Skip to content

Support dynamically creating tailored continuation layouts - #120411

Merged
jakobbotsch merged 51 commits into
dotnet:mainfrom
jakobbotsch:tailored-continuation-layouts
Oct 18, 2025
Merged

Support dynamically creating tailored continuation layouts#120411
jakobbotsch merged 51 commits into
dotnet:mainfrom
jakobbotsch:tailored-continuation-layouts

Conversation

@jakobbotsch

@jakobbotschjakobbotsch commented Oct 4, 2025

Copy link
Copy Markdown
Member

Add ability for the VM to dynamically create continuation layout types and for the JIT to request such types to be created.

@jakobbotsch
Initial
7d27090
@jakobbotsch
Fix build, make tests run
6743534
@jakobbotsch
Tailored continuation layouts
0f8cd9c
Add ability for the VM to dynamically create continuation layout types
and for the JIT to request such types to be created.
@jakobbotsch
Update type
a642f42
@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 4, 2025
@dotnet-policy-service

dotnet-policy-serviceBot commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

jkotas
jkotas reviewed Oct 5, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/jitinterface.cpp Outdated
jkotas
jkotas reviewed Oct 5, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/methodtable.h Outdated
@jakobbotschjakobbotsch mentioned this pull request Oct 7, 2025
Merged
jakobbotsch
jakobbotsch commented Oct 7, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/jitinterface.cpp Outdated
jkotas
jkotas reviewed Oct 7, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/jitinterface.cpp Outdated
jkotas
jkotas reviewed Oct 7, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/methodtable.cpp Outdated
jakobbotsch
jakobbotsch commented Oct 7, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/methodtable.inl Outdated
jkotas
jkotas reviewed Oct 16, 2025
View reviewed changes
Comment threadsrc/coreclr/inc/corinfo.h Outdated
jkotas
jkotas reviewed Oct 16, 2025
View reviewed changes
Comment threadsrc/coreclr/jit/async.cpp
jkotas
jkotas reviewed Oct 16, 2025
View reviewed changes
Comment threadsrc/coreclr/inc/corinfo.h Outdated
noahfalk
noahfalk reviewed Oct 17, 2025
View reviewed changes

@noahfalknoahfalk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me modulo making RuntimeAsync on by default. If there is a need to get it on by default regardless of the diagnostics I'd suggest we do it in a separate PR.

Comment threadsrc/coreclr/inc/clrconfigvalues.h Outdated
This was referenced Oct 17, 2025
Open
Open
AndyAyersMS
AndyAyersMS reviewed Oct 17, 2025
View reviewed changes

@AndyAyersMSAndyAyersMS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JIT changes look good.

@build-analysisbuild-analysisBot mentioned this pull request Oct 17, 2025
Open
@jakobbotschjakobbotsch mentioned this pull request Oct 17, 2025
Closed
@jkotasjkotas mentioned this pull request Oct 18, 2025
Merged
jkotas
jkotas reviewed Oct 18, 2025
View reviewed changes
Comment threadsrc/coreclr/inc/corinfo.h Outdated
jkotas
jkotas approved these changes Oct 18, 2025
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

noahfalk
noahfalk approved these changes Oct 18, 2025
View reviewed changes

@noahfalknoahfalk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto!

VSadov
VSadov approved these changes Oct 18, 2025
View reviewed changes

@VSadovVSadov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!!

Comment threadsrc/coreclr/vm/asyncthunks.cpp
Comment threadsrc/coreclr/vm/jitinterface.cpp
Comment threadsrc/coreclr/vm/corelib.h
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs
@jakobbotschjakobbotsch mentioned this pull request Oct 18, 2025
Closed
@jakobbotsch

jakobbotsch commented Oct 18, 2025

Copy link
Copy Markdown
MemberAuthor

Some numbers for the micro benchmark in #120865 (comment) that measures raw suspension/resumption performance, with 10 million iterations:

Before the change: Took 596.9 ms
After the change: Took 558.0 ms
Async1 for comparison: Took 332.1 ms

@jakobbotsch
jakobbotsch merged commit c928a95 into dotnet:mainOct 18, 2025
148 of 150 checks passed
@jakobbotsch
jakobbotsch deleted the tailored-continuation-layouts branch October 18, 2025 14:59
@build-analysisbuild-analysisBot mentioned this pull request Oct 18, 2025
Closed
@dotnet-maestrodotnet-maestroBot mentioned this pull request Oct 21, 2025
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Nov 18, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky left review comments
@AndyAyersMSAndyAyersMSAndyAyersMS left review comments
@davidwrightondavidwrightondavidwrighton left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@jkotasjkotasjkotas approved these changes
@VSadovVSadovVSadov approved these changes
@tommcdontommcdonAwaiting requested review from tommcdon
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@jakobbotschjakobbotsch

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jakobbotsch@noahfalk@jkotas@jkoritzinsky@VSadov@AndyAyersMS@davidwrighton