Skip to content

[wasm][coreclr] Implement RhpNewArrayFastAlign8 - #120690

Merged
radekdoulik merged 8 commits into
dotnet:mainfrom
radekdoulik:clr-interp-wasm-RhpNewArrayFastAlign8
Oct 16, 2025
Merged

[wasm][coreclr] Implement RhpNewArrayFastAlign8#120690
radekdoulik merged 8 commits into
dotnet:mainfrom
radekdoulik:clr-interp-wasm-RhpNewArrayFastAlign8

Conversation

@radekdoulik

Copy link
Copy Markdown
Member

Resolves#120659

@radekdoulik
radekdoulik requested review from AaronRobinsonMSFT and Copilot and removed request for CopilotOctober 14, 2025 07:58
@github-actionsgithub-actionsBot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 14, 2025
@radekdoulikradekdoulik added arch-wasm WebAssembly architecture area-VM-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 14, 2025
@radekdoulikradekdoulik added this to the 11.0.0 milestone Oct 14, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Comment threadsrc/coreclr/runtime/portable/AllocFast.cpp Outdated
Comment threadsrc/coreclr/runtime/portable/AllocFast.cpp Outdated
CopilotAI review requested due to automatic review settings October 14, 2025 15:10

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the RhpNewArrayFastAlign8 function for WASM and CoreCLR, resolving issue #120659. The implementation enables aligned memory allocation for arrays that require 8-byte alignment, particularly for long and double arrays on 32-bit platforms.

Key changes:

  • Implements the RhpNewArrayFastAlign8 function with proper alignment logic
  • Refactors existing allocation code to improve maintainability
  • Removes WASM-specific test exclusions that are no longer needed

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
src/coreclr/runtime/portable/AllocFast.cppImplements RhpNewArrayFastAlign8 function and refactors allocation helpers
src/tests/JIT/interpreter/Interpreter.csRemoves WASM architecture exclusions for long and double array tests

Comment threadsrc/coreclr/runtime/portable/AllocFast.cpp Outdated
Comment threadsrc/coreclr/runtime/portable/AllocFast.cpp
Comment threadsrc/coreclr/runtime/portable/AllocFast.cpp
radekdoulikand others added 2 commits October 14, 2025 19:15
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Comment threadsrc/coreclr/runtime/portable/AllocFast.cpp Outdated

@AaronRobinsonMSFTAaronRobinsonMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. I'm like to try and remove some of the "magic" numbers in NewArrayFastAlign8Core. There must be some simple macros or computation to get them.

Comment threadsrc/coreclr/runtime/portable/AllocFast.cpp
Comment threadsrc/coreclr/runtime/portable/AllocFast.cpp
Comment threadsrc/coreclr/runtime/portable/AllocFast.cpp Outdated
Comment threadsrc/coreclr/runtime/portable/AllocFast.cpp Outdated
Comment threadsrc/coreclr/runtime/portable/AllocFast.cpp Outdated
Comment threadsrc/coreclr/runtime/portable/AllocFast.cpp Outdated
radekdoulikand others added 2 commits October 15, 2025 18:24
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
radekdoulik enabled auto-merge (squash) October 15, 2025 16:37
Comment threadsrc/coreclr/runtime/portable/AllocFast.cpp Outdated
@radekdoulik
radekdoulik merged commit 878667d into dotnet:mainOct 16, 2025
103 checks passed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Nov 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-VM-coreclr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wasm][coreclr] implement RhpNewArrayFastAlign8

4 participants

@radekdoulik@jkotas@AaronRobinsonMSFT