Skip to content

[wasm][coreclr] Allow memory growth for corerun - #120844

Merged
radekdoulik merged 2 commits into
dotnet:mainfrom
radekdoulik:clr-interp-wasm-emscripten-options-update
Oct 17, 2025
Merged

[wasm][coreclr] Allow memory growth for corerun#120844
radekdoulik merged 2 commits into
dotnet:mainfrom
radekdoulik:clr-interp-wasm-emscripten-options-update

Conversation

@radekdoulik

Copy link
Copy Markdown
Member

Also remove table growth option from browserhost, we don't need it as we don't have jiterpreter

Also remove table growth option from browserhost, we don't need it as
we don't have jiterpreter

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables WebAssembly memory growth in the corerun host and removes table growth from the browserhost configuration as it is no longer needed without jiterpreter.

  • Added -sALLOW_MEMORY_GROWTH=1 to corerun build.
  • Removed -sALLOW_TABLE_GROWTH=1 from browserhost link options.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
src/native/corehost/browserhost/CMakeLists.txtRemoves table growth flag to simplify browserhost configuration.
src/coreclr/hosts/corerun/CMakeLists.txtAdds memory growth flag to allow dynamic heap expansion for corerun.

Comment threadsrc/coreclr/hosts/corerun/CMakeLists.txt
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Comment threadsrc/native/corehost/browserhost/CMakeLists.txt
@radekdoulik
radekdoulik merged commit bd5dc33 into dotnet:mainOct 17, 2025
108 of 110 checks passed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Nov 17, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-Host

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@radekdoulik@pavelsavara