Uh oh!
There was an error while loading. Please reload this page.
Disable CoreCLR tests crashing merged test suites fully interpreted - #120911
Conversation
This change disables all coreclr tests that cause the merged coreclr test suites to crash and so preventing us from getting any test pass / fail information from those. This is with running the tests with InterpMode=3 (fully interpreted) This was put together on Windows x64 checked build, we may need to add more for other targets in a separate PR.
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
There was a problem hiding this comment.
Pull Request Overview
This PR disables CoreCLR tests that crash when running merged test suites in fully interpreted mode (InterpMode=3), preventing the collection of test results. The changes add SkipOnCoreClrAttribute annotations to tests that fail intermittently with access violations or run indefinitely under the interpreter, all referencing tracking issue #120904.
Key Changes:
- Disabled 30 threading tests (thread01-thread30) that fail with intermittent AVs
- Disabled exception interop tests unsupported by the interpreter
- Disabled performance/stress tests that run indefinitely when interpreted
- Added project references where needed to support the skip attributes
Reviewed Changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| thread01-30.cs | Added skip attributes for tests failing intermittently with AV under interpreter |
| ExceptionInterop.cs | Skipped exception interop tests incompatible with interpreter |
| Test111242.csproj | Marked SetJmp/LongJmp test as interpreter-incompatible |
| RngchkStress3.cs/.csproj | Skipped range check stress test that runs forever when interpreted |
| Sums.cs | Skipped SIMD sum test that runs forever when interpreted |
| GitHub_19438.cs | Skipped performance test that runs forever when interpreted |
| b609988.il and b609988_Desktop.il | Added skip attributes to IL tests causing AVs under interpreter |
| ConsoleMandel.cs | Skipped Mandelbrot test that runs forever when interpreted |
| reference_i.il | Skipped tailcall test causing AVs under interpreter |
| out_of_range_fp_to_int_conversions.cs/.csproj | Skipped conversion test that runs forever when interpreted |
| PassingByRefTest.cs | Skipped reverse P/Invoke test with unsupported exception propagation |
| IEnumeratorTest.cs | Skipped COM interop tests asserting on thunkData with interpreter |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
davidwrighton
commented
Oct 20, 2025
Copilot issues appear to be real issues. Please address them. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
agocke
commented
Oct 22, 2025
@janvorli it looks like this broke the native aot test runs. Can you take a look? |
jkotas
commented
Oct 22, 2025
I am going to take care of whatever broke in NativeAOT runs in #119878. |
Also, note that there is a break introduced by Windows update applied to test machines that is starting to show up in CI, including native AOT runs: #120974 . (I am not planning to work on that.) |
This change disables all coreclr tests that cause the merged coreclr test suites to crash and so preventing us from getting any test pass / fail information from those. This is with running the tests with InterpMode=3 (fully interpreted)
This was put together on Windows x64 checked build, we may need to add more for other targets in a separate PR.
The disabled tests comment includes basic info on the failure / crash.