Uh oh!
There was an error while loading. Please reload this page.
[browser][coreCLR] async main, thread pool, timers - #120976
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
pavelsavara
commented
Nov 3, 2025
is there more feedback ? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…erServices/AsyncHelpers.NonBrowser.cs Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…erServices/AsyncHelpers.NonBrowser.cs Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
…erServices/AsyncHelpers.NonBrowser.cs Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
gewarren
left a comment
There was a problem hiding this comment.
Left some doc suggestions.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jkotas
commented
Nov 3, 2025
LGTM (the parts that I understand). Somebody with understanding of the JavaScript layer should review and signoff on that part. |
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
pavelsavara
commented
Nov 4, 2025
/ba-g CI timeouts and #114924 |
work in progress:
-sEXIT_RUNTIME=0for coreRun toocoreclr_shutdown2_funcin coreRun/browserHostAsyncHelpers.Browser.cswithExecuteAsyncEntryPointthat would callSystemJS_RejectMainPromiseorSystemJS_ResolveMainPromiseAssembly::GetEntryPointto find original asyncMain()TaskAwaiter<int>.GetResult()which is not possible on ST browser.MemberLoader::FindMethodByNameby original name, but ignoring return typeValidateMainMethodto allow for signatures withTaskorTask<int>CorEntryPointType.EntryManagedMainAsyncandCorEntryPointType.EntryManagedMainAsyncVoidSystemJS_ExecuteTimerCallbackandSystemJS_ExecuteBackgroundJobCallback[UnmanagedCallersOnly]src\coreclr\vm\wasm\helpers.cppandsrc\coreclr\vm\corelib.hfor nowFixes#120212
Fixes#120211
Fixes#121046
This work with the PR
TODO
Task Main()of void signature.