Uh oh!
There was an error while loading. Please reload this page.
Fix SPMI assert - #121051
Merged
Merged
Conversation
`repGetCookieForPInvokeCalliSig` was asserting for the wrong map, and so collection cleaning ended up throwing away a bunch of good method contexts. Fix and add the corresponding assert to `repGetCookieForInterpreterCalliSig`.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an incorrect assertion in SPMI (SuperPMI) that was causing valid method contexts to be discarded during collection cleaning. The fix corrects the map validation in repGetCookieForPInvokeCalliSig and adds the missing assertion to repGetCookieForInterpreterCalliSig for consistency.
Key changes:
- Fixed incorrect map assertion in
repGetCookieForPInvokeCalliSig(was checking wrong map) - Added missing map assertion to
repGetCookieForInterpreterCalliSig
AndyAyersMS
commented
Oct 23, 2025
MemberAuthor
@dotnet/jit-contrib PTAL |
jakobbotsch
approved these changes
Oct 24, 2025
kg
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repGetCookieForPInvokeCalliSigwas asserting for the wrong map, and so collection cleaning ended up throwing away a bunch of good method contexts.Fix and add the corresponding assert to
repGetCookieForInterpreterCalliSig.