Skip to content

Remove all-arch condition in tryrun - #121071

Merged
jkoritzinsky merged 2 commits into
dotnet:mainfrom
am11:patch-42
Oct 24, 2025
Merged

Remove all-arch condition in tryrun#121071
jkoritzinsky merged 2 commits into
dotnet:mainfrom
am11:patch-42

Conversation

@am11

@am11am11 commented Oct 24, 2025

Copy link
Copy Markdown
Member

This was including all arch in match, which makes no sense. Noticed while syncing configs downstream dotnet/diagnostics#5612.

@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Oct 24, 2025
@github-actionsgithub-actionsBot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 24, 2025
@am11am11 added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 24, 2025
@dotnet-policy-service

dotnet-policy-serviceBot commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@am11am11 mentioned this pull request Oct 24, 2025
Open
janvorli
janvorli approved these changes Oct 24, 2025
View reviewed changes

@janvorlijanvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Comment threadeng/native/tryrun.cmake
@jkoritzinsky
jkoritzinsky enabled auto-merge (squash) October 24, 2025 18:35
@jkoritzinsky
jkoritzinsky merged commit eb63c0e into dotnet:mainOct 24, 2025
150 checks passed
@am11
am11 deleted the patch-42 branch October 24, 2025 19:22
@dotnet-maestrodotnet-maestroBot mentioned this pull request Oct 28, 2025
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Nov 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@janvorlijanvorlijanvorli approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

Assignees

No one assigned

Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

Runtime Infra
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@am11@jkoritzinsky@janvorli