Skip to content

Port coreclr interpreter to riscv64 - #121276

Merged
janvorli merged 13 commits into
dotnet:mainfrom
am11:feature/interp/riscv64-port
Nov 10, 2025
Merged

Port coreclr interpreter to riscv64#121276
janvorli merged 13 commits into
dotnet:mainfrom
am11:feature/interp/riscv64-port

Conversation

@am11

@am11am11 commented Nov 2, 2025

Copy link
Copy Markdown
Member

No description provided.

@am11
am11 requested review from filipnavara and removed request for MichalStrehovskyNovember 2, 2025 14:33
@am11
am11 requested a review from janvorliNovember 2, 2025 14:33
@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Nov 2, 2025
@am11
am11 requested a review from a teamNovember 2, 2025 14:33
@am11

am11 commented Nov 2, 2025

Copy link
Copy Markdown
MemberAuthor

@jkoritzinsky, this is an initial interpreter port. I wasn't able to run InterpreterTester since src/tests build is broken with --bootstrap: #115622 (comment).

This was referenced Nov 2, 2025
Open
Closed
Closed
tomeksowi
tomeksowi reviewed Nov 3, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/riscv64/asmhelpers.S
tomeksowi
tomeksowi reviewed Nov 3, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/riscv64/asmhelpers.S Outdated
Comment threadsrc/coreclr/vm/riscv64/asmhelpers.S Outdated
Comment threadsrc/coreclr/vm/riscv64/asmhelpers.S Outdated
Comment threadsrc/coreclr/vm/riscv64/asmhelpers.S Outdated
am11
am11 commented Nov 3, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/callstubgenerator.cpp Outdated
tomeksowi
tomeksowi reviewed Nov 3, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/callstubgenerator.cpp Outdated
am11and others added 2 commits November 3, 2025 15:47
@am11@tomeksowi
Update src/coreclr/vm/callstubgenerator.cpp
af669ef
Co-authored-by: Tomasz Sowiński <tomeksowi@gmail.com>
@am11
Add scope
6c595de
@am11

am11 commented Nov 3, 2025

Copy link
Copy Markdown
MemberAuthor

@janvorli, PTAL. Bulk change for the initial port. Testing is currently blocked #115622 (comment), so I couldn’t run tests yet. This is a good checkpoint; follow-up updates will be small and incremental.

riscv64 leg is now green, remaining failures are unrelated.

janvorli
janvorli reviewed Nov 5, 2025
View reviewed changes
Comment threadsrc/coreclr/debug/CMakeLists.txt
janvorli
janvorli approved these changes Nov 5, 2025
View reviewed changes

@janvorlijanvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@am11

am11 commented Nov 10, 2025

Copy link
Copy Markdown
MemberAuthor

@janvorli, could you please merge this?

@janvorli

janvorli commented Nov 10, 2025

Copy link
Copy Markdown
Member

/ba-g the failures are know and the android build has been failing on multiple PRs too.

@janvorli
janvorli merged commit 61bb961 into dotnet:mainNov 10, 2025
134 of 140 checks passed
@am11
am11 deleted the feature/interp/riscv64-port branch November 10, 2025 20:49
@dotnet-maestrodotnet-maestroBot mentioned this pull request Nov 11, 2025
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 11, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janvorlijanvorlijanvorli approved these changes
@filipnavarafilipnavaraAwaiting requested review from filipnavara
+1 more reviewer
@tomeksowitomeksowitomeksowi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-Interpreter-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@am11@janvorli@tomeksowi