Skip to content

[release/8.0-staging] Add required MSBuild package dependencies - #121307

Merged
ericstj merged 1 commit into
dotnet:release/8.0-stagingfrom
NikolaMilosavljevic:msbuild.deps
Nov 4, 2025
Merged

[release/8.0-staging] Add required MSBuild package dependencies#121307
ericstj merged 1 commit into
dotnet:release/8.0-stagingfrom
NikolaMilosavljevic:msbuild.deps

Conversation

@NikolaMilosavljevic

Copy link
Copy Markdown
Contributor

Backport of https://github.com/dotnet/installer/blob/release/8.0.1xx/src/SourceBuild/patches/runtime/0002-Update-MSBuild-dependencies.patch

Fixes: #101395

Source-build requires explicit package versions and references for all dependencies. This PR backports the long-standing patch. It would help avoid issues with frequent patch updates.

CopilotAI review requested due to automatic review settings November 3, 2025 17:05
@NikolaMilosavljevicNikolaMilosavljevic added the Servicing-consider Issue for next servicing release review label Nov 3, 2025

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Microsoft.Build package references by replacing version variable references with hardcoded version strings and adds explicit dependency tracking entries.

Key Changes

  • Replaced MSBuild version variables ($(MicrosoftBuildVersion)) with hardcoded version string 17.8.3 for three MSBuild components
  • Added explicit dependency tracking entries in Version.Details.xml for the three MSBuild packages

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
eng/Versions.propsReplaced variable references with hardcoded version 17.8.3 for MSBuild Tasks, Framework, and Utilities packages
eng/Version.Details.xmlAdded dependency tracking entries for MSBuild Framework, Tasks Core, and Utilities Core packages

Comment threadeng/Versions.props
@NikolaMilosavljevic

Copy link
Copy Markdown
ContributorAuthor

Marking as Servicing-approved as this is an infra-only change.

@NikolaMilosavljevicNikolaMilosavljevic added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 3, 2025
@NikolaMilosavljevicNikolaMilosavljevic changed the title Add required MSBuild package dependencies[release/8.0-staging] Add required MSBuild package dependenciesNov 3, 2025
@NikolaMilosavljevic

Copy link
Copy Markdown
ContributorAuthor

Test failures seem to be the same as those seen in other PRs, i.e. #121150

One example:

 System.Security.Cryptography.X509Certificates.Tests.ChainTests.BuildChain [FAIL]
Chain built validly
Expected: True
Actual: False
Stack Trace:
/_/src/libraries/System.Security.Cryptography/tests/X509Certificates/ChainTests.cs(57,0): at System.Security.Cryptography.X509Certificates.Tests.ChainTests.BuildChain()

@bartonjs@vcsjones is this issue tracked somewhere? Test failure

@bartonjs

Copy link
Copy Markdown
Member

@NikolaMilosavljevic looks like #120527

@NikolaMilosavljevic

Copy link
Copy Markdown
ContributorAuthor

All errors in checks are unrelated to my changes. Can this be merged now?

@akoeplinger@ericstj

@ericstj

Copy link
Copy Markdown
Member

/ba-g build timeouts

@ericstj
ericstj merged commit b1248f2 into dotnet:release/8.0-stagingNov 4, 2025
189 of 201 checks passed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 5, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Servicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@NikolaMilosavljevic@bartonjs@ericstj@akoeplinger