[Wasm RyuJIT] Wasm control flow basics - #121417

Merged
AndyAyersMS merged 9 commits into
dotnet:mainfrom
AndyAyersMS:WasmControlFlowBasics
Nov 14, 2025
Merged

[Wasm RyuJIT] Wasm control flow basics#121417
AndyAyersMS merged 9 commits into
dotnet:mainfrom
AndyAyersMS:WasmControlFlowBasics

Conversation

@AndyAyersMS

Copy link
Copy Markdown
Member

Determine how to emit Wasm control flow from the JIT's control flow graph.

Relies on loop-aware RPO to determine the block order. Currently only handles the main method. Assumes irreducible loops have been fixed upstream (which is not yet guaranteed; bails out if not so).

Doesn't actually do any emission, just prints a textual description in the JIT dump (along with a dot markup version).

Uses only LOOP and BLOCK. Tries to limit the extent of BLOCK.

Run for now as an optional phase even if not targeting Wasm, to do some stress testing.

Contributes to #121178

Determine how to emit Wasm control flow from the JIT's control flow graph.
Relies on loop-aware RPO to determine the block order. Currently only
handles the main method. Assumes irreducible loops have been fixed
upstream (which is not yet guaranteed; bails out if not so).
Doesn't actually do any emission, just prints a textual description in
the JIT dump (along with a dot markup version).
Uses only LOOP and BLOCK. Tries to limit the extent of BLOCK.
Run for now as an optional phase even if not targeting Wasm, to
do some stress testing.
Contributes to dotnet#121178
@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 6, 2025
@AndyAyersMS

AndyAyersMS commented Nov 6, 2025

Copy link
Copy Markdown
MemberAuthor

FYI @dotnet/jit-contrib @SingleAccretion a first cut at wasm control flow. Eventually the text emission will end up being part of emitwasm (and in binary, with text disasm) and not part of this phase.

Left: sample control flow graph. Black are Wasm blocks, red are Wasm loops.

Right: sample Wasm instruction stream (block contents not shown, just BBxx).

image (49) BB01
FALLTHROUGH

BLOCK (13)
BLOCK (12)
BLOCK (8)
BLOCK (4)
BB04
BR_IF 0 (4)
FALLTHROUGH

LOOP (4)
BB33
BR_IF 2 (8)
FALLTHROUGH

BB07
BR_IF 0 (2)be
FALLTHROUGH

END (4) LOOP
END (4)
BLOCK (7)
BB09
BR_IF 0 (7)
FALLTHROUGH

BB10
BR_IF 1 (8)
FALLTHROUGH

BB12
FALLTHROUGH

END (7)
BB19
BR 1 (12)

END (8)
BB21

BB22
FALLTHROUGH

BB16
FALLTHROUGH-inv
BR_IF-inv 1 (13)

BB30
FALLTHROUGH

END (12)
BB02
RETURN

END (13)
BB29
THROW

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

The

FALLTHROUGH-inv
BR_IF-inv 1 (13)

above is a reminder we need to invert the branch condition (not yet done).

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

Think this is ready for review. There could still be bugs in the control flow, but hard to be sure until we can actually generate code.

Errors seem to be all known or timeouts.

@AndyAyersMS
AndyAyersMS marked this pull request as ready for review November 6, 2025 23:48
CopilotAI review requested due to automatic review settings November 6, 2025 23:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new experimental Wasm control flow simulation phase to the JIT compiler. The phase analyzes the control flow graph and simulates how Wasm BLOCK/END and LOOP/END control structures would be emitted for the method being compiled.

  • Introduces a new fgWasmControlFlow phase that transforms the control flow graph into Wasm-style nested control structures
  • Adds a JitWasmControlFlow configuration option to enable/disable this experimental feature (DEBUG builds only)
  • Implements an interval-based algorithm to properly nest blocks and loops according to Wasm requirements

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
FileDescription
src/coreclr/jit/jitconfigvalues.hAdds the JitWasmControlFlow configuration integer to control the new phase
src/coreclr/jit/fgwasm.cppNew file implementing the Wasm control flow analysis and simulation algorithm
src/coreclr/jit/compphases.hRegisters the PHASE_WASM_CONTROL_FLOW phase
src/coreclr/jit/compmemkind.hAdds CMK_Wasm memory kind for allocations
src/coreclr/jit/compiler.hDeclares the fgWasmControlFlow method
src/coreclr/jit/compiler.cppInvokes the new phase conditionally in DEBUG builds after loop alignment
src/coreclr/jit/CMakeLists.txtAdds fgwasm.cpp to the build sources

Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
@AndyAyersMS
AndyAyersMS requested a review from a teamNovember 7, 2025 15:31
@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib PTAL

@am11am11 added the arch-wasm WebAssembly architecture label Nov 7, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib ping

Comment threadsrc/coreclr/jit/compmemkind.h Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp
@kg

kg commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

LGTM but I'll leave the green check to someone who knows the JIT better

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

I should do a run where I enable this in release just to see the TP impact... will do that locally and report back.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

I should do a run where I enable this in release just to see the TP impact... will do that locally and report back.

Enabling this in release, it has about a 0.5-0.9% TP hit. Worst-case was benchmaks.pgo at 0.92.

Restricting the analysis to running just on methods with optimization (as it will be doing mostly, R2R code is optimized) drops this to 0.55%.

Breaking it down by stages

DFS 0.14%
+ Loops 0.22%
+ LaRPO 0.27%
+ Intervals 0.36%
+ Conflicts 0.50%
+ Sort 0.53%
+ "codegen" 0.55%

so no clear bottleneck.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

The new phase is now disabled. I will create a wasm test pipeline where we can enable this.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

/ba-g one test failed with Half-way through waiting for remote process. Memory load: 18

Unrelated

@AndyAyersMS
AndyAyersMS merged commit b435b40 into dotnet:mainNov 14, 2025
109 of 112 checks passed
AndyAyersMS added a commit that referenced this pull request Nov 18, 2025
Loops for Wasm control flow codegen don't involve EH or runtime mediated
control flow transfers.
Implement a custom block successor enumerator for Wasm, and adjust
`fgRunDFS`
to allow using this and also to generalize how the DFS is initiated. Use
this to build a "Wasm" DFS. In that DFS handle both the main method and
all funclets (by specifying funclet entries as additional DFS starting
points).
Update the loop finding code to make suitable changes when it is driven
from
a "Wasm" DFS instead of the typical all successor / all predecessor DFS.
Remove the restriction in the Wasm control flow codegen that only
handles
the main method; now it works for the main method and all funclets.
Contributes to #121178.
Dependent on #121417.
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@AndyAyersMSAndyAyersMS mentioned this pull request Nov 19, 2025
12 tasks
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@AndyAyersMS@kg@jakobbotsch@SingleAccretion@am11
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

[Wasm RyuJIT] Wasm control flow basics - #121417

Merged
AndyAyersMS merged 9 commits into
dotnet:mainfrom
AndyAyersMS:WasmControlFlowBasics
Nov 14, 2025
Merged

[Wasm RyuJIT] Wasm control flow basics#121417
AndyAyersMS merged 9 commits into
dotnet:mainfrom
AndyAyersMS:WasmControlFlowBasics

Conversation

@AndyAyersMS

Copy link
Copy Markdown
Member

Determine how to emit Wasm control flow from the JIT's control flow graph.

Relies on loop-aware RPO to determine the block order. Currently only handles the main method. Assumes irreducible loops have been fixed upstream (which is not yet guaranteed; bails out if not so).

Doesn't actually do any emission, just prints a textual description in the JIT dump (along with a dot markup version).

Uses only LOOP and BLOCK. Tries to limit the extent of BLOCK.

Run for now as an optional phase even if not targeting Wasm, to do some stress testing.

Contributes to #121178

Determine how to emit Wasm control flow from the JIT's control flow graph.
Relies on loop-aware RPO to determine the block order. Currently only
handles the main method. Assumes irreducible loops have been fixed
upstream (which is not yet guaranteed; bails out if not so).
Doesn't actually do any emission, just prints a textual description in
the JIT dump (along with a dot markup version).
Uses only LOOP and BLOCK. Tries to limit the extent of BLOCK.
Run for now as an optional phase even if not targeting Wasm, to
do some stress testing.
Contributes to dotnet#121178
@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 6, 2025
@AndyAyersMS

AndyAyersMS commented Nov 6, 2025

Copy link
Copy Markdown
MemberAuthor

FYI @dotnet/jit-contrib @SingleAccretion a first cut at wasm control flow. Eventually the text emission will end up being part of emitwasm (and in binary, with text disasm) and not part of this phase.

Left: sample control flow graph. Black are Wasm blocks, red are Wasm loops.

Right: sample Wasm instruction stream (block contents not shown, just BBxx).

image (49) BB01
FALLTHROUGH

BLOCK (13)
BLOCK (12)
BLOCK (8)
BLOCK (4)
BB04
BR_IF 0 (4)
FALLTHROUGH

LOOP (4)
BB33
BR_IF 2 (8)
FALLTHROUGH

BB07
BR_IF 0 (2)be
FALLTHROUGH

END (4) LOOP
END (4)
BLOCK (7)
BB09
BR_IF 0 (7)
FALLTHROUGH

BB10
BR_IF 1 (8)
FALLTHROUGH

BB12
FALLTHROUGH

END (7)
BB19
BR 1 (12)

END (8)
BB21

BB22
FALLTHROUGH

BB16
FALLTHROUGH-inv
BR_IF-inv 1 (13)

BB30
FALLTHROUGH

END (12)
BB02
RETURN

END (13)
BB29
THROW

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

The

FALLTHROUGH-inv
BR_IF-inv 1 (13)

above is a reminder we need to invert the branch condition (not yet done).

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

Think this is ready for review. There could still be bugs in the control flow, but hard to be sure until we can actually generate code.

Errors seem to be all known or timeouts.

@AndyAyersMS
AndyAyersMS marked this pull request as ready for review November 6, 2025 23:48
CopilotAI review requested due to automatic review settings November 6, 2025 23:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new experimental Wasm control flow simulation phase to the JIT compiler. The phase analyzes the control flow graph and simulates how Wasm BLOCK/END and LOOP/END control structures would be emitted for the method being compiled.

  • Introduces a new fgWasmControlFlow phase that transforms the control flow graph into Wasm-style nested control structures
  • Adds a JitWasmControlFlow configuration option to enable/disable this experimental feature (DEBUG builds only)
  • Implements an interval-based algorithm to properly nest blocks and loops according to Wasm requirements

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
FileDescription
src/coreclr/jit/jitconfigvalues.hAdds the JitWasmControlFlow configuration integer to control the new phase
src/coreclr/jit/fgwasm.cppNew file implementing the Wasm control flow analysis and simulation algorithm
src/coreclr/jit/compphases.hRegisters the PHASE_WASM_CONTROL_FLOW phase
src/coreclr/jit/compmemkind.hAdds CMK_Wasm memory kind for allocations
src/coreclr/jit/compiler.hDeclares the fgWasmControlFlow method
src/coreclr/jit/compiler.cppInvokes the new phase conditionally in DEBUG builds after loop alignment
src/coreclr/jit/CMakeLists.txtAdds fgwasm.cpp to the build sources

Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
@AndyAyersMS
AndyAyersMS requested a review from a teamNovember 7, 2025 15:31
@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib PTAL

@am11am11 added the arch-wasm WebAssembly architecture label Nov 7, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib ping

Comment threadsrc/coreclr/jit/compmemkind.h Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp
@kg

kg commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

LGTM but I'll leave the green check to someone who knows the JIT better

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

I should do a run where I enable this in release just to see the TP impact... will do that locally and report back.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

I should do a run where I enable this in release just to see the TP impact... will do that locally and report back.

Enabling this in release, it has about a 0.5-0.9% TP hit. Worst-case was benchmaks.pgo at 0.92.

Restricting the analysis to running just on methods with optimization (as it will be doing mostly, R2R code is optimized) drops this to 0.55%.

Breaking it down by stages

DFS 0.14%
+ Loops 0.22%
+ LaRPO 0.27%
+ Intervals 0.36%
+ Conflicts 0.50%
+ Sort 0.53%
+ "codegen" 0.55%

so no clear bottleneck.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

The new phase is now disabled. I will create a wasm test pipeline where we can enable this.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

/ba-g one test failed with Half-way through waiting for remote process. Memory load: 18

Unrelated

@AndyAyersMS
AndyAyersMS merged commit b435b40 into dotnet:mainNov 14, 2025
109 of 112 checks passed
AndyAyersMS added a commit that referenced this pull request Nov 18, 2025
Loops for Wasm control flow codegen don't involve EH or runtime mediated
control flow transfers.
Implement a custom block successor enumerator for Wasm, and adjust
`fgRunDFS`
to allow using this and also to generalize how the DFS is initiated. Use
this to build a "Wasm" DFS. In that DFS handle both the main method and
all funclets (by specifying funclet entries as additional DFS starting
points).
Update the loop finding code to make suitable changes when it is driven
from
a "Wasm" DFS instead of the typical all successor / all predecessor DFS.
Remove the restriction in the Wasm control flow codegen that only
handles
the main method; now it works for the main method and all funclets.
Contributes to #121178.
Dependent on #121417.
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@AndyAyersMSAndyAyersMS mentioned this pull request Nov 19, 2025
12 tasks
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@AndyAyersMS@kg@jakobbotsch@SingleAccretion@am11
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[Wasm RyuJIT] Wasm control flow basics - #121417

Merged
AndyAyersMS merged 9 commits into
dotnet:mainfrom
AndyAyersMS:WasmControlFlowBasics
Nov 14, 2025
Merged

[Wasm RyuJIT] Wasm control flow basics#121417
AndyAyersMS merged 9 commits into
dotnet:mainfrom
AndyAyersMS:WasmControlFlowBasics

Conversation

@AndyAyersMS

Copy link
Copy Markdown
Member

Determine how to emit Wasm control flow from the JIT's control flow graph.

Relies on loop-aware RPO to determine the block order. Currently only handles the main method. Assumes irreducible loops have been fixed upstream (which is not yet guaranteed; bails out if not so).

Doesn't actually do any emission, just prints a textual description in the JIT dump (along with a dot markup version).

Uses only LOOP and BLOCK. Tries to limit the extent of BLOCK.

Run for now as an optional phase even if not targeting Wasm, to do some stress testing.

Contributes to #121178

Determine how to emit Wasm control flow from the JIT's control flow graph.
Relies on loop-aware RPO to determine the block order. Currently only
handles the main method. Assumes irreducible loops have been fixed
upstream (which is not yet guaranteed; bails out if not so).
Doesn't actually do any emission, just prints a textual description in
the JIT dump (along with a dot markup version).
Uses only LOOP and BLOCK. Tries to limit the extent of BLOCK.
Run for now as an optional phase even if not targeting Wasm, to
do some stress testing.
Contributes to dotnet#121178
@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 6, 2025
@AndyAyersMS

AndyAyersMS commented Nov 6, 2025

Copy link
Copy Markdown
MemberAuthor

FYI @dotnet/jit-contrib @SingleAccretion a first cut at wasm control flow. Eventually the text emission will end up being part of emitwasm (and in binary, with text disasm) and not part of this phase.

Left: sample control flow graph. Black are Wasm blocks, red are Wasm loops.

Right: sample Wasm instruction stream (block contents not shown, just BBxx).

image (49) BB01
FALLTHROUGH

BLOCK (13)
BLOCK (12)
BLOCK (8)
BLOCK (4)
BB04
BR_IF 0 (4)
FALLTHROUGH

LOOP (4)
BB33
BR_IF 2 (8)
FALLTHROUGH

BB07
BR_IF 0 (2)be
FALLTHROUGH

END (4) LOOP
END (4)
BLOCK (7)
BB09
BR_IF 0 (7)
FALLTHROUGH

BB10
BR_IF 1 (8)
FALLTHROUGH

BB12
FALLTHROUGH

END (7)
BB19
BR 1 (12)

END (8)
BB21

BB22
FALLTHROUGH

BB16
FALLTHROUGH-inv
BR_IF-inv 1 (13)

BB30
FALLTHROUGH

END (12)
BB02
RETURN

END (13)
BB29
THROW

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

The

FALLTHROUGH-inv
BR_IF-inv 1 (13)

above is a reminder we need to invert the branch condition (not yet done).

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

Think this is ready for review. There could still be bugs in the control flow, but hard to be sure until we can actually generate code.

Errors seem to be all known or timeouts.

@AndyAyersMS
AndyAyersMS marked this pull request as ready for review November 6, 2025 23:48
CopilotAI review requested due to automatic review settings November 6, 2025 23:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new experimental Wasm control flow simulation phase to the JIT compiler. The phase analyzes the control flow graph and simulates how Wasm BLOCK/END and LOOP/END control structures would be emitted for the method being compiled.

  • Introduces a new fgWasmControlFlow phase that transforms the control flow graph into Wasm-style nested control structures
  • Adds a JitWasmControlFlow configuration option to enable/disable this experimental feature (DEBUG builds only)
  • Implements an interval-based algorithm to properly nest blocks and loops according to Wasm requirements

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
FileDescription
src/coreclr/jit/jitconfigvalues.hAdds the JitWasmControlFlow configuration integer to control the new phase
src/coreclr/jit/fgwasm.cppNew file implementing the Wasm control flow analysis and simulation algorithm
src/coreclr/jit/compphases.hRegisters the PHASE_WASM_CONTROL_FLOW phase
src/coreclr/jit/compmemkind.hAdds CMK_Wasm memory kind for allocations
src/coreclr/jit/compiler.hDeclares the fgWasmControlFlow method
src/coreclr/jit/compiler.cppInvokes the new phase conditionally in DEBUG builds after loop alignment
src/coreclr/jit/CMakeLists.txtAdds fgwasm.cpp to the build sources

Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
@AndyAyersMS
AndyAyersMS requested a review from a teamNovember 7, 2025 15:31
@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib PTAL

@am11am11 added the arch-wasm WebAssembly architecture label Nov 7, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib ping

Comment threadsrc/coreclr/jit/compmemkind.h Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp
@kg

kg commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

LGTM but I'll leave the green check to someone who knows the JIT better

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

I should do a run where I enable this in release just to see the TP impact... will do that locally and report back.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

I should do a run where I enable this in release just to see the TP impact... will do that locally and report back.

Enabling this in release, it has about a 0.5-0.9% TP hit. Worst-case was benchmaks.pgo at 0.92.

Restricting the analysis to running just on methods with optimization (as it will be doing mostly, R2R code is optimized) drops this to 0.55%.

Breaking it down by stages

DFS 0.14%
+ Loops 0.22%
+ LaRPO 0.27%
+ Intervals 0.36%
+ Conflicts 0.50%
+ Sort 0.53%
+ "codegen" 0.55%

so no clear bottleneck.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

The new phase is now disabled. I will create a wasm test pipeline where we can enable this.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

/ba-g one test failed with Half-way through waiting for remote process. Memory load: 18

Unrelated

@AndyAyersMS
AndyAyersMS merged commit b435b40 into dotnet:mainNov 14, 2025
109 of 112 checks passed
AndyAyersMS added a commit that referenced this pull request Nov 18, 2025
Loops for Wasm control flow codegen don't involve EH or runtime mediated
control flow transfers.
Implement a custom block successor enumerator for Wasm, and adjust
`fgRunDFS`
to allow using this and also to generalize how the DFS is initiated. Use
this to build a "Wasm" DFS. In that DFS handle both the main method and
all funclets (by specifying funclet entries as additional DFS starting
points).
Update the loop finding code to make suitable changes when it is driven
from
a "Wasm" DFS instead of the typical all successor / all predecessor DFS.
Remove the restriction in the Wasm control flow codegen that only
handles
the main method; now it works for the main method and all funclets.
Contributes to #121178.
Dependent on #121417.
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@AndyAyersMSAndyAyersMS mentioned this pull request Nov 19, 2025
12 tasks
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@AndyAyersMS@kg@jakobbotsch@SingleAccretion@am11
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[Wasm RyuJIT] Wasm control flow basics - #121417

Merged
AndyAyersMS merged 9 commits into
dotnet:mainfrom
AndyAyersMS:WasmControlFlowBasics
Nov 14, 2025
Merged

[Wasm RyuJIT] Wasm control flow basics#121417
AndyAyersMS merged 9 commits into
dotnet:mainfrom
AndyAyersMS:WasmControlFlowBasics

Conversation

@AndyAyersMS

Copy link
Copy Markdown
Member

Determine how to emit Wasm control flow from the JIT's control flow graph.

Relies on loop-aware RPO to determine the block order. Currently only handles the main method. Assumes irreducible loops have been fixed upstream (which is not yet guaranteed; bails out if not so).

Doesn't actually do any emission, just prints a textual description in the JIT dump (along with a dot markup version).

Uses only LOOP and BLOCK. Tries to limit the extent of BLOCK.

Run for now as an optional phase even if not targeting Wasm, to do some stress testing.

Contributes to #121178

Determine how to emit Wasm control flow from the JIT's control flow graph.
Relies on loop-aware RPO to determine the block order. Currently only
handles the main method. Assumes irreducible loops have been fixed
upstream (which is not yet guaranteed; bails out if not so).
Doesn't actually do any emission, just prints a textual description in
the JIT dump (along with a dot markup version).
Uses only LOOP and BLOCK. Tries to limit the extent of BLOCK.
Run for now as an optional phase even if not targeting Wasm, to
do some stress testing.
Contributes to dotnet#121178
@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 6, 2025
@AndyAyersMS

AndyAyersMS commented Nov 6, 2025

Copy link
Copy Markdown
MemberAuthor

FYI @dotnet/jit-contrib @SingleAccretion a first cut at wasm control flow. Eventually the text emission will end up being part of emitwasm (and in binary, with text disasm) and not part of this phase.

Left: sample control flow graph. Black are Wasm blocks, red are Wasm loops.

Right: sample Wasm instruction stream (block contents not shown, just BBxx).

image (49) BB01
FALLTHROUGH

BLOCK (13)
BLOCK (12)
BLOCK (8)
BLOCK (4)
BB04
BR_IF 0 (4)
FALLTHROUGH

LOOP (4)
BB33
BR_IF 2 (8)
FALLTHROUGH

BB07
BR_IF 0 (2)be
FALLTHROUGH

END (4) LOOP
END (4)
BLOCK (7)
BB09
BR_IF 0 (7)
FALLTHROUGH

BB10
BR_IF 1 (8)
FALLTHROUGH

BB12
FALLTHROUGH

END (7)
BB19
BR 1 (12)

END (8)
BB21

BB22
FALLTHROUGH

BB16
FALLTHROUGH-inv
BR_IF-inv 1 (13)

BB30
FALLTHROUGH

END (12)
BB02
RETURN

END (13)
BB29
THROW

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

The

FALLTHROUGH-inv
BR_IF-inv 1 (13)

above is a reminder we need to invert the branch condition (not yet done).

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

Think this is ready for review. There could still be bugs in the control flow, but hard to be sure until we can actually generate code.

Errors seem to be all known or timeouts.

@AndyAyersMS
AndyAyersMS marked this pull request as ready for review November 6, 2025 23:48
CopilotAI review requested due to automatic review settings November 6, 2025 23:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new experimental Wasm control flow simulation phase to the JIT compiler. The phase analyzes the control flow graph and simulates how Wasm BLOCK/END and LOOP/END control structures would be emitted for the method being compiled.

  • Introduces a new fgWasmControlFlow phase that transforms the control flow graph into Wasm-style nested control structures
  • Adds a JitWasmControlFlow configuration option to enable/disable this experimental feature (DEBUG builds only)
  • Implements an interval-based algorithm to properly nest blocks and loops according to Wasm requirements

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
FileDescription
src/coreclr/jit/jitconfigvalues.hAdds the JitWasmControlFlow configuration integer to control the new phase
src/coreclr/jit/fgwasm.cppNew file implementing the Wasm control flow analysis and simulation algorithm
src/coreclr/jit/compphases.hRegisters the PHASE_WASM_CONTROL_FLOW phase
src/coreclr/jit/compmemkind.hAdds CMK_Wasm memory kind for allocations
src/coreclr/jit/compiler.hDeclares the fgWasmControlFlow method
src/coreclr/jit/compiler.cppInvokes the new phase conditionally in DEBUG builds after loop alignment
src/coreclr/jit/CMakeLists.txtAdds fgwasm.cpp to the build sources

Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
@AndyAyersMS
AndyAyersMS requested a review from a teamNovember 7, 2025 15:31
@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib PTAL

@am11am11 added the arch-wasm WebAssembly architecture label Nov 7, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib ping

Comment threadsrc/coreclr/jit/compmemkind.h Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp
@kg

kg commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

LGTM but I'll leave the green check to someone who knows the JIT better

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

I should do a run where I enable this in release just to see the TP impact... will do that locally and report back.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

I should do a run where I enable this in release just to see the TP impact... will do that locally and report back.

Enabling this in release, it has about a 0.5-0.9% TP hit. Worst-case was benchmaks.pgo at 0.92.

Restricting the analysis to running just on methods with optimization (as it will be doing mostly, R2R code is optimized) drops this to 0.55%.

Breaking it down by stages

DFS 0.14%
+ Loops 0.22%
+ LaRPO 0.27%
+ Intervals 0.36%
+ Conflicts 0.50%
+ Sort 0.53%
+ "codegen" 0.55%

so no clear bottleneck.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

The new phase is now disabled. I will create a wasm test pipeline where we can enable this.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

/ba-g one test failed with Half-way through waiting for remote process. Memory load: 18

Unrelated

@AndyAyersMS
AndyAyersMS merged commit b435b40 into dotnet:mainNov 14, 2025
109 of 112 checks passed
AndyAyersMS added a commit that referenced this pull request Nov 18, 2025
Loops for Wasm control flow codegen don't involve EH or runtime mediated
control flow transfers.
Implement a custom block successor enumerator for Wasm, and adjust
`fgRunDFS`
to allow using this and also to generalize how the DFS is initiated. Use
this to build a "Wasm" DFS. In that DFS handle both the main method and
all funclets (by specifying funclet entries as additional DFS starting
points).
Update the loop finding code to make suitable changes when it is driven
from
a "Wasm" DFS instead of the typical all successor / all predecessor DFS.
Remove the restriction in the Wasm control flow codegen that only
handles
the main method; now it works for the main method and all funclets.
Contributes to #121178.
Dependent on #121417.
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@AndyAyersMSAndyAyersMS mentioned this pull request Nov 19, 2025
12 tasks
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@AndyAyersMS@kg@jakobbotsch@SingleAccretion@am11
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

[Wasm RyuJIT] Wasm control flow basics - #121417

Merged
AndyAyersMS merged 9 commits into
dotnet:mainfrom
AndyAyersMS:WasmControlFlowBasics
Nov 14, 2025
Merged

[Wasm RyuJIT] Wasm control flow basics#121417
AndyAyersMS merged 9 commits into
dotnet:mainfrom
AndyAyersMS:WasmControlFlowBasics

Conversation

@AndyAyersMS

Copy link
Copy Markdown
Member

Determine how to emit Wasm control flow from the JIT's control flow graph.

Relies on loop-aware RPO to determine the block order. Currently only handles the main method. Assumes irreducible loops have been fixed upstream (which is not yet guaranteed; bails out if not so).

Doesn't actually do any emission, just prints a textual description in the JIT dump (along with a dot markup version).

Uses only LOOP and BLOCK. Tries to limit the extent of BLOCK.

Run for now as an optional phase even if not targeting Wasm, to do some stress testing.

Contributes to #121178

Determine how to emit Wasm control flow from the JIT's control flow graph.
Relies on loop-aware RPO to determine the block order. Currently only
handles the main method. Assumes irreducible loops have been fixed
upstream (which is not yet guaranteed; bails out if not so).
Doesn't actually do any emission, just prints a textual description in
the JIT dump (along with a dot markup version).
Uses only LOOP and BLOCK. Tries to limit the extent of BLOCK.
Run for now as an optional phase even if not targeting Wasm, to
do some stress testing.
Contributes to dotnet#121178
@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 6, 2025
@AndyAyersMS

AndyAyersMS commented Nov 6, 2025

Copy link
Copy Markdown
MemberAuthor

FYI @dotnet/jit-contrib @SingleAccretion a first cut at wasm control flow. Eventually the text emission will end up being part of emitwasm (and in binary, with text disasm) and not part of this phase.

Left: sample control flow graph. Black are Wasm blocks, red are Wasm loops.

Right: sample Wasm instruction stream (block contents not shown, just BBxx).

image (49) BB01
FALLTHROUGH

BLOCK (13)
BLOCK (12)
BLOCK (8)
BLOCK (4)
BB04
BR_IF 0 (4)
FALLTHROUGH

LOOP (4)
BB33
BR_IF 2 (8)
FALLTHROUGH

BB07
BR_IF 0 (2)be
FALLTHROUGH

END (4) LOOP
END (4)
BLOCK (7)
BB09
BR_IF 0 (7)
FALLTHROUGH

BB10
BR_IF 1 (8)
FALLTHROUGH

BB12
FALLTHROUGH

END (7)
BB19
BR 1 (12)

END (8)
BB21

BB22
FALLTHROUGH

BB16
FALLTHROUGH-inv
BR_IF-inv 1 (13)

BB30
FALLTHROUGH

END (12)
BB02
RETURN

END (13)
BB29
THROW

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

The

FALLTHROUGH-inv
BR_IF-inv 1 (13)

above is a reminder we need to invert the branch condition (not yet done).

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

Think this is ready for review. There could still be bugs in the control flow, but hard to be sure until we can actually generate code.

Errors seem to be all known or timeouts.

@AndyAyersMS
AndyAyersMS marked this pull request as ready for review November 6, 2025 23:48
CopilotAI review requested due to automatic review settings November 6, 2025 23:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new experimental Wasm control flow simulation phase to the JIT compiler. The phase analyzes the control flow graph and simulates how Wasm BLOCK/END and LOOP/END control structures would be emitted for the method being compiled.

  • Introduces a new fgWasmControlFlow phase that transforms the control flow graph into Wasm-style nested control structures
  • Adds a JitWasmControlFlow configuration option to enable/disable this experimental feature (DEBUG builds only)
  • Implements an interval-based algorithm to properly nest blocks and loops according to Wasm requirements

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
FileDescription
src/coreclr/jit/jitconfigvalues.hAdds the JitWasmControlFlow configuration integer to control the new phase
src/coreclr/jit/fgwasm.cppNew file implementing the Wasm control flow analysis and simulation algorithm
src/coreclr/jit/compphases.hRegisters the PHASE_WASM_CONTROL_FLOW phase
src/coreclr/jit/compmemkind.hAdds CMK_Wasm memory kind for allocations
src/coreclr/jit/compiler.hDeclares the fgWasmControlFlow method
src/coreclr/jit/compiler.cppInvokes the new phase conditionally in DEBUG builds after loop alignment
src/coreclr/jit/CMakeLists.txtAdds fgwasm.cpp to the build sources

Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
@AndyAyersMS
AndyAyersMS requested a review from a teamNovember 7, 2025 15:31
@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib PTAL

@am11am11 added the arch-wasm WebAssembly architecture label Nov 7, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib ping

Comment threadsrc/coreclr/jit/compmemkind.h Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp
@kg

kg commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

LGTM but I'll leave the green check to someone who knows the JIT better

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

I should do a run where I enable this in release just to see the TP impact... will do that locally and report back.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

I should do a run where I enable this in release just to see the TP impact... will do that locally and report back.

Enabling this in release, it has about a 0.5-0.9% TP hit. Worst-case was benchmaks.pgo at 0.92.

Restricting the analysis to running just on methods with optimization (as it will be doing mostly, R2R code is optimized) drops this to 0.55%.

Breaking it down by stages

DFS 0.14%
+ Loops 0.22%
+ LaRPO 0.27%
+ Intervals 0.36%
+ Conflicts 0.50%
+ Sort 0.53%
+ "codegen" 0.55%

so no clear bottleneck.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

The new phase is now disabled. I will create a wasm test pipeline where we can enable this.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

/ba-g one test failed with Half-way through waiting for remote process. Memory load: 18

Unrelated

@AndyAyersMS
AndyAyersMS merged commit b435b40 into dotnet:mainNov 14, 2025
109 of 112 checks passed
AndyAyersMS added a commit that referenced this pull request Nov 18, 2025
Loops for Wasm control flow codegen don't involve EH or runtime mediated
control flow transfers.
Implement a custom block successor enumerator for Wasm, and adjust
`fgRunDFS`
to allow using this and also to generalize how the DFS is initiated. Use
this to build a "Wasm" DFS. In that DFS handle both the main method and
all funclets (by specifying funclet entries as additional DFS starting
points).
Update the loop finding code to make suitable changes when it is driven
from
a "Wasm" DFS instead of the typical all successor / all predecessor DFS.
Remove the restriction in the Wasm control flow codegen that only
handles
the main method; now it works for the main method and all funclets.
Contributes to #121178.
Dependent on #121417.
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@AndyAyersMSAndyAyersMS mentioned this pull request Nov 19, 2025
12 tasks
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@AndyAyersMS@kg@jakobbotsch@SingleAccretion@am11
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[Wasm RyuJIT] Wasm control flow basics - #121417

Merged
AndyAyersMS merged 9 commits into
dotnet:mainfrom
AndyAyersMS:WasmControlFlowBasics
Nov 14, 2025
Merged

[Wasm RyuJIT] Wasm control flow basics#121417
AndyAyersMS merged 9 commits into
dotnet:mainfrom
AndyAyersMS:WasmControlFlowBasics

Conversation

@AndyAyersMS

Copy link
Copy Markdown
Member

Determine how to emit Wasm control flow from the JIT's control flow graph.

Relies on loop-aware RPO to determine the block order. Currently only handles the main method. Assumes irreducible loops have been fixed upstream (which is not yet guaranteed; bails out if not so).

Doesn't actually do any emission, just prints a textual description in the JIT dump (along with a dot markup version).

Uses only LOOP and BLOCK. Tries to limit the extent of BLOCK.

Run for now as an optional phase even if not targeting Wasm, to do some stress testing.

Contributes to #121178

Determine how to emit Wasm control flow from the JIT's control flow graph.
Relies on loop-aware RPO to determine the block order. Currently only
handles the main method. Assumes irreducible loops have been fixed
upstream (which is not yet guaranteed; bails out if not so).
Doesn't actually do any emission, just prints a textual description in
the JIT dump (along with a dot markup version).
Uses only LOOP and BLOCK. Tries to limit the extent of BLOCK.
Run for now as an optional phase even if not targeting Wasm, to
do some stress testing.
Contributes to dotnet#121178
@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 6, 2025
@AndyAyersMS

AndyAyersMS commented Nov 6, 2025

Copy link
Copy Markdown
MemberAuthor

FYI @dotnet/jit-contrib @SingleAccretion a first cut at wasm control flow. Eventually the text emission will end up being part of emitwasm (and in binary, with text disasm) and not part of this phase.

Left: sample control flow graph. Black are Wasm blocks, red are Wasm loops.

Right: sample Wasm instruction stream (block contents not shown, just BBxx).

image (49) BB01
FALLTHROUGH

BLOCK (13)
BLOCK (12)
BLOCK (8)
BLOCK (4)
BB04
BR_IF 0 (4)
FALLTHROUGH

LOOP (4)
BB33
BR_IF 2 (8)
FALLTHROUGH

BB07
BR_IF 0 (2)be
FALLTHROUGH

END (4) LOOP
END (4)
BLOCK (7)
BB09
BR_IF 0 (7)
FALLTHROUGH

BB10
BR_IF 1 (8)
FALLTHROUGH

BB12
FALLTHROUGH

END (7)
BB19
BR 1 (12)

END (8)
BB21

BB22
FALLTHROUGH

BB16
FALLTHROUGH-inv
BR_IF-inv 1 (13)

BB30
FALLTHROUGH

END (12)
BB02
RETURN

END (13)
BB29
THROW

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

The

FALLTHROUGH-inv
BR_IF-inv 1 (13)

above is a reminder we need to invert the branch condition (not yet done).

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

Think this is ready for review. There could still be bugs in the control flow, but hard to be sure until we can actually generate code.

Errors seem to be all known or timeouts.

@AndyAyersMS
AndyAyersMS marked this pull request as ready for review November 6, 2025 23:48
CopilotAI review requested due to automatic review settings November 6, 2025 23:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new experimental Wasm control flow simulation phase to the JIT compiler. The phase analyzes the control flow graph and simulates how Wasm BLOCK/END and LOOP/END control structures would be emitted for the method being compiled.

  • Introduces a new fgWasmControlFlow phase that transforms the control flow graph into Wasm-style nested control structures
  • Adds a JitWasmControlFlow configuration option to enable/disable this experimental feature (DEBUG builds only)
  • Implements an interval-based algorithm to properly nest blocks and loops according to Wasm requirements

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
FileDescription
src/coreclr/jit/jitconfigvalues.hAdds the JitWasmControlFlow configuration integer to control the new phase
src/coreclr/jit/fgwasm.cppNew file implementing the Wasm control flow analysis and simulation algorithm
src/coreclr/jit/compphases.hRegisters the PHASE_WASM_CONTROL_FLOW phase
src/coreclr/jit/compmemkind.hAdds CMK_Wasm memory kind for allocations
src/coreclr/jit/compiler.hDeclares the fgWasmControlFlow method
src/coreclr/jit/compiler.cppInvokes the new phase conditionally in DEBUG builds after loop alignment
src/coreclr/jit/CMakeLists.txtAdds fgwasm.cpp to the build sources

Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
@AndyAyersMS
AndyAyersMS requested a review from a teamNovember 7, 2025 15:31
@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib PTAL

@am11am11 added the arch-wasm WebAssembly architecture label Nov 7, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib ping

Comment threadsrc/coreclr/jit/compmemkind.h Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp
@kg

kg commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

LGTM but I'll leave the green check to someone who knows the JIT better

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

I should do a run where I enable this in release just to see the TP impact... will do that locally and report back.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

I should do a run where I enable this in release just to see the TP impact... will do that locally and report back.

Enabling this in release, it has about a 0.5-0.9% TP hit. Worst-case was benchmaks.pgo at 0.92.

Restricting the analysis to running just on methods with optimization (as it will be doing mostly, R2R code is optimized) drops this to 0.55%.

Breaking it down by stages

DFS 0.14%
+ Loops 0.22%
+ LaRPO 0.27%
+ Intervals 0.36%
+ Conflicts 0.50%
+ Sort 0.53%
+ "codegen" 0.55%

so no clear bottleneck.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

The new phase is now disabled. I will create a wasm test pipeline where we can enable this.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

/ba-g one test failed with Half-way through waiting for remote process. Memory load: 18

Unrelated

@AndyAyersMS
AndyAyersMS merged commit b435b40 into dotnet:mainNov 14, 2025
109 of 112 checks passed
AndyAyersMS added a commit that referenced this pull request Nov 18, 2025
Loops for Wasm control flow codegen don't involve EH or runtime mediated
control flow transfers.
Implement a custom block successor enumerator for Wasm, and adjust
`fgRunDFS`
to allow using this and also to generalize how the DFS is initiated. Use
this to build a "Wasm" DFS. In that DFS handle both the main method and
all funclets (by specifying funclet entries as additional DFS starting
points).
Update the loop finding code to make suitable changes when it is driven
from
a "Wasm" DFS instead of the typical all successor / all predecessor DFS.
Remove the restriction in the Wasm control flow codegen that only
handles
the main method; now it works for the main method and all funclets.
Contributes to #121178.
Dependent on #121417.
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@AndyAyersMSAndyAyersMS mentioned this pull request Nov 19, 2025
12 tasks
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@AndyAyersMS@kg@jakobbotsch@SingleAccretion@am11
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[Wasm RyuJIT] Wasm control flow basics - #121417

Merged
AndyAyersMS merged 9 commits into
dotnet:mainfrom
AndyAyersMS:WasmControlFlowBasics
Nov 14, 2025
Merged

[Wasm RyuJIT] Wasm control flow basics#121417
AndyAyersMS merged 9 commits into
dotnet:mainfrom
AndyAyersMS:WasmControlFlowBasics

Conversation

@AndyAyersMS

Copy link
Copy Markdown
Member

Determine how to emit Wasm control flow from the JIT's control flow graph.

Relies on loop-aware RPO to determine the block order. Currently only handles the main method. Assumes irreducible loops have been fixed upstream (which is not yet guaranteed; bails out if not so).

Doesn't actually do any emission, just prints a textual description in the JIT dump (along with a dot markup version).

Uses only LOOP and BLOCK. Tries to limit the extent of BLOCK.

Run for now as an optional phase even if not targeting Wasm, to do some stress testing.

Contributes to #121178

Determine how to emit Wasm control flow from the JIT's control flow graph.
Relies on loop-aware RPO to determine the block order. Currently only
handles the main method. Assumes irreducible loops have been fixed
upstream (which is not yet guaranteed; bails out if not so).
Doesn't actually do any emission, just prints a textual description in
the JIT dump (along with a dot markup version).
Uses only LOOP and BLOCK. Tries to limit the extent of BLOCK.
Run for now as an optional phase even if not targeting Wasm, to
do some stress testing.
Contributes to dotnet#121178
@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 6, 2025
@AndyAyersMS

AndyAyersMS commented Nov 6, 2025

Copy link
Copy Markdown
MemberAuthor

FYI @dotnet/jit-contrib @SingleAccretion a first cut at wasm control flow. Eventually the text emission will end up being part of emitwasm (and in binary, with text disasm) and not part of this phase.

Left: sample control flow graph. Black are Wasm blocks, red are Wasm loops.

Right: sample Wasm instruction stream (block contents not shown, just BBxx).

image (49) BB01
FALLTHROUGH

BLOCK (13)
BLOCK (12)
BLOCK (8)
BLOCK (4)
BB04
BR_IF 0 (4)
FALLTHROUGH

LOOP (4)
BB33
BR_IF 2 (8)
FALLTHROUGH

BB07
BR_IF 0 (2)be
FALLTHROUGH

END (4) LOOP
END (4)
BLOCK (7)
BB09
BR_IF 0 (7)
FALLTHROUGH

BB10
BR_IF 1 (8)
FALLTHROUGH

BB12
FALLTHROUGH

END (7)
BB19
BR 1 (12)

END (8)
BB21

BB22
FALLTHROUGH

BB16
FALLTHROUGH-inv
BR_IF-inv 1 (13)

BB30
FALLTHROUGH

END (12)
BB02
RETURN

END (13)
BB29
THROW

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

The

FALLTHROUGH-inv
BR_IF-inv 1 (13)

above is a reminder we need to invert the branch condition (not yet done).

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

Think this is ready for review. There could still be bugs in the control flow, but hard to be sure until we can actually generate code.

Errors seem to be all known or timeouts.

@AndyAyersMS
AndyAyersMS marked this pull request as ready for review November 6, 2025 23:48
CopilotAI review requested due to automatic review settings November 6, 2025 23:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new experimental Wasm control flow simulation phase to the JIT compiler. The phase analyzes the control flow graph and simulates how Wasm BLOCK/END and LOOP/END control structures would be emitted for the method being compiled.

  • Introduces a new fgWasmControlFlow phase that transforms the control flow graph into Wasm-style nested control structures
  • Adds a JitWasmControlFlow configuration option to enable/disable this experimental feature (DEBUG builds only)
  • Implements an interval-based algorithm to properly nest blocks and loops according to Wasm requirements

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
FileDescription
src/coreclr/jit/jitconfigvalues.hAdds the JitWasmControlFlow configuration integer to control the new phase
src/coreclr/jit/fgwasm.cppNew file implementing the Wasm control flow analysis and simulation algorithm
src/coreclr/jit/compphases.hRegisters the PHASE_WASM_CONTROL_FLOW phase
src/coreclr/jit/compmemkind.hAdds CMK_Wasm memory kind for allocations
src/coreclr/jit/compiler.hDeclares the fgWasmControlFlow method
src/coreclr/jit/compiler.cppInvokes the new phase conditionally in DEBUG builds after loop alignment
src/coreclr/jit/CMakeLists.txtAdds fgwasm.cpp to the build sources

Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
@AndyAyersMS
AndyAyersMS requested a review from a teamNovember 7, 2025 15:31
@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib PTAL

@am11am11 added the arch-wasm WebAssembly architecture label Nov 7, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib ping

Comment threadsrc/coreclr/jit/compmemkind.h Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp
@kg

kg commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

LGTM but I'll leave the green check to someone who knows the JIT better

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

I should do a run where I enable this in release just to see the TP impact... will do that locally and report back.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

I should do a run where I enable this in release just to see the TP impact... will do that locally and report back.

Enabling this in release, it has about a 0.5-0.9% TP hit. Worst-case was benchmaks.pgo at 0.92.

Restricting the analysis to running just on methods with optimization (as it will be doing mostly, R2R code is optimized) drops this to 0.55%.

Breaking it down by stages

DFS 0.14%
+ Loops 0.22%
+ LaRPO 0.27%
+ Intervals 0.36%
+ Conflicts 0.50%
+ Sort 0.53%
+ "codegen" 0.55%

so no clear bottleneck.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

The new phase is now disabled. I will create a wasm test pipeline where we can enable this.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

/ba-g one test failed with Half-way through waiting for remote process. Memory load: 18

Unrelated

@AndyAyersMS
AndyAyersMS merged commit b435b40 into dotnet:mainNov 14, 2025
109 of 112 checks passed
AndyAyersMS added a commit that referenced this pull request Nov 18, 2025
Loops for Wasm control flow codegen don't involve EH or runtime mediated
control flow transfers.
Implement a custom block successor enumerator for Wasm, and adjust
`fgRunDFS`
to allow using this and also to generalize how the DFS is initiated. Use
this to build a "Wasm" DFS. In that DFS handle both the main method and
all funclets (by specifying funclet entries as additional DFS starting
points).
Update the loop finding code to make suitable changes when it is driven
from
a "Wasm" DFS instead of the typical all successor / all predecessor DFS.
Remove the restriction in the Wasm control flow codegen that only
handles
the main method; now it works for the main method and all funclets.
Contributes to #121178.
Dependent on #121417.
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@AndyAyersMSAndyAyersMS mentioned this pull request Nov 19, 2025
12 tasks
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@AndyAyersMS@kg@jakobbotsch@SingleAccretion@am11
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

[Wasm RyuJIT] Wasm control flow basics - #121417

Merged
AndyAyersMS merged 9 commits into
dotnet:mainfrom
AndyAyersMS:WasmControlFlowBasics
Nov 14, 2025
Merged

[Wasm RyuJIT] Wasm control flow basics#121417
AndyAyersMS merged 9 commits into
dotnet:mainfrom
AndyAyersMS:WasmControlFlowBasics

Conversation

@AndyAyersMS

Copy link
Copy Markdown
Member

Determine how to emit Wasm control flow from the JIT's control flow graph.

Relies on loop-aware RPO to determine the block order. Currently only handles the main method. Assumes irreducible loops have been fixed upstream (which is not yet guaranteed; bails out if not so).

Doesn't actually do any emission, just prints a textual description in the JIT dump (along with a dot markup version).

Uses only LOOP and BLOCK. Tries to limit the extent of BLOCK.

Run for now as an optional phase even if not targeting Wasm, to do some stress testing.

Contributes to #121178

Determine how to emit Wasm control flow from the JIT's control flow graph.
Relies on loop-aware RPO to determine the block order. Currently only
handles the main method. Assumes irreducible loops have been fixed
upstream (which is not yet guaranteed; bails out if not so).
Doesn't actually do any emission, just prints a textual description in
the JIT dump (along with a dot markup version).
Uses only LOOP and BLOCK. Tries to limit the extent of BLOCK.
Run for now as an optional phase even if not targeting Wasm, to
do some stress testing.
Contributes to dotnet#121178
@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 6, 2025
@AndyAyersMS

AndyAyersMS commented Nov 6, 2025

Copy link
Copy Markdown
MemberAuthor

FYI @dotnet/jit-contrib @SingleAccretion a first cut at wasm control flow. Eventually the text emission will end up being part of emitwasm (and in binary, with text disasm) and not part of this phase.

Left: sample control flow graph. Black are Wasm blocks, red are Wasm loops.

Right: sample Wasm instruction stream (block contents not shown, just BBxx).

image (49) BB01
FALLTHROUGH

BLOCK (13)
BLOCK (12)
BLOCK (8)
BLOCK (4)
BB04
BR_IF 0 (4)
FALLTHROUGH

LOOP (4)
BB33
BR_IF 2 (8)
FALLTHROUGH

BB07
BR_IF 0 (2)be
FALLTHROUGH

END (4) LOOP
END (4)
BLOCK (7)
BB09
BR_IF 0 (7)
FALLTHROUGH

BB10
BR_IF 1 (8)
FALLTHROUGH

BB12
FALLTHROUGH

END (7)
BB19
BR 1 (12)

END (8)
BB21

BB22
FALLTHROUGH

BB16
FALLTHROUGH-inv
BR_IF-inv 1 (13)

BB30
FALLTHROUGH

END (12)
BB02
RETURN

END (13)
BB29
THROW

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

The

FALLTHROUGH-inv
BR_IF-inv 1 (13)

above is a reminder we need to invert the branch condition (not yet done).

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

Think this is ready for review. There could still be bugs in the control flow, but hard to be sure until we can actually generate code.

Errors seem to be all known or timeouts.

@AndyAyersMS
AndyAyersMS marked this pull request as ready for review November 6, 2025 23:48
CopilotAI review requested due to automatic review settings November 6, 2025 23:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new experimental Wasm control flow simulation phase to the JIT compiler. The phase analyzes the control flow graph and simulates how Wasm BLOCK/END and LOOP/END control structures would be emitted for the method being compiled.

  • Introduces a new fgWasmControlFlow phase that transforms the control flow graph into Wasm-style nested control structures
  • Adds a JitWasmControlFlow configuration option to enable/disable this experimental feature (DEBUG builds only)
  • Implements an interval-based algorithm to properly nest blocks and loops according to Wasm requirements

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
FileDescription
src/coreclr/jit/jitconfigvalues.hAdds the JitWasmControlFlow configuration integer to control the new phase
src/coreclr/jit/fgwasm.cppNew file implementing the Wasm control flow analysis and simulation algorithm
src/coreclr/jit/compphases.hRegisters the PHASE_WASM_CONTROL_FLOW phase
src/coreclr/jit/compmemkind.hAdds CMK_Wasm memory kind for allocations
src/coreclr/jit/compiler.hDeclares the fgWasmControlFlow method
src/coreclr/jit/compiler.cppInvokes the new phase conditionally in DEBUG builds after loop alignment
src/coreclr/jit/CMakeLists.txtAdds fgwasm.cpp to the build sources

Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
@AndyAyersMS
AndyAyersMS requested a review from a teamNovember 7, 2025 15:31
@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib PTAL

@am11am11 added the arch-wasm WebAssembly architecture label Nov 7, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib ping

Comment threadsrc/coreclr/jit/compmemkind.h Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp Outdated
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp
Comment threadsrc/coreclr/jit/fgwasm.cpp
@kg

kg commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

LGTM but I'll leave the green check to someone who knows the JIT better

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

I should do a run where I enable this in release just to see the TP impact... will do that locally and report back.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

I should do a run where I enable this in release just to see the TP impact... will do that locally and report back.

Enabling this in release, it has about a 0.5-0.9% TP hit. Worst-case was benchmaks.pgo at 0.92.

Restricting the analysis to running just on methods with optimization (as it will be doing mostly, R2R code is optimized) drops this to 0.55%.

Breaking it down by stages

DFS 0.14%
+ Loops 0.22%
+ LaRPO 0.27%
+ Intervals 0.36%
+ Conflicts 0.50%
+ Sort 0.53%
+ "codegen" 0.55%

so no clear bottleneck.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

The new phase is now disabled. I will create a wasm test pipeline where we can enable this.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

/ba-g one test failed with Half-way through waiting for remote process. Memory load: 18

Unrelated

@AndyAyersMS
AndyAyersMS merged commit b435b40 into dotnet:mainNov 14, 2025
109 of 112 checks passed
AndyAyersMS added a commit that referenced this pull request Nov 18, 2025
Loops for Wasm control flow codegen don't involve EH or runtime mediated
control flow transfers.
Implement a custom block successor enumerator for Wasm, and adjust
`fgRunDFS`
to allow using this and also to generalize how the DFS is initiated. Use
this to build a "Wasm" DFS. In that DFS handle both the main method and
all funclets (by specifying funclet entries as additional DFS starting
points).
Update the loop finding code to make suitable changes when it is driven
from
a "Wasm" DFS instead of the typical all successor / all predecessor DFS.
Remove the restriction in the Wasm control flow codegen that only
handles
the main method; now it works for the main method and all funclets.
Contributes to #121178.
Dependent on #121417.
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@AndyAyersMSAndyAyersMS mentioned this pull request Nov 19, 2025
12 tasks
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@AndyAyersMS@kg@jakobbotsch@SingleAccretion@am11