Skip to content

[RyuJit/WASM] Crossgen2 integration and further factoring - #121563

Merged
AndyAyersMS merged 7 commits into
dotnet:mainfrom
SingleAccretion:WasmJit-Cg
Nov 19, 2025
Merged

[RyuJit/WASM] Crossgen2 integration and further factoring#121563
AndyAyersMS merged 7 commits into
dotnet:mainfrom
SingleAccretion:WasmJit-Cg

Conversation

@SingleAccretion

@SingleAccretionSingleAccretion commented Nov 12, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This allows:

int add(int a, int b) => a + b;

to run until the NYI in codegen.

@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 12, 2025
@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Nov 12, 2025
This was referenced Nov 13, 2025
Closed
Open
Closed
Open
Open
Open
This was referenced Nov 13, 2025
Closed
Open
@adamperlin

adamperlin commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

@SingleAccretion I am starting work on the R2R object writer. Is it alright if I copy the crossgen2 integration bits from this PR for that purpose?

@SingleAccretion

SingleAccretion commented Nov 13, 2025

Copy link
Copy Markdown
ContributorAuthor

I am starting work on the R2R object writer. Is it alright if I copy the crossgen2 integration bits from this PR for that purpose?

Sure!

(But do be prepared for them to perhaps change a bit in the course of the review.)

@adamperlin

adamperlin commented Nov 13, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

I am starting work on the R2R object writer. Is it alright if I copy the crossgen2 integration bits from this PR for that purpose?

Sure!

(But do be prepared for them to perhaps change a bit in the course of the review.)

Ok, that sounds good! I will be prepared that they may change and I'll check back during review!

@SingleAccretion
SingleAccretion marked this pull request as ready for review November 15, 2025 01:07
@SingleAccretion

SingleAccretion commented Nov 15, 2025

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib

kg
kg reviewed Nov 15, 2025
View reviewed changes
Comment threadsrc/coreclr/jit/compiler.cpp Outdated
jkotas
jkotas reviewed Nov 15, 2025
View reviewed changes
Comment threadsrc/coreclr/inc/corinfo.h Outdated
@build-analysisbuild-analysisBot mentioned this pull request Nov 15, 2025
Closed
@am11am11 added the arch-wasm WebAssembly architecture label Nov 15, 2025
@dotnet-policy-service

dotnet-policy-serviceBot commented Nov 15, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@build-analysisbuild-analysisBot mentioned this pull request Nov 16, 2025
Closed
3 tasks
AndyAyersMS
AndyAyersMS reviewed Nov 17, 2025
View reviewed changes

@AndyAyersMSAndyAyersMS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JIT side of this looks good to me.

@kg any other comments?

kg
kg reviewed Nov 19, 2025
View reviewed changes
Comment threadsrc/coreclr/jit/targetwasm.h
kg
kg reviewed Nov 19, 2025
View reviewed changes
Comment threadsrc/coreclr/tools/Common/JitInterface/JitConfigProvider.cs
@kg

kg commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

The JIT side of this looks good to me.

@kg any other comments?

This LGTM as well! Thanks for all the hard work.

@AndyAyersMS
AndyAyersMS merged commit 4fed3f3 into dotnet:mainNov 19, 2025
156 of 158 checks passed
@SingleAccretion
SingleAccretion deleted the WasmJit-Cg branch November 19, 2025 16:14
@dotnet-maestrodotnet-maestroBot mentioned this pull request Nov 20, 2025
Merged
@AndyAyersMSAndyAyersMS mentioned this pull request Dec 13, 2025
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 20, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas left review comments
@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
+2 more reviewers
@kgkgkg left review comments
@am11am11am11 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SingleAccretion@adamperlin@kg@am11@jkotas@AndyAyersMS