Skip to content

[infra][iOS] Fully build smoke tests on azdo build images - #121927

Merged
matouskozak merged 11 commits into
dotnet:mainfrom
matouskozak:update-macos-images
Dec 4, 2025
Merged

[infra][iOS] Fully build smoke tests on azdo build images#121927
matouskozak merged 11 commits into
dotnet:mainfrom
matouskozak:update-macos-images

Conversation

@matouskozak

@matouskozakmatouskozak commented Nov 24, 2025

Copy link
Copy Markdown
Member

Build Mono smoke tests on Azdo build images to work around an issue where helix machines have lower XCode than Azdo images, causing Mono linking errors: #120589 (comment)

Changes:

  • Correct Directory.Build.* imports for functional tests
  • Tweak src/libraries/sendtohelix-mobile.targets to handle cases where only runonly tests are prepared for sending to helix.
  • Rename mobile jobs running only smoke tests

@github-actionsgithub-actionsBot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 24, 2025
@matouskozakmatouskozak added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 24, 2025
@matouskozakmatouskozak changed the title [Testing] Try macOS-14 azdo images[Testing][iOS] Try macOS-15 azdo imagesNov 26, 2025
@matouskozakmatouskozak changed the title [Testing][iOS] Try macOS-15 azdo images[infra][iOS] Fully build smoke tests on azdo build imagesDec 3, 2025
@matouskozakmatouskozak added os-ios Apple iOS and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Dec 4, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

@matouskozak

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslike,runtime-ioslikesimulator

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@matouskozak

Copy link
Copy Markdown
MemberAuthor

I've tried building full libraries suit on macOS azdo machine but it took over 4h and then got cancelled (https://dev.azure.com/dnceng-public/public/_build/results?buildId=1220044&view=logs&jobId=6ad81d5f-e956-5767-2437-61a9fc4dc8db&j=acac6bf3-3edd-5022-4e45-3362a02520b1&t=311ccc8e-0304-52d0-3115-8f8cb0052fd2), we will need the helix build step when helix queues get updated.

@matouskozak
matouskozak marked this pull request as ready for review December 4, 2025 13:23
CopilotAI review requested due to automatic review settings December 4, 2025 13:23

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables building Mono smoke tests on Azure DevOps build images instead of Helix machines to work around XCode version incompatibilities. The changes include correcting import paths for functional tests, improving the robustness of mobile test handling, and renaming pipeline jobs for clarity.

Key Changes:

  • Corrected Directory.Build.* import paths for iOS/tvOS functional tests to reference the correct parent directory
  • Enhanced sendtohelix-mobile.targets with existence checks and path corrections for run-only test scenarios
  • Removed /p:BuildTestsOnHelix=true from iOS/tvOS device builds and renamed mobile smoke test jobs with _Smoke suffix for clarity

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
src/tests/FunctionalTests/tvOS/Device/AOT/Directory.Build.targetsCorrected import path from libraries directory to FunctionalTests parent directory
src/tests/FunctionalTests/tvOS/Device/AOT/Directory.Build.propsCorrected import path from libraries directory to FunctionalTests parent directory
src/tests/FunctionalTests/iOS/Device/Directory.Build.targetsCorrected import path from libraries directory to FunctionalTests parent directory
src/tests/FunctionalTests/iOS/Device/Directory.Build.propsCorrected import path from libraries directory to FunctionalTests parent directory
src/libraries/sendtohelix-mobile.targetsAdded existence checks, CustomCommands for runonly tests, and fixed Exclude path for consistency
eng/pipelines/runtime.ymlRenamed mobile smoke test jobs with _Smoke suffix, removed BuildTestsOnHelix parameter, and re-enabled iOS/tvOS device test execution
eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.ymlRenamed CoreCLR smoke test job with _Smoke suffix
eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.ymlRenamed CoreCLR smoke test job with _Smoke suffix
eng/pipelines/extra-platforms/runtime-extra-platforms-ioslike.ymlRenamed NativeAOT and CoreCLR smoke test jobs with _Smoke suffix

Comment threadeng/pipelines/runtime.yml
Comment threadeng/pipelines/runtime.yml
Comment threadsrc/libraries/sendtohelix-mobile.targets
@kotlarmilos
kotlarmilos self-requested a review December 4, 2025 14:09

@kotlarmiloskotlarmilos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@matouskozak
matouskozak enabled auto-merge (squash) December 4, 2025 16:59
@matouskozak
matouskozak merged commit f6d570f into dotnet:mainDec 4, 2025
173 of 175 checks passed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 4, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@matouskozak@kotlarmilos