Uh oh!
There was an error while loading. Please reload this page.
Fix race in installer tasks build - #122
Merged
Merged
Conversation
eiriktsarpalis
approved these changes
Nov 19, 2019
trylek
reviewed
Nov 19, 2019
trylek
left a comment
Member
There was a problem hiding this comment.
Awesome, thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't find the place where CoreClr is fiddling with the Configuration property but this change is general goodness (by making the tools-local logic more general purpose)
cc @ivdiazsa@jashook