Uh oh!
There was an error while loading. Please reload this page.
[browser][coreCLR] fix trimming of TimerHandler, BackgroundJobHandler - #122068
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes trimming issues for Browser builds with CoreCLR by adding ILLink descriptor preservation rules for methods that are called from native code via unmanaged function pointers.
- Adds a new Browser-specific ILLink descriptor file to preserve
TimerHandlerandBackgroundJobHandlermethods - Configures the build system to conditionally include this descriptor file for Browser targets
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems | Adds conditional inclusion of the Browser-specific ILLink descriptor file when targeting Browser platform |
| src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.LibraryBuild.Browser.xml | New descriptor file that preserves TimerHandler and BackgroundJobHandler methods marked with [UnmanagedCallersOnly] to prevent them from being trimmed |
Uh oh!
There was an error while loading. Please reload this page.
jkotas
reviewed
Dec 1, 2025
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Dec 1, 2025
Open
pavelsavaraforce-pushed
the
browser_corelcr_umco_trim
branch
from
December 2, 2025 15:36
6773f7c to
8c71f50Comparejkotas
approved these changes
Dec 2, 2025
pavelsavara
enabled auto-merge (squash)
December 2, 2025 19:25
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.