Uh oh!
There was an error while loading. Please reload this page.
Add Zip Archives password support - #122093
Conversation
…assword and unprotected
… with cryptography lib
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
GrabYourPitchforks
commented
Jul 2, 2026
@alinpahontu2912 We signed off earlier this week on the security design you submitted. Thanks. :) Remember to update the public-facing docs so that consumers know what explicit promises (and non-promises!) the component intends to make here. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bartonjs
left a comment
There was a problem hiding this comment.
I never looked at the tests at all.
I skimmed the majority of the source code looking for places where the password might be mishandled.
I aggressively reviewed the crypto parts of WinZipAesStream and ZipCryptoStream.
Those parts LGTM.
Since I didn't do a full review I won't give a checkmark, but I also don't have any reason to hold.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…WinZipAesStream.cs Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
MihaZupan
commented
Jul 14, 2026
@alinpahontu2912 did you test running the new fuzzers locally? |
Fixes#1545
Big Milestones and status: