Initial SslStream stress app work by eiriktsarpalis · Pull Request #123 · dotnet/runtime

eiriktsarpalis · 2019-11-19T13:20:49Z

Adds the changes initially created for the corefx repo in dotnet/corefx#42560

Adds a console application for stress testing the SslStream class. The work somewhat imitates the setup that we already have in the http stress app: the app will open a fixed number of concurrent connections and run the stress scenaria for a fixed time period per connection (defaults at 2 minutes).
Unlike http2 there are no multiplexing concerns here, so the potential for stress tests seems less interesting. I've only included a single scenario for the moment: sending and echoing back of random data with basic integrity checks, using randomized permutations of Write, WriteAsync, WriteByte and Flush methods. I haven't been able to reproduce failures so far, though I haven't run the app for extensive periods of time yet.

eiriktsarpalis · 2019-11-19T13:23:51Z

NB I can't request reviews from https://github.com/orgs/dotnet/teams/ncl yet, so I'm adding some of you manually. cc @maryamariyan

davidsh · 2019-11-19T19:42:45Z

Adds the changes initially created for the corefx repo in dotnet/corefx#42560

Does this PR incorporate the existing feedback/changes from the corefx repo PR which was already reviewed?

davidsh · 2019-11-19T19:43:19Z

/azp run corefx-outerloop

azure-pipelines · 2019-11-19T19:43:24Z

No pipelines are associated with this pull request.

davidsh · 2019-11-19T19:43:57Z

/azp list

azure-pipelines · 2019-11-19T19:44:02Z

CI/CD Pipelines for this repository: runtime-installer runtime-libraries runtime-coreclr runtime-coreclr outerloop runtime-coreclr crossgen2 runtime-libraries outerloop runtime-libraries outerloop-windows runtime-libraries outerloop-linux runtime-libraries outerloop-osx

davidsh · 2019-11-19T19:44:25Z

/azp runtime-libraries outerloop

azure-pipelines · 2019-11-19T19:44:30Z

Command 'runtime-libraries' is not supported by Azure Pipelines. Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or a specific pipeline for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify a pipeline to run. Example: "run" or "run pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

davidsh · 2019-11-19T19:47:59Z

/azp run runtime-libraries outerloop

azure-pipelines · 2019-11-19T19:48:10Z

Azure Pipelines successfully started running 1 pipeline(s).

eiriktsarpalis · 2019-11-19T21:09:33Z

Does this PR incorporate the existing feedback/changes from the corefx repo PR which was already reviewed?

Mostly yes, with the only outstanding issue being this one. I've been thinking about this, and my conclusion is that I'd prefer it if we didn't reference other test code, at least not until we're not validating the stress projects in CI. Moving forward I would like to consolidate the stress projects into a single solution which are built as part of CI. @stephentoub thoughts?

eiriktsarpalis · 2019-11-20T15:08:05Z

/azp run runtime-libraries outerloop

azure-pipelines · 2019-11-20T15:08:16Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2019-11-23T11:43:25Z

FYI: We are discouraging creating PR branches in the dotnet/runtime repo. Could you please create the branch in your fork next time?

https://github.com/dotnet/consolidation/blob/master/Documentation/issues-pr-management.md#what-will-be-dotnetruntimes-branch-policy

eiriktsarpalis · 2019-11-25T15:22:03Z

@jkotas The branches have been pushed to the main repo deliberately, as it's the only way I can debug the stress pipelines with the changes. I will make sure they are cleaned up as soon as the PRs are merged.

eiriktsarpalis · 2019-11-25T18:13:29Z

/azp list

azure-pipelines · 2019-11-25T18:13:35Z

CI/CD Pipelines for this repository: stress-http-linux runtime-installer runtime-libraries runtime-coreclr runtime-coreclr outerloop runtime-coreclr crossgen2 runtime-libraries outerloop runtime-libraries outerloop-windows runtime-libraries outerloop-linux runtime-libraries outerloop-osx

eiriktsarpalis · 2019-11-26T13:57:56Z

/azp list

azure-pipelines · 2019-11-26T13:58:01Z

CI/CD Pipelines for this repository: coreclr-gc-longrunning runtime-libraries stress-http-windows runtime-libraries stress-http-linux runtime-installer runtime-libraries runtime-coreclr runtime-coreclr outerloop runtime-coreclr crossgen2 runtime-libraries outerloop runtime-libraries outerloop-windows runtime-libraries outerloop-linux runtime-libraries outerloop-osx

eiriktsarpalis · 2019-11-26T14:00:15Z

/azp run runtime-libraries stress-http-windows

azure-pipelines · 2019-11-26T14:00:25Z

Azure Pipelines successfully started running 1 pipeline(s).

eiriktsarpalis · 2019-11-26T14:32:27Z

Closing and re-creating as the publication of the repo has caused issues in my personal fork.

eiriktsarpalis · 2019-11-26T15:19:27Z

Replaced by #290

Merge from dotnet/runtime

eiriktsarpalis requested a review from stephentoub November 19, 2019 13:20

Dotnet-GitSync-Bot added the area-System.Net.Security label Nov 19, 2019

eiriktsarpalis requested review from alnikola, davidsh, scalablecory and wfurt November 19, 2019 13:23

eiriktsarpalis added the tenet-reliability Reliability/stability related issue (stress, load problems, etc.) label Nov 19, 2019

davidsh added this to the 5.0 milestone Nov 19, 2019

davidsh reviewed Nov 20, 2019
View reviewed changes

Comment threadsrc/libraries/System.Net.Security/tests/StressTests/SslStress/Configuration.cs Outdated

davidsh reviewed Nov 20, 2019
View reviewed changes

Comment threadsrc/libraries/System.Net.Security/tests/StressTests/SslStress/SslStress.csproj Outdated

davidsh reviewed Nov 20, 2019
View reviewed changes

Comment threadsrc/libraries/System.Net.Security/tests/StressTests/SslStress/global.json Outdated

eiriktsarpalis added 6 commits November 22, 2019 22:59

move sslstress project to runtime repo
57fb85e

spanify CRC.cs implementation and reference from stress projects
435108d

add extra EoL
1d76ca9

account for Common dependency
5d42e45

fix docker issue
fe830d6

fix typo
7daf26d

eiriktsarpalis added 2 commits November 22, 2019 22:59

use correct relative path
aa9661b

fix docker-compose scenaria
110ca39

eiriktsarpalis closed this Nov 26, 2019

MichalStrehovsky pushed a commit to MichalStrehovsky/runtime that referenced this pull request Oct 12, 2020
Merge pull requestdotnet#123from jkotas/runtime-merge
30d3c2b
Merge from dotnet/runtime

ghost locked as resolved and limited conversation to collaborators Dec 11, 2020

Uh oh!

Conversation

eiriktsarpalis commented Nov 19, 2019

Uh oh!

eiriktsarpalis commented Nov 19, 2019

Uh oh!

davidsh commented Nov 19, 2019

Uh oh!

davidsh commented Nov 19, 2019

Uh oh!

azure-pipelinesBot commented Nov 19, 2019

Uh oh!

davidsh commented Nov 19, 2019

Uh oh!

azure-pipelinesBot commented Nov 19, 2019

Uh oh!

davidsh commented Nov 19, 2019

Uh oh!

azure-pipelinesBot commented Nov 19, 2019

Uh oh!

davidsh commented Nov 19, 2019

Uh oh!

azure-pipelinesBot commented Nov 19, 2019

Uh oh!

eiriktsarpalis commented Nov 19, 2019

Uh oh!

eiriktsarpalis commented Nov 20, 2019

Uh oh!

azure-pipelinesBot commented Nov 20, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas commented Nov 23, 2019

Uh oh!

eiriktsarpalis commented Nov 25, 2019

Uh oh!

eiriktsarpalis commented Nov 25, 2019

Uh oh!

azure-pipelinesBot commented Nov 25, 2019

Uh oh!

eiriktsarpalis commented Nov 26, 2019

Uh oh!

azure-pipelinesBot commented Nov 26, 2019

Uh oh!

eiriktsarpalis commented Nov 26, 2019

Uh oh!

azure-pipelinesBot commented Nov 26, 2019

Uh oh!

eiriktsarpalis commented Nov 26, 2019

Uh oh!

eiriktsarpalis commented Nov 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants