Uh oh!
There was an error while loading. Please reload this page.
[manual] Merge release/8.0-staging into release/8.0 - #123114
Merged
Merged
Conversation
) This pull request updates the following dependencies [marker]: <> (Begin:e82a8e07-8d2b-4a71-e90f-08dbcfd41ade) ## From https://github.com/dotnet/icu - **Subscription**: [e82a8e07-8d2b-4a71-e90f-08dbcfd41ade](https://maestro.dot.net/subscriptions?search=e82a8e07-8d2b-4a71-e90f-08dbcfd41ade) - **Build**: [20251212.3](https://dev.azure.com/dnceng/internal/_build/results?buildId=2859935) ([294543](https://maestro.dot.net/channel/3073/github:dotnet:icu/build/294543)) - **Date Produced**: December 12, 2025 8:16:11 PM UTC - **Commit**: [4bfba9f36e8667005d7a40ade385daabce5fc7d5](dotnet/icu@4bfba9f) - **Branch**: [dotnet/release/8.0](https://github.com/dotnet/icu/tree/dotnet/release/8.0) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [8.0.0-rtm.25565.1 to 8.0.0-rtm.25612.3][1] - Microsoft.NETCore.Runtime.ICU.Transport [1]: dotnet/icu@b565264...4bfba9f [DependencyUpdate]: <> (End) [marker]: <> (End:e82a8e07-8d2b-4a71-e90f-08dbcfd41ade) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…dotnet#122731) This pull request updates the following dependencies [marker]: <> (Begin:c0fef358-3848-4a30-a438-08dbcfd61a5a) ## From https://github.com/dotnet/hotreload-utils - **Subscription**: [c0fef358-3848-4a30-a438-08dbcfd61a5a](https://maestro.dot.net/subscriptions?search=c0fef358-3848-4a30-a438-08dbcfd61a5a) - **Build**: [20251225.3](https://dev.azure.com/dnceng/internal/_build/results?buildId=2867020) ([295569](https://maestro.dot.net/channel/3073/github:dotnet:hotreload-utils/build/295569)) - **Date Produced**: December 25, 2025 11:22:01 AM UTC - **Commit**: [e7e99065bbd4a7b911d5cfa56b23d873d9675355](dotnet/hotreload-utils@e7e9906) - **Branch**: [release/8.0](https://github.com/dotnet/hotreload-utils/tree/release/8.0) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [8.0.0-alpha.0.25574.3 to 8.0.0-alpha.0.25625.3][1] - Microsoft.DotNet.HotReload.Utils.Generator.BuildTool [1]: dotnet/hotreload-utils@cf2f6ad...e7e9906 [DependencyUpdate]: <> (End) [marker]: <> (End:c0fef358-3848-4a30-a438-08dbcfd61a5a) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…otnet#122735) This pull request updates the following dependencies [marker]: <> (Begin:855db5a2-4d17-4346-a439-08dbcfd61a5a) ## From https://github.com/dotnet/runtime-assets - **Subscription**: [855db5a2-4d17-4346-a439-08dbcfd61a5a](https://maestro.dot.net/subscriptions?search=855db5a2-4d17-4346-a439-08dbcfd61a5a) - **Build**: [20251225.3](https://dev.azure.com/dnceng/internal/_build/results?buildId=2867033) ([295573](https://maestro.dot.net/channel/3073/github:dotnet:runtime-assets/build/295573)) - **Date Produced**: December 25, 2025 11:52:55 AM UTC - **Commit**: [98185bc6d28f41decb681555c343a62b3c6c165e](dotnet/runtime-assets@98185bc) - **Branch**: [release/8.0](https://github.com/dotnet/runtime-assets/tree/release/8.0) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [8.0.0-beta.25565.1 to 8.0.0-beta.25625.3][1] - Microsoft.DotNet.CilStrip.Sources - System.ComponentModel.TypeConverter.TestData - System.Data.Common.TestData - System.Drawing.Common.TestData - System.Formats.Tar.TestData - System.IO.Compression.TestData - System.IO.Packaging.TestData - System.Net.TestData - System.Private.Runtime.UnicodeData - System.Runtime.Numerics.TestData - System.Runtime.TimeZoneData - System.Security.Cryptography.X509Certificates.TestData - System.Text.RegularExpressions.TestData - System.Windows.Extensions.TestData [1]: dotnet/runtime-assets@40ac8f2...98185bc [DependencyUpdate]: <> (End) [marker]: <> (End:855db5a2-4d17-4346-a439-08dbcfd61a5a) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
) This pull request updates the following dependencies [marker]: <> (Begin:e82a8e07-8d2b-4a71-e90f-08dbcfd41ade) ## From https://github.com/dotnet/icu - **Subscription**: [e82a8e07-8d2b-4a71-e90f-08dbcfd41ade](https://maestro.dot.net/subscriptions?search=e82a8e07-8d2b-4a71-e90f-08dbcfd41ade) - **Build**: [20251225.2](https://dev.azure.com/dnceng/internal/_build/results?buildId=2867037) ([295579](https://maestro.dot.net/channel/3073/github:dotnet:icu/build/295579)) - **Date Produced**: December 25, 2025 12:12:34 PM UTC - **Commit**: [7e1e01ce174204fc50e1b221c59cbd2c7a752441](dotnet/icu@7e1e01c) - **Branch**: [dotnet/release/8.0](https://github.com/dotnet/icu/tree/dotnet/release/8.0) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [8.0.0-rtm.25612.3 to 8.0.0-rtm.25625.2][1] - Microsoft.NETCore.Runtime.ICU.Transport [1]: dotnet/icu@4bfba9f...7e1e01c [DependencyUpdate]: <> (End) [marker]: <> (End:e82a8e07-8d2b-4a71-e90f-08dbcfd41ade) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…dotnet#122654) Fixes: dotnet#122653 `libopenssl3` is supported and installed by default on all of the supported distro releases listed at https://learn.microsoft.com/en-us/dotnet/core/install/linux-sles?tabs=dotnet8 and https://learn.microsoft.com/en-us/dotnet/core/install/linux-opensuse?tabs=dotnet8 `libopenssl3` is also supported and installed by default on openSUSE Tumbleweed release. This release does not have any other, older, version of this library.
…ine YAML files (dotnet#122417) Adds `fetchTags: false` to Azure Pipelines checkout steps to skip fetching git tags during repository checkout, reducing network overhead and improving checkout performance. ## Changes - Updated 8 YAML files containing 10 total checkout steps in `eng/pipelines/`: - Pipeline templates: `base-job.yml`, `xplat-job.yml`, `build-job.yml` - Stress test pipelines: `http.yml`, `ssl.yml` (2 occurrences each) - Path evaluation and build jobs: `evaluate-paths-job.yml`, `global-build-job.yml` - Official build jobs: `prepare-signed-artifacts.yml` Note: Changes to `eng/common/` templates were excluded as those are shared infrastructure files managed separately. ## Example ```yaml - checkout: self clean: true fetchDepth: $(checkoutFetchDepth) fetchTags: false # Added to skip tag fetching ``` <!-- START COPILOT CODING AGENT SUFFIX --> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > Update the checkout step in the runtime CI yml to specify fetchTags: false. </details> <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com> Co-authored-by: Elinor Fung <elfung@microsoft.com>
…122199) Backport of dotnet#121351 to release/8.0-staging ## Customer Impact Fixes a customer-reported crash in ILLink analyzer in a net8.0 project that uses C# 14 extension members. Customer issue: dotnet#120728 ``` warning AD0001: Analyzer 'ILLink.RoslynAnalyzer.DynamicallyAccessedMembersAnalyzer' threw an exception of type 'System.InvalidCastException' with message 'Unable to cast object of type 'Microsoft.CodeAnalysis.CSharp.Symbols.PublicModel.NonErrorNamedTypeSymbol' to type 'Microsoft.CodeAnalysis.IMethodSymbol'.'. ``` ## Regression No - crash only happens for language features introduced after .NET 8 was released. ## Testing Tested locally. We can't add automated testing because this repo doesn't reference a new enough version of Roslyn to build tests with extension members. ## Risk Low, analyzer-only fix, with limited scope. <hr /> Fixesdotnet#120728 main PR dotnet#121351 # Description Backports fix for analyzer crash when encountering C# 14 extension members. The crash occurred because the analyzer assumed `parameter.ContainingSymbol` is always `IMethodSymbol`, which is false for extension member parameters where the container is an extension type. **Core analyzer changes:** - Remove `MethodParameterValue` constructors that cast `parameter.ContainingSymbol` to `IMethodSymbol` - Require explicit `IMethodSymbol` parameter in `ParameterProxy` constructor - Skip analysis for extension members in `GetParameterTargetValue` (return `TopValue` when `ContainingSymbol` is not `IMethodSymbol`) - Update `VisitInstanceReference` to use new `ParameterProxy` constructor (without unrelated static method checks) **Test infrastructure:** - Add `Microsoft.Net.Compilers.Toolset` package reference for C# preview features - Add workaround in `ResultChecker.cs` to skip validation of compiler-generated extension member types (`<>E__` prefix) - Add `ExtensionsDataFlow.cs` test (enabled) - Add `ExtensionMembersDataFlow.cs` test (disabled until C# 14 available) **Note:** NativeAOT test changes from original PR excluded as `ILCompiler.Trimming.Tests` doesn't exist in 8.0. # Customer Impact Without this fix, the Roslyn analyzer crashes when analyzing code that uses or references C# 14 extension members, breaking the build or IDE experience. # Regression No. This is a new feature compatibility fix for C# 14, not a regression from 8.0 functionality. # Testing - All 60 DataFlow analyzer tests pass - New `ExtensionsDataFlow` test validates fix for regular extension methods - ILLink.RoslynAnalyzer builds cleanly # Risk Low. Changes are surgical and isolated to extension member handling: - Early-exit paths for extension members prevent processing unsupported constructs - Existing code paths unchanged (all parameters with method containers work as before) - Test coverage validates no regressions in standard scenarios # Package authoring signed off? N/A - Changes are internal to analyzer implementation, no public API surface modified. <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > Backport dotnet#121351 to release/8.0-staging. </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> Co-authored-by: Sven Boemer <sbomer@gmail.com>
…otnet#120589) (dotnet#122423) (cherry picked from commit eaafd7c) (cherry picked from commit 1905046) --------- Co-authored-by: Eric StJohn <ericstj@microsoft.com> Co-authored-by: Matous Kozak <matouskozak@seznam.cz> Co-authored-by: Steve Pfister <stpfiste@microsoft.com> Co-authored-by: Filip Navara <filip.navara@gmail.com>
jeffhandley
requested review from
SamMonoRT, lambdageek and thaystg
as code ownersJanuary 13, 2026 01:50
Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
jeffhandley
commented
Jan 13, 2026
MemberAuthor
@dotnet/ncl - The 'System.Net.Http.Functional.Tests' tests have failed twice on |
steveisok
commented
Jan 13, 2026
Member
See #122423 (comment). I think it's ok and is actually #71463 |
steveisok
enabled auto-merge (squash)
January 13, 2026 22:57
steveisok
commented
Jan 13, 2026
Member
steveisok
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were no OOB packages with
<GeneratePackageOnBuild>set totrue, so none needed to be reset tofalse.