Skip to content

Implement IDisposable in BlazorWebWasmLogClient - #123392

Merged
oroztocil merged 2 commits into
oroztocil/asset-caching-test-fixfrom
copilot/sub-pr-123388-again
Jan 20, 2026
Merged

Implement IDisposable in BlazorWebWasmLogClient#123392
oroztocil merged 2 commits into
oroztocil/asset-caching-test-fixfrom
copilot/sub-pr-123388-again

Conversation

CopilotAI commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Description

Addresses resource leak in BlazorWebWasmLogClient which creates an HttpClient but never disposes it, potentially causing socket exhaustion.

Changes

  • BlazorWebWasmLogClient: Implements IDisposable with Dispose() method to clean up HttpClient resource
  • AssetCachingTests: Uses using statement for automatic disposal
// BeforevarrequestLogClient=newBlazorWebWasmLogClient(baseUrl);// AfterusingvarrequestLogClient=newBlazorWebWasmLogClient(baseUrl);

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: oroztocil <79744616+oroztocil@users.noreply.github.com>
CopilotAI changed the title [WIP] Implement IDisposable in Wasm.Build.Tests.AssetCachingTestsImplement IDisposable in BlazorWebWasmLogClientJan 20, 2026
CopilotAI requested a review from oroztocilJanuary 20, 2026 17:47
@oroztocil
oroztocil marked this pull request as ready for review January 20, 2026 17:52
@oroztocil
oroztocil merged commit d8da55b into oroztocil/asset-caching-test-fixJan 20, 2026
12 of 14 checks passed
@oroztocil
oroztocil deleted the copilot/sub-pr-123388-again branch January 21, 2026 10:20
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 21, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@oroztocil