Skip to content

Deny unmasked frame receive for WebSocket Server - #123485

Merged
liveans merged 2 commits into
dotnet:mainfrom
liveans:websocket_server_receive_unmasked_frame_fix
Jan 22, 2026
Merged

Deny unmasked frame receive for WebSocket Server#123485
liveans merged 2 commits into
dotnet:mainfrom
liveans:websocket_server_receive_unmasked_frame_fix

Conversation

@liveans

@liveansliveans commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

Increasing RFC-compliance for WebSocket

@liveans
liveans requested review from a team and CopilotJanuary 22, 2026 10:27
@dotnet-policy-service

dotnet-policy-serviceBot commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @karelz, @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

CopilotAI reviewed Jan 22, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enhances RFC 6455 compliance for WebSocket servers by adding validation to reject unmasked frames from clients. According to the RFC, clients must mask all frames sent to servers, and servers should reject unmasked frames.

Changes:

  • Added validation logic to reject unmasked frames when running as a WebSocket server
  • Added a test case to verify the server properly rejects unmasked frames with appropriate error handling
  • Added a new resource string for the error message

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

FileDescription
src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csAdds server-side validation to reject unmasked frames, mirroring the existing client-side check for masked frames
src/libraries/System.Net.WebSockets/tests/WebSocketTests.csAdds test to verify server rejects unmasked frames and transitions to Aborted state
src/libraries/System.Net.WebSockets/src/Resources/Strings.resxAdds error message resource for unmasked frame rejection

Comment threadsrc/libraries/System.Net.WebSockets/tests/WebSocketTests.cs Outdated
Ahmet Ibrahim Aksoy
Update src/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
74af74a
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CarnaViire
CarnaViire approved these changes Jan 22, 2026
View reviewed changes

@CarnaViireCarnaViire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@liveans
liveans enabled auto-merge (squash) January 22, 2026 12:50
@liveans
liveans merged commit 777287d into dotnet:mainJan 22, 2026
89 checks passed
@dotnet-maestrodotnet-maestroBot mentioned this pull request Jan 23, 2026
Merged
@liveans

liveans commented Jan 27, 2026

Copy link
Copy Markdown
ContributorAuthor

/backport to release/10.0

@github-actions

github-actionsBot commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

Started backporting to release/10.0 (link to workflow run)

@github-actionsgithub-actionsBot mentioned this pull request Jan 27, 2026
Merged
@liveans

liveans commented Jan 27, 2026

Copy link
Copy Markdown
ContributorAuthor

/backport to release/9.0-staging

@github-actions

github-actionsBot commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging (link to workflow run)

@github-actionsgithub-actionsBot mentioned this pull request Jan 27, 2026
Merged
@liveans

liveans commented Jan 27, 2026

Copy link
Copy Markdown
ContributorAuthor

/backport to release/8.0-staging

@github-actions

github-actionsBot commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0-staging (link to workflow run)

@github-actions

github-actionsBot commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

@liveans backporting to release/8.0-staging failed, the patch most likely resulted in conflicts. Please backport manually!

git am output
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchApplying: Deny unmasked frame receive on server.git/rebase-apply/patch:53: trailing whitespace.warning: 1 line adds whitespace errors.Using index info to reconstruct a base tree...M	src/libraries/System.Net.WebSockets/src/Resources/Strings.resxM	src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csM	src/libraries/System.Net.WebSockets/tests/WebSocketTests.csFalling back to patching base and 3-way merge...Auto-merging src/libraries/System.Net.WebSockets/src/Resources/Strings.resxAuto-merging src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csAuto-merging src/libraries/System.Net.WebSockets/tests/WebSocketTests.csCONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets/tests/WebSocketTests.cserror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0001 Deny unmasked frame receive on serverError: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

@liveansliveans mentioned this pull request Jan 27, 2026
Merged
@MihaZupanMihaZupan added this to the 11.0.0 milestone Jan 27, 2026
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 27, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@CarnaViireCarnaViireCarnaViire approved these changes

Assignees

@liveansliveans

Labels

area-System.Net

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@liveans@CarnaViire@MihaZupan
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Deny unmasked frame receive for WebSocket Server by liveans · Pull Request #123485 · dotnet/runtime · GitHub
Skip to content
Deny unmasked frame receive for WebSocket Server - #123485
Merged
liveans merged 2 commits into
dotnet:mainfrom 
liveans:websocket_server_receive_unmasked_frame_fix
Jan 22, 2026
Merged
Deny unmasked frame receive for WebSocket Server#123485
liveans merged 2 commits into
dotnet:mainfrom 
liveans:websocket_server_receive_unmasked_frame_fix
Conversation
@liveans
@liveansliveans
commented
Jan 22, 2026

Copy link


Copy Markdown

Contributor
Increasing RFC-compliance for WebSocket
@liveans
liveans
requested review from
a team and CopilotJanuary 22, 2026 10:27
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jan 22, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @karelz, @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Jan 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This pull request enhances RFC 6455 compliance for WebSocket servers by adding validation to reject unmasked frames from clients. According to the RFC, clients must mask all frames sent to servers, and servers should reject unmasked frames.
Changes:
  • Added validation logic to reject unmasked frames when running as a WebSocket server
  • Added a test case to verify the server properly rejects unmasked frames with appropriate error handling
  • Added a new resource string for the error message
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
FileDescription
src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csAdds server-side validation to reject unmasked frames, mirroring the existing client-side check for masked frames
src/libraries/System.Net.WebSockets/tests/WebSocketTests.csAdds test to verify server rejects unmasked frames and transitions to Aborted state
src/libraries/System.Net.WebSockets/src/Resources/Strings.resxAdds error message resource for unmasked frame rejection
Comment threadsrc/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
Outdated

Ahmet Ibrahim Aksoy
Update src/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
74af74a
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CarnaViire
CarnaViire
approved these changes
Jan 22, 2026
View reviewed changes
@CarnaViireCarnaViire
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@liveans
liveans
enabled auto-merge (squash)
January 22, 2026 12:50
@liveans
liveans
merged commit 777287d
into
dotnet:mainJan 22, 2026

89 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jan 23, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/10.0
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/10.0 (link to workflow run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jan 27, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/9.0-staging
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/9.0-staging (link to workflow run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jan 27, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-staging
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging (link to workflow run)
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
@liveans backporting to release/8.0-staging failed, the patch most likely resulted in conflicts. Please backport manually!
git am output
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchApplying: Deny unmasked frame receive on server.git/rebase-apply/patch:53: trailing whitespace.warning: 1 line adds whitespace errors.Using index info to reconstruct a base tree...M	src/libraries/System.Net.WebSockets/src/Resources/Strings.resxM	src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csM	src/libraries/System.Net.WebSockets/tests/WebSocketTests.csFalling back to patching base and 3-way merge...Auto-merging src/libraries/System.Net.WebSockets/src/Resources/Strings.resxAuto-merging src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csAuto-merging src/libraries/System.Net.WebSockets/tests/WebSocketTests.csCONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets/tests/WebSocketTests.cserror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0001 Deny unmasked frame receive on serverError: The process '/usr/bin/git' failed with exit code 128
Link to workflow output
@liveansliveans
mentioned this pull request
Jan 27, 2026
 Merged

@MihaZupanMihaZupan
added this to the 11.0.0 milestone
Jan 27, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Feb 27, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@CarnaViireCarnaViireCarnaViire approved these changes

Assignees

@liveansliveans

Labels

area-System.Net

Projects


None yet


Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@liveans@CarnaViire@MihaZupan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Deny unmasked frame receive for WebSocket Server by liveans · Pull Request #123485 · dotnet/runtime · GitHub
Skip to content
Deny unmasked frame receive for WebSocket Server - #123485
Merged
liveans merged 2 commits into
dotnet:mainfrom 
liveans:websocket_server_receive_unmasked_frame_fix
Jan 22, 2026
Merged
Deny unmasked frame receive for WebSocket Server#123485
liveans merged 2 commits into
dotnet:mainfrom 
liveans:websocket_server_receive_unmasked_frame_fix
Conversation
@liveans
@liveansliveans
commented
Jan 22, 2026

Copy link


Copy Markdown

Contributor
Increasing RFC-compliance for WebSocket
@liveans
liveans
requested review from
a team and CopilotJanuary 22, 2026 10:27
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jan 22, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @karelz, @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Jan 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This pull request enhances RFC 6455 compliance for WebSocket servers by adding validation to reject unmasked frames from clients. According to the RFC, clients must mask all frames sent to servers, and servers should reject unmasked frames.
Changes:
  • Added validation logic to reject unmasked frames when running as a WebSocket server
  • Added a test case to verify the server properly rejects unmasked frames with appropriate error handling
  • Added a new resource string for the error message
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
FileDescription
src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csAdds server-side validation to reject unmasked frames, mirroring the existing client-side check for masked frames
src/libraries/System.Net.WebSockets/tests/WebSocketTests.csAdds test to verify server rejects unmasked frames and transitions to Aborted state
src/libraries/System.Net.WebSockets/src/Resources/Strings.resxAdds error message resource for unmasked frame rejection
Comment threadsrc/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
Outdated

Ahmet Ibrahim Aksoy
Update src/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
74af74a
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CarnaViire
CarnaViire
approved these changes
Jan 22, 2026
View reviewed changes
@CarnaViireCarnaViire
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@liveans
liveans
enabled auto-merge (squash)
January 22, 2026 12:50
@liveans
liveans
merged commit 777287d
into
dotnet:mainJan 22, 2026

89 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jan 23, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/10.0
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/10.0 (link to workflow run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jan 27, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/9.0-staging
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/9.0-staging (link to workflow run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jan 27, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-staging
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging (link to workflow run)
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
@liveans backporting to release/8.0-staging failed, the patch most likely resulted in conflicts. Please backport manually!
git am output
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchApplying: Deny unmasked frame receive on server.git/rebase-apply/patch:53: trailing whitespace.warning: 1 line adds whitespace errors.Using index info to reconstruct a base tree...M	src/libraries/System.Net.WebSockets/src/Resources/Strings.resxM	src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csM	src/libraries/System.Net.WebSockets/tests/WebSocketTests.csFalling back to patching base and 3-way merge...Auto-merging src/libraries/System.Net.WebSockets/src/Resources/Strings.resxAuto-merging src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csAuto-merging src/libraries/System.Net.WebSockets/tests/WebSocketTests.csCONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets/tests/WebSocketTests.cserror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0001 Deny unmasked frame receive on serverError: The process '/usr/bin/git' failed with exit code 128
Link to workflow output
@liveansliveans
mentioned this pull request
Jan 27, 2026
 Merged

@MihaZupanMihaZupan
added this to the 11.0.0 milestone
Jan 27, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Feb 27, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@CarnaViireCarnaViireCarnaViire approved these changes

Assignees

@liveansliveans

Labels

area-System.Net

Projects


None yet


Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@liveans@CarnaViire@MihaZupan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Deny unmasked frame receive for WebSocket Server by liveans · Pull Request #123485 · dotnet/runtime · GitHub
Skip to content
Deny unmasked frame receive for WebSocket Server - #123485
Merged
liveans merged 2 commits into
dotnet:mainfrom 
liveans:websocket_server_receive_unmasked_frame_fix
Jan 22, 2026
Merged
Deny unmasked frame receive for WebSocket Server#123485
liveans merged 2 commits into
dotnet:mainfrom 
liveans:websocket_server_receive_unmasked_frame_fix
Conversation
@liveans
@liveansliveans
commented
Jan 22, 2026

Copy link


Copy Markdown

Contributor
Increasing RFC-compliance for WebSocket
@liveans
liveans
requested review from
a team and CopilotJanuary 22, 2026 10:27
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jan 22, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @karelz, @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Jan 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This pull request enhances RFC 6455 compliance for WebSocket servers by adding validation to reject unmasked frames from clients. According to the RFC, clients must mask all frames sent to servers, and servers should reject unmasked frames.
Changes:
  • Added validation logic to reject unmasked frames when running as a WebSocket server
  • Added a test case to verify the server properly rejects unmasked frames with appropriate error handling
  • Added a new resource string for the error message
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
FileDescription
src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csAdds server-side validation to reject unmasked frames, mirroring the existing client-side check for masked frames
src/libraries/System.Net.WebSockets/tests/WebSocketTests.csAdds test to verify server rejects unmasked frames and transitions to Aborted state
src/libraries/System.Net.WebSockets/src/Resources/Strings.resxAdds error message resource for unmasked frame rejection
Comment threadsrc/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
Outdated

Ahmet Ibrahim Aksoy
Update src/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
74af74a
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CarnaViire
CarnaViire
approved these changes
Jan 22, 2026
View reviewed changes
@CarnaViireCarnaViire
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@liveans
liveans
enabled auto-merge (squash)
January 22, 2026 12:50
@liveans
liveans
merged commit 777287d
into
dotnet:mainJan 22, 2026

89 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jan 23, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/10.0
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/10.0 (link to workflow run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jan 27, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/9.0-staging
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/9.0-staging (link to workflow run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jan 27, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-staging
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging (link to workflow run)
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
@liveans backporting to release/8.0-staging failed, the patch most likely resulted in conflicts. Please backport manually!
git am output
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchApplying: Deny unmasked frame receive on server.git/rebase-apply/patch:53: trailing whitespace.warning: 1 line adds whitespace errors.Using index info to reconstruct a base tree...M	src/libraries/System.Net.WebSockets/src/Resources/Strings.resxM	src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csM	src/libraries/System.Net.WebSockets/tests/WebSocketTests.csFalling back to patching base and 3-way merge...Auto-merging src/libraries/System.Net.WebSockets/src/Resources/Strings.resxAuto-merging src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csAuto-merging src/libraries/System.Net.WebSockets/tests/WebSocketTests.csCONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets/tests/WebSocketTests.cserror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0001 Deny unmasked frame receive on serverError: The process '/usr/bin/git' failed with exit code 128
Link to workflow output
@liveansliveans
mentioned this pull request
Jan 27, 2026
 Merged

@MihaZupanMihaZupan
added this to the 11.0.0 milestone
Jan 27, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Feb 27, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@CarnaViireCarnaViireCarnaViire approved these changes

Assignees

@liveansliveans

Labels

area-System.Net

Projects


None yet


Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@liveans@CarnaViire@MihaZupan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Deny unmasked frame receive for WebSocket Server by liveans · Pull Request #123485 · dotnet/runtime · GitHub
Skip to content
Deny unmasked frame receive for WebSocket Server - #123485
Merged
liveans merged 2 commits into
dotnet:mainfrom 
liveans:websocket_server_receive_unmasked_frame_fix
Jan 22, 2026
Merged
Deny unmasked frame receive for WebSocket Server#123485
liveans merged 2 commits into
dotnet:mainfrom 
liveans:websocket_server_receive_unmasked_frame_fix
Conversation
@liveans
@liveansliveans
commented
Jan 22, 2026

Copy link


Copy Markdown

Contributor
Increasing RFC-compliance for WebSocket
@liveans
liveans
requested review from
a team and CopilotJanuary 22, 2026 10:27
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jan 22, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @karelz, @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Jan 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This pull request enhances RFC 6455 compliance for WebSocket servers by adding validation to reject unmasked frames from clients. According to the RFC, clients must mask all frames sent to servers, and servers should reject unmasked frames.
Changes:
  • Added validation logic to reject unmasked frames when running as a WebSocket server
  • Added a test case to verify the server properly rejects unmasked frames with appropriate error handling
  • Added a new resource string for the error message
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
FileDescription
src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csAdds server-side validation to reject unmasked frames, mirroring the existing client-side check for masked frames
src/libraries/System.Net.WebSockets/tests/WebSocketTests.csAdds test to verify server rejects unmasked frames and transitions to Aborted state
src/libraries/System.Net.WebSockets/src/Resources/Strings.resxAdds error message resource for unmasked frame rejection
Comment threadsrc/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
Outdated

Ahmet Ibrahim Aksoy
Update src/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
74af74a
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CarnaViire
CarnaViire
approved these changes
Jan 22, 2026
View reviewed changes
@CarnaViireCarnaViire
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@liveans
liveans
enabled auto-merge (squash)
January 22, 2026 12:50
@liveans
liveans
merged commit 777287d
into
dotnet:mainJan 22, 2026

89 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jan 23, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/10.0
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/10.0 (link to workflow run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jan 27, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/9.0-staging
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/9.0-staging (link to workflow run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jan 27, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-staging
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging (link to workflow run)
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
@liveans backporting to release/8.0-staging failed, the patch most likely resulted in conflicts. Please backport manually!
git am output
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchApplying: Deny unmasked frame receive on server.git/rebase-apply/patch:53: trailing whitespace.warning: 1 line adds whitespace errors.Using index info to reconstruct a base tree...M	src/libraries/System.Net.WebSockets/src/Resources/Strings.resxM	src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csM	src/libraries/System.Net.WebSockets/tests/WebSocketTests.csFalling back to patching base and 3-way merge...Auto-merging src/libraries/System.Net.WebSockets/src/Resources/Strings.resxAuto-merging src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csAuto-merging src/libraries/System.Net.WebSockets/tests/WebSocketTests.csCONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets/tests/WebSocketTests.cserror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0001 Deny unmasked frame receive on serverError: The process '/usr/bin/git' failed with exit code 128
Link to workflow output
@liveansliveans
mentioned this pull request
Jan 27, 2026
 Merged

@MihaZupanMihaZupan
added this to the 11.0.0 milestone
Jan 27, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Feb 27, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@CarnaViireCarnaViireCarnaViire approved these changes

Assignees

@liveansliveans

Labels

area-System.Net

Projects


None yet


Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@liveans@CarnaViire@MihaZupan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Deny unmasked frame receive for WebSocket Server by liveans · Pull Request #123485 · dotnet/runtime · GitHub
Skip to content
Deny unmasked frame receive for WebSocket Server - #123485
Merged
liveans merged 2 commits into
dotnet:mainfrom 
liveans:websocket_server_receive_unmasked_frame_fix
Jan 22, 2026
Merged
Deny unmasked frame receive for WebSocket Server#123485
liveans merged 2 commits into
dotnet:mainfrom 
liveans:websocket_server_receive_unmasked_frame_fix
Conversation
@liveans
@liveansliveans
commented
Jan 22, 2026

Copy link


Copy Markdown

Contributor
Increasing RFC-compliance for WebSocket
@liveans
liveans
requested review from
a team and CopilotJanuary 22, 2026 10:27
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jan 22, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @karelz, @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Jan 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This pull request enhances RFC 6455 compliance for WebSocket servers by adding validation to reject unmasked frames from clients. According to the RFC, clients must mask all frames sent to servers, and servers should reject unmasked frames.
Changes:
  • Added validation logic to reject unmasked frames when running as a WebSocket server
  • Added a test case to verify the server properly rejects unmasked frames with appropriate error handling
  • Added a new resource string for the error message
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
FileDescription
src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csAdds server-side validation to reject unmasked frames, mirroring the existing client-side check for masked frames
src/libraries/System.Net.WebSockets/tests/WebSocketTests.csAdds test to verify server rejects unmasked frames and transitions to Aborted state
src/libraries/System.Net.WebSockets/src/Resources/Strings.resxAdds error message resource for unmasked frame rejection
Comment threadsrc/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
Outdated

Ahmet Ibrahim Aksoy
Update src/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
74af74a
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CarnaViire
CarnaViire
approved these changes
Jan 22, 2026
View reviewed changes
@CarnaViireCarnaViire
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@liveans
liveans
enabled auto-merge (squash)
January 22, 2026 12:50
@liveans
liveans
merged commit 777287d
into
dotnet:mainJan 22, 2026

89 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jan 23, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/10.0
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/10.0 (link to workflow run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jan 27, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/9.0-staging
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/9.0-staging (link to workflow run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jan 27, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-staging
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging (link to workflow run)
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
@liveans backporting to release/8.0-staging failed, the patch most likely resulted in conflicts. Please backport manually!
git am output
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchApplying: Deny unmasked frame receive on server.git/rebase-apply/patch:53: trailing whitespace.warning: 1 line adds whitespace errors.Using index info to reconstruct a base tree...M	src/libraries/System.Net.WebSockets/src/Resources/Strings.resxM	src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csM	src/libraries/System.Net.WebSockets/tests/WebSocketTests.csFalling back to patching base and 3-way merge...Auto-merging src/libraries/System.Net.WebSockets/src/Resources/Strings.resxAuto-merging src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csAuto-merging src/libraries/System.Net.WebSockets/tests/WebSocketTests.csCONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets/tests/WebSocketTests.cserror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0001 Deny unmasked frame receive on serverError: The process '/usr/bin/git' failed with exit code 128
Link to workflow output
@liveansliveans
mentioned this pull request
Jan 27, 2026
 Merged

@MihaZupanMihaZupan
added this to the 11.0.0 milestone
Jan 27, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Feb 27, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@CarnaViireCarnaViireCarnaViire approved these changes

Assignees

@liveansliveans

Labels

area-System.Net

Projects


None yet


Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@liveans@CarnaViire@MihaZupan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Deny unmasked frame receive for WebSocket Server by liveans · Pull Request #123485 · dotnet/runtime · GitHub
Skip to content
Deny unmasked frame receive for WebSocket Server - #123485
Merged
liveans merged 2 commits into
dotnet:mainfrom 
liveans:websocket_server_receive_unmasked_frame_fix
Jan 22, 2026
Merged
Deny unmasked frame receive for WebSocket Server#123485
liveans merged 2 commits into
dotnet:mainfrom 
liveans:websocket_server_receive_unmasked_frame_fix
Conversation
@liveans
@liveansliveans
commented
Jan 22, 2026

Copy link


Copy Markdown

Contributor
Increasing RFC-compliance for WebSocket
@liveans
liveans
requested review from
a team and CopilotJanuary 22, 2026 10:27
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jan 22, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @karelz, @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Jan 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This pull request enhances RFC 6455 compliance for WebSocket servers by adding validation to reject unmasked frames from clients. According to the RFC, clients must mask all frames sent to servers, and servers should reject unmasked frames.
Changes:
  • Added validation logic to reject unmasked frames when running as a WebSocket server
  • Added a test case to verify the server properly rejects unmasked frames with appropriate error handling
  • Added a new resource string for the error message
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
FileDescription
src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csAdds server-side validation to reject unmasked frames, mirroring the existing client-side check for masked frames
src/libraries/System.Net.WebSockets/tests/WebSocketTests.csAdds test to verify server rejects unmasked frames and transitions to Aborted state
src/libraries/System.Net.WebSockets/src/Resources/Strings.resxAdds error message resource for unmasked frame rejection
Comment threadsrc/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
Outdated

Ahmet Ibrahim Aksoy
Update src/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
74af74a
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CarnaViire
CarnaViire
approved these changes
Jan 22, 2026
View reviewed changes
@CarnaViireCarnaViire
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@liveans
liveans
enabled auto-merge (squash)
January 22, 2026 12:50
@liveans
liveans
merged commit 777287d
into
dotnet:mainJan 22, 2026

89 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jan 23, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/10.0
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/10.0 (link to workflow run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jan 27, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/9.0-staging
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/9.0-staging (link to workflow run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jan 27, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-staging
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging (link to workflow run)
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
@liveans backporting to release/8.0-staging failed, the patch most likely resulted in conflicts. Please backport manually!
git am output
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchApplying: Deny unmasked frame receive on server.git/rebase-apply/patch:53: trailing whitespace.warning: 1 line adds whitespace errors.Using index info to reconstruct a base tree...M	src/libraries/System.Net.WebSockets/src/Resources/Strings.resxM	src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csM	src/libraries/System.Net.WebSockets/tests/WebSocketTests.csFalling back to patching base and 3-way merge...Auto-merging src/libraries/System.Net.WebSockets/src/Resources/Strings.resxAuto-merging src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csAuto-merging src/libraries/System.Net.WebSockets/tests/WebSocketTests.csCONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets/tests/WebSocketTests.cserror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0001 Deny unmasked frame receive on serverError: The process '/usr/bin/git' failed with exit code 128
Link to workflow output
@liveansliveans
mentioned this pull request
Jan 27, 2026
 Merged

@MihaZupanMihaZupan
added this to the 11.0.0 milestone
Jan 27, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Feb 27, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@CarnaViireCarnaViireCarnaViire approved these changes

Assignees

@liveansliveans

Labels

area-System.Net

Projects


None yet


Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@liveans@CarnaViire@MihaZupan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Deny unmasked frame receive for WebSocket Server by liveans · Pull Request #123485 · dotnet/runtime · GitHub
Skip to content
Deny unmasked frame receive for WebSocket Server - #123485
Merged
liveans merged 2 commits into
dotnet:mainfrom 
liveans:websocket_server_receive_unmasked_frame_fix
Jan 22, 2026
Merged
Deny unmasked frame receive for WebSocket Server#123485
liveans merged 2 commits into
dotnet:mainfrom 
liveans:websocket_server_receive_unmasked_frame_fix
Conversation
@liveans
@liveansliveans
commented
Jan 22, 2026

Copy link


Copy Markdown

Contributor
Increasing RFC-compliance for WebSocket
@liveans
liveans
requested review from
a team and CopilotJanuary 22, 2026 10:27
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jan 22, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @karelz, @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Jan 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This pull request enhances RFC 6455 compliance for WebSocket servers by adding validation to reject unmasked frames from clients. According to the RFC, clients must mask all frames sent to servers, and servers should reject unmasked frames.
Changes:
  • Added validation logic to reject unmasked frames when running as a WebSocket server
  • Added a test case to verify the server properly rejects unmasked frames with appropriate error handling
  • Added a new resource string for the error message
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
FileDescription
src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csAdds server-side validation to reject unmasked frames, mirroring the existing client-side check for masked frames
src/libraries/System.Net.WebSockets/tests/WebSocketTests.csAdds test to verify server rejects unmasked frames and transitions to Aborted state
src/libraries/System.Net.WebSockets/src/Resources/Strings.resxAdds error message resource for unmasked frame rejection
Comment threadsrc/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
Outdated

Ahmet Ibrahim Aksoy
Update src/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
74af74a
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CarnaViire
CarnaViire
approved these changes
Jan 22, 2026
View reviewed changes
@CarnaViireCarnaViire
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@liveans
liveans
enabled auto-merge (squash)
January 22, 2026 12:50
@liveans
liveans
merged commit 777287d
into
dotnet:mainJan 22, 2026

89 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jan 23, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/10.0
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/10.0 (link to workflow run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jan 27, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/9.0-staging
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/9.0-staging (link to workflow run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jan 27, 2026
 Merged

@liveans
liveans
commented
Jan 27, 2026

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-staging
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging (link to workflow run)
@github-actions
github-actionsBot
commented
Jan 27, 2026

Copy link


Copy Markdown

Contributor
@liveans backporting to release/8.0-staging failed, the patch most likely resulted in conflicts. Please backport manually!
git am output
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchApplying: Deny unmasked frame receive on server.git/rebase-apply/patch:53: trailing whitespace.warning: 1 line adds whitespace errors.Using index info to reconstruct a base tree...M	src/libraries/System.Net.WebSockets/src/Resources/Strings.resxM	src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csM	src/libraries/System.Net.WebSockets/tests/WebSocketTests.csFalling back to patching base and 3-way merge...Auto-merging src/libraries/System.Net.WebSockets/src/Resources/Strings.resxAuto-merging src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.csAuto-merging src/libraries/System.Net.WebSockets/tests/WebSocketTests.csCONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets/tests/WebSocketTests.cserror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0001 Deny unmasked frame receive on serverError: The process '/usr/bin/git' failed with exit code 128
Link to workflow output
@liveansliveans
mentioned this pull request
Jan 27, 2026
 Merged

@MihaZupanMihaZupan
added this to the 11.0.0 milestone
Jan 27, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Feb 27, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@CarnaViireCarnaViireCarnaViire approved these changes

Assignees

@liveansliveans

Labels

area-System.Net

Projects


None yet


Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@liveans@CarnaViire@MihaZupan