') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Update native AOT ActiveIssue on NegotiateAuthenticationTests by MichalStrehovsky · Pull Request #123528 · dotnet/runtime · GitHub
Skip to content

Update native AOT ActiveIssue on NegotiateAuthenticationTests - #123528

Merged
MichalStrehovsky merged 1 commit into
mainfrom
MichalStrehovsky-patch-1
Jan 23, 2026
Merged

Update native AOT ActiveIssue on NegotiateAuthenticationTests#123528
MichalStrehovsky merged 1 commit into
mainfrom
MichalStrehovsky-patch-1

Conversation

@MichalStrehovsky

@MichalStrehovskyMichalStrehovsky commented Jan 23, 2026

Copy link
Copy Markdown
Member

I originally saw crashes in Package_Unsupported_NTLM, but looks like everything crashes. So just disable on Linux in general. This time I'll actually run outerloop to verify :(

@MichalStrehovsky
Update native AOT ActiveIssue on NegotiateAuthenticationTests
af8e05c
I originally saw crashes in Package_Unsupported_NTLM, but looks like everything crashes. So just disable on Linux in general. This time I'll run outerloop to verify :(
@MichalStrehovsky

MichalStrehovsky commented Jan 23, 2026

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-nativeaot-outerloop

@dotnet-policy-service

dotnet-policy-serviceBot commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@azure-pipelines

azure-pipelinesBot commented Jan 23, 2026

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

CopilotAI reviewed Jan 23, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ActiveIssue attribute for NegotiateAuthenticationTests to skip all tests in the class on Native AOT + Linux, rather than just skipping a single test. The author discovered that the crashes were not limited to just the Package_Unsupported_NTLM test, but affect the entire test suite.

Changes:

  • Moved ActiveIssue from specific test method to the entire test class
  • Broadened the platform condition from just NativeAot to NativeAot AND Linux
  • Removed the previous method-level ActiveIssue attribute

@rzikm

rzikm commented Jan 23, 2026

Copy link
Copy Markdown
Member

I think we should disable the tests only on the affected OSes, from what I can see from the Kusto DB, the crashes are on Ubuntu 26, likely due to a buggy gss-ntlmssp on the system, we have seen the same on Ubuntu 24 I believe: #113414 .

According to https://launchpad.net/ubuntu/resolute/+source/gss-ntlmssp, Ubuntu 26 still uses the buggy 1.2.0 version as Ubuntu 24

@MichalStrehovsky

MichalStrehovsky commented Jan 23, 2026

Copy link
Copy Markdown
MemberAuthor

I think we should disable the tests only on the affected OSes, from what I can see from the Kusto DB, the crashes are on Ubuntu 26, likely due to a buggy gss-ntlmssp on the system, we have seen the same on Ubuntu 24 I believe: #113414 .

According to https://launchpad.net/ubuntu/resolute/+source/gss-ntlmssp, Ubuntu 26 still uses the buggy 1.2.0 version as Ubuntu 24

AFAIK there's no native AOT specific logic in these codepaths. So the only test coverage we're losing is "random code hits a random bug in native AOT" (i.e. we're looking for native AOT runtime/compiler bugs, not System.Net.Security bugs since those are covered with CoreCLR-JIT).

I'm fine losing this small piece of native AOT coverage if it means I will not have to come back to this and tweak the list before #123472 is fixed. I don't think anyone from dotnet/ncl monitors native AOT outerloops because I always have to do this myself and this is just one of the manymanymanymanymanymany issues that showed up in native AOT outerloops just in the last two weeks.

@MichalStrehovsky

MichalStrehovsky commented Jan 23, 2026

Copy link
Copy Markdown
MemberAuthor

/ba-g native AOT outerloops known to be broken

@MichalStrehovsky
MichalStrehovsky merged commit 8ef2efb into mainJan 23, 2026
109 of 123 checks passed
@MichalStrehovsky
MichalStrehovsky deleted the MichalStrehovsky-patch-1 branch January 23, 2026 12:16
@dotnet-maestrodotnet-maestroBot mentioned this pull request Jan 23, 2026
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 23, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@wfurtwfurtwfurt approved these changes

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-System.Net.Security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MichalStrehovsky@rzikm@wfurt