Skip to content

Added Adler32 to System.IO.Hashing. - #123601

Merged
stephentoub merged 19 commits into
dotnet:mainfrom
AraHaan:add-adler32-to-system-io-hashing
Feb 13, 2026
Merged

Added Adler32 to System.IO.Hashing.#123601
stephentoub merged 19 commits into
dotnet:mainfrom
AraHaan:add-adler32-to-system-io-hashing

Conversation

@AraHaan

@AraHaanAraHaan commented Jan 25, 2026

Copy link
Copy Markdown
Member

Fixes#90191.

@github-actionsgithub-actionsBot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 25, 2026
@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jan 25, 2026
@AraHaan

This comment was marked as outdated.

Sign in to view
@akoeplingerakoeplinger added area-System.IO.Hashing and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 25, 2026
bartonjs
bartonjs reviewed Jan 25, 2026
View reviewed changes
Comment threadsrc/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs Outdated
Comment threadsrc/libraries/System.IO.Hashing/tests/Adler32Tests.cs Outdated
@AraHaan

This comment was marked as outdated.

Sign in to view
stephentoub
stephentoub reviewed Jan 26, 2026
View reviewed changes
Comment threadsrc/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs
huoyaoyuan
huoyaoyuan reviewed Jan 26, 2026
View reviewed changes
Comment threadsrc/libraries/System.IO.Hashing/ref/System.IO.Hashing.cs Outdated
vcsjones
vcsjones reviewed Jan 26, 2026
View reviewed changes
Comment threadsrc/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs Outdated
This was referenced Jan 26, 2026
Open
Open
Open
Closed
vcsjones
vcsjones reviewed Jan 26, 2026
View reviewed changes
Comment threadsrc/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs Outdated
CopilotAI mentioned this pull request Jan 26, 2026
Merged
@AraHaan
AraHaan marked this pull request as ready for review January 27, 2026 15:40
vcsjones
vcsjones reviewed Jan 27, 2026
View reviewed changes
Comment threadsrc/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs Outdated
vcsjones
vcsjones reviewed Jan 27, 2026
View reviewed changes
Comment threadsrc/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs Outdated
JimBobSquarePants
JimBobSquarePants reviewed Jan 28, 2026
View reviewed changes
Comment threadsrc/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs
AraHaan
AraHaan commented Jan 28, 2026
View reviewed changes
Comment threadsrc/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.Vectorized.cs Outdated
@build-analysisbuild-analysisBot mentioned this pull request Jan 28, 2026
Open
3 tasks
vcsjones
vcsjones reviewed Jan 29, 2026
View reviewed changes
Comment threadsrc/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.Avx2Sse.cs Outdated
This was referenced Jan 30, 2026
Closed
Closed
Open
@AraHaan

AraHaan commented Feb 1, 2026

Copy link
Copy Markdown
MemberAuthor

Let me know if these changes look good as is or if any more changes are needed.

@AraHaanAraHaan mentioned this pull request Feb 6, 2026
Closed
stephentoub
stephentoub reviewed Feb 10, 2026
View reviewed changes
Comment threadsrc/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs Outdated
stephentoub
stephentoub reviewed Feb 10, 2026
View reviewed changes
Comment threadsrc/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs Outdated
AraHaanand others added 17 commits February 12, 2026 17:22
@AraHaan@stephentoub
Removed Residue test cases from Adler32Tests.
d593e85
Also another attempt at fixing the expected hash values as well.
@AraHaan@stephentoub
Fixed empty hash value tests.
7a45ac7
Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
@AraHaan@stephentoub
Optimized away needless bounds checking in each access to buf.
99c187d
Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
@AraHaan@stephentoub
Moved Adler32 up in the ref source.
fa7f6a0
Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
@AraHaan@stephentoub
Fix Adler32.Update to return current adler when empty
e541c89
@AraHaan@stephentoub
Moved Base and NMax into locals inside of Update().
6243013
Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
@AraHaan@vcsjones@stephentoub
Update src/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs
8a0acc7
Co-authored-by: Kevin Jones <vcsjones@github.com>
@AraHaan@stephentoub
Fixed writing LittleEndian -> BigEndian
422642d
Added another remarks entry.
@AraHaan@stephentoub
Fixed tests.
b500939
@AraHaan@stephentoub
Added method for vectorized adler32, and moved the normal adler32 cal…
5bf6d94
…c to UpdateScalar(). Also added optional spot where ARM intrinsics can be used in UpdateScalar if vectorization is not possible.
@AraHaan@stephentoub
Added functions for Avx2 and Sse Scalar implementations.
b67347d
@AraHaan@stephentoub
Commented out the optimization paths until they are properly implemen…
b5c5126
…ted.
@AraHaan@stephentoub
Removed commented out code.
2a115c8
Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
@AraHaan@stephentoub
Removed Adler32.Vectorized.cs as it is not used at the moment.
e5b1596
Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
@stephentoub
Apply suggestion from@stephentoub
b32c63f
@stephentoub
Apply suggestion from@stephentoub
0b5b56c
@stephentoub
Add additional tests for larger inputs
55235a4
@stephentoub
stephentoubforce-pushed the add-adler32-to-system-io-hashing branch from f776e19 to 55235a4CompareFebruary 12, 2026 23:18
@stephentoub
stephentoub enabled auto-merge (squash) February 12, 2026 23:19
@stephentoub
stephentoub merged commit fd26ea9 into dotnet:mainFeb 13, 2026
88 of 90 checks passed
This was referenced Feb 13, 2026
Open
Open
Closed
@dotnet-maestrodotnet-maestroBot mentioned this pull request Feb 14, 2026
Merged
@stephentoubstephentoub mentioned this pull request Feb 14, 2026
Merged
@AraHaan
AraHaan deleted the add-adler32-to-system-io-hashing branch February 17, 2026 12:09
iremyux pushed a commit to iremyux/dotnet-runtime that referenced this pull request Mar 2, 2026
@AraHaan@bartonjs
@vcsjones@stephentoub@iremyux
Added Adler32 to System.IO.Hashing. (dotnet#123601)
d8a6e75
Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Co-authored-by: Kevin Jones <vcsjones@github.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 20, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vcsjonesvcsjonesvcsjones left review comments
@stephentoubstephentoubstephentoub approved these changes
@bartonjsbartonjsbartonjs approved these changes
+2 more reviewers
@JimBobSquarePantsJimBobSquarePantsJimBobSquarePants left review comments
@huoyaoyuanhuoyaoyuanhuoyaoyuan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.IO.Hashingcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[API Proposal]: System.IO.Hashing.Adler32 class for computing Adler32 checksums

7 participants

@AraHaan@stephentoub@vcsjones@JimBobSquarePants@huoyaoyuan@bartonjs@akoeplinger