Skip to content

[clr-interp] Workaround c++ compiler bug - #123732

Merged
davidwrighton merged 1 commit into
dotnet:mainfrom
davidwrighton:fix_unwind_issue
Jan 29, 2026
Merged

[clr-interp] Workaround c++ compiler bug#123732
davidwrighton merged 1 commit into
dotnet:mainfrom
davidwrighton:fix_unwind_issue

Conversation

@davidwrighton

@davidwrightondavidwrighton commented Jan 28, 2026•
edited
Loading

Copy link
Copy Markdown
Member

@davidwrighton
[clr-interp] Workaround c++ compiler bug
bec249c
- Disable optimization on InterpCompiler::EmitStaticFieldAccess
- See https://developercommunity.visualstudio.com/t/noreturn-function-called-from-a-function/11035707 for details on the issue
CopilotAI review requested due to automatic review settings January 28, 2026 21:15
CopilotAI reviewed Jan 28, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Windows ARM64-specific workaround for a C++ compiler issue by disabling optimizations around a problematic interpreter compiler routine.

Changes:

  • Disable compiler optimizations for a specific function on TARGET_WINDOWS && TARGET_ARM64 via #pragma optimize("", off/on).
  • Document the workaround with a link to the Visual Studio Developer Community report.

Comment threadsrc/coreclr/interpreter/compiler.cpp
Comment threadsrc/coreclr/interpreter/compiler.cpp
This was referenced Jan 29, 2026
Open
Closed
@davidwrighton

davidwrighton commented Jan 29, 2026

Copy link
Copy Markdown
MemberAuthor

/ba-g known infra failures

@davidwrighton
davidwrighton merged commit 1336003 into dotnet:mainJan 29, 2026
107 of 111 checks passed
@dotnet-maestrodotnet-maestroBot mentioned this pull request Jan 30, 2026
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 1, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@janvorlijanvorlijanvorli approved these changes
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@kgkgAwaiting requested review from kg

Assignees

@davidwrightondavidwrighton

Labels

area-CodeGen-Interpreter-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidwrighton@janvorli