Remove INodeWithSize interface, use IMAGE_REL_SYMBOL_SIZE relocation, and restructure ModuleInfoRow by Copilot · Pull Request #124202 · dotnet/runtime

Copilot · 2026-02-09T22:10:47Z

Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation
Remove HasEndPointer flag and ModuleInfoFlags enum
Update ModuleInfoRow to have SectionId, Length, Start fields
Remove GetLength() method and use Length field directly
Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode
Remove double blank lines left by mechanical removal in ~30 files
Restore single blank lines between methods and logical code sections
Encode dehydrated data length instead of fixup count

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…SIZE reloc Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

dotnet-policy-service · 2026-02-09T22:22:55Z

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

jkoritzinsky · 2026-02-10T00:01:39Z

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove the Flags type there as well.

Finally, update the code in ReadyToRunHeaderNode to require alignment before emitting each entry.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilot · 2026-02-10T00:11:39Z

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove th...

Done. Removed HasEndPointer flag and ModuleInfoFlags enum. Updated ModuleInfoRow to have Start and Length fields instead of Start, End, and Flags. Added alignment requirement before emitting each entry. (5b50167)

jkoritzinsky

@copilot please address this feedback

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilot · 2026-02-10T20:50:30Z

@copilot please address this feedback

All feedback addressed. (cc44d34)

MichalStrehovsky · 2026-02-11T22:29:20Z

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of method bodies.

MichalStrehovsky · 2026-02-11T22:30:07Z

The test failures look related. Pulled down a random crashdump with runfo and looks like GC statics are broken. GC statics are one of the things referenced from R2R header.

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>

Copilot · 2026-02-11T22:45:14Z

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of meth...

Restored single blank lines at all 47 locations across the 30 files. Each location now has exactly one blank line separating method blocks and logical code sections (e.g., between constructor } and next method, between Save() and return, between loop } and next logical section). No double blank lines remain. Build verified clean. (9b06c1e)

jkoritzinsky · 2026-02-13T23:34:30Z

I found one of the issues: The DehydratedDataNode is the only node type that didn't set its "size" to the size of the output object data. So, we'll need to encode in that data stream the number of fixups so we can correctly delineate between the data and fixup sections.

…encode the size of the dehydrated data blob consistendly with other object nodes.

jkoritzinsky · 2026-02-14T00:06:59Z

@MichalStrehovsky pushed a fix. Let me know if it looks good to you.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

MichalStrehovsky

Nice!

… and restructure ModuleInfoRow (dotnet#124202) - [x] Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation - [x] Remove HasEndPointer flag and ModuleInfoFlags enum - [x] Update ModuleInfoRow to have SectionId, Length, Start fields - [x] Remove GetLength() method and use Length field directly - [x] Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode - [x] Remove double blank lines left by mechanical removal in ~30 files - [x] Restore single blank lines between methods and logical code sections - [x] Encode dehydrated data length instead of fixup count  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Copilot · 2026-02-09T22:10:47Z

Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation
Remove HasEndPointer flag and ModuleInfoFlags enum
Update ModuleInfoRow to have SectionId, Length, Start fields
Remove GetLength() method and use Length field directly
Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode
Remove double blank lines left by mechanical removal in ~30 files
Restore single blank lines between methods and logical code sections
Encode dehydrated data length instead of fixup count

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…SIZE reloc Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

dotnet-policy-service · 2026-02-09T22:22:55Z

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

jkoritzinsky · 2026-02-10T00:01:39Z

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove the Flags type there as well.

Finally, update the code in ReadyToRunHeaderNode to require alignment before emitting each entry.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilot · 2026-02-10T00:11:39Z

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove th...

Done. Removed HasEndPointer flag and ModuleInfoFlags enum. Updated ModuleInfoRow to have Start and Length fields instead of Start, End, and Flags. Added alignment requirement before emitting each entry. (5b50167)

jkoritzinsky

@copilot please address this feedback

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilot · 2026-02-10T20:50:30Z

@copilot please address this feedback

All feedback addressed. (cc44d34)

MichalStrehovsky · 2026-02-11T22:29:20Z

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of method bodies.

MichalStrehovsky · 2026-02-11T22:30:07Z

The test failures look related. Pulled down a random crashdump with runfo and looks like GC statics are broken. GC statics are one of the things referenced from R2R header.

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>

Copilot · 2026-02-11T22:45:14Z

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of meth...

Restored single blank lines at all 47 locations across the 30 files. Each location now has exactly one blank line separating method blocks and logical code sections (e.g., between constructor } and next method, between Save() and return, between loop } and next logical section). No double blank lines remain. Build verified clean. (9b06c1e)

jkoritzinsky · 2026-02-13T23:34:30Z

I found one of the issues: The DehydratedDataNode is the only node type that didn't set its "size" to the size of the output object data. So, we'll need to encode in that data stream the number of fixups so we can correctly delineate between the data and fixup sections.

…encode the size of the dehydrated data blob consistendly with other object nodes.

jkoritzinsky · 2026-02-14T00:06:59Z

@MichalStrehovsky pushed a fix. Let me know if it looks good to you.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

MichalStrehovsky

Nice!

… and restructure ModuleInfoRow (dotnet#124202) - [x] Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation - [x] Remove HasEndPointer flag and ModuleInfoFlags enum - [x] Update ModuleInfoRow to have SectionId, Length, Start fields - [x] Remove GetLength() method and use Length field directly - [x] Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode - [x] Remove double blank lines left by mechanical removal in ~30 files - [x] Restore single blank lines between methods and logical code sections - [x] Encode dehydrated data length instead of fixup count  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Copilot · 2026-02-09T22:10:47Z

Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation
Remove HasEndPointer flag and ModuleInfoFlags enum
Update ModuleInfoRow to have SectionId, Length, Start fields
Remove GetLength() method and use Length field directly
Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode
Remove double blank lines left by mechanical removal in ~30 files
Restore single blank lines between methods and logical code sections
Encode dehydrated data length instead of fixup count

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…SIZE reloc Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

dotnet-policy-service · 2026-02-09T22:22:55Z

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

jkoritzinsky · 2026-02-10T00:01:39Z

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove the Flags type there as well.

Finally, update the code in ReadyToRunHeaderNode to require alignment before emitting each entry.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilot · 2026-02-10T00:11:39Z

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove th...

Done. Removed HasEndPointer flag and ModuleInfoFlags enum. Updated ModuleInfoRow to have Start and Length fields instead of Start, End, and Flags. Added alignment requirement before emitting each entry. (5b50167)

jkoritzinsky

@copilot please address this feedback

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilot · 2026-02-10T20:50:30Z

@copilot please address this feedback

All feedback addressed. (cc44d34)

MichalStrehovsky · 2026-02-11T22:29:20Z

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of method bodies.

MichalStrehovsky · 2026-02-11T22:30:07Z

The test failures look related. Pulled down a random crashdump with runfo and looks like GC statics are broken. GC statics are one of the things referenced from R2R header.

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>

Copilot · 2026-02-11T22:45:14Z

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of meth...

Restored single blank lines at all 47 locations across the 30 files. Each location now has exactly one blank line separating method blocks and logical code sections (e.g., between constructor } and next method, between Save() and return, between loop } and next logical section). No double blank lines remain. Build verified clean. (9b06c1e)

jkoritzinsky · 2026-02-13T23:34:30Z

I found one of the issues: The DehydratedDataNode is the only node type that didn't set its "size" to the size of the output object data. So, we'll need to encode in that data stream the number of fixups so we can correctly delineate between the data and fixup sections.

…encode the size of the dehydrated data blob consistendly with other object nodes.

jkoritzinsky · 2026-02-14T00:06:59Z

@MichalStrehovsky pushed a fix. Let me know if it looks good to you.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

MichalStrehovsky

Nice!

… and restructure ModuleInfoRow (dotnet#124202) - [x] Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation - [x] Remove HasEndPointer flag and ModuleInfoFlags enum - [x] Update ModuleInfoRow to have SectionId, Length, Start fields - [x] Remove GetLength() method and use Length field directly - [x] Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode - [x] Remove double blank lines left by mechanical removal in ~30 files - [x] Restore single blank lines between methods and logical code sections - [x] Encode dehydrated data length instead of fixup count  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Copilot · 2026-02-09T22:10:47Z

Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation
Remove HasEndPointer flag and ModuleInfoFlags enum
Update ModuleInfoRow to have SectionId, Length, Start fields
Remove GetLength() method and use Length field directly
Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode
Remove double blank lines left by mechanical removal in ~30 files
Restore single blank lines between methods and logical code sections
Encode dehydrated data length instead of fixup count

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…SIZE reloc Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

dotnet-policy-service · 2026-02-09T22:22:55Z

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

jkoritzinsky · 2026-02-10T00:01:39Z

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove the Flags type there as well.

Finally, update the code in ReadyToRunHeaderNode to require alignment before emitting each entry.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilot · 2026-02-10T00:11:39Z

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove th...

Done. Removed HasEndPointer flag and ModuleInfoFlags enum. Updated ModuleInfoRow to have Start and Length fields instead of Start, End, and Flags. Added alignment requirement before emitting each entry. (5b50167)

jkoritzinsky

@copilot please address this feedback

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilot · 2026-02-10T20:50:30Z

@copilot please address this feedback

All feedback addressed. (cc44d34)

MichalStrehovsky · 2026-02-11T22:29:20Z

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of method bodies.

MichalStrehovsky · 2026-02-11T22:30:07Z

The test failures look related. Pulled down a random crashdump with runfo and looks like GC statics are broken. GC statics are one of the things referenced from R2R header.

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>

Copilot · 2026-02-11T22:45:14Z

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of meth...

Restored single blank lines at all 47 locations across the 30 files. Each location now has exactly one blank line separating method blocks and logical code sections (e.g., between constructor } and next method, between Save() and return, between loop } and next logical section). No double blank lines remain. Build verified clean. (9b06c1e)

jkoritzinsky · 2026-02-13T23:34:30Z

I found one of the issues: The DehydratedDataNode is the only node type that didn't set its "size" to the size of the output object data. So, we'll need to encode in that data stream the number of fixups so we can correctly delineate between the data and fixup sections.

…encode the size of the dehydrated data blob consistendly with other object nodes.

jkoritzinsky · 2026-02-14T00:06:59Z

@MichalStrehovsky pushed a fix. Let me know if it looks good to you.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

MichalStrehovsky

Nice!

… and restructure ModuleInfoRow (dotnet#124202) - [x] Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation - [x] Remove HasEndPointer flag and ModuleInfoFlags enum - [x] Update ModuleInfoRow to have SectionId, Length, Start fields - [x] Remove GetLength() method and use Length field directly - [x] Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode - [x] Remove double blank lines left by mechanical removal in ~30 files - [x] Restore single blank lines between methods and logical code sections - [x] Encode dehydrated data length instead of fixup count  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Copilot · 2026-02-09T22:10:47Z

Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation
Remove HasEndPointer flag and ModuleInfoFlags enum
Update ModuleInfoRow to have SectionId, Length, Start fields
Remove GetLength() method and use Length field directly
Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode
Remove double blank lines left by mechanical removal in ~30 files
Restore single blank lines between methods and logical code sections
Encode dehydrated data length instead of fixup count

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…SIZE reloc Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

dotnet-policy-service · 2026-02-09T22:22:55Z

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

jkoritzinsky · 2026-02-10T00:01:39Z

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove the Flags type there as well.

Finally, update the code in ReadyToRunHeaderNode to require alignment before emitting each entry.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilot · 2026-02-10T00:11:39Z

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove th...

Done. Removed HasEndPointer flag and ModuleInfoFlags enum. Updated ModuleInfoRow to have Start and Length fields instead of Start, End, and Flags. Added alignment requirement before emitting each entry. (5b50167)

jkoritzinsky

@copilot please address this feedback

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilot · 2026-02-10T20:50:30Z

@copilot please address this feedback

All feedback addressed. (cc44d34)

MichalStrehovsky · 2026-02-11T22:29:20Z

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of method bodies.

MichalStrehovsky · 2026-02-11T22:30:07Z

The test failures look related. Pulled down a random crashdump with runfo and looks like GC statics are broken. GC statics are one of the things referenced from R2R header.

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>

Copilot · 2026-02-11T22:45:14Z

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of meth...

Restored single blank lines at all 47 locations across the 30 files. Each location now has exactly one blank line separating method blocks and logical code sections (e.g., between constructor } and next method, between Save() and return, between loop } and next logical section). No double blank lines remain. Build verified clean. (9b06c1e)

jkoritzinsky · 2026-02-13T23:34:30Z

I found one of the issues: The DehydratedDataNode is the only node type that didn't set its "size" to the size of the output object data. So, we'll need to encode in that data stream the number of fixups so we can correctly delineate between the data and fixup sections.

…encode the size of the dehydrated data blob consistendly with other object nodes.

jkoritzinsky · 2026-02-14T00:06:59Z

@MichalStrehovsky pushed a fix. Let me know if it looks good to you.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

MichalStrehovsky

Nice!

… and restructure ModuleInfoRow (dotnet#124202) - [x] Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation - [x] Remove HasEndPointer flag and ModuleInfoFlags enum - [x] Update ModuleInfoRow to have SectionId, Length, Start fields - [x] Remove GetLength() method and use Length field directly - [x] Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode - [x] Remove double blank lines left by mechanical removal in ~30 files - [x] Restore single blank lines between methods and logical code sections - [x] Encode dehydrated data length instead of fixup count  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Copilot · 2026-02-09T22:10:47Z

Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation
Remove HasEndPointer flag and ModuleInfoFlags enum
Update ModuleInfoRow to have SectionId, Length, Start fields
Remove GetLength() method and use Length field directly
Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode
Remove double blank lines left by mechanical removal in ~30 files
Restore single blank lines between methods and logical code sections
Encode dehydrated data length instead of fixup count

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…SIZE reloc Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

dotnet-policy-service · 2026-02-09T22:22:55Z

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

jkoritzinsky · 2026-02-10T00:01:39Z

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove the Flags type there as well.

Finally, update the code in ReadyToRunHeaderNode to require alignment before emitting each entry.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilot · 2026-02-10T00:11:39Z

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove th...

Done. Removed HasEndPointer flag and ModuleInfoFlags enum. Updated ModuleInfoRow to have Start and Length fields instead of Start, End, and Flags. Added alignment requirement before emitting each entry. (5b50167)

jkoritzinsky

@copilot please address this feedback

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilot · 2026-02-10T20:50:30Z

@copilot please address this feedback

All feedback addressed. (cc44d34)

MichalStrehovsky · 2026-02-11T22:29:20Z

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of method bodies.

MichalStrehovsky · 2026-02-11T22:30:07Z

The test failures look related. Pulled down a random crashdump with runfo and looks like GC statics are broken. GC statics are one of the things referenced from R2R header.

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>

Copilot · 2026-02-11T22:45:14Z

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of meth...

Restored single blank lines at all 47 locations across the 30 files. Each location now has exactly one blank line separating method blocks and logical code sections (e.g., between constructor } and next method, between Save() and return, between loop } and next logical section). No double blank lines remain. Build verified clean. (9b06c1e)

jkoritzinsky · 2026-02-13T23:34:30Z

I found one of the issues: The DehydratedDataNode is the only node type that didn't set its "size" to the size of the output object data. So, we'll need to encode in that data stream the number of fixups so we can correctly delineate between the data and fixup sections.

…encode the size of the dehydrated data blob consistendly with other object nodes.

jkoritzinsky · 2026-02-14T00:06:59Z

@MichalStrehovsky pushed a fix. Let me know if it looks good to you.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

MichalStrehovsky

Nice!

… and restructure ModuleInfoRow (dotnet#124202) - [x] Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation - [x] Remove HasEndPointer flag and ModuleInfoFlags enum - [x] Update ModuleInfoRow to have SectionId, Length, Start fields - [x] Remove GetLength() method and use Length field directly - [x] Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode - [x] Remove double blank lines left by mechanical removal in ~30 files - [x] Restore single blank lines between methods and logical code sections - [x] Encode dehydrated data length instead of fixup count  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Copilot · 2026-02-09T22:10:47Z

Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation
Remove HasEndPointer flag and ModuleInfoFlags enum
Update ModuleInfoRow to have SectionId, Length, Start fields
Remove GetLength() method and use Length field directly
Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode
Remove double blank lines left by mechanical removal in ~30 files
Restore single blank lines between methods and logical code sections
Encode dehydrated data length instead of fixup count

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…SIZE reloc Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

dotnet-policy-service · 2026-02-09T22:22:55Z

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

jkoritzinsky · 2026-02-10T00:01:39Z

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove the Flags type there as well.

Finally, update the code in ReadyToRunHeaderNode to require alignment before emitting each entry.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilot · 2026-02-10T00:11:39Z

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove th...

Done. Removed HasEndPointer flag and ModuleInfoFlags enum. Updated ModuleInfoRow to have Start and Length fields instead of Start, End, and Flags. Added alignment requirement before emitting each entry. (5b50167)

jkoritzinsky

@copilot please address this feedback

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilot · 2026-02-10T20:50:30Z

@copilot please address this feedback

All feedback addressed. (cc44d34)

MichalStrehovsky · 2026-02-11T22:29:20Z

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of method bodies.

MichalStrehovsky · 2026-02-11T22:30:07Z

The test failures look related. Pulled down a random crashdump with runfo and looks like GC statics are broken. GC statics are one of the things referenced from R2R header.

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>

Copilot · 2026-02-11T22:45:14Z

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of meth...

Restored single blank lines at all 47 locations across the 30 files. Each location now has exactly one blank line separating method blocks and logical code sections (e.g., between constructor } and next method, between Save() and return, between loop } and next logical section). No double blank lines remain. Build verified clean. (9b06c1e)

jkoritzinsky · 2026-02-13T23:34:30Z

I found one of the issues: The DehydratedDataNode is the only node type that didn't set its "size" to the size of the output object data. So, we'll need to encode in that data stream the number of fixups so we can correctly delineate between the data and fixup sections.

…encode the size of the dehydrated data blob consistendly with other object nodes.

jkoritzinsky · 2026-02-14T00:06:59Z

@MichalStrehovsky pushed a fix. Let me know if it looks good to you.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

MichalStrehovsky

Nice!

… and restructure ModuleInfoRow (dotnet#124202) - [x] Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation - [x] Remove HasEndPointer flag and ModuleInfoFlags enum - [x] Update ModuleInfoRow to have SectionId, Length, Start fields - [x] Remove GetLength() method and use Length field directly - [x] Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode - [x] Remove double blank lines left by mechanical removal in ~30 files - [x] Restore single blank lines between methods and logical code sections - [x] Encode dehydrated data length instead of fixup count  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Copilot · 2026-02-09T22:10:47Z

Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation
Remove HasEndPointer flag and ModuleInfoFlags enum
Update ModuleInfoRow to have SectionId, Length, Start fields
Remove GetLength() method and use Length field directly
Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode
Remove double blank lines left by mechanical removal in ~30 files
Restore single blank lines between methods and logical code sections
Encode dehydrated data length instead of fixup count

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…SIZE reloc Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

dotnet-policy-service · 2026-02-09T22:22:55Z

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

jkoritzinsky · 2026-02-10T00:01:39Z

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove the Flags type there as well.

Finally, update the code in ReadyToRunHeaderNode to require alignment before emitting each entry.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilot · 2026-02-10T00:11:39Z

@copilot please remove the HasEndPointer flag and the Flags field it goes in. Then, update the native ModuleInfoRow type to have a Start field and a Length field instead of Start and End and remove th...

Done. Removed HasEndPointer flag and ModuleInfoFlags enum. Updated ModuleInfoRow to have Start and Length fields instead of Start, End, and Flags. Added alignment requirement before emitting each entry. (5b50167)

jkoritzinsky

@copilot please address this feedback

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilot · 2026-02-10T20:50:30Z

@copilot please address this feedback

All feedback addressed. (cc44d34)

MichalStrehovsky · 2026-02-11T22:29:20Z

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of method bodies.

MichalStrehovsky · 2026-02-11T22:30:07Z

The test failures look related. Pulled down a random crashdump with runfo and looks like GC statics are broken. GC statics are one of the things referenced from R2R header.

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>

Copilot · 2026-02-11T22:45:14Z

@copilot go over the blank lines deleted in this pull request. Make sure a blank line still separates individual method blocks. Make sure a blank line still separates logically different parts of meth...

Restored single blank lines at all 47 locations across the 30 files. Each location now has exactly one blank line separating method blocks and logical code sections (e.g., between constructor } and next method, between Save() and return, between loop } and next logical section). No double blank lines remain. Build verified clean. (9b06c1e)

jkoritzinsky · 2026-02-13T23:34:30Z

I found one of the issues: The DehydratedDataNode is the only node type that didn't set its "size" to the size of the output object data. So, we'll need to encode in that data stream the number of fixups so we can correctly delineate between the data and fixup sections.

…encode the size of the dehydrated data blob consistendly with other object nodes.

jkoritzinsky · 2026-02-14T00:06:59Z

@MichalStrehovsky pushed a fix. Let me know if it looks good to you.

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

MichalStrehovsky

Nice!

… and restructure ModuleInfoRow (dotnet#124202) - [x] Remove INodeWithSize interface and always use IMAGE_REL_SYMBOL_SIZE relocation - [x] Remove HasEndPointer flag and ModuleInfoFlags enum - [x] Update ModuleInfoRow to have SectionId, Length, Start fields - [x] Remove GetLength() method and use Length field directly - [x] Remove Size properties from ProxyTypeMapObjectNode and ExternalTypeMapObjectNode - [x] Remove double blank lines left by mechanical removal in ~30 files - [x] Restore single blank lines between methods and logical code sections - [x] Encode dehydrated data length instead of fixup count  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Initial plan
72ccfc4

CopilotAI assigned Copilot and jkoritzinsky Feb 9, 2026

github-project-automationBot added this to AppModel Feb 9, 2026

Copilotstarted work on behalf of jkoritzinsky February 9, 2026 22:11 View session

Remove INodeWithSize Size property and replace with IMAGE_REL_SYMBOL_…
44ba19f
…SIZE reloc Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

github-actionsBot added the area-NativeAOT-coreclr label Feb 9, 2026

Enhanced INodeWithSize documentation and completed implementation
5abdbe0
Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

CopilotAI changed the title ~~[WIP] Remove INodeWithSize interface and update size emission~~Replace INodeWithSize.Size property with IMAGE_REL_SYMBOL_SIZE relocationFeb 9, 2026

CopilotAI requested a review from jkoritzinsky February 9, 2026 22:27

Copilotfinished work on behalf of jkoritzinsky February 9, 2026 22:27

jkoritzinsky reviewed Feb 9, 2026
View reviewed changes

Comment threadsrc/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/ReadyToRunHeaderNode.cs Outdated

Copilotstarted work on behalf of jkoritzinsky February 9, 2026 22:46 View session

Remove INodeWithSize interface and always emit IMAGE_REL_SYMBOL_SIZE
68bf54c
Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

CopilotAI changed the title ~~Replace INodeWithSize.Size property with IMAGE_REL_SYMBOL_SIZE relocation~~Remove INodeWithSize interface and use IMAGE_REL_SYMBOL_SIZE relocationFeb 9, 2026

CopilotAI requested a review from jkoritzinsky February 9, 2026 22:56

Copilotfinished work on behalf of jkoritzinsky February 9, 2026 22:56

Copilotstarted work on behalf of jkoritzinsky February 10, 2026 00:01 View session

Remove HasEndPointer flag and change ModuleInfoRow to use Length field
5b50167
Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

CopilotAI changed the title ~~Remove INodeWithSize interface and use IMAGE_REL_SYMBOL_SIZE relocation~~Remove INodeWithSize interface, use IMAGE_REL_SYMBOL_SIZE relocation, and restructure ModuleInfoRowFeb 10, 2026

Copilotfinished work on behalf of jkoritzinsky February 10, 2026 00:13

This was referenced Feb 10, 2026
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
[android-arm64] The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#6408
Closed

jkoritzinsky reviewed Feb 10, 2026
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/TypeManager.h Outdated
Comment threadsrc/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/ProxyTypeMapObjectNode.cs
Comment thread...reclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/ExternalTypeMapObjectNode.cs

Copilotstarted work on behalf of jkoritzinsky February 10, 2026 20:41 View session

Remove GetLength method and Size properties as requested in code review
cc44d34
Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

build-analysisBot mentioned this pull request Feb 11, 2026
crossgen2 failing on Linux Arm32 intermittently #124007
Closed

Copilotstarted work on behalf of MichalStrehovsky February 11, 2026 22:29 View session

Restore blank lines between methods and logical code sections
9b06c1e
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>

Copilotfinished work on behalf of MichalStrehovsky February 11, 2026 22:46

build-analysisBot mentioned this pull request Feb 12, 2026
System.Security.Cryptography.CryptographicException : m_safeCertContext is an invalid handle. #124279
Closed

Encode the number of fixups into the dehydrated data to enable us to …
df98fb9
…encode the size of the dehydrated data blob consistendly with other object nodes.

jkoritzinsky mentioned this pull request Feb 14, 2026
Add support for pre-compiling interop type maps in crossgen2 #124352
Merged

MichalStrehovsky reviewed Feb 16, 2026
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Common/src/Internal/Runtime/CompilerHelpers/StartupCodeHelpers.cs Outdated

Copilotstarted work on behalf of jkoritzinsky February 17, 2026 16:18 View session

Encode dehydrated data length instead of fixup count per review feedback
dc812ba
Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>

Copilotfinished work on behalf of jkoritzinsky February 17, 2026 16:30

jkoritzinsky requested a review from MichalStrehovsky February 17, 2026 16:32

jkoritzinsky approved these changes Feb 17, 2026
View reviewed changes

MichalStrehovsky approved these changes Feb 17, 2026
View reviewed changes

jkoritzinsky merged commit 8e6e74e into mainFeb 18, 2026
93 of 96 checks passed

github-project-automationBot moved this to Done in AppModel Feb 18, 2026

jkoritzinsky deleted the copilot/remove-inodewithsize-interface branch February 18, 2026 00:32

dotnet-maestroBot mentioned this pull request Feb 18, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#4923
Merged

github-actionsBot locked and limited conversation to collaborators Mar 20, 2026