Uh oh!
There was an error while loading. Please reload this page.
Publish Uri and UriBuilder threat models - #124273
Conversation
Tagging subscribers to this area: @karelz, @dotnet/ncl |
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive threat model and implementation design documentation for System.Uri and System.UriBuilder. These documents are intended to be referenced from public documentation and provide detailed security considerations, implementation details, and usage guidelines for developers working with URI parsing and construction.
Changes:
- Adds detailed threat model documentation for
System.Uricovering parsing behavior, security considerations, algorithmic complexity, thread safety, and custom parsers - Adds threat model documentation for
System.UriBuildercovering construction, property validation, and security considerations - Documents are placed in
src/libraries/System.Private.Uri/docs/following the pattern of other security documentation in the repository
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/libraries/System.Private.Uri/docs/System.Uri Threat Model.md | Comprehensive 517-line threat model covering Uri parsing phases, component validation, normalization, security considerations, algorithmic complexity guarantees, thread safety, custom parsers, and fuzzing |
src/libraries/System.Private.Uri/docs/System.UriBuilder Threat Model.md | 141-line threat model documenting UriBuilder's mutable builder pattern, component validation, property behavior, and security considerations for URI construction |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com> Co-authored-by: MihaZupan <mihazupan.zupan1@gmail.com>
These are a mix of threat model / implementation design doc.
I'll link to this from public docs once it's merged.
The Fuzzing section refers to a non-existent file for now since I'm waiting on #123932 to get merged first.