[X86][APX] Update the CPUID check logics for APX. - #124624

Merged
tannergooding merged 8 commits into
dotnet:mainfrom
Ruihan-Yin:apx-cpuid-0218
Mar 9, 2026
Merged

[X86][APX] Update the CPUID check logics for APX.#124624
tannergooding merged 8 commits into
dotnet:mainfrom
Ruihan-Yin:apx-cpuid-0218

Conversation

@Ruihan-Yin

@Ruihan-YinRuihan-Yin commented Feb 19, 2026

Copy link
Copy Markdown
Member

This PR is to update the new APX CPUID bits as documented in the specification:
image

This PR is to introduce the new CPUID bit only, and it is not intended to change the JIT behavior based on the presence of the new bit. (APX_F bit will guarantee the new APX_NDD_NCI_NF bit on Intel processors as documented above). All the features and optimizations will be available as long as APX_F bit is set.

CopilotAI review requested due to automatic review settings February 19, 2026 23:21
@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Feb 19, 2026
@dotnet-policy-service

dotnet-policy-serviceBot commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

CopilotAI reviewed Feb 19, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates x86/x64 APX feature detection in minipal_getcpufeatures to incorporate the new APX-related CPUID bit from the updated Intel APX documentation.

Changes:

  • Renames the existing APX CPUID bit comment to APX_F and adds a follow-up CPUID query (leaf 0x29) for APX_NCI_NDD_NF.
  • Requires both APX_F and CPUID.(EAX=29H,ECX=0):EBX[0] to be present before setting XArchIntrinsicConstants_Apx.
  • Re-issues CPUID.(EAX=07H,ECX=1H) after the new leaf 0x29 query to restore state for subsequent checks.

Comment threadsrc/native/minipal/cpufeatures.c Outdated
Comment threadsrc/native/minipal/cpufeatures.c Outdated
Comment threadsrc/native/minipal/cpufeatures.c Outdated
Comment threadsrc/native/minipal/cpufeatures.c Outdated
This was referenced Feb 20, 2026
Open
Closed
This was referenced Feb 20, 2026
Open
Open
@Ruihan-Yin

Ruihan-Yin commented Feb 23, 2026

Copy link
Copy Markdown
MemberAuthor

Build Analysis is green, PR is ready for review.

@Ruihan-Yin
Ruihan-Yin marked this pull request as ready for review February 23, 2026 19:07
CopilotAI review requested due to automatic review settings February 23, 2026 19:07
CopilotAI reviewed Feb 23, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment threadsrc/native/minipal/cpufeatures.c Outdated
@Ruihan-Yin

Ruihan-Yin commented Feb 23, 2026

Copy link
Copy Markdown
MemberAuthor

Failures look irrelevant

Hi @kg@tannergooding , could you please take a look at the PR :)

This was referenced Feb 24, 2026
Open
Open
Open
Closed
tannergooding
tannergooding reviewed Feb 25, 2026
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c Outdated
tannergooding
tannergooding reviewed Feb 27, 2026
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c Outdated
@Ruihan-Yin@tannergooding
Update src/native/minipal/cpufeatures.c
6d42295
resolve comments
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
CopilotAI review requested due to automatic review settings February 27, 2026 22:40
CopilotAI reviewed Mar 2, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@build-analysisbuild-analysisBot mentioned this pull request Mar 2, 2026
Open
@Ruihan-Yin

Ruihan-Yin commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Hi @kg, could you please take a look at this PR? Thanks for any input :)

@kg

kg commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

This looks good to me. Please note that we can't merge this PR until all comments have been resolved, so please address copilot's comments at your earliest convenience. (You aren't obligated to do what it says, but I find it often has useful feedback.)

kg
kg approved these changes Mar 5, 2026
View reviewed changes
@Ruihan-Yin
Update src/native/minipal/cpufeatures.c
f046b4e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings March 5, 2026 22:48
CopilotAI reviewed Mar 5, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment threadsrc/native/minipal/cpufeatures.c Outdated
@tannergooding
tannergooding enabled auto-merge (squash) March 5, 2026 22:55
@Ruihan-Yin
Update src/native/minipal/cpufeatures.c
e0dba1c
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
auto-merge was automatically disabled March 5, 2026 22:56

Head branch was pushed to by a user without write access

CopilotAI review requested due to automatic review settings March 5, 2026 22:56
CopilotAI reviewed Mar 5, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@tannergooding
tannergooding enabled auto-merge (squash) March 5, 2026 23:36
This was referenced Mar 6, 2026
Closed
Closed
@Ruihan-Yin

Ruihan-Yin commented Mar 6, 2026

Copy link
Copy Markdown
MemberAuthor

Failures are from other platform or GC, looks not related to the PR, updating to latest main and rerun CI.

This was referenced Mar 7, 2026
Open
Open
Open
@tannergooding

tannergooding commented Mar 9, 2026

Copy link
Copy Markdown
Member

/ba-g unrelated wasm timeouts

@tannergooding
tannergooding merged commit 919358b into dotnet:mainMar 9, 2026
167 of 172 checks passed
@Ruihan-Yin

Ruihan-Yin commented Mar 9, 2026

Copy link
Copy Markdown
MemberAuthor

Thanks for the reviews and suggestions!

@dotnet-maestrodotnet-maestroBot mentioned this pull request Mar 10, 2026
Merged
@clairikyclairiky mentioned this pull request Apr 1, 2026
Closed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 9, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tannergoodingtannergoodingtannergooding approved these changes
+1 more reviewer
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

Runtime Infra
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ruihan-Yin@kg@tannergooding
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[X86][APX] Update the CPUID check logics for APX. - #124624
Merged
tannergooding merged 8 commits into
dotnet:mainfrom 
Ruihan-Yin:apx-cpuid-0218
Mar 9, 2026
Merged
[X86][APX] Update the CPUID check logics for APX.#124624
tannergooding merged 8 commits into
dotnet:mainfrom 
Ruihan-Yin:apx-cpuid-0218
Conversation
@Ruihan-Yin
@Ruihan-YinRuihan-Yin
commented
Feb 19, 2026

Copy link


Copy Markdown

Member
This PR is to update the new APX CPUID bits as documented in the specification:
image
This PR is to introduce the new CPUID bit only, and it is not intended to change the JIT behavior based on the presence of the new bit. (APX_F bit will guarantee the new APX_NDD_NCI_NF bit on Intel processors as documented above). All the features and optimizations will be available as long as APX_F bit is set.
CopilotAI
review requested due to automatic review settings
February 19, 2026 23:21
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Feb 19, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Feb 19, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Feb 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Updates x86/x64 APX feature detection in minipal_getcpufeatures to incorporate the new APX-related CPUID bit from the updated Intel APX documentation.
Changes:
  • Renames the existing APX CPUID bit comment to APX_F and adds a follow-up CPUID query (leaf 0x29) for APX_NCI_NDD_NF.
  • Requires both APX_F and CPUID.(EAX=29H,ECX=0):EBX[0] to be present before setting XArchIntrinsicConstants_Apx.
  • Re-issues CPUID.(EAX=07H,ECX=1H) after the new leaf 0x29 query to restore state for subsequent checks.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated


This was referenced Feb 20, 2026

Open


Closed


This was referenced Feb 20, 2026

Open


Open

@Ruihan-Yin
Ruihan-Yin
commented
Feb 23, 2026

Copy link


Copy Markdown

MemberAuthor
Build Analysis is green, PR is ready for review.
@Ruihan-Yin
Ruihan-Yin
marked this pull request as ready for review
February 23, 2026 19:07
CopilotAI
review requested due to automatic review settings
February 23, 2026 19:07
CopilotAI
reviewed
Feb 23, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@Ruihan-Yin
Ruihan-Yin
commented
Feb 23, 2026

Copy link


Copy Markdown

MemberAuthor
Failures look irrelevant
Hi @kg@tannergooding , could you please take a look at the PR :)

This was referenced Feb 24, 2026

Open


Open


Open


Closed

tannergooding
tannergooding
reviewed
Feb 25, 2026
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

tannergooding
tannergooding
reviewed
Feb 27, 2026
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@Ruihan-Yin@tannergooding
Update src/native/minipal/cpufeatures.c
6d42295
resolve comments
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
CopilotAI
review requested due to automatic review settings
February 27, 2026 22:40
CopilotAI
reviewed
Mar 2, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
@build-analysisbuild-analysisBot
mentioned this pull request
Mar 2, 2026

Open

@Ruihan-Yin
Ruihan-Yin
commented
Mar 5, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Hi @kg, could you please take a look at this PR? Thanks for any input :)
@kg
kg
commented
Mar 5, 2026

Copy link


Copy Markdown

Contributor
This looks good to me. Please note that we can't merge this PR until all comments have been resolved, so please address copilot's comments at your earliest convenience. (You aren't obligated to do what it says, but I find it often has useful feedback.)
kg
kg
approved these changes
Mar 5, 2026
View reviewed changes
@Ruihan-Yin
Update src/native/minipal/cpufeatures.c
f046b4e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
March 5, 2026 22:48
CopilotAI
reviewed
Mar 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@tannergooding
tannergooding
enabled auto-merge (squash)
March 5, 2026 22:55
@Ruihan-Yin
Update src/native/minipal/cpufeatures.c
e0dba1c
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

auto-merge was automatically disabled
March 5, 2026 22:56
Head branch was pushed to by a user without write access
CopilotAI
review requested due to automatic review settings
March 5, 2026 22:56
CopilotAI
reviewed
Mar 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
@tannergooding
tannergooding
enabled auto-merge (squash)
March 5, 2026 23:36

This was referenced Mar 6, 2026

Closed


Closed

@Ruihan-Yin
Ruihan-Yin
commented
Mar 6, 2026

Copy link


Copy Markdown

MemberAuthor
Failures are from other platform or GC, looks not related to the PR, updating to latest main and rerun CI.

This was referenced Mar 7, 2026

Open


Open


Open

@tannergooding
tannergooding
commented
Mar 9, 2026

Copy link


Copy Markdown

Member
/ba-g unrelated wasm timeouts
@tannergooding
tannergooding
merged commit 919358b
into
dotnet:mainMar 9, 2026

167 of 172 checks passed

@Ruihan-Yin
Ruihan-Yin
commented
Mar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Thanks for the reviews and suggestions!
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Mar 10, 2026
 Merged

@clairikyclairiky
mentioned this pull request
Apr 1, 2026

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Apr 9, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tannergoodingtannergoodingtannergooding approved these changes

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

Runtime Infra

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Ruihan-Yin@kg@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[X86][APX] Update the CPUID check logics for APX. - #124624
Merged
tannergooding merged 8 commits into
dotnet:mainfrom 
Ruihan-Yin:apx-cpuid-0218
Mar 9, 2026
Merged
[X86][APX] Update the CPUID check logics for APX.#124624
tannergooding merged 8 commits into
dotnet:mainfrom 
Ruihan-Yin:apx-cpuid-0218
Conversation
@Ruihan-Yin
@Ruihan-YinRuihan-Yin
commented
Feb 19, 2026

Copy link


Copy Markdown

Member
This PR is to update the new APX CPUID bits as documented in the specification:
image
This PR is to introduce the new CPUID bit only, and it is not intended to change the JIT behavior based on the presence of the new bit. (APX_F bit will guarantee the new APX_NDD_NCI_NF bit on Intel processors as documented above). All the features and optimizations will be available as long as APX_F bit is set.
CopilotAI
review requested due to automatic review settings
February 19, 2026 23:21
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Feb 19, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Feb 19, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Feb 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Updates x86/x64 APX feature detection in minipal_getcpufeatures to incorporate the new APX-related CPUID bit from the updated Intel APX documentation.
Changes:
  • Renames the existing APX CPUID bit comment to APX_F and adds a follow-up CPUID query (leaf 0x29) for APX_NCI_NDD_NF.
  • Requires both APX_F and CPUID.(EAX=29H,ECX=0):EBX[0] to be present before setting XArchIntrinsicConstants_Apx.
  • Re-issues CPUID.(EAX=07H,ECX=1H) after the new leaf 0x29 query to restore state for subsequent checks.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated


This was referenced Feb 20, 2026

Open


Closed


This was referenced Feb 20, 2026

Open


Open

@Ruihan-Yin
Ruihan-Yin
commented
Feb 23, 2026

Copy link


Copy Markdown

MemberAuthor
Build Analysis is green, PR is ready for review.
@Ruihan-Yin
Ruihan-Yin
marked this pull request as ready for review
February 23, 2026 19:07
CopilotAI
review requested due to automatic review settings
February 23, 2026 19:07
CopilotAI
reviewed
Feb 23, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@Ruihan-Yin
Ruihan-Yin
commented
Feb 23, 2026

Copy link


Copy Markdown

MemberAuthor
Failures look irrelevant
Hi @kg@tannergooding , could you please take a look at the PR :)

This was referenced Feb 24, 2026

Open


Open


Open


Closed

tannergooding
tannergooding
reviewed
Feb 25, 2026
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

tannergooding
tannergooding
reviewed
Feb 27, 2026
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@Ruihan-Yin@tannergooding
Update src/native/minipal/cpufeatures.c
6d42295
resolve comments
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
CopilotAI
review requested due to automatic review settings
February 27, 2026 22:40
CopilotAI
reviewed
Mar 2, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
@build-analysisbuild-analysisBot
mentioned this pull request
Mar 2, 2026

Open

@Ruihan-Yin
Ruihan-Yin
commented
Mar 5, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Hi @kg, could you please take a look at this PR? Thanks for any input :)
@kg
kg
commented
Mar 5, 2026

Copy link


Copy Markdown

Contributor
This looks good to me. Please note that we can't merge this PR until all comments have been resolved, so please address copilot's comments at your earliest convenience. (You aren't obligated to do what it says, but I find it often has useful feedback.)
kg
kg
approved these changes
Mar 5, 2026
View reviewed changes
@Ruihan-Yin
Update src/native/minipal/cpufeatures.c
f046b4e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
March 5, 2026 22:48
CopilotAI
reviewed
Mar 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@tannergooding
tannergooding
enabled auto-merge (squash)
March 5, 2026 22:55
@Ruihan-Yin
Update src/native/minipal/cpufeatures.c
e0dba1c
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

auto-merge was automatically disabled
March 5, 2026 22:56
Head branch was pushed to by a user without write access
CopilotAI
review requested due to automatic review settings
March 5, 2026 22:56
CopilotAI
reviewed
Mar 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
@tannergooding
tannergooding
enabled auto-merge (squash)
March 5, 2026 23:36

This was referenced Mar 6, 2026

Closed


Closed

@Ruihan-Yin
Ruihan-Yin
commented
Mar 6, 2026

Copy link


Copy Markdown

MemberAuthor
Failures are from other platform or GC, looks not related to the PR, updating to latest main and rerun CI.

This was referenced Mar 7, 2026

Open


Open


Open

@tannergooding
tannergooding
commented
Mar 9, 2026

Copy link


Copy Markdown

Member
/ba-g unrelated wasm timeouts
@tannergooding
tannergooding
merged commit 919358b
into
dotnet:mainMar 9, 2026

167 of 172 checks passed

@Ruihan-Yin
Ruihan-Yin
commented
Mar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Thanks for the reviews and suggestions!
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Mar 10, 2026
 Merged

@clairikyclairiky
mentioned this pull request
Apr 1, 2026

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Apr 9, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tannergoodingtannergoodingtannergooding approved these changes

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

Runtime Infra

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Ruihan-Yin@kg@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[X86][APX] Update the CPUID check logics for APX. - #124624
Merged
tannergooding merged 8 commits into
dotnet:mainfrom 
Ruihan-Yin:apx-cpuid-0218
Mar 9, 2026
Merged
[X86][APX] Update the CPUID check logics for APX.#124624
tannergooding merged 8 commits into
dotnet:mainfrom 
Ruihan-Yin:apx-cpuid-0218
Conversation
@Ruihan-Yin
@Ruihan-YinRuihan-Yin
commented
Feb 19, 2026

Copy link


Copy Markdown

Member
This PR is to update the new APX CPUID bits as documented in the specification:
image
This PR is to introduce the new CPUID bit only, and it is not intended to change the JIT behavior based on the presence of the new bit. (APX_F bit will guarantee the new APX_NDD_NCI_NF bit on Intel processors as documented above). All the features and optimizations will be available as long as APX_F bit is set.
CopilotAI
review requested due to automatic review settings
February 19, 2026 23:21
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Feb 19, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Feb 19, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Feb 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Updates x86/x64 APX feature detection in minipal_getcpufeatures to incorporate the new APX-related CPUID bit from the updated Intel APX documentation.
Changes:
  • Renames the existing APX CPUID bit comment to APX_F and adds a follow-up CPUID query (leaf 0x29) for APX_NCI_NDD_NF.
  • Requires both APX_F and CPUID.(EAX=29H,ECX=0):EBX[0] to be present before setting XArchIntrinsicConstants_Apx.
  • Re-issues CPUID.(EAX=07H,ECX=1H) after the new leaf 0x29 query to restore state for subsequent checks.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated


This was referenced Feb 20, 2026

Open


Closed


This was referenced Feb 20, 2026

Open


Open

@Ruihan-Yin
Ruihan-Yin
commented
Feb 23, 2026

Copy link


Copy Markdown

MemberAuthor
Build Analysis is green, PR is ready for review.
@Ruihan-Yin
Ruihan-Yin
marked this pull request as ready for review
February 23, 2026 19:07
CopilotAI
review requested due to automatic review settings
February 23, 2026 19:07
CopilotAI
reviewed
Feb 23, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@Ruihan-Yin
Ruihan-Yin
commented
Feb 23, 2026

Copy link


Copy Markdown

MemberAuthor
Failures look irrelevant
Hi @kg@tannergooding , could you please take a look at the PR :)

This was referenced Feb 24, 2026

Open


Open


Open


Closed

tannergooding
tannergooding
reviewed
Feb 25, 2026
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

tannergooding
tannergooding
reviewed
Feb 27, 2026
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@Ruihan-Yin@tannergooding
Update src/native/minipal/cpufeatures.c
6d42295
resolve comments
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
CopilotAI
review requested due to automatic review settings
February 27, 2026 22:40
CopilotAI
reviewed
Mar 2, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
@build-analysisbuild-analysisBot
mentioned this pull request
Mar 2, 2026

Open

@Ruihan-Yin
Ruihan-Yin
commented
Mar 5, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Hi @kg, could you please take a look at this PR? Thanks for any input :)
@kg
kg
commented
Mar 5, 2026

Copy link


Copy Markdown

Contributor
This looks good to me. Please note that we can't merge this PR until all comments have been resolved, so please address copilot's comments at your earliest convenience. (You aren't obligated to do what it says, but I find it often has useful feedback.)
kg
kg
approved these changes
Mar 5, 2026
View reviewed changes
@Ruihan-Yin
Update src/native/minipal/cpufeatures.c
f046b4e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
March 5, 2026 22:48
CopilotAI
reviewed
Mar 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@tannergooding
tannergooding
enabled auto-merge (squash)
March 5, 2026 22:55
@Ruihan-Yin
Update src/native/minipal/cpufeatures.c
e0dba1c
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

auto-merge was automatically disabled
March 5, 2026 22:56
Head branch was pushed to by a user without write access
CopilotAI
review requested due to automatic review settings
March 5, 2026 22:56
CopilotAI
reviewed
Mar 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
@tannergooding
tannergooding
enabled auto-merge (squash)
March 5, 2026 23:36

This was referenced Mar 6, 2026

Closed


Closed

@Ruihan-Yin
Ruihan-Yin
commented
Mar 6, 2026

Copy link


Copy Markdown

MemberAuthor
Failures are from other platform or GC, looks not related to the PR, updating to latest main and rerun CI.

This was referenced Mar 7, 2026

Open


Open


Open

@tannergooding
tannergooding
commented
Mar 9, 2026

Copy link


Copy Markdown

Member
/ba-g unrelated wasm timeouts
@tannergooding
tannergooding
merged commit 919358b
into
dotnet:mainMar 9, 2026

167 of 172 checks passed

@Ruihan-Yin
Ruihan-Yin
commented
Mar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Thanks for the reviews and suggestions!
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Mar 10, 2026
 Merged

@clairikyclairiky
mentioned this pull request
Apr 1, 2026

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Apr 9, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tannergoodingtannergoodingtannergooding approved these changes

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

Runtime Infra

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Ruihan-Yin@kg@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[X86][APX] Update the CPUID check logics for APX. - #124624
Merged
tannergooding merged 8 commits into
dotnet:mainfrom 
Ruihan-Yin:apx-cpuid-0218
Mar 9, 2026
Merged
[X86][APX] Update the CPUID check logics for APX.#124624
tannergooding merged 8 commits into
dotnet:mainfrom 
Ruihan-Yin:apx-cpuid-0218
Conversation
@Ruihan-Yin
@Ruihan-YinRuihan-Yin
commented
Feb 19, 2026

Copy link


Copy Markdown

Member
This PR is to update the new APX CPUID bits as documented in the specification:
image
This PR is to introduce the new CPUID bit only, and it is not intended to change the JIT behavior based on the presence of the new bit. (APX_F bit will guarantee the new APX_NDD_NCI_NF bit on Intel processors as documented above). All the features and optimizations will be available as long as APX_F bit is set.
CopilotAI
review requested due to automatic review settings
February 19, 2026 23:21
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Feb 19, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Feb 19, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Feb 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Updates x86/x64 APX feature detection in minipal_getcpufeatures to incorporate the new APX-related CPUID bit from the updated Intel APX documentation.
Changes:
  • Renames the existing APX CPUID bit comment to APX_F and adds a follow-up CPUID query (leaf 0x29) for APX_NCI_NDD_NF.
  • Requires both APX_F and CPUID.(EAX=29H,ECX=0):EBX[0] to be present before setting XArchIntrinsicConstants_Apx.
  • Re-issues CPUID.(EAX=07H,ECX=1H) after the new leaf 0x29 query to restore state for subsequent checks.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated


This was referenced Feb 20, 2026

Open


Closed


This was referenced Feb 20, 2026

Open


Open

@Ruihan-Yin
Ruihan-Yin
commented
Feb 23, 2026

Copy link


Copy Markdown

MemberAuthor
Build Analysis is green, PR is ready for review.
@Ruihan-Yin
Ruihan-Yin
marked this pull request as ready for review
February 23, 2026 19:07
CopilotAI
review requested due to automatic review settings
February 23, 2026 19:07
CopilotAI
reviewed
Feb 23, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@Ruihan-Yin
Ruihan-Yin
commented
Feb 23, 2026

Copy link


Copy Markdown

MemberAuthor
Failures look irrelevant
Hi @kg@tannergooding , could you please take a look at the PR :)

This was referenced Feb 24, 2026

Open


Open


Open


Closed

tannergooding
tannergooding
reviewed
Feb 25, 2026
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

tannergooding
tannergooding
reviewed
Feb 27, 2026
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@Ruihan-Yin@tannergooding
Update src/native/minipal/cpufeatures.c
6d42295
resolve comments
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
CopilotAI
review requested due to automatic review settings
February 27, 2026 22:40
CopilotAI
reviewed
Mar 2, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
@build-analysisbuild-analysisBot
mentioned this pull request
Mar 2, 2026

Open

@Ruihan-Yin
Ruihan-Yin
commented
Mar 5, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Hi @kg, could you please take a look at this PR? Thanks for any input :)
@kg
kg
commented
Mar 5, 2026

Copy link


Copy Markdown

Contributor
This looks good to me. Please note that we can't merge this PR until all comments have been resolved, so please address copilot's comments at your earliest convenience. (You aren't obligated to do what it says, but I find it often has useful feedback.)
kg
kg
approved these changes
Mar 5, 2026
View reviewed changes
@Ruihan-Yin
Update src/native/minipal/cpufeatures.c
f046b4e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
March 5, 2026 22:48
CopilotAI
reviewed
Mar 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@tannergooding
tannergooding
enabled auto-merge (squash)
March 5, 2026 22:55
@Ruihan-Yin
Update src/native/minipal/cpufeatures.c
e0dba1c
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

auto-merge was automatically disabled
March 5, 2026 22:56
Head branch was pushed to by a user without write access
CopilotAI
review requested due to automatic review settings
March 5, 2026 22:56
CopilotAI
reviewed
Mar 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
@tannergooding
tannergooding
enabled auto-merge (squash)
March 5, 2026 23:36

This was referenced Mar 6, 2026

Closed


Closed

@Ruihan-Yin
Ruihan-Yin
commented
Mar 6, 2026

Copy link


Copy Markdown

MemberAuthor
Failures are from other platform or GC, looks not related to the PR, updating to latest main and rerun CI.

This was referenced Mar 7, 2026

Open


Open


Open

@tannergooding
tannergooding
commented
Mar 9, 2026

Copy link


Copy Markdown

Member
/ba-g unrelated wasm timeouts
@tannergooding
tannergooding
merged commit 919358b
into
dotnet:mainMar 9, 2026

167 of 172 checks passed

@Ruihan-Yin
Ruihan-Yin
commented
Mar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Thanks for the reviews and suggestions!
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Mar 10, 2026
 Merged

@clairikyclairiky
mentioned this pull request
Apr 1, 2026

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Apr 9, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tannergoodingtannergoodingtannergooding approved these changes

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

Runtime Infra

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Ruihan-Yin@kg@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[X86][APX] Update the CPUID check logics for APX. - #124624
Merged
tannergooding merged 8 commits into
dotnet:mainfrom 
Ruihan-Yin:apx-cpuid-0218
Mar 9, 2026
Merged
[X86][APX] Update the CPUID check logics for APX.#124624
tannergooding merged 8 commits into
dotnet:mainfrom 
Ruihan-Yin:apx-cpuid-0218
Conversation
@Ruihan-Yin
@Ruihan-YinRuihan-Yin
commented
Feb 19, 2026

Copy link


Copy Markdown

Member
This PR is to update the new APX CPUID bits as documented in the specification:
image
This PR is to introduce the new CPUID bit only, and it is not intended to change the JIT behavior based on the presence of the new bit. (APX_F bit will guarantee the new APX_NDD_NCI_NF bit on Intel processors as documented above). All the features and optimizations will be available as long as APX_F bit is set.
CopilotAI
review requested due to automatic review settings
February 19, 2026 23:21
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Feb 19, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Feb 19, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Feb 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Updates x86/x64 APX feature detection in minipal_getcpufeatures to incorporate the new APX-related CPUID bit from the updated Intel APX documentation.
Changes:
  • Renames the existing APX CPUID bit comment to APX_F and adds a follow-up CPUID query (leaf 0x29) for APX_NCI_NDD_NF.
  • Requires both APX_F and CPUID.(EAX=29H,ECX=0):EBX[0] to be present before setting XArchIntrinsicConstants_Apx.
  • Re-issues CPUID.(EAX=07H,ECX=1H) after the new leaf 0x29 query to restore state for subsequent checks.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated


This was referenced Feb 20, 2026

Open


Closed


This was referenced Feb 20, 2026

Open


Open

@Ruihan-Yin
Ruihan-Yin
commented
Feb 23, 2026

Copy link


Copy Markdown

MemberAuthor
Build Analysis is green, PR is ready for review.
@Ruihan-Yin
Ruihan-Yin
marked this pull request as ready for review
February 23, 2026 19:07
CopilotAI
review requested due to automatic review settings
February 23, 2026 19:07
CopilotAI
reviewed
Feb 23, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@Ruihan-Yin
Ruihan-Yin
commented
Feb 23, 2026

Copy link


Copy Markdown

MemberAuthor
Failures look irrelevant
Hi @kg@tannergooding , could you please take a look at the PR :)

This was referenced Feb 24, 2026

Open


Open


Open


Closed

tannergooding
tannergooding
reviewed
Feb 25, 2026
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

tannergooding
tannergooding
reviewed
Feb 27, 2026
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@Ruihan-Yin@tannergooding
Update src/native/minipal/cpufeatures.c
6d42295
resolve comments
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
CopilotAI
review requested due to automatic review settings
February 27, 2026 22:40
CopilotAI
reviewed
Mar 2, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
@build-analysisbuild-analysisBot
mentioned this pull request
Mar 2, 2026

Open

@Ruihan-Yin
Ruihan-Yin
commented
Mar 5, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Hi @kg, could you please take a look at this PR? Thanks for any input :)
@kg
kg
commented
Mar 5, 2026

Copy link


Copy Markdown

Contributor
This looks good to me. Please note that we can't merge this PR until all comments have been resolved, so please address copilot's comments at your earliest convenience. (You aren't obligated to do what it says, but I find it often has useful feedback.)
kg
kg
approved these changes
Mar 5, 2026
View reviewed changes
@Ruihan-Yin
Update src/native/minipal/cpufeatures.c
f046b4e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
March 5, 2026 22:48
CopilotAI
reviewed
Mar 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@tannergooding
tannergooding
enabled auto-merge (squash)
March 5, 2026 22:55
@Ruihan-Yin
Update src/native/minipal/cpufeatures.c
e0dba1c
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

auto-merge was automatically disabled
March 5, 2026 22:56
Head branch was pushed to by a user without write access
CopilotAI
review requested due to automatic review settings
March 5, 2026 22:56
CopilotAI
reviewed
Mar 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
@tannergooding
tannergooding
enabled auto-merge (squash)
March 5, 2026 23:36

This was referenced Mar 6, 2026

Closed


Closed

@Ruihan-Yin
Ruihan-Yin
commented
Mar 6, 2026

Copy link


Copy Markdown

MemberAuthor
Failures are from other platform or GC, looks not related to the PR, updating to latest main and rerun CI.

This was referenced Mar 7, 2026

Open


Open


Open

@tannergooding
tannergooding
commented
Mar 9, 2026

Copy link


Copy Markdown

Member
/ba-g unrelated wasm timeouts
@tannergooding
tannergooding
merged commit 919358b
into
dotnet:mainMar 9, 2026

167 of 172 checks passed

@Ruihan-Yin
Ruihan-Yin
commented
Mar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Thanks for the reviews and suggestions!
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Mar 10, 2026
 Merged

@clairikyclairiky
mentioned this pull request
Apr 1, 2026

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Apr 9, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tannergoodingtannergoodingtannergooding approved these changes

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

Runtime Infra

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Ruihan-Yin@kg@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[X86][APX] Update the CPUID check logics for APX. - #124624
Merged
tannergooding merged 8 commits into
dotnet:mainfrom 
Ruihan-Yin:apx-cpuid-0218
Mar 9, 2026
Merged
[X86][APX] Update the CPUID check logics for APX.#124624
tannergooding merged 8 commits into
dotnet:mainfrom 
Ruihan-Yin:apx-cpuid-0218
Conversation
@Ruihan-Yin
@Ruihan-YinRuihan-Yin
commented
Feb 19, 2026

Copy link


Copy Markdown

Member
This PR is to update the new APX CPUID bits as documented in the specification:
image
This PR is to introduce the new CPUID bit only, and it is not intended to change the JIT behavior based on the presence of the new bit. (APX_F bit will guarantee the new APX_NDD_NCI_NF bit on Intel processors as documented above). All the features and optimizations will be available as long as APX_F bit is set.
CopilotAI
review requested due to automatic review settings
February 19, 2026 23:21
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Feb 19, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Feb 19, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Feb 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Updates x86/x64 APX feature detection in minipal_getcpufeatures to incorporate the new APX-related CPUID bit from the updated Intel APX documentation.
Changes:
  • Renames the existing APX CPUID bit comment to APX_F and adds a follow-up CPUID query (leaf 0x29) for APX_NCI_NDD_NF.
  • Requires both APX_F and CPUID.(EAX=29H,ECX=0):EBX[0] to be present before setting XArchIntrinsicConstants_Apx.
  • Re-issues CPUID.(EAX=07H,ECX=1H) after the new leaf 0x29 query to restore state for subsequent checks.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated


This was referenced Feb 20, 2026

Open


Closed


This was referenced Feb 20, 2026

Open


Open

@Ruihan-Yin
Ruihan-Yin
commented
Feb 23, 2026

Copy link


Copy Markdown

MemberAuthor
Build Analysis is green, PR is ready for review.
@Ruihan-Yin
Ruihan-Yin
marked this pull request as ready for review
February 23, 2026 19:07
CopilotAI
review requested due to automatic review settings
February 23, 2026 19:07
CopilotAI
reviewed
Feb 23, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@Ruihan-Yin
Ruihan-Yin
commented
Feb 23, 2026

Copy link


Copy Markdown

MemberAuthor
Failures look irrelevant
Hi @kg@tannergooding , could you please take a look at the PR :)

This was referenced Feb 24, 2026

Open


Open


Open


Closed

tannergooding
tannergooding
reviewed
Feb 25, 2026
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

tannergooding
tannergooding
reviewed
Feb 27, 2026
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@Ruihan-Yin@tannergooding
Update src/native/minipal/cpufeatures.c
6d42295
resolve comments
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
CopilotAI
review requested due to automatic review settings
February 27, 2026 22:40
CopilotAI
reviewed
Mar 2, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
@build-analysisbuild-analysisBot
mentioned this pull request
Mar 2, 2026

Open

@Ruihan-Yin
Ruihan-Yin
commented
Mar 5, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Hi @kg, could you please take a look at this PR? Thanks for any input :)
@kg
kg
commented
Mar 5, 2026

Copy link


Copy Markdown

Contributor
This looks good to me. Please note that we can't merge this PR until all comments have been resolved, so please address copilot's comments at your earliest convenience. (You aren't obligated to do what it says, but I find it often has useful feedback.)
kg
kg
approved these changes
Mar 5, 2026
View reviewed changes
@Ruihan-Yin
Update src/native/minipal/cpufeatures.c
f046b4e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
March 5, 2026 22:48
CopilotAI
reviewed
Mar 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@tannergooding
tannergooding
enabled auto-merge (squash)
March 5, 2026 22:55
@Ruihan-Yin
Update src/native/minipal/cpufeatures.c
e0dba1c
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

auto-merge was automatically disabled
March 5, 2026 22:56
Head branch was pushed to by a user without write access
CopilotAI
review requested due to automatic review settings
March 5, 2026 22:56
CopilotAI
reviewed
Mar 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
@tannergooding
tannergooding
enabled auto-merge (squash)
March 5, 2026 23:36

This was referenced Mar 6, 2026

Closed


Closed

@Ruihan-Yin
Ruihan-Yin
commented
Mar 6, 2026

Copy link


Copy Markdown

MemberAuthor
Failures are from other platform or GC, looks not related to the PR, updating to latest main and rerun CI.

This was referenced Mar 7, 2026

Open


Open


Open

@tannergooding
tannergooding
commented
Mar 9, 2026

Copy link


Copy Markdown

Member
/ba-g unrelated wasm timeouts
@tannergooding
tannergooding
merged commit 919358b
into
dotnet:mainMar 9, 2026

167 of 172 checks passed

@Ruihan-Yin
Ruihan-Yin
commented
Mar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Thanks for the reviews and suggestions!
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Mar 10, 2026
 Merged

@clairikyclairiky
mentioned this pull request
Apr 1, 2026

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Apr 9, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tannergoodingtannergoodingtannergooding approved these changes

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

Runtime Infra

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Ruihan-Yin@kg@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[X86][APX] Update the CPUID check logics for APX. - #124624
Merged
tannergooding merged 8 commits into
dotnet:mainfrom 
Ruihan-Yin:apx-cpuid-0218
Mar 9, 2026
Merged
[X86][APX] Update the CPUID check logics for APX.#124624
tannergooding merged 8 commits into
dotnet:mainfrom 
Ruihan-Yin:apx-cpuid-0218
Conversation
@Ruihan-Yin
@Ruihan-YinRuihan-Yin
commented
Feb 19, 2026

Copy link


Copy Markdown

Member
This PR is to update the new APX CPUID bits as documented in the specification:
image
This PR is to introduce the new CPUID bit only, and it is not intended to change the JIT behavior based on the presence of the new bit. (APX_F bit will guarantee the new APX_NDD_NCI_NF bit on Intel processors as documented above). All the features and optimizations will be available as long as APX_F bit is set.
CopilotAI
review requested due to automatic review settings
February 19, 2026 23:21
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Feb 19, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Feb 19, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Feb 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Updates x86/x64 APX feature detection in minipal_getcpufeatures to incorporate the new APX-related CPUID bit from the updated Intel APX documentation.
Changes:
  • Renames the existing APX CPUID bit comment to APX_F and adds a follow-up CPUID query (leaf 0x29) for APX_NCI_NDD_NF.
  • Requires both APX_F and CPUID.(EAX=29H,ECX=0):EBX[0] to be present before setting XArchIntrinsicConstants_Apx.
  • Re-issues CPUID.(EAX=07H,ECX=1H) after the new leaf 0x29 query to restore state for subsequent checks.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated

Comment threadsrc/native/minipal/cpufeatures.c
Outdated


This was referenced Feb 20, 2026

Open


Closed


This was referenced Feb 20, 2026

Open


Open

@Ruihan-Yin
Ruihan-Yin
commented
Feb 23, 2026

Copy link


Copy Markdown

MemberAuthor
Build Analysis is green, PR is ready for review.
@Ruihan-Yin
Ruihan-Yin
marked this pull request as ready for review
February 23, 2026 19:07
CopilotAI
review requested due to automatic review settings
February 23, 2026 19:07
CopilotAI
reviewed
Feb 23, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@Ruihan-Yin
Ruihan-Yin
commented
Feb 23, 2026

Copy link


Copy Markdown

MemberAuthor
Failures look irrelevant
Hi @kg@tannergooding , could you please take a look at the PR :)

This was referenced Feb 24, 2026

Open


Open


Open


Closed

tannergooding
tannergooding
reviewed
Feb 25, 2026
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

tannergooding
tannergooding
reviewed
Feb 27, 2026
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@Ruihan-Yin@tannergooding
Update src/native/minipal/cpufeatures.c
6d42295
resolve comments
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
CopilotAI
review requested due to automatic review settings
February 27, 2026 22:40
CopilotAI
reviewed
Mar 2, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
@build-analysisbuild-analysisBot
mentioned this pull request
Mar 2, 2026

Open

@Ruihan-Yin
Ruihan-Yin
commented
Mar 5, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Hi @kg, could you please take a look at this PR? Thanks for any input :)
@kg
kg
commented
Mar 5, 2026

Copy link


Copy Markdown

Contributor
This looks good to me. Please note that we can't merge this PR until all comments have been resolved, so please address copilot's comments at your earliest convenience. (You aren't obligated to do what it says, but I find it often has useful feedback.)
kg
kg
approved these changes
Mar 5, 2026
View reviewed changes
@Ruihan-Yin
Update src/native/minipal/cpufeatures.c
f046b4e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
March 5, 2026 22:48
CopilotAI
reviewed
Mar 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/minipal/cpufeatures.c
Outdated

@tannergooding
tannergooding
enabled auto-merge (squash)
March 5, 2026 22:55
@Ruihan-Yin
Update src/native/minipal/cpufeatures.c
e0dba1c
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

auto-merge was automatically disabled
March 5, 2026 22:56
Head branch was pushed to by a user without write access
CopilotAI
review requested due to automatic review settings
March 5, 2026 22:56
CopilotAI
reviewed
Mar 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
@tannergooding
tannergooding
enabled auto-merge (squash)
March 5, 2026 23:36

This was referenced Mar 6, 2026

Closed


Closed

@Ruihan-Yin
Ruihan-Yin
commented
Mar 6, 2026

Copy link


Copy Markdown

MemberAuthor
Failures are from other platform or GC, looks not related to the PR, updating to latest main and rerun CI.

This was referenced Mar 7, 2026

Open


Open


Open

@tannergooding
tannergooding
commented
Mar 9, 2026

Copy link


Copy Markdown

Member
/ba-g unrelated wasm timeouts
@tannergooding
tannergooding
merged commit 919358b
into
dotnet:mainMar 9, 2026

167 of 172 checks passed

@Ruihan-Yin
Ruihan-Yin
commented
Mar 9, 2026

Copy link


Copy Markdown

MemberAuthor
Thanks for the reviews and suggestions!
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Mar 10, 2026
 Merged

@clairikyclairiky
mentioned this pull request
Apr 1, 2026

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Apr 9, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tannergoodingtannergoodingtannergooding approved these changes

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

Runtime Infra

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Ruihan-Yin@kg@tannergooding