Fix premature returns for argument/pointer checks in SOSDacImpl.cs by Copilot · Pull Request #124814 · dotnet/runtime

Copilot · 2026-02-24T20:18:11Z

Description

Argument and pointer validation checks at the start of SOSDacImpl methods were returning early (before the try/catch), bypassing the catch block's HResult conversion and the #if DEBUG legacy comparison block.

Changes

E_INVALIDARG checks → moved inside try, replaced return HResults.E_INVALIDARG with throw new ArgumentException()
E_POINTER checks → moved inside try, replaced return HResults.E_POINTER with throw new NullReferenceException()
if/else guard patterns (ISOSDacInterface14 methods, GetILForModule, GetMethodDescFromToken, TraverseModuleMap) → flattened into unified try/catch with throws
Switch default: cases (GetMethodDescFromToken, TraverseModuleMap) → replaced hr = HResults.E_INVALIDARG with throw new ArgumentException() so execution halts rather than falling through
GetPEFileName → inner return HResults.E_NOTIMPL inside try replaced with throw new NotImplementedException() to prevent CopyStringToBuffer from running on empty paths
SOSMethodEnum.GetCount → added try/catch wrapper; return HResults.E_POINTER → throw new NullReferenceException()
GetThreadFromThinlockID → fixed latent bug: null check was setting hr but not preventing the try block from running, causing *pThread dereference on a null pointer

Before / After pattern:

// Before — bypasses catch and #if DEBUG blockintISOSDacInterface.GetThreadData(ClrDataAddressthread,DacpThreadData*data){if(thread==0||data==null)returnHResults.E_INVALIDARG;// skips try/catch and DEBUG comparisoninthr=HResults.S_OK;try{ ...}catch(Exceptionex){hr=ex.HResult;}
...}// After — check participates in unified error handlingintISOSDacInterface.GetThreadData(ClrDataAddressthread,DacpThreadData*data){inthr=HResults.S_OK;try{if(thread==0||data==null)thrownewArgumentException();
...}catch(Exceptionex){hr=ex.HResult;}
...}

Testing

All 832 existing cDAC unit tests pass.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

dotnet-policy-service · 2026-02-24T20:21:12Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

…x GetPEFileName E_NOTIMPL Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

max-charlamb

lgtm, nice cleanup.

Especially good find on the bug in GetThreadFromThinlockID

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot

Pull request overview

This pull request refactors error handling in SOSDacImpl.cs by moving argument and pointer validation checks from before try blocks to inside try blocks, converting early returns to thrown exceptions. The goal is to ensure that the catch block can handle HResult conversion and that DEBUG comparison blocks work correctly.

Changes:

Moved null pointer and invalid argument checks from before try blocks to inside try blocks across approximately 30 methods
Changed early return HResults.E_INVALIDARG statements to throw new ArgumentException() inside try blocks
Changed early return HResults.E_POINTER statements to throw new NullReferenceException() inside try blocks
Restructured methods like GetILForModule, GetMethodDescFromToken, and TraverseModuleMap from if/else structures to unified try/catch blocks
Added try/catch wrapper to SOSMethodEnum.GetCount

…atch, use heapData.GenerationTable.Count, and use local buffers for debug cross-validation - Change void* to DacpGenerationData* in ISOSDacInterface8 methods - Move null/validation checks inside try/catch blocks per PR dotnet#124814 pattern - Replace ReadGlobal<uint>(TotalGenerationCount) with heapData.GenerationTable.Count - Use local buffers for legacy DAC cross-validation to avoid overwriting cDAC data - Use 'is null'/'is not null' instead of '== null'/'!= null' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…otnet#124814) ## Description Argument and pointer validation checks at the start of `SOSDacImpl` methods were returning early (before the `try/catch`), bypassing the catch block's HResult conversion and the `#if DEBUG` legacy comparison block. ### Changes - **E_INVALIDARG checks** → moved inside `try`, replaced `return HResults.E_INVALIDARG` with `throw new ArgumentException()` - **E_POINTER checks** → moved inside `try`, replaced `return HResults.E_POINTER` with `throw new NullReferenceException()` - **`if/else` guard patterns** (ISOSDacInterface14 methods, `GetILForModule`, `GetMethodDescFromToken`, `TraverseModuleMap`) → flattened into unified `try/catch` with throws - **Switch `default:` cases** (`GetMethodDescFromToken`, `TraverseModuleMap`) → replaced `hr = HResults.E_INVALIDARG` with `throw new ArgumentException()` so execution halts rather than falling through - **`GetPEFileName`** → inner `return HResults.E_NOTIMPL` inside `try` replaced with `throw new NotImplementedException()` to prevent `CopyStringToBuffer` from running on empty paths - **`SOSMethodEnum.GetCount`** → added `try/catch` wrapper; `return HResults.E_POINTER` → `throw new NullReferenceException()` - **`GetThreadFromThinlockID`** → fixed latent bug: null check was setting `hr` but not preventing the `try` block from running, causing `*pThread` dereference on a null pointer **Before / After pattern:** ```csharp // Before — bypasses catch and #if DEBUG block int ISOSDacInterface.GetThreadData(ClrDataAddress thread, DacpThreadData* data) { if (thread == 0 || data == null) return HResults.E_INVALIDARG; // skips try/catch and DEBUG comparison int hr = HResults.S_OK; try { ... } catch (Exception ex) { hr = ex.HResult; } ... } // After — check participates in unified error handling int ISOSDacInterface.GetThreadData(ClrDataAddress thread, DacpThreadData* data) { int hr = HResults.S_OK; try { if (thread == 0 || data == null) throw new ArgumentException(); ... } catch (Exception ex) { hr = ex.HResult; } ... } ``` ## Testing - All 832 existing cDAC unit tests pass.  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot · 2026-02-24T20:18:11Z

Description

Argument and pointer validation checks at the start of SOSDacImpl methods were returning early (before the try/catch), bypassing the catch block's HResult conversion and the #if DEBUG legacy comparison block.

Changes

E_INVALIDARG checks → moved inside try, replaced return HResults.E_INVALIDARG with throw new ArgumentException()
E_POINTER checks → moved inside try, replaced return HResults.E_POINTER with throw new NullReferenceException()
if/else guard patterns (ISOSDacInterface14 methods, GetILForModule, GetMethodDescFromToken, TraverseModuleMap) → flattened into unified try/catch with throws
Switch default: cases (GetMethodDescFromToken, TraverseModuleMap) → replaced hr = HResults.E_INVALIDARG with throw new ArgumentException() so execution halts rather than falling through
GetPEFileName → inner return HResults.E_NOTIMPL inside try replaced with throw new NotImplementedException() to prevent CopyStringToBuffer from running on empty paths
SOSMethodEnum.GetCount → added try/catch wrapper; return HResults.E_POINTER → throw new NullReferenceException()
GetThreadFromThinlockID → fixed latent bug: null check was setting hr but not preventing the try block from running, causing *pThread dereference on a null pointer

Before / After pattern:

// Before — bypasses catch and #if DEBUG blockintISOSDacInterface.GetThreadData(ClrDataAddressthread,DacpThreadData*data){if(thread==0||data==null)returnHResults.E_INVALIDARG;// skips try/catch and DEBUG comparisoninthr=HResults.S_OK;try{ ...}catch(Exceptionex){hr=ex.HResult;}
...}// After — check participates in unified error handlingintISOSDacInterface.GetThreadData(ClrDataAddressthread,DacpThreadData*data){inthr=HResults.S_OK;try{if(thread==0||data==null)thrownewArgumentException();
...}catch(Exceptionex){hr=ex.HResult;}
...}

Testing

All 832 existing cDAC unit tests pass.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

dotnet-policy-service · 2026-02-24T20:21:12Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

…x GetPEFileName E_NOTIMPL Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

max-charlamb

lgtm, nice cleanup.

Especially good find on the bug in GetThreadFromThinlockID

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot

Pull request overview

This pull request refactors error handling in SOSDacImpl.cs by moving argument and pointer validation checks from before try blocks to inside try blocks, converting early returns to thrown exceptions. The goal is to ensure that the catch block can handle HResult conversion and that DEBUG comparison blocks work correctly.

Changes:

Moved null pointer and invalid argument checks from before try blocks to inside try blocks across approximately 30 methods
Changed early return HResults.E_INVALIDARG statements to throw new ArgumentException() inside try blocks
Changed early return HResults.E_POINTER statements to throw new NullReferenceException() inside try blocks
Restructured methods like GetILForModule, GetMethodDescFromToken, and TraverseModuleMap from if/else structures to unified try/catch blocks
Added try/catch wrapper to SOSMethodEnum.GetCount

…atch, use heapData.GenerationTable.Count, and use local buffers for debug cross-validation - Change void* to DacpGenerationData* in ISOSDacInterface8 methods - Move null/validation checks inside try/catch blocks per PR dotnet#124814 pattern - Replace ReadGlobal<uint>(TotalGenerationCount) with heapData.GenerationTable.Count - Use local buffers for legacy DAC cross-validation to avoid overwriting cDAC data - Use 'is null'/'is not null' instead of '== null'/'!= null' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…otnet#124814) ## Description Argument and pointer validation checks at the start of `SOSDacImpl` methods were returning early (before the `try/catch`), bypassing the catch block's HResult conversion and the `#if DEBUG` legacy comparison block. ### Changes - **E_INVALIDARG checks** → moved inside `try`, replaced `return HResults.E_INVALIDARG` with `throw new ArgumentException()` - **E_POINTER checks** → moved inside `try`, replaced `return HResults.E_POINTER` with `throw new NullReferenceException()` - **`if/else` guard patterns** (ISOSDacInterface14 methods, `GetILForModule`, `GetMethodDescFromToken`, `TraverseModuleMap`) → flattened into unified `try/catch` with throws - **Switch `default:` cases** (`GetMethodDescFromToken`, `TraverseModuleMap`) → replaced `hr = HResults.E_INVALIDARG` with `throw new ArgumentException()` so execution halts rather than falling through - **`GetPEFileName`** → inner `return HResults.E_NOTIMPL` inside `try` replaced with `throw new NotImplementedException()` to prevent `CopyStringToBuffer` from running on empty paths - **`SOSMethodEnum.GetCount`** → added `try/catch` wrapper; `return HResults.E_POINTER` → `throw new NullReferenceException()` - **`GetThreadFromThinlockID`** → fixed latent bug: null check was setting `hr` but not preventing the `try` block from running, causing `*pThread` dereference on a null pointer **Before / After pattern:** ```csharp // Before — bypasses catch and #if DEBUG block int ISOSDacInterface.GetThreadData(ClrDataAddress thread, DacpThreadData* data) { if (thread == 0 || data == null) return HResults.E_INVALIDARG; // skips try/catch and DEBUG comparison int hr = HResults.S_OK; try { ... } catch (Exception ex) { hr = ex.HResult; } ... } // After — check participates in unified error handling int ISOSDacInterface.GetThreadData(ClrDataAddress thread, DacpThreadData* data) { int hr = HResults.S_OK; try { if (thread == 0 || data == null) throw new ArgumentException(); ... } catch (Exception ex) { hr = ex.HResult; } ... } ``` ## Testing - All 832 existing cDAC unit tests pass.  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot · 2026-02-24T20:18:11Z

Description

Argument and pointer validation checks at the start of SOSDacImpl methods were returning early (before the try/catch), bypassing the catch block's HResult conversion and the #if DEBUG legacy comparison block.

Changes

E_INVALIDARG checks → moved inside try, replaced return HResults.E_INVALIDARG with throw new ArgumentException()
E_POINTER checks → moved inside try, replaced return HResults.E_POINTER with throw new NullReferenceException()
if/else guard patterns (ISOSDacInterface14 methods, GetILForModule, GetMethodDescFromToken, TraverseModuleMap) → flattened into unified try/catch with throws
Switch default: cases (GetMethodDescFromToken, TraverseModuleMap) → replaced hr = HResults.E_INVALIDARG with throw new ArgumentException() so execution halts rather than falling through
GetPEFileName → inner return HResults.E_NOTIMPL inside try replaced with throw new NotImplementedException() to prevent CopyStringToBuffer from running on empty paths
SOSMethodEnum.GetCount → added try/catch wrapper; return HResults.E_POINTER → throw new NullReferenceException()
GetThreadFromThinlockID → fixed latent bug: null check was setting hr but not preventing the try block from running, causing *pThread dereference on a null pointer

Before / After pattern:

// Before — bypasses catch and #if DEBUG blockintISOSDacInterface.GetThreadData(ClrDataAddressthread,DacpThreadData*data){if(thread==0||data==null)returnHResults.E_INVALIDARG;// skips try/catch and DEBUG comparisoninthr=HResults.S_OK;try{ ...}catch(Exceptionex){hr=ex.HResult;}
...}// After — check participates in unified error handlingintISOSDacInterface.GetThreadData(ClrDataAddressthread,DacpThreadData*data){inthr=HResults.S_OK;try{if(thread==0||data==null)thrownewArgumentException();
...}catch(Exceptionex){hr=ex.HResult;}
...}

Testing

All 832 existing cDAC unit tests pass.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

dotnet-policy-service · 2026-02-24T20:21:12Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

…x GetPEFileName E_NOTIMPL Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

max-charlamb

lgtm, nice cleanup.

Especially good find on the bug in GetThreadFromThinlockID

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot

Pull request overview

This pull request refactors error handling in SOSDacImpl.cs by moving argument and pointer validation checks from before try blocks to inside try blocks, converting early returns to thrown exceptions. The goal is to ensure that the catch block can handle HResult conversion and that DEBUG comparison blocks work correctly.

Changes:

Moved null pointer and invalid argument checks from before try blocks to inside try blocks across approximately 30 methods
Changed early return HResults.E_INVALIDARG statements to throw new ArgumentException() inside try blocks
Changed early return HResults.E_POINTER statements to throw new NullReferenceException() inside try blocks
Restructured methods like GetILForModule, GetMethodDescFromToken, and TraverseModuleMap from if/else structures to unified try/catch blocks
Added try/catch wrapper to SOSMethodEnum.GetCount

…atch, use heapData.GenerationTable.Count, and use local buffers for debug cross-validation - Change void* to DacpGenerationData* in ISOSDacInterface8 methods - Move null/validation checks inside try/catch blocks per PR dotnet#124814 pattern - Replace ReadGlobal<uint>(TotalGenerationCount) with heapData.GenerationTable.Count - Use local buffers for legacy DAC cross-validation to avoid overwriting cDAC data - Use 'is null'/'is not null' instead of '== null'/'!= null' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…otnet#124814) ## Description Argument and pointer validation checks at the start of `SOSDacImpl` methods were returning early (before the `try/catch`), bypassing the catch block's HResult conversion and the `#if DEBUG` legacy comparison block. ### Changes - **E_INVALIDARG checks** → moved inside `try`, replaced `return HResults.E_INVALIDARG` with `throw new ArgumentException()` - **E_POINTER checks** → moved inside `try`, replaced `return HResults.E_POINTER` with `throw new NullReferenceException()` - **`if/else` guard patterns** (ISOSDacInterface14 methods, `GetILForModule`, `GetMethodDescFromToken`, `TraverseModuleMap`) → flattened into unified `try/catch` with throws - **Switch `default:` cases** (`GetMethodDescFromToken`, `TraverseModuleMap`) → replaced `hr = HResults.E_INVALIDARG` with `throw new ArgumentException()` so execution halts rather than falling through - **`GetPEFileName`** → inner `return HResults.E_NOTIMPL` inside `try` replaced with `throw new NotImplementedException()` to prevent `CopyStringToBuffer` from running on empty paths - **`SOSMethodEnum.GetCount`** → added `try/catch` wrapper; `return HResults.E_POINTER` → `throw new NullReferenceException()` - **`GetThreadFromThinlockID`** → fixed latent bug: null check was setting `hr` but not preventing the `try` block from running, causing `*pThread` dereference on a null pointer **Before / After pattern:** ```csharp // Before — bypasses catch and #if DEBUG block int ISOSDacInterface.GetThreadData(ClrDataAddress thread, DacpThreadData* data) { if (thread == 0 || data == null) return HResults.E_INVALIDARG; // skips try/catch and DEBUG comparison int hr = HResults.S_OK; try { ... } catch (Exception ex) { hr = ex.HResult; } ... } // After — check participates in unified error handling int ISOSDacInterface.GetThreadData(ClrDataAddress thread, DacpThreadData* data) { int hr = HResults.S_OK; try { if (thread == 0 || data == null) throw new ArgumentException(); ... } catch (Exception ex) { hr = ex.HResult; } ... } ``` ## Testing - All 832 existing cDAC unit tests pass.  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot · 2026-02-24T20:18:11Z

Description

Argument and pointer validation checks at the start of SOSDacImpl methods were returning early (before the try/catch), bypassing the catch block's HResult conversion and the #if DEBUG legacy comparison block.

Changes

E_INVALIDARG checks → moved inside try, replaced return HResults.E_INVALIDARG with throw new ArgumentException()
E_POINTER checks → moved inside try, replaced return HResults.E_POINTER with throw new NullReferenceException()
if/else guard patterns (ISOSDacInterface14 methods, GetILForModule, GetMethodDescFromToken, TraverseModuleMap) → flattened into unified try/catch with throws
Switch default: cases (GetMethodDescFromToken, TraverseModuleMap) → replaced hr = HResults.E_INVALIDARG with throw new ArgumentException() so execution halts rather than falling through
GetPEFileName → inner return HResults.E_NOTIMPL inside try replaced with throw new NotImplementedException() to prevent CopyStringToBuffer from running on empty paths
SOSMethodEnum.GetCount → added try/catch wrapper; return HResults.E_POINTER → throw new NullReferenceException()
GetThreadFromThinlockID → fixed latent bug: null check was setting hr but not preventing the try block from running, causing *pThread dereference on a null pointer

Before / After pattern:

// Before — bypasses catch and #if DEBUG blockintISOSDacInterface.GetThreadData(ClrDataAddressthread,DacpThreadData*data){if(thread==0||data==null)returnHResults.E_INVALIDARG;// skips try/catch and DEBUG comparisoninthr=HResults.S_OK;try{ ...}catch(Exceptionex){hr=ex.HResult;}
...}// After — check participates in unified error handlingintISOSDacInterface.GetThreadData(ClrDataAddressthread,DacpThreadData*data){inthr=HResults.S_OK;try{if(thread==0||data==null)thrownewArgumentException();
...}catch(Exceptionex){hr=ex.HResult;}
...}

Testing

All 832 existing cDAC unit tests pass.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

dotnet-policy-service · 2026-02-24T20:21:12Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

…x GetPEFileName E_NOTIMPL Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

max-charlamb

lgtm, nice cleanup.

Especially good find on the bug in GetThreadFromThinlockID

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot

Pull request overview

This pull request refactors error handling in SOSDacImpl.cs by moving argument and pointer validation checks from before try blocks to inside try blocks, converting early returns to thrown exceptions. The goal is to ensure that the catch block can handle HResult conversion and that DEBUG comparison blocks work correctly.

Changes:

Moved null pointer and invalid argument checks from before try blocks to inside try blocks across approximately 30 methods
Changed early return HResults.E_INVALIDARG statements to throw new ArgumentException() inside try blocks
Changed early return HResults.E_POINTER statements to throw new NullReferenceException() inside try blocks
Restructured methods like GetILForModule, GetMethodDescFromToken, and TraverseModuleMap from if/else structures to unified try/catch blocks
Added try/catch wrapper to SOSMethodEnum.GetCount

…atch, use heapData.GenerationTable.Count, and use local buffers for debug cross-validation - Change void* to DacpGenerationData* in ISOSDacInterface8 methods - Move null/validation checks inside try/catch blocks per PR dotnet#124814 pattern - Replace ReadGlobal<uint>(TotalGenerationCount) with heapData.GenerationTable.Count - Use local buffers for legacy DAC cross-validation to avoid overwriting cDAC data - Use 'is null'/'is not null' instead of '== null'/'!= null' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…otnet#124814) ## Description Argument and pointer validation checks at the start of `SOSDacImpl` methods were returning early (before the `try/catch`), bypassing the catch block's HResult conversion and the `#if DEBUG` legacy comparison block. ### Changes - **E_INVALIDARG checks** → moved inside `try`, replaced `return HResults.E_INVALIDARG` with `throw new ArgumentException()` - **E_POINTER checks** → moved inside `try`, replaced `return HResults.E_POINTER` with `throw new NullReferenceException()` - **`if/else` guard patterns** (ISOSDacInterface14 methods, `GetILForModule`, `GetMethodDescFromToken`, `TraverseModuleMap`) → flattened into unified `try/catch` with throws - **Switch `default:` cases** (`GetMethodDescFromToken`, `TraverseModuleMap`) → replaced `hr = HResults.E_INVALIDARG` with `throw new ArgumentException()` so execution halts rather than falling through - **`GetPEFileName`** → inner `return HResults.E_NOTIMPL` inside `try` replaced with `throw new NotImplementedException()` to prevent `CopyStringToBuffer` from running on empty paths - **`SOSMethodEnum.GetCount`** → added `try/catch` wrapper; `return HResults.E_POINTER` → `throw new NullReferenceException()` - **`GetThreadFromThinlockID`** → fixed latent bug: null check was setting `hr` but not preventing the `try` block from running, causing `*pThread` dereference on a null pointer **Before / After pattern:** ```csharp // Before — bypasses catch and #if DEBUG block int ISOSDacInterface.GetThreadData(ClrDataAddress thread, DacpThreadData* data) { if (thread == 0 || data == null) return HResults.E_INVALIDARG; // skips try/catch and DEBUG comparison int hr = HResults.S_OK; try { ... } catch (Exception ex) { hr = ex.HResult; } ... } // After — check participates in unified error handling int ISOSDacInterface.GetThreadData(ClrDataAddress thread, DacpThreadData* data) { int hr = HResults.S_OK; try { if (thread == 0 || data == null) throw new ArgumentException(); ... } catch (Exception ex) { hr = ex.HResult; } ... } ``` ## Testing - All 832 existing cDAC unit tests pass.  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot · 2026-02-24T20:18:11Z

Description

Argument and pointer validation checks at the start of SOSDacImpl methods were returning early (before the try/catch), bypassing the catch block's HResult conversion and the #if DEBUG legacy comparison block.

Changes

E_INVALIDARG checks → moved inside try, replaced return HResults.E_INVALIDARG with throw new ArgumentException()
E_POINTER checks → moved inside try, replaced return HResults.E_POINTER with throw new NullReferenceException()
if/else guard patterns (ISOSDacInterface14 methods, GetILForModule, GetMethodDescFromToken, TraverseModuleMap) → flattened into unified try/catch with throws
Switch default: cases (GetMethodDescFromToken, TraverseModuleMap) → replaced hr = HResults.E_INVALIDARG with throw new ArgumentException() so execution halts rather than falling through
GetPEFileName → inner return HResults.E_NOTIMPL inside try replaced with throw new NotImplementedException() to prevent CopyStringToBuffer from running on empty paths
SOSMethodEnum.GetCount → added try/catch wrapper; return HResults.E_POINTER → throw new NullReferenceException()
GetThreadFromThinlockID → fixed latent bug: null check was setting hr but not preventing the try block from running, causing *pThread dereference on a null pointer

Before / After pattern:

// Before — bypasses catch and #if DEBUG blockintISOSDacInterface.GetThreadData(ClrDataAddressthread,DacpThreadData*data){if(thread==0||data==null)returnHResults.E_INVALIDARG;// skips try/catch and DEBUG comparisoninthr=HResults.S_OK;try{ ...}catch(Exceptionex){hr=ex.HResult;}
...}// After — check participates in unified error handlingintISOSDacInterface.GetThreadData(ClrDataAddressthread,DacpThreadData*data){inthr=HResults.S_OK;try{if(thread==0||data==null)thrownewArgumentException();
...}catch(Exceptionex){hr=ex.HResult;}
...}

Testing

All 832 existing cDAC unit tests pass.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

dotnet-policy-service · 2026-02-24T20:21:12Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

…x GetPEFileName E_NOTIMPL Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

max-charlamb

lgtm, nice cleanup.

Especially good find on the bug in GetThreadFromThinlockID

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot

Pull request overview

This pull request refactors error handling in SOSDacImpl.cs by moving argument and pointer validation checks from before try blocks to inside try blocks, converting early returns to thrown exceptions. The goal is to ensure that the catch block can handle HResult conversion and that DEBUG comparison blocks work correctly.

Changes:

Moved null pointer and invalid argument checks from before try blocks to inside try blocks across approximately 30 methods
Changed early return HResults.E_INVALIDARG statements to throw new ArgumentException() inside try blocks
Changed early return HResults.E_POINTER statements to throw new NullReferenceException() inside try blocks
Restructured methods like GetILForModule, GetMethodDescFromToken, and TraverseModuleMap from if/else structures to unified try/catch blocks
Added try/catch wrapper to SOSMethodEnum.GetCount

…atch, use heapData.GenerationTable.Count, and use local buffers for debug cross-validation - Change void* to DacpGenerationData* in ISOSDacInterface8 methods - Move null/validation checks inside try/catch blocks per PR dotnet#124814 pattern - Replace ReadGlobal<uint>(TotalGenerationCount) with heapData.GenerationTable.Count - Use local buffers for legacy DAC cross-validation to avoid overwriting cDAC data - Use 'is null'/'is not null' instead of '== null'/'!= null' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…otnet#124814) ## Description Argument and pointer validation checks at the start of `SOSDacImpl` methods were returning early (before the `try/catch`), bypassing the catch block's HResult conversion and the `#if DEBUG` legacy comparison block. ### Changes - **E_INVALIDARG checks** → moved inside `try`, replaced `return HResults.E_INVALIDARG` with `throw new ArgumentException()` - **E_POINTER checks** → moved inside `try`, replaced `return HResults.E_POINTER` with `throw new NullReferenceException()` - **`if/else` guard patterns** (ISOSDacInterface14 methods, `GetILForModule`, `GetMethodDescFromToken`, `TraverseModuleMap`) → flattened into unified `try/catch` with throws - **Switch `default:` cases** (`GetMethodDescFromToken`, `TraverseModuleMap`) → replaced `hr = HResults.E_INVALIDARG` with `throw new ArgumentException()` so execution halts rather than falling through - **`GetPEFileName`** → inner `return HResults.E_NOTIMPL` inside `try` replaced with `throw new NotImplementedException()` to prevent `CopyStringToBuffer` from running on empty paths - **`SOSMethodEnum.GetCount`** → added `try/catch` wrapper; `return HResults.E_POINTER` → `throw new NullReferenceException()` - **`GetThreadFromThinlockID`** → fixed latent bug: null check was setting `hr` but not preventing the `try` block from running, causing `*pThread` dereference on a null pointer **Before / After pattern:** ```csharp // Before — bypasses catch and #if DEBUG block int ISOSDacInterface.GetThreadData(ClrDataAddress thread, DacpThreadData* data) { if (thread == 0 || data == null) return HResults.E_INVALIDARG; // skips try/catch and DEBUG comparison int hr = HResults.S_OK; try { ... } catch (Exception ex) { hr = ex.HResult; } ... } // After — check participates in unified error handling int ISOSDacInterface.GetThreadData(ClrDataAddress thread, DacpThreadData* data) { int hr = HResults.S_OK; try { if (thread == 0 || data == null) throw new ArgumentException(); ... } catch (Exception ex) { hr = ex.HResult; } ... } ``` ## Testing - All 832 existing cDAC unit tests pass.  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot · 2026-02-24T20:18:11Z

Description

Argument and pointer validation checks at the start of SOSDacImpl methods were returning early (before the try/catch), bypassing the catch block's HResult conversion and the #if DEBUG legacy comparison block.

Changes

E_INVALIDARG checks → moved inside try, replaced return HResults.E_INVALIDARG with throw new ArgumentException()
E_POINTER checks → moved inside try, replaced return HResults.E_POINTER with throw new NullReferenceException()
if/else guard patterns (ISOSDacInterface14 methods, GetILForModule, GetMethodDescFromToken, TraverseModuleMap) → flattened into unified try/catch with throws
Switch default: cases (GetMethodDescFromToken, TraverseModuleMap) → replaced hr = HResults.E_INVALIDARG with throw new ArgumentException() so execution halts rather than falling through
GetPEFileName → inner return HResults.E_NOTIMPL inside try replaced with throw new NotImplementedException() to prevent CopyStringToBuffer from running on empty paths
SOSMethodEnum.GetCount → added try/catch wrapper; return HResults.E_POINTER → throw new NullReferenceException()
GetThreadFromThinlockID → fixed latent bug: null check was setting hr but not preventing the try block from running, causing *pThread dereference on a null pointer

Before / After pattern:

// Before — bypasses catch and #if DEBUG blockintISOSDacInterface.GetThreadData(ClrDataAddressthread,DacpThreadData*data){if(thread==0||data==null)returnHResults.E_INVALIDARG;// skips try/catch and DEBUG comparisoninthr=HResults.S_OK;try{ ...}catch(Exceptionex){hr=ex.HResult;}
...}// After — check participates in unified error handlingintISOSDacInterface.GetThreadData(ClrDataAddressthread,DacpThreadData*data){inthr=HResults.S_OK;try{if(thread==0||data==null)thrownewArgumentException();
...}catch(Exceptionex){hr=ex.HResult;}
...}

Testing

All 832 existing cDAC unit tests pass.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

dotnet-policy-service · 2026-02-24T20:21:12Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

…x GetPEFileName E_NOTIMPL Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

max-charlamb

lgtm, nice cleanup.

Especially good find on the bug in GetThreadFromThinlockID

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot

Pull request overview

This pull request refactors error handling in SOSDacImpl.cs by moving argument and pointer validation checks from before try blocks to inside try blocks, converting early returns to thrown exceptions. The goal is to ensure that the catch block can handle HResult conversion and that DEBUG comparison blocks work correctly.

Changes:

Moved null pointer and invalid argument checks from before try blocks to inside try blocks across approximately 30 methods
Changed early return HResults.E_INVALIDARG statements to throw new ArgumentException() inside try blocks
Changed early return HResults.E_POINTER statements to throw new NullReferenceException() inside try blocks
Restructured methods like GetILForModule, GetMethodDescFromToken, and TraverseModuleMap from if/else structures to unified try/catch blocks
Added try/catch wrapper to SOSMethodEnum.GetCount

…atch, use heapData.GenerationTable.Count, and use local buffers for debug cross-validation - Change void* to DacpGenerationData* in ISOSDacInterface8 methods - Move null/validation checks inside try/catch blocks per PR dotnet#124814 pattern - Replace ReadGlobal<uint>(TotalGenerationCount) with heapData.GenerationTable.Count - Use local buffers for legacy DAC cross-validation to avoid overwriting cDAC data - Use 'is null'/'is not null' instead of '== null'/'!= null' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…otnet#124814) ## Description Argument and pointer validation checks at the start of `SOSDacImpl` methods were returning early (before the `try/catch`), bypassing the catch block's HResult conversion and the `#if DEBUG` legacy comparison block. ### Changes - **E_INVALIDARG checks** → moved inside `try`, replaced `return HResults.E_INVALIDARG` with `throw new ArgumentException()` - **E_POINTER checks** → moved inside `try`, replaced `return HResults.E_POINTER` with `throw new NullReferenceException()` - **`if/else` guard patterns** (ISOSDacInterface14 methods, `GetILForModule`, `GetMethodDescFromToken`, `TraverseModuleMap`) → flattened into unified `try/catch` with throws - **Switch `default:` cases** (`GetMethodDescFromToken`, `TraverseModuleMap`) → replaced `hr = HResults.E_INVALIDARG` with `throw new ArgumentException()` so execution halts rather than falling through - **`GetPEFileName`** → inner `return HResults.E_NOTIMPL` inside `try` replaced with `throw new NotImplementedException()` to prevent `CopyStringToBuffer` from running on empty paths - **`SOSMethodEnum.GetCount`** → added `try/catch` wrapper; `return HResults.E_POINTER` → `throw new NullReferenceException()` - **`GetThreadFromThinlockID`** → fixed latent bug: null check was setting `hr` but not preventing the `try` block from running, causing `*pThread` dereference on a null pointer **Before / After pattern:** ```csharp // Before — bypasses catch and #if DEBUG block int ISOSDacInterface.GetThreadData(ClrDataAddress thread, DacpThreadData* data) { if (thread == 0 || data == null) return HResults.E_INVALIDARG; // skips try/catch and DEBUG comparison int hr = HResults.S_OK; try { ... } catch (Exception ex) { hr = ex.HResult; } ... } // After — check participates in unified error handling int ISOSDacInterface.GetThreadData(ClrDataAddress thread, DacpThreadData* data) { int hr = HResults.S_OK; try { if (thread == 0 || data == null) throw new ArgumentException(); ... } catch (Exception ex) { hr = ex.HResult; } ... } ``` ## Testing - All 832 existing cDAC unit tests pass.  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot · 2026-02-24T20:18:11Z

Description

Argument and pointer validation checks at the start of SOSDacImpl methods were returning early (before the try/catch), bypassing the catch block's HResult conversion and the #if DEBUG legacy comparison block.

Changes

E_INVALIDARG checks → moved inside try, replaced return HResults.E_INVALIDARG with throw new ArgumentException()
E_POINTER checks → moved inside try, replaced return HResults.E_POINTER with throw new NullReferenceException()
if/else guard patterns (ISOSDacInterface14 methods, GetILForModule, GetMethodDescFromToken, TraverseModuleMap) → flattened into unified try/catch with throws
Switch default: cases (GetMethodDescFromToken, TraverseModuleMap) → replaced hr = HResults.E_INVALIDARG with throw new ArgumentException() so execution halts rather than falling through
GetPEFileName → inner return HResults.E_NOTIMPL inside try replaced with throw new NotImplementedException() to prevent CopyStringToBuffer from running on empty paths
SOSMethodEnum.GetCount → added try/catch wrapper; return HResults.E_POINTER → throw new NullReferenceException()
GetThreadFromThinlockID → fixed latent bug: null check was setting hr but not preventing the try block from running, causing *pThread dereference on a null pointer

Before / After pattern:

// Before — bypasses catch and #if DEBUG blockintISOSDacInterface.GetThreadData(ClrDataAddressthread,DacpThreadData*data){if(thread==0||data==null)returnHResults.E_INVALIDARG;// skips try/catch and DEBUG comparisoninthr=HResults.S_OK;try{ ...}catch(Exceptionex){hr=ex.HResult;}
...}// After — check participates in unified error handlingintISOSDacInterface.GetThreadData(ClrDataAddressthread,DacpThreadData*data){inthr=HResults.S_OK;try{if(thread==0||data==null)thrownewArgumentException();
...}catch(Exceptionex){hr=ex.HResult;}
...}

Testing

All 832 existing cDAC unit tests pass.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

dotnet-policy-service · 2026-02-24T20:21:12Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

…x GetPEFileName E_NOTIMPL Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

max-charlamb

lgtm, nice cleanup.

Especially good find on the bug in GetThreadFromThinlockID

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot

Pull request overview

This pull request refactors error handling in SOSDacImpl.cs by moving argument and pointer validation checks from before try blocks to inside try blocks, converting early returns to thrown exceptions. The goal is to ensure that the catch block can handle HResult conversion and that DEBUG comparison blocks work correctly.

Changes:

Moved null pointer and invalid argument checks from before try blocks to inside try blocks across approximately 30 methods
Changed early return HResults.E_INVALIDARG statements to throw new ArgumentException() inside try blocks
Changed early return HResults.E_POINTER statements to throw new NullReferenceException() inside try blocks
Restructured methods like GetILForModule, GetMethodDescFromToken, and TraverseModuleMap from if/else structures to unified try/catch blocks
Added try/catch wrapper to SOSMethodEnum.GetCount

…atch, use heapData.GenerationTable.Count, and use local buffers for debug cross-validation - Change void* to DacpGenerationData* in ISOSDacInterface8 methods - Move null/validation checks inside try/catch blocks per PR dotnet#124814 pattern - Replace ReadGlobal<uint>(TotalGenerationCount) with heapData.GenerationTable.Count - Use local buffers for legacy DAC cross-validation to avoid overwriting cDAC data - Use 'is null'/'is not null' instead of '== null'/'!= null' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…otnet#124814) ## Description Argument and pointer validation checks at the start of `SOSDacImpl` methods were returning early (before the `try/catch`), bypassing the catch block's HResult conversion and the `#if DEBUG` legacy comparison block. ### Changes - **E_INVALIDARG checks** → moved inside `try`, replaced `return HResults.E_INVALIDARG` with `throw new ArgumentException()` - **E_POINTER checks** → moved inside `try`, replaced `return HResults.E_POINTER` with `throw new NullReferenceException()` - **`if/else` guard patterns** (ISOSDacInterface14 methods, `GetILForModule`, `GetMethodDescFromToken`, `TraverseModuleMap`) → flattened into unified `try/catch` with throws - **Switch `default:` cases** (`GetMethodDescFromToken`, `TraverseModuleMap`) → replaced `hr = HResults.E_INVALIDARG` with `throw new ArgumentException()` so execution halts rather than falling through - **`GetPEFileName`** → inner `return HResults.E_NOTIMPL` inside `try` replaced with `throw new NotImplementedException()` to prevent `CopyStringToBuffer` from running on empty paths - **`SOSMethodEnum.GetCount`** → added `try/catch` wrapper; `return HResults.E_POINTER` → `throw new NullReferenceException()` - **`GetThreadFromThinlockID`** → fixed latent bug: null check was setting `hr` but not preventing the `try` block from running, causing `*pThread` dereference on a null pointer **Before / After pattern:** ```csharp // Before — bypasses catch and #if DEBUG block int ISOSDacInterface.GetThreadData(ClrDataAddress thread, DacpThreadData* data) { if (thread == 0 || data == null) return HResults.E_INVALIDARG; // skips try/catch and DEBUG comparison int hr = HResults.S_OK; try { ... } catch (Exception ex) { hr = ex.HResult; } ... } // After — check participates in unified error handling int ISOSDacInterface.GetThreadData(ClrDataAddress thread, DacpThreadData* data) { int hr = HResults.S_OK; try { if (thread == 0 || data == null) throw new ArgumentException(); ... } catch (Exception ex) { hr = ex.HResult; } ... } ``` ## Testing - All 832 existing cDAC unit tests pass.  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot · 2026-02-24T20:18:11Z

Description

Argument and pointer validation checks at the start of SOSDacImpl methods were returning early (before the try/catch), bypassing the catch block's HResult conversion and the #if DEBUG legacy comparison block.

Changes

E_INVALIDARG checks → moved inside try, replaced return HResults.E_INVALIDARG with throw new ArgumentException()
E_POINTER checks → moved inside try, replaced return HResults.E_POINTER with throw new NullReferenceException()
if/else guard patterns (ISOSDacInterface14 methods, GetILForModule, GetMethodDescFromToken, TraverseModuleMap) → flattened into unified try/catch with throws
Switch default: cases (GetMethodDescFromToken, TraverseModuleMap) → replaced hr = HResults.E_INVALIDARG with throw new ArgumentException() so execution halts rather than falling through
GetPEFileName → inner return HResults.E_NOTIMPL inside try replaced with throw new NotImplementedException() to prevent CopyStringToBuffer from running on empty paths
SOSMethodEnum.GetCount → added try/catch wrapper; return HResults.E_POINTER → throw new NullReferenceException()
GetThreadFromThinlockID → fixed latent bug: null check was setting hr but not preventing the try block from running, causing *pThread dereference on a null pointer

Before / After pattern:

// Before — bypasses catch and #if DEBUG blockintISOSDacInterface.GetThreadData(ClrDataAddressthread,DacpThreadData*data){if(thread==0||data==null)returnHResults.E_INVALIDARG;// skips try/catch and DEBUG comparisoninthr=HResults.S_OK;try{ ...}catch(Exceptionex){hr=ex.HResult;}
...}// After — check participates in unified error handlingintISOSDacInterface.GetThreadData(ClrDataAddressthread,DacpThreadData*data){inthr=HResults.S_OK;try{if(thread==0||data==null)thrownewArgumentException();
...}catch(Exceptionex){hr=ex.HResult;}
...}

Testing

All 832 existing cDAC unit tests pass.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

dotnet-policy-service · 2026-02-24T20:21:12Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

…x GetPEFileName E_NOTIMPL Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

max-charlamb

lgtm, nice cleanup.

Especially good find on the bug in GetThreadFromThinlockID

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot

Pull request overview

This pull request refactors error handling in SOSDacImpl.cs by moving argument and pointer validation checks from before try blocks to inside try blocks, converting early returns to thrown exceptions. The goal is to ensure that the catch block can handle HResult conversion and that DEBUG comparison blocks work correctly.

Changes:

Moved null pointer and invalid argument checks from before try blocks to inside try blocks across approximately 30 methods
Changed early return HResults.E_INVALIDARG statements to throw new ArgumentException() inside try blocks
Changed early return HResults.E_POINTER statements to throw new NullReferenceException() inside try blocks
Restructured methods like GetILForModule, GetMethodDescFromToken, and TraverseModuleMap from if/else structures to unified try/catch blocks
Added try/catch wrapper to SOSMethodEnum.GetCount

…atch, use heapData.GenerationTable.Count, and use local buffers for debug cross-validation - Change void* to DacpGenerationData* in ISOSDacInterface8 methods - Move null/validation checks inside try/catch blocks per PR dotnet#124814 pattern - Replace ReadGlobal<uint>(TotalGenerationCount) with heapData.GenerationTable.Count - Use local buffers for legacy DAC cross-validation to avoid overwriting cDAC data - Use 'is null'/'is not null' instead of '== null'/'!= null' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…otnet#124814) ## Description Argument and pointer validation checks at the start of `SOSDacImpl` methods were returning early (before the `try/catch`), bypassing the catch block's HResult conversion and the `#if DEBUG` legacy comparison block. ### Changes - **E_INVALIDARG checks** → moved inside `try`, replaced `return HResults.E_INVALIDARG` with `throw new ArgumentException()` - **E_POINTER checks** → moved inside `try`, replaced `return HResults.E_POINTER` with `throw new NullReferenceException()` - **`if/else` guard patterns** (ISOSDacInterface14 methods, `GetILForModule`, `GetMethodDescFromToken`, `TraverseModuleMap`) → flattened into unified `try/catch` with throws - **Switch `default:` cases** (`GetMethodDescFromToken`, `TraverseModuleMap`) → replaced `hr = HResults.E_INVALIDARG` with `throw new ArgumentException()` so execution halts rather than falling through - **`GetPEFileName`** → inner `return HResults.E_NOTIMPL` inside `try` replaced with `throw new NotImplementedException()` to prevent `CopyStringToBuffer` from running on empty paths - **`SOSMethodEnum.GetCount`** → added `try/catch` wrapper; `return HResults.E_POINTER` → `throw new NullReferenceException()` - **`GetThreadFromThinlockID`** → fixed latent bug: null check was setting `hr` but not preventing the `try` block from running, causing `*pThread` dereference on a null pointer **Before / After pattern:** ```csharp // Before — bypasses catch and #if DEBUG block int ISOSDacInterface.GetThreadData(ClrDataAddress thread, DacpThreadData* data) { if (thread == 0 || data == null) return HResults.E_INVALIDARG; // skips try/catch and DEBUG comparison int hr = HResults.S_OK; try { ... } catch (Exception ex) { hr = ex.HResult; } ... } // After — check participates in unified error handling int ISOSDacInterface.GetThreadData(ClrDataAddress thread, DacpThreadData* data) { int hr = HResults.S_OK; try { if (thread == 0 || data == null) throw new ArgumentException(); ... } catch (Exception ex) { hr = ex.HResult; } ... } ``` ## Testing - All 832 existing cDAC unit tests pass.  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Initial plan
70d0dcd

CopilotAI assigned Copilot and rcj1 Feb 24, 2026

Copilotstarted work on behalf of rcj1 February 24, 2026 20:18 View session

github-actionsBot added the area-VM-coreclr label Feb 24, 2026

CopilotAIand others added 2 commits February 24, 2026 20:31

Fix premature returns for argument/pointer checks in SOSDacImpl.cs
be5e1a3
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Address code review feedback: throw exceptions in switch defaults, fi…
acee219
…x GetPEFileName E_NOTIMPL Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

CopilotAI changed the title ~~[WIP] Fix argument and pointer checks in SOSDacImpl.cs~~Fix premature returns for argument/pointer checks in SOSDacImpl.csFeb 24, 2026

Copilotfinished work on behalf of rcj1 February 24, 2026 20:37

max-charlamb approved these changes Feb 24, 2026
View reviewed changes

rcj1 reviewed Feb 24, 2026
View reviewed changes

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs Outdated

Copilotstarted work on behalf of rcj1 February 24, 2026 20:58 View session

Use throw new NotImplementedException() in GetPEFileName
e5c2fa2
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

rcj1 marked this pull request as ready for review February 24, 2026 21:03

CopilotAI review requested due to automatic review settings February 24, 2026 21:03

Copilotfinished work on behalf of rcj1 February 24, 2026 21:04

Copilotstarted reviewing on behalf of rcj1 February 24, 2026 21:04 View session

CopilotAI reviewed Feb 24, 2026
View reviewed changes

rcj1 merged commit 9511672 into mainFeb 25, 2026
56 of 58 checks passed

rcj1 deleted the copilot/fix-argument-pointer-checks branch February 25, 2026 03:51

dotnet-maestroBot mentioned this pull request Feb 25, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5088
Merged

max-charlamb mentioned this pull request Feb 25, 2026
Add cDAC tests and implementation for GetGenerationTable and GetFinalizationFillPointers #124674
Merged

github-actionsBot locked and limited conversation to collaborators Mar 27, 2026

Initial plan
70d0dcd

CopilotAI assigned Copilot and rcj1 Feb 24, 2026

Copilotstarted work on behalf of rcj1 February 24, 2026 20:18 View session

github-actionsBot added the area-VM-coreclr label Feb 24, 2026

CopilotAIand others added 2 commits February 24, 2026 20:31

Fix premature returns for argument/pointer checks in SOSDacImpl.cs
be5e1a3
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Address code review feedback: throw exceptions in switch defaults, fi…
acee219
…x GetPEFileName E_NOTIMPL Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

CopilotAI changed the title ~~[WIP] Fix argument and pointer checks in SOSDacImpl.cs~~Fix premature returns for argument/pointer checks in SOSDacImpl.csFeb 24, 2026

Copilotfinished work on behalf of rcj1 February 24, 2026 20:37

max-charlamb approved these changes Feb 24, 2026
View reviewed changes

rcj1 reviewed Feb 24, 2026
View reviewed changes

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs Outdated

Copilotstarted work on behalf of rcj1 February 24, 2026 20:58 View session

Use throw new NotImplementedException() in GetPEFileName
e5c2fa2
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

rcj1 marked this pull request as ready for review February 24, 2026 21:03

CopilotAI review requested due to automatic review settings February 24, 2026 21:03

Copilotfinished work on behalf of rcj1 February 24, 2026 21:04

Copilotstarted reviewing on behalf of rcj1 February 24, 2026 21:04 View session

CopilotAI reviewed Feb 24, 2026
View reviewed changes

rcj1 merged commit 9511672 into mainFeb 25, 2026
56 of 58 checks passed

rcj1 deleted the copilot/fix-argument-pointer-checks branch February 25, 2026 03:51

dotnet-maestroBot mentioned this pull request Feb 25, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5088
Merged

max-charlamb mentioned this pull request Feb 25, 2026
Add cDAC tests and implementation for GetGenerationTable and GetFinalizationFillPointers #124674
Merged

github-actionsBot locked and limited conversation to collaborators Mar 27, 2026

Initial plan
70d0dcd

CopilotAI assigned Copilot and rcj1 Feb 24, 2026

Copilotstarted work on behalf of rcj1 February 24, 2026 20:18 View session

github-actionsBot added the area-VM-coreclr label Feb 24, 2026

CopilotAIand others added 2 commits February 24, 2026 20:31

Fix premature returns for argument/pointer checks in SOSDacImpl.cs
be5e1a3
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Address code review feedback: throw exceptions in switch defaults, fi…
acee219
…x GetPEFileName E_NOTIMPL Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

CopilotAI changed the title ~~[WIP] Fix argument and pointer checks in SOSDacImpl.cs~~Fix premature returns for argument/pointer checks in SOSDacImpl.csFeb 24, 2026

Copilotfinished work on behalf of rcj1 February 24, 2026 20:37

max-charlamb approved these changes Feb 24, 2026
View reviewed changes

rcj1 reviewed Feb 24, 2026
View reviewed changes

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs Outdated

Copilotstarted work on behalf of rcj1 February 24, 2026 20:58 View session

Use throw new NotImplementedException() in GetPEFileName
e5c2fa2
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

rcj1 marked this pull request as ready for review February 24, 2026 21:03

CopilotAI review requested due to automatic review settings February 24, 2026 21:03

Copilotfinished work on behalf of rcj1 February 24, 2026 21:04

Copilotstarted reviewing on behalf of rcj1 February 24, 2026 21:04 View session

CopilotAI reviewed Feb 24, 2026
View reviewed changes

rcj1 merged commit 9511672 into mainFeb 25, 2026
56 of 58 checks passed

rcj1 deleted the copilot/fix-argument-pointer-checks branch February 25, 2026 03:51

dotnet-maestroBot mentioned this pull request Feb 25, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5088
Merged

max-charlamb mentioned this pull request Feb 25, 2026
Add cDAC tests and implementation for GetGenerationTable and GetFinalizationFillPointers #124674
Merged

github-actionsBot locked and limited conversation to collaborators Mar 27, 2026

Initial plan
70d0dcd

CopilotAI assigned Copilot and rcj1 Feb 24, 2026

Copilotstarted work on behalf of rcj1 February 24, 2026 20:18 View session

github-actionsBot added the area-VM-coreclr label Feb 24, 2026

CopilotAIand others added 2 commits February 24, 2026 20:31

Fix premature returns for argument/pointer checks in SOSDacImpl.cs
be5e1a3
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Address code review feedback: throw exceptions in switch defaults, fi…
acee219
…x GetPEFileName E_NOTIMPL Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

CopilotAI changed the title ~~[WIP] Fix argument and pointer checks in SOSDacImpl.cs~~Fix premature returns for argument/pointer checks in SOSDacImpl.csFeb 24, 2026

Copilotfinished work on behalf of rcj1 February 24, 2026 20:37

max-charlamb approved these changes Feb 24, 2026
View reviewed changes

rcj1 reviewed Feb 24, 2026
View reviewed changes

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs Outdated

Copilotstarted work on behalf of rcj1 February 24, 2026 20:58 View session

Use throw new NotImplementedException() in GetPEFileName
e5c2fa2
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

rcj1 marked this pull request as ready for review February 24, 2026 21:03

CopilotAI review requested due to automatic review settings February 24, 2026 21:03

Copilotfinished work on behalf of rcj1 February 24, 2026 21:04

Copilotstarted reviewing on behalf of rcj1 February 24, 2026 21:04 View session

CopilotAI reviewed Feb 24, 2026
View reviewed changes

rcj1 merged commit 9511672 into mainFeb 25, 2026
56 of 58 checks passed

rcj1 deleted the copilot/fix-argument-pointer-checks branch February 25, 2026 03:51

dotnet-maestroBot mentioned this pull request Feb 25, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5088
Merged

max-charlamb mentioned this pull request Feb 25, 2026
Add cDAC tests and implementation for GetGenerationTable and GetFinalizationFillPointers #124674
Merged

github-actionsBot locked and limited conversation to collaborators Mar 27, 2026

Initial plan
70d0dcd

CopilotAI assigned Copilot and rcj1 Feb 24, 2026

Copilotstarted work on behalf of rcj1 February 24, 2026 20:18 View session

github-actionsBot added the area-VM-coreclr label Feb 24, 2026

CopilotAIand others added 2 commits February 24, 2026 20:31

Fix premature returns for argument/pointer checks in SOSDacImpl.cs
be5e1a3
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Address code review feedback: throw exceptions in switch defaults, fi…
acee219
…x GetPEFileName E_NOTIMPL Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

CopilotAI changed the title ~~[WIP] Fix argument and pointer checks in SOSDacImpl.cs~~Fix premature returns for argument/pointer checks in SOSDacImpl.csFeb 24, 2026

Copilotfinished work on behalf of rcj1 February 24, 2026 20:37

max-charlamb approved these changes Feb 24, 2026
View reviewed changes

rcj1 reviewed Feb 24, 2026
View reviewed changes

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs Outdated

Copilotstarted work on behalf of rcj1 February 24, 2026 20:58 View session

Use throw new NotImplementedException() in GetPEFileName
e5c2fa2
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

rcj1 marked this pull request as ready for review February 24, 2026 21:03

CopilotAI review requested due to automatic review settings February 24, 2026 21:03

Copilotfinished work on behalf of rcj1 February 24, 2026 21:04

Copilotstarted reviewing on behalf of rcj1 February 24, 2026 21:04 View session

CopilotAI reviewed Feb 24, 2026
View reviewed changes

rcj1 merged commit 9511672 into mainFeb 25, 2026
56 of 58 checks passed

rcj1 deleted the copilot/fix-argument-pointer-checks branch February 25, 2026 03:51

dotnet-maestroBot mentioned this pull request Feb 25, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5088
Merged

max-charlamb mentioned this pull request Feb 25, 2026
Add cDAC tests and implementation for GetGenerationTable and GetFinalizationFillPointers #124674
Merged

github-actionsBot locked and limited conversation to collaborators Mar 27, 2026

Initial plan
70d0dcd

CopilotAI assigned Copilot and rcj1 Feb 24, 2026

Copilotstarted work on behalf of rcj1 February 24, 2026 20:18 View session

github-actionsBot added the area-VM-coreclr label Feb 24, 2026

CopilotAIand others added 2 commits February 24, 2026 20:31

Fix premature returns for argument/pointer checks in SOSDacImpl.cs
be5e1a3
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Address code review feedback: throw exceptions in switch defaults, fi…
acee219
…x GetPEFileName E_NOTIMPL Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

CopilotAI changed the title ~~[WIP] Fix argument and pointer checks in SOSDacImpl.cs~~Fix premature returns for argument/pointer checks in SOSDacImpl.csFeb 24, 2026

Copilotfinished work on behalf of rcj1 February 24, 2026 20:37

max-charlamb approved these changes Feb 24, 2026
View reviewed changes

rcj1 reviewed Feb 24, 2026
View reviewed changes

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs Outdated

Copilotstarted work on behalf of rcj1 February 24, 2026 20:58 View session

Use throw new NotImplementedException() in GetPEFileName
e5c2fa2
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

rcj1 marked this pull request as ready for review February 24, 2026 21:03

CopilotAI review requested due to automatic review settings February 24, 2026 21:03

Copilotfinished work on behalf of rcj1 February 24, 2026 21:04

Copilotstarted reviewing on behalf of rcj1 February 24, 2026 21:04 View session

CopilotAI reviewed Feb 24, 2026
View reviewed changes

rcj1 merged commit 9511672 into mainFeb 25, 2026
56 of 58 checks passed

rcj1 deleted the copilot/fix-argument-pointer-checks branch February 25, 2026 03:51

dotnet-maestroBot mentioned this pull request Feb 25, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5088
Merged

max-charlamb mentioned this pull request Feb 25, 2026
Add cDAC tests and implementation for GetGenerationTable and GetFinalizationFillPointers #124674
Merged

github-actionsBot locked and limited conversation to collaborators Mar 27, 2026

Initial plan
70d0dcd

CopilotAI assigned Copilot and rcj1 Feb 24, 2026

Copilotstarted work on behalf of rcj1 February 24, 2026 20:18 View session

github-actionsBot added the area-VM-coreclr label Feb 24, 2026

CopilotAIand others added 2 commits February 24, 2026 20:31

Fix premature returns for argument/pointer checks in SOSDacImpl.cs
be5e1a3
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Address code review feedback: throw exceptions in switch defaults, fi…
acee219
…x GetPEFileName E_NOTIMPL Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

CopilotAI changed the title ~~[WIP] Fix argument and pointer checks in SOSDacImpl.cs~~Fix premature returns for argument/pointer checks in SOSDacImpl.csFeb 24, 2026

Copilotfinished work on behalf of rcj1 February 24, 2026 20:37

max-charlamb approved these changes Feb 24, 2026
View reviewed changes

rcj1 reviewed Feb 24, 2026
View reviewed changes

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs Outdated

Copilotstarted work on behalf of rcj1 February 24, 2026 20:58 View session

Use throw new NotImplementedException() in GetPEFileName
e5c2fa2
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

rcj1 marked this pull request as ready for review February 24, 2026 21:03

CopilotAI review requested due to automatic review settings February 24, 2026 21:03

Copilotfinished work on behalf of rcj1 February 24, 2026 21:04

Copilotstarted reviewing on behalf of rcj1 February 24, 2026 21:04 View session

CopilotAI reviewed Feb 24, 2026
View reviewed changes

rcj1 merged commit 9511672 into mainFeb 25, 2026
56 of 58 checks passed

rcj1 deleted the copilot/fix-argument-pointer-checks branch February 25, 2026 03:51

dotnet-maestroBot mentioned this pull request Feb 25, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5088
Merged

max-charlamb mentioned this pull request Feb 25, 2026
Add cDAC tests and implementation for GetGenerationTable and GetFinalizationFillPointers #124674
Merged

github-actionsBot locked and limited conversation to collaborators Mar 27, 2026

Initial plan
70d0dcd

CopilotAI assigned Copilot and rcj1 Feb 24, 2026

Copilotstarted work on behalf of rcj1 February 24, 2026 20:18 View session

github-actionsBot added the area-VM-coreclr label Feb 24, 2026

CopilotAIand others added 2 commits February 24, 2026 20:31

Fix premature returns for argument/pointer checks in SOSDacImpl.cs
be5e1a3
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Address code review feedback: throw exceptions in switch defaults, fi…
acee219
…x GetPEFileName E_NOTIMPL Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

CopilotAI changed the title ~~[WIP] Fix argument and pointer checks in SOSDacImpl.cs~~Fix premature returns for argument/pointer checks in SOSDacImpl.csFeb 24, 2026

Copilotfinished work on behalf of rcj1 February 24, 2026 20:37

max-charlamb approved these changes Feb 24, 2026
View reviewed changes

rcj1 reviewed Feb 24, 2026
View reviewed changes

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs Outdated

Copilotstarted work on behalf of rcj1 February 24, 2026 20:58 View session

Use throw new NotImplementedException() in GetPEFileName
e5c2fa2
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

rcj1 marked this pull request as ready for review February 24, 2026 21:03

CopilotAI review requested due to automatic review settings February 24, 2026 21:03

Copilotfinished work on behalf of rcj1 February 24, 2026 21:04

Copilotstarted reviewing on behalf of rcj1 February 24, 2026 21:04 View session

CopilotAI reviewed Feb 24, 2026
View reviewed changes

rcj1 merged commit 9511672 into mainFeb 25, 2026
56 of 58 checks passed

rcj1 deleted the copilot/fix-argument-pointer-checks branch February 25, 2026 03:51

dotnet-maestroBot mentioned this pull request Feb 25, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5088
Merged

max-charlamb mentioned this pull request Feb 25, 2026
Add cDAC tests and implementation for GetGenerationTable and GetFinalizationFillPointers #124674
Merged

github-actionsBot locked and limited conversation to collaborators Mar 27, 2026

Uh oh!

Conversation

CopilotAI commented Feb 24, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Testing

Uh oh!

dotnet-policy-serviceBot commented Feb 24, 2026

Uh oh!

max-charlamb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

CopilotAI commented Feb 24, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Testing

Uh oh!

dotnet-policy-serviceBot commented Feb 24, 2026

Uh oh!

max-charlamb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

CopilotAI commented Feb 24, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

CopilotAI commented Feb 24, 2026•
edited
Loading

CopilotAI commented Feb 24, 2026•
edited
Loading

CopilotAI commented Feb 24, 2026•
edited
Loading

CopilotAI commented Feb 24, 2026•
edited
Loading