Convert exception-related MethodDescCallSite calls to UnmanagedCallersOnly by AaronRobinsonMSFT · Pull Request #124834 · dotnet/runtime

AaronRobinsonMSFT · 2026-02-24T23:49:47Z

Summary

Replace MethodDescCallSite/CallDescrWorker calls with more efficient UnmanagedCallersOnly reverse P/Invoke calls in exception handling code paths (priority 2 from #123864).

Changes

Convert the following call sites in excep.cpp to use UnmanagedCallersOnlyCaller:

GetExceptionMessage: Object.ToString via UCO (METHOD__RUNTIMEHELPERS__CALL_TO_STRING)
ExceptionPreserveStackTrace: InternalPreserveStackTrace via UCO
WrapNonCompliantException: RuntimeWrappedException construction via UCO
CreateTypeInitializationExceptionObject: TypeInitializationException construction via UCO
GetResourceStringFromManaged: Environment.GetResourceStringLocal via UCO
GetEventArgsForNotification: FirstChanceExceptionEventArgs construction via UCO

Pattern

Each conversion follows the established pattern:

Add [UnmanagedCallersOnly] static wrapper in managed code with Exception* out-parameter
Add corresponding metasig in metasig.h and DEFINE_METHOD in corelib.h
Replace MethodDescCallSite + ARG_SLOT with UnmanagedCallersOnlyCaller::InvokeThrowing
Remove now-unused DEFINE_METHOD entries for old constructors

All GC references passed to InvokeThrowing are in GCPROTECT'd locations.

…sOnly Replace MethodDescCallSite/CallDescrWorker calls with more efficient UnmanagedCallersOnly reverse P/Invoke calls in exception handling code paths (priority 2 from dotnet#123864): - GetExceptionMessage: Object.ToString via UCO - ExceptionPreserveStackTrace: InternalPreserveStackTrace via UCO - WrapNonCompliantException: RuntimeWrappedException ctor via UCO - CreateTypeInitializationExceptionObject: TypeInitializationException via UCO - GetResourceStringFromManaged: Environment.GetResourceStringLocal via UCO - GetEventArgsForNotification: FirstChanceExceptionEventArgs ctor via UCO Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This pull request converts six exception-related MethodDescCallSite call sites in excep.cpp to use the more efficient UnmanagedCallersOnly reverse P/Invoke pattern, following the established approach from priority 1 and 2 tasks in issue #123864.

Changes:

Replaces MethodDescCallSite/CallDescrWorker with UnmanagedCallersOnlyCaller::InvokeThrowing for six exception-handling methods
Adds six new UnmanagedCallersOnly wrapper methods in managed code (Object.CoreCLR.cs, Exception.CoreCLR.cs, Environment.CoreCLR.cs)
Updates metasig.h with six new method signatures and corelib.h with updated DEFINE_METHOD entries, removing obsolete constructor definitions

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/metasig.h	Adds 6 new metasig definitions for UnmanagedCallersOnly wrappers (PtrObj_PtrStr, PtrObj_PtrObj, PtrStr_PtrStr, PtrException_PtrException, PtrChar_PtrException_PtrObj, PtrException_PtrObj, all with PtrException_RetVoid suffix)
src/coreclr/vm/corelib.h	Updates DEFINE_METHOD entries for the 6 converted methods and removes 3 obsolete constructor entries (TYPE_INIT_EXCEPTION.STR_EX_CTOR, RUNTIME_WRAPPED_EXCEPTION.OBJ_CTOR, FIRSTCHANCE_EVENTARGS.CTOR)
src/coreclr/vm/excep.cpp	Converts 6 call sites to use UnmanagedCallersOnlyCaller: GetExceptionMessage, ExceptionPreserveStackTrace, WrapNonCompliantException, CreateTypeInitializationExceptionObject, GetResourceStringFromManaged, GetEventArgsForNotification
src/coreclr/System.Private.CoreLib/src/System/Object.CoreCLR.cs	Adds GetToString UnmanagedCallersOnly wrapper with Exception* out-parameter
src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs	Adds 4 UnmanagedCallersOnly wrappers: InternalPreserveStackTrace, CreateRuntimeWrappedException, CreateTypeInitializationException, CreateFirstChanceExceptionEventArgs
src/coreclr/System.Private.CoreLib/src/System/Environment.CoreCLR.cs	Converts GetResourceStringLocal to UnmanagedCallersOnly pattern with string* in/out parameters

- Move GetToString from System.Object to System.Exception to avoid breaking reflection in user code - Clean up stale comment about SystemException fallback in CreateTypeInitializationExceptionObject - Rename GetResourceStringLocal to GetResourceString, drop Local suffix - Delete unused DEFINE_CLASS(FIRSTCHANCE_EVENTARGS) from corelib.h - Fold GetResourceStringFromManaged into its single caller ResMgrGetString, pass key as char* and move string creation to managed side - Add GCPROTECT around ResMgrGetString caller in clrex.cpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…o single UCO call Combine event args construction and delegate invocation into a single managed DeliverFirstChanceNotification UCO method. Multicast delegate iteration is now handled by managed Delegate.Invoke. Remove the native DeliverExceptionNotification and GetEventArgsForNotification methods. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

AaronRobinsonMSFT · 2026-02-25T23:34:52Z

@EgorBot -linux_amd -osx_arm64

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;usingSystem;BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);publicclassBench{privateException_cachedException=newInvalidOperationException("test");[Benchmark]publicvoidThrowCatch_NoHandler(){try{throw_cachedException;}catch{}}[Benchmark]publicvoidThrowCatch_WithHandler(){AppDomain.CurrentDomain.FirstChanceException+=Handler;try{throw_cachedException;}catch{}finally{AppDomain.CurrentDomain.FirstChanceException-=Handler;}}privatestaticvoidHandler(object?sender,System.Runtime.ExceptionServices.FirstChanceExceptionEventArgse){}}

…dd OnFirstChanceException method

Replace the CanDeliverNotificationToCurrentAppDomain check, which read the managed FirstChanceException delegate field via CoreLibBinder in cooperative GC mode, with a native Volatile<BOOL> flag set via a SuppressGCTransition QCall when a handler is first registered. This avoids the GCX_COOP transition in DeliverFirstChanceNotification on every exception throw when no handler is registered. The flag is sticky: once set to TRUE it is never cleared, avoiding race conditions between concurrent add/remove operations. - Remove CanDeliverNotificationToCurrentAppDomain and FIELD__APPCONTEXT__FIRST_CHANCE_EXCEPTION - Add AppDomain_SetFirstChanceExceptionHandler QCall (SuppressGCTransition) - Move GCX_COOP inside the handler check in DeliverFirstChanceNotification Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

jkotas

Thanks!

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

…124854) First set of priority 3 conversions from #123864 — replace `MethodDescCallSite`/`CallDescrWorker` calls with `UnmanagedCallersOnly` reverse P/Invoke calls. ## Converted call sites | File | Call site | Method | |------|-----------|--------| | `appdomain.cpp` | `AppDomain::RaiseExitProcessEvent` | `ON_PROCESS_EXIT` | | `appdomain.cpp` | `AppDomain::OnUnhandledException` | `ON_UNHANDLED_EXCEPTION` | | `assembly.cpp` | `RunManagedStartup` | `MANAGED_STARTUP` | | `assembly.cpp` | `RunMainInternal` (TARGET_BROWSER) | `HANDLE_ASYNC_ENTRYPOINT` | | `invokeutil.cpp` | `InvokeUtil::CreateClassLoadExcept` | `ReflectionTypeLoadException` ctor | | `invokeutil.cpp` | `InvokeUtil::CreateTargetExcept` | `TargetInvocationException` ctor | ## Remaining priority 3 items (follow ups) - Main entry point in `RunMainInternal` (dynamic MethodDesc) - `CustomAttribute_CreateCustomAttributeInstance` (dynamic ctor, already a QCall) - `CorHost2::ExecuteAssembly` (dynamic method lookup) - `FuncEvalWrapper`/`DoNormalFuncEval` (debugger func-eval) ## Pattern Follows the same conversion pattern as #124834 (priority 2). Each conversion adds an `[UnmanagedCallersOnly]` managed wrapper with an `Exception*` out-parameter and replaces the native `MethodDescCallSite` + `ARG_SLOT` with `UnmanagedCallersOnlyCaller::InvokeThrowing`. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

AaronRobinsonMSFT · 2026-02-24T23:49:47Z

Summary

Replace MethodDescCallSite/CallDescrWorker calls with more efficient UnmanagedCallersOnly reverse P/Invoke calls in exception handling code paths (priority 2 from #123864).

Changes

Convert the following call sites in excep.cpp to use UnmanagedCallersOnlyCaller:

GetExceptionMessage: Object.ToString via UCO (METHOD__RUNTIMEHELPERS__CALL_TO_STRING)
ExceptionPreserveStackTrace: InternalPreserveStackTrace via UCO
WrapNonCompliantException: RuntimeWrappedException construction via UCO
CreateTypeInitializationExceptionObject: TypeInitializationException construction via UCO
GetResourceStringFromManaged: Environment.GetResourceStringLocal via UCO
GetEventArgsForNotification: FirstChanceExceptionEventArgs construction via UCO

Pattern

Each conversion follows the established pattern:

Add [UnmanagedCallersOnly] static wrapper in managed code with Exception* out-parameter
Add corresponding metasig in metasig.h and DEFINE_METHOD in corelib.h
Replace MethodDescCallSite + ARG_SLOT with UnmanagedCallersOnlyCaller::InvokeThrowing
Remove now-unused DEFINE_METHOD entries for old constructors

All GC references passed to InvokeThrowing are in GCPROTECT'd locations.

…sOnly Replace MethodDescCallSite/CallDescrWorker calls with more efficient UnmanagedCallersOnly reverse P/Invoke calls in exception handling code paths (priority 2 from dotnet#123864): - GetExceptionMessage: Object.ToString via UCO - ExceptionPreserveStackTrace: InternalPreserveStackTrace via UCO - WrapNonCompliantException: RuntimeWrappedException ctor via UCO - CreateTypeInitializationExceptionObject: TypeInitializationException via UCO - GetResourceStringFromManaged: Environment.GetResourceStringLocal via UCO - GetEventArgsForNotification: FirstChanceExceptionEventArgs ctor via UCO Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This pull request converts six exception-related MethodDescCallSite call sites in excep.cpp to use the more efficient UnmanagedCallersOnly reverse P/Invoke pattern, following the established approach from priority 1 and 2 tasks in issue #123864.

Changes:

Replaces MethodDescCallSite/CallDescrWorker with UnmanagedCallersOnlyCaller::InvokeThrowing for six exception-handling methods
Adds six new UnmanagedCallersOnly wrapper methods in managed code (Object.CoreCLR.cs, Exception.CoreCLR.cs, Environment.CoreCLR.cs)
Updates metasig.h with six new method signatures and corelib.h with updated DEFINE_METHOD entries, removing obsolete constructor definitions

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/metasig.h	Adds 6 new metasig definitions for UnmanagedCallersOnly wrappers (PtrObj_PtrStr, PtrObj_PtrObj, PtrStr_PtrStr, PtrException_PtrException, PtrChar_PtrException_PtrObj, PtrException_PtrObj, all with PtrException_RetVoid suffix)
src/coreclr/vm/corelib.h	Updates DEFINE_METHOD entries for the 6 converted methods and removes 3 obsolete constructor entries (TYPE_INIT_EXCEPTION.STR_EX_CTOR, RUNTIME_WRAPPED_EXCEPTION.OBJ_CTOR, FIRSTCHANCE_EVENTARGS.CTOR)
src/coreclr/vm/excep.cpp	Converts 6 call sites to use UnmanagedCallersOnlyCaller: GetExceptionMessage, ExceptionPreserveStackTrace, WrapNonCompliantException, CreateTypeInitializationExceptionObject, GetResourceStringFromManaged, GetEventArgsForNotification
src/coreclr/System.Private.CoreLib/src/System/Object.CoreCLR.cs	Adds GetToString UnmanagedCallersOnly wrapper with Exception* out-parameter
src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs	Adds 4 UnmanagedCallersOnly wrappers: InternalPreserveStackTrace, CreateRuntimeWrappedException, CreateTypeInitializationException, CreateFirstChanceExceptionEventArgs
src/coreclr/System.Private.CoreLib/src/System/Environment.CoreCLR.cs	Converts GetResourceStringLocal to UnmanagedCallersOnly pattern with string* in/out parameters

- Move GetToString from System.Object to System.Exception to avoid breaking reflection in user code - Clean up stale comment about SystemException fallback in CreateTypeInitializationExceptionObject - Rename GetResourceStringLocal to GetResourceString, drop Local suffix - Delete unused DEFINE_CLASS(FIRSTCHANCE_EVENTARGS) from corelib.h - Fold GetResourceStringFromManaged into its single caller ResMgrGetString, pass key as char* and move string creation to managed side - Add GCPROTECT around ResMgrGetString caller in clrex.cpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…o single UCO call Combine event args construction and delegate invocation into a single managed DeliverFirstChanceNotification UCO method. Multicast delegate iteration is now handled by managed Delegate.Invoke. Remove the native DeliverExceptionNotification and GetEventArgsForNotification methods. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

AaronRobinsonMSFT · 2026-02-25T23:34:52Z

@EgorBot -linux_amd -osx_arm64

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;usingSystem;BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);publicclassBench{privateException_cachedException=newInvalidOperationException("test");[Benchmark]publicvoidThrowCatch_NoHandler(){try{throw_cachedException;}catch{}}[Benchmark]publicvoidThrowCatch_WithHandler(){AppDomain.CurrentDomain.FirstChanceException+=Handler;try{throw_cachedException;}catch{}finally{AppDomain.CurrentDomain.FirstChanceException-=Handler;}}privatestaticvoidHandler(object?sender,System.Runtime.ExceptionServices.FirstChanceExceptionEventArgse){}}

…dd OnFirstChanceException method

Replace the CanDeliverNotificationToCurrentAppDomain check, which read the managed FirstChanceException delegate field via CoreLibBinder in cooperative GC mode, with a native Volatile<BOOL> flag set via a SuppressGCTransition QCall when a handler is first registered. This avoids the GCX_COOP transition in DeliverFirstChanceNotification on every exception throw when no handler is registered. The flag is sticky: once set to TRUE it is never cleared, avoiding race conditions between concurrent add/remove operations. - Remove CanDeliverNotificationToCurrentAppDomain and FIELD__APPCONTEXT__FIRST_CHANCE_EXCEPTION - Add AppDomain_SetFirstChanceExceptionHandler QCall (SuppressGCTransition) - Move GCX_COOP inside the handler check in DeliverFirstChanceNotification Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

jkotas

Thanks!

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

…124854) First set of priority 3 conversions from #123864 — replace `MethodDescCallSite`/`CallDescrWorker` calls with `UnmanagedCallersOnly` reverse P/Invoke calls. ## Converted call sites | File | Call site | Method | |------|-----------|--------| | `appdomain.cpp` | `AppDomain::RaiseExitProcessEvent` | `ON_PROCESS_EXIT` | | `appdomain.cpp` | `AppDomain::OnUnhandledException` | `ON_UNHANDLED_EXCEPTION` | | `assembly.cpp` | `RunManagedStartup` | `MANAGED_STARTUP` | | `assembly.cpp` | `RunMainInternal` (TARGET_BROWSER) | `HANDLE_ASYNC_ENTRYPOINT` | | `invokeutil.cpp` | `InvokeUtil::CreateClassLoadExcept` | `ReflectionTypeLoadException` ctor | | `invokeutil.cpp` | `InvokeUtil::CreateTargetExcept` | `TargetInvocationException` ctor | ## Remaining priority 3 items (follow ups) - Main entry point in `RunMainInternal` (dynamic MethodDesc) - `CustomAttribute_CreateCustomAttributeInstance` (dynamic ctor, already a QCall) - `CorHost2::ExecuteAssembly` (dynamic method lookup) - `FuncEvalWrapper`/`DoNormalFuncEval` (debugger func-eval) ## Pattern Follows the same conversion pattern as #124834 (priority 2). Each conversion adds an `[UnmanagedCallersOnly]` managed wrapper with an `Exception*` out-parameter and replaces the native `MethodDescCallSite` + `ARG_SLOT` with `UnmanagedCallersOnlyCaller::InvokeThrowing`. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

AaronRobinsonMSFT · 2026-02-24T23:49:47Z

Summary

Replace MethodDescCallSite/CallDescrWorker calls with more efficient UnmanagedCallersOnly reverse P/Invoke calls in exception handling code paths (priority 2 from #123864).

Changes

Convert the following call sites in excep.cpp to use UnmanagedCallersOnlyCaller:

GetExceptionMessage: Object.ToString via UCO (METHOD__RUNTIMEHELPERS__CALL_TO_STRING)
ExceptionPreserveStackTrace: InternalPreserveStackTrace via UCO
WrapNonCompliantException: RuntimeWrappedException construction via UCO
CreateTypeInitializationExceptionObject: TypeInitializationException construction via UCO
GetResourceStringFromManaged: Environment.GetResourceStringLocal via UCO
GetEventArgsForNotification: FirstChanceExceptionEventArgs construction via UCO

Pattern

Each conversion follows the established pattern:

Add [UnmanagedCallersOnly] static wrapper in managed code with Exception* out-parameter
Add corresponding metasig in metasig.h and DEFINE_METHOD in corelib.h
Replace MethodDescCallSite + ARG_SLOT with UnmanagedCallersOnlyCaller::InvokeThrowing
Remove now-unused DEFINE_METHOD entries for old constructors

All GC references passed to InvokeThrowing are in GCPROTECT'd locations.

…sOnly Replace MethodDescCallSite/CallDescrWorker calls with more efficient UnmanagedCallersOnly reverse P/Invoke calls in exception handling code paths (priority 2 from dotnet#123864): - GetExceptionMessage: Object.ToString via UCO - ExceptionPreserveStackTrace: InternalPreserveStackTrace via UCO - WrapNonCompliantException: RuntimeWrappedException ctor via UCO - CreateTypeInitializationExceptionObject: TypeInitializationException via UCO - GetResourceStringFromManaged: Environment.GetResourceStringLocal via UCO - GetEventArgsForNotification: FirstChanceExceptionEventArgs ctor via UCO Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This pull request converts six exception-related MethodDescCallSite call sites in excep.cpp to use the more efficient UnmanagedCallersOnly reverse P/Invoke pattern, following the established approach from priority 1 and 2 tasks in issue #123864.

Changes:

Replaces MethodDescCallSite/CallDescrWorker with UnmanagedCallersOnlyCaller::InvokeThrowing for six exception-handling methods
Adds six new UnmanagedCallersOnly wrapper methods in managed code (Object.CoreCLR.cs, Exception.CoreCLR.cs, Environment.CoreCLR.cs)
Updates metasig.h with six new method signatures and corelib.h with updated DEFINE_METHOD entries, removing obsolete constructor definitions

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/metasig.h	Adds 6 new metasig definitions for UnmanagedCallersOnly wrappers (PtrObj_PtrStr, PtrObj_PtrObj, PtrStr_PtrStr, PtrException_PtrException, PtrChar_PtrException_PtrObj, PtrException_PtrObj, all with PtrException_RetVoid suffix)
src/coreclr/vm/corelib.h	Updates DEFINE_METHOD entries for the 6 converted methods and removes 3 obsolete constructor entries (TYPE_INIT_EXCEPTION.STR_EX_CTOR, RUNTIME_WRAPPED_EXCEPTION.OBJ_CTOR, FIRSTCHANCE_EVENTARGS.CTOR)
src/coreclr/vm/excep.cpp	Converts 6 call sites to use UnmanagedCallersOnlyCaller: GetExceptionMessage, ExceptionPreserveStackTrace, WrapNonCompliantException, CreateTypeInitializationExceptionObject, GetResourceStringFromManaged, GetEventArgsForNotification
src/coreclr/System.Private.CoreLib/src/System/Object.CoreCLR.cs	Adds GetToString UnmanagedCallersOnly wrapper with Exception* out-parameter
src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs	Adds 4 UnmanagedCallersOnly wrappers: InternalPreserveStackTrace, CreateRuntimeWrappedException, CreateTypeInitializationException, CreateFirstChanceExceptionEventArgs
src/coreclr/System.Private.CoreLib/src/System/Environment.CoreCLR.cs	Converts GetResourceStringLocal to UnmanagedCallersOnly pattern with string* in/out parameters

- Move GetToString from System.Object to System.Exception to avoid breaking reflection in user code - Clean up stale comment about SystemException fallback in CreateTypeInitializationExceptionObject - Rename GetResourceStringLocal to GetResourceString, drop Local suffix - Delete unused DEFINE_CLASS(FIRSTCHANCE_EVENTARGS) from corelib.h - Fold GetResourceStringFromManaged into its single caller ResMgrGetString, pass key as char* and move string creation to managed side - Add GCPROTECT around ResMgrGetString caller in clrex.cpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…o single UCO call Combine event args construction and delegate invocation into a single managed DeliverFirstChanceNotification UCO method. Multicast delegate iteration is now handled by managed Delegate.Invoke. Remove the native DeliverExceptionNotification and GetEventArgsForNotification methods. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

AaronRobinsonMSFT · 2026-02-25T23:34:52Z

@EgorBot -linux_amd -osx_arm64

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;usingSystem;BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);publicclassBench{privateException_cachedException=newInvalidOperationException("test");[Benchmark]publicvoidThrowCatch_NoHandler(){try{throw_cachedException;}catch{}}[Benchmark]publicvoidThrowCatch_WithHandler(){AppDomain.CurrentDomain.FirstChanceException+=Handler;try{throw_cachedException;}catch{}finally{AppDomain.CurrentDomain.FirstChanceException-=Handler;}}privatestaticvoidHandler(object?sender,System.Runtime.ExceptionServices.FirstChanceExceptionEventArgse){}}

…dd OnFirstChanceException method

Replace the CanDeliverNotificationToCurrentAppDomain check, which read the managed FirstChanceException delegate field via CoreLibBinder in cooperative GC mode, with a native Volatile<BOOL> flag set via a SuppressGCTransition QCall when a handler is first registered. This avoids the GCX_COOP transition in DeliverFirstChanceNotification on every exception throw when no handler is registered. The flag is sticky: once set to TRUE it is never cleared, avoiding race conditions between concurrent add/remove operations. - Remove CanDeliverNotificationToCurrentAppDomain and FIELD__APPCONTEXT__FIRST_CHANCE_EXCEPTION - Add AppDomain_SetFirstChanceExceptionHandler QCall (SuppressGCTransition) - Move GCX_COOP inside the handler check in DeliverFirstChanceNotification Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

jkotas

Thanks!

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

…124854) First set of priority 3 conversions from #123864 — replace `MethodDescCallSite`/`CallDescrWorker` calls with `UnmanagedCallersOnly` reverse P/Invoke calls. ## Converted call sites | File | Call site | Method | |------|-----------|--------| | `appdomain.cpp` | `AppDomain::RaiseExitProcessEvent` | `ON_PROCESS_EXIT` | | `appdomain.cpp` | `AppDomain::OnUnhandledException` | `ON_UNHANDLED_EXCEPTION` | | `assembly.cpp` | `RunManagedStartup` | `MANAGED_STARTUP` | | `assembly.cpp` | `RunMainInternal` (TARGET_BROWSER) | `HANDLE_ASYNC_ENTRYPOINT` | | `invokeutil.cpp` | `InvokeUtil::CreateClassLoadExcept` | `ReflectionTypeLoadException` ctor | | `invokeutil.cpp` | `InvokeUtil::CreateTargetExcept` | `TargetInvocationException` ctor | ## Remaining priority 3 items (follow ups) - Main entry point in `RunMainInternal` (dynamic MethodDesc) - `CustomAttribute_CreateCustomAttributeInstance` (dynamic ctor, already a QCall) - `CorHost2::ExecuteAssembly` (dynamic method lookup) - `FuncEvalWrapper`/`DoNormalFuncEval` (debugger func-eval) ## Pattern Follows the same conversion pattern as #124834 (priority 2). Each conversion adds an `[UnmanagedCallersOnly]` managed wrapper with an `Exception*` out-parameter and replaces the native `MethodDescCallSite` + `ARG_SLOT` with `UnmanagedCallersOnlyCaller::InvokeThrowing`. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

AaronRobinsonMSFT · 2026-02-24T23:49:47Z

Summary

Replace MethodDescCallSite/CallDescrWorker calls with more efficient UnmanagedCallersOnly reverse P/Invoke calls in exception handling code paths (priority 2 from #123864).

Changes

Convert the following call sites in excep.cpp to use UnmanagedCallersOnlyCaller:

GetExceptionMessage: Object.ToString via UCO (METHOD__RUNTIMEHELPERS__CALL_TO_STRING)
ExceptionPreserveStackTrace: InternalPreserveStackTrace via UCO
WrapNonCompliantException: RuntimeWrappedException construction via UCO
CreateTypeInitializationExceptionObject: TypeInitializationException construction via UCO
GetResourceStringFromManaged: Environment.GetResourceStringLocal via UCO
GetEventArgsForNotification: FirstChanceExceptionEventArgs construction via UCO

Pattern

Each conversion follows the established pattern:

Add [UnmanagedCallersOnly] static wrapper in managed code with Exception* out-parameter
Add corresponding metasig in metasig.h and DEFINE_METHOD in corelib.h
Replace MethodDescCallSite + ARG_SLOT with UnmanagedCallersOnlyCaller::InvokeThrowing
Remove now-unused DEFINE_METHOD entries for old constructors

All GC references passed to InvokeThrowing are in GCPROTECT'd locations.

…sOnly Replace MethodDescCallSite/CallDescrWorker calls with more efficient UnmanagedCallersOnly reverse P/Invoke calls in exception handling code paths (priority 2 from dotnet#123864): - GetExceptionMessage: Object.ToString via UCO - ExceptionPreserveStackTrace: InternalPreserveStackTrace via UCO - WrapNonCompliantException: RuntimeWrappedException ctor via UCO - CreateTypeInitializationExceptionObject: TypeInitializationException via UCO - GetResourceStringFromManaged: Environment.GetResourceStringLocal via UCO - GetEventArgsForNotification: FirstChanceExceptionEventArgs ctor via UCO Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This pull request converts six exception-related MethodDescCallSite call sites in excep.cpp to use the more efficient UnmanagedCallersOnly reverse P/Invoke pattern, following the established approach from priority 1 and 2 tasks in issue #123864.

Changes:

Replaces MethodDescCallSite/CallDescrWorker with UnmanagedCallersOnlyCaller::InvokeThrowing for six exception-handling methods
Adds six new UnmanagedCallersOnly wrapper methods in managed code (Object.CoreCLR.cs, Exception.CoreCLR.cs, Environment.CoreCLR.cs)
Updates metasig.h with six new method signatures and corelib.h with updated DEFINE_METHOD entries, removing obsolete constructor definitions

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/metasig.h	Adds 6 new metasig definitions for UnmanagedCallersOnly wrappers (PtrObj_PtrStr, PtrObj_PtrObj, PtrStr_PtrStr, PtrException_PtrException, PtrChar_PtrException_PtrObj, PtrException_PtrObj, all with PtrException_RetVoid suffix)
src/coreclr/vm/corelib.h	Updates DEFINE_METHOD entries for the 6 converted methods and removes 3 obsolete constructor entries (TYPE_INIT_EXCEPTION.STR_EX_CTOR, RUNTIME_WRAPPED_EXCEPTION.OBJ_CTOR, FIRSTCHANCE_EVENTARGS.CTOR)
src/coreclr/vm/excep.cpp	Converts 6 call sites to use UnmanagedCallersOnlyCaller: GetExceptionMessage, ExceptionPreserveStackTrace, WrapNonCompliantException, CreateTypeInitializationExceptionObject, GetResourceStringFromManaged, GetEventArgsForNotification
src/coreclr/System.Private.CoreLib/src/System/Object.CoreCLR.cs	Adds GetToString UnmanagedCallersOnly wrapper with Exception* out-parameter
src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs	Adds 4 UnmanagedCallersOnly wrappers: InternalPreserveStackTrace, CreateRuntimeWrappedException, CreateTypeInitializationException, CreateFirstChanceExceptionEventArgs
src/coreclr/System.Private.CoreLib/src/System/Environment.CoreCLR.cs	Converts GetResourceStringLocal to UnmanagedCallersOnly pattern with string* in/out parameters

- Move GetToString from System.Object to System.Exception to avoid breaking reflection in user code - Clean up stale comment about SystemException fallback in CreateTypeInitializationExceptionObject - Rename GetResourceStringLocal to GetResourceString, drop Local suffix - Delete unused DEFINE_CLASS(FIRSTCHANCE_EVENTARGS) from corelib.h - Fold GetResourceStringFromManaged into its single caller ResMgrGetString, pass key as char* and move string creation to managed side - Add GCPROTECT around ResMgrGetString caller in clrex.cpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…o single UCO call Combine event args construction and delegate invocation into a single managed DeliverFirstChanceNotification UCO method. Multicast delegate iteration is now handled by managed Delegate.Invoke. Remove the native DeliverExceptionNotification and GetEventArgsForNotification methods. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

AaronRobinsonMSFT · 2026-02-25T23:34:52Z

@EgorBot -linux_amd -osx_arm64

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;usingSystem;BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);publicclassBench{privateException_cachedException=newInvalidOperationException("test");[Benchmark]publicvoidThrowCatch_NoHandler(){try{throw_cachedException;}catch{}}[Benchmark]publicvoidThrowCatch_WithHandler(){AppDomain.CurrentDomain.FirstChanceException+=Handler;try{throw_cachedException;}catch{}finally{AppDomain.CurrentDomain.FirstChanceException-=Handler;}}privatestaticvoidHandler(object?sender,System.Runtime.ExceptionServices.FirstChanceExceptionEventArgse){}}

…dd OnFirstChanceException method

Replace the CanDeliverNotificationToCurrentAppDomain check, which read the managed FirstChanceException delegate field via CoreLibBinder in cooperative GC mode, with a native Volatile<BOOL> flag set via a SuppressGCTransition QCall when a handler is first registered. This avoids the GCX_COOP transition in DeliverFirstChanceNotification on every exception throw when no handler is registered. The flag is sticky: once set to TRUE it is never cleared, avoiding race conditions between concurrent add/remove operations. - Remove CanDeliverNotificationToCurrentAppDomain and FIELD__APPCONTEXT__FIRST_CHANCE_EXCEPTION - Add AppDomain_SetFirstChanceExceptionHandler QCall (SuppressGCTransition) - Move GCX_COOP inside the handler check in DeliverFirstChanceNotification Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

jkotas

Thanks!

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

…124854) First set of priority 3 conversions from #123864 — replace `MethodDescCallSite`/`CallDescrWorker` calls with `UnmanagedCallersOnly` reverse P/Invoke calls. ## Converted call sites | File | Call site | Method | |------|-----------|--------| | `appdomain.cpp` | `AppDomain::RaiseExitProcessEvent` | `ON_PROCESS_EXIT` | | `appdomain.cpp` | `AppDomain::OnUnhandledException` | `ON_UNHANDLED_EXCEPTION` | | `assembly.cpp` | `RunManagedStartup` | `MANAGED_STARTUP` | | `assembly.cpp` | `RunMainInternal` (TARGET_BROWSER) | `HANDLE_ASYNC_ENTRYPOINT` | | `invokeutil.cpp` | `InvokeUtil::CreateClassLoadExcept` | `ReflectionTypeLoadException` ctor | | `invokeutil.cpp` | `InvokeUtil::CreateTargetExcept` | `TargetInvocationException` ctor | ## Remaining priority 3 items (follow ups) - Main entry point in `RunMainInternal` (dynamic MethodDesc) - `CustomAttribute_CreateCustomAttributeInstance` (dynamic ctor, already a QCall) - `CorHost2::ExecuteAssembly` (dynamic method lookup) - `FuncEvalWrapper`/`DoNormalFuncEval` (debugger func-eval) ## Pattern Follows the same conversion pattern as #124834 (priority 2). Each conversion adds an `[UnmanagedCallersOnly]` managed wrapper with an `Exception*` out-parameter and replaces the native `MethodDescCallSite` + `ARG_SLOT` with `UnmanagedCallersOnlyCaller::InvokeThrowing`. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

AaronRobinsonMSFT · 2026-02-24T23:49:47Z

Summary

Replace MethodDescCallSite/CallDescrWorker calls with more efficient UnmanagedCallersOnly reverse P/Invoke calls in exception handling code paths (priority 2 from #123864).

Changes

Convert the following call sites in excep.cpp to use UnmanagedCallersOnlyCaller:

GetExceptionMessage: Object.ToString via UCO (METHOD__RUNTIMEHELPERS__CALL_TO_STRING)
ExceptionPreserveStackTrace: InternalPreserveStackTrace via UCO
WrapNonCompliantException: RuntimeWrappedException construction via UCO
CreateTypeInitializationExceptionObject: TypeInitializationException construction via UCO
GetResourceStringFromManaged: Environment.GetResourceStringLocal via UCO
GetEventArgsForNotification: FirstChanceExceptionEventArgs construction via UCO

Pattern

Each conversion follows the established pattern:

Add [UnmanagedCallersOnly] static wrapper in managed code with Exception* out-parameter
Add corresponding metasig in metasig.h and DEFINE_METHOD in corelib.h
Replace MethodDescCallSite + ARG_SLOT with UnmanagedCallersOnlyCaller::InvokeThrowing
Remove now-unused DEFINE_METHOD entries for old constructors

All GC references passed to InvokeThrowing are in GCPROTECT'd locations.

…sOnly Replace MethodDescCallSite/CallDescrWorker calls with more efficient UnmanagedCallersOnly reverse P/Invoke calls in exception handling code paths (priority 2 from dotnet#123864): - GetExceptionMessage: Object.ToString via UCO - ExceptionPreserveStackTrace: InternalPreserveStackTrace via UCO - WrapNonCompliantException: RuntimeWrappedException ctor via UCO - CreateTypeInitializationExceptionObject: TypeInitializationException via UCO - GetResourceStringFromManaged: Environment.GetResourceStringLocal via UCO - GetEventArgsForNotification: FirstChanceExceptionEventArgs ctor via UCO Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This pull request converts six exception-related MethodDescCallSite call sites in excep.cpp to use the more efficient UnmanagedCallersOnly reverse P/Invoke pattern, following the established approach from priority 1 and 2 tasks in issue #123864.

Changes:

Replaces MethodDescCallSite/CallDescrWorker with UnmanagedCallersOnlyCaller::InvokeThrowing for six exception-handling methods
Adds six new UnmanagedCallersOnly wrapper methods in managed code (Object.CoreCLR.cs, Exception.CoreCLR.cs, Environment.CoreCLR.cs)
Updates metasig.h with six new method signatures and corelib.h with updated DEFINE_METHOD entries, removing obsolete constructor definitions

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/metasig.h	Adds 6 new metasig definitions for UnmanagedCallersOnly wrappers (PtrObj_PtrStr, PtrObj_PtrObj, PtrStr_PtrStr, PtrException_PtrException, PtrChar_PtrException_PtrObj, PtrException_PtrObj, all with PtrException_RetVoid suffix)
src/coreclr/vm/corelib.h	Updates DEFINE_METHOD entries for the 6 converted methods and removes 3 obsolete constructor entries (TYPE_INIT_EXCEPTION.STR_EX_CTOR, RUNTIME_WRAPPED_EXCEPTION.OBJ_CTOR, FIRSTCHANCE_EVENTARGS.CTOR)
src/coreclr/vm/excep.cpp	Converts 6 call sites to use UnmanagedCallersOnlyCaller: GetExceptionMessage, ExceptionPreserveStackTrace, WrapNonCompliantException, CreateTypeInitializationExceptionObject, GetResourceStringFromManaged, GetEventArgsForNotification
src/coreclr/System.Private.CoreLib/src/System/Object.CoreCLR.cs	Adds GetToString UnmanagedCallersOnly wrapper with Exception* out-parameter
src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs	Adds 4 UnmanagedCallersOnly wrappers: InternalPreserveStackTrace, CreateRuntimeWrappedException, CreateTypeInitializationException, CreateFirstChanceExceptionEventArgs
src/coreclr/System.Private.CoreLib/src/System/Environment.CoreCLR.cs	Converts GetResourceStringLocal to UnmanagedCallersOnly pattern with string* in/out parameters

- Move GetToString from System.Object to System.Exception to avoid breaking reflection in user code - Clean up stale comment about SystemException fallback in CreateTypeInitializationExceptionObject - Rename GetResourceStringLocal to GetResourceString, drop Local suffix - Delete unused DEFINE_CLASS(FIRSTCHANCE_EVENTARGS) from corelib.h - Fold GetResourceStringFromManaged into its single caller ResMgrGetString, pass key as char* and move string creation to managed side - Add GCPROTECT around ResMgrGetString caller in clrex.cpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…o single UCO call Combine event args construction and delegate invocation into a single managed DeliverFirstChanceNotification UCO method. Multicast delegate iteration is now handled by managed Delegate.Invoke. Remove the native DeliverExceptionNotification and GetEventArgsForNotification methods. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

AaronRobinsonMSFT · 2026-02-25T23:34:52Z

@EgorBot -linux_amd -osx_arm64

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;usingSystem;BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);publicclassBench{privateException_cachedException=newInvalidOperationException("test");[Benchmark]publicvoidThrowCatch_NoHandler(){try{throw_cachedException;}catch{}}[Benchmark]publicvoidThrowCatch_WithHandler(){AppDomain.CurrentDomain.FirstChanceException+=Handler;try{throw_cachedException;}catch{}finally{AppDomain.CurrentDomain.FirstChanceException-=Handler;}}privatestaticvoidHandler(object?sender,System.Runtime.ExceptionServices.FirstChanceExceptionEventArgse){}}

…dd OnFirstChanceException method

Replace the CanDeliverNotificationToCurrentAppDomain check, which read the managed FirstChanceException delegate field via CoreLibBinder in cooperative GC mode, with a native Volatile<BOOL> flag set via a SuppressGCTransition QCall when a handler is first registered. This avoids the GCX_COOP transition in DeliverFirstChanceNotification on every exception throw when no handler is registered. The flag is sticky: once set to TRUE it is never cleared, avoiding race conditions between concurrent add/remove operations. - Remove CanDeliverNotificationToCurrentAppDomain and FIELD__APPCONTEXT__FIRST_CHANCE_EXCEPTION - Add AppDomain_SetFirstChanceExceptionHandler QCall (SuppressGCTransition) - Move GCX_COOP inside the handler check in DeliverFirstChanceNotification Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

jkotas

Thanks!

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

…124854) First set of priority 3 conversions from #123864 — replace `MethodDescCallSite`/`CallDescrWorker` calls with `UnmanagedCallersOnly` reverse P/Invoke calls. ## Converted call sites | File | Call site | Method | |------|-----------|--------| | `appdomain.cpp` | `AppDomain::RaiseExitProcessEvent` | `ON_PROCESS_EXIT` | | `appdomain.cpp` | `AppDomain::OnUnhandledException` | `ON_UNHANDLED_EXCEPTION` | | `assembly.cpp` | `RunManagedStartup` | `MANAGED_STARTUP` | | `assembly.cpp` | `RunMainInternal` (TARGET_BROWSER) | `HANDLE_ASYNC_ENTRYPOINT` | | `invokeutil.cpp` | `InvokeUtil::CreateClassLoadExcept` | `ReflectionTypeLoadException` ctor | | `invokeutil.cpp` | `InvokeUtil::CreateTargetExcept` | `TargetInvocationException` ctor | ## Remaining priority 3 items (follow ups) - Main entry point in `RunMainInternal` (dynamic MethodDesc) - `CustomAttribute_CreateCustomAttributeInstance` (dynamic ctor, already a QCall) - `CorHost2::ExecuteAssembly` (dynamic method lookup) - `FuncEvalWrapper`/`DoNormalFuncEval` (debugger func-eval) ## Pattern Follows the same conversion pattern as #124834 (priority 2). Each conversion adds an `[UnmanagedCallersOnly]` managed wrapper with an `Exception*` out-parameter and replaces the native `MethodDescCallSite` + `ARG_SLOT` with `UnmanagedCallersOnlyCaller::InvokeThrowing`. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

AaronRobinsonMSFT · 2026-02-24T23:49:47Z

Summary

Replace MethodDescCallSite/CallDescrWorker calls with more efficient UnmanagedCallersOnly reverse P/Invoke calls in exception handling code paths (priority 2 from #123864).

Changes

Convert the following call sites in excep.cpp to use UnmanagedCallersOnlyCaller:

GetExceptionMessage: Object.ToString via UCO (METHOD__RUNTIMEHELPERS__CALL_TO_STRING)
ExceptionPreserveStackTrace: InternalPreserveStackTrace via UCO
WrapNonCompliantException: RuntimeWrappedException construction via UCO
CreateTypeInitializationExceptionObject: TypeInitializationException construction via UCO
GetResourceStringFromManaged: Environment.GetResourceStringLocal via UCO
GetEventArgsForNotification: FirstChanceExceptionEventArgs construction via UCO

Pattern

Each conversion follows the established pattern:

Add [UnmanagedCallersOnly] static wrapper in managed code with Exception* out-parameter
Add corresponding metasig in metasig.h and DEFINE_METHOD in corelib.h
Replace MethodDescCallSite + ARG_SLOT with UnmanagedCallersOnlyCaller::InvokeThrowing
Remove now-unused DEFINE_METHOD entries for old constructors

All GC references passed to InvokeThrowing are in GCPROTECT'd locations.

…sOnly Replace MethodDescCallSite/CallDescrWorker calls with more efficient UnmanagedCallersOnly reverse P/Invoke calls in exception handling code paths (priority 2 from dotnet#123864): - GetExceptionMessage: Object.ToString via UCO - ExceptionPreserveStackTrace: InternalPreserveStackTrace via UCO - WrapNonCompliantException: RuntimeWrappedException ctor via UCO - CreateTypeInitializationExceptionObject: TypeInitializationException via UCO - GetResourceStringFromManaged: Environment.GetResourceStringLocal via UCO - GetEventArgsForNotification: FirstChanceExceptionEventArgs ctor via UCO Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This pull request converts six exception-related MethodDescCallSite call sites in excep.cpp to use the more efficient UnmanagedCallersOnly reverse P/Invoke pattern, following the established approach from priority 1 and 2 tasks in issue #123864.

Changes:

Replaces MethodDescCallSite/CallDescrWorker with UnmanagedCallersOnlyCaller::InvokeThrowing for six exception-handling methods
Adds six new UnmanagedCallersOnly wrapper methods in managed code (Object.CoreCLR.cs, Exception.CoreCLR.cs, Environment.CoreCLR.cs)
Updates metasig.h with six new method signatures and corelib.h with updated DEFINE_METHOD entries, removing obsolete constructor definitions

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/metasig.h	Adds 6 new metasig definitions for UnmanagedCallersOnly wrappers (PtrObj_PtrStr, PtrObj_PtrObj, PtrStr_PtrStr, PtrException_PtrException, PtrChar_PtrException_PtrObj, PtrException_PtrObj, all with PtrException_RetVoid suffix)
src/coreclr/vm/corelib.h	Updates DEFINE_METHOD entries for the 6 converted methods and removes 3 obsolete constructor entries (TYPE_INIT_EXCEPTION.STR_EX_CTOR, RUNTIME_WRAPPED_EXCEPTION.OBJ_CTOR, FIRSTCHANCE_EVENTARGS.CTOR)
src/coreclr/vm/excep.cpp	Converts 6 call sites to use UnmanagedCallersOnlyCaller: GetExceptionMessage, ExceptionPreserveStackTrace, WrapNonCompliantException, CreateTypeInitializationExceptionObject, GetResourceStringFromManaged, GetEventArgsForNotification
src/coreclr/System.Private.CoreLib/src/System/Object.CoreCLR.cs	Adds GetToString UnmanagedCallersOnly wrapper with Exception* out-parameter
src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs	Adds 4 UnmanagedCallersOnly wrappers: InternalPreserveStackTrace, CreateRuntimeWrappedException, CreateTypeInitializationException, CreateFirstChanceExceptionEventArgs
src/coreclr/System.Private.CoreLib/src/System/Environment.CoreCLR.cs	Converts GetResourceStringLocal to UnmanagedCallersOnly pattern with string* in/out parameters

- Move GetToString from System.Object to System.Exception to avoid breaking reflection in user code - Clean up stale comment about SystemException fallback in CreateTypeInitializationExceptionObject - Rename GetResourceStringLocal to GetResourceString, drop Local suffix - Delete unused DEFINE_CLASS(FIRSTCHANCE_EVENTARGS) from corelib.h - Fold GetResourceStringFromManaged into its single caller ResMgrGetString, pass key as char* and move string creation to managed side - Add GCPROTECT around ResMgrGetString caller in clrex.cpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…o single UCO call Combine event args construction and delegate invocation into a single managed DeliverFirstChanceNotification UCO method. Multicast delegate iteration is now handled by managed Delegate.Invoke. Remove the native DeliverExceptionNotification and GetEventArgsForNotification methods. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

AaronRobinsonMSFT · 2026-02-25T23:34:52Z

@EgorBot -linux_amd -osx_arm64

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;usingSystem;BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);publicclassBench{privateException_cachedException=newInvalidOperationException("test");[Benchmark]publicvoidThrowCatch_NoHandler(){try{throw_cachedException;}catch{}}[Benchmark]publicvoidThrowCatch_WithHandler(){AppDomain.CurrentDomain.FirstChanceException+=Handler;try{throw_cachedException;}catch{}finally{AppDomain.CurrentDomain.FirstChanceException-=Handler;}}privatestaticvoidHandler(object?sender,System.Runtime.ExceptionServices.FirstChanceExceptionEventArgse){}}

…dd OnFirstChanceException method

Replace the CanDeliverNotificationToCurrentAppDomain check, which read the managed FirstChanceException delegate field via CoreLibBinder in cooperative GC mode, with a native Volatile<BOOL> flag set via a SuppressGCTransition QCall when a handler is first registered. This avoids the GCX_COOP transition in DeliverFirstChanceNotification on every exception throw when no handler is registered. The flag is sticky: once set to TRUE it is never cleared, avoiding race conditions between concurrent add/remove operations. - Remove CanDeliverNotificationToCurrentAppDomain and FIELD__APPCONTEXT__FIRST_CHANCE_EXCEPTION - Add AppDomain_SetFirstChanceExceptionHandler QCall (SuppressGCTransition) - Move GCX_COOP inside the handler check in DeliverFirstChanceNotification Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

jkotas

Thanks!

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

…124854) First set of priority 3 conversions from #123864 — replace `MethodDescCallSite`/`CallDescrWorker` calls with `UnmanagedCallersOnly` reverse P/Invoke calls. ## Converted call sites | File | Call site | Method | |------|-----------|--------| | `appdomain.cpp` | `AppDomain::RaiseExitProcessEvent` | `ON_PROCESS_EXIT` | | `appdomain.cpp` | `AppDomain::OnUnhandledException` | `ON_UNHANDLED_EXCEPTION` | | `assembly.cpp` | `RunManagedStartup` | `MANAGED_STARTUP` | | `assembly.cpp` | `RunMainInternal` (TARGET_BROWSER) | `HANDLE_ASYNC_ENTRYPOINT` | | `invokeutil.cpp` | `InvokeUtil::CreateClassLoadExcept` | `ReflectionTypeLoadException` ctor | | `invokeutil.cpp` | `InvokeUtil::CreateTargetExcept` | `TargetInvocationException` ctor | ## Remaining priority 3 items (follow ups) - Main entry point in `RunMainInternal` (dynamic MethodDesc) - `CustomAttribute_CreateCustomAttributeInstance` (dynamic ctor, already a QCall) - `CorHost2::ExecuteAssembly` (dynamic method lookup) - `FuncEvalWrapper`/`DoNormalFuncEval` (debugger func-eval) ## Pattern Follows the same conversion pattern as #124834 (priority 2). Each conversion adds an `[UnmanagedCallersOnly]` managed wrapper with an `Exception*` out-parameter and replaces the native `MethodDescCallSite` + `ARG_SLOT` with `UnmanagedCallersOnlyCaller::InvokeThrowing`. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

AaronRobinsonMSFT · 2026-02-24T23:49:47Z

Summary

Replace MethodDescCallSite/CallDescrWorker calls with more efficient UnmanagedCallersOnly reverse P/Invoke calls in exception handling code paths (priority 2 from #123864).

Changes

Convert the following call sites in excep.cpp to use UnmanagedCallersOnlyCaller:

GetExceptionMessage: Object.ToString via UCO (METHOD__RUNTIMEHELPERS__CALL_TO_STRING)
ExceptionPreserveStackTrace: InternalPreserveStackTrace via UCO
WrapNonCompliantException: RuntimeWrappedException construction via UCO
CreateTypeInitializationExceptionObject: TypeInitializationException construction via UCO
GetResourceStringFromManaged: Environment.GetResourceStringLocal via UCO
GetEventArgsForNotification: FirstChanceExceptionEventArgs construction via UCO

Pattern

Each conversion follows the established pattern:

Add [UnmanagedCallersOnly] static wrapper in managed code with Exception* out-parameter
Add corresponding metasig in metasig.h and DEFINE_METHOD in corelib.h
Replace MethodDescCallSite + ARG_SLOT with UnmanagedCallersOnlyCaller::InvokeThrowing
Remove now-unused DEFINE_METHOD entries for old constructors

All GC references passed to InvokeThrowing are in GCPROTECT'd locations.

…sOnly Replace MethodDescCallSite/CallDescrWorker calls with more efficient UnmanagedCallersOnly reverse P/Invoke calls in exception handling code paths (priority 2 from dotnet#123864): - GetExceptionMessage: Object.ToString via UCO - ExceptionPreserveStackTrace: InternalPreserveStackTrace via UCO - WrapNonCompliantException: RuntimeWrappedException ctor via UCO - CreateTypeInitializationExceptionObject: TypeInitializationException via UCO - GetResourceStringFromManaged: Environment.GetResourceStringLocal via UCO - GetEventArgsForNotification: FirstChanceExceptionEventArgs ctor via UCO Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This pull request converts six exception-related MethodDescCallSite call sites in excep.cpp to use the more efficient UnmanagedCallersOnly reverse P/Invoke pattern, following the established approach from priority 1 and 2 tasks in issue #123864.

Changes:

Replaces MethodDescCallSite/CallDescrWorker with UnmanagedCallersOnlyCaller::InvokeThrowing for six exception-handling methods
Adds six new UnmanagedCallersOnly wrapper methods in managed code (Object.CoreCLR.cs, Exception.CoreCLR.cs, Environment.CoreCLR.cs)
Updates metasig.h with six new method signatures and corelib.h with updated DEFINE_METHOD entries, removing obsolete constructor definitions

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/metasig.h	Adds 6 new metasig definitions for UnmanagedCallersOnly wrappers (PtrObj_PtrStr, PtrObj_PtrObj, PtrStr_PtrStr, PtrException_PtrException, PtrChar_PtrException_PtrObj, PtrException_PtrObj, all with PtrException_RetVoid suffix)
src/coreclr/vm/corelib.h	Updates DEFINE_METHOD entries for the 6 converted methods and removes 3 obsolete constructor entries (TYPE_INIT_EXCEPTION.STR_EX_CTOR, RUNTIME_WRAPPED_EXCEPTION.OBJ_CTOR, FIRSTCHANCE_EVENTARGS.CTOR)
src/coreclr/vm/excep.cpp	Converts 6 call sites to use UnmanagedCallersOnlyCaller: GetExceptionMessage, ExceptionPreserveStackTrace, WrapNonCompliantException, CreateTypeInitializationExceptionObject, GetResourceStringFromManaged, GetEventArgsForNotification
src/coreclr/System.Private.CoreLib/src/System/Object.CoreCLR.cs	Adds GetToString UnmanagedCallersOnly wrapper with Exception* out-parameter
src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs	Adds 4 UnmanagedCallersOnly wrappers: InternalPreserveStackTrace, CreateRuntimeWrappedException, CreateTypeInitializationException, CreateFirstChanceExceptionEventArgs
src/coreclr/System.Private.CoreLib/src/System/Environment.CoreCLR.cs	Converts GetResourceStringLocal to UnmanagedCallersOnly pattern with string* in/out parameters

- Move GetToString from System.Object to System.Exception to avoid breaking reflection in user code - Clean up stale comment about SystemException fallback in CreateTypeInitializationExceptionObject - Rename GetResourceStringLocal to GetResourceString, drop Local suffix - Delete unused DEFINE_CLASS(FIRSTCHANCE_EVENTARGS) from corelib.h - Fold GetResourceStringFromManaged into its single caller ResMgrGetString, pass key as char* and move string creation to managed side - Add GCPROTECT around ResMgrGetString caller in clrex.cpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…o single UCO call Combine event args construction and delegate invocation into a single managed DeliverFirstChanceNotification UCO method. Multicast delegate iteration is now handled by managed Delegate.Invoke. Remove the native DeliverExceptionNotification and GetEventArgsForNotification methods. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

AaronRobinsonMSFT · 2026-02-25T23:34:52Z

@EgorBot -linux_amd -osx_arm64

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;usingSystem;BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);publicclassBench{privateException_cachedException=newInvalidOperationException("test");[Benchmark]publicvoidThrowCatch_NoHandler(){try{throw_cachedException;}catch{}}[Benchmark]publicvoidThrowCatch_WithHandler(){AppDomain.CurrentDomain.FirstChanceException+=Handler;try{throw_cachedException;}catch{}finally{AppDomain.CurrentDomain.FirstChanceException-=Handler;}}privatestaticvoidHandler(object?sender,System.Runtime.ExceptionServices.FirstChanceExceptionEventArgse){}}

…dd OnFirstChanceException method

Replace the CanDeliverNotificationToCurrentAppDomain check, which read the managed FirstChanceException delegate field via CoreLibBinder in cooperative GC mode, with a native Volatile<BOOL> flag set via a SuppressGCTransition QCall when a handler is first registered. This avoids the GCX_COOP transition in DeliverFirstChanceNotification on every exception throw when no handler is registered. The flag is sticky: once set to TRUE it is never cleared, avoiding race conditions between concurrent add/remove operations. - Remove CanDeliverNotificationToCurrentAppDomain and FIELD__APPCONTEXT__FIRST_CHANCE_EXCEPTION - Add AppDomain_SetFirstChanceExceptionHandler QCall (SuppressGCTransition) - Move GCX_COOP inside the handler check in DeliverFirstChanceNotification Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

jkotas

Thanks!

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

…124854) First set of priority 3 conversions from #123864 — replace `MethodDescCallSite`/`CallDescrWorker` calls with `UnmanagedCallersOnly` reverse P/Invoke calls. ## Converted call sites | File | Call site | Method | |------|-----------|--------| | `appdomain.cpp` | `AppDomain::RaiseExitProcessEvent` | `ON_PROCESS_EXIT` | | `appdomain.cpp` | `AppDomain::OnUnhandledException` | `ON_UNHANDLED_EXCEPTION` | | `assembly.cpp` | `RunManagedStartup` | `MANAGED_STARTUP` | | `assembly.cpp` | `RunMainInternal` (TARGET_BROWSER) | `HANDLE_ASYNC_ENTRYPOINT` | | `invokeutil.cpp` | `InvokeUtil::CreateClassLoadExcept` | `ReflectionTypeLoadException` ctor | | `invokeutil.cpp` | `InvokeUtil::CreateTargetExcept` | `TargetInvocationException` ctor | ## Remaining priority 3 items (follow ups) - Main entry point in `RunMainInternal` (dynamic MethodDesc) - `CustomAttribute_CreateCustomAttributeInstance` (dynamic ctor, already a QCall) - `CorHost2::ExecuteAssembly` (dynamic method lookup) - `FuncEvalWrapper`/`DoNormalFuncEval` (debugger func-eval) ## Pattern Follows the same conversion pattern as #124834 (priority 2). Each conversion adds an `[UnmanagedCallersOnly]` managed wrapper with an `Exception*` out-parameter and replaces the native `MethodDescCallSite` + `ARG_SLOT` with `UnmanagedCallersOnlyCaller::InvokeThrowing`. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

AaronRobinsonMSFT · 2026-02-24T23:49:47Z

Summary

Replace MethodDescCallSite/CallDescrWorker calls with more efficient UnmanagedCallersOnly reverse P/Invoke calls in exception handling code paths (priority 2 from #123864).

Changes

Convert the following call sites in excep.cpp to use UnmanagedCallersOnlyCaller:

GetExceptionMessage: Object.ToString via UCO (METHOD__RUNTIMEHELPERS__CALL_TO_STRING)
ExceptionPreserveStackTrace: InternalPreserveStackTrace via UCO
WrapNonCompliantException: RuntimeWrappedException construction via UCO
CreateTypeInitializationExceptionObject: TypeInitializationException construction via UCO
GetResourceStringFromManaged: Environment.GetResourceStringLocal via UCO
GetEventArgsForNotification: FirstChanceExceptionEventArgs construction via UCO

Pattern

Each conversion follows the established pattern:

Add [UnmanagedCallersOnly] static wrapper in managed code with Exception* out-parameter
Add corresponding metasig in metasig.h and DEFINE_METHOD in corelib.h
Replace MethodDescCallSite + ARG_SLOT with UnmanagedCallersOnlyCaller::InvokeThrowing
Remove now-unused DEFINE_METHOD entries for old constructors

All GC references passed to InvokeThrowing are in GCPROTECT'd locations.

…sOnly Replace MethodDescCallSite/CallDescrWorker calls with more efficient UnmanagedCallersOnly reverse P/Invoke calls in exception handling code paths (priority 2 from dotnet#123864): - GetExceptionMessage: Object.ToString via UCO - ExceptionPreserveStackTrace: InternalPreserveStackTrace via UCO - WrapNonCompliantException: RuntimeWrappedException ctor via UCO - CreateTypeInitializationExceptionObject: TypeInitializationException via UCO - GetResourceStringFromManaged: Environment.GetResourceStringLocal via UCO - GetEventArgsForNotification: FirstChanceExceptionEventArgs ctor via UCO Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This pull request converts six exception-related MethodDescCallSite call sites in excep.cpp to use the more efficient UnmanagedCallersOnly reverse P/Invoke pattern, following the established approach from priority 1 and 2 tasks in issue #123864.

Changes:

Replaces MethodDescCallSite/CallDescrWorker with UnmanagedCallersOnlyCaller::InvokeThrowing for six exception-handling methods
Adds six new UnmanagedCallersOnly wrapper methods in managed code (Object.CoreCLR.cs, Exception.CoreCLR.cs, Environment.CoreCLR.cs)
Updates metasig.h with six new method signatures and corelib.h with updated DEFINE_METHOD entries, removing obsolete constructor definitions

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/metasig.h	Adds 6 new metasig definitions for UnmanagedCallersOnly wrappers (PtrObj_PtrStr, PtrObj_PtrObj, PtrStr_PtrStr, PtrException_PtrException, PtrChar_PtrException_PtrObj, PtrException_PtrObj, all with PtrException_RetVoid suffix)
src/coreclr/vm/corelib.h	Updates DEFINE_METHOD entries for the 6 converted methods and removes 3 obsolete constructor entries (TYPE_INIT_EXCEPTION.STR_EX_CTOR, RUNTIME_WRAPPED_EXCEPTION.OBJ_CTOR, FIRSTCHANCE_EVENTARGS.CTOR)
src/coreclr/vm/excep.cpp	Converts 6 call sites to use UnmanagedCallersOnlyCaller: GetExceptionMessage, ExceptionPreserveStackTrace, WrapNonCompliantException, CreateTypeInitializationExceptionObject, GetResourceStringFromManaged, GetEventArgsForNotification
src/coreclr/System.Private.CoreLib/src/System/Object.CoreCLR.cs	Adds GetToString UnmanagedCallersOnly wrapper with Exception* out-parameter
src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs	Adds 4 UnmanagedCallersOnly wrappers: InternalPreserveStackTrace, CreateRuntimeWrappedException, CreateTypeInitializationException, CreateFirstChanceExceptionEventArgs
src/coreclr/System.Private.CoreLib/src/System/Environment.CoreCLR.cs	Converts GetResourceStringLocal to UnmanagedCallersOnly pattern with string* in/out parameters

- Move GetToString from System.Object to System.Exception to avoid breaking reflection in user code - Clean up stale comment about SystemException fallback in CreateTypeInitializationExceptionObject - Rename GetResourceStringLocal to GetResourceString, drop Local suffix - Delete unused DEFINE_CLASS(FIRSTCHANCE_EVENTARGS) from corelib.h - Fold GetResourceStringFromManaged into its single caller ResMgrGetString, pass key as char* and move string creation to managed side - Add GCPROTECT around ResMgrGetString caller in clrex.cpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…o single UCO call Combine event args construction and delegate invocation into a single managed DeliverFirstChanceNotification UCO method. Multicast delegate iteration is now handled by managed Delegate.Invoke. Remove the native DeliverExceptionNotification and GetEventArgsForNotification methods. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

AaronRobinsonMSFT · 2026-02-25T23:34:52Z

@EgorBot -linux_amd -osx_arm64

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;usingSystem;BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);publicclassBench{privateException_cachedException=newInvalidOperationException("test");[Benchmark]publicvoidThrowCatch_NoHandler(){try{throw_cachedException;}catch{}}[Benchmark]publicvoidThrowCatch_WithHandler(){AppDomain.CurrentDomain.FirstChanceException+=Handler;try{throw_cachedException;}catch{}finally{AppDomain.CurrentDomain.FirstChanceException-=Handler;}}privatestaticvoidHandler(object?sender,System.Runtime.ExceptionServices.FirstChanceExceptionEventArgse){}}

…dd OnFirstChanceException method

Replace the CanDeliverNotificationToCurrentAppDomain check, which read the managed FirstChanceException delegate field via CoreLibBinder in cooperative GC mode, with a native Volatile<BOOL> flag set via a SuppressGCTransition QCall when a handler is first registered. This avoids the GCX_COOP transition in DeliverFirstChanceNotification on every exception throw when no handler is registered. The flag is sticky: once set to TRUE it is never cleared, avoiding race conditions between concurrent add/remove operations. - Remove CanDeliverNotificationToCurrentAppDomain and FIELD__APPCONTEXT__FIRST_CHANCE_EXCEPTION - Add AppDomain_SetFirstChanceExceptionHandler QCall (SuppressGCTransition) - Move GCX_COOP inside the handler check in DeliverFirstChanceNotification Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

jkotas

Thanks!

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

…124854) First set of priority 3 conversions from #123864 — replace `MethodDescCallSite`/`CallDescrWorker` calls with `UnmanagedCallersOnly` reverse P/Invoke calls. ## Converted call sites | File | Call site | Method | |------|-----------|--------| | `appdomain.cpp` | `AppDomain::RaiseExitProcessEvent` | `ON_PROCESS_EXIT` | | `appdomain.cpp` | `AppDomain::OnUnhandledException` | `ON_UNHANDLED_EXCEPTION` | | `assembly.cpp` | `RunManagedStartup` | `MANAGED_STARTUP` | | `assembly.cpp` | `RunMainInternal` (TARGET_BROWSER) | `HANDLE_ASYNC_ENTRYPOINT` | | `invokeutil.cpp` | `InvokeUtil::CreateClassLoadExcept` | `ReflectionTypeLoadException` ctor | | `invokeutil.cpp` | `InvokeUtil::CreateTargetExcept` | `TargetInvocationException` ctor | ## Remaining priority 3 items (follow ups) - Main entry point in `RunMainInternal` (dynamic MethodDesc) - `CustomAttribute_CreateCustomAttributeInstance` (dynamic ctor, already a QCall) - `CorHost2::ExecuteAssembly` (dynamic method lookup) - `FuncEvalWrapper`/`DoNormalFuncEval` (debugger func-eval) ## Pattern Follows the same conversion pattern as #124834 (priority 2). Each conversion adds an `[UnmanagedCallersOnly]` managed wrapper with an `Exception*` out-parameter and replaces the native `MethodDescCallSite` + `ARG_SLOT` with `UnmanagedCallersOnlyCaller::InvokeThrowing`. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

CopilotAI review requested due to automatic review settings February 24, 2026 23:49

github-actionsBot added the area-VM-coreclr label Feb 24, 2026

dotnet-policy-serviceBot assigned AaronRobinsonMSFT Feb 24, 2026

github-project-automationBot added this to AppModel Feb 24, 2026

Copilotstarted reviewing on behalf of AaronRobinsonMSFT February 24, 2026 23:50 View session

CopilotAI reviewed Feb 24, 2026
View reviewed changes

jkotas reviewed Feb 25, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Object.CoreCLR.cs Outdated

jkotas reviewed Feb 25, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/excep.cpp Outdated

jkotas reviewed Feb 25, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/excep.cpp Outdated

jkotas reviewed Feb 25, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Environment.CoreCLR.cs Outdated

jkotas reviewed Feb 25, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/corelib.h Outdated

build-analysisBot mentioned this pull request Feb 25, 2026
[android][clr] No peer certificates when executing System.Net.Http.Functional.Tests on Android emulator #124526
Closed

steveisok mentioned this pull request Feb 25, 2026
Convert priority 3 MethodDescCallSite calls to UnmanagedCallersOnly #124854
Merged

jkotas reviewed Feb 25, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/excep.cpp Outdated

AaronRobinsonMSFTand others added 3 commits February 25, 2026 10:43

Merge remote-tracking branch 'upstream/main' into uco-excep-priority2
217a124

jkotas reviewed Feb 25, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/excep.cpp Outdated
Comment threadsrc/coreclr/vm/excep.cpp Outdated
Comment threadsrc/coreclr/vm/excep.cpp Outdated
Comment threadsrc/coreclr/vm/excep.cpp Outdated
Comment threadsrc/coreclr/vm/excep.cpp Outdated

EgorBot mentioned this pull request Feb 25, 2026
Benchmarks for dotnet/runtime#124834 (for @AaronRobinsonMSFT) EgorBot/Benchmarks#7
Open

AaronRobinsonMSFTand others added 2 commits February 25, 2026 16:47

Refactor exception handling: remove DeliverFirstChanceNotification, a…
da0c8fb
…dd OnFirstChanceException method

CopilotAI review requested due to automatic review settings February 26, 2026 02:00

Copilotstarted reviewing on behalf of AaronRobinsonMSFT February 26, 2026 02:01 View session

CopilotAI reviewed Feb 26, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/excep.cpp
Comment threadsrc/libraries/System.Private.CoreLib/src/System/AppContext.cs Outdated
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/AppContext.cs Outdated

AaronRobinsonMSFT mentioned this pull request Feb 26, 2026
Replace CallDescrWorker with UnmanagedCallersOnlyAttribute pattern #123864
Open
72 tasks

jkotas reviewed Feb 26, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/excep.cpp Outdated

jkotas reviewed Feb 26, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/excep.cpp Outdated

jkotas reviewed Feb 27, 2026
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/AppContext.cs Outdated

Refactor OnFirstChanceException method for native AOT compatibility
54474b8

CopilotAI review requested due to automatic review settings February 27, 2026 01:14

Copilotstarted reviewing on behalf of AaronRobinsonMSFT February 27, 2026 01:15 View session

CopilotAI reviewed Feb 27, 2026
View reviewed changes

jkotas approved these changes Feb 27, 2026
View reviewed changes

Merge branch 'main' into uco-excep-priority2
147b0ba

This was referenced Feb 27, 2026
Test failure: baseservices/exceptions/stackoverflow/stackoverflowtester/stackoverflowtester.cmd #110173
Open
Unable to pull image from mcr.microsoft.com #117164
Closed

Merge branch 'main' into uco-excep-priority2
0c3fd2b

CopilotAI review requested due to automatic review settings February 27, 2026 18:47

Copilotstarted reviewing on behalf of AaronRobinsonMSFT February 27, 2026 18:48 View session

CopilotAI reviewed Feb 27, 2026
View reviewed changes

This was referenced Feb 27, 2026
ProcessThreadTests.TestStartTimeProperty failure in CI #105526
Closed
[browser] Wasm.Build.Tests timeout - Timed out after 10s waiting for 'WASM EXIT' #116697
Open

AaronRobinsonMSFT added 2 commits March 1, 2026 16:39

Merge branch 'main' into uco-excep-priority2
7428a09

Merge branch 'main' into uco-excep-priority2
aac1485

CopilotAI review requested due to automatic review settings March 2, 2026 04:46

Copilotstarted reviewing on behalf of AaronRobinsonMSFT March 2, 2026 04:47 View session

CopilotAI reviewed Mar 2, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/excep.cpp

AaronRobinsonMSFT merged commit 77f0e35 into dotnet:mainMar 2, 2026
163 of 168 checks passed

AaronRobinsonMSFT deleted the uco-excep-priority2 branch March 2, 2026 16:30

github-project-automationBot moved this to Done in AppModel Mar 2, 2026

dotnet-maestroBot mentioned this pull request Mar 3, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5186
Merged

github-actionsBot locked and limited conversation to collaborators Apr 2, 2026