[wasm][coreclr] Improve method portable entrypoints lifecycle by radekdoulik · Pull Request #124868 · dotnet/runtime

radekdoulik · 2026-02-25T19:05:39Z

Reset the portable entrypoint in places where we clear the interpreter code pointer. To avoid having stale portable entrypoint set to a method without interpreter code pointer.
Re-enable running of finalizers

This was happening when dynamic method was finalized and added back to free list. Later when Reset() was called on that method, the portable entrypoint had still data from previous cycle, with dangling pointer to the interpreter code.

I also added call to reset portable entry point in other places, where we clear the interpreter code pointer to avoid similar issues.

Fixes#123712

Reset the portable entrypoint in places where we clear the interpreter code pointer Re-enable running of finalizers Re-enable access checks in the interpreter compiler This fixesdotnet#123712 and possibly dotnet#121955

dotnet-policy-service · 2026-02-25T19:06:25Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

radekdoulik · 2026-02-25T19:07:50Z

The library test I was using to reproduce locally was running fine with re-enabled access checks. Let see whether it will survive CI as well.

Copilot

Pull request overview

This pull request fixes memory corruption issues in the WASM CoreCLR build by properly managing the portable entrypoint lifecycle. When interpreter code pointers are cleared (e.g., during dynamic method finalization), the portable entrypoint structure can retain stale data with dangling pointers. The fix introduces a ResetPortableEntryPoint() method that clears the portable entrypoint whenever interpreter code is cleared, preventing memory corruption.

Changes:

Added ResetPortableEntryPoint() method to reset portable entrypoints alongside interpreter code clearing
Re-enabled finalizers for browser/WASM builds (previously disabled due to #123712)
Re-enabled access checks in the interpreter compiler (previously disabled due to #121955)

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/coreclr/vm/method.hpp	Adds declaration for new `ResetPortableEntryPoint()` method
src/coreclr/vm/method.cpp	Implements `ResetPortableEntryPoint()` and calls it in `Reset()`, `ResetCodeEntryPoint()`, and `ResetCodeEntryPointForEnC()` wherever interpreter code is cleared
src/coreclr/vm/codeversion.cpp	Calls `ResetPortableEntryPoint()` in `PublishNativeCodeVersion()` when clearing interpreter code
src/coreclr/vm/finalizerthread.cpp	Re-enables finalizer execution for browser/WASM (was disabled as workaround for #123712)
src/coreclr/interpreter/compiler.cpp	Re-enables access checks in interpreter compiler (was disabled as workaround for #121955)

radekdoulik · 2026-02-25T21:03:22Z

OK, no free lunch :-)

[20:11:21] info: System.MethodAccessException : Attempt by method 'System.Runtime.InteropServices.JavaScript.JSMarshalerArgument.ToJS(System.Threading.Tasks.Task`1<!!0>, ArgumentToJSCallback`1<!!0>)' to access method 'System.Delegate.DelegateConstruct(System.Object, IntPtr)' failed.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Aaron R Robinson <arobins@microsoft.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

[wasm][coreclr] Fix method portable entrypoints lifecycle
02065c6
Reset the portable entrypoint in places where we clear the interpreter code pointer Re-enable running of finalizers Re-enable access checks in the interpreter compiler This fixesdotnet#123712 and possibly dotnet#121955

radekdoulik added this to the Future milestone Feb 25, 2026

CopilotAI review requested due to automatic review settings February 25, 2026 19:05

radekdoulik added arch-wasm WebAssembly architecture area-VM-coreclr labels Feb 25, 2026

dotnet-policy-serviceBot assigned radekdoulik Feb 25, 2026

radekdoulik requested review from AaronRobinsonMSFT and jkotas February 25, 2026 19:06

Copilotstarted reviewing on behalf of radekdoulik February 25, 2026 19:06 View session

CopilotAI reviewed Feb 25, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/method.cpp Outdated

AaronRobinsonMSFT reviewed Feb 25, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/method.cpp Outdated

radekdoulikand others added 2 commits February 25, 2026 22:04

Disable access checks again
d908053

Apply suggestions from code review
a3c7ac1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Aaron R Robinson <arobins@microsoft.com>

CopilotAI review requested due to automatic review settings February 25, 2026 21:05

Copilotstarted reviewing on behalf of radekdoulik February 25, 2026 21:06 View session

CopilotAI reviewed Feb 25, 2026
View reviewed changes

radekdoulik mentioned this pull request Feb 25, 2026
[wasm][coreclr] Fix prestub of methods with IL helper stubs #124873
Merged

radekdoulik requested a review from AaronRobinsonMSFT February 26, 2026 15:11

radekdoulik marked this pull request as ready for review February 27, 2026 08:16

Merge branch 'main' into clr-wasm-reset-portable-entrypoint
8a7c025

build-analysisBot mentioned this pull request Feb 27, 2026
"We stopped hearing from agent Azure Pipelines 32. Verify the agent machine is running and has a healthy network connection" dotnet/dnceng#1886
Open
3 tasks

AaronRobinsonMSFT reviewed Feb 27, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/method.cpp Outdated

Feedback
191e0f4

CopilotAI review requested due to automatic review settings March 2, 2026 11:32

Merge branch 'main' into clr-wasm-reset-portable-entrypoint
b8aba7a

Copilotstarted reviewing on behalf of radekdoulik March 2, 2026 11:33 View session

CopilotAI reviewed Mar 2, 2026
View reviewed changes

jkotas reviewed Mar 2, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/method.cpp Outdated

Feedback
729e786

jkotas reviewed Mar 2, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/method.cpp Outdated

jkotas approved these changes Mar 2, 2026
View reviewed changes

build-analysisBot mentioned this pull request Mar 2, 2026
System.Diagnostics.Process.Tests failure on net10.0-linux-Debug-arm64-Mono_Minijit_Debug #110643
Open

Remove comment
aa65d74
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

CopilotAI review requested due to automatic review settings March 3, 2026 08:19

Copilotstarted reviewing on behalf of radekdoulik March 3, 2026 08:20 View session

CopilotAI reviewed Mar 3, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/finalizerthread.cpp
Comment threadsrc/coreclr/vm/codeversion.cpp

radekdoulik merged commit a964328 into dotnet:mainMar 3, 2026
107 of 109 checks passed

dotnet-maestroBot mentioned this pull request Mar 4, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5186
Merged

pavelsavara mentioned this pull request Mar 13, 2026
[browser][coreclr] run finalizers on browser timer #114096
Closed

github-actionsBot locked and limited conversation to collaborators Apr 3, 2026

Navigation Menu

Uh oh!

[wasm][coreclr] Improve method portable entrypoints lifecycle - #124868

[wasm][coreclr] Improve method portable entrypoints lifecycle#124868
radekdoulik merged 8 commits into
dotnet:mainfrom
radekdoulik:clr-wasm-reset-portable-entrypoint

radekdoulik commented Feb 25, 2026•
edited
Loading

Uh oh!

dotnet-policy-serviceBot commented Feb 25, 2026

Uh oh!

radekdoulik commented Feb 25, 2026

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

Uh oh!

radekdoulik commented Feb 25, 2026

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

radekdoulik commented Feb 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Feb 25, 2026

Uh oh!

radekdoulik commented Feb 25, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

radekdoulik commented Feb 25, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

radekdoulik commented Feb 25, 2026•
edited
Loading