[RyuJit] Add `VisitOperandUses` by SingleAccretion · Pull Request #125073 · dotnet/runtime

SingleAccretion · 2026-03-02T20:27:41Z

For an upcoming WASM stackifier change, we'll need the ability to enumerate operand uses in their proper order. This change adds the necessary function.

dotnet-policy-service · 2026-03-02T20:29:01Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

SingleAccretion · 2026-03-03T12:19:58Z

@dotnet/jit-contrib

There is a bit of a TP diff, hopefully it'll smooth itself out through PGO (naturally this kind of change relies on inlining to clean up the added indirection in VisitOperands).

AndyAyersMS · 2026-03-03T20:30:25Z

There is a bit of a TP diff, hopefully it'll smooth itself out through PGO (naturally this kind of change relies on inlining to clean up the added indirection in VisitOperands).

Mostly looks a bit faster, certainly nothing to worry about.

To do this we need to maintain some more state, so convert the stackifier into a full walk over all blocks so that we can encapsulate this state better. Depends on #125073.

SingleAccretion · 2026-03-02T20:27:41Z

For an upcoming WASM stackifier change, we'll need the ability to enumerate operand uses in their proper order. This change adds the necessary function.

dotnet-policy-service · 2026-03-02T20:29:01Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

SingleAccretion · 2026-03-03T12:19:58Z

@dotnet/jit-contrib

There is a bit of a TP diff, hopefully it'll smooth itself out through PGO (naturally this kind of change relies on inlining to clean up the added indirection in VisitOperands).

AndyAyersMS · 2026-03-03T20:30:25Z

There is a bit of a TP diff, hopefully it'll smooth itself out through PGO (naturally this kind of change relies on inlining to clean up the added indirection in VisitOperands).

Mostly looks a bit faster, certainly nothing to worry about.

To do this we need to maintain some more state, so convert the stackifier into a full walk over all blocks so that we can encapsulate this state better. Depends on #125073.

SingleAccretion · 2026-03-02T20:27:41Z

For an upcoming WASM stackifier change, we'll need the ability to enumerate operand uses in their proper order. This change adds the necessary function.

dotnet-policy-service · 2026-03-02T20:29:01Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

SingleAccretion · 2026-03-03T12:19:58Z

@dotnet/jit-contrib

There is a bit of a TP diff, hopefully it'll smooth itself out through PGO (naturally this kind of change relies on inlining to clean up the added indirection in VisitOperands).

AndyAyersMS · 2026-03-03T20:30:25Z

There is a bit of a TP diff, hopefully it'll smooth itself out through PGO (naturally this kind of change relies on inlining to clean up the added indirection in VisitOperands).

Mostly looks a bit faster, certainly nothing to worry about.

To do this we need to maintain some more state, so convert the stackifier into a full walk over all blocks so that we can encapsulate this state better. Depends on #125073.

SingleAccretion · 2026-03-02T20:27:41Z

For an upcoming WASM stackifier change, we'll need the ability to enumerate operand uses in their proper order. This change adds the necessary function.

dotnet-policy-service · 2026-03-02T20:29:01Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

SingleAccretion · 2026-03-03T12:19:58Z

@dotnet/jit-contrib

There is a bit of a TP diff, hopefully it'll smooth itself out through PGO (naturally this kind of change relies on inlining to clean up the added indirection in VisitOperands).

AndyAyersMS · 2026-03-03T20:30:25Z

There is a bit of a TP diff, hopefully it'll smooth itself out through PGO (naturally this kind of change relies on inlining to clean up the added indirection in VisitOperands).

Mostly looks a bit faster, certainly nothing to worry about.

To do this we need to maintain some more state, so convert the stackifier into a full walk over all blocks so that we can encapsulate this state better. Depends on #125073.

SingleAccretion · 2026-03-02T20:27:41Z

For an upcoming WASM stackifier change, we'll need the ability to enumerate operand uses in their proper order. This change adds the necessary function.

dotnet-policy-service · 2026-03-02T20:29:01Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

SingleAccretion · 2026-03-03T12:19:58Z

@dotnet/jit-contrib

There is a bit of a TP diff, hopefully it'll smooth itself out through PGO (naturally this kind of change relies on inlining to clean up the added indirection in VisitOperands).

AndyAyersMS · 2026-03-03T20:30:25Z

There is a bit of a TP diff, hopefully it'll smooth itself out through PGO (naturally this kind of change relies on inlining to clean up the added indirection in VisitOperands).

Mostly looks a bit faster, certainly nothing to worry about.

To do this we need to maintain some more state, so convert the stackifier into a full walk over all blocks so that we can encapsulate this state better. Depends on #125073.

SingleAccretion · 2026-03-02T20:27:41Z

For an upcoming WASM stackifier change, we'll need the ability to enumerate operand uses in their proper order. This change adds the necessary function.

dotnet-policy-service · 2026-03-02T20:29:01Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

SingleAccretion · 2026-03-03T12:19:58Z

@dotnet/jit-contrib

There is a bit of a TP diff, hopefully it'll smooth itself out through PGO (naturally this kind of change relies on inlining to clean up the added indirection in VisitOperands).

AndyAyersMS · 2026-03-03T20:30:25Z

There is a bit of a TP diff, hopefully it'll smooth itself out through PGO (naturally this kind of change relies on inlining to clean up the added indirection in VisitOperands).

Mostly looks a bit faster, certainly nothing to worry about.

To do this we need to maintain some more state, so convert the stackifier into a full walk over all blocks so that we can encapsulate this state better. Depends on #125073.

SingleAccretion · 2026-03-02T20:27:41Z

For an upcoming WASM stackifier change, we'll need the ability to enumerate operand uses in their proper order. This change adds the necessary function.

dotnet-policy-service · 2026-03-02T20:29:01Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

SingleAccretion · 2026-03-03T12:19:58Z

@dotnet/jit-contrib

There is a bit of a TP diff, hopefully it'll smooth itself out through PGO (naturally this kind of change relies on inlining to clean up the added indirection in VisitOperands).

AndyAyersMS · 2026-03-03T20:30:25Z

There is a bit of a TP diff, hopefully it'll smooth itself out through PGO (naturally this kind of change relies on inlining to clean up the added indirection in VisitOperands).

Mostly looks a bit faster, certainly nothing to worry about.

To do this we need to maintain some more state, so convert the stackifier into a full walk over all blocks so that we can encapsulate this state better. Depends on #125073.

SingleAccretion · 2026-03-02T20:27:41Z

For an upcoming WASM stackifier change, we'll need the ability to enumerate operand uses in their proper order. This change adds the necessary function.

dotnet-policy-service · 2026-03-02T20:29:01Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

SingleAccretion · 2026-03-03T12:19:58Z

@dotnet/jit-contrib

There is a bit of a TP diff, hopefully it'll smooth itself out through PGO (naturally this kind of change relies on inlining to clean up the added indirection in VisitOperands).

AndyAyersMS · 2026-03-03T20:30:25Z

There is a bit of a TP diff, hopefully it'll smooth itself out through PGO (naturally this kind of change relies on inlining to clean up the added indirection in VisitOperands).

Mostly looks a bit faster, certainly nothing to worry about.

To do this we need to maintain some more state, so convert the stackifier into a full walk over all blocks so that we can encapsulate this state better. Depends on #125073.

VisitUses
1243b79

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Mar 2, 2026

github-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 2, 2026

build-analysisBot mentioned this pull request Mar 3, 2026
[android][clr] No peer certificates when executing System.Net.Http.Functional.Tests on Android emulator #124526
Closed

SingleAccretion marked this pull request as ready for review March 3, 2026 12:18

SingleAccretion mentioned this pull request Mar 3, 2026
[RyuJit/WASW] Insert temporaries when needed in the stackifier #125146
Merged

AndyAyersMS approved these changes Mar 3, 2026
View reviewed changes

AndyAyersMS merged commit 4172d0e into dotnet:mainMar 3, 2026
130 of 133 checks passed

dotnet-maestroBot mentioned this pull request Mar 4, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5186
Merged

SingleAccretion deleted the VisitUses branch March 10, 2026 19:48

github-actionsBot locked and limited conversation to collaborators Apr 10, 2026