Uh oh!
There was an error while loading. Please reload this page.
Re-enable generator tests on big endian architectures - #125228
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the big-endian test suppression so source generation tests run again on big-endian architectures.
Changes:
- Removed the
[ActiveIssue(..., nameof(IsBigEndian))]skip that disabled tests on big-endian. - Deleted the
IsBigEndianhelper and its associated comment.
jkotas
commented
Mar 5, 2026
Member
cc @uweigand |
Contributor
Tagging subscribers to this area: @dotnet/area-extensions-configuration |
This was referenced Mar 5, 2026
Open
cincuranet
approved these changes
Mar 17, 2026
rosebyte
approved these changes
Mar 17, 2026
svick
commented
Mar 17, 2026
MemberAuthor
I am going to merge this now, even though this PR was not tested on a big-endian machine. If it turns out it's still an issue, we can revert it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Roslyn issue dotnet/roslyn#74682 was fixed, so the tests should now pass on big endian architectures.
This reverts #105485.
Resolves#105311.