Fix some CMake definitions on OpenBSD

[sethjackson]

• Need sys/types.h for HAVE_STATFS_FSTYPENAME. See https://man.openbsd.org/statfs (missed a couple of places in Fix pal_io.c on OpenBSD #124992).
• Need sys/types.h for HAVE_MNTINFO. See: https://man.openbsd.org/getmntinfo
• Need sys/types.h and sys/socket.h for HAVE_GETPEEREID. See: https://man.openbsd.org/getpeereid

Contributes to #124911.

[sethjackson]

@jkotas@am11 would someone be able to take a look at this one?

[am11]

LGTM.

Corehost is building with #125557.

Reminder: your best bet is to start porting libunwind. For Solaris/illumos, haiku, QNX and linux-riscv64/loongarch64, that's the first thing we ported before working on runtime side. Back then, we had lot more dependency on libunwind than these days (six calls left..) but it's still an (annoyingly) important dependency to port which needs to be working on platform. It's usually missed on platforms because other software rely on their own unwinder or something out of the target OS. In this case, we need either HP libunwind (https://github.com/libunwind/libunwind <- preferred) or llvm-libunwind (https://github.com/llvm/llvm-project and look for libunwind dir at root of that repo).

[sethjackson]

LGTM.

Corehost is building with #125557.

Reminder: your best bet is to start porting libunwind. For Solaris/illumos, haiku, QNX and linux-riscv64/loongarch64, that's the first thing we ported before working on runtime side. Back then, we had lot more dependency on libunwind than these days (six calls left..) but it's still an (annoyingly) important dependency to port which needs to be working on platform. It's usually missed on platforms because other software rely on their own unwinder or something out of the target OS. In this case, we need either HP libunwind (https://github.com/libunwind/libunwind <- preferred) or llvm-libunwind (https://github.com/llvm/llvm-project and look for libunwind dir at root of that repo).

Got it. I am wondering if the system unwind will work though on OpenBSD? llvm-unwind appears to be in tree:
https://github.com/openbsd/src/tree/master/gnu/llvm/libunwind

I know you had mentioned previously about a missing function (I'll have to dig through the previous PRs laters as I have forgotten the exact function) but IIRC I did find it in here somewhere:
https://github.com/openbsd/src/tree/master/gnu/llvm/libunwind/include

But maybe I misunderstood?

[am11]

Good, that would work. The only missing piece which llvm-libunwind lacks is unw_get_save_loc. AFAIK, the only difference unw_get_save_loc (available in HP libunwind, but not yet implemented on LLVM libunwind) makes is that GC pins the objects longer in its absence. It can work. I will try to install it in crossroot and wire it up.

[jkotas]

/ba-g unrelated timeouts

[sethjackson]

• Need sys/types.h for HAVE_STATFS_FSTYPENAME. See https://man.openbsd.org/statfs (missed a couple of places in Fix pal_io.c on OpenBSD #124992).
• Need sys/types.h for HAVE_MNTINFO. See: https://man.openbsd.org/getmntinfo
• Need sys/types.h and sys/socket.h for HAVE_GETPEEREID. See: https://man.openbsd.org/getpeereid

Contributes to #124911.

[sethjackson]

@jkotas@am11 would someone be able to take a look at this one?

[am11]

LGTM.

Corehost is building with #125557.

Reminder: your best bet is to start porting libunwind. For Solaris/illumos, haiku, QNX and linux-riscv64/loongarch64, that's the first thing we ported before working on runtime side. Back then, we had lot more dependency on libunwind than these days (six calls left..) but it's still an (annoyingly) important dependency to port which needs to be working on platform. It's usually missed on platforms because other software rely on their own unwinder or something out of the target OS. In this case, we need either HP libunwind (https://github.com/libunwind/libunwind <- preferred) or llvm-libunwind (https://github.com/llvm/llvm-project and look for libunwind dir at root of that repo).

[sethjackson]

LGTM.

Corehost is building with #125557.

Reminder: your best bet is to start porting libunwind. For Solaris/illumos, haiku, QNX and linux-riscv64/loongarch64, that's the first thing we ported before working on runtime side. Back then, we had lot more dependency on libunwind than these days (six calls left..) but it's still an (annoyingly) important dependency to port which needs to be working on platform. It's usually missed on platforms because other software rely on their own unwinder or something out of the target OS. In this case, we need either HP libunwind (https://github.com/libunwind/libunwind <- preferred) or llvm-libunwind (https://github.com/llvm/llvm-project and look for libunwind dir at root of that repo).

Got it. I am wondering if the system unwind will work though on OpenBSD? llvm-unwind appears to be in tree:
https://github.com/openbsd/src/tree/master/gnu/llvm/libunwind

I know you had mentioned previously about a missing function (I'll have to dig through the previous PRs laters as I have forgotten the exact function) but IIRC I did find it in here somewhere:
https://github.com/openbsd/src/tree/master/gnu/llvm/libunwind/include

But maybe I misunderstood?

[am11]

Good, that would work. The only missing piece which llvm-libunwind lacks is unw_get_save_loc. AFAIK, the only difference unw_get_save_loc (available in HP libunwind, but not yet implemented on LLVM libunwind) makes is that GC pins the objects longer in its absence. It can work. I will try to install it in crossroot and wire it up.

[jkotas]

/ba-g unrelated timeouts

[sethjackson]

• Need sys/types.h for HAVE_STATFS_FSTYPENAME. See https://man.openbsd.org/statfs (missed a couple of places in Fix pal_io.c on OpenBSD #124992).
• Need sys/types.h for HAVE_MNTINFO. See: https://man.openbsd.org/getmntinfo
• Need sys/types.h and sys/socket.h for HAVE_GETPEEREID. See: https://man.openbsd.org/getpeereid

Contributes to #124911.

[sethjackson]

@jkotas@am11 would someone be able to take a look at this one?

[am11]

LGTM.

Corehost is building with #125557.

Reminder: your best bet is to start porting libunwind. For Solaris/illumos, haiku, QNX and linux-riscv64/loongarch64, that's the first thing we ported before working on runtime side. Back then, we had lot more dependency on libunwind than these days (six calls left..) but it's still an (annoyingly) important dependency to port which needs to be working on platform. It's usually missed on platforms because other software rely on their own unwinder or something out of the target OS. In this case, we need either HP libunwind (https://github.com/libunwind/libunwind <- preferred) or llvm-libunwind (https://github.com/llvm/llvm-project and look for libunwind dir at root of that repo).

[sethjackson]

LGTM.

Corehost is building with #125557.

Reminder: your best bet is to start porting libunwind. For Solaris/illumos, haiku, QNX and linux-riscv64/loongarch64, that's the first thing we ported before working on runtime side. Back then, we had lot more dependency on libunwind than these days (six calls left..) but it's still an (annoyingly) important dependency to port which needs to be working on platform. It's usually missed on platforms because other software rely on their own unwinder or something out of the target OS. In this case, we need either HP libunwind (https://github.com/libunwind/libunwind <- preferred) or llvm-libunwind (https://github.com/llvm/llvm-project and look for libunwind dir at root of that repo).

Got it. I am wondering if the system unwind will work though on OpenBSD? llvm-unwind appears to be in tree:
https://github.com/openbsd/src/tree/master/gnu/llvm/libunwind

I know you had mentioned previously about a missing function (I'll have to dig through the previous PRs laters as I have forgotten the exact function) but IIRC I did find it in here somewhere:
https://github.com/openbsd/src/tree/master/gnu/llvm/libunwind/include

But maybe I misunderstood?

[am11]

Good, that would work. The only missing piece which llvm-libunwind lacks is unw_get_save_loc. AFAIK, the only difference unw_get_save_loc (available in HP libunwind, but not yet implemented on LLVM libunwind) makes is that GC pins the objects longer in its absence. It can work. I will try to install it in crossroot and wire it up.

[jkotas]

/ba-g unrelated timeouts

[sethjackson]

• Need sys/types.h for HAVE_STATFS_FSTYPENAME. See https://man.openbsd.org/statfs (missed a couple of places in Fix pal_io.c on OpenBSD #124992).
• Need sys/types.h for HAVE_MNTINFO. See: https://man.openbsd.org/getmntinfo
• Need sys/types.h and sys/socket.h for HAVE_GETPEEREID. See: https://man.openbsd.org/getpeereid

Contributes to #124911.

[sethjackson]

@jkotas@am11 would someone be able to take a look at this one?

[am11]

LGTM.

Corehost is building with #125557.

Reminder: your best bet is to start porting libunwind. For Solaris/illumos, haiku, QNX and linux-riscv64/loongarch64, that's the first thing we ported before working on runtime side. Back then, we had lot more dependency on libunwind than these days (six calls left..) but it's still an (annoyingly) important dependency to port which needs to be working on platform. It's usually missed on platforms because other software rely on their own unwinder or something out of the target OS. In this case, we need either HP libunwind (https://github.com/libunwind/libunwind <- preferred) or llvm-libunwind (https://github.com/llvm/llvm-project and look for libunwind dir at root of that repo).

[sethjackson]

LGTM.

Corehost is building with #125557.

Reminder: your best bet is to start porting libunwind. For Solaris/illumos, haiku, QNX and linux-riscv64/loongarch64, that's the first thing we ported before working on runtime side. Back then, we had lot more dependency on libunwind than these days (six calls left..) but it's still an (annoyingly) important dependency to port which needs to be working on platform. It's usually missed on platforms because other software rely on their own unwinder or something out of the target OS. In this case, we need either HP libunwind (https://github.com/libunwind/libunwind <- preferred) or llvm-libunwind (https://github.com/llvm/llvm-project and look for libunwind dir at root of that repo).

Got it. I am wondering if the system unwind will work though on OpenBSD? llvm-unwind appears to be in tree:
https://github.com/openbsd/src/tree/master/gnu/llvm/libunwind

I know you had mentioned previously about a missing function (I'll have to dig through the previous PRs laters as I have forgotten the exact function) but IIRC I did find it in here somewhere:
https://github.com/openbsd/src/tree/master/gnu/llvm/libunwind/include

But maybe I misunderstood?

[am11]

Good, that would work. The only missing piece which llvm-libunwind lacks is unw_get_save_loc. AFAIK, the only difference unw_get_save_loc (available in HP libunwind, but not yet implemented on LLVM libunwind) makes is that GC pins the objects longer in its absence. It can work. I will try to install it in crossroot and wire it up.

[jkotas]

/ba-g unrelated timeouts

[sethjackson]

• Need sys/types.h for HAVE_STATFS_FSTYPENAME. See https://man.openbsd.org/statfs (missed a couple of places in Fix pal_io.c on OpenBSD #124992).
• Need sys/types.h for HAVE_MNTINFO. See: https://man.openbsd.org/getmntinfo
• Need sys/types.h and sys/socket.h for HAVE_GETPEEREID. See: https://man.openbsd.org/getpeereid

Contributes to #124911.

[sethjackson]

@jkotas@am11 would someone be able to take a look at this one?

[am11]

LGTM.

Corehost is building with #125557.

Reminder: your best bet is to start porting libunwind. For Solaris/illumos, haiku, QNX and linux-riscv64/loongarch64, that's the first thing we ported before working on runtime side. Back then, we had lot more dependency on libunwind than these days (six calls left..) but it's still an (annoyingly) important dependency to port which needs to be working on platform. It's usually missed on platforms because other software rely on their own unwinder or something out of the target OS. In this case, we need either HP libunwind (https://github.com/libunwind/libunwind <- preferred) or llvm-libunwind (https://github.com/llvm/llvm-project and look for libunwind dir at root of that repo).

[sethjackson]

LGTM.

Corehost is building with #125557.

Reminder: your best bet is to start porting libunwind. For Solaris/illumos, haiku, QNX and linux-riscv64/loongarch64, that's the first thing we ported before working on runtime side. Back then, we had lot more dependency on libunwind than these days (six calls left..) but it's still an (annoyingly) important dependency to port which needs to be working on platform. It's usually missed on platforms because other software rely on their own unwinder or something out of the target OS. In this case, we need either HP libunwind (https://github.com/libunwind/libunwind <- preferred) or llvm-libunwind (https://github.com/llvm/llvm-project and look for libunwind dir at root of that repo).

Got it. I am wondering if the system unwind will work though on OpenBSD? llvm-unwind appears to be in tree:
https://github.com/openbsd/src/tree/master/gnu/llvm/libunwind

I know you had mentioned previously about a missing function (I'll have to dig through the previous PRs laters as I have forgotten the exact function) but IIRC I did find it in here somewhere:
https://github.com/openbsd/src/tree/master/gnu/llvm/libunwind/include

But maybe I misunderstood?

[am11]

Good, that would work. The only missing piece which llvm-libunwind lacks is unw_get_save_loc. AFAIK, the only difference unw_get_save_loc (available in HP libunwind, but not yet implemented on LLVM libunwind) makes is that GC pins the objects longer in its absence. It can work. I will try to install it in crossroot and wire it up.

[jkotas]

/ba-g unrelated timeouts

[sethjackson]

• Need sys/types.h for HAVE_STATFS_FSTYPENAME. See https://man.openbsd.org/statfs (missed a couple of places in Fix pal_io.c on OpenBSD #124992).
• Need sys/types.h for HAVE_MNTINFO. See: https://man.openbsd.org/getmntinfo
• Need sys/types.h and sys/socket.h for HAVE_GETPEEREID. See: https://man.openbsd.org/getpeereid

Contributes to #124911.

[sethjackson]

@jkotas@am11 would someone be able to take a look at this one?

[am11]

LGTM.

Corehost is building with #125557.

Reminder: your best bet is to start porting libunwind. For Solaris/illumos, haiku, QNX and linux-riscv64/loongarch64, that's the first thing we ported before working on runtime side. Back then, we had lot more dependency on libunwind than these days (six calls left..) but it's still an (annoyingly) important dependency to port which needs to be working on platform. It's usually missed on platforms because other software rely on their own unwinder or something out of the target OS. In this case, we need either HP libunwind (https://github.com/libunwind/libunwind <- preferred) or llvm-libunwind (https://github.com/llvm/llvm-project and look for libunwind dir at root of that repo).

[sethjackson]

LGTM.

Corehost is building with #125557.

Reminder: your best bet is to start porting libunwind. For Solaris/illumos, haiku, QNX and linux-riscv64/loongarch64, that's the first thing we ported before working on runtime side. Back then, we had lot more dependency on libunwind than these days (six calls left..) but it's still an (annoyingly) important dependency to port which needs to be working on platform. It's usually missed on platforms because other software rely on their own unwinder or something out of the target OS. In this case, we need either HP libunwind (https://github.com/libunwind/libunwind <- preferred) or llvm-libunwind (https://github.com/llvm/llvm-project and look for libunwind dir at root of that repo).

Got it. I am wondering if the system unwind will work though on OpenBSD? llvm-unwind appears to be in tree:
https://github.com/openbsd/src/tree/master/gnu/llvm/libunwind

I know you had mentioned previously about a missing function (I'll have to dig through the previous PRs laters as I have forgotten the exact function) but IIRC I did find it in here somewhere:
https://github.com/openbsd/src/tree/master/gnu/llvm/libunwind/include

But maybe I misunderstood?

[am11]

Good, that would work. The only missing piece which llvm-libunwind lacks is unw_get_save_loc. AFAIK, the only difference unw_get_save_loc (available in HP libunwind, but not yet implemented on LLVM libunwind) makes is that GC pins the objects longer in its absence. It can work. I will try to install it in crossroot and wire it up.

[jkotas]

/ba-g unrelated timeouts

[sethjackson]

• Need sys/types.h for HAVE_STATFS_FSTYPENAME. See https://man.openbsd.org/statfs (missed a couple of places in Fix pal_io.c on OpenBSD #124992).
• Need sys/types.h for HAVE_MNTINFO. See: https://man.openbsd.org/getmntinfo
• Need sys/types.h and sys/socket.h for HAVE_GETPEEREID. See: https://man.openbsd.org/getpeereid

Contributes to #124911.

[sethjackson]

@jkotas@am11 would someone be able to take a look at this one?

[am11]

LGTM.

Corehost is building with #125557.

Reminder: your best bet is to start porting libunwind. For Solaris/illumos, haiku, QNX and linux-riscv64/loongarch64, that's the first thing we ported before working on runtime side. Back then, we had lot more dependency on libunwind than these days (six calls left..) but it's still an (annoyingly) important dependency to port which needs to be working on platform. It's usually missed on platforms because other software rely on their own unwinder or something out of the target OS. In this case, we need either HP libunwind (https://github.com/libunwind/libunwind <- preferred) or llvm-libunwind (https://github.com/llvm/llvm-project and look for libunwind dir at root of that repo).

[sethjackson]

LGTM.

Corehost is building with #125557.

Reminder: your best bet is to start porting libunwind. For Solaris/illumos, haiku, QNX and linux-riscv64/loongarch64, that's the first thing we ported before working on runtime side. Back then, we had lot more dependency on libunwind than these days (six calls left..) but it's still an (annoyingly) important dependency to port which needs to be working on platform. It's usually missed on platforms because other software rely on their own unwinder or something out of the target OS. In this case, we need either HP libunwind (https://github.com/libunwind/libunwind <- preferred) or llvm-libunwind (https://github.com/llvm/llvm-project and look for libunwind dir at root of that repo).

Got it. I am wondering if the system unwind will work though on OpenBSD? llvm-unwind appears to be in tree:
https://github.com/openbsd/src/tree/master/gnu/llvm/libunwind

I know you had mentioned previously about a missing function (I'll have to dig through the previous PRs laters as I have forgotten the exact function) but IIRC I did find it in here somewhere:
https://github.com/openbsd/src/tree/master/gnu/llvm/libunwind/include

But maybe I misunderstood?

[am11]

Good, that would work. The only missing piece which llvm-libunwind lacks is unw_get_save_loc. AFAIK, the only difference unw_get_save_loc (available in HP libunwind, but not yet implemented on LLVM libunwind) makes is that GC pins the objects longer in its absence. It can work. I will try to install it in crossroot and wire it up.

[jkotas]

/ba-g unrelated timeouts

[sethjackson]

• Need sys/types.h for HAVE_STATFS_FSTYPENAME. See https://man.openbsd.org/statfs (missed a couple of places in Fix pal_io.c on OpenBSD #124992).
• Need sys/types.h for HAVE_MNTINFO. See: https://man.openbsd.org/getmntinfo
• Need sys/types.h and sys/socket.h for HAVE_GETPEEREID. See: https://man.openbsd.org/getpeereid

Contributes to #124911.

[sethjackson]

@jkotas@am11 would someone be able to take a look at this one?

[am11]

LGTM.

Corehost is building with #125557.

Reminder: your best bet is to start porting libunwind. For Solaris/illumos, haiku, QNX and linux-riscv64/loongarch64, that's the first thing we ported before working on runtime side. Back then, we had lot more dependency on libunwind than these days (six calls left..) but it's still an (annoyingly) important dependency to port which needs to be working on platform. It's usually missed on platforms because other software rely on their own unwinder or something out of the target OS. In this case, we need either HP libunwind (https://github.com/libunwind/libunwind <- preferred) or llvm-libunwind (https://github.com/llvm/llvm-project and look for libunwind dir at root of that repo).

[sethjackson]

LGTM.

Corehost is building with #125557.

Reminder: your best bet is to start porting libunwind. For Solaris/illumos, haiku, QNX and linux-riscv64/loongarch64, that's the first thing we ported before working on runtime side. Back then, we had lot more dependency on libunwind than these days (six calls left..) but it's still an (annoyingly) important dependency to port which needs to be working on platform. It's usually missed on platforms because other software rely on their own unwinder or something out of the target OS. In this case, we need either HP libunwind (https://github.com/libunwind/libunwind <- preferred) or llvm-libunwind (https://github.com/llvm/llvm-project and look for libunwind dir at root of that repo).

Got it. I am wondering if the system unwind will work though on OpenBSD? llvm-unwind appears to be in tree:
https://github.com/openbsd/src/tree/master/gnu/llvm/libunwind

I know you had mentioned previously about a missing function (I'll have to dig through the previous PRs laters as I have forgotten the exact function) but IIRC I did find it in here somewhere:
https://github.com/openbsd/src/tree/master/gnu/llvm/libunwind/include

But maybe I misunderstood?

[am11]

Good, that would work. The only missing piece which llvm-libunwind lacks is unw_get_save_loc. AFAIK, the only difference unw_get_save_loc (available in HP libunwind, but not yet implemented on LLVM libunwind) makes is that GC pins the objects longer in its absence. It can work. I will try to install it in crossroot and wire it up.

[jkotas]

/ba-g unrelated timeouts