Uh oh!
There was an error while loading. Please reload this page.
Remove unnecessary RequiresProcessIsolation from 172 tests and update comments on 18 that need it - #125460
Merged
jkoritzinsky merged 3 commits intoMar 24, 2026
Merged
Conversation
…actual reasons For 172 tests that had the "mechanical merging" comment but no actual triggers requiring process isolation, remove both the comment and RequiresProcessIsolation property. For 18 tests that do need isolation, update the comment to explain the actual reason: - 7 tests: custom Main entry point (ReferenceXUnitWrapperGenerator=false) - 2 tests: NativeAotIncompatible - 3 tests: MonoAotIncompatible - 1 test: CMakeProjectReference and CopyToOutputDirectory - 5 tests: CLRTestTargetUnsupported (inherited from Directory.Build.props) Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>
jkoritzinsky
approved these changes
Mar 11, 2026
Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR audits CoreCLR test projects under src/tests/ that carried a generic “mechanical merging” comment for RequiresProcessIsolation, removing the property where it isn’t required and replacing the generic comment with a specific documented trigger where isolation is required.
Changes:
- Removed
RequiresProcessIsolation(and the obsolete generic comment) from test projects that have no documented project-file or source-code triggers. - Updated remaining
RequiresProcessIsolationcomments to state the concrete trigger (e.g.,CLRTestTargetUnsupported,MonoAotIncompatible,NativeAotIncompatible, customMain,CMakeProjectReference+CopyToOutputDirectory). - Cleaned up now-unneeded/empty
<PropertyGroup>blocks in affected project files.
Reviewed changes
Copilot reviewed 187 out of 190 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/reflection/regression/manyStackArgs/manyStackArgs.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/reflection/regression/hfa/hfaParam.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/reflection/regression/github_25697/25697.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/reflection/StaticInterfaceMembers/consumer.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/reflection/SetValue/TrySetReadonlyStaticField2.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/reflection/SetValue/TrySetReadonlyStaticField.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/reflection/RefEmit/EmittingIgnoresAccessChecksToAttributeIsRespected.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/reflection/Modifiers/modifiers.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/reflection/GenericAttribute/GenericAttributeTests.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/reflection/DefaultInterfaceMethods/InvokeConsumer.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/reflection/DefaultInterfaceMethods/GetInterfaceMapConsumer.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/reflection/DefaultInterfaceMethods/Emit.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/readytorun/tests/newarray.csproj | Updated RequiresProcessIsolation comment to specific trigger (CLRTestTargetUnsupported). |
| src/tests/readytorun/tests/genericsload/usegenericfield.csproj | Updated RequiresProcessIsolation comment to specific trigger (CLRTestTargetUnsupported). |
| src/tests/readytorun/tests/genericsload/callgenericctor.csproj | Updated RequiresProcessIsolation comment to specific trigger (CLRTestTargetUnsupported). |
| src/tests/readytorun/tests/generics.csproj | Updated RequiresProcessIsolation comment to specific trigger (CLRTestTargetUnsupported). |
| src/tests/readytorun/crossboundarylayout/crossboundarytest/crossboundarytest.csproj | Updated RequiresProcessIsolation comment to specific trigger (CLRTestTargetUnsupported). |
| src/tests/baseservices/typeequivalence/simple/Simple.csproj | Updated RequiresProcessIsolation comment to specific trigger (MonoAotIncompatible). |
| src/tests/baseservices/typeequivalence/istypeequivalent/istypeequivalent.csproj | Updated RequiresProcessIsolation comment to specific trigger (MonoAotIncompatible). |
| src/tests/baseservices/mono/runningmono.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/invalid_operations/InvalidOperations.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/finalization/Finalizer.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/TryCatchInFinally.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/ThrowInFinallyNestedInTry.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/ThrowInFinally.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/ThrowInCatch.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/StrSwitchFinally.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/ReturnFromCatch.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/RethrowAndFinally.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/RecursiveThrowNew.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/RecursiveRethrow.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/Recurse.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/Pending.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/InnerFinallyAndCatch.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/InnerFinally.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/GoryNativePast.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/GoryManagedPresent.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/EHPatternTests.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/CollidedUnwind.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/BaseClass.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unittests/Baadbaad.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/unhandled/unhandledTester.csproj | Updated RequiresProcessIsolation comment to specific triggers (CMakeProjectReference + CopyToOutputDirectory). |
| src/tests/baseservices/exceptions/simple/finally.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/simple/HardwareEh.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/simple/ArrayInit.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/sharedexceptions/emptystacktrace/OOMException01.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/regressions/whidbeym3.3/302680/302680.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/regressions/whidbeym3.3/106011/106011.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/regressions/whidbeybeta2/349379/349379.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/regressions/whidbeyM3.2/151232.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/regressions/v4.0/640474/test640474.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/regressions/v1.0/19896.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/regressions/V1/SEH/coverage/Exceptions.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/UserException.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/TryCatchFinally.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/TryCatch.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NormalException.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedEx2.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedEx1.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/regressions/V1/SEH/COOL/rethrow.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/regressions/V1/SEH/COOL/finally.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/StackTracePreserve/StackTracePreserveTests.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/AccessViolationException/AVException03.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/AccessViolationException/AVException02.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/exceptions/AccessViolationException/AVException01.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/compilerservices/modulector/runmoduleconstructor.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/compilerservices/dynamicobjectproperties/TestOverrides.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/compilerservices/dynamicobjectproperties/TestAPIs.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/compilerservices/UnsafeAccessors/UnsafeAccessorsTests.csproj | Updated RequiresProcessIsolation comment to specific trigger (MonoAotIncompatible). |
| src/tests/baseservices/compilerservices/RuntimeWrappedException/RuntimeWrappedException.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/compilerservices/RuntimeHelpers/RuntimeHelpersTests.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/baseservices/TieredCompilation/BasicTest_DefaultMode_R2r.csproj | Updated RequiresProcessIsolation comment to specific trigger (NativeAotIncompatible). |
| src/tests/baseservices/TieredCompilation/BasicTest_DefaultMode.csproj | Updated RequiresProcessIsolation comment to specific trigger (NativeAotIncompatible). |
| src/tests/Regressions/coreclr/Runtime_49998/Runtime_49998.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_88128/test88128.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_85240/test85240.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_84694/test84694.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_79022/test79022.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_78635/test78635.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_7685/Test7685.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_66005/test66005.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_62058/test62058.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_61104/test61104.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_54719/test54719.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_47007/test47007.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_45929/test45929.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_45082/test45082.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_45053/test45053.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_45037/test45037.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_43763/test43763.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_42732/test42732.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_35000/test35000.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_34094/Test34094.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_27937/Test27937.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_24701/test24701.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_22348/Test22348.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_17398/test17398.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_16833/Test16833.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_1674/GitHub_1674.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_13394/test13394.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/GitHub_11611/Test11611.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/9414/readonlyPrefix.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/72162/Test72162.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/25057/byref.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/1770/autolayoutsize.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/16371/ptrarray.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/1514/InterlockExchange.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/0582/csgen.1.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/0487/test.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/0211/genrecur.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/0099/AboveStackLimit.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/0075/LargeArrayTest.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/0046/istype.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/0044/nullable.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/Regressions/coreclr/0041/expl_double_1.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/RyuJIT/DoWhileBndChk.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Math/Functions/Functions_ro.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Math/Functions/Functions_r.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/TypeIntrinsics_ro.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/TypeIntrinsics_r.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/TypeEquality_ro.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/TypeEquality_r.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/TypeEqualitySealed_ro.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/TypeEqualitySealed_r.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MemoryMarshalGetArrayDataReference_ro.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MemoryMarshalGetArrayDataReference_r.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MathRoundSingle_ro.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MathRoundSingle_r.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MathRoundDouble_ro.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MathRoundDouble_r.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MathMinMaxInteger_ro.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MathMinMaxInteger_r.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MathFusedMultiplyAdd_ro.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MathFusedMultiplyAdd_r.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MathFloorSingle_ro.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MathFloorSingle_r.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MathFloorDouble_ro.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MathFloorDouble_r.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MathCeilingSingle_ro.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MathCeilingSingle_r.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MathCeilingDouble_ro.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/MathCeilingDouble_r.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/BitOperationsIntrinsics_ro.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/BitOperationsIntrinsics_r.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/BinaryPrimitivesReverseEndianness_ro.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/BinaryPrimitivesReverseEndianness_r.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/BMI1Intrinsicss_r.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/JIT/Intrinsics/BMI1Intrinsics_ro.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/Regressions/v3.0/25252/25252.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/Regressions/Github/runtime_32848/runtime_32848.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/Coverage/LargeObjectAlloc.csproj | Updated RequiresProcessIsolation comment to specific trigger (custom Main / wrapper generator disabled). |
| src/tests/GC/Coverage/271010.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/WeakReference/TrackResurrection.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/WeakReference/Target.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/WeakReference/IsAlive_neg.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCSettings/InputValidation.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandleCollector/NegTests.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandleCollector/CtorsAndProperties.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandleCollector/Count.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandle/ToFromIntPtr.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandle/Target_neg.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandle/Target.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandle/Pinned.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandle/PinObj_neg.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandle/IsAllocated.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandle/Free_neg.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandle/Free.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandle/Equality.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandle/Casting.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandle/Alloc_neg2.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandle/Alloc_neg.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandle/Alloc.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandle/AddrOfPinnedObject_neg.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GCHandle/AddrOfPinnedObject.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GC/SuppressFinalize_Null.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GC/ReRegisterForFinalize_null.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GC/MaxGeneration.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GC/GetGeneration_fail.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GC/GetGeneration_box.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GC/GetGenerationWR.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GC/GetConfigurationVariables.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GC/CollectionCountTest.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GC/Collect_neg.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GC/Collect_fail.csproj | Removed unnecessary RequiresProcessIsolation and obsolete comment. |
| src/tests/GC/API/GC/Collect_Optimized_3.csproj | Updated RequiresProcessIsolation comment to specific trigger (custom Main / wrapper generator disabled). |
| src/tests/GC/API/GC/Collect_Optimized_2.csproj | Updated RequiresProcessIsolation comment to specific trigger (custom Main / wrapper generator disabled). |
| src/tests/GC/API/GC/Collect_Optimized_1.csproj | Updated RequiresProcessIsolation comment to specific trigger (custom Main / wrapper generator disabled). |
| src/tests/GC/API/GC/Collect_Default_3.csproj | Updated RequiresProcessIsolation comment to specific trigger (custom Main / wrapper generator disabled). |
| src/tests/GC/API/GC/Collect_Default_2.csproj | Updated RequiresProcessIsolation comment to specific trigger (custom Main / wrapper generator disabled). |
| src/tests/GC/API/GC/Collect_Default_1.csproj | Updated RequiresProcessIsolation comment to specific trigger (custom Main / wrapper generator disabled). |
MichalStrehovsky
commented
Mar 11, 2026
Member
@jkoritzinsky did you validate we're still running the same number of tests? (When I did this for the loader subtree, we stopped running 20 or so tests. At the same time we coincidentally started running the same number of new tests (because the merged runner gained visibility into |
jkoritzinsky
commented
Mar 11, 2026
Member
I'll go do an extra run of validation tomorrow to make sure nothing slipped through. |
jkoritzinsky
commented
Mar 19, 2026
Member
Validated that we are running the same number of tests. |
MichalStrehovsky
approved these changes
Mar 23, 2026
jkoritzinsky
enabled auto-merge (squash)
March 23, 2026 04:06
jkoritzinsky
commented
Mar 24, 2026
Member
/ba-g mono wasm helix timeout unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Audit all 190 test projects under
src/tests/bearing the comment "Needed for mechanical merging of all remaining tests, this particular project may not actually need process isolation" against the 28 rules indocs/workflow/testing/coreclr/requiresprocessisolation.md.172 tests had no project-file or source-code triggers — removed
RequiresProcessIsolationand the comment. Empty<PropertyGroup>elements left behind were cleaned up.18 tests do need isolation — replaced the generic comment with the actual reason:
ReferenceXUnitWrapperGenerator=false(custom Main entry point)CLRTestTargetUnsupported(inherited fromreadytorun/Directory.Build.props)MonoAotIncompatibleNativeAotIncompatibleCMakeProjectReference+CopyToOutputDirectoryBefore:
After (kept, with reason):
After (removed — no triggers):
<!-- line and property both deleted -->Verified zero files remain with the "mechanical merging" comment.