Convert more COM interop MethodDescCallSite to UCO by am11 · Pull Request #125508 · dotnet/runtime

am11 · 2026-03-12T19:37:29Z

Contributes to #123864 (group 5: except dispatchinfo.cpp)

…A-pattern

jkotas · 2026-03-20T00:25:44Z

This was close to being merged, except the InvokeArgSlot one that needs more work so that we are confident about it. Would you like to resubmit the delta without InvokeArgSlot?

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

am11 · 2026-03-20T14:24:42Z

Failures are known/unrelated.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

AaronRobinsonMSFT · 2026-03-20T15:51:09Z

+ INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
+ INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
+ UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
+ callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);


There is also InvokeThrowing_Ret that can be used to return primitives. We use it in a few places and in this case probably is easier to read. You can then also update the managed signature to be more "natural".

jkotas · 2026-03-20T16:43:15Z

 DEFINE_METHOD(STUBHELPERS, GET_IENUMERATOR_TO_ENUM_VARIANT_MARSHALER, GetIEnumeratorToEnumVariantMarshaler, SM_PtrObj_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, GET_DISPATCH_EX_PROPERTY_FLAGS, GetDispatchExPropertyFlags, SM_PtrPropertyInfo_PtrInt_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, CALL_ICUSTOM_QUERY_INTERFACE, CallICustomQueryInterface, SM_PtrICustomQueryInterface_PtrGuid_PtrIntPtr_PtrInt_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)


Suggested change
DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)
DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, NoSig)
This should be nosig now that it has unmanaged pointers in the signatures (encoding the unmanaged pointers in the signature here is not worth the pain).

jkotas · 2026-03-20T16:46:12Z

+ INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
+ INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
+ UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
+ callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);
+
+ *ppUnkOut = reinterpret_cast<IUnknown*>(queriedInterface);


Suggested change
INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);
*ppUnkOut = reinterpret_cast<IUnknown*>(queriedInterface);
INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
callICustomQueryInterface.InvokeThrowing(&pObj, &guid, ppUnkOut, &result);
We do not need a local copy of the IUnknown. This should also reduce changes that the IUknown reference leak if an exception is thrown in a specific spot.

am11 · 2026-03-20T17:07:19Z

PR was already approved and we had a good checkpoint with all tests passing. Now I have to go back to debug the new issues in additional changes made in last two hours. I will park this for now from my side. If someone else has time, feel free to continue (curl -sSL https://github.com/dotnet/runtime/pull/125508.patch | git apply -).

jkotas · 2026-03-20T18:10:04Z

Asked copilot to continue: #125849

…UCO) (#125849) Continues the <a href="https://github.com/dotnet/runtime/issues/123864">COM interop UCO migration</a> (group 5), converting three `MethodDescCallSite` call sites to the UCO pattern and removing associated dead code. Addresses all pending feedback from #125508. ## Description ### New UCO helpers in `StubHelpers.cs` - **`GetDispatchExPropertyFlags`** – replaces two `MethodDescCallSite` calls for `PropertyInfo.CanRead`/`CanWrite` in `DispatchEx_GetMemberProperties`; returns `int` directly via `InvokeThrowing_Ret` at the callsite (no out-param) - **`CallICustomQueryInterface`** – replaces the `InvokeICustomQueryInterfaceGetInterface_CallBack` struct/callback pattern; returns `int` directly (uses `InvokeThrowing_Ret`) - **`InvokeConnectionPointProviderMethod`** – replaces two `MethodDescCallSite` calls in `ConnectionPoint::InvokeProviderMethod`; uses `nint`/`UIntPtr` ctor fallback for correctness; uses `GetMultiCallableAddrOfCode()` for the event target since it is stored for future invokes - Added `[RequiresUnsafe]` to the existing `GetIEnumeratorToEnumVariantMarshaler` UCO overload for consistency ### Feedback addressed - `INVOKE_CONNECTION_POINT_PROVIDER_METHOD` registered as `NoSig` in `corelib.h` (has unmanaged fn-ptr params — encoding in metasig not worth the pain) - `CallICustomQueryInterface` uses `InvokeThrowing_Ret<INT32>` and passes `ppUnkOut` directly — no local copy needed - `GetDispatchExPropertyFlags` signature changed to return `int` directly; metasig (`SM_PtrPropertyInfo_PtrException_RetInt`) and `corelib.h` registration updated accordingly; callsite in `stdinterfaces.cpp` updated to use `InvokeThrowing_Ret<INT32>` - UIntPtr ctor fallback restored in `ConnectionPoint::InvokeProviderMethod` for correctness - Comment updated in `comconnectionpoints.cpp` to clarify why `GetMultiCallableAddrOfCode()` is used for the event target ### Dead code removed - `InvokeICustomQueryInterfaceGetInterface_CallBack` + arg struct in `comcallablewrapper.cpp` - `GetICustomQueryInterfaceGetInterfaceMD` / `m_pICustomQueryInterfaceGetInterfaceMD` from `ComCallWrapperTemplate` - `m_ohDelegate` union field and `GetOHDelegate`/`SetOHDelegate`/`GetObjCreateDelegate`/`SetObjCreateDelegate` from `EEClass`/`MethodTable` — `SetObjCreateDelegate` had no callers; the delegate-based `CreateAggregatedInstance` path was effectively dead  --- ⌨️ Start Copilot coding agent tasks without leaving your editor — available in [VS Code](https://gh.io/cca-vs-code-docs), [Visual Studio](https://gh.io/cca-visual-studio-docs), [JetBrains IDEs](https://gh.io/cca-jetbrains-docs) and [Eclipse](https://gh.io/cca-eclipse-docs). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: AaronRobinsonMSFT <30635565+AaronRobinsonMSFT@users.noreply.github.com>

am11 · 2026-03-12T19:37:29Z

Contributes to #123864 (group 5: except dispatchinfo.cpp)

…A-pattern

jkotas · 2026-03-20T00:25:44Z

This was close to being merged, except the InvokeArgSlot one that needs more work so that we are confident about it. Would you like to resubmit the delta without InvokeArgSlot?

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

am11 · 2026-03-20T14:24:42Z

Failures are known/unrelated.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

AaronRobinsonMSFT · 2026-03-20T15:51:09Z

+ INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
+ INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
+ UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
+ callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);


There is also InvokeThrowing_Ret that can be used to return primitives. We use it in a few places and in this case probably is easier to read. You can then also update the managed signature to be more "natural".

jkotas · 2026-03-20T16:43:15Z

 DEFINE_METHOD(STUBHELPERS, GET_IENUMERATOR_TO_ENUM_VARIANT_MARSHALER, GetIEnumeratorToEnumVariantMarshaler, SM_PtrObj_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, GET_DISPATCH_EX_PROPERTY_FLAGS, GetDispatchExPropertyFlags, SM_PtrPropertyInfo_PtrInt_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, CALL_ICUSTOM_QUERY_INTERFACE, CallICustomQueryInterface, SM_PtrICustomQueryInterface_PtrGuid_PtrIntPtr_PtrInt_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)


Suggested change
DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)
DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, NoSig)
This should be nosig now that it has unmanaged pointers in the signatures (encoding the unmanaged pointers in the signature here is not worth the pain).

jkotas · 2026-03-20T16:46:12Z

+ INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
+ INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
+ UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
+ callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);
+
+ *ppUnkOut = reinterpret_cast<IUnknown*>(queriedInterface);


Suggested change
INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);
*ppUnkOut = reinterpret_cast<IUnknown*>(queriedInterface);
INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
callICustomQueryInterface.InvokeThrowing(&pObj, &guid, ppUnkOut, &result);
We do not need a local copy of the IUnknown. This should also reduce changes that the IUknown reference leak if an exception is thrown in a specific spot.

am11 · 2026-03-20T17:07:19Z

PR was already approved and we had a good checkpoint with all tests passing. Now I have to go back to debug the new issues in additional changes made in last two hours. I will park this for now from my side. If someone else has time, feel free to continue (curl -sSL https://github.com/dotnet/runtime/pull/125508.patch | git apply -).

jkotas · 2026-03-20T18:10:04Z

Asked copilot to continue: #125849

…UCO) (#125849) Continues the <a href="https://github.com/dotnet/runtime/issues/123864">COM interop UCO migration</a> (group 5), converting three `MethodDescCallSite` call sites to the UCO pattern and removing associated dead code. Addresses all pending feedback from #125508. ## Description ### New UCO helpers in `StubHelpers.cs` - **`GetDispatchExPropertyFlags`** – replaces two `MethodDescCallSite` calls for `PropertyInfo.CanRead`/`CanWrite` in `DispatchEx_GetMemberProperties`; returns `int` directly via `InvokeThrowing_Ret` at the callsite (no out-param) - **`CallICustomQueryInterface`** – replaces the `InvokeICustomQueryInterfaceGetInterface_CallBack` struct/callback pattern; returns `int` directly (uses `InvokeThrowing_Ret`) - **`InvokeConnectionPointProviderMethod`** – replaces two `MethodDescCallSite` calls in `ConnectionPoint::InvokeProviderMethod`; uses `nint`/`UIntPtr` ctor fallback for correctness; uses `GetMultiCallableAddrOfCode()` for the event target since it is stored for future invokes - Added `[RequiresUnsafe]` to the existing `GetIEnumeratorToEnumVariantMarshaler` UCO overload for consistency ### Feedback addressed - `INVOKE_CONNECTION_POINT_PROVIDER_METHOD` registered as `NoSig` in `corelib.h` (has unmanaged fn-ptr params — encoding in metasig not worth the pain) - `CallICustomQueryInterface` uses `InvokeThrowing_Ret<INT32>` and passes `ppUnkOut` directly — no local copy needed - `GetDispatchExPropertyFlags` signature changed to return `int` directly; metasig (`SM_PtrPropertyInfo_PtrException_RetInt`) and `corelib.h` registration updated accordingly; callsite in `stdinterfaces.cpp` updated to use `InvokeThrowing_Ret<INT32>` - UIntPtr ctor fallback restored in `ConnectionPoint::InvokeProviderMethod` for correctness - Comment updated in `comconnectionpoints.cpp` to clarify why `GetMultiCallableAddrOfCode()` is used for the event target ### Dead code removed - `InvokeICustomQueryInterfaceGetInterface_CallBack` + arg struct in `comcallablewrapper.cpp` - `GetICustomQueryInterfaceGetInterfaceMD` / `m_pICustomQueryInterfaceGetInterfaceMD` from `ComCallWrapperTemplate` - `m_ohDelegate` union field and `GetOHDelegate`/`SetOHDelegate`/`GetObjCreateDelegate`/`SetObjCreateDelegate` from `EEClass`/`MethodTable` — `SetObjCreateDelegate` had no callers; the delegate-based `CreateAggregatedInstance` path was effectively dead  --- ⌨️ Start Copilot coding agent tasks without leaving your editor — available in [VS Code](https://gh.io/cca-vs-code-docs), [Visual Studio](https://gh.io/cca-visual-studio-docs), [JetBrains IDEs](https://gh.io/cca-jetbrains-docs) and [Eclipse](https://gh.io/cca-eclipse-docs). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: AaronRobinsonMSFT <30635565+AaronRobinsonMSFT@users.noreply.github.com>

am11 · 2026-03-12T19:37:29Z

Contributes to #123864 (group 5: except dispatchinfo.cpp)

…A-pattern

jkotas · 2026-03-20T00:25:44Z

This was close to being merged, except the InvokeArgSlot one that needs more work so that we are confident about it. Would you like to resubmit the delta without InvokeArgSlot?

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

am11 · 2026-03-20T14:24:42Z

Failures are known/unrelated.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

AaronRobinsonMSFT · 2026-03-20T15:51:09Z

+ INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
+ INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
+ UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
+ callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);


There is also InvokeThrowing_Ret that can be used to return primitives. We use it in a few places and in this case probably is easier to read. You can then also update the managed signature to be more "natural".

jkotas · 2026-03-20T16:43:15Z

 DEFINE_METHOD(STUBHELPERS, GET_IENUMERATOR_TO_ENUM_VARIANT_MARSHALER, GetIEnumeratorToEnumVariantMarshaler, SM_PtrObj_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, GET_DISPATCH_EX_PROPERTY_FLAGS, GetDispatchExPropertyFlags, SM_PtrPropertyInfo_PtrInt_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, CALL_ICUSTOM_QUERY_INTERFACE, CallICustomQueryInterface, SM_PtrICustomQueryInterface_PtrGuid_PtrIntPtr_PtrInt_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)


Suggested change
DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)
DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, NoSig)
This should be nosig now that it has unmanaged pointers in the signatures (encoding the unmanaged pointers in the signature here is not worth the pain).

jkotas · 2026-03-20T16:46:12Z

+ INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
+ INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
+ UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
+ callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);
+
+ *ppUnkOut = reinterpret_cast<IUnknown*>(queriedInterface);


Suggested change
INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);
*ppUnkOut = reinterpret_cast<IUnknown*>(queriedInterface);
INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
callICustomQueryInterface.InvokeThrowing(&pObj, &guid, ppUnkOut, &result);
We do not need a local copy of the IUnknown. This should also reduce changes that the IUknown reference leak if an exception is thrown in a specific spot.

am11 · 2026-03-20T17:07:19Z

PR was already approved and we had a good checkpoint with all tests passing. Now I have to go back to debug the new issues in additional changes made in last two hours. I will park this for now from my side. If someone else has time, feel free to continue (curl -sSL https://github.com/dotnet/runtime/pull/125508.patch | git apply -).

jkotas · 2026-03-20T18:10:04Z

Asked copilot to continue: #125849

…UCO) (#125849) Continues the <a href="https://github.com/dotnet/runtime/issues/123864">COM interop UCO migration</a> (group 5), converting three `MethodDescCallSite` call sites to the UCO pattern and removing associated dead code. Addresses all pending feedback from #125508. ## Description ### New UCO helpers in `StubHelpers.cs` - **`GetDispatchExPropertyFlags`** – replaces two `MethodDescCallSite` calls for `PropertyInfo.CanRead`/`CanWrite` in `DispatchEx_GetMemberProperties`; returns `int` directly via `InvokeThrowing_Ret` at the callsite (no out-param) - **`CallICustomQueryInterface`** – replaces the `InvokeICustomQueryInterfaceGetInterface_CallBack` struct/callback pattern; returns `int` directly (uses `InvokeThrowing_Ret`) - **`InvokeConnectionPointProviderMethod`** – replaces two `MethodDescCallSite` calls in `ConnectionPoint::InvokeProviderMethod`; uses `nint`/`UIntPtr` ctor fallback for correctness; uses `GetMultiCallableAddrOfCode()` for the event target since it is stored for future invokes - Added `[RequiresUnsafe]` to the existing `GetIEnumeratorToEnumVariantMarshaler` UCO overload for consistency ### Feedback addressed - `INVOKE_CONNECTION_POINT_PROVIDER_METHOD` registered as `NoSig` in `corelib.h` (has unmanaged fn-ptr params — encoding in metasig not worth the pain) - `CallICustomQueryInterface` uses `InvokeThrowing_Ret<INT32>` and passes `ppUnkOut` directly — no local copy needed - `GetDispatchExPropertyFlags` signature changed to return `int` directly; metasig (`SM_PtrPropertyInfo_PtrException_RetInt`) and `corelib.h` registration updated accordingly; callsite in `stdinterfaces.cpp` updated to use `InvokeThrowing_Ret<INT32>` - UIntPtr ctor fallback restored in `ConnectionPoint::InvokeProviderMethod` for correctness - Comment updated in `comconnectionpoints.cpp` to clarify why `GetMultiCallableAddrOfCode()` is used for the event target ### Dead code removed - `InvokeICustomQueryInterfaceGetInterface_CallBack` + arg struct in `comcallablewrapper.cpp` - `GetICustomQueryInterfaceGetInterfaceMD` / `m_pICustomQueryInterfaceGetInterfaceMD` from `ComCallWrapperTemplate` - `m_ohDelegate` union field and `GetOHDelegate`/`SetOHDelegate`/`GetObjCreateDelegate`/`SetObjCreateDelegate` from `EEClass`/`MethodTable` — `SetObjCreateDelegate` had no callers; the delegate-based `CreateAggregatedInstance` path was effectively dead  --- ⌨️ Start Copilot coding agent tasks without leaving your editor — available in [VS Code](https://gh.io/cca-vs-code-docs), [Visual Studio](https://gh.io/cca-visual-studio-docs), [JetBrains IDEs](https://gh.io/cca-jetbrains-docs) and [Eclipse](https://gh.io/cca-eclipse-docs). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: AaronRobinsonMSFT <30635565+AaronRobinsonMSFT@users.noreply.github.com>

am11 · 2026-03-12T19:37:29Z

Contributes to #123864 (group 5: except dispatchinfo.cpp)

…A-pattern

jkotas · 2026-03-20T00:25:44Z

This was close to being merged, except the InvokeArgSlot one that needs more work so that we are confident about it. Would you like to resubmit the delta without InvokeArgSlot?

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

am11 · 2026-03-20T14:24:42Z

Failures are known/unrelated.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

AaronRobinsonMSFT · 2026-03-20T15:51:09Z

+ INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
+ INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
+ UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
+ callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);


There is also InvokeThrowing_Ret that can be used to return primitives. We use it in a few places and in this case probably is easier to read. You can then also update the managed signature to be more "natural".

jkotas · 2026-03-20T16:43:15Z

 DEFINE_METHOD(STUBHELPERS, GET_IENUMERATOR_TO_ENUM_VARIANT_MARSHALER, GetIEnumeratorToEnumVariantMarshaler, SM_PtrObj_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, GET_DISPATCH_EX_PROPERTY_FLAGS, GetDispatchExPropertyFlags, SM_PtrPropertyInfo_PtrInt_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, CALL_ICUSTOM_QUERY_INTERFACE, CallICustomQueryInterface, SM_PtrICustomQueryInterface_PtrGuid_PtrIntPtr_PtrInt_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)


Suggested change
DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)
DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, NoSig)
This should be nosig now that it has unmanaged pointers in the signatures (encoding the unmanaged pointers in the signature here is not worth the pain).

jkotas · 2026-03-20T16:46:12Z

+ INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
+ INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
+ UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
+ callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);
+
+ *ppUnkOut = reinterpret_cast<IUnknown*>(queriedInterface);


Suggested change
INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);
*ppUnkOut = reinterpret_cast<IUnknown*>(queriedInterface);
INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
callICustomQueryInterface.InvokeThrowing(&pObj, &guid, ppUnkOut, &result);
We do not need a local copy of the IUnknown. This should also reduce changes that the IUknown reference leak if an exception is thrown in a specific spot.

am11 · 2026-03-20T17:07:19Z

PR was already approved and we had a good checkpoint with all tests passing. Now I have to go back to debug the new issues in additional changes made in last two hours. I will park this for now from my side. If someone else has time, feel free to continue (curl -sSL https://github.com/dotnet/runtime/pull/125508.patch | git apply -).

jkotas · 2026-03-20T18:10:04Z

Asked copilot to continue: #125849

…UCO) (#125849) Continues the <a href="https://github.com/dotnet/runtime/issues/123864">COM interop UCO migration</a> (group 5), converting three `MethodDescCallSite` call sites to the UCO pattern and removing associated dead code. Addresses all pending feedback from #125508. ## Description ### New UCO helpers in `StubHelpers.cs` - **`GetDispatchExPropertyFlags`** – replaces two `MethodDescCallSite` calls for `PropertyInfo.CanRead`/`CanWrite` in `DispatchEx_GetMemberProperties`; returns `int` directly via `InvokeThrowing_Ret` at the callsite (no out-param) - **`CallICustomQueryInterface`** – replaces the `InvokeICustomQueryInterfaceGetInterface_CallBack` struct/callback pattern; returns `int` directly (uses `InvokeThrowing_Ret`) - **`InvokeConnectionPointProviderMethod`** – replaces two `MethodDescCallSite` calls in `ConnectionPoint::InvokeProviderMethod`; uses `nint`/`UIntPtr` ctor fallback for correctness; uses `GetMultiCallableAddrOfCode()` for the event target since it is stored for future invokes - Added `[RequiresUnsafe]` to the existing `GetIEnumeratorToEnumVariantMarshaler` UCO overload for consistency ### Feedback addressed - `INVOKE_CONNECTION_POINT_PROVIDER_METHOD` registered as `NoSig` in `corelib.h` (has unmanaged fn-ptr params — encoding in metasig not worth the pain) - `CallICustomQueryInterface` uses `InvokeThrowing_Ret<INT32>` and passes `ppUnkOut` directly — no local copy needed - `GetDispatchExPropertyFlags` signature changed to return `int` directly; metasig (`SM_PtrPropertyInfo_PtrException_RetInt`) and `corelib.h` registration updated accordingly; callsite in `stdinterfaces.cpp` updated to use `InvokeThrowing_Ret<INT32>` - UIntPtr ctor fallback restored in `ConnectionPoint::InvokeProviderMethod` for correctness - Comment updated in `comconnectionpoints.cpp` to clarify why `GetMultiCallableAddrOfCode()` is used for the event target ### Dead code removed - `InvokeICustomQueryInterfaceGetInterface_CallBack` + arg struct in `comcallablewrapper.cpp` - `GetICustomQueryInterfaceGetInterfaceMD` / `m_pICustomQueryInterfaceGetInterfaceMD` from `ComCallWrapperTemplate` - `m_ohDelegate` union field and `GetOHDelegate`/`SetOHDelegate`/`GetObjCreateDelegate`/`SetObjCreateDelegate` from `EEClass`/`MethodTable` — `SetObjCreateDelegate` had no callers; the delegate-based `CreateAggregatedInstance` path was effectively dead  --- ⌨️ Start Copilot coding agent tasks without leaving your editor — available in [VS Code](https://gh.io/cca-vs-code-docs), [Visual Studio](https://gh.io/cca-visual-studio-docs), [JetBrains IDEs](https://gh.io/cca-jetbrains-docs) and [Eclipse](https://gh.io/cca-eclipse-docs). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: AaronRobinsonMSFT <30635565+AaronRobinsonMSFT@users.noreply.github.com>

am11 · 2026-03-12T19:37:29Z

Contributes to #123864 (group 5: except dispatchinfo.cpp)

…A-pattern

jkotas · 2026-03-20T00:25:44Z

This was close to being merged, except the InvokeArgSlot one that needs more work so that we are confident about it. Would you like to resubmit the delta without InvokeArgSlot?

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

am11 · 2026-03-20T14:24:42Z

Failures are known/unrelated.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

AaronRobinsonMSFT · 2026-03-20T15:51:09Z

+ INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
+ INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
+ UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
+ callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);


There is also InvokeThrowing_Ret that can be used to return primitives. We use it in a few places and in this case probably is easier to read. You can then also update the managed signature to be more "natural".

jkotas · 2026-03-20T16:43:15Z

 DEFINE_METHOD(STUBHELPERS, GET_IENUMERATOR_TO_ENUM_VARIANT_MARSHALER, GetIEnumeratorToEnumVariantMarshaler, SM_PtrObj_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, GET_DISPATCH_EX_PROPERTY_FLAGS, GetDispatchExPropertyFlags, SM_PtrPropertyInfo_PtrInt_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, CALL_ICUSTOM_QUERY_INTERFACE, CallICustomQueryInterface, SM_PtrICustomQueryInterface_PtrGuid_PtrIntPtr_PtrInt_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)


Suggested change
DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)
DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, NoSig)
This should be nosig now that it has unmanaged pointers in the signatures (encoding the unmanaged pointers in the signature here is not worth the pain).

jkotas · 2026-03-20T16:46:12Z

+ INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
+ INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
+ UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
+ callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);
+
+ *ppUnkOut = reinterpret_cast<IUnknown*>(queriedInterface);


Suggested change
INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);
*ppUnkOut = reinterpret_cast<IUnknown*>(queriedInterface);
INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
callICustomQueryInterface.InvokeThrowing(&pObj, &guid, ppUnkOut, &result);
We do not need a local copy of the IUnknown. This should also reduce changes that the IUknown reference leak if an exception is thrown in a specific spot.

am11 · 2026-03-20T17:07:19Z

PR was already approved and we had a good checkpoint with all tests passing. Now I have to go back to debug the new issues in additional changes made in last two hours. I will park this for now from my side. If someone else has time, feel free to continue (curl -sSL https://github.com/dotnet/runtime/pull/125508.patch | git apply -).

jkotas · 2026-03-20T18:10:04Z

Asked copilot to continue: #125849

…UCO) (#125849) Continues the <a href="https://github.com/dotnet/runtime/issues/123864">COM interop UCO migration</a> (group 5), converting three `MethodDescCallSite` call sites to the UCO pattern and removing associated dead code. Addresses all pending feedback from #125508. ## Description ### New UCO helpers in `StubHelpers.cs` - **`GetDispatchExPropertyFlags`** – replaces two `MethodDescCallSite` calls for `PropertyInfo.CanRead`/`CanWrite` in `DispatchEx_GetMemberProperties`; returns `int` directly via `InvokeThrowing_Ret` at the callsite (no out-param) - **`CallICustomQueryInterface`** – replaces the `InvokeICustomQueryInterfaceGetInterface_CallBack` struct/callback pattern; returns `int` directly (uses `InvokeThrowing_Ret`) - **`InvokeConnectionPointProviderMethod`** – replaces two `MethodDescCallSite` calls in `ConnectionPoint::InvokeProviderMethod`; uses `nint`/`UIntPtr` ctor fallback for correctness; uses `GetMultiCallableAddrOfCode()` for the event target since it is stored for future invokes - Added `[RequiresUnsafe]` to the existing `GetIEnumeratorToEnumVariantMarshaler` UCO overload for consistency ### Feedback addressed - `INVOKE_CONNECTION_POINT_PROVIDER_METHOD` registered as `NoSig` in `corelib.h` (has unmanaged fn-ptr params — encoding in metasig not worth the pain) - `CallICustomQueryInterface` uses `InvokeThrowing_Ret<INT32>` and passes `ppUnkOut` directly — no local copy needed - `GetDispatchExPropertyFlags` signature changed to return `int` directly; metasig (`SM_PtrPropertyInfo_PtrException_RetInt`) and `corelib.h` registration updated accordingly; callsite in `stdinterfaces.cpp` updated to use `InvokeThrowing_Ret<INT32>` - UIntPtr ctor fallback restored in `ConnectionPoint::InvokeProviderMethod` for correctness - Comment updated in `comconnectionpoints.cpp` to clarify why `GetMultiCallableAddrOfCode()` is used for the event target ### Dead code removed - `InvokeICustomQueryInterfaceGetInterface_CallBack` + arg struct in `comcallablewrapper.cpp` - `GetICustomQueryInterfaceGetInterfaceMD` / `m_pICustomQueryInterfaceGetInterfaceMD` from `ComCallWrapperTemplate` - `m_ohDelegate` union field and `GetOHDelegate`/`SetOHDelegate`/`GetObjCreateDelegate`/`SetObjCreateDelegate` from `EEClass`/`MethodTable` — `SetObjCreateDelegate` had no callers; the delegate-based `CreateAggregatedInstance` path was effectively dead  --- ⌨️ Start Copilot coding agent tasks without leaving your editor — available in [VS Code](https://gh.io/cca-vs-code-docs), [Visual Studio](https://gh.io/cca-visual-studio-docs), [JetBrains IDEs](https://gh.io/cca-jetbrains-docs) and [Eclipse](https://gh.io/cca-eclipse-docs). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: AaronRobinsonMSFT <30635565+AaronRobinsonMSFT@users.noreply.github.com>

am11 · 2026-03-12T19:37:29Z

Contributes to #123864 (group 5: except dispatchinfo.cpp)

…A-pattern

jkotas · 2026-03-20T00:25:44Z

This was close to being merged, except the InvokeArgSlot one that needs more work so that we are confident about it. Would you like to resubmit the delta without InvokeArgSlot?

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

am11 · 2026-03-20T14:24:42Z

Failures are known/unrelated.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

AaronRobinsonMSFT · 2026-03-20T15:51:09Z

+ INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
+ INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
+ UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
+ callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);


There is also InvokeThrowing_Ret that can be used to return primitives. We use it in a few places and in this case probably is easier to read. You can then also update the managed signature to be more "natural".

jkotas · 2026-03-20T16:43:15Z

 DEFINE_METHOD(STUBHELPERS, GET_IENUMERATOR_TO_ENUM_VARIANT_MARSHALER, GetIEnumeratorToEnumVariantMarshaler, SM_PtrObj_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, GET_DISPATCH_EX_PROPERTY_FLAGS, GetDispatchExPropertyFlags, SM_PtrPropertyInfo_PtrInt_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, CALL_ICUSTOM_QUERY_INTERFACE, CallICustomQueryInterface, SM_PtrICustomQueryInterface_PtrGuid_PtrIntPtr_PtrInt_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)


Suggested change
DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)
DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, NoSig)
This should be nosig now that it has unmanaged pointers in the signatures (encoding the unmanaged pointers in the signature here is not worth the pain).

jkotas · 2026-03-20T16:46:12Z

+ INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
+ INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
+ UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
+ callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);
+
+ *ppUnkOut = reinterpret_cast<IUnknown*>(queriedInterface);


Suggested change
INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);
*ppUnkOut = reinterpret_cast<IUnknown*>(queriedInterface);
INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
callICustomQueryInterface.InvokeThrowing(&pObj, &guid, ppUnkOut, &result);
We do not need a local copy of the IUnknown. This should also reduce changes that the IUknown reference leak if an exception is thrown in a specific spot.

am11 · 2026-03-20T17:07:19Z

PR was already approved and we had a good checkpoint with all tests passing. Now I have to go back to debug the new issues in additional changes made in last two hours. I will park this for now from my side. If someone else has time, feel free to continue (curl -sSL https://github.com/dotnet/runtime/pull/125508.patch | git apply -).

jkotas · 2026-03-20T18:10:04Z

Asked copilot to continue: #125849

…UCO) (#125849) Continues the <a href="https://github.com/dotnet/runtime/issues/123864">COM interop UCO migration</a> (group 5), converting three `MethodDescCallSite` call sites to the UCO pattern and removing associated dead code. Addresses all pending feedback from #125508. ## Description ### New UCO helpers in `StubHelpers.cs` - **`GetDispatchExPropertyFlags`** – replaces two `MethodDescCallSite` calls for `PropertyInfo.CanRead`/`CanWrite` in `DispatchEx_GetMemberProperties`; returns `int` directly via `InvokeThrowing_Ret` at the callsite (no out-param) - **`CallICustomQueryInterface`** – replaces the `InvokeICustomQueryInterfaceGetInterface_CallBack` struct/callback pattern; returns `int` directly (uses `InvokeThrowing_Ret`) - **`InvokeConnectionPointProviderMethod`** – replaces two `MethodDescCallSite` calls in `ConnectionPoint::InvokeProviderMethod`; uses `nint`/`UIntPtr` ctor fallback for correctness; uses `GetMultiCallableAddrOfCode()` for the event target since it is stored for future invokes - Added `[RequiresUnsafe]` to the existing `GetIEnumeratorToEnumVariantMarshaler` UCO overload for consistency ### Feedback addressed - `INVOKE_CONNECTION_POINT_PROVIDER_METHOD` registered as `NoSig` in `corelib.h` (has unmanaged fn-ptr params — encoding in metasig not worth the pain) - `CallICustomQueryInterface` uses `InvokeThrowing_Ret<INT32>` and passes `ppUnkOut` directly — no local copy needed - `GetDispatchExPropertyFlags` signature changed to return `int` directly; metasig (`SM_PtrPropertyInfo_PtrException_RetInt`) and `corelib.h` registration updated accordingly; callsite in `stdinterfaces.cpp` updated to use `InvokeThrowing_Ret<INT32>` - UIntPtr ctor fallback restored in `ConnectionPoint::InvokeProviderMethod` for correctness - Comment updated in `comconnectionpoints.cpp` to clarify why `GetMultiCallableAddrOfCode()` is used for the event target ### Dead code removed - `InvokeICustomQueryInterfaceGetInterface_CallBack` + arg struct in `comcallablewrapper.cpp` - `GetICustomQueryInterfaceGetInterfaceMD` / `m_pICustomQueryInterfaceGetInterfaceMD` from `ComCallWrapperTemplate` - `m_ohDelegate` union field and `GetOHDelegate`/`SetOHDelegate`/`GetObjCreateDelegate`/`SetObjCreateDelegate` from `EEClass`/`MethodTable` — `SetObjCreateDelegate` had no callers; the delegate-based `CreateAggregatedInstance` path was effectively dead  --- ⌨️ Start Copilot coding agent tasks without leaving your editor — available in [VS Code](https://gh.io/cca-vs-code-docs), [Visual Studio](https://gh.io/cca-visual-studio-docs), [JetBrains IDEs](https://gh.io/cca-jetbrains-docs) and [Eclipse](https://gh.io/cca-eclipse-docs). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: AaronRobinsonMSFT <30635565+AaronRobinsonMSFT@users.noreply.github.com>

am11 · 2026-03-12T19:37:29Z

Contributes to #123864 (group 5: except dispatchinfo.cpp)

…A-pattern

jkotas · 2026-03-20T00:25:44Z

This was close to being merged, except the InvokeArgSlot one that needs more work so that we are confident about it. Would you like to resubmit the delta without InvokeArgSlot?

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

am11 · 2026-03-20T14:24:42Z

Failures are known/unrelated.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

AaronRobinsonMSFT · 2026-03-20T15:51:09Z

+ INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
+ INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
+ UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
+ callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);


There is also InvokeThrowing_Ret that can be used to return primitives. We use it in a few places and in this case probably is easier to read. You can then also update the managed signature to be more "natural".

jkotas · 2026-03-20T16:43:15Z

 DEFINE_METHOD(STUBHELPERS, GET_IENUMERATOR_TO_ENUM_VARIANT_MARSHALER, GetIEnumeratorToEnumVariantMarshaler, SM_PtrObj_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, GET_DISPATCH_EX_PROPERTY_FLAGS, GetDispatchExPropertyFlags, SM_PtrPropertyInfo_PtrInt_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, CALL_ICUSTOM_QUERY_INTERFACE, CallICustomQueryInterface, SM_PtrICustomQueryInterface_PtrGuid_PtrIntPtr_PtrInt_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)


Suggested change
DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)
DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, NoSig)
This should be nosig now that it has unmanaged pointers in the signatures (encoding the unmanaged pointers in the signature here is not worth the pain).

jkotas · 2026-03-20T16:46:12Z

+ INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
+ INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
+ UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
+ callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);
+
+ *ppUnkOut = reinterpret_cast<IUnknown*>(queriedInterface);


Suggested change
INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);
*ppUnkOut = reinterpret_cast<IUnknown*>(queriedInterface);
INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
callICustomQueryInterface.InvokeThrowing(&pObj, &guid, ppUnkOut, &result);
We do not need a local copy of the IUnknown. This should also reduce changes that the IUknown reference leak if an exception is thrown in a specific spot.

am11 · 2026-03-20T17:07:19Z

PR was already approved and we had a good checkpoint with all tests passing. Now I have to go back to debug the new issues in additional changes made in last two hours. I will park this for now from my side. If someone else has time, feel free to continue (curl -sSL https://github.com/dotnet/runtime/pull/125508.patch | git apply -).

jkotas · 2026-03-20T18:10:04Z

Asked copilot to continue: #125849

…UCO) (#125849) Continues the <a href="https://github.com/dotnet/runtime/issues/123864">COM interop UCO migration</a> (group 5), converting three `MethodDescCallSite` call sites to the UCO pattern and removing associated dead code. Addresses all pending feedback from #125508. ## Description ### New UCO helpers in `StubHelpers.cs` - **`GetDispatchExPropertyFlags`** – replaces two `MethodDescCallSite` calls for `PropertyInfo.CanRead`/`CanWrite` in `DispatchEx_GetMemberProperties`; returns `int` directly via `InvokeThrowing_Ret` at the callsite (no out-param) - **`CallICustomQueryInterface`** – replaces the `InvokeICustomQueryInterfaceGetInterface_CallBack` struct/callback pattern; returns `int` directly (uses `InvokeThrowing_Ret`) - **`InvokeConnectionPointProviderMethod`** – replaces two `MethodDescCallSite` calls in `ConnectionPoint::InvokeProviderMethod`; uses `nint`/`UIntPtr` ctor fallback for correctness; uses `GetMultiCallableAddrOfCode()` for the event target since it is stored for future invokes - Added `[RequiresUnsafe]` to the existing `GetIEnumeratorToEnumVariantMarshaler` UCO overload for consistency ### Feedback addressed - `INVOKE_CONNECTION_POINT_PROVIDER_METHOD` registered as `NoSig` in `corelib.h` (has unmanaged fn-ptr params — encoding in metasig not worth the pain) - `CallICustomQueryInterface` uses `InvokeThrowing_Ret<INT32>` and passes `ppUnkOut` directly — no local copy needed - `GetDispatchExPropertyFlags` signature changed to return `int` directly; metasig (`SM_PtrPropertyInfo_PtrException_RetInt`) and `corelib.h` registration updated accordingly; callsite in `stdinterfaces.cpp` updated to use `InvokeThrowing_Ret<INT32>` - UIntPtr ctor fallback restored in `ConnectionPoint::InvokeProviderMethod` for correctness - Comment updated in `comconnectionpoints.cpp` to clarify why `GetMultiCallableAddrOfCode()` is used for the event target ### Dead code removed - `InvokeICustomQueryInterfaceGetInterface_CallBack` + arg struct in `comcallablewrapper.cpp` - `GetICustomQueryInterfaceGetInterfaceMD` / `m_pICustomQueryInterfaceGetInterfaceMD` from `ComCallWrapperTemplate` - `m_ohDelegate` union field and `GetOHDelegate`/`SetOHDelegate`/`GetObjCreateDelegate`/`SetObjCreateDelegate` from `EEClass`/`MethodTable` — `SetObjCreateDelegate` had no callers; the delegate-based `CreateAggregatedInstance` path was effectively dead  --- ⌨️ Start Copilot coding agent tasks without leaving your editor — available in [VS Code](https://gh.io/cca-vs-code-docs), [Visual Studio](https://gh.io/cca-visual-studio-docs), [JetBrains IDEs](https://gh.io/cca-jetbrains-docs) and [Eclipse](https://gh.io/cca-eclipse-docs). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: AaronRobinsonMSFT <30635565+AaronRobinsonMSFT@users.noreply.github.com>

am11 · 2026-03-12T19:37:29Z

Contributes to #123864 (group 5: except dispatchinfo.cpp)

…A-pattern

jkotas · 2026-03-20T00:25:44Z

This was close to being merged, except the InvokeArgSlot one that needs more work so that we are confident about it. Would you like to resubmit the delta without InvokeArgSlot?

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

am11 · 2026-03-20T14:24:42Z

Failures are known/unrelated.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

AaronRobinsonMSFT · 2026-03-20T15:51:09Z

+ INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
+ INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
+ UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
+ callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);


There is also InvokeThrowing_Ret that can be used to return primitives. We use it in a few places and in this case probably is easier to read. You can then also update the managed signature to be more "natural".

jkotas · 2026-03-20T16:43:15Z

 DEFINE_METHOD(STUBHELPERS, GET_IENUMERATOR_TO_ENUM_VARIANT_MARSHALER, GetIEnumeratorToEnumVariantMarshaler, SM_PtrObj_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, GET_DISPATCH_EX_PROPERTY_FLAGS, GetDispatchExPropertyFlags, SM_PtrPropertyInfo_PtrInt_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, CALL_ICUSTOM_QUERY_INTERFACE, CallICustomQueryInterface, SM_PtrICustomQueryInterface_PtrGuid_PtrIntPtr_PtrInt_PtrException_RetVoid)
+DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)


Suggested change
DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)
DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, NoSig)
This should be nosig now that it has unmanaged pointers in the signatures (encoding the unmanaged pointers in the signature here is not worth the pain).

jkotas · 2026-03-20T16:46:12Z

+ INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
+ INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
+ UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
+ callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);
+
+ *ppUnkOut = reinterpret_cast<IUnknown*>(queriedInterface);


Suggested change
INT_PTR queriedInterface = reinterpret_cast<INT_PTR>(*ppUnkOut);
INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
callICustomQueryInterface.InvokeThrowing(&pObj, &guid, &queriedInterface, &result);
*ppUnkOut = reinterpret_cast<IUnknown*>(queriedInterface);
INT32 result = static_cast<INT32>(CustomQueryInterfaceResult::NotHandled);
UnmanagedCallersOnlyCaller callICustomQueryInterface(METHOD__STUBHELPERS__CALL_ICUSTOM_QUERY_INTERFACE);
callICustomQueryInterface.InvokeThrowing(&pObj, &guid, ppUnkOut, &result);
We do not need a local copy of the IUnknown. This should also reduce changes that the IUknown reference leak if an exception is thrown in a specific spot.

am11 · 2026-03-20T17:07:19Z

PR was already approved and we had a good checkpoint with all tests passing. Now I have to go back to debug the new issues in additional changes made in last two hours. I will park this for now from my side. If someone else has time, feel free to continue (curl -sSL https://github.com/dotnet/runtime/pull/125508.patch | git apply -).

jkotas · 2026-03-20T18:10:04Z

Asked copilot to continue: #125849

…UCO) (#125849) Continues the <a href="https://github.com/dotnet/runtime/issues/123864">COM interop UCO migration</a> (group 5), converting three `MethodDescCallSite` call sites to the UCO pattern and removing associated dead code. Addresses all pending feedback from #125508. ## Description ### New UCO helpers in `StubHelpers.cs` - **`GetDispatchExPropertyFlags`** – replaces two `MethodDescCallSite` calls for `PropertyInfo.CanRead`/`CanWrite` in `DispatchEx_GetMemberProperties`; returns `int` directly via `InvokeThrowing_Ret` at the callsite (no out-param) - **`CallICustomQueryInterface`** – replaces the `InvokeICustomQueryInterfaceGetInterface_CallBack` struct/callback pattern; returns `int` directly (uses `InvokeThrowing_Ret`) - **`InvokeConnectionPointProviderMethod`** – replaces two `MethodDescCallSite` calls in `ConnectionPoint::InvokeProviderMethod`; uses `nint`/`UIntPtr` ctor fallback for correctness; uses `GetMultiCallableAddrOfCode()` for the event target since it is stored for future invokes - Added `[RequiresUnsafe]` to the existing `GetIEnumeratorToEnumVariantMarshaler` UCO overload for consistency ### Feedback addressed - `INVOKE_CONNECTION_POINT_PROVIDER_METHOD` registered as `NoSig` in `corelib.h` (has unmanaged fn-ptr params — encoding in metasig not worth the pain) - `CallICustomQueryInterface` uses `InvokeThrowing_Ret<INT32>` and passes `ppUnkOut` directly — no local copy needed - `GetDispatchExPropertyFlags` signature changed to return `int` directly; metasig (`SM_PtrPropertyInfo_PtrException_RetInt`) and `corelib.h` registration updated accordingly; callsite in `stdinterfaces.cpp` updated to use `InvokeThrowing_Ret<INT32>` - UIntPtr ctor fallback restored in `ConnectionPoint::InvokeProviderMethod` for correctness - Comment updated in `comconnectionpoints.cpp` to clarify why `GetMultiCallableAddrOfCode()` is used for the event target ### Dead code removed - `InvokeICustomQueryInterfaceGetInterface_CallBack` + arg struct in `comcallablewrapper.cpp` - `GetICustomQueryInterfaceGetInterfaceMD` / `m_pICustomQueryInterfaceGetInterfaceMD` from `ComCallWrapperTemplate` - `m_ohDelegate` union field and `GetOHDelegate`/`SetOHDelegate`/`GetObjCreateDelegate`/`SetObjCreateDelegate` from `EEClass`/`MethodTable` — `SetObjCreateDelegate` had no callers; the delegate-based `CreateAggregatedInstance` path was effectively dead  --- ⌨️ Start Copilot coding agent tasks without leaving your editor — available in [VS Code](https://gh.io/cca-vs-code-docs), [Visual Studio](https://gh.io/cca-visual-studio-docs), [JetBrains IDEs](https://gh.io/cca-jetbrains-docs) and [Eclipse](https://gh.io/cca-eclipse-docs). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: AaronRobinsonMSFT <30635565+AaronRobinsonMSFT@users.noreply.github.com>

Convert more COM interop MethodDescCallSite to UCO
96197f1

github-actionsBot added the area-VM-coreclr label Mar 12, 2026

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Mar 12, 2026

am11 mentioned this pull request Mar 12, 2026
Replace CallDescrWorker with UnmanagedCallersOnlyAttribute pattern #123864
Open
72 tasks

am11 added 2 commits March 13, 2026 02:41

Add guard
83f8dd6

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
3247c98

This was referenced Mar 13, 2026
MsQuic fails with QUIC_STATUS_OUT_OF_MEMORY on AzureLinux #123216
Closed
AOT precompile failed on ios-arm64: 'No space left on device' (exit code 1) #125107
Closed

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comconnectionpoints.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comcallablewrapper.cpp

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/runtimecallablewrapper.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/clrtocomcall.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11 added 3 commits March 13, 2026 15:46

Address CR fb
e4b6de6

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
3e5088f

Use raw data for value type
988e82a

AaronRobinsonMSFT reviewed Mar 13, 2026
View reviewed changes

am11 added 2 commits March 13, 2026 18:40

Address CR fb
68e943f

Merge remote-tracking branch 'upstream/main' into feature/MDCS-to-UCO…
dc0cc4a
…A-pattern

AaronRobinsonMSFT reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

Add comment explaining ulong usage
dd50f41

jkotas reviewed Mar 14, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/methodtable.cpp

Delete {G,S}setOHDelegate
5057a6a

jkotas reviewed Mar 14, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/class.h

am11 added 2 commits March 14, 2026 11:03

Update class.h
3ed9700

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
f1fc86a

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/clrtocomcall.cpp Outdated

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 16, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11 closed this Mar 19, 2026

am11 deleted the feature/MDCS-to-UCOA-pattern branch March 19, 2026 16:39

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comcallablewrapper.cpp Outdated

am11 restored the feature/MDCS-to-UCOA-pattern branch March 20, 2026 10:50

am11 reopened this Mar 20, 2026

am11 added 4 commits March 20, 2026 12:53

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
cdaee50

Address feedback
e4e5d2a

Add [RequiresUnsafe] attribute
a08de0d
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

Update StubHelpers.cs
5693443

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11and others added 3 commits March 20, 2026 14:57

Revert slot conversions
0f433ae

Update StubHelpers.cs
a2eb88b
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
563d118

AaronRobinsonMSFT reviewed Mar 20, 2026
View reviewed changes

jkotas reviewed Mar 20, 2026
View reviewed changes

am11 closed this Mar 20, 2026

am11 deleted the feature/MDCS-to-UCOA-pattern branch March 20, 2026 17:07

CopilotAI mentioned this pull request Mar 20, 2026
Convert more COM interop MethodDescCallSite to UnmanagedCallersOnly (UCO) #125849
Merged

github-actionsBot locked and limited conversation to collaborators Apr 20, 2026

Convert more COM interop MethodDescCallSite to UCO
96197f1

github-actionsBot added the area-VM-coreclr label Mar 12, 2026

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Mar 12, 2026

am11 mentioned this pull request Mar 12, 2026
Replace CallDescrWorker with UnmanagedCallersOnlyAttribute pattern #123864
Open
72 tasks

am11 added 2 commits March 13, 2026 02:41

Add guard
83f8dd6

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
3247c98

This was referenced Mar 13, 2026
MsQuic fails with QUIC_STATUS_OUT_OF_MEMORY on AzureLinux #123216
Closed
AOT precompile failed on ios-arm64: 'No space left on device' (exit code 1) #125107
Closed

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comconnectionpoints.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comcallablewrapper.cpp

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/runtimecallablewrapper.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/clrtocomcall.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11 added 3 commits March 13, 2026 15:46

Address CR fb
e4b6de6

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
3e5088f

Use raw data for value type
988e82a

AaronRobinsonMSFT reviewed Mar 13, 2026
View reviewed changes

am11 added 2 commits March 13, 2026 18:40

Address CR fb
68e943f

Merge remote-tracking branch 'upstream/main' into feature/MDCS-to-UCO…
dc0cc4a
…A-pattern

AaronRobinsonMSFT reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

Add comment explaining ulong usage
dd50f41

jkotas reviewed Mar 14, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/methodtable.cpp

Delete {G,S}setOHDelegate
5057a6a

jkotas reviewed Mar 14, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/class.h

am11 added 2 commits March 14, 2026 11:03

Update class.h
3ed9700

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
f1fc86a

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/clrtocomcall.cpp Outdated

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 16, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11 closed this Mar 19, 2026

am11 deleted the feature/MDCS-to-UCOA-pattern branch March 19, 2026 16:39

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comcallablewrapper.cpp Outdated

am11 restored the feature/MDCS-to-UCOA-pattern branch March 20, 2026 10:50

am11 reopened this Mar 20, 2026

am11 added 4 commits March 20, 2026 12:53

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
cdaee50

Address feedback
e4e5d2a

Add [RequiresUnsafe] attribute
a08de0d
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

Update StubHelpers.cs
5693443

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11and others added 3 commits March 20, 2026 14:57

Revert slot conversions
0f433ae

Update StubHelpers.cs
a2eb88b
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
563d118

AaronRobinsonMSFT reviewed Mar 20, 2026
View reviewed changes

jkotas reviewed Mar 20, 2026
View reviewed changes

am11 closed this Mar 20, 2026

am11 deleted the feature/MDCS-to-UCOA-pattern branch March 20, 2026 17:07

CopilotAI mentioned this pull request Mar 20, 2026
Convert more COM interop MethodDescCallSite to UnmanagedCallersOnly (UCO) #125849
Merged

github-actionsBot locked and limited conversation to collaborators Apr 20, 2026

Convert more COM interop MethodDescCallSite to UCO
96197f1

github-actionsBot added the area-VM-coreclr label Mar 12, 2026

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Mar 12, 2026

am11 mentioned this pull request Mar 12, 2026
Replace CallDescrWorker with UnmanagedCallersOnlyAttribute pattern #123864
Open
72 tasks

am11 added 2 commits March 13, 2026 02:41

Add guard
83f8dd6

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
3247c98

This was referenced Mar 13, 2026
MsQuic fails with QUIC_STATUS_OUT_OF_MEMORY on AzureLinux #123216
Closed
AOT precompile failed on ios-arm64: 'No space left on device' (exit code 1) #125107
Closed

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comconnectionpoints.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comcallablewrapper.cpp

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/runtimecallablewrapper.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/clrtocomcall.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11 added 3 commits March 13, 2026 15:46

Address CR fb
e4b6de6

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
3e5088f

Use raw data for value type
988e82a

AaronRobinsonMSFT reviewed Mar 13, 2026
View reviewed changes

am11 added 2 commits March 13, 2026 18:40

Address CR fb
68e943f

Merge remote-tracking branch 'upstream/main' into feature/MDCS-to-UCO…
dc0cc4a
…A-pattern

AaronRobinsonMSFT reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

Add comment explaining ulong usage
dd50f41

jkotas reviewed Mar 14, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/methodtable.cpp

Delete {G,S}setOHDelegate
5057a6a

jkotas reviewed Mar 14, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/class.h

am11 added 2 commits March 14, 2026 11:03

Update class.h
3ed9700

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
f1fc86a

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/clrtocomcall.cpp Outdated

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 16, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11 closed this Mar 19, 2026

am11 deleted the feature/MDCS-to-UCOA-pattern branch March 19, 2026 16:39

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comcallablewrapper.cpp Outdated

am11 restored the feature/MDCS-to-UCOA-pattern branch March 20, 2026 10:50

am11 reopened this Mar 20, 2026

am11 added 4 commits March 20, 2026 12:53

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
cdaee50

Address feedback
e4e5d2a

Add [RequiresUnsafe] attribute
a08de0d
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

Update StubHelpers.cs
5693443

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11and others added 3 commits March 20, 2026 14:57

Revert slot conversions
0f433ae

Update StubHelpers.cs
a2eb88b
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
563d118

AaronRobinsonMSFT reviewed Mar 20, 2026
View reviewed changes

jkotas reviewed Mar 20, 2026
View reviewed changes

am11 closed this Mar 20, 2026

am11 deleted the feature/MDCS-to-UCOA-pattern branch March 20, 2026 17:07

CopilotAI mentioned this pull request Mar 20, 2026
Convert more COM interop MethodDescCallSite to UnmanagedCallersOnly (UCO) #125849
Merged

github-actionsBot locked and limited conversation to collaborators Apr 20, 2026

Convert more COM interop MethodDescCallSite to UCO
96197f1

github-actionsBot added the area-VM-coreclr label Mar 12, 2026

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Mar 12, 2026

am11 mentioned this pull request Mar 12, 2026
Replace CallDescrWorker with UnmanagedCallersOnlyAttribute pattern #123864
Open
72 tasks

am11 added 2 commits March 13, 2026 02:41

Add guard
83f8dd6

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
3247c98

This was referenced Mar 13, 2026
MsQuic fails with QUIC_STATUS_OUT_OF_MEMORY on AzureLinux #123216
Closed
AOT precompile failed on ios-arm64: 'No space left on device' (exit code 1) #125107
Closed

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comconnectionpoints.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comcallablewrapper.cpp

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/runtimecallablewrapper.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/clrtocomcall.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11 added 3 commits March 13, 2026 15:46

Address CR fb
e4b6de6

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
3e5088f

Use raw data for value type
988e82a

AaronRobinsonMSFT reviewed Mar 13, 2026
View reviewed changes

am11 added 2 commits March 13, 2026 18:40

Address CR fb
68e943f

Merge remote-tracking branch 'upstream/main' into feature/MDCS-to-UCO…
dc0cc4a
…A-pattern

AaronRobinsonMSFT reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

Add comment explaining ulong usage
dd50f41

jkotas reviewed Mar 14, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/methodtable.cpp

Delete {G,S}setOHDelegate
5057a6a

jkotas reviewed Mar 14, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/class.h

am11 added 2 commits March 14, 2026 11:03

Update class.h
3ed9700

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
f1fc86a

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/clrtocomcall.cpp Outdated

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 16, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11 closed this Mar 19, 2026

am11 deleted the feature/MDCS-to-UCOA-pattern branch March 19, 2026 16:39

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comcallablewrapper.cpp Outdated

am11 restored the feature/MDCS-to-UCOA-pattern branch March 20, 2026 10:50

am11 reopened this Mar 20, 2026

am11 added 4 commits March 20, 2026 12:53

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
cdaee50

Address feedback
e4e5d2a

Add [RequiresUnsafe] attribute
a08de0d
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

Update StubHelpers.cs
5693443

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11and others added 3 commits March 20, 2026 14:57

Revert slot conversions
0f433ae

Update StubHelpers.cs
a2eb88b
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
563d118

AaronRobinsonMSFT reviewed Mar 20, 2026
View reviewed changes

jkotas reviewed Mar 20, 2026
View reviewed changes

am11 closed this Mar 20, 2026

am11 deleted the feature/MDCS-to-UCOA-pattern branch March 20, 2026 17:07

CopilotAI mentioned this pull request Mar 20, 2026
Convert more COM interop MethodDescCallSite to UnmanagedCallersOnly (UCO) #125849
Merged

github-actionsBot locked and limited conversation to collaborators Apr 20, 2026

Convert more COM interop MethodDescCallSite to UCO
96197f1

github-actionsBot added the area-VM-coreclr label Mar 12, 2026

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Mar 12, 2026

am11 mentioned this pull request Mar 12, 2026
Replace CallDescrWorker with UnmanagedCallersOnlyAttribute pattern #123864
Open
72 tasks

am11 added 2 commits March 13, 2026 02:41

Add guard
83f8dd6

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
3247c98

This was referenced Mar 13, 2026
MsQuic fails with QUIC_STATUS_OUT_OF_MEMORY on AzureLinux #123216
Closed
AOT precompile failed on ios-arm64: 'No space left on device' (exit code 1) #125107
Closed

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comconnectionpoints.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comcallablewrapper.cpp

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/runtimecallablewrapper.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/clrtocomcall.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11 added 3 commits March 13, 2026 15:46

Address CR fb
e4b6de6

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
3e5088f

Use raw data for value type
988e82a

AaronRobinsonMSFT reviewed Mar 13, 2026
View reviewed changes

am11 added 2 commits March 13, 2026 18:40

Address CR fb
68e943f

Merge remote-tracking branch 'upstream/main' into feature/MDCS-to-UCO…
dc0cc4a
…A-pattern

AaronRobinsonMSFT reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

Add comment explaining ulong usage
dd50f41

jkotas reviewed Mar 14, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/methodtable.cpp

Delete {G,S}setOHDelegate
5057a6a

jkotas reviewed Mar 14, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/class.h

am11 added 2 commits March 14, 2026 11:03

Update class.h
3ed9700

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
f1fc86a

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/clrtocomcall.cpp Outdated

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 16, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11 closed this Mar 19, 2026

am11 deleted the feature/MDCS-to-UCOA-pattern branch March 19, 2026 16:39

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comcallablewrapper.cpp Outdated

am11 restored the feature/MDCS-to-UCOA-pattern branch March 20, 2026 10:50

am11 reopened this Mar 20, 2026

am11 added 4 commits March 20, 2026 12:53

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
cdaee50

Address feedback
e4e5d2a

Add [RequiresUnsafe] attribute
a08de0d
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

Update StubHelpers.cs
5693443

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11and others added 3 commits March 20, 2026 14:57

Revert slot conversions
0f433ae

Update StubHelpers.cs
a2eb88b
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
563d118

AaronRobinsonMSFT reviewed Mar 20, 2026
View reviewed changes

jkotas reviewed Mar 20, 2026
View reviewed changes

am11 closed this Mar 20, 2026

am11 deleted the feature/MDCS-to-UCOA-pattern branch March 20, 2026 17:07

CopilotAI mentioned this pull request Mar 20, 2026
Convert more COM interop MethodDescCallSite to UnmanagedCallersOnly (UCO) #125849
Merged

github-actionsBot locked and limited conversation to collaborators Apr 20, 2026

Convert more COM interop MethodDescCallSite to UCO
96197f1

github-actionsBot added the area-VM-coreclr label Mar 12, 2026

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Mar 12, 2026

am11 mentioned this pull request Mar 12, 2026
Replace CallDescrWorker with UnmanagedCallersOnlyAttribute pattern #123864
Open
72 tasks

am11 added 2 commits March 13, 2026 02:41

Add guard
83f8dd6

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
3247c98

This was referenced Mar 13, 2026
MsQuic fails with QUIC_STATUS_OUT_OF_MEMORY on AzureLinux #123216
Closed
AOT precompile failed on ios-arm64: 'No space left on device' (exit code 1) #125107
Closed

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comconnectionpoints.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comcallablewrapper.cpp

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/runtimecallablewrapper.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/clrtocomcall.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11 added 3 commits March 13, 2026 15:46

Address CR fb
e4b6de6

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
3e5088f

Use raw data for value type
988e82a

AaronRobinsonMSFT reviewed Mar 13, 2026
View reviewed changes

am11 added 2 commits March 13, 2026 18:40

Address CR fb
68e943f

Merge remote-tracking branch 'upstream/main' into feature/MDCS-to-UCO…
dc0cc4a
…A-pattern

AaronRobinsonMSFT reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

Add comment explaining ulong usage
dd50f41

jkotas reviewed Mar 14, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/methodtable.cpp

Delete {G,S}setOHDelegate
5057a6a

jkotas reviewed Mar 14, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/class.h

am11 added 2 commits March 14, 2026 11:03

Update class.h
3ed9700

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
f1fc86a

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/clrtocomcall.cpp Outdated

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 16, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11 closed this Mar 19, 2026

am11 deleted the feature/MDCS-to-UCOA-pattern branch March 19, 2026 16:39

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comcallablewrapper.cpp Outdated

am11 restored the feature/MDCS-to-UCOA-pattern branch March 20, 2026 10:50

am11 reopened this Mar 20, 2026

am11 added 4 commits March 20, 2026 12:53

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
cdaee50

Address feedback
e4e5d2a

Add [RequiresUnsafe] attribute
a08de0d
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

Update StubHelpers.cs
5693443

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11and others added 3 commits March 20, 2026 14:57

Revert slot conversions
0f433ae

Update StubHelpers.cs
a2eb88b
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
563d118

AaronRobinsonMSFT reviewed Mar 20, 2026
View reviewed changes

jkotas reviewed Mar 20, 2026
View reviewed changes

am11 closed this Mar 20, 2026

am11 deleted the feature/MDCS-to-UCOA-pattern branch March 20, 2026 17:07

CopilotAI mentioned this pull request Mar 20, 2026
Convert more COM interop MethodDescCallSite to UnmanagedCallersOnly (UCO) #125849
Merged

github-actionsBot locked and limited conversation to collaborators Apr 20, 2026

Convert more COM interop MethodDescCallSite to UCO
96197f1

github-actionsBot added the area-VM-coreclr label Mar 12, 2026

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Mar 12, 2026

am11 mentioned this pull request Mar 12, 2026
Replace CallDescrWorker with UnmanagedCallersOnlyAttribute pattern #123864
Open
72 tasks

am11 added 2 commits March 13, 2026 02:41

Add guard
83f8dd6

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
3247c98

This was referenced Mar 13, 2026
MsQuic fails with QUIC_STATUS_OUT_OF_MEMORY on AzureLinux #123216
Closed
AOT precompile failed on ios-arm64: 'No space left on device' (exit code 1) #125107
Closed

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comconnectionpoints.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comcallablewrapper.cpp

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/runtimecallablewrapper.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/clrtocomcall.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11 added 3 commits March 13, 2026 15:46

Address CR fb
e4b6de6

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
3e5088f

Use raw data for value type
988e82a

AaronRobinsonMSFT reviewed Mar 13, 2026
View reviewed changes

am11 added 2 commits March 13, 2026 18:40

Address CR fb
68e943f

Merge remote-tracking branch 'upstream/main' into feature/MDCS-to-UCO…
dc0cc4a
…A-pattern

AaronRobinsonMSFT reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

Add comment explaining ulong usage
dd50f41

jkotas reviewed Mar 14, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/methodtable.cpp

Delete {G,S}setOHDelegate
5057a6a

jkotas reviewed Mar 14, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/class.h

am11 added 2 commits March 14, 2026 11:03

Update class.h
3ed9700

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
f1fc86a

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/clrtocomcall.cpp Outdated

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 16, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11 closed this Mar 19, 2026

am11 deleted the feature/MDCS-to-UCOA-pattern branch March 19, 2026 16:39

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comcallablewrapper.cpp Outdated

am11 restored the feature/MDCS-to-UCOA-pattern branch March 20, 2026 10:50

am11 reopened this Mar 20, 2026

am11 added 4 commits March 20, 2026 12:53

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
cdaee50

Address feedback
e4e5d2a

Add [RequiresUnsafe] attribute
a08de0d
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

Update StubHelpers.cs
5693443

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11and others added 3 commits March 20, 2026 14:57

Revert slot conversions
0f433ae

Update StubHelpers.cs
a2eb88b
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
563d118

AaronRobinsonMSFT reviewed Mar 20, 2026
View reviewed changes

jkotas reviewed Mar 20, 2026
View reviewed changes

am11 closed this Mar 20, 2026

am11 deleted the feature/MDCS-to-UCOA-pattern branch March 20, 2026 17:07

CopilotAI mentioned this pull request Mar 20, 2026
Convert more COM interop MethodDescCallSite to UnmanagedCallersOnly (UCO) #125849
Merged

github-actionsBot locked and limited conversation to collaborators Apr 20, 2026

Convert more COM interop MethodDescCallSite to UCO
96197f1

github-actionsBot added the area-VM-coreclr label Mar 12, 2026

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Mar 12, 2026

am11 mentioned this pull request Mar 12, 2026
Replace CallDescrWorker with UnmanagedCallersOnlyAttribute pattern #123864
Open
72 tasks

am11 added 2 commits March 13, 2026 02:41

Add guard
83f8dd6

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
3247c98

This was referenced Mar 13, 2026
MsQuic fails with QUIC_STATUS_OUT_OF_MEMORY on AzureLinux #123216
Closed
AOT precompile failed on ios-arm64: 'No space left on device' (exit code 1) #125107
Closed

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comconnectionpoints.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comcallablewrapper.cpp

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/runtimecallablewrapper.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/clrtocomcall.cpp Outdated

jkotas reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11 added 3 commits March 13, 2026 15:46

Address CR fb
e4b6de6

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
3e5088f

Use raw data for value type
988e82a

AaronRobinsonMSFT reviewed Mar 13, 2026
View reviewed changes

am11 added 2 commits March 13, 2026 18:40

Address CR fb
68e943f

Merge remote-tracking branch 'upstream/main' into feature/MDCS-to-UCO…
dc0cc4a
…A-pattern

AaronRobinsonMSFT reviewed Mar 13, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

Add comment explaining ulong usage
dd50f41

jkotas reviewed Mar 14, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/methodtable.cpp

Delete {G,S}setOHDelegate
5057a6a

jkotas reviewed Mar 14, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/class.h

am11 added 2 commits March 14, 2026 11:03

Update class.h
3ed9700

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
f1fc86a

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/clrtocomcall.cpp Outdated

jkotas reviewed Mar 15, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 16, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11 closed this Mar 19, 2026

am11 deleted the feature/MDCS-to-UCOA-pattern branch March 19, 2026 16:39

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/comcallablewrapper.cpp Outdated

am11 restored the feature/MDCS-to-UCOA-pattern branch March 20, 2026 10:50

am11 reopened this Mar 20, 2026

am11 added 4 commits March 20, 2026 12:53

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
cdaee50

Address feedback
e4e5d2a

Add [RequiresUnsafe] attribute
a08de0d
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

Update StubHelpers.cs
5693443

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

jkotas reviewed Mar 20, 2026
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs Outdated

am11and others added 3 commits March 20, 2026 14:57

Revert slot conversions
0f433ae

Update StubHelpers.cs
a2eb88b
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Merge branch 'main' into feature/MDCS-to-UCOA-pattern
563d118

AaronRobinsonMSFT reviewed Mar 20, 2026
View reviewed changes

jkotas reviewed Mar 20, 2026
View reviewed changes

am11 closed this Mar 20, 2026

am11 deleted the feature/MDCS-to-UCOA-pattern branch March 20, 2026 17:07

CopilotAI mentioned this pull request Mar 20, 2026
Convert more COM interop MethodDescCallSite to UnmanagedCallersOnly (UCO) #125849
Merged

github-actionsBot locked and limited conversation to collaborators Apr 20, 2026

	DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, SM_PtrObj_IntPtr_PtrObj_IntPtr_PtrObj_IntPtr_Bool_PtrException_RetVoid)
	DEFINE_METHOD(STUBHELPERS, INVOKE_CONNECTION_POINT_PROVIDER_METHOD, InvokeConnectionPointProviderMethod, NoSig)

Uh oh!

Conversation

am11 commented Mar 12, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas commented Mar 20, 2026

Uh oh!

Uh oh!

am11 commented Mar 20, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

am11 commented Mar 20, 2026

Uh oh!

jkotas commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

am11 commented Mar 12, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas commented Mar 20, 2026

Uh oh!

Uh oh!

am11 commented Mar 20, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!