Filter out SPMI metric diffs smaller than ±0.001% - #125684

Merged
EgorBo merged 6 commits into
mainfrom
copilot/fix-synchronous-metric-differences
Mar 19, 2026
Merged

Filter out SPMI metric diffs smaller than ±0.001%#125684
EgorBo merged 6 commits into
mainfrom
copilot/fix-synchronous-metric-differences

Conversation

CopilotAI commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Description

SPMI metric diff reporting shows noise as changes even when there are no actual code diffs. The write_metricdiff_markdown_summary function used a bare != equality check, so any tiny numeric variance was reported as significant.

Inlined an abs(compute_pct(...)) >= 0.01 threshold check directly in the list comprehension filter in superpmi.py to suppress metric diffs below ±0.01%. This is consistent with the existing is_significant_pct threshold pattern already used in write_tpdiff_markdown_summary.

A dummy comment change was also added to src/coreclr/jit/compiler.cpp to trigger the SPMI pipeline and validate the fix.

Original prompt

This section details on the original issue you should resolve

<issue_title>JIT: Metrics show changes even with no-diff changes</issue_title>
<issue_description>E.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=1339686&view=ms.vss-build-web.run-extensions-tab has no diffs, yet several metrics show up as changing. We probably should increase the expected variance of these metrics so that they don't show up unless they are actually changing.

cc @EgorBo </issue_description>

<agent_instructions>Please do not report diffs for SPMI metric diffs if the difference is smaller than +/- 0.01%</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Add a significance threshold to write_metricdiff_markdown_summary so
that metric diffs are only reported when the percentage change is at
least 0.01%. This prevents noise from expected variance when there
are no actual code diffs.
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
CopilotAI changed the title [WIP] [JIT] Fix metrics reporting for no-diff changesFilter out SPMI metric diffs smaller than ±0.01%Mar 17, 2026
CopilotAI requested a review from EgorBoMarch 17, 2026 21:47
Comment threadsrc/coreclr/scripts/superpmi.py Outdated
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
CopilotAI requested a review from EgorBoMarch 17, 2026 21:57
@EgorBo

Copy link
Copy Markdown
Member

@copilot please make a dummy change in jit to trigger the spmi pipeline

Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>

CopilotAI commented Mar 17, 2026

Copy link
Copy Markdown
ContributorAuthor

@copilot please make a dummy change in jit to trigger the spmi pipeline

Done in 97e1984 — added a comment line to compiler.cpp to trigger the SPMI pipeline.

@EgorBoEgorBo changed the title Filter out SPMI metric diffs smaller than ±0.01%Filter out SPMI metric diffs smaller than ±0.001%Mar 18, 2026
@EgorBo
EgorBo marked this pull request as ready for review March 18, 2026 22:30
CopilotAI review requested due to automatic review settings March 18, 2026 22:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce noise in SuperPMI “metricdiff” markdown reporting by suppressing insignificant metric changes that are due to tiny numeric variance rather than real codegen differences.

Changes:

  • Updated write_metricdiff_markdown_summary to filter metric diffs using a percent-change threshold instead of a raw != comparison.

Comment threadsrc/coreclr/scripts/superpmi.py
@EgorBo

Copy link
Copy Markdown
Member

@jakobbotsch PTAL. copilot has an idea how to fix the variance - it blames SPMI itself, the fact that it re-uses CompilationResult, but I don't like its fix yet, so I think having a threshold won't hurt.

@EgorBo
EgorBo requested a review from jakobbotschMarch 19, 2026 11:57
@EgorBo
EgorBo enabled auto-merge (squash) March 19, 2026 12:28
@EgorBo

Copy link
Copy Markdown
Member

/ba-g deadletter + #125757

@EgorBo
EgorBo merged commit a348be8 into mainMar 19, 2026
94 of 107 checks passed
@EgorBo
EgorBo deleted the copilot/fix-synchronous-metric-differences branch March 19, 2026 12:30
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 19, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

JIT: Metrics show changes even with no-diff changes

4 participants

@EgorBo@jakobbotsch
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Filter out SPMI metric diffs smaller than ±0.001% - #125684

Merged
EgorBo merged 6 commits into
mainfrom
copilot/fix-synchronous-metric-differences
Mar 19, 2026
Merged

Filter out SPMI metric diffs smaller than ±0.001%#125684
EgorBo merged 6 commits into
mainfrom
copilot/fix-synchronous-metric-differences

Conversation

CopilotAI commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Description

SPMI metric diff reporting shows noise as changes even when there are no actual code diffs. The write_metricdiff_markdown_summary function used a bare != equality check, so any tiny numeric variance was reported as significant.

Inlined an abs(compute_pct(...)) >= 0.01 threshold check directly in the list comprehension filter in superpmi.py to suppress metric diffs below ±0.01%. This is consistent with the existing is_significant_pct threshold pattern already used in write_tpdiff_markdown_summary.

A dummy comment change was also added to src/coreclr/jit/compiler.cpp to trigger the SPMI pipeline and validate the fix.

Original prompt

This section details on the original issue you should resolve

<issue_title>JIT: Metrics show changes even with no-diff changes</issue_title>
<issue_description>E.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=1339686&view=ms.vss-build-web.run-extensions-tab has no diffs, yet several metrics show up as changing. We probably should increase the expected variance of these metrics so that they don't show up unless they are actually changing.

cc @EgorBo </issue_description>

<agent_instructions>Please do not report diffs for SPMI metric diffs if the difference is smaller than +/- 0.01%</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Add a significance threshold to write_metricdiff_markdown_summary so
that metric diffs are only reported when the percentage change is at
least 0.01%. This prevents noise from expected variance when there
are no actual code diffs.
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
CopilotAI changed the title [WIP] [JIT] Fix metrics reporting for no-diff changesFilter out SPMI metric diffs smaller than ±0.01%Mar 17, 2026
CopilotAI requested a review from EgorBoMarch 17, 2026 21:47
Comment threadsrc/coreclr/scripts/superpmi.py Outdated
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
CopilotAI requested a review from EgorBoMarch 17, 2026 21:57
@EgorBo

Copy link
Copy Markdown
Member

@copilot please make a dummy change in jit to trigger the spmi pipeline

Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>

CopilotAI commented Mar 17, 2026

Copy link
Copy Markdown
ContributorAuthor

@copilot please make a dummy change in jit to trigger the spmi pipeline

Done in 97e1984 — added a comment line to compiler.cpp to trigger the SPMI pipeline.

@EgorBoEgorBo changed the title Filter out SPMI metric diffs smaller than ±0.01%Filter out SPMI metric diffs smaller than ±0.001%Mar 18, 2026
@EgorBo
EgorBo marked this pull request as ready for review March 18, 2026 22:30
CopilotAI review requested due to automatic review settings March 18, 2026 22:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce noise in SuperPMI “metricdiff” markdown reporting by suppressing insignificant metric changes that are due to tiny numeric variance rather than real codegen differences.

Changes:

  • Updated write_metricdiff_markdown_summary to filter metric diffs using a percent-change threshold instead of a raw != comparison.

Comment threadsrc/coreclr/scripts/superpmi.py
@EgorBo

Copy link
Copy Markdown
Member

@jakobbotsch PTAL. copilot has an idea how to fix the variance - it blames SPMI itself, the fact that it re-uses CompilationResult, but I don't like its fix yet, so I think having a threshold won't hurt.

@EgorBo
EgorBo requested a review from jakobbotschMarch 19, 2026 11:57
@EgorBo
EgorBo enabled auto-merge (squash) March 19, 2026 12:28
@EgorBo

Copy link
Copy Markdown
Member

/ba-g deadletter + #125757

@EgorBo
EgorBo merged commit a348be8 into mainMar 19, 2026
94 of 107 checks passed
@EgorBo
EgorBo deleted the copilot/fix-synchronous-metric-differences branch March 19, 2026 12:30
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 19, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

JIT: Metrics show changes even with no-diff changes

4 participants

@EgorBo@jakobbotsch
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Filter out SPMI metric diffs smaller than ±0.001% - #125684

Merged
EgorBo merged 6 commits into
mainfrom
copilot/fix-synchronous-metric-differences
Mar 19, 2026
Merged

Filter out SPMI metric diffs smaller than ±0.001%#125684
EgorBo merged 6 commits into
mainfrom
copilot/fix-synchronous-metric-differences

Conversation

CopilotAI commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Description

SPMI metric diff reporting shows noise as changes even when there are no actual code diffs. The write_metricdiff_markdown_summary function used a bare != equality check, so any tiny numeric variance was reported as significant.

Inlined an abs(compute_pct(...)) >= 0.01 threshold check directly in the list comprehension filter in superpmi.py to suppress metric diffs below ±0.01%. This is consistent with the existing is_significant_pct threshold pattern already used in write_tpdiff_markdown_summary.

A dummy comment change was also added to src/coreclr/jit/compiler.cpp to trigger the SPMI pipeline and validate the fix.

Original prompt

This section details on the original issue you should resolve

<issue_title>JIT: Metrics show changes even with no-diff changes</issue_title>
<issue_description>E.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=1339686&view=ms.vss-build-web.run-extensions-tab has no diffs, yet several metrics show up as changing. We probably should increase the expected variance of these metrics so that they don't show up unless they are actually changing.

cc @EgorBo </issue_description>

<agent_instructions>Please do not report diffs for SPMI metric diffs if the difference is smaller than +/- 0.01%</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Add a significance threshold to write_metricdiff_markdown_summary so
that metric diffs are only reported when the percentage change is at
least 0.01%. This prevents noise from expected variance when there
are no actual code diffs.
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
CopilotAI changed the title [WIP] [JIT] Fix metrics reporting for no-diff changesFilter out SPMI metric diffs smaller than ±0.01%Mar 17, 2026
CopilotAI requested a review from EgorBoMarch 17, 2026 21:47
Comment threadsrc/coreclr/scripts/superpmi.py Outdated
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
CopilotAI requested a review from EgorBoMarch 17, 2026 21:57
@EgorBo

Copy link
Copy Markdown
Member

@copilot please make a dummy change in jit to trigger the spmi pipeline

Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>

CopilotAI commented Mar 17, 2026

Copy link
Copy Markdown
ContributorAuthor

@copilot please make a dummy change in jit to trigger the spmi pipeline

Done in 97e1984 — added a comment line to compiler.cpp to trigger the SPMI pipeline.

@EgorBoEgorBo changed the title Filter out SPMI metric diffs smaller than ±0.01%Filter out SPMI metric diffs smaller than ±0.001%Mar 18, 2026
@EgorBo
EgorBo marked this pull request as ready for review March 18, 2026 22:30
CopilotAI review requested due to automatic review settings March 18, 2026 22:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce noise in SuperPMI “metricdiff” markdown reporting by suppressing insignificant metric changes that are due to tiny numeric variance rather than real codegen differences.

Changes:

  • Updated write_metricdiff_markdown_summary to filter metric diffs using a percent-change threshold instead of a raw != comparison.

Comment threadsrc/coreclr/scripts/superpmi.py
@EgorBo

Copy link
Copy Markdown
Member

@jakobbotsch PTAL. copilot has an idea how to fix the variance - it blames SPMI itself, the fact that it re-uses CompilationResult, but I don't like its fix yet, so I think having a threshold won't hurt.

@EgorBo
EgorBo requested a review from jakobbotschMarch 19, 2026 11:57
@EgorBo
EgorBo enabled auto-merge (squash) March 19, 2026 12:28
@EgorBo

Copy link
Copy Markdown
Member

/ba-g deadletter + #125757

@EgorBo
EgorBo merged commit a348be8 into mainMar 19, 2026
94 of 107 checks passed
@EgorBo
EgorBo deleted the copilot/fix-synchronous-metric-differences branch March 19, 2026 12:30
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 19, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

JIT: Metrics show changes even with no-diff changes

4 participants

@EgorBo@jakobbotsch
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Filter out SPMI metric diffs smaller than ±0.001% - #125684

Merged
EgorBo merged 6 commits into
mainfrom
copilot/fix-synchronous-metric-differences
Mar 19, 2026
Merged

Filter out SPMI metric diffs smaller than ±0.001%#125684
EgorBo merged 6 commits into
mainfrom
copilot/fix-synchronous-metric-differences

Conversation

CopilotAI commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Description

SPMI metric diff reporting shows noise as changes even when there are no actual code diffs. The write_metricdiff_markdown_summary function used a bare != equality check, so any tiny numeric variance was reported as significant.

Inlined an abs(compute_pct(...)) >= 0.01 threshold check directly in the list comprehension filter in superpmi.py to suppress metric diffs below ±0.01%. This is consistent with the existing is_significant_pct threshold pattern already used in write_tpdiff_markdown_summary.

A dummy comment change was also added to src/coreclr/jit/compiler.cpp to trigger the SPMI pipeline and validate the fix.

Original prompt

This section details on the original issue you should resolve

<issue_title>JIT: Metrics show changes even with no-diff changes</issue_title>
<issue_description>E.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=1339686&view=ms.vss-build-web.run-extensions-tab has no diffs, yet several metrics show up as changing. We probably should increase the expected variance of these metrics so that they don't show up unless they are actually changing.

cc @EgorBo </issue_description>

<agent_instructions>Please do not report diffs for SPMI metric diffs if the difference is smaller than +/- 0.01%</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Add a significance threshold to write_metricdiff_markdown_summary so
that metric diffs are only reported when the percentage change is at
least 0.01%. This prevents noise from expected variance when there
are no actual code diffs.
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
CopilotAI changed the title [WIP] [JIT] Fix metrics reporting for no-diff changesFilter out SPMI metric diffs smaller than ±0.01%Mar 17, 2026
CopilotAI requested a review from EgorBoMarch 17, 2026 21:47
Comment threadsrc/coreclr/scripts/superpmi.py Outdated
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
CopilotAI requested a review from EgorBoMarch 17, 2026 21:57
@EgorBo

Copy link
Copy Markdown
Member

@copilot please make a dummy change in jit to trigger the spmi pipeline

Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>

CopilotAI commented Mar 17, 2026

Copy link
Copy Markdown
ContributorAuthor

@copilot please make a dummy change in jit to trigger the spmi pipeline

Done in 97e1984 — added a comment line to compiler.cpp to trigger the SPMI pipeline.

@EgorBoEgorBo changed the title Filter out SPMI metric diffs smaller than ±0.01%Filter out SPMI metric diffs smaller than ±0.001%Mar 18, 2026
@EgorBo
EgorBo marked this pull request as ready for review March 18, 2026 22:30
CopilotAI review requested due to automatic review settings March 18, 2026 22:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce noise in SuperPMI “metricdiff” markdown reporting by suppressing insignificant metric changes that are due to tiny numeric variance rather than real codegen differences.

Changes:

  • Updated write_metricdiff_markdown_summary to filter metric diffs using a percent-change threshold instead of a raw != comparison.

Comment threadsrc/coreclr/scripts/superpmi.py
@EgorBo

Copy link
Copy Markdown
Member

@jakobbotsch PTAL. copilot has an idea how to fix the variance - it blames SPMI itself, the fact that it re-uses CompilationResult, but I don't like its fix yet, so I think having a threshold won't hurt.

@EgorBo
EgorBo requested a review from jakobbotschMarch 19, 2026 11:57
@EgorBo
EgorBo enabled auto-merge (squash) March 19, 2026 12:28
@EgorBo

Copy link
Copy Markdown
Member

/ba-g deadletter + #125757

@EgorBo
EgorBo merged commit a348be8 into mainMar 19, 2026
94 of 107 checks passed
@EgorBo
EgorBo deleted the copilot/fix-synchronous-metric-differences branch March 19, 2026 12:30
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 19, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

JIT: Metrics show changes even with no-diff changes

4 participants

@EgorBo@jakobbotsch
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Filter out SPMI metric diffs smaller than ±0.001% - #125684

Merged
EgorBo merged 6 commits into
mainfrom
copilot/fix-synchronous-metric-differences
Mar 19, 2026
Merged

Filter out SPMI metric diffs smaller than ±0.001%#125684
EgorBo merged 6 commits into
mainfrom
copilot/fix-synchronous-metric-differences

Conversation

CopilotAI commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Description

SPMI metric diff reporting shows noise as changes even when there are no actual code diffs. The write_metricdiff_markdown_summary function used a bare != equality check, so any tiny numeric variance was reported as significant.

Inlined an abs(compute_pct(...)) >= 0.01 threshold check directly in the list comprehension filter in superpmi.py to suppress metric diffs below ±0.01%. This is consistent with the existing is_significant_pct threshold pattern already used in write_tpdiff_markdown_summary.

A dummy comment change was also added to src/coreclr/jit/compiler.cpp to trigger the SPMI pipeline and validate the fix.

Original prompt

This section details on the original issue you should resolve

<issue_title>JIT: Metrics show changes even with no-diff changes</issue_title>
<issue_description>E.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=1339686&view=ms.vss-build-web.run-extensions-tab has no diffs, yet several metrics show up as changing. We probably should increase the expected variance of these metrics so that they don't show up unless they are actually changing.

cc @EgorBo </issue_description>

<agent_instructions>Please do not report diffs for SPMI metric diffs if the difference is smaller than +/- 0.01%</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Add a significance threshold to write_metricdiff_markdown_summary so
that metric diffs are only reported when the percentage change is at
least 0.01%. This prevents noise from expected variance when there
are no actual code diffs.
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
CopilotAI changed the title [WIP] [JIT] Fix metrics reporting for no-diff changesFilter out SPMI metric diffs smaller than ±0.01%Mar 17, 2026
CopilotAI requested a review from EgorBoMarch 17, 2026 21:47
Comment threadsrc/coreclr/scripts/superpmi.py Outdated
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
CopilotAI requested a review from EgorBoMarch 17, 2026 21:57
@EgorBo

Copy link
Copy Markdown
Member

@copilot please make a dummy change in jit to trigger the spmi pipeline

Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>

CopilotAI commented Mar 17, 2026

Copy link
Copy Markdown
ContributorAuthor

@copilot please make a dummy change in jit to trigger the spmi pipeline

Done in 97e1984 — added a comment line to compiler.cpp to trigger the SPMI pipeline.

@EgorBoEgorBo changed the title Filter out SPMI metric diffs smaller than ±0.01%Filter out SPMI metric diffs smaller than ±0.001%Mar 18, 2026
@EgorBo
EgorBo marked this pull request as ready for review March 18, 2026 22:30
CopilotAI review requested due to automatic review settings March 18, 2026 22:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce noise in SuperPMI “metricdiff” markdown reporting by suppressing insignificant metric changes that are due to tiny numeric variance rather than real codegen differences.

Changes:

  • Updated write_metricdiff_markdown_summary to filter metric diffs using a percent-change threshold instead of a raw != comparison.

Comment threadsrc/coreclr/scripts/superpmi.py
@EgorBo

Copy link
Copy Markdown
Member

@jakobbotsch PTAL. copilot has an idea how to fix the variance - it blames SPMI itself, the fact that it re-uses CompilationResult, but I don't like its fix yet, so I think having a threshold won't hurt.

@EgorBo
EgorBo requested a review from jakobbotschMarch 19, 2026 11:57
@EgorBo
EgorBo enabled auto-merge (squash) March 19, 2026 12:28
@EgorBo

Copy link
Copy Markdown
Member

/ba-g deadletter + #125757

@EgorBo
EgorBo merged commit a348be8 into mainMar 19, 2026
94 of 107 checks passed
@EgorBo
EgorBo deleted the copilot/fix-synchronous-metric-differences branch March 19, 2026 12:30
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 19, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

JIT: Metrics show changes even with no-diff changes

4 participants

@EgorBo@jakobbotsch
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Filter out SPMI metric diffs smaller than ±0.001% - #125684

Merged
EgorBo merged 6 commits into
mainfrom
copilot/fix-synchronous-metric-differences
Mar 19, 2026
Merged

Filter out SPMI metric diffs smaller than ±0.001%#125684
EgorBo merged 6 commits into
mainfrom
copilot/fix-synchronous-metric-differences

Conversation

CopilotAI commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Description

SPMI metric diff reporting shows noise as changes even when there are no actual code diffs. The write_metricdiff_markdown_summary function used a bare != equality check, so any tiny numeric variance was reported as significant.

Inlined an abs(compute_pct(...)) >= 0.01 threshold check directly in the list comprehension filter in superpmi.py to suppress metric diffs below ±0.01%. This is consistent with the existing is_significant_pct threshold pattern already used in write_tpdiff_markdown_summary.

A dummy comment change was also added to src/coreclr/jit/compiler.cpp to trigger the SPMI pipeline and validate the fix.

Original prompt

This section details on the original issue you should resolve

<issue_title>JIT: Metrics show changes even with no-diff changes</issue_title>
<issue_description>E.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=1339686&view=ms.vss-build-web.run-extensions-tab has no diffs, yet several metrics show up as changing. We probably should increase the expected variance of these metrics so that they don't show up unless they are actually changing.

cc @EgorBo </issue_description>

<agent_instructions>Please do not report diffs for SPMI metric diffs if the difference is smaller than +/- 0.01%</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Add a significance threshold to write_metricdiff_markdown_summary so
that metric diffs are only reported when the percentage change is at
least 0.01%. This prevents noise from expected variance when there
are no actual code diffs.
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
CopilotAI changed the title [WIP] [JIT] Fix metrics reporting for no-diff changesFilter out SPMI metric diffs smaller than ±0.01%Mar 17, 2026
CopilotAI requested a review from EgorBoMarch 17, 2026 21:47
Comment threadsrc/coreclr/scripts/superpmi.py Outdated
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
CopilotAI requested a review from EgorBoMarch 17, 2026 21:57
@EgorBo

Copy link
Copy Markdown
Member

@copilot please make a dummy change in jit to trigger the spmi pipeline

Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>

CopilotAI commented Mar 17, 2026

Copy link
Copy Markdown
ContributorAuthor

@copilot please make a dummy change in jit to trigger the spmi pipeline

Done in 97e1984 — added a comment line to compiler.cpp to trigger the SPMI pipeline.

@EgorBoEgorBo changed the title Filter out SPMI metric diffs smaller than ±0.01%Filter out SPMI metric diffs smaller than ±0.001%Mar 18, 2026
@EgorBo
EgorBo marked this pull request as ready for review March 18, 2026 22:30
CopilotAI review requested due to automatic review settings March 18, 2026 22:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce noise in SuperPMI “metricdiff” markdown reporting by suppressing insignificant metric changes that are due to tiny numeric variance rather than real codegen differences.

Changes:

  • Updated write_metricdiff_markdown_summary to filter metric diffs using a percent-change threshold instead of a raw != comparison.

Comment threadsrc/coreclr/scripts/superpmi.py
@EgorBo

Copy link
Copy Markdown
Member

@jakobbotsch PTAL. copilot has an idea how to fix the variance - it blames SPMI itself, the fact that it re-uses CompilationResult, but I don't like its fix yet, so I think having a threshold won't hurt.

@EgorBo
EgorBo requested a review from jakobbotschMarch 19, 2026 11:57
@EgorBo
EgorBo enabled auto-merge (squash) March 19, 2026 12:28
@EgorBo

Copy link
Copy Markdown
Member

/ba-g deadletter + #125757

@EgorBo
EgorBo merged commit a348be8 into mainMar 19, 2026
94 of 107 checks passed
@EgorBo
EgorBo deleted the copilot/fix-synchronous-metric-differences branch March 19, 2026 12:30
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 19, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

JIT: Metrics show changes even with no-diff changes

4 participants

@EgorBo@jakobbotsch
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Filter out SPMI metric diffs smaller than ±0.001% - #125684

Merged
EgorBo merged 6 commits into
mainfrom
copilot/fix-synchronous-metric-differences
Mar 19, 2026
Merged

Filter out SPMI metric diffs smaller than ±0.001%#125684
EgorBo merged 6 commits into
mainfrom
copilot/fix-synchronous-metric-differences

Conversation

CopilotAI commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Description

SPMI metric diff reporting shows noise as changes even when there are no actual code diffs. The write_metricdiff_markdown_summary function used a bare != equality check, so any tiny numeric variance was reported as significant.

Inlined an abs(compute_pct(...)) >= 0.01 threshold check directly in the list comprehension filter in superpmi.py to suppress metric diffs below ±0.01%. This is consistent with the existing is_significant_pct threshold pattern already used in write_tpdiff_markdown_summary.

A dummy comment change was also added to src/coreclr/jit/compiler.cpp to trigger the SPMI pipeline and validate the fix.

Original prompt

This section details on the original issue you should resolve

<issue_title>JIT: Metrics show changes even with no-diff changes</issue_title>
<issue_description>E.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=1339686&view=ms.vss-build-web.run-extensions-tab has no diffs, yet several metrics show up as changing. We probably should increase the expected variance of these metrics so that they don't show up unless they are actually changing.

cc @EgorBo </issue_description>

<agent_instructions>Please do not report diffs for SPMI metric diffs if the difference is smaller than +/- 0.01%</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Add a significance threshold to write_metricdiff_markdown_summary so
that metric diffs are only reported when the percentage change is at
least 0.01%. This prevents noise from expected variance when there
are no actual code diffs.
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
CopilotAI changed the title [WIP] [JIT] Fix metrics reporting for no-diff changesFilter out SPMI metric diffs smaller than ±0.01%Mar 17, 2026
CopilotAI requested a review from EgorBoMarch 17, 2026 21:47
Comment threadsrc/coreclr/scripts/superpmi.py Outdated
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
CopilotAI requested a review from EgorBoMarch 17, 2026 21:57
@EgorBo

Copy link
Copy Markdown
Member

@copilot please make a dummy change in jit to trigger the spmi pipeline

Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>

CopilotAI commented Mar 17, 2026

Copy link
Copy Markdown
ContributorAuthor

@copilot please make a dummy change in jit to trigger the spmi pipeline

Done in 97e1984 — added a comment line to compiler.cpp to trigger the SPMI pipeline.

@EgorBoEgorBo changed the title Filter out SPMI metric diffs smaller than ±0.01%Filter out SPMI metric diffs smaller than ±0.001%Mar 18, 2026
@EgorBo
EgorBo marked this pull request as ready for review March 18, 2026 22:30
CopilotAI review requested due to automatic review settings March 18, 2026 22:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce noise in SuperPMI “metricdiff” markdown reporting by suppressing insignificant metric changes that are due to tiny numeric variance rather than real codegen differences.

Changes:

  • Updated write_metricdiff_markdown_summary to filter metric diffs using a percent-change threshold instead of a raw != comparison.

Comment threadsrc/coreclr/scripts/superpmi.py
@EgorBo

Copy link
Copy Markdown
Member

@jakobbotsch PTAL. copilot has an idea how to fix the variance - it blames SPMI itself, the fact that it re-uses CompilationResult, but I don't like its fix yet, so I think having a threshold won't hurt.

@EgorBo
EgorBo requested a review from jakobbotschMarch 19, 2026 11:57
@EgorBo
EgorBo enabled auto-merge (squash) March 19, 2026 12:28
@EgorBo

Copy link
Copy Markdown
Member

/ba-g deadletter + #125757

@EgorBo
EgorBo merged commit a348be8 into mainMar 19, 2026
94 of 107 checks passed
@EgorBo
EgorBo deleted the copilot/fix-synchronous-metric-differences branch March 19, 2026 12:30
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 19, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

JIT: Metrics show changes even with no-diff changes

4 participants

@EgorBo@jakobbotsch
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Filter out SPMI metric diffs smaller than ±0.001% - #125684

Merged
EgorBo merged 6 commits into
mainfrom
copilot/fix-synchronous-metric-differences
Mar 19, 2026
Merged

Filter out SPMI metric diffs smaller than ±0.001%#125684
EgorBo merged 6 commits into
mainfrom
copilot/fix-synchronous-metric-differences

Conversation

CopilotAI commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Description

SPMI metric diff reporting shows noise as changes even when there are no actual code diffs. The write_metricdiff_markdown_summary function used a bare != equality check, so any tiny numeric variance was reported as significant.

Inlined an abs(compute_pct(...)) >= 0.01 threshold check directly in the list comprehension filter in superpmi.py to suppress metric diffs below ±0.01%. This is consistent with the existing is_significant_pct threshold pattern already used in write_tpdiff_markdown_summary.

A dummy comment change was also added to src/coreclr/jit/compiler.cpp to trigger the SPMI pipeline and validate the fix.

Original prompt

This section details on the original issue you should resolve

<issue_title>JIT: Metrics show changes even with no-diff changes</issue_title>
<issue_description>E.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=1339686&view=ms.vss-build-web.run-extensions-tab has no diffs, yet several metrics show up as changing. We probably should increase the expected variance of these metrics so that they don't show up unless they are actually changing.

cc @EgorBo </issue_description>

<agent_instructions>Please do not report diffs for SPMI metric diffs if the difference is smaller than +/- 0.01%</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Add a significance threshold to write_metricdiff_markdown_summary so
that metric diffs are only reported when the percentage change is at
least 0.01%. This prevents noise from expected variance when there
are no actual code diffs.
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
CopilotAI changed the title [WIP] [JIT] Fix metrics reporting for no-diff changesFilter out SPMI metric diffs smaller than ±0.01%Mar 17, 2026
CopilotAI requested a review from EgorBoMarch 17, 2026 21:47
Comment threadsrc/coreclr/scripts/superpmi.py Outdated
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
CopilotAI requested a review from EgorBoMarch 17, 2026 21:57
@EgorBo

Copy link
Copy Markdown
Member

@copilot please make a dummy change in jit to trigger the spmi pipeline

Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>

CopilotAI commented Mar 17, 2026

Copy link
Copy Markdown
ContributorAuthor

@copilot please make a dummy change in jit to trigger the spmi pipeline

Done in 97e1984 — added a comment line to compiler.cpp to trigger the SPMI pipeline.

@EgorBoEgorBo changed the title Filter out SPMI metric diffs smaller than ±0.01%Filter out SPMI metric diffs smaller than ±0.001%Mar 18, 2026
@EgorBo
EgorBo marked this pull request as ready for review March 18, 2026 22:30
CopilotAI review requested due to automatic review settings March 18, 2026 22:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce noise in SuperPMI “metricdiff” markdown reporting by suppressing insignificant metric changes that are due to tiny numeric variance rather than real codegen differences.

Changes:

  • Updated write_metricdiff_markdown_summary to filter metric diffs using a percent-change threshold instead of a raw != comparison.

Comment threadsrc/coreclr/scripts/superpmi.py
@EgorBo

Copy link
Copy Markdown
Member

@jakobbotsch PTAL. copilot has an idea how to fix the variance - it blames SPMI itself, the fact that it re-uses CompilationResult, but I don't like its fix yet, so I think having a threshold won't hurt.

@EgorBo
EgorBo requested a review from jakobbotschMarch 19, 2026 11:57
@EgorBo
EgorBo enabled auto-merge (squash) March 19, 2026 12:28
@EgorBo

Copy link
Copy Markdown
Member

/ba-g deadletter + #125757

@EgorBo
EgorBo merged commit a348be8 into mainMar 19, 2026
94 of 107 checks passed
@EgorBo
EgorBo deleted the copilot/fix-synchronous-metric-differences branch March 19, 2026 12:30
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 19, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

JIT: Metrics show changes even with no-diff changes

4 participants

@EgorBo@jakobbotsch