Increase FileSystemWatcher test event timeout to 1000ms by lewing · Pull Request #125744 · dotnet/runtime

lewing · 2026-03-18T19:44:55Z

Increase WaitForExpectedEventTimeout from 500ms to 1000ms per @tmds suggestion in #125740 (comment).

The inotify refactor (#117148) changed stop/start timing for watches, which can delay event delivery under stress conditions. The 500ms timeout is too tight for jitstress runs on slower hardware (arm32), causing false failures in SymbolicLink tests that are being incorrectly attributed to #103630.

This is a single constant change that affects 94 tests using the default ExpectEvent timeout. It should help distinguish timing issues from functional bugs.

Ref: #125737, #125740

/cc @tmds @adamsitnik @jozkee

The inotify refactor (dotnet#117148) changed stop/start timing for watches, which can delay event delivery under stress. The 500ms timeout is too tight for jitstress runs on slower hardware (arm32), causing false failures in SymbolicLink tests. Double the timeout from 500ms to 1000ms to better distinguish timing issues from functional bugs. This affects 94 tests that use the default ExpectEvent timeout. Ref: dotnet#125737 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-03-18T19:46:11Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR increases the default wait timeout used by FileSystemWatcher test utilities to reduce Linux (notably arm32 jitstress) timing-related flakiness after the inotify refactor.

Changes:

Increase WaitForExpectedEventTimeout from 500ms to 1000ms in the FileSystemWatcher test base helper.

Comments suppressed due to low confidence (1)

src/libraries/System.IO.FileSystem.Watcher/tests/Utility/FileSystemWatcherTest.cs:28

Raising WaitForExpectedEventTimeout will also increase the default wait for negative assertions and fixed sleeps that use this constant (e.g., ExpectNoEvent has a default timeout = WaitForExpectedEventTimeout, and some tests call Thread.Sleep(WaitForExpectedEventTimeout)). That can add ~500ms per such call to successful test runs. Consider keeping WaitForExpectedEventTimeout scoped to expected events only (e.g., change ExpectNoEvent’s default to WaitForUnexpectedEventTimeout, or introduce a separate constant for the longer expected-event wait) so the flakiness fix doesn’t unnecessarily slow the suite.

 public const int WaitForExpectedEventTimeout = 1000; // ms to wait for an event to happen
public const int LongWaitTimeout = 50000; // ms to wait for an event that takes a longer time than the average operation
public const int SubsequentExpectedWait = 10; // ms to wait for checks that occur after the first.
public const int WaitForExpectedEventTimeout_NoRetry = 3000;// ms to wait for an event that isn't surrounded by a retry.
public const int WaitForUnexpectedEventTimeout = 150; // ms to wait for a non-expected event.

You can also share your feedback on Copilot code review. Take the survey.

adamsitnik

LGTM, big thanks for fixing it @lewing !

lewing · 2026-03-19T01:29:19Z

/ba-g failures are infrastructure and actively being resolved

lewing · 2026-03-18T19:44:55Z

Increase WaitForExpectedEventTimeout from 500ms to 1000ms per @tmds suggestion in #125740 (comment).

The inotify refactor (#117148) changed stop/start timing for watches, which can delay event delivery under stress conditions. The 500ms timeout is too tight for jitstress runs on slower hardware (arm32), causing false failures in SymbolicLink tests that are being incorrectly attributed to #103630.

This is a single constant change that affects 94 tests using the default ExpectEvent timeout. It should help distinguish timing issues from functional bugs.

Ref: #125737, #125740

/cc @tmds @adamsitnik @jozkee

The inotify refactor (dotnet#117148) changed stop/start timing for watches, which can delay event delivery under stress. The 500ms timeout is too tight for jitstress runs on slower hardware (arm32), causing false failures in SymbolicLink tests. Double the timeout from 500ms to 1000ms to better distinguish timing issues from functional bugs. This affects 94 tests that use the default ExpectEvent timeout. Ref: dotnet#125737 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-03-18T19:46:11Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR increases the default wait timeout used by FileSystemWatcher test utilities to reduce Linux (notably arm32 jitstress) timing-related flakiness after the inotify refactor.

Changes:

Increase WaitForExpectedEventTimeout from 500ms to 1000ms in the FileSystemWatcher test base helper.

Comments suppressed due to low confidence (1)

src/libraries/System.IO.FileSystem.Watcher/tests/Utility/FileSystemWatcherTest.cs:28

Raising WaitForExpectedEventTimeout will also increase the default wait for negative assertions and fixed sleeps that use this constant (e.g., ExpectNoEvent has a default timeout = WaitForExpectedEventTimeout, and some tests call Thread.Sleep(WaitForExpectedEventTimeout)). That can add ~500ms per such call to successful test runs. Consider keeping WaitForExpectedEventTimeout scoped to expected events only (e.g., change ExpectNoEvent’s default to WaitForUnexpectedEventTimeout, or introduce a separate constant for the longer expected-event wait) so the flakiness fix doesn’t unnecessarily slow the suite.

 public const int WaitForExpectedEventTimeout = 1000; // ms to wait for an event to happen
public const int LongWaitTimeout = 50000; // ms to wait for an event that takes a longer time than the average operation
public const int SubsequentExpectedWait = 10; // ms to wait for checks that occur after the first.
public const int WaitForExpectedEventTimeout_NoRetry = 3000;// ms to wait for an event that isn't surrounded by a retry.
public const int WaitForUnexpectedEventTimeout = 150; // ms to wait for a non-expected event.

You can also share your feedback on Copilot code review. Take the survey.

adamsitnik

LGTM, big thanks for fixing it @lewing !

lewing · 2026-03-19T01:29:19Z

/ba-g failures are infrastructure and actively being resolved

lewing · 2026-03-18T19:44:55Z

Increase WaitForExpectedEventTimeout from 500ms to 1000ms per @tmds suggestion in #125740 (comment).

The inotify refactor (#117148) changed stop/start timing for watches, which can delay event delivery under stress conditions. The 500ms timeout is too tight for jitstress runs on slower hardware (arm32), causing false failures in SymbolicLink tests that are being incorrectly attributed to #103630.

This is a single constant change that affects 94 tests using the default ExpectEvent timeout. It should help distinguish timing issues from functional bugs.

Ref: #125737, #125740

/cc @tmds @adamsitnik @jozkee

The inotify refactor (dotnet#117148) changed stop/start timing for watches, which can delay event delivery under stress. The 500ms timeout is too tight for jitstress runs on slower hardware (arm32), causing false failures in SymbolicLink tests. Double the timeout from 500ms to 1000ms to better distinguish timing issues from functional bugs. This affects 94 tests that use the default ExpectEvent timeout. Ref: dotnet#125737 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-03-18T19:46:11Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR increases the default wait timeout used by FileSystemWatcher test utilities to reduce Linux (notably arm32 jitstress) timing-related flakiness after the inotify refactor.

Changes:

Increase WaitForExpectedEventTimeout from 500ms to 1000ms in the FileSystemWatcher test base helper.

Comments suppressed due to low confidence (1)

src/libraries/System.IO.FileSystem.Watcher/tests/Utility/FileSystemWatcherTest.cs:28

Raising WaitForExpectedEventTimeout will also increase the default wait for negative assertions and fixed sleeps that use this constant (e.g., ExpectNoEvent has a default timeout = WaitForExpectedEventTimeout, and some tests call Thread.Sleep(WaitForExpectedEventTimeout)). That can add ~500ms per such call to successful test runs. Consider keeping WaitForExpectedEventTimeout scoped to expected events only (e.g., change ExpectNoEvent’s default to WaitForUnexpectedEventTimeout, or introduce a separate constant for the longer expected-event wait) so the flakiness fix doesn’t unnecessarily slow the suite.

 public const int WaitForExpectedEventTimeout = 1000; // ms to wait for an event to happen
public const int LongWaitTimeout = 50000; // ms to wait for an event that takes a longer time than the average operation
public const int SubsequentExpectedWait = 10; // ms to wait for checks that occur after the first.
public const int WaitForExpectedEventTimeout_NoRetry = 3000;// ms to wait for an event that isn't surrounded by a retry.
public const int WaitForUnexpectedEventTimeout = 150; // ms to wait for a non-expected event.

You can also share your feedback on Copilot code review. Take the survey.

adamsitnik

LGTM, big thanks for fixing it @lewing !

lewing · 2026-03-19T01:29:19Z

/ba-g failures are infrastructure and actively being resolved

lewing · 2026-03-18T19:44:55Z

Increase WaitForExpectedEventTimeout from 500ms to 1000ms per @tmds suggestion in #125740 (comment).

The inotify refactor (#117148) changed stop/start timing for watches, which can delay event delivery under stress conditions. The 500ms timeout is too tight for jitstress runs on slower hardware (arm32), causing false failures in SymbolicLink tests that are being incorrectly attributed to #103630.

This is a single constant change that affects 94 tests using the default ExpectEvent timeout. It should help distinguish timing issues from functional bugs.

Ref: #125737, #125740

/cc @tmds @adamsitnik @jozkee

The inotify refactor (dotnet#117148) changed stop/start timing for watches, which can delay event delivery under stress. The 500ms timeout is too tight for jitstress runs on slower hardware (arm32), causing false failures in SymbolicLink tests. Double the timeout from 500ms to 1000ms to better distinguish timing issues from functional bugs. This affects 94 tests that use the default ExpectEvent timeout. Ref: dotnet#125737 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-03-18T19:46:11Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR increases the default wait timeout used by FileSystemWatcher test utilities to reduce Linux (notably arm32 jitstress) timing-related flakiness after the inotify refactor.

Changes:

Increase WaitForExpectedEventTimeout from 500ms to 1000ms in the FileSystemWatcher test base helper.

Comments suppressed due to low confidence (1)

src/libraries/System.IO.FileSystem.Watcher/tests/Utility/FileSystemWatcherTest.cs:28

Raising WaitForExpectedEventTimeout will also increase the default wait for negative assertions and fixed sleeps that use this constant (e.g., ExpectNoEvent has a default timeout = WaitForExpectedEventTimeout, and some tests call Thread.Sleep(WaitForExpectedEventTimeout)). That can add ~500ms per such call to successful test runs. Consider keeping WaitForExpectedEventTimeout scoped to expected events only (e.g., change ExpectNoEvent’s default to WaitForUnexpectedEventTimeout, or introduce a separate constant for the longer expected-event wait) so the flakiness fix doesn’t unnecessarily slow the suite.

 public const int WaitForExpectedEventTimeout = 1000; // ms to wait for an event to happen
public const int LongWaitTimeout = 50000; // ms to wait for an event that takes a longer time than the average operation
public const int SubsequentExpectedWait = 10; // ms to wait for checks that occur after the first.
public const int WaitForExpectedEventTimeout_NoRetry = 3000;// ms to wait for an event that isn't surrounded by a retry.
public const int WaitForUnexpectedEventTimeout = 150; // ms to wait for a non-expected event.

You can also share your feedback on Copilot code review. Take the survey.

adamsitnik

LGTM, big thanks for fixing it @lewing !

lewing · 2026-03-19T01:29:19Z

/ba-g failures are infrastructure and actively being resolved

lewing · 2026-03-18T19:44:55Z

Increase WaitForExpectedEventTimeout from 500ms to 1000ms per @tmds suggestion in #125740 (comment).

The inotify refactor (#117148) changed stop/start timing for watches, which can delay event delivery under stress conditions. The 500ms timeout is too tight for jitstress runs on slower hardware (arm32), causing false failures in SymbolicLink tests that are being incorrectly attributed to #103630.

This is a single constant change that affects 94 tests using the default ExpectEvent timeout. It should help distinguish timing issues from functional bugs.

Ref: #125737, #125740

/cc @tmds @adamsitnik @jozkee

The inotify refactor (dotnet#117148) changed stop/start timing for watches, which can delay event delivery under stress. The 500ms timeout is too tight for jitstress runs on slower hardware (arm32), causing false failures in SymbolicLink tests. Double the timeout from 500ms to 1000ms to better distinguish timing issues from functional bugs. This affects 94 tests that use the default ExpectEvent timeout. Ref: dotnet#125737 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-03-18T19:46:11Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR increases the default wait timeout used by FileSystemWatcher test utilities to reduce Linux (notably arm32 jitstress) timing-related flakiness after the inotify refactor.

Changes:

Increase WaitForExpectedEventTimeout from 500ms to 1000ms in the FileSystemWatcher test base helper.

Comments suppressed due to low confidence (1)

src/libraries/System.IO.FileSystem.Watcher/tests/Utility/FileSystemWatcherTest.cs:28

Raising WaitForExpectedEventTimeout will also increase the default wait for negative assertions and fixed sleeps that use this constant (e.g., ExpectNoEvent has a default timeout = WaitForExpectedEventTimeout, and some tests call Thread.Sleep(WaitForExpectedEventTimeout)). That can add ~500ms per such call to successful test runs. Consider keeping WaitForExpectedEventTimeout scoped to expected events only (e.g., change ExpectNoEvent’s default to WaitForUnexpectedEventTimeout, or introduce a separate constant for the longer expected-event wait) so the flakiness fix doesn’t unnecessarily slow the suite.

 public const int WaitForExpectedEventTimeout = 1000; // ms to wait for an event to happen
public const int LongWaitTimeout = 50000; // ms to wait for an event that takes a longer time than the average operation
public const int SubsequentExpectedWait = 10; // ms to wait for checks that occur after the first.
public const int WaitForExpectedEventTimeout_NoRetry = 3000;// ms to wait for an event that isn't surrounded by a retry.
public const int WaitForUnexpectedEventTimeout = 150; // ms to wait for a non-expected event.

You can also share your feedback on Copilot code review. Take the survey.

adamsitnik

LGTM, big thanks for fixing it @lewing !

lewing · 2026-03-19T01:29:19Z

/ba-g failures are infrastructure and actively being resolved

lewing · 2026-03-18T19:44:55Z

Increase WaitForExpectedEventTimeout from 500ms to 1000ms per @tmds suggestion in #125740 (comment).

The inotify refactor (#117148) changed stop/start timing for watches, which can delay event delivery under stress conditions. The 500ms timeout is too tight for jitstress runs on slower hardware (arm32), causing false failures in SymbolicLink tests that are being incorrectly attributed to #103630.

This is a single constant change that affects 94 tests using the default ExpectEvent timeout. It should help distinguish timing issues from functional bugs.

Ref: #125737, #125740

/cc @tmds @adamsitnik @jozkee

The inotify refactor (dotnet#117148) changed stop/start timing for watches, which can delay event delivery under stress. The 500ms timeout is too tight for jitstress runs on slower hardware (arm32), causing false failures in SymbolicLink tests. Double the timeout from 500ms to 1000ms to better distinguish timing issues from functional bugs. This affects 94 tests that use the default ExpectEvent timeout. Ref: dotnet#125737 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-03-18T19:46:11Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR increases the default wait timeout used by FileSystemWatcher test utilities to reduce Linux (notably arm32 jitstress) timing-related flakiness after the inotify refactor.

Changes:

Increase WaitForExpectedEventTimeout from 500ms to 1000ms in the FileSystemWatcher test base helper.

Comments suppressed due to low confidence (1)

src/libraries/System.IO.FileSystem.Watcher/tests/Utility/FileSystemWatcherTest.cs:28

Raising WaitForExpectedEventTimeout will also increase the default wait for negative assertions and fixed sleeps that use this constant (e.g., ExpectNoEvent has a default timeout = WaitForExpectedEventTimeout, and some tests call Thread.Sleep(WaitForExpectedEventTimeout)). That can add ~500ms per such call to successful test runs. Consider keeping WaitForExpectedEventTimeout scoped to expected events only (e.g., change ExpectNoEvent’s default to WaitForUnexpectedEventTimeout, or introduce a separate constant for the longer expected-event wait) so the flakiness fix doesn’t unnecessarily slow the suite.

 public const int WaitForExpectedEventTimeout = 1000; // ms to wait for an event to happen
public const int LongWaitTimeout = 50000; // ms to wait for an event that takes a longer time than the average operation
public const int SubsequentExpectedWait = 10; // ms to wait for checks that occur after the first.
public const int WaitForExpectedEventTimeout_NoRetry = 3000;// ms to wait for an event that isn't surrounded by a retry.
public const int WaitForUnexpectedEventTimeout = 150; // ms to wait for a non-expected event.

You can also share your feedback on Copilot code review. Take the survey.

adamsitnik

LGTM, big thanks for fixing it @lewing !

lewing · 2026-03-19T01:29:19Z

/ba-g failures are infrastructure and actively being resolved

lewing · 2026-03-18T19:44:55Z

Increase WaitForExpectedEventTimeout from 500ms to 1000ms per @tmds suggestion in #125740 (comment).

The inotify refactor (#117148) changed stop/start timing for watches, which can delay event delivery under stress conditions. The 500ms timeout is too tight for jitstress runs on slower hardware (arm32), causing false failures in SymbolicLink tests that are being incorrectly attributed to #103630.

This is a single constant change that affects 94 tests using the default ExpectEvent timeout. It should help distinguish timing issues from functional bugs.

Ref: #125737, #125740

/cc @tmds @adamsitnik @jozkee

The inotify refactor (dotnet#117148) changed stop/start timing for watches, which can delay event delivery under stress. The 500ms timeout is too tight for jitstress runs on slower hardware (arm32), causing false failures in SymbolicLink tests. Double the timeout from 500ms to 1000ms to better distinguish timing issues from functional bugs. This affects 94 tests that use the default ExpectEvent timeout. Ref: dotnet#125737 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-03-18T19:46:11Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR increases the default wait timeout used by FileSystemWatcher test utilities to reduce Linux (notably arm32 jitstress) timing-related flakiness after the inotify refactor.

Changes:

Increase WaitForExpectedEventTimeout from 500ms to 1000ms in the FileSystemWatcher test base helper.

Comments suppressed due to low confidence (1)

src/libraries/System.IO.FileSystem.Watcher/tests/Utility/FileSystemWatcherTest.cs:28

Raising WaitForExpectedEventTimeout will also increase the default wait for negative assertions and fixed sleeps that use this constant (e.g., ExpectNoEvent has a default timeout = WaitForExpectedEventTimeout, and some tests call Thread.Sleep(WaitForExpectedEventTimeout)). That can add ~500ms per such call to successful test runs. Consider keeping WaitForExpectedEventTimeout scoped to expected events only (e.g., change ExpectNoEvent’s default to WaitForUnexpectedEventTimeout, or introduce a separate constant for the longer expected-event wait) so the flakiness fix doesn’t unnecessarily slow the suite.

 public const int WaitForExpectedEventTimeout = 1000; // ms to wait for an event to happen
public const int LongWaitTimeout = 50000; // ms to wait for an event that takes a longer time than the average operation
public const int SubsequentExpectedWait = 10; // ms to wait for checks that occur after the first.
public const int WaitForExpectedEventTimeout_NoRetry = 3000;// ms to wait for an event that isn't surrounded by a retry.
public const int WaitForUnexpectedEventTimeout = 150; // ms to wait for a non-expected event.

You can also share your feedback on Copilot code review. Take the survey.

adamsitnik

LGTM, big thanks for fixing it @lewing !

lewing · 2026-03-19T01:29:19Z

/ba-g failures are infrastructure and actively being resolved

lewing · 2026-03-18T19:44:55Z

Increase WaitForExpectedEventTimeout from 500ms to 1000ms per @tmds suggestion in #125740 (comment).

The inotify refactor (#117148) changed stop/start timing for watches, which can delay event delivery under stress conditions. The 500ms timeout is too tight for jitstress runs on slower hardware (arm32), causing false failures in SymbolicLink tests that are being incorrectly attributed to #103630.

This is a single constant change that affects 94 tests using the default ExpectEvent timeout. It should help distinguish timing issues from functional bugs.

Ref: #125737, #125740

/cc @tmds @adamsitnik @jozkee

The inotify refactor (dotnet#117148) changed stop/start timing for watches, which can delay event delivery under stress. The 500ms timeout is too tight for jitstress runs on slower hardware (arm32), causing false failures in SymbolicLink tests. Double the timeout from 500ms to 1000ms to better distinguish timing issues from functional bugs. This affects 94 tests that use the default ExpectEvent timeout. Ref: dotnet#125737 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-03-18T19:46:11Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR increases the default wait timeout used by FileSystemWatcher test utilities to reduce Linux (notably arm32 jitstress) timing-related flakiness after the inotify refactor.

Changes:

Increase WaitForExpectedEventTimeout from 500ms to 1000ms in the FileSystemWatcher test base helper.

Comments suppressed due to low confidence (1)

src/libraries/System.IO.FileSystem.Watcher/tests/Utility/FileSystemWatcherTest.cs:28

Raising WaitForExpectedEventTimeout will also increase the default wait for negative assertions and fixed sleeps that use this constant (e.g., ExpectNoEvent has a default timeout = WaitForExpectedEventTimeout, and some tests call Thread.Sleep(WaitForExpectedEventTimeout)). That can add ~500ms per such call to successful test runs. Consider keeping WaitForExpectedEventTimeout scoped to expected events only (e.g., change ExpectNoEvent’s default to WaitForUnexpectedEventTimeout, or introduce a separate constant for the longer expected-event wait) so the flakiness fix doesn’t unnecessarily slow the suite.

 public const int WaitForExpectedEventTimeout = 1000; // ms to wait for an event to happen
public const int LongWaitTimeout = 50000; // ms to wait for an event that takes a longer time than the average operation
public const int SubsequentExpectedWait = 10; // ms to wait for checks that occur after the first.
public const int WaitForExpectedEventTimeout_NoRetry = 3000;// ms to wait for an event that isn't surrounded by a retry.
public const int WaitForUnexpectedEventTimeout = 150; // ms to wait for a non-expected event.

You can also share your feedback on Copilot code review. Take the survey.

adamsitnik

LGTM, big thanks for fixing it @lewing !

lewing · 2026-03-19T01:29:19Z

/ba-g failures are infrastructure and actively being resolved

CopilotAI review requested due to automatic review settings March 18, 2026 19:44

github-actionsBot added the area-System.IO label Mar 18, 2026

dotnet-policy-serviceBot assigned lewing Mar 18, 2026

lewing requested review from adamsitnik and tmds March 18, 2026 19:45

CopilotAI reviewed Mar 18, 2026
View reviewed changes

lewing marked this pull request as ready for review March 18, 2026 19:53

This was referenced Mar 18, 2026
Fix FileSystemWatcher startup race on Linux #125740
Closed
FileSystemWatcher SymbolicLink tests failing after inotify refactor (#117148) #125737
Closed

tmds approved these changes Mar 18, 2026
View reviewed changes

lewing requested a review from JulieLeeMSFT March 18, 2026 20:21

steveisok approved these changes Mar 18, 2026
View reviewed changes

adamsitnik approved these changes Mar 18, 2026
View reviewed changes

lewing enabled auto-merge (squash) March 18, 2026 20:59

lewing merged commit 0d2f781 into dotnet:mainMar 19, 2026
79 of 92 checks passed

dotnet-maestroBot mentioned this pull request Mar 19, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5588
Merged

tmds mentioned this pull request Mar 19, 2026
Test failure: System.IO.Tests.File_Changed_Tests.FileSystemWatcher_File_Changed_LastWrite #125241
Closed

lewing mentioned this pull request Mar 20, 2026
Fix FileSystemWatcher test flakiness on Windows and re-enable 86 disabled tests #125818
Merged

github-actionsBot locked and limited conversation to collaborators Apr 18, 2026

CopilotAI review requested due to automatic review settings March 18, 2026 19:44

github-actionsBot added the area-System.IO label Mar 18, 2026

dotnet-policy-serviceBot assigned lewing Mar 18, 2026

lewing requested review from adamsitnik and tmds March 18, 2026 19:45

CopilotAI reviewed Mar 18, 2026
View reviewed changes

lewing marked this pull request as ready for review March 18, 2026 19:53

This was referenced Mar 18, 2026
Fix FileSystemWatcher startup race on Linux #125740
Closed
FileSystemWatcher SymbolicLink tests failing after inotify refactor (#117148) #125737
Closed

tmds approved these changes Mar 18, 2026
View reviewed changes

lewing requested a review from JulieLeeMSFT March 18, 2026 20:21

steveisok approved these changes Mar 18, 2026
View reviewed changes

adamsitnik approved these changes Mar 18, 2026
View reviewed changes

lewing enabled auto-merge (squash) March 18, 2026 20:59

lewing merged commit 0d2f781 into dotnet:mainMar 19, 2026
79 of 92 checks passed

dotnet-maestroBot mentioned this pull request Mar 19, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5588
Merged

tmds mentioned this pull request Mar 19, 2026
Test failure: System.IO.Tests.File_Changed_Tests.FileSystemWatcher_File_Changed_LastWrite #125241
Closed

lewing mentioned this pull request Mar 20, 2026
Fix FileSystemWatcher test flakiness on Windows and re-enable 86 disabled tests #125818
Merged

github-actionsBot locked and limited conversation to collaborators Apr 18, 2026

CopilotAI review requested due to automatic review settings March 18, 2026 19:44

github-actionsBot added the area-System.IO label Mar 18, 2026

dotnet-policy-serviceBot assigned lewing Mar 18, 2026

lewing requested review from adamsitnik and tmds March 18, 2026 19:45

CopilotAI reviewed Mar 18, 2026
View reviewed changes

lewing marked this pull request as ready for review March 18, 2026 19:53

This was referenced Mar 18, 2026
Fix FileSystemWatcher startup race on Linux #125740
Closed
FileSystemWatcher SymbolicLink tests failing after inotify refactor (#117148) #125737
Closed

tmds approved these changes Mar 18, 2026
View reviewed changes

lewing requested a review from JulieLeeMSFT March 18, 2026 20:21

steveisok approved these changes Mar 18, 2026
View reviewed changes

adamsitnik approved these changes Mar 18, 2026
View reviewed changes

lewing enabled auto-merge (squash) March 18, 2026 20:59

lewing merged commit 0d2f781 into dotnet:mainMar 19, 2026
79 of 92 checks passed

dotnet-maestroBot mentioned this pull request Mar 19, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5588
Merged

tmds mentioned this pull request Mar 19, 2026
Test failure: System.IO.Tests.File_Changed_Tests.FileSystemWatcher_File_Changed_LastWrite #125241
Closed

lewing mentioned this pull request Mar 20, 2026
Fix FileSystemWatcher test flakiness on Windows and re-enable 86 disabled tests #125818
Merged

github-actionsBot locked and limited conversation to collaborators Apr 18, 2026

CopilotAI review requested due to automatic review settings March 18, 2026 19:44

github-actionsBot added the area-System.IO label Mar 18, 2026

dotnet-policy-serviceBot assigned lewing Mar 18, 2026

lewing requested review from adamsitnik and tmds March 18, 2026 19:45

CopilotAI reviewed Mar 18, 2026
View reviewed changes

lewing marked this pull request as ready for review March 18, 2026 19:53

This was referenced Mar 18, 2026
Fix FileSystemWatcher startup race on Linux #125740
Closed
FileSystemWatcher SymbolicLink tests failing after inotify refactor (#117148) #125737
Closed

tmds approved these changes Mar 18, 2026
View reviewed changes

lewing requested a review from JulieLeeMSFT March 18, 2026 20:21

steveisok approved these changes Mar 18, 2026
View reviewed changes

adamsitnik approved these changes Mar 18, 2026
View reviewed changes

lewing enabled auto-merge (squash) March 18, 2026 20:59

lewing merged commit 0d2f781 into dotnet:mainMar 19, 2026
79 of 92 checks passed

dotnet-maestroBot mentioned this pull request Mar 19, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5588
Merged

tmds mentioned this pull request Mar 19, 2026
Test failure: System.IO.Tests.File_Changed_Tests.FileSystemWatcher_File_Changed_LastWrite #125241
Closed

lewing mentioned this pull request Mar 20, 2026
Fix FileSystemWatcher test flakiness on Windows and re-enable 86 disabled tests #125818
Merged

github-actionsBot locked and limited conversation to collaborators Apr 18, 2026

CopilotAI review requested due to automatic review settings March 18, 2026 19:44

github-actionsBot added the area-System.IO label Mar 18, 2026

dotnet-policy-serviceBot assigned lewing Mar 18, 2026

lewing requested review from adamsitnik and tmds March 18, 2026 19:45

CopilotAI reviewed Mar 18, 2026
View reviewed changes

lewing marked this pull request as ready for review March 18, 2026 19:53

This was referenced Mar 18, 2026
Fix FileSystemWatcher startup race on Linux #125740
Closed
FileSystemWatcher SymbolicLink tests failing after inotify refactor (#117148) #125737
Closed

tmds approved these changes Mar 18, 2026
View reviewed changes

lewing requested a review from JulieLeeMSFT March 18, 2026 20:21

steveisok approved these changes Mar 18, 2026
View reviewed changes

adamsitnik approved these changes Mar 18, 2026
View reviewed changes

lewing enabled auto-merge (squash) March 18, 2026 20:59

lewing merged commit 0d2f781 into dotnet:mainMar 19, 2026
79 of 92 checks passed

dotnet-maestroBot mentioned this pull request Mar 19, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5588
Merged

tmds mentioned this pull request Mar 19, 2026
Test failure: System.IO.Tests.File_Changed_Tests.FileSystemWatcher_File_Changed_LastWrite #125241
Closed

lewing mentioned this pull request Mar 20, 2026
Fix FileSystemWatcher test flakiness on Windows and re-enable 86 disabled tests #125818
Merged

github-actionsBot locked and limited conversation to collaborators Apr 18, 2026

CopilotAI review requested due to automatic review settings March 18, 2026 19:44

github-actionsBot added the area-System.IO label Mar 18, 2026

dotnet-policy-serviceBot assigned lewing Mar 18, 2026

lewing requested review from adamsitnik and tmds March 18, 2026 19:45

CopilotAI reviewed Mar 18, 2026
View reviewed changes

lewing marked this pull request as ready for review March 18, 2026 19:53

This was referenced Mar 18, 2026
Fix FileSystemWatcher startup race on Linux #125740
Closed
FileSystemWatcher SymbolicLink tests failing after inotify refactor (#117148) #125737
Closed

tmds approved these changes Mar 18, 2026
View reviewed changes

lewing requested a review from JulieLeeMSFT March 18, 2026 20:21

steveisok approved these changes Mar 18, 2026
View reviewed changes

adamsitnik approved these changes Mar 18, 2026
View reviewed changes

lewing enabled auto-merge (squash) March 18, 2026 20:59

lewing merged commit 0d2f781 into dotnet:mainMar 19, 2026
79 of 92 checks passed

dotnet-maestroBot mentioned this pull request Mar 19, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5588
Merged

tmds mentioned this pull request Mar 19, 2026
Test failure: System.IO.Tests.File_Changed_Tests.FileSystemWatcher_File_Changed_LastWrite #125241
Closed

lewing mentioned this pull request Mar 20, 2026
Fix FileSystemWatcher test flakiness on Windows and re-enable 86 disabled tests #125818
Merged

github-actionsBot locked and limited conversation to collaborators Apr 18, 2026

CopilotAI review requested due to automatic review settings March 18, 2026 19:44

github-actionsBot added the area-System.IO label Mar 18, 2026

dotnet-policy-serviceBot assigned lewing Mar 18, 2026

lewing requested review from adamsitnik and tmds March 18, 2026 19:45

CopilotAI reviewed Mar 18, 2026
View reviewed changes

lewing marked this pull request as ready for review March 18, 2026 19:53

This was referenced Mar 18, 2026
Fix FileSystemWatcher startup race on Linux #125740
Closed
FileSystemWatcher SymbolicLink tests failing after inotify refactor (#117148) #125737
Closed

tmds approved these changes Mar 18, 2026
View reviewed changes

lewing requested a review from JulieLeeMSFT March 18, 2026 20:21

steveisok approved these changes Mar 18, 2026
View reviewed changes

adamsitnik approved these changes Mar 18, 2026
View reviewed changes

lewing enabled auto-merge (squash) March 18, 2026 20:59

lewing merged commit 0d2f781 into dotnet:mainMar 19, 2026
79 of 92 checks passed

dotnet-maestroBot mentioned this pull request Mar 19, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5588
Merged

tmds mentioned this pull request Mar 19, 2026
Test failure: System.IO.Tests.File_Changed_Tests.FileSystemWatcher_File_Changed_LastWrite #125241
Closed

lewing mentioned this pull request Mar 20, 2026
Fix FileSystemWatcher test flakiness on Windows and re-enable 86 disabled tests #125818
Merged

github-actionsBot locked and limited conversation to collaborators Apr 18, 2026

CopilotAI review requested due to automatic review settings March 18, 2026 19:44

github-actionsBot added the area-System.IO label Mar 18, 2026

dotnet-policy-serviceBot assigned lewing Mar 18, 2026

lewing requested review from adamsitnik and tmds March 18, 2026 19:45

CopilotAI reviewed Mar 18, 2026
View reviewed changes

lewing marked this pull request as ready for review March 18, 2026 19:53

This was referenced Mar 18, 2026
Fix FileSystemWatcher startup race on Linux #125740
Closed
FileSystemWatcher SymbolicLink tests failing after inotify refactor (#117148) #125737
Closed

tmds approved these changes Mar 18, 2026
View reviewed changes

lewing requested a review from JulieLeeMSFT March 18, 2026 20:21

steveisok approved these changes Mar 18, 2026
View reviewed changes

adamsitnik approved these changes Mar 18, 2026
View reviewed changes

lewing enabled auto-merge (squash) March 18, 2026 20:59

lewing merged commit 0d2f781 into dotnet:mainMar 19, 2026
79 of 92 checks passed

dotnet-maestroBot mentioned this pull request Mar 19, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#5588
Merged

tmds mentioned this pull request Mar 19, 2026
Test failure: System.IO.Tests.File_Changed_Tests.FileSystemWatcher_File_Changed_LastWrite #125241
Closed

lewing mentioned this pull request Mar 20, 2026
Fix FileSystemWatcher test flakiness on Windows and re-enable 86 disabled tests #125818
Merged

github-actionsBot locked and limited conversation to collaborators Apr 18, 2026

Uh oh!

Conversation

lewing commented Mar 18, 2026

Uh oh!

dotnet-policy-serviceBot commented Mar 18, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

adamsitnik left a comment

Choose a reason for hiding this comment

Uh oh!

lewing commented Mar 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

lewing commented Mar 18, 2026

Uh oh!

dotnet-policy-serviceBot commented Mar 18, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

adamsitnik left a comment

Choose a reason for hiding this comment

Uh oh!

lewing commented Mar 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

lewing commented Mar 18, 2026

Uh oh!

dotnet-policy-serviceBot commented Mar 18, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

adamsitnik left a comment

Choose a reason for hiding this comment

Uh oh!

lewing commented Mar 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

lewing commented Mar 18, 2026

Uh oh!

dotnet-policy-serviceBot commented Mar 18, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment