Improve Process support on MacCatalyst: use posix_spawn - #126478

Merged
adamsitnik merged 10 commits into
mainfrom
copilot/improve-process-support-maccatalyst
Apr 13, 2026
Merged

Improve Process support on MacCatalyst: use posix_spawn#126478
adamsitnik merged 10 commits into
mainfrom
copilot/improve-process-support-maccatalyst

Conversation

CopilotAI commented Apr 2, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

MacCatalyst was missing the fast process spawning path available on macOS via posix_spawn. Before this change, MacCatalyst had no working code path in SystemNative_ForkAndExecProcess — it fell through to the #else return -1 fallback with *childPid uninitialized, since both HAVE_FORK (disabled by kernel restriction in configure.cmake) and TARGET_OSX were false for MacCatalyst.

Description

configure.cmake

  • Add check_symbol_exists(posix_spawn_file_actions_addchdir_np spawn.h HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP) to detect availability of posix_spawn_file_actions_addchdir_np at configure time. The existing -Wunguarded-availability flag ensures this check correctly fails for platforms (e.g. MacCatalyst) where the function is marked __API_UNAVAILABLE in the SDK, making the guard future-proof if the function becomes available on those platforms.

src/native/libs/Common/pal_config.h.in

  • Add #cmakedefine01 HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP so the capability macro detected by CMake is emitted into the generated pal_config.h header used by pal_process.c.

Native (pal_process.c)

  • Extend the posix_spawn path to MacCatalyst by changing #if defined(TARGET_OSX) to #if defined(TARGET_OSX) || defined(TARGET_MACCATALYST) for both the argument/initialization guard and the posix_spawn block. Previously, MacCatalyst had no functional code path for process spawning.
  • Extend the leading #if HAVE_FORK || defined(TARGET_OSX) guard to include TARGET_MACCATALYST, ensuring *childPid is properly initialized to -1 and the access() pre-check runs on MacCatalyst.
  • Replace the TARGET_MACCATALYST-specific early-fail block with two capability-based guards:
    • #if !HAVE_FORK — fails fast with errno = ENOTSUP when setCredentials=true, since setuid/setgid-based credential changes require fork, which is blocked by the kernel at runtime on MacCatalyst (EPERM). The in-code comment explains this constraint.
    • #if !HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP — fails fast with errno = ENOTSUP when cwd != NULL, since the function is unavailable on MacCatalyst.
  • Guard the posix_spawn_file_actions_addchdir_np call site with #if HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP (previously #if !defined(TARGET_MACCATALYST)) to fix the build error and make the guard forward-compatible.
  • Move the // Change working directory if specified comment to the end of the posix_spawn_file_actions_addchdir_np line where it belongs.

@adamsitnikadamsitnik added this to the 11.0.0 milestone Apr 2, 2026
@dotnet-policy-service

dotnet-policy-serviceBot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-diagnostics-process
See info in area-owners.md if you want to be subscribed.

CopilotAI linked an issue Apr 2, 2026 that may be closed by this pull request
Improve Process support on MacCatalyst #126472
Closed
CopilotAI changed the title [WIP] Improve process support on MacCatalystImprove Process support on MacCatalystApr 2, 2026
CopilotAI requested a review from adamsitnikApril 2, 2026 18:47
adamsitnik
adamsitnik reviewed Apr 2, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_log.m Outdated
This was referenced Apr 3, 2026
Open
Open
Closed
Open
Closed
Closed
adamsitnik
adamsitnik reviewed Apr 10, 2026
View reviewed changes

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please address my feedback

Comment threadsrc/native/libs/System.Native/pal_process.c
CopilotAI requested review from Copilot and removed request for CopilotApril 10, 2026 14:29
CopilotAI changed the title Improve Process support on MacCatalystImprove Process support on MacCatalyst: use posix_spawnApr 10, 2026
CopilotAI requested a review from adamsitnikApril 10, 2026 14:31
@adamsitnik
Use HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP and HAVE_FORK instead o…
43de386
…f TARGET_MACCATALYST guards
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/e578bc53-d1e7-41bb-ad79-023a0863881a
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
CopilotAI requested review from adamsitnik and Copilot and removed request for CopilotApril 11, 2026 07:38
adamsitnik
adamsitnik reviewed Apr 11, 2026
View reviewed changes
Comment threadsrc/native/libs/configure.cmake
CopilotAI requested review from adamsitnik and Copilot and removed request for CopilotApril 11, 2026 08:45
@adamsitnik

adamsitnik commented Apr 11, 2026

Copy link
Copy Markdown
Member

/azp run runtime-maccatalyst

@azure-pipelines

azure-pipelinesBot commented Apr 11, 2026

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 11, 2026
Open
Closed
rolfbjarne
rolfbjarne approved these changes Apr 13, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_process.c Outdated
CopilotAI requested review from Copilot and removed request for CopilotApril 13, 2026 10:13
@adamsitnik
adamsitnik enabled auto-merge (squash) April 13, 2026 10:16
@adamsitnik

adamsitnik commented Apr 13, 2026

Copy link
Copy Markdown
Member

/ba-g WASM build timeout is unrelated

@adamsitnik
adamsitnik merged commit bf222c5 into mainApr 13, 2026
174 of 177 checks passed
@adamsitnik
adamsitnik deleted the copilot/improve-process-support-maccatalyst branch April 13, 2026 14:21
@dotnet-maestrodotnet-maestroBot mentioned this pull request Apr 15, 2026
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 14, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rolfbjarnerolfbjarnerolfbjarne approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@adamsitnikadamsitnikAwaiting requested review from adamsitnik

Assignees

@adamsitnikadamsitnik

Copilot code reviewCopilot

Labels

area-System.Diagnostics.Process

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

Improve Process support on MacCatalyst

5 participants

@adamsitnik@rolfbjarne@jkotas
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Improve Process support on MacCatalyst: use posix_spawn - #126478
Merged
adamsitnik merged 10 commits into
mainfrom 
copilot/improve-process-support-maccatalyst
Apr 13, 2026
Merged
Improve Process support on MacCatalyst: use posix_spawn#126478
adamsitnik merged 10 commits into
mainfrom 
copilot/improve-process-support-maccatalyst
Conversation
CopilotAI
commented
Apr 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
MacCatalyst was missing the fast process spawning path available on macOS via posix_spawn. Before this change, MacCatalyst had no working code path in SystemNative_ForkAndExecProcess — it fell through to the #else return -1 fallback with *childPid uninitialized, since both HAVE_FORK (disabled by kernel restriction in configure.cmake) and TARGET_OSX were false for MacCatalyst.
Description
configure.cmake
  • Add check_symbol_exists(posix_spawn_file_actions_addchdir_np spawn.h HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP) to detect availability of posix_spawn_file_actions_addchdir_np at configure time. The existing -Wunguarded-availability flag ensures this check correctly fails for platforms (e.g. MacCatalyst) where the function is marked __API_UNAVAILABLE in the SDK, making the guard future-proof if the function becomes available on those platforms.
src/native/libs/Common/pal_config.h.in
  • Add #cmakedefine01 HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP so the capability macro detected by CMake is emitted into the generated pal_config.h header used by pal_process.c.
Native (pal_process.c)
  • Extend the posix_spawn path to MacCatalyst by changing #if defined(TARGET_OSX) to #if defined(TARGET_OSX) || defined(TARGET_MACCATALYST) for both the argument/initialization guard and the posix_spawn block. Previously, MacCatalyst had no functional code path for process spawning.
  • Extend the leading #if HAVE_FORK || defined(TARGET_OSX) guard to include TARGET_MACCATALYST, ensuring *childPid is properly initialized to -1 and the access() pre-check runs on MacCatalyst.
  • Replace the TARGET_MACCATALYST-specific early-fail block with two capability-based guards:

    • #if !HAVE_FORK — fails fast with errno = ENOTSUP when setCredentials=true, since setuid/setgid-based credential changes require fork, which is blocked by the kernel at runtime on MacCatalyst (EPERM). The in-code comment explains this constraint.
    • #if !HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP — fails fast with errno = ENOTSUP when cwd != NULL, since the function is unavailable on MacCatalyst.
  • Guard the posix_spawn_file_actions_addchdir_np call site with #if HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP (previously #if !defined(TARGET_MACCATALYST)) to fix the build error and make the guard forward-compatible.
  • Move the // Change working directory if specified comment to the end of the posix_spawn_file_actions_addchdir_np line where it belongs.
@adamsitnikadamsitnik
added this to the 11.0.0 milestone
Apr 2, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 2, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process

See info in area-owners.md if you want to be subscribed.
CopilotAI
linked an issue
Apr 2, 2026
that may be
closed
by this pull request


Improve Process support on MacCatalyst
#126472

Closed

CopilotAI
changed the title
[WIP] Improve process support on MacCatalystImprove Process support on MacCatalystApr 2, 2026
CopilotAI
requested a review
from adamsitnikApril 2, 2026 18:47
adamsitnik
adamsitnik
reviewed
Apr 2, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_log.m
Outdated


This was referenced Apr 3, 2026

Open


Open


Closed


Open


Closed


Closed

adamsitnik
adamsitnik
reviewed
Apr 10, 2026
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please address my feedback
Comment threadsrc/native/libs/System.Native/pal_process.c
CopilotAI
requested review from
Copilot
and removed request for
CopilotApril 10, 2026 14:29
CopilotAI
changed the title
Improve Process support on MacCatalystImprove Process support on MacCatalyst: use posix_spawnApr 10, 2026
CopilotAI
requested a review
from adamsitnikApril 10, 2026 14:31
@adamsitnik
Use HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP and HAVE_FORK instead o…
43de386
…f TARGET_MACCATALYST guards
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/e578bc53-d1e7-41bb-ad79-023a0863881a
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
CopilotAI
requested review from
adamsitnik and Copilot
and removed request for
CopilotApril 11, 2026 07:38
adamsitnik
adamsitnik
reviewed
Apr 11, 2026
View reviewed changes
Comment threadsrc/native/libs/configure.cmake
CopilotAI
requested review from
adamsitnik and Copilot
and removed request for
CopilotApril 11, 2026 08:45
@adamsitnik
adamsitnik
commented
Apr 11, 2026

Copy link


Copy Markdown

Member
/azp run runtime-maccatalyst
@azure-pipelines
azure-pipelinesBot
commented
Apr 11, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 11, 2026

Open


Closed

rolfbjarne
rolfbjarne
approved these changes
Apr 13, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_process.c
Outdated

CopilotAI
requested review from
Copilot
and removed request for
CopilotApril 13, 2026 10:13
@adamsitnik
adamsitnik
enabled auto-merge (squash)
April 13, 2026 10:16
@adamsitnik
adamsitnik
commented
Apr 13, 2026

Copy link


Copy Markdown

Member
/ba-g WASM build timeout is unrelated
@adamsitnik
adamsitnik
merged commit bf222c5
into
mainApr 13, 2026

174 of 177 checks passed

@adamsitnik
adamsitnik
deleted the

copilot/improve-process-support-maccatalyst

branch
April 13, 2026 14:21
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 15, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 14, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rolfbjarnerolfbjarnerolfbjarne approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@adamsitnikadamsitnikAwaiting requested review from adamsitnik

Assignees

@adamsitnikadamsitnik
Copilot code reviewCopilot

Labels

area-System.Diagnostics.Process

Projects


None yet


Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

Improve Process support on MacCatalyst


5 participants

@adamsitnik@rolfbjarne@jkotas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Improve Process support on MacCatalyst: use posix_spawn - #126478
Merged
adamsitnik merged 10 commits into
mainfrom 
copilot/improve-process-support-maccatalyst
Apr 13, 2026
Merged
Improve Process support on MacCatalyst: use posix_spawn#126478
adamsitnik merged 10 commits into
mainfrom 
copilot/improve-process-support-maccatalyst
Conversation
CopilotAI
commented
Apr 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
MacCatalyst was missing the fast process spawning path available on macOS via posix_spawn. Before this change, MacCatalyst had no working code path in SystemNative_ForkAndExecProcess — it fell through to the #else return -1 fallback with *childPid uninitialized, since both HAVE_FORK (disabled by kernel restriction in configure.cmake) and TARGET_OSX were false for MacCatalyst.
Description
configure.cmake
  • Add check_symbol_exists(posix_spawn_file_actions_addchdir_np spawn.h HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP) to detect availability of posix_spawn_file_actions_addchdir_np at configure time. The existing -Wunguarded-availability flag ensures this check correctly fails for platforms (e.g. MacCatalyst) where the function is marked __API_UNAVAILABLE in the SDK, making the guard future-proof if the function becomes available on those platforms.
src/native/libs/Common/pal_config.h.in
  • Add #cmakedefine01 HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP so the capability macro detected by CMake is emitted into the generated pal_config.h header used by pal_process.c.
Native (pal_process.c)
  • Extend the posix_spawn path to MacCatalyst by changing #if defined(TARGET_OSX) to #if defined(TARGET_OSX) || defined(TARGET_MACCATALYST) for both the argument/initialization guard and the posix_spawn block. Previously, MacCatalyst had no functional code path for process spawning.
  • Extend the leading #if HAVE_FORK || defined(TARGET_OSX) guard to include TARGET_MACCATALYST, ensuring *childPid is properly initialized to -1 and the access() pre-check runs on MacCatalyst.
  • Replace the TARGET_MACCATALYST-specific early-fail block with two capability-based guards:

    • #if !HAVE_FORK — fails fast with errno = ENOTSUP when setCredentials=true, since setuid/setgid-based credential changes require fork, which is blocked by the kernel at runtime on MacCatalyst (EPERM). The in-code comment explains this constraint.
    • #if !HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP — fails fast with errno = ENOTSUP when cwd != NULL, since the function is unavailable on MacCatalyst.
  • Guard the posix_spawn_file_actions_addchdir_np call site with #if HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP (previously #if !defined(TARGET_MACCATALYST)) to fix the build error and make the guard forward-compatible.
  • Move the // Change working directory if specified comment to the end of the posix_spawn_file_actions_addchdir_np line where it belongs.
@adamsitnikadamsitnik
added this to the 11.0.0 milestone
Apr 2, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 2, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process

See info in area-owners.md if you want to be subscribed.
CopilotAI
linked an issue
Apr 2, 2026
that may be
closed
by this pull request


Improve Process support on MacCatalyst
#126472

Closed

CopilotAI
changed the title
[WIP] Improve process support on MacCatalystImprove Process support on MacCatalystApr 2, 2026
CopilotAI
requested a review
from adamsitnikApril 2, 2026 18:47
adamsitnik
adamsitnik
reviewed
Apr 2, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_log.m
Outdated


This was referenced Apr 3, 2026

Open


Open


Closed


Open


Closed


Closed

adamsitnik
adamsitnik
reviewed
Apr 10, 2026
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please address my feedback
Comment threadsrc/native/libs/System.Native/pal_process.c
CopilotAI
requested review from
Copilot
and removed request for
CopilotApril 10, 2026 14:29
CopilotAI
changed the title
Improve Process support on MacCatalystImprove Process support on MacCatalyst: use posix_spawnApr 10, 2026
CopilotAI
requested a review
from adamsitnikApril 10, 2026 14:31
@adamsitnik
Use HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP and HAVE_FORK instead o…
43de386
…f TARGET_MACCATALYST guards
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/e578bc53-d1e7-41bb-ad79-023a0863881a
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
CopilotAI
requested review from
adamsitnik and Copilot
and removed request for
CopilotApril 11, 2026 07:38
adamsitnik
adamsitnik
reviewed
Apr 11, 2026
View reviewed changes
Comment threadsrc/native/libs/configure.cmake
CopilotAI
requested review from
adamsitnik and Copilot
and removed request for
CopilotApril 11, 2026 08:45
@adamsitnik
adamsitnik
commented
Apr 11, 2026

Copy link


Copy Markdown

Member
/azp run runtime-maccatalyst
@azure-pipelines
azure-pipelinesBot
commented
Apr 11, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 11, 2026

Open


Closed

rolfbjarne
rolfbjarne
approved these changes
Apr 13, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_process.c
Outdated

CopilotAI
requested review from
Copilot
and removed request for
CopilotApril 13, 2026 10:13
@adamsitnik
adamsitnik
enabled auto-merge (squash)
April 13, 2026 10:16
@adamsitnik
adamsitnik
commented
Apr 13, 2026

Copy link


Copy Markdown

Member
/ba-g WASM build timeout is unrelated
@adamsitnik
adamsitnik
merged commit bf222c5
into
mainApr 13, 2026

174 of 177 checks passed

@adamsitnik
adamsitnik
deleted the

copilot/improve-process-support-maccatalyst

branch
April 13, 2026 14:21
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 15, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 14, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rolfbjarnerolfbjarnerolfbjarne approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@adamsitnikadamsitnikAwaiting requested review from adamsitnik

Assignees

@adamsitnikadamsitnik
Copilot code reviewCopilot

Labels

area-System.Diagnostics.Process

Projects


None yet


Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

Improve Process support on MacCatalyst


5 participants

@adamsitnik@rolfbjarne@jkotas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Improve Process support on MacCatalyst: use posix_spawn - #126478
Merged
adamsitnik merged 10 commits into
mainfrom 
copilot/improve-process-support-maccatalyst
Apr 13, 2026
Merged
Improve Process support on MacCatalyst: use posix_spawn#126478
adamsitnik merged 10 commits into
mainfrom 
copilot/improve-process-support-maccatalyst
Conversation
CopilotAI
commented
Apr 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
MacCatalyst was missing the fast process spawning path available on macOS via posix_spawn. Before this change, MacCatalyst had no working code path in SystemNative_ForkAndExecProcess — it fell through to the #else return -1 fallback with *childPid uninitialized, since both HAVE_FORK (disabled by kernel restriction in configure.cmake) and TARGET_OSX were false for MacCatalyst.
Description
configure.cmake
  • Add check_symbol_exists(posix_spawn_file_actions_addchdir_np spawn.h HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP) to detect availability of posix_spawn_file_actions_addchdir_np at configure time. The existing -Wunguarded-availability flag ensures this check correctly fails for platforms (e.g. MacCatalyst) where the function is marked __API_UNAVAILABLE in the SDK, making the guard future-proof if the function becomes available on those platforms.
src/native/libs/Common/pal_config.h.in
  • Add #cmakedefine01 HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP so the capability macro detected by CMake is emitted into the generated pal_config.h header used by pal_process.c.
Native (pal_process.c)
  • Extend the posix_spawn path to MacCatalyst by changing #if defined(TARGET_OSX) to #if defined(TARGET_OSX) || defined(TARGET_MACCATALYST) for both the argument/initialization guard and the posix_spawn block. Previously, MacCatalyst had no functional code path for process spawning.
  • Extend the leading #if HAVE_FORK || defined(TARGET_OSX) guard to include TARGET_MACCATALYST, ensuring *childPid is properly initialized to -1 and the access() pre-check runs on MacCatalyst.
  • Replace the TARGET_MACCATALYST-specific early-fail block with two capability-based guards:

    • #if !HAVE_FORK — fails fast with errno = ENOTSUP when setCredentials=true, since setuid/setgid-based credential changes require fork, which is blocked by the kernel at runtime on MacCatalyst (EPERM). The in-code comment explains this constraint.
    • #if !HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP — fails fast with errno = ENOTSUP when cwd != NULL, since the function is unavailable on MacCatalyst.
  • Guard the posix_spawn_file_actions_addchdir_np call site with #if HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP (previously #if !defined(TARGET_MACCATALYST)) to fix the build error and make the guard forward-compatible.
  • Move the // Change working directory if specified comment to the end of the posix_spawn_file_actions_addchdir_np line where it belongs.
@adamsitnikadamsitnik
added this to the 11.0.0 milestone
Apr 2, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 2, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process

See info in area-owners.md if you want to be subscribed.
CopilotAI
linked an issue
Apr 2, 2026
that may be
closed
by this pull request


Improve Process support on MacCatalyst
#126472

Closed

CopilotAI
changed the title
[WIP] Improve process support on MacCatalystImprove Process support on MacCatalystApr 2, 2026
CopilotAI
requested a review
from adamsitnikApril 2, 2026 18:47
adamsitnik
adamsitnik
reviewed
Apr 2, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_log.m
Outdated


This was referenced Apr 3, 2026

Open


Open


Closed


Open


Closed


Closed

adamsitnik
adamsitnik
reviewed
Apr 10, 2026
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please address my feedback
Comment threadsrc/native/libs/System.Native/pal_process.c
CopilotAI
requested review from
Copilot
and removed request for
CopilotApril 10, 2026 14:29
CopilotAI
changed the title
Improve Process support on MacCatalystImprove Process support on MacCatalyst: use posix_spawnApr 10, 2026
CopilotAI
requested a review
from adamsitnikApril 10, 2026 14:31
@adamsitnik
Use HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP and HAVE_FORK instead o…
43de386
…f TARGET_MACCATALYST guards
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/e578bc53-d1e7-41bb-ad79-023a0863881a
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
CopilotAI
requested review from
adamsitnik and Copilot
and removed request for
CopilotApril 11, 2026 07:38
adamsitnik
adamsitnik
reviewed
Apr 11, 2026
View reviewed changes
Comment threadsrc/native/libs/configure.cmake
CopilotAI
requested review from
adamsitnik and Copilot
and removed request for
CopilotApril 11, 2026 08:45
@adamsitnik
adamsitnik
commented
Apr 11, 2026

Copy link


Copy Markdown

Member
/azp run runtime-maccatalyst
@azure-pipelines
azure-pipelinesBot
commented
Apr 11, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 11, 2026

Open


Closed

rolfbjarne
rolfbjarne
approved these changes
Apr 13, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_process.c
Outdated

CopilotAI
requested review from
Copilot
and removed request for
CopilotApril 13, 2026 10:13
@adamsitnik
adamsitnik
enabled auto-merge (squash)
April 13, 2026 10:16
@adamsitnik
adamsitnik
commented
Apr 13, 2026

Copy link


Copy Markdown

Member
/ba-g WASM build timeout is unrelated
@adamsitnik
adamsitnik
merged commit bf222c5
into
mainApr 13, 2026

174 of 177 checks passed

@adamsitnik
adamsitnik
deleted the

copilot/improve-process-support-maccatalyst

branch
April 13, 2026 14:21
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 15, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 14, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rolfbjarnerolfbjarnerolfbjarne approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@adamsitnikadamsitnikAwaiting requested review from adamsitnik

Assignees

@adamsitnikadamsitnik
Copilot code reviewCopilot

Labels

area-System.Diagnostics.Process

Projects


None yet


Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

Improve Process support on MacCatalyst


5 participants

@adamsitnik@rolfbjarne@jkotas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Improve Process support on MacCatalyst: use posix_spawn - #126478
Merged
adamsitnik merged 10 commits into
mainfrom 
copilot/improve-process-support-maccatalyst
Apr 13, 2026
Merged
Improve Process support on MacCatalyst: use posix_spawn#126478
adamsitnik merged 10 commits into
mainfrom 
copilot/improve-process-support-maccatalyst
Conversation
CopilotAI
commented
Apr 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
MacCatalyst was missing the fast process spawning path available on macOS via posix_spawn. Before this change, MacCatalyst had no working code path in SystemNative_ForkAndExecProcess — it fell through to the #else return -1 fallback with *childPid uninitialized, since both HAVE_FORK (disabled by kernel restriction in configure.cmake) and TARGET_OSX were false for MacCatalyst.
Description
configure.cmake
  • Add check_symbol_exists(posix_spawn_file_actions_addchdir_np spawn.h HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP) to detect availability of posix_spawn_file_actions_addchdir_np at configure time. The existing -Wunguarded-availability flag ensures this check correctly fails for platforms (e.g. MacCatalyst) where the function is marked __API_UNAVAILABLE in the SDK, making the guard future-proof if the function becomes available on those platforms.
src/native/libs/Common/pal_config.h.in
  • Add #cmakedefine01 HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP so the capability macro detected by CMake is emitted into the generated pal_config.h header used by pal_process.c.
Native (pal_process.c)
  • Extend the posix_spawn path to MacCatalyst by changing #if defined(TARGET_OSX) to #if defined(TARGET_OSX) || defined(TARGET_MACCATALYST) for both the argument/initialization guard and the posix_spawn block. Previously, MacCatalyst had no functional code path for process spawning.
  • Extend the leading #if HAVE_FORK || defined(TARGET_OSX) guard to include TARGET_MACCATALYST, ensuring *childPid is properly initialized to -1 and the access() pre-check runs on MacCatalyst.
  • Replace the TARGET_MACCATALYST-specific early-fail block with two capability-based guards:

    • #if !HAVE_FORK — fails fast with errno = ENOTSUP when setCredentials=true, since setuid/setgid-based credential changes require fork, which is blocked by the kernel at runtime on MacCatalyst (EPERM). The in-code comment explains this constraint.
    • #if !HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP — fails fast with errno = ENOTSUP when cwd != NULL, since the function is unavailable on MacCatalyst.
  • Guard the posix_spawn_file_actions_addchdir_np call site with #if HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP (previously #if !defined(TARGET_MACCATALYST)) to fix the build error and make the guard forward-compatible.
  • Move the // Change working directory if specified comment to the end of the posix_spawn_file_actions_addchdir_np line where it belongs.
@adamsitnikadamsitnik
added this to the 11.0.0 milestone
Apr 2, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 2, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process

See info in area-owners.md if you want to be subscribed.
CopilotAI
linked an issue
Apr 2, 2026
that may be
closed
by this pull request


Improve Process support on MacCatalyst
#126472

Closed

CopilotAI
changed the title
[WIP] Improve process support on MacCatalystImprove Process support on MacCatalystApr 2, 2026
CopilotAI
requested a review
from adamsitnikApril 2, 2026 18:47
adamsitnik
adamsitnik
reviewed
Apr 2, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_log.m
Outdated


This was referenced Apr 3, 2026

Open


Open


Closed


Open


Closed


Closed

adamsitnik
adamsitnik
reviewed
Apr 10, 2026
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please address my feedback
Comment threadsrc/native/libs/System.Native/pal_process.c
CopilotAI
requested review from
Copilot
and removed request for
CopilotApril 10, 2026 14:29
CopilotAI
changed the title
Improve Process support on MacCatalystImprove Process support on MacCatalyst: use posix_spawnApr 10, 2026
CopilotAI
requested a review
from adamsitnikApril 10, 2026 14:31
@adamsitnik
Use HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP and HAVE_FORK instead o…
43de386
…f TARGET_MACCATALYST guards
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/e578bc53-d1e7-41bb-ad79-023a0863881a
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
CopilotAI
requested review from
adamsitnik and Copilot
and removed request for
CopilotApril 11, 2026 07:38
adamsitnik
adamsitnik
reviewed
Apr 11, 2026
View reviewed changes
Comment threadsrc/native/libs/configure.cmake
CopilotAI
requested review from
adamsitnik and Copilot
and removed request for
CopilotApril 11, 2026 08:45
@adamsitnik
adamsitnik
commented
Apr 11, 2026

Copy link


Copy Markdown

Member
/azp run runtime-maccatalyst
@azure-pipelines
azure-pipelinesBot
commented
Apr 11, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 11, 2026

Open


Closed

rolfbjarne
rolfbjarne
approved these changes
Apr 13, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_process.c
Outdated

CopilotAI
requested review from
Copilot
and removed request for
CopilotApril 13, 2026 10:13
@adamsitnik
adamsitnik
enabled auto-merge (squash)
April 13, 2026 10:16
@adamsitnik
adamsitnik
commented
Apr 13, 2026

Copy link


Copy Markdown

Member
/ba-g WASM build timeout is unrelated
@adamsitnik
adamsitnik
merged commit bf222c5
into
mainApr 13, 2026

174 of 177 checks passed

@adamsitnik
adamsitnik
deleted the

copilot/improve-process-support-maccatalyst

branch
April 13, 2026 14:21
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 15, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 14, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rolfbjarnerolfbjarnerolfbjarne approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@adamsitnikadamsitnikAwaiting requested review from adamsitnik

Assignees

@adamsitnikadamsitnik
Copilot code reviewCopilot

Labels

area-System.Diagnostics.Process

Projects


None yet


Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

Improve Process support on MacCatalyst


5 participants

@adamsitnik@rolfbjarne@jkotas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Improve Process support on MacCatalyst: use posix_spawn - #126478
Merged
adamsitnik merged 10 commits into
mainfrom 
copilot/improve-process-support-maccatalyst
Apr 13, 2026
Merged
Improve Process support on MacCatalyst: use posix_spawn#126478
adamsitnik merged 10 commits into
mainfrom 
copilot/improve-process-support-maccatalyst
Conversation
CopilotAI
commented
Apr 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
MacCatalyst was missing the fast process spawning path available on macOS via posix_spawn. Before this change, MacCatalyst had no working code path in SystemNative_ForkAndExecProcess — it fell through to the #else return -1 fallback with *childPid uninitialized, since both HAVE_FORK (disabled by kernel restriction in configure.cmake) and TARGET_OSX were false for MacCatalyst.
Description
configure.cmake
  • Add check_symbol_exists(posix_spawn_file_actions_addchdir_np spawn.h HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP) to detect availability of posix_spawn_file_actions_addchdir_np at configure time. The existing -Wunguarded-availability flag ensures this check correctly fails for platforms (e.g. MacCatalyst) where the function is marked __API_UNAVAILABLE in the SDK, making the guard future-proof if the function becomes available on those platforms.
src/native/libs/Common/pal_config.h.in
  • Add #cmakedefine01 HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP so the capability macro detected by CMake is emitted into the generated pal_config.h header used by pal_process.c.
Native (pal_process.c)
  • Extend the posix_spawn path to MacCatalyst by changing #if defined(TARGET_OSX) to #if defined(TARGET_OSX) || defined(TARGET_MACCATALYST) for both the argument/initialization guard and the posix_spawn block. Previously, MacCatalyst had no functional code path for process spawning.
  • Extend the leading #if HAVE_FORK || defined(TARGET_OSX) guard to include TARGET_MACCATALYST, ensuring *childPid is properly initialized to -1 and the access() pre-check runs on MacCatalyst.
  • Replace the TARGET_MACCATALYST-specific early-fail block with two capability-based guards:

    • #if !HAVE_FORK — fails fast with errno = ENOTSUP when setCredentials=true, since setuid/setgid-based credential changes require fork, which is blocked by the kernel at runtime on MacCatalyst (EPERM). The in-code comment explains this constraint.
    • #if !HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP — fails fast with errno = ENOTSUP when cwd != NULL, since the function is unavailable on MacCatalyst.
  • Guard the posix_spawn_file_actions_addchdir_np call site with #if HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP (previously #if !defined(TARGET_MACCATALYST)) to fix the build error and make the guard forward-compatible.
  • Move the // Change working directory if specified comment to the end of the posix_spawn_file_actions_addchdir_np line where it belongs.
@adamsitnikadamsitnik
added this to the 11.0.0 milestone
Apr 2, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 2, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process

See info in area-owners.md if you want to be subscribed.
CopilotAI
linked an issue
Apr 2, 2026
that may be
closed
by this pull request


Improve Process support on MacCatalyst
#126472

Closed

CopilotAI
changed the title
[WIP] Improve process support on MacCatalystImprove Process support on MacCatalystApr 2, 2026
CopilotAI
requested a review
from adamsitnikApril 2, 2026 18:47
adamsitnik
adamsitnik
reviewed
Apr 2, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_log.m
Outdated


This was referenced Apr 3, 2026

Open


Open


Closed


Open


Closed


Closed

adamsitnik
adamsitnik
reviewed
Apr 10, 2026
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please address my feedback
Comment threadsrc/native/libs/System.Native/pal_process.c
CopilotAI
requested review from
Copilot
and removed request for
CopilotApril 10, 2026 14:29
CopilotAI
changed the title
Improve Process support on MacCatalystImprove Process support on MacCatalyst: use posix_spawnApr 10, 2026
CopilotAI
requested a review
from adamsitnikApril 10, 2026 14:31
@adamsitnik
Use HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP and HAVE_FORK instead o…
43de386
…f TARGET_MACCATALYST guards
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/e578bc53-d1e7-41bb-ad79-023a0863881a
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
CopilotAI
requested review from
adamsitnik and Copilot
and removed request for
CopilotApril 11, 2026 07:38
adamsitnik
adamsitnik
reviewed
Apr 11, 2026
View reviewed changes
Comment threadsrc/native/libs/configure.cmake
CopilotAI
requested review from
adamsitnik and Copilot
and removed request for
CopilotApril 11, 2026 08:45
@adamsitnik
adamsitnik
commented
Apr 11, 2026

Copy link


Copy Markdown

Member
/azp run runtime-maccatalyst
@azure-pipelines
azure-pipelinesBot
commented
Apr 11, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 11, 2026

Open


Closed

rolfbjarne
rolfbjarne
approved these changes
Apr 13, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_process.c
Outdated

CopilotAI
requested review from
Copilot
and removed request for
CopilotApril 13, 2026 10:13
@adamsitnik
adamsitnik
enabled auto-merge (squash)
April 13, 2026 10:16
@adamsitnik
adamsitnik
commented
Apr 13, 2026

Copy link


Copy Markdown

Member
/ba-g WASM build timeout is unrelated
@adamsitnik
adamsitnik
merged commit bf222c5
into
mainApr 13, 2026

174 of 177 checks passed

@adamsitnik
adamsitnik
deleted the

copilot/improve-process-support-maccatalyst

branch
April 13, 2026 14:21
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 15, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 14, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rolfbjarnerolfbjarnerolfbjarne approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@adamsitnikadamsitnikAwaiting requested review from adamsitnik

Assignees

@adamsitnikadamsitnik
Copilot code reviewCopilot

Labels

area-System.Diagnostics.Process

Projects


None yet


Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

Improve Process support on MacCatalyst


5 participants

@adamsitnik@rolfbjarne@jkotas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Improve Process support on MacCatalyst: use posix_spawn - #126478
Merged
adamsitnik merged 10 commits into
mainfrom 
copilot/improve-process-support-maccatalyst
Apr 13, 2026
Merged
Improve Process support on MacCatalyst: use posix_spawn#126478
adamsitnik merged 10 commits into
mainfrom 
copilot/improve-process-support-maccatalyst
Conversation
CopilotAI
commented
Apr 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
MacCatalyst was missing the fast process spawning path available on macOS via posix_spawn. Before this change, MacCatalyst had no working code path in SystemNative_ForkAndExecProcess — it fell through to the #else return -1 fallback with *childPid uninitialized, since both HAVE_FORK (disabled by kernel restriction in configure.cmake) and TARGET_OSX were false for MacCatalyst.
Description
configure.cmake
  • Add check_symbol_exists(posix_spawn_file_actions_addchdir_np spawn.h HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP) to detect availability of posix_spawn_file_actions_addchdir_np at configure time. The existing -Wunguarded-availability flag ensures this check correctly fails for platforms (e.g. MacCatalyst) where the function is marked __API_UNAVAILABLE in the SDK, making the guard future-proof if the function becomes available on those platforms.
src/native/libs/Common/pal_config.h.in
  • Add #cmakedefine01 HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP so the capability macro detected by CMake is emitted into the generated pal_config.h header used by pal_process.c.
Native (pal_process.c)
  • Extend the posix_spawn path to MacCatalyst by changing #if defined(TARGET_OSX) to #if defined(TARGET_OSX) || defined(TARGET_MACCATALYST) for both the argument/initialization guard and the posix_spawn block. Previously, MacCatalyst had no functional code path for process spawning.
  • Extend the leading #if HAVE_FORK || defined(TARGET_OSX) guard to include TARGET_MACCATALYST, ensuring *childPid is properly initialized to -1 and the access() pre-check runs on MacCatalyst.
  • Replace the TARGET_MACCATALYST-specific early-fail block with two capability-based guards:

    • #if !HAVE_FORK — fails fast with errno = ENOTSUP when setCredentials=true, since setuid/setgid-based credential changes require fork, which is blocked by the kernel at runtime on MacCatalyst (EPERM). The in-code comment explains this constraint.
    • #if !HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP — fails fast with errno = ENOTSUP when cwd != NULL, since the function is unavailable on MacCatalyst.
  • Guard the posix_spawn_file_actions_addchdir_np call site with #if HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP (previously #if !defined(TARGET_MACCATALYST)) to fix the build error and make the guard forward-compatible.
  • Move the // Change working directory if specified comment to the end of the posix_spawn_file_actions_addchdir_np line where it belongs.
@adamsitnikadamsitnik
added this to the 11.0.0 milestone
Apr 2, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 2, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process

See info in area-owners.md if you want to be subscribed.
CopilotAI
linked an issue
Apr 2, 2026
that may be
closed
by this pull request


Improve Process support on MacCatalyst
#126472

Closed

CopilotAI
changed the title
[WIP] Improve process support on MacCatalystImprove Process support on MacCatalystApr 2, 2026
CopilotAI
requested a review
from adamsitnikApril 2, 2026 18:47
adamsitnik
adamsitnik
reviewed
Apr 2, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_log.m
Outdated


This was referenced Apr 3, 2026

Open


Open


Closed


Open


Closed


Closed

adamsitnik
adamsitnik
reviewed
Apr 10, 2026
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please address my feedback
Comment threadsrc/native/libs/System.Native/pal_process.c
CopilotAI
requested review from
Copilot
and removed request for
CopilotApril 10, 2026 14:29
CopilotAI
changed the title
Improve Process support on MacCatalystImprove Process support on MacCatalyst: use posix_spawnApr 10, 2026
CopilotAI
requested a review
from adamsitnikApril 10, 2026 14:31
@adamsitnik
Use HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP and HAVE_FORK instead o…
43de386
…f TARGET_MACCATALYST guards
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/e578bc53-d1e7-41bb-ad79-023a0863881a
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
CopilotAI
requested review from
adamsitnik and Copilot
and removed request for
CopilotApril 11, 2026 07:38
adamsitnik
adamsitnik
reviewed
Apr 11, 2026
View reviewed changes
Comment threadsrc/native/libs/configure.cmake
CopilotAI
requested review from
adamsitnik and Copilot
and removed request for
CopilotApril 11, 2026 08:45
@adamsitnik
adamsitnik
commented
Apr 11, 2026

Copy link


Copy Markdown

Member
/azp run runtime-maccatalyst
@azure-pipelines
azure-pipelinesBot
commented
Apr 11, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 11, 2026

Open


Closed

rolfbjarne
rolfbjarne
approved these changes
Apr 13, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_process.c
Outdated

CopilotAI
requested review from
Copilot
and removed request for
CopilotApril 13, 2026 10:13
@adamsitnik
adamsitnik
enabled auto-merge (squash)
April 13, 2026 10:16
@adamsitnik
adamsitnik
commented
Apr 13, 2026

Copy link


Copy Markdown

Member
/ba-g WASM build timeout is unrelated
@adamsitnik
adamsitnik
merged commit bf222c5
into
mainApr 13, 2026

174 of 177 checks passed

@adamsitnik
adamsitnik
deleted the

copilot/improve-process-support-maccatalyst

branch
April 13, 2026 14:21
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 15, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 14, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rolfbjarnerolfbjarnerolfbjarne approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@adamsitnikadamsitnikAwaiting requested review from adamsitnik

Assignees

@adamsitnikadamsitnik
Copilot code reviewCopilot

Labels

area-System.Diagnostics.Process

Projects


None yet


Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

Improve Process support on MacCatalyst


5 participants

@adamsitnik@rolfbjarne@jkotas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Improve Process support on MacCatalyst: use posix_spawn - #126478
Merged
adamsitnik merged 10 commits into
mainfrom 
copilot/improve-process-support-maccatalyst
Apr 13, 2026
Merged
Improve Process support on MacCatalyst: use posix_spawn#126478
adamsitnik merged 10 commits into
mainfrom 
copilot/improve-process-support-maccatalyst
Conversation
CopilotAI
commented
Apr 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
MacCatalyst was missing the fast process spawning path available on macOS via posix_spawn. Before this change, MacCatalyst had no working code path in SystemNative_ForkAndExecProcess — it fell through to the #else return -1 fallback with *childPid uninitialized, since both HAVE_FORK (disabled by kernel restriction in configure.cmake) and TARGET_OSX were false for MacCatalyst.
Description
configure.cmake
  • Add check_symbol_exists(posix_spawn_file_actions_addchdir_np spawn.h HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP) to detect availability of posix_spawn_file_actions_addchdir_np at configure time. The existing -Wunguarded-availability flag ensures this check correctly fails for platforms (e.g. MacCatalyst) where the function is marked __API_UNAVAILABLE in the SDK, making the guard future-proof if the function becomes available on those platforms.
src/native/libs/Common/pal_config.h.in
  • Add #cmakedefine01 HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP so the capability macro detected by CMake is emitted into the generated pal_config.h header used by pal_process.c.
Native (pal_process.c)
  • Extend the posix_spawn path to MacCatalyst by changing #if defined(TARGET_OSX) to #if defined(TARGET_OSX) || defined(TARGET_MACCATALYST) for both the argument/initialization guard and the posix_spawn block. Previously, MacCatalyst had no functional code path for process spawning.
  • Extend the leading #if HAVE_FORK || defined(TARGET_OSX) guard to include TARGET_MACCATALYST, ensuring *childPid is properly initialized to -1 and the access() pre-check runs on MacCatalyst.
  • Replace the TARGET_MACCATALYST-specific early-fail block with two capability-based guards:

    • #if !HAVE_FORK — fails fast with errno = ENOTSUP when setCredentials=true, since setuid/setgid-based credential changes require fork, which is blocked by the kernel at runtime on MacCatalyst (EPERM). The in-code comment explains this constraint.
    • #if !HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP — fails fast with errno = ENOTSUP when cwd != NULL, since the function is unavailable on MacCatalyst.
  • Guard the posix_spawn_file_actions_addchdir_np call site with #if HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP (previously #if !defined(TARGET_MACCATALYST)) to fix the build error and make the guard forward-compatible.
  • Move the // Change working directory if specified comment to the end of the posix_spawn_file_actions_addchdir_np line where it belongs.
@adamsitnikadamsitnik
added this to the 11.0.0 milestone
Apr 2, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 2, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process

See info in area-owners.md if you want to be subscribed.
CopilotAI
linked an issue
Apr 2, 2026
that may be
closed
by this pull request


Improve Process support on MacCatalyst
#126472

Closed

CopilotAI
changed the title
[WIP] Improve process support on MacCatalystImprove Process support on MacCatalystApr 2, 2026
CopilotAI
requested a review
from adamsitnikApril 2, 2026 18:47
adamsitnik
adamsitnik
reviewed
Apr 2, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_log.m
Outdated


This was referenced Apr 3, 2026

Open


Open


Closed


Open


Closed


Closed

adamsitnik
adamsitnik
reviewed
Apr 10, 2026
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please address my feedback
Comment threadsrc/native/libs/System.Native/pal_process.c
CopilotAI
requested review from
Copilot
and removed request for
CopilotApril 10, 2026 14:29
CopilotAI
changed the title
Improve Process support on MacCatalystImprove Process support on MacCatalyst: use posix_spawnApr 10, 2026
CopilotAI
requested a review
from adamsitnikApril 10, 2026 14:31
@adamsitnik
Use HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP and HAVE_FORK instead o…
43de386
…f TARGET_MACCATALYST guards
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/e578bc53-d1e7-41bb-ad79-023a0863881a
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
CopilotAI
requested review from
adamsitnik and Copilot
and removed request for
CopilotApril 11, 2026 07:38
adamsitnik
adamsitnik
reviewed
Apr 11, 2026
View reviewed changes
Comment threadsrc/native/libs/configure.cmake
CopilotAI
requested review from
adamsitnik and Copilot
and removed request for
CopilotApril 11, 2026 08:45
@adamsitnik
adamsitnik
commented
Apr 11, 2026

Copy link


Copy Markdown

Member
/azp run runtime-maccatalyst
@azure-pipelines
azure-pipelinesBot
commented
Apr 11, 2026

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 11, 2026

Open


Closed

rolfbjarne
rolfbjarne
approved these changes
Apr 13, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_process.c
Outdated

CopilotAI
requested review from
Copilot
and removed request for
CopilotApril 13, 2026 10:13
@adamsitnik
adamsitnik
enabled auto-merge (squash)
April 13, 2026 10:16
@adamsitnik
adamsitnik
commented
Apr 13, 2026

Copy link


Copy Markdown

Member
/ba-g WASM build timeout is unrelated
@adamsitnik
adamsitnik
merged commit bf222c5
into
mainApr 13, 2026

174 of 177 checks passed

@adamsitnik
adamsitnik
deleted the

copilot/improve-process-support-maccatalyst

branch
April 13, 2026 14:21
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 15, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 14, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rolfbjarnerolfbjarnerolfbjarne approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@adamsitnikadamsitnikAwaiting requested review from adamsitnik

Assignees

@adamsitnikadamsitnik
Copilot code reviewCopilot

Labels

area-System.Diagnostics.Process

Projects


None yet


Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

Improve Process support on MacCatalyst


5 participants

@adamsitnik@rolfbjarne@jkotas