[Wasm RyuJit] Call Codegen Fixes for R2R by adamperlin · Pull Request #126778 · dotnet/runtime

adamperlin · 2026-04-10T23:33:31Z

Initially cherry-picked commit from #126662;

This PR:

Adds explicit handling in lowering for managed calls using the PEP calling convention to pass the additional PEP parameter.
Removes some dead code around handling of WellKnownArg::R2RIndireictionCell from wasm code gen.
Adds fixes for helper call codegen to account for the extra level of indirection needed to load a helper call target from a PEP (Portable Entrypoint).

Lowering Transformation Details

The lowering transformation introduces a temp local (call it pep) to hold the PEP, which we then add to a managed call as a final parameter with associated ABI info. We then rewrite the control expr of the call to be *pep. This ensures that, conceptually, any call with an entrypoint of access type PVALUE will be lowered to something roughly like the following, in C notation:

void* pep = *(void**)(<value>);
(*(void**)pep)(arg0, arg1, ..., argN, pep)

…into locations in the R2R file work - Notably, a new level of indirection is needed

… in helper call codegen in Wasm

…-fix-call-codegen

dotnet-policy-service · 2026-04-10T23:34:42Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR adjusts WebAssembly RyuJIT call lowering/emission for ReadyToRun (R2R) so call targets and PortableEntryPoints (PEPs) are loaded through the correct number of indirections when the host exposes symbols as indirection cells (indirection cell -> PEP -> target).

Changes:

Add an extra indirection when materializing the R2R indirection-cell argument on WASM so the value passed reflects the PEP rather than the cell itself.
Update WASM direct-call lowering for IAT_PVALUE to dereference through indirection cell -> PEP -> target.
Update WASM helper-call emission to load the PEP from the indirection cell (for managed helpers) and to load the final call target via an additional dereference.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
`src/coreclr/jit/morph.cpp`	Adds a WASM-specific extra indirection when preparing the R2R indirection-cell argument so the runtime sees the expected PEP pointer.
`src/coreclr/jit/lower.cpp`	Ensures WASM `IAT_PVALUE` direct call targets are lowered with an additional dereference to reach the actual dispatch target.
`src/coreclr/jit/codegenwasm.cpp`	Fixes helper-call emission to load the PEP from the indirection cell and to load the indirect call target by dereferencing the PEP.

AndyAyersMS · 2026-04-11T00:11:37Z

Maybe a picture would be useful here?

I imagine it something like this: We have an indirection cell that refers to a PEP which refers to a function index, which we then call indirectly.

adamperlin · 2026-04-13T22:30:05Z

Maybe a picture would be useful here?
I imagine it something like this: We have an indirection cell that refers to a PEP which refers to a function index, which we then call indirectly.

This is the right mental model! I am attaching a diagram that I created though of calling a function F from generated code:

jkotas · 2026-04-13T22:45:30Z

I am attaching a diagram that I created though of calling a function F from generated code

This picture is missing the part that passes portable entrypoint address (the value fetched from R2R import table) as the hidden argument that it somewhat important detail.

adamperlin · 2026-04-14T00:49:26Z

I am attaching a diagram that I created though of calling a function F from generated code
This picture is missing the part that passes portable entrypoint address (the value fetched from R2R import table) as the hidden argument that it somewhat important detail.

Ah I wasn't sure whether to include that bit, I've updated the diagram to include it!

…-fix-call-codegen

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

adamperlin · 2026-04-27T17:37:04Z

Could I get another review when you have a moment @jkotas @jakobbotsch? I've updated the PR based on your feedback to explicitly handle the PEP calling convention transformation in lower. Thinking about this further exposed some dead case handling in Wasm codegen around the handling of the indirection cell arg which will now not be materialized on wasm. This also exposed a bug in the stackifier that I'm currently working through here: #127412
Also cc'ing @kg due to wasm call codegen changes!

…lin/runtime into adamperlin/wasm-fix-call-codegen

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jakobbotsch

LGTM, feel free to address the ifdef nit in a follow up

This is a fix for an issue that came up in #126778, and is probably easiest to explain with a motivating example. Consider the following case, where NOMOVE is a gentree operation we aren't allowed to move. ``` t2 = ... NOMOVE OP t3 = ... OP t0 = ... NOMOVE OP t1 = ... OP * t3 (arg1) * t2 (arg2) * t1 (arg3) * t0 (target) CALL ``` The stackifier will first introduce a store to put `t0` after `t1`: ``` t2 = ... NOMOVE OP t3 = ... OP t0 = ... OP +** STORE_LCL_VAR tmp0 t1 = ... OP t0 = LCL_VAR tmp0 * t3 (arg1) * t2 (arg2) * t1 (arg3) * t0 (call target) CALL ``` And then recursively stackify the new STORE to tmp0, since it is a dataflow root. *The stackifier then marks tmp0 as free here, since it IS free in linear data flow order*. Then, when the next operands to the call are stackified, the stackifier introduces a temporary again, but reuses t0 because we freed it. ``` t2 = ... OP +** STORE_LCL_VAR tmp0 t3 = ... OP t2 = LCL_VAR tmp0 t0 = ... OP +** STORE_LCL_VAR tmp0 t1 = ... OP t0 = LCL_VAR tmp0 * t3 * t2 * t1 * t0 (target) CALL ``` This produces invalid LIR; there is a store to tmp0 before one of its reads (t2) is consumed. The simplest fix is to not release temporaries for reuse until all operands of a root tree have been processed. This PR adds a free list of temps which is recycled after each root gen tree has been processed, so we won't end up with any interference between temporaries while processing gentree ops which share a parent node. --------- Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

adamperlin · 2026-04-10T23:33:31Z

Initially cherry-picked commit from #126662;

This PR:

Adds explicit handling in lowering for managed calls using the PEP calling convention to pass the additional PEP parameter.
Removes some dead code around handling of WellKnownArg::R2RIndireictionCell from wasm code gen.
Adds fixes for helper call codegen to account for the extra level of indirection needed to load a helper call target from a PEP (Portable Entrypoint).

Lowering Transformation Details

The lowering transformation introduces a temp local (call it pep) to hold the PEP, which we then add to a managed call as a final parameter with associated ABI info. We then rewrite the control expr of the call to be *pep. This ensures that, conceptually, any call with an entrypoint of access type PVALUE will be lowered to something roughly like the following, in C notation:

void* pep = *(void**)(<value>);
(*(void**)pep)(arg0, arg1, ..., argN, pep)

…into locations in the R2R file work - Notably, a new level of indirection is needed

… in helper call codegen in Wasm

…-fix-call-codegen

dotnet-policy-service · 2026-04-10T23:34:42Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR adjusts WebAssembly RyuJIT call lowering/emission for ReadyToRun (R2R) so call targets and PortableEntryPoints (PEPs) are loaded through the correct number of indirections when the host exposes symbols as indirection cells (indirection cell -> PEP -> target).

Changes:

Add an extra indirection when materializing the R2R indirection-cell argument on WASM so the value passed reflects the PEP rather than the cell itself.
Update WASM direct-call lowering for IAT_PVALUE to dereference through indirection cell -> PEP -> target.
Update WASM helper-call emission to load the PEP from the indirection cell (for managed helpers) and to load the final call target via an additional dereference.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
`src/coreclr/jit/morph.cpp`	Adds a WASM-specific extra indirection when preparing the R2R indirection-cell argument so the runtime sees the expected PEP pointer.
`src/coreclr/jit/lower.cpp`	Ensures WASM `IAT_PVALUE` direct call targets are lowered with an additional dereference to reach the actual dispatch target.
`src/coreclr/jit/codegenwasm.cpp`	Fixes helper-call emission to load the PEP from the indirection cell and to load the indirect call target by dereferencing the PEP.

AndyAyersMS · 2026-04-11T00:11:37Z

Maybe a picture would be useful here?

I imagine it something like this: We have an indirection cell that refers to a PEP which refers to a function index, which we then call indirectly.

adamperlin · 2026-04-13T22:30:05Z

Maybe a picture would be useful here?
I imagine it something like this: We have an indirection cell that refers to a PEP which refers to a function index, which we then call indirectly.

This is the right mental model! I am attaching a diagram that I created though of calling a function F from generated code:

jkotas · 2026-04-13T22:45:30Z

I am attaching a diagram that I created though of calling a function F from generated code

This picture is missing the part that passes portable entrypoint address (the value fetched from R2R import table) as the hidden argument that it somewhat important detail.

adamperlin · 2026-04-14T00:49:26Z

I am attaching a diagram that I created though of calling a function F from generated code
This picture is missing the part that passes portable entrypoint address (the value fetched from R2R import table) as the hidden argument that it somewhat important detail.

Ah I wasn't sure whether to include that bit, I've updated the diagram to include it!

…-fix-call-codegen

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

adamperlin · 2026-04-27T17:37:04Z

Could I get another review when you have a moment @jkotas @jakobbotsch? I've updated the PR based on your feedback to explicitly handle the PEP calling convention transformation in lower. Thinking about this further exposed some dead case handling in Wasm codegen around the handling of the indirection cell arg which will now not be materialized on wasm. This also exposed a bug in the stackifier that I'm currently working through here: #127412
Also cc'ing @kg due to wasm call codegen changes!

…lin/runtime into adamperlin/wasm-fix-call-codegen

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jakobbotsch

LGTM, feel free to address the ifdef nit in a follow up

This is a fix for an issue that came up in #126778, and is probably easiest to explain with a motivating example. Consider the following case, where NOMOVE is a gentree operation we aren't allowed to move. ``` t2 = ... NOMOVE OP t3 = ... OP t0 = ... NOMOVE OP t1 = ... OP * t3 (arg1) * t2 (arg2) * t1 (arg3) * t0 (target) CALL ``` The stackifier will first introduce a store to put `t0` after `t1`: ``` t2 = ... NOMOVE OP t3 = ... OP t0 = ... OP +** STORE_LCL_VAR tmp0 t1 = ... OP t0 = LCL_VAR tmp0 * t3 (arg1) * t2 (arg2) * t1 (arg3) * t0 (call target) CALL ``` And then recursively stackify the new STORE to tmp0, since it is a dataflow root. *The stackifier then marks tmp0 as free here, since it IS free in linear data flow order*. Then, when the next operands to the call are stackified, the stackifier introduces a temporary again, but reuses t0 because we freed it. ``` t2 = ... OP +** STORE_LCL_VAR tmp0 t3 = ... OP t2 = LCL_VAR tmp0 t0 = ... OP +** STORE_LCL_VAR tmp0 t1 = ... OP t0 = LCL_VAR tmp0 * t3 * t2 * t1 * t0 (target) CALL ``` This produces invalid LIR; there is a store to tmp0 before one of its reads (t2) is consumed. The simplest fix is to not release temporaries for reuse until all operands of a root tree have been processed. This PR adds a free list of temps which is recycled after each root gen tree has been processed, so we won't end up with any interference between temporaries while processing gentree ops which share a parent node. --------- Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

adamperlin · 2026-04-10T23:33:31Z

Initially cherry-picked commit from #126662;

This PR:

Adds explicit handling in lowering for managed calls using the PEP calling convention to pass the additional PEP parameter.
Removes some dead code around handling of WellKnownArg::R2RIndireictionCell from wasm code gen.
Adds fixes for helper call codegen to account for the extra level of indirection needed to load a helper call target from a PEP (Portable Entrypoint).

Lowering Transformation Details

The lowering transformation introduces a temp local (call it pep) to hold the PEP, which we then add to a managed call as a final parameter with associated ABI info. We then rewrite the control expr of the call to be *pep. This ensures that, conceptually, any call with an entrypoint of access type PVALUE will be lowered to something roughly like the following, in C notation:

void* pep = *(void**)(<value>);
(*(void**)pep)(arg0, arg1, ..., argN, pep)

…into locations in the R2R file work - Notably, a new level of indirection is needed

… in helper call codegen in Wasm

…-fix-call-codegen

dotnet-policy-service · 2026-04-10T23:34:42Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR adjusts WebAssembly RyuJIT call lowering/emission for ReadyToRun (R2R) so call targets and PortableEntryPoints (PEPs) are loaded through the correct number of indirections when the host exposes symbols as indirection cells (indirection cell -> PEP -> target).

Changes:

Add an extra indirection when materializing the R2R indirection-cell argument on WASM so the value passed reflects the PEP rather than the cell itself.
Update WASM direct-call lowering for IAT_PVALUE to dereference through indirection cell -> PEP -> target.
Update WASM helper-call emission to load the PEP from the indirection cell (for managed helpers) and to load the final call target via an additional dereference.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
`src/coreclr/jit/morph.cpp`	Adds a WASM-specific extra indirection when preparing the R2R indirection-cell argument so the runtime sees the expected PEP pointer.
`src/coreclr/jit/lower.cpp`	Ensures WASM `IAT_PVALUE` direct call targets are lowered with an additional dereference to reach the actual dispatch target.
`src/coreclr/jit/codegenwasm.cpp`	Fixes helper-call emission to load the PEP from the indirection cell and to load the indirect call target by dereferencing the PEP.

AndyAyersMS · 2026-04-11T00:11:37Z

Maybe a picture would be useful here?

I imagine it something like this: We have an indirection cell that refers to a PEP which refers to a function index, which we then call indirectly.

adamperlin · 2026-04-13T22:30:05Z

Maybe a picture would be useful here?
I imagine it something like this: We have an indirection cell that refers to a PEP which refers to a function index, which we then call indirectly.

This is the right mental model! I am attaching a diagram that I created though of calling a function F from generated code:

jkotas · 2026-04-13T22:45:30Z

I am attaching a diagram that I created though of calling a function F from generated code

This picture is missing the part that passes portable entrypoint address (the value fetched from R2R import table) as the hidden argument that it somewhat important detail.

adamperlin · 2026-04-14T00:49:26Z

I am attaching a diagram that I created though of calling a function F from generated code
This picture is missing the part that passes portable entrypoint address (the value fetched from R2R import table) as the hidden argument that it somewhat important detail.

Ah I wasn't sure whether to include that bit, I've updated the diagram to include it!

…-fix-call-codegen

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

adamperlin · 2026-04-27T17:37:04Z

Could I get another review when you have a moment @jkotas @jakobbotsch? I've updated the PR based on your feedback to explicitly handle the PEP calling convention transformation in lower. Thinking about this further exposed some dead case handling in Wasm codegen around the handling of the indirection cell arg which will now not be materialized on wasm. This also exposed a bug in the stackifier that I'm currently working through here: #127412
Also cc'ing @kg due to wasm call codegen changes!

…lin/runtime into adamperlin/wasm-fix-call-codegen

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jakobbotsch

LGTM, feel free to address the ifdef nit in a follow up

This is a fix for an issue that came up in #126778, and is probably easiest to explain with a motivating example. Consider the following case, where NOMOVE is a gentree operation we aren't allowed to move. ``` t2 = ... NOMOVE OP t3 = ... OP t0 = ... NOMOVE OP t1 = ... OP * t3 (arg1) * t2 (arg2) * t1 (arg3) * t0 (target) CALL ``` The stackifier will first introduce a store to put `t0` after `t1`: ``` t2 = ... NOMOVE OP t3 = ... OP t0 = ... OP +** STORE_LCL_VAR tmp0 t1 = ... OP t0 = LCL_VAR tmp0 * t3 (arg1) * t2 (arg2) * t1 (arg3) * t0 (call target) CALL ``` And then recursively stackify the new STORE to tmp0, since it is a dataflow root. *The stackifier then marks tmp0 as free here, since it IS free in linear data flow order*. Then, when the next operands to the call are stackified, the stackifier introduces a temporary again, but reuses t0 because we freed it. ``` t2 = ... OP +** STORE_LCL_VAR tmp0 t3 = ... OP t2 = LCL_VAR tmp0 t0 = ... OP +** STORE_LCL_VAR tmp0 t1 = ... OP t0 = LCL_VAR tmp0 * t3 * t2 * t1 * t0 (target) CALL ``` This produces invalid LIR; there is a store to tmp0 before one of its reads (t2) is consumed. The simplest fix is to not release temporaries for reuse until all operands of a root tree have been processed. This PR adds a free list of temps which is recycled after each root gen tree has been processed, so we won't end up with any interference between temporaries while processing gentree ops which share a parent node. --------- Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

adamperlin · 2026-04-10T23:33:31Z

Initially cherry-picked commit from #126662;

This PR:

Adds explicit handling in lowering for managed calls using the PEP calling convention to pass the additional PEP parameter.
Removes some dead code around handling of WellKnownArg::R2RIndireictionCell from wasm code gen.
Adds fixes for helper call codegen to account for the extra level of indirection needed to load a helper call target from a PEP (Portable Entrypoint).

Lowering Transformation Details

The lowering transformation introduces a temp local (call it pep) to hold the PEP, which we then add to a managed call as a final parameter with associated ABI info. We then rewrite the control expr of the call to be *pep. This ensures that, conceptually, any call with an entrypoint of access type PVALUE will be lowered to something roughly like the following, in C notation:

void* pep = *(void**)(<value>);
(*(void**)pep)(arg0, arg1, ..., argN, pep)

…into locations in the R2R file work - Notably, a new level of indirection is needed

… in helper call codegen in Wasm

…-fix-call-codegen

dotnet-policy-service · 2026-04-10T23:34:42Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR adjusts WebAssembly RyuJIT call lowering/emission for ReadyToRun (R2R) so call targets and PortableEntryPoints (PEPs) are loaded through the correct number of indirections when the host exposes symbols as indirection cells (indirection cell -> PEP -> target).

Changes:

Add an extra indirection when materializing the R2R indirection-cell argument on WASM so the value passed reflects the PEP rather than the cell itself.
Update WASM direct-call lowering for IAT_PVALUE to dereference through indirection cell -> PEP -> target.
Update WASM helper-call emission to load the PEP from the indirection cell (for managed helpers) and to load the final call target via an additional dereference.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
`src/coreclr/jit/morph.cpp`	Adds a WASM-specific extra indirection when preparing the R2R indirection-cell argument so the runtime sees the expected PEP pointer.
`src/coreclr/jit/lower.cpp`	Ensures WASM `IAT_PVALUE` direct call targets are lowered with an additional dereference to reach the actual dispatch target.
`src/coreclr/jit/codegenwasm.cpp`	Fixes helper-call emission to load the PEP from the indirection cell and to load the indirect call target by dereferencing the PEP.

AndyAyersMS · 2026-04-11T00:11:37Z

Maybe a picture would be useful here?

I imagine it something like this: We have an indirection cell that refers to a PEP which refers to a function index, which we then call indirectly.

adamperlin · 2026-04-13T22:30:05Z

Maybe a picture would be useful here?
I imagine it something like this: We have an indirection cell that refers to a PEP which refers to a function index, which we then call indirectly.

This is the right mental model! I am attaching a diagram that I created though of calling a function F from generated code:

jkotas · 2026-04-13T22:45:30Z

I am attaching a diagram that I created though of calling a function F from generated code

This picture is missing the part that passes portable entrypoint address (the value fetched from R2R import table) as the hidden argument that it somewhat important detail.

adamperlin · 2026-04-14T00:49:26Z

I am attaching a diagram that I created though of calling a function F from generated code
This picture is missing the part that passes portable entrypoint address (the value fetched from R2R import table) as the hidden argument that it somewhat important detail.

Ah I wasn't sure whether to include that bit, I've updated the diagram to include it!

…-fix-call-codegen

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

adamperlin · 2026-04-27T17:37:04Z

Could I get another review when you have a moment @jkotas @jakobbotsch? I've updated the PR based on your feedback to explicitly handle the PEP calling convention transformation in lower. Thinking about this further exposed some dead case handling in Wasm codegen around the handling of the indirection cell arg which will now not be materialized on wasm. This also exposed a bug in the stackifier that I'm currently working through here: #127412
Also cc'ing @kg due to wasm call codegen changes!

…lin/runtime into adamperlin/wasm-fix-call-codegen

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jakobbotsch

LGTM, feel free to address the ifdef nit in a follow up

This is a fix for an issue that came up in #126778, and is probably easiest to explain with a motivating example. Consider the following case, where NOMOVE is a gentree operation we aren't allowed to move. ``` t2 = ... NOMOVE OP t3 = ... OP t0 = ... NOMOVE OP t1 = ... OP * t3 (arg1) * t2 (arg2) * t1 (arg3) * t0 (target) CALL ``` The stackifier will first introduce a store to put `t0` after `t1`: ``` t2 = ... NOMOVE OP t3 = ... OP t0 = ... OP +** STORE_LCL_VAR tmp0 t1 = ... OP t0 = LCL_VAR tmp0 * t3 (arg1) * t2 (arg2) * t1 (arg3) * t0 (call target) CALL ``` And then recursively stackify the new STORE to tmp0, since it is a dataflow root. *The stackifier then marks tmp0 as free here, since it IS free in linear data flow order*. Then, when the next operands to the call are stackified, the stackifier introduces a temporary again, but reuses t0 because we freed it. ``` t2 = ... OP +** STORE_LCL_VAR tmp0 t3 = ... OP t2 = LCL_VAR tmp0 t0 = ... OP +** STORE_LCL_VAR tmp0 t1 = ... OP t0 = LCL_VAR tmp0 * t3 * t2 * t1 * t0 (target) CALL ``` This produces invalid LIR; there is a store to tmp0 before one of its reads (t2) is consumed. The simplest fix is to not release temporaries for reuse until all operands of a root tree have been processed. This PR adds a free list of temps which is recycled after each root gen tree has been processed, so we won't end up with any interference between temporaries while processing gentree ops which share a parent node. --------- Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

adamperlin · 2026-04-10T23:33:31Z

Initially cherry-picked commit from #126662;

This PR:

Adds explicit handling in lowering for managed calls using the PEP calling convention to pass the additional PEP parameter.
Removes some dead code around handling of WellKnownArg::R2RIndireictionCell from wasm code gen.
Adds fixes for helper call codegen to account for the extra level of indirection needed to load a helper call target from a PEP (Portable Entrypoint).

Lowering Transformation Details

The lowering transformation introduces a temp local (call it pep) to hold the PEP, which we then add to a managed call as a final parameter with associated ABI info. We then rewrite the control expr of the call to be *pep. This ensures that, conceptually, any call with an entrypoint of access type PVALUE will be lowered to something roughly like the following, in C notation:

void* pep = *(void**)(<value>);
(*(void**)pep)(arg0, arg1, ..., argN, pep)

…into locations in the R2R file work - Notably, a new level of indirection is needed

… in helper call codegen in Wasm

…-fix-call-codegen

dotnet-policy-service · 2026-04-10T23:34:42Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR adjusts WebAssembly RyuJIT call lowering/emission for ReadyToRun (R2R) so call targets and PortableEntryPoints (PEPs) are loaded through the correct number of indirections when the host exposes symbols as indirection cells (indirection cell -> PEP -> target).

Changes:

Add an extra indirection when materializing the R2R indirection-cell argument on WASM so the value passed reflects the PEP rather than the cell itself.
Update WASM direct-call lowering for IAT_PVALUE to dereference through indirection cell -> PEP -> target.
Update WASM helper-call emission to load the PEP from the indirection cell (for managed helpers) and to load the final call target via an additional dereference.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
`src/coreclr/jit/morph.cpp`	Adds a WASM-specific extra indirection when preparing the R2R indirection-cell argument so the runtime sees the expected PEP pointer.
`src/coreclr/jit/lower.cpp`	Ensures WASM `IAT_PVALUE` direct call targets are lowered with an additional dereference to reach the actual dispatch target.
`src/coreclr/jit/codegenwasm.cpp`	Fixes helper-call emission to load the PEP from the indirection cell and to load the indirect call target by dereferencing the PEP.

AndyAyersMS · 2026-04-11T00:11:37Z

Maybe a picture would be useful here?

I imagine it something like this: We have an indirection cell that refers to a PEP which refers to a function index, which we then call indirectly.

adamperlin · 2026-04-13T22:30:05Z

Maybe a picture would be useful here?
I imagine it something like this: We have an indirection cell that refers to a PEP which refers to a function index, which we then call indirectly.

This is the right mental model! I am attaching a diagram that I created though of calling a function F from generated code:

jkotas · 2026-04-13T22:45:30Z

I am attaching a diagram that I created though of calling a function F from generated code

This picture is missing the part that passes portable entrypoint address (the value fetched from R2R import table) as the hidden argument that it somewhat important detail.

adamperlin · 2026-04-14T00:49:26Z

I am attaching a diagram that I created though of calling a function F from generated code
This picture is missing the part that passes portable entrypoint address (the value fetched from R2R import table) as the hidden argument that it somewhat important detail.

Ah I wasn't sure whether to include that bit, I've updated the diagram to include it!

…-fix-call-codegen

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

adamperlin · 2026-04-27T17:37:04Z

Could I get another review when you have a moment @jkotas @jakobbotsch? I've updated the PR based on your feedback to explicitly handle the PEP calling convention transformation in lower. Thinking about this further exposed some dead case handling in Wasm codegen around the handling of the indirection cell arg which will now not be materialized on wasm. This also exposed a bug in the stackifier that I'm currently working through here: #127412
Also cc'ing @kg due to wasm call codegen changes!

…lin/runtime into adamperlin/wasm-fix-call-codegen

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jakobbotsch

LGTM, feel free to address the ifdef nit in a follow up

This is a fix for an issue that came up in #126778, and is probably easiest to explain with a motivating example. Consider the following case, where NOMOVE is a gentree operation we aren't allowed to move. ``` t2 = ... NOMOVE OP t3 = ... OP t0 = ... NOMOVE OP t1 = ... OP * t3 (arg1) * t2 (arg2) * t1 (arg3) * t0 (target) CALL ``` The stackifier will first introduce a store to put `t0` after `t1`: ``` t2 = ... NOMOVE OP t3 = ... OP t0 = ... OP +** STORE_LCL_VAR tmp0 t1 = ... OP t0 = LCL_VAR tmp0 * t3 (arg1) * t2 (arg2) * t1 (arg3) * t0 (call target) CALL ``` And then recursively stackify the new STORE to tmp0, since it is a dataflow root. *The stackifier then marks tmp0 as free here, since it IS free in linear data flow order*. Then, when the next operands to the call are stackified, the stackifier introduces a temporary again, but reuses t0 because we freed it. ``` t2 = ... OP +** STORE_LCL_VAR tmp0 t3 = ... OP t2 = LCL_VAR tmp0 t0 = ... OP +** STORE_LCL_VAR tmp0 t1 = ... OP t0 = LCL_VAR tmp0 * t3 * t2 * t1 * t0 (target) CALL ``` This produces invalid LIR; there is a store to tmp0 before one of its reads (t2) is consumed. The simplest fix is to not release temporaries for reuse until all operands of a root tree have been processed. This PR adds a free list of temps which is recycled after each root gen tree has been processed, so we won't end up with any interference between temporaries while processing gentree ops which share a parent node. --------- Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

adamperlin · 2026-04-10T23:33:31Z

Initially cherry-picked commit from #126662;

This PR:

Adds explicit handling in lowering for managed calls using the PEP calling convention to pass the additional PEP parameter.
Removes some dead code around handling of WellKnownArg::R2RIndireictionCell from wasm code gen.
Adds fixes for helper call codegen to account for the extra level of indirection needed to load a helper call target from a PEP (Portable Entrypoint).

Lowering Transformation Details

The lowering transformation introduces a temp local (call it pep) to hold the PEP, which we then add to a managed call as a final parameter with associated ABI info. We then rewrite the control expr of the call to be *pep. This ensures that, conceptually, any call with an entrypoint of access type PVALUE will be lowered to something roughly like the following, in C notation:

void* pep = *(void**)(<value>);
(*(void**)pep)(arg0, arg1, ..., argN, pep)

…into locations in the R2R file work - Notably, a new level of indirection is needed

… in helper call codegen in Wasm

…-fix-call-codegen

dotnet-policy-service · 2026-04-10T23:34:42Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR adjusts WebAssembly RyuJIT call lowering/emission for ReadyToRun (R2R) so call targets and PortableEntryPoints (PEPs) are loaded through the correct number of indirections when the host exposes symbols as indirection cells (indirection cell -> PEP -> target).

Changes:

Add an extra indirection when materializing the R2R indirection-cell argument on WASM so the value passed reflects the PEP rather than the cell itself.
Update WASM direct-call lowering for IAT_PVALUE to dereference through indirection cell -> PEP -> target.
Update WASM helper-call emission to load the PEP from the indirection cell (for managed helpers) and to load the final call target via an additional dereference.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
`src/coreclr/jit/morph.cpp`	Adds a WASM-specific extra indirection when preparing the R2R indirection-cell argument so the runtime sees the expected PEP pointer.
`src/coreclr/jit/lower.cpp`	Ensures WASM `IAT_PVALUE` direct call targets are lowered with an additional dereference to reach the actual dispatch target.
`src/coreclr/jit/codegenwasm.cpp`	Fixes helper-call emission to load the PEP from the indirection cell and to load the indirect call target by dereferencing the PEP.

AndyAyersMS · 2026-04-11T00:11:37Z

Maybe a picture would be useful here?

I imagine it something like this: We have an indirection cell that refers to a PEP which refers to a function index, which we then call indirectly.

adamperlin · 2026-04-13T22:30:05Z

Maybe a picture would be useful here?
I imagine it something like this: We have an indirection cell that refers to a PEP which refers to a function index, which we then call indirectly.

This is the right mental model! I am attaching a diagram that I created though of calling a function F from generated code:

jkotas · 2026-04-13T22:45:30Z

I am attaching a diagram that I created though of calling a function F from generated code

This picture is missing the part that passes portable entrypoint address (the value fetched from R2R import table) as the hidden argument that it somewhat important detail.

adamperlin · 2026-04-14T00:49:26Z

I am attaching a diagram that I created though of calling a function F from generated code
This picture is missing the part that passes portable entrypoint address (the value fetched from R2R import table) as the hidden argument that it somewhat important detail.

Ah I wasn't sure whether to include that bit, I've updated the diagram to include it!

…-fix-call-codegen

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

adamperlin · 2026-04-27T17:37:04Z

Could I get another review when you have a moment @jkotas @jakobbotsch? I've updated the PR based on your feedback to explicitly handle the PEP calling convention transformation in lower. Thinking about this further exposed some dead case handling in Wasm codegen around the handling of the indirection cell arg which will now not be materialized on wasm. This also exposed a bug in the stackifier that I'm currently working through here: #127412
Also cc'ing @kg due to wasm call codegen changes!

…lin/runtime into adamperlin/wasm-fix-call-codegen

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jakobbotsch

LGTM, feel free to address the ifdef nit in a follow up

This is a fix for an issue that came up in #126778, and is probably easiest to explain with a motivating example. Consider the following case, where NOMOVE is a gentree operation we aren't allowed to move. ``` t2 = ... NOMOVE OP t3 = ... OP t0 = ... NOMOVE OP t1 = ... OP * t3 (arg1) * t2 (arg2) * t1 (arg3) * t0 (target) CALL ``` The stackifier will first introduce a store to put `t0` after `t1`: ``` t2 = ... NOMOVE OP t3 = ... OP t0 = ... OP +** STORE_LCL_VAR tmp0 t1 = ... OP t0 = LCL_VAR tmp0 * t3 (arg1) * t2 (arg2) * t1 (arg3) * t0 (call target) CALL ``` And then recursively stackify the new STORE to tmp0, since it is a dataflow root. *The stackifier then marks tmp0 as free here, since it IS free in linear data flow order*. Then, when the next operands to the call are stackified, the stackifier introduces a temporary again, but reuses t0 because we freed it. ``` t2 = ... OP +** STORE_LCL_VAR tmp0 t3 = ... OP t2 = LCL_VAR tmp0 t0 = ... OP +** STORE_LCL_VAR tmp0 t1 = ... OP t0 = LCL_VAR tmp0 * t3 * t2 * t1 * t0 (target) CALL ``` This produces invalid LIR; there is a store to tmp0 before one of its reads (t2) is consumed. The simplest fix is to not release temporaries for reuse until all operands of a root tree have been processed. This PR adds a free list of temps which is recycled after each root gen tree has been processed, so we won't end up with any interference between temporaries while processing gentree ops which share a parent node. --------- Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

adamperlin · 2026-04-10T23:33:31Z

Initially cherry-picked commit from #126662;

This PR:

Adds explicit handling in lowering for managed calls using the PEP calling convention to pass the additional PEP parameter.
Removes some dead code around handling of WellKnownArg::R2RIndireictionCell from wasm code gen.
Adds fixes for helper call codegen to account for the extra level of indirection needed to load a helper call target from a PEP (Portable Entrypoint).

Lowering Transformation Details

The lowering transformation introduces a temp local (call it pep) to hold the PEP, which we then add to a managed call as a final parameter with associated ABI info. We then rewrite the control expr of the call to be *pep. This ensures that, conceptually, any call with an entrypoint of access type PVALUE will be lowered to something roughly like the following, in C notation:

void* pep = *(void**)(<value>);
(*(void**)pep)(arg0, arg1, ..., argN, pep)

…into locations in the R2R file work - Notably, a new level of indirection is needed

… in helper call codegen in Wasm

…-fix-call-codegen

dotnet-policy-service · 2026-04-10T23:34:42Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR adjusts WebAssembly RyuJIT call lowering/emission for ReadyToRun (R2R) so call targets and PortableEntryPoints (PEPs) are loaded through the correct number of indirections when the host exposes symbols as indirection cells (indirection cell -> PEP -> target).

Changes:

Add an extra indirection when materializing the R2R indirection-cell argument on WASM so the value passed reflects the PEP rather than the cell itself.
Update WASM direct-call lowering for IAT_PVALUE to dereference through indirection cell -> PEP -> target.
Update WASM helper-call emission to load the PEP from the indirection cell (for managed helpers) and to load the final call target via an additional dereference.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
`src/coreclr/jit/morph.cpp`	Adds a WASM-specific extra indirection when preparing the R2R indirection-cell argument so the runtime sees the expected PEP pointer.
`src/coreclr/jit/lower.cpp`	Ensures WASM `IAT_PVALUE` direct call targets are lowered with an additional dereference to reach the actual dispatch target.
`src/coreclr/jit/codegenwasm.cpp`	Fixes helper-call emission to load the PEP from the indirection cell and to load the indirect call target by dereferencing the PEP.

AndyAyersMS · 2026-04-11T00:11:37Z

Maybe a picture would be useful here?

I imagine it something like this: We have an indirection cell that refers to a PEP which refers to a function index, which we then call indirectly.

adamperlin · 2026-04-13T22:30:05Z

Maybe a picture would be useful here?
I imagine it something like this: We have an indirection cell that refers to a PEP which refers to a function index, which we then call indirectly.

This is the right mental model! I am attaching a diagram that I created though of calling a function F from generated code:

jkotas · 2026-04-13T22:45:30Z

I am attaching a diagram that I created though of calling a function F from generated code

This picture is missing the part that passes portable entrypoint address (the value fetched from R2R import table) as the hidden argument that it somewhat important detail.

adamperlin · 2026-04-14T00:49:26Z

I am attaching a diagram that I created though of calling a function F from generated code
This picture is missing the part that passes portable entrypoint address (the value fetched from R2R import table) as the hidden argument that it somewhat important detail.

Ah I wasn't sure whether to include that bit, I've updated the diagram to include it!

…-fix-call-codegen

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

adamperlin · 2026-04-27T17:37:04Z

Could I get another review when you have a moment @jkotas @jakobbotsch? I've updated the PR based on your feedback to explicitly handle the PEP calling convention transformation in lower. Thinking about this further exposed some dead case handling in Wasm codegen around the handling of the indirection cell arg which will now not be materialized on wasm. This also exposed a bug in the stackifier that I'm currently working through here: #127412
Also cc'ing @kg due to wasm call codegen changes!

…lin/runtime into adamperlin/wasm-fix-call-codegen

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jakobbotsch

LGTM, feel free to address the ifdef nit in a follow up

This is a fix for an issue that came up in #126778, and is probably easiest to explain with a motivating example. Consider the following case, where NOMOVE is a gentree operation we aren't allowed to move. ``` t2 = ... NOMOVE OP t3 = ... OP t0 = ... NOMOVE OP t1 = ... OP * t3 (arg1) * t2 (arg2) * t1 (arg3) * t0 (target) CALL ``` The stackifier will first introduce a store to put `t0` after `t1`: ``` t2 = ... NOMOVE OP t3 = ... OP t0 = ... OP +** STORE_LCL_VAR tmp0 t1 = ... OP t0 = LCL_VAR tmp0 * t3 (arg1) * t2 (arg2) * t1 (arg3) * t0 (call target) CALL ``` And then recursively stackify the new STORE to tmp0, since it is a dataflow root. *The stackifier then marks tmp0 as free here, since it IS free in linear data flow order*. Then, when the next operands to the call are stackified, the stackifier introduces a temporary again, but reuses t0 because we freed it. ``` t2 = ... OP +** STORE_LCL_VAR tmp0 t3 = ... OP t2 = LCL_VAR tmp0 t0 = ... OP +** STORE_LCL_VAR tmp0 t1 = ... OP t0 = LCL_VAR tmp0 * t3 * t2 * t1 * t0 (target) CALL ``` This produces invalid LIR; there is a store to tmp0 before one of its reads (t2) is consumed. The simplest fix is to not release temporaries for reuse until all operands of a root tree have been processed. This PR adds a free list of temps which is recycled after each root gen tree has been processed, so we won't end up with any interference between temporaries while processing gentree ops which share a parent node. --------- Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

adamperlin · 2026-04-10T23:33:31Z

Initially cherry-picked commit from #126662;

This PR:

Adds explicit handling in lowering for managed calls using the PEP calling convention to pass the additional PEP parameter.
Removes some dead code around handling of WellKnownArg::R2RIndireictionCell from wasm code gen.
Adds fixes for helper call codegen to account for the extra level of indirection needed to load a helper call target from a PEP (Portable Entrypoint).

Lowering Transformation Details

The lowering transformation introduces a temp local (call it pep) to hold the PEP, which we then add to a managed call as a final parameter with associated ABI info. We then rewrite the control expr of the call to be *pep. This ensures that, conceptually, any call with an entrypoint of access type PVALUE will be lowered to something roughly like the following, in C notation:

void* pep = *(void**)(<value>);
(*(void**)pep)(arg0, arg1, ..., argN, pep)

…into locations in the R2R file work - Notably, a new level of indirection is needed

… in helper call codegen in Wasm

…-fix-call-codegen

dotnet-policy-service · 2026-04-10T23:34:42Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR adjusts WebAssembly RyuJIT call lowering/emission for ReadyToRun (R2R) so call targets and PortableEntryPoints (PEPs) are loaded through the correct number of indirections when the host exposes symbols as indirection cells (indirection cell -> PEP -> target).

Changes:

Add an extra indirection when materializing the R2R indirection-cell argument on WASM so the value passed reflects the PEP rather than the cell itself.
Update WASM direct-call lowering for IAT_PVALUE to dereference through indirection cell -> PEP -> target.
Update WASM helper-call emission to load the PEP from the indirection cell (for managed helpers) and to load the final call target via an additional dereference.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
`src/coreclr/jit/morph.cpp`	Adds a WASM-specific extra indirection when preparing the R2R indirection-cell argument so the runtime sees the expected PEP pointer.
`src/coreclr/jit/lower.cpp`	Ensures WASM `IAT_PVALUE` direct call targets are lowered with an additional dereference to reach the actual dispatch target.
`src/coreclr/jit/codegenwasm.cpp`	Fixes helper-call emission to load the PEP from the indirection cell and to load the indirect call target by dereferencing the PEP.

AndyAyersMS · 2026-04-11T00:11:37Z

Maybe a picture would be useful here?

I imagine it something like this: We have an indirection cell that refers to a PEP which refers to a function index, which we then call indirectly.

adamperlin · 2026-04-13T22:30:05Z

Maybe a picture would be useful here?
I imagine it something like this: We have an indirection cell that refers to a PEP which refers to a function index, which we then call indirectly.

This is the right mental model! I am attaching a diagram that I created though of calling a function F from generated code:

jkotas · 2026-04-13T22:45:30Z

I am attaching a diagram that I created though of calling a function F from generated code

This picture is missing the part that passes portable entrypoint address (the value fetched from R2R import table) as the hidden argument that it somewhat important detail.

adamperlin · 2026-04-14T00:49:26Z

I am attaching a diagram that I created though of calling a function F from generated code
This picture is missing the part that passes portable entrypoint address (the value fetched from R2R import table) as the hidden argument that it somewhat important detail.

Ah I wasn't sure whether to include that bit, I've updated the diagram to include it!

…-fix-call-codegen

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

adamperlin · 2026-04-27T17:37:04Z

Could I get another review when you have a moment @jkotas @jakobbotsch? I've updated the PR based on your feedback to explicitly handle the PEP calling convention transformation in lower. Thinking about this further exposed some dead case handling in Wasm codegen around the handling of the indirection cell arg which will now not be materialized on wasm. This also exposed a bug in the stackifier that I'm currently working through here: #127412
Also cc'ing @kg due to wasm call codegen changes!

…lin/runtime into adamperlin/wasm-fix-call-codegen

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jakobbotsch

LGTM, feel free to address the ifdef nit in a follow up

This is a fix for an issue that came up in #126778, and is probably easiest to explain with a motivating example. Consider the following case, where NOMOVE is a gentree operation we aren't allowed to move. ``` t2 = ... NOMOVE OP t3 = ... OP t0 = ... NOMOVE OP t1 = ... OP * t3 (arg1) * t2 (arg2) * t1 (arg3) * t0 (target) CALL ``` The stackifier will first introduce a store to put `t0` after `t1`: ``` t2 = ... NOMOVE OP t3 = ... OP t0 = ... OP +** STORE_LCL_VAR tmp0 t1 = ... OP t0 = LCL_VAR tmp0 * t3 (arg1) * t2 (arg2) * t1 (arg3) * t0 (call target) CALL ``` And then recursively stackify the new STORE to tmp0, since it is a dataflow root. *The stackifier then marks tmp0 as free here, since it IS free in linear data flow order*. Then, when the next operands to the call are stackified, the stackifier introduces a temporary again, but reuses t0 because we freed it. ``` t2 = ... OP +** STORE_LCL_VAR tmp0 t3 = ... OP t2 = LCL_VAR tmp0 t0 = ... OP +** STORE_LCL_VAR tmp0 t1 = ... OP t0 = LCL_VAR tmp0 * t3 * t2 * t1 * t0 (target) CALL ``` This produces invalid LIR; there is a store to tmp0 before one of its reads (t2) is consumed. The simplest fix is to not release temporaries for reuse until all operands of a root tree have been processed. This PR adds a free list of temps which is recycled after each root gen tree has been processed, so we won't end up with any interference between temporaries while processing gentree ops which share a parent node. --------- Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

davidwrightonand others added 3 commits April 9, 2026 13:44

Add codegen changes to make calls through PortableEntryPoints stored …
0b80545
…into locations in the R2R file work - Notably, a new level of indirection is needed

Add additional comment about the need for second level of indirection…
9c88d47
… in helper call codegen in Wasm

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
7141714
…-fix-call-codegen

CopilotAI review requested due to automatic review settings April 10, 2026 23:33

github-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 10, 2026

dotnet-policy-serviceBot assigned adamperlin Apr 10, 2026

Copilotstarted reviewing on behalf of adamperlin April 10, 2026 23:34 View session

adamperlin changed the title ~~[Wasm RyuJit] Call Codegen Fixes~~[Wasm RyuJit] Call Codegen Fixes for R2RApr 10, 2026

adamperlin requested review from AndyAyersMS and kg April 10, 2026 23:34

CopilotAI reviewed Apr 10, 2026
View reviewed changes

adamperlin commented Apr 10, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegenwasm.cpp

jkotas reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jkotas reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

build-analysisBot mentioned this pull request Apr 11, 2026
System.Net.NameResolution.Tests DNS failures: Name or service not known #126641
Closed

jakobbotsch reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

SingleAccretion reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

adamperlin added 3 commits April 15, 2026 10:56

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
1878b53
…-fix-call-codegen

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
7ca6386
…-fix-call-codegen

WIP Lowering::LowerPEPCall for Wasm
5e4a83f

jkotas reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jakobbotsch reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

jakobbotsch reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

Copilotstarted reviewing on behalf of adamperlin April 24, 2026 21:14 View session

CopilotAI reviewed Apr 24, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated
Comment threadsrc/coreclr/jit/codegenwasm.cpp Outdated
Comment threadsrc/coreclr/jit/lower.cpp Outdated

Update src/coreclr/jit/lower.cpp
0cdc541
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings April 24, 2026 21:48

Copilotstarted reviewing on behalf of adamperlin April 24, 2026 21:49 View session

CopilotAI reviewed Apr 24, 2026
View reviewed changes

adamperlin mentioned this pull request Apr 24, 2026
[Wasm RyuJIT]: Fix LIR Semantics in Stackifier Output #127412
Merged

adamperlin added 2 commits April 27, 2026 10:43

Use INS_I_LOAD in genEmitHelperCall to ensure compatibility with wasm64
4a4ae2c

Merge branch 'adamperlin/wasm-fix-call-codegen' of github.com:adamper…
3981152
…lin/runtime into adamperlin/wasm-fix-call-codegen

adamperlin force-pushed the adamperlin/wasm-fix-call-codegen branch from 5c9ee85 to 3981152Compare April 27, 2026 17:46

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegenwasm.cpp Outdated

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

adamperlin added 2 commits April 27, 2026 11:19

Move LowerPEPCall def into lowerwasm.cpp
4a60460

More review feedback
d74680e

CopilotAI review requested due to automatic review settings April 27, 2026 20:00

Copilotstarted reviewing on behalf of adamperlin April 27, 2026 20:00 View session

CopilotAI reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lowerwasm.cpp Outdated

Update src/coreclr/jit/lowerwasm.cpp
29cf060
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings April 27, 2026 20:46

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp

jakobbotsch mentioned this pull request Apr 27, 2026
[Wasm RyuJIT] Load PEP Only Once for JIT Helper Calls #127468
Open

jakobbotsch approved these changes Apr 28, 2026
View reviewed changes

adamperlin merged commit 8f854af into dotnet:mainApr 30, 2026
135 checks passed

adamperlin deleted the adamperlin/wasm-fix-call-codegen branch April 30, 2026 01:18

dotnet-maestroBot mentioned this pull request Apr 30, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#6388
Merged

github-actionsBot locked and limited conversation to collaborators May 30, 2026

pavelsavara added the arch-wasm WebAssembly architecture label Jun 16, 2026

davidwrightonand others added 3 commits April 9, 2026 13:44

Add codegen changes to make calls through PortableEntryPoints stored …
0b80545
…into locations in the R2R file work - Notably, a new level of indirection is needed

Add additional comment about the need for second level of indirection…
9c88d47
… in helper call codegen in Wasm

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
7141714
…-fix-call-codegen

CopilotAI review requested due to automatic review settings April 10, 2026 23:33

github-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 10, 2026

dotnet-policy-serviceBot assigned adamperlin Apr 10, 2026

Copilotstarted reviewing on behalf of adamperlin April 10, 2026 23:34 View session

adamperlin changed the title ~~[Wasm RyuJit] Call Codegen Fixes~~[Wasm RyuJit] Call Codegen Fixes for R2RApr 10, 2026

adamperlin requested review from AndyAyersMS and kg April 10, 2026 23:34

CopilotAI reviewed Apr 10, 2026
View reviewed changes

adamperlin commented Apr 10, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegenwasm.cpp

jkotas reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jkotas reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

build-analysisBot mentioned this pull request Apr 11, 2026
System.Net.NameResolution.Tests DNS failures: Name or service not known #126641
Closed

jakobbotsch reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

SingleAccretion reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

adamperlin added 3 commits April 15, 2026 10:56

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
1878b53
…-fix-call-codegen

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
7ca6386
…-fix-call-codegen

WIP Lowering::LowerPEPCall for Wasm
5e4a83f

jkotas reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jakobbotsch reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

jakobbotsch reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

Copilotstarted reviewing on behalf of adamperlin April 24, 2026 21:14 View session

CopilotAI reviewed Apr 24, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated
Comment threadsrc/coreclr/jit/codegenwasm.cpp Outdated
Comment threadsrc/coreclr/jit/lower.cpp Outdated

Update src/coreclr/jit/lower.cpp
0cdc541
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings April 24, 2026 21:48

Copilotstarted reviewing on behalf of adamperlin April 24, 2026 21:49 View session

CopilotAI reviewed Apr 24, 2026
View reviewed changes

adamperlin mentioned this pull request Apr 24, 2026
[Wasm RyuJIT]: Fix LIR Semantics in Stackifier Output #127412
Merged

adamperlin added 2 commits April 27, 2026 10:43

Use INS_I_LOAD in genEmitHelperCall to ensure compatibility with wasm64
4a4ae2c

Merge branch 'adamperlin/wasm-fix-call-codegen' of github.com:adamper…
3981152
…lin/runtime into adamperlin/wasm-fix-call-codegen

adamperlin force-pushed the adamperlin/wasm-fix-call-codegen branch from 5c9ee85 to 3981152Compare April 27, 2026 17:46

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegenwasm.cpp Outdated

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

adamperlin added 2 commits April 27, 2026 11:19

Move LowerPEPCall def into lowerwasm.cpp
4a60460

More review feedback
d74680e

CopilotAI review requested due to automatic review settings April 27, 2026 20:00

Copilotstarted reviewing on behalf of adamperlin April 27, 2026 20:00 View session

CopilotAI reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lowerwasm.cpp Outdated

Update src/coreclr/jit/lowerwasm.cpp
29cf060
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings April 27, 2026 20:46

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp

jakobbotsch mentioned this pull request Apr 27, 2026
[Wasm RyuJIT] Load PEP Only Once for JIT Helper Calls #127468
Open

jakobbotsch approved these changes Apr 28, 2026
View reviewed changes

adamperlin merged commit 8f854af into dotnet:mainApr 30, 2026
135 checks passed

adamperlin deleted the adamperlin/wasm-fix-call-codegen branch April 30, 2026 01:18

dotnet-maestroBot mentioned this pull request Apr 30, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#6388
Merged

github-actionsBot locked and limited conversation to collaborators May 30, 2026

pavelsavara added the arch-wasm WebAssembly architecture label Jun 16, 2026

davidwrightonand others added 3 commits April 9, 2026 13:44

Add codegen changes to make calls through PortableEntryPoints stored …
0b80545
…into locations in the R2R file work - Notably, a new level of indirection is needed

Add additional comment about the need for second level of indirection…
9c88d47
… in helper call codegen in Wasm

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
7141714
…-fix-call-codegen

CopilotAI review requested due to automatic review settings April 10, 2026 23:33

github-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 10, 2026

dotnet-policy-serviceBot assigned adamperlin Apr 10, 2026

Copilotstarted reviewing on behalf of adamperlin April 10, 2026 23:34 View session

adamperlin changed the title ~~[Wasm RyuJit] Call Codegen Fixes~~[Wasm RyuJit] Call Codegen Fixes for R2RApr 10, 2026

adamperlin requested review from AndyAyersMS and kg April 10, 2026 23:34

CopilotAI reviewed Apr 10, 2026
View reviewed changes

adamperlin commented Apr 10, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegenwasm.cpp

jkotas reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jkotas reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

build-analysisBot mentioned this pull request Apr 11, 2026
System.Net.NameResolution.Tests DNS failures: Name or service not known #126641
Closed

jakobbotsch reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

SingleAccretion reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

adamperlin added 3 commits April 15, 2026 10:56

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
1878b53
…-fix-call-codegen

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
7ca6386
…-fix-call-codegen

WIP Lowering::LowerPEPCall for Wasm
5e4a83f

jkotas reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jakobbotsch reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

jakobbotsch reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

Copilotstarted reviewing on behalf of adamperlin April 24, 2026 21:14 View session

CopilotAI reviewed Apr 24, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated
Comment threadsrc/coreclr/jit/codegenwasm.cpp Outdated
Comment threadsrc/coreclr/jit/lower.cpp Outdated

Update src/coreclr/jit/lower.cpp
0cdc541
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings April 24, 2026 21:48

Copilotstarted reviewing on behalf of adamperlin April 24, 2026 21:49 View session

CopilotAI reviewed Apr 24, 2026
View reviewed changes

adamperlin mentioned this pull request Apr 24, 2026
[Wasm RyuJIT]: Fix LIR Semantics in Stackifier Output #127412
Merged

adamperlin added 2 commits April 27, 2026 10:43

Use INS_I_LOAD in genEmitHelperCall to ensure compatibility with wasm64
4a4ae2c

Merge branch 'adamperlin/wasm-fix-call-codegen' of github.com:adamper…
3981152
…lin/runtime into adamperlin/wasm-fix-call-codegen

adamperlin force-pushed the adamperlin/wasm-fix-call-codegen branch from 5c9ee85 to 3981152Compare April 27, 2026 17:46

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegenwasm.cpp Outdated

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

adamperlin added 2 commits April 27, 2026 11:19

Move LowerPEPCall def into lowerwasm.cpp
4a60460

More review feedback
d74680e

CopilotAI review requested due to automatic review settings April 27, 2026 20:00

Copilotstarted reviewing on behalf of adamperlin April 27, 2026 20:00 View session

CopilotAI reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lowerwasm.cpp Outdated

Update src/coreclr/jit/lowerwasm.cpp
29cf060
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings April 27, 2026 20:46

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp

jakobbotsch mentioned this pull request Apr 27, 2026
[Wasm RyuJIT] Load PEP Only Once for JIT Helper Calls #127468
Open

jakobbotsch approved these changes Apr 28, 2026
View reviewed changes

adamperlin merged commit 8f854af into dotnet:mainApr 30, 2026
135 checks passed

adamperlin deleted the adamperlin/wasm-fix-call-codegen branch April 30, 2026 01:18

dotnet-maestroBot mentioned this pull request Apr 30, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#6388
Merged

github-actionsBot locked and limited conversation to collaborators May 30, 2026

pavelsavara added the arch-wasm WebAssembly architecture label Jun 16, 2026

davidwrightonand others added 3 commits April 9, 2026 13:44

Add codegen changes to make calls through PortableEntryPoints stored …
0b80545
…into locations in the R2R file work - Notably, a new level of indirection is needed

Add additional comment about the need for second level of indirection…
9c88d47
… in helper call codegen in Wasm

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
7141714
…-fix-call-codegen

CopilotAI review requested due to automatic review settings April 10, 2026 23:33

github-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 10, 2026

dotnet-policy-serviceBot assigned adamperlin Apr 10, 2026

Copilotstarted reviewing on behalf of adamperlin April 10, 2026 23:34 View session

adamperlin changed the title ~~[Wasm RyuJit] Call Codegen Fixes~~[Wasm RyuJit] Call Codegen Fixes for R2RApr 10, 2026

adamperlin requested review from AndyAyersMS and kg April 10, 2026 23:34

CopilotAI reviewed Apr 10, 2026
View reviewed changes

adamperlin commented Apr 10, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegenwasm.cpp

jkotas reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jkotas reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

build-analysisBot mentioned this pull request Apr 11, 2026
System.Net.NameResolution.Tests DNS failures: Name or service not known #126641
Closed

jakobbotsch reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

SingleAccretion reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

adamperlin added 3 commits April 15, 2026 10:56

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
1878b53
…-fix-call-codegen

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
7ca6386
…-fix-call-codegen

WIP Lowering::LowerPEPCall for Wasm
5e4a83f

jkotas reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jakobbotsch reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

jakobbotsch reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

Copilotstarted reviewing on behalf of adamperlin April 24, 2026 21:14 View session

CopilotAI reviewed Apr 24, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated
Comment threadsrc/coreclr/jit/codegenwasm.cpp Outdated
Comment threadsrc/coreclr/jit/lower.cpp Outdated

Update src/coreclr/jit/lower.cpp
0cdc541
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings April 24, 2026 21:48

Copilotstarted reviewing on behalf of adamperlin April 24, 2026 21:49 View session

CopilotAI reviewed Apr 24, 2026
View reviewed changes

adamperlin mentioned this pull request Apr 24, 2026
[Wasm RyuJIT]: Fix LIR Semantics in Stackifier Output #127412
Merged

adamperlin added 2 commits April 27, 2026 10:43

Use INS_I_LOAD in genEmitHelperCall to ensure compatibility with wasm64
4a4ae2c

Merge branch 'adamperlin/wasm-fix-call-codegen' of github.com:adamper…
3981152
…lin/runtime into adamperlin/wasm-fix-call-codegen

adamperlin force-pushed the adamperlin/wasm-fix-call-codegen branch from 5c9ee85 to 3981152Compare April 27, 2026 17:46

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegenwasm.cpp Outdated

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

adamperlin added 2 commits April 27, 2026 11:19

Move LowerPEPCall def into lowerwasm.cpp
4a60460

More review feedback
d74680e

CopilotAI review requested due to automatic review settings April 27, 2026 20:00

Copilotstarted reviewing on behalf of adamperlin April 27, 2026 20:00 View session

CopilotAI reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lowerwasm.cpp Outdated

Update src/coreclr/jit/lowerwasm.cpp
29cf060
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings April 27, 2026 20:46

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp

jakobbotsch mentioned this pull request Apr 27, 2026
[Wasm RyuJIT] Load PEP Only Once for JIT Helper Calls #127468
Open

jakobbotsch approved these changes Apr 28, 2026
View reviewed changes

adamperlin merged commit 8f854af into dotnet:mainApr 30, 2026
135 checks passed

adamperlin deleted the adamperlin/wasm-fix-call-codegen branch April 30, 2026 01:18

dotnet-maestroBot mentioned this pull request Apr 30, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#6388
Merged

github-actionsBot locked and limited conversation to collaborators May 30, 2026

pavelsavara added the arch-wasm WebAssembly architecture label Jun 16, 2026

davidwrightonand others added 3 commits April 9, 2026 13:44

Add codegen changes to make calls through PortableEntryPoints stored …
0b80545
…into locations in the R2R file work - Notably, a new level of indirection is needed

Add additional comment about the need for second level of indirection…
9c88d47
… in helper call codegen in Wasm

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
7141714
…-fix-call-codegen

CopilotAI review requested due to automatic review settings April 10, 2026 23:33

github-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 10, 2026

dotnet-policy-serviceBot assigned adamperlin Apr 10, 2026

Copilotstarted reviewing on behalf of adamperlin April 10, 2026 23:34 View session

adamperlin changed the title ~~[Wasm RyuJit] Call Codegen Fixes~~[Wasm RyuJit] Call Codegen Fixes for R2RApr 10, 2026

adamperlin requested review from AndyAyersMS and kg April 10, 2026 23:34

CopilotAI reviewed Apr 10, 2026
View reviewed changes

adamperlin commented Apr 10, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegenwasm.cpp

jkotas reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jkotas reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

build-analysisBot mentioned this pull request Apr 11, 2026
System.Net.NameResolution.Tests DNS failures: Name or service not known #126641
Closed

jakobbotsch reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

SingleAccretion reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

adamperlin added 3 commits April 15, 2026 10:56

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
1878b53
…-fix-call-codegen

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
7ca6386
…-fix-call-codegen

WIP Lowering::LowerPEPCall for Wasm
5e4a83f

jkotas reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jakobbotsch reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

jakobbotsch reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

Copilotstarted reviewing on behalf of adamperlin April 24, 2026 21:14 View session

CopilotAI reviewed Apr 24, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated
Comment threadsrc/coreclr/jit/codegenwasm.cpp Outdated
Comment threadsrc/coreclr/jit/lower.cpp Outdated

Update src/coreclr/jit/lower.cpp
0cdc541
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings April 24, 2026 21:48

Copilotstarted reviewing on behalf of adamperlin April 24, 2026 21:49 View session

CopilotAI reviewed Apr 24, 2026
View reviewed changes

adamperlin mentioned this pull request Apr 24, 2026
[Wasm RyuJIT]: Fix LIR Semantics in Stackifier Output #127412
Merged

adamperlin added 2 commits April 27, 2026 10:43

Use INS_I_LOAD in genEmitHelperCall to ensure compatibility with wasm64
4a4ae2c

Merge branch 'adamperlin/wasm-fix-call-codegen' of github.com:adamper…
3981152
…lin/runtime into adamperlin/wasm-fix-call-codegen

adamperlin force-pushed the adamperlin/wasm-fix-call-codegen branch from 5c9ee85 to 3981152Compare April 27, 2026 17:46

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegenwasm.cpp Outdated

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

adamperlin added 2 commits April 27, 2026 11:19

Move LowerPEPCall def into lowerwasm.cpp
4a60460

More review feedback
d74680e

CopilotAI review requested due to automatic review settings April 27, 2026 20:00

Copilotstarted reviewing on behalf of adamperlin April 27, 2026 20:00 View session

CopilotAI reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lowerwasm.cpp Outdated

Update src/coreclr/jit/lowerwasm.cpp
29cf060
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings April 27, 2026 20:46

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp

jakobbotsch mentioned this pull request Apr 27, 2026
[Wasm RyuJIT] Load PEP Only Once for JIT Helper Calls #127468
Open

jakobbotsch approved these changes Apr 28, 2026
View reviewed changes

adamperlin merged commit 8f854af into dotnet:mainApr 30, 2026
135 checks passed

adamperlin deleted the adamperlin/wasm-fix-call-codegen branch April 30, 2026 01:18

dotnet-maestroBot mentioned this pull request Apr 30, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#6388
Merged

github-actionsBot locked and limited conversation to collaborators May 30, 2026

pavelsavara added the arch-wasm WebAssembly architecture label Jun 16, 2026

davidwrightonand others added 3 commits April 9, 2026 13:44

Add codegen changes to make calls through PortableEntryPoints stored …
0b80545
…into locations in the R2R file work - Notably, a new level of indirection is needed

Add additional comment about the need for second level of indirection…
9c88d47
… in helper call codegen in Wasm

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
7141714
…-fix-call-codegen

CopilotAI review requested due to automatic review settings April 10, 2026 23:33

github-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 10, 2026

dotnet-policy-serviceBot assigned adamperlin Apr 10, 2026

Copilotstarted reviewing on behalf of adamperlin April 10, 2026 23:34 View session

adamperlin changed the title ~~[Wasm RyuJit] Call Codegen Fixes~~[Wasm RyuJit] Call Codegen Fixes for R2RApr 10, 2026

adamperlin requested review from AndyAyersMS and kg April 10, 2026 23:34

CopilotAI reviewed Apr 10, 2026
View reviewed changes

adamperlin commented Apr 10, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegenwasm.cpp

jkotas reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jkotas reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

build-analysisBot mentioned this pull request Apr 11, 2026
System.Net.NameResolution.Tests DNS failures: Name or service not known #126641
Closed

jakobbotsch reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

SingleAccretion reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

adamperlin added 3 commits April 15, 2026 10:56

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
1878b53
…-fix-call-codegen

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
7ca6386
…-fix-call-codegen

WIP Lowering::LowerPEPCall for Wasm
5e4a83f

jkotas reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jakobbotsch reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

jakobbotsch reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

Copilotstarted reviewing on behalf of adamperlin April 24, 2026 21:14 View session

CopilotAI reviewed Apr 24, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated
Comment threadsrc/coreclr/jit/codegenwasm.cpp Outdated
Comment threadsrc/coreclr/jit/lower.cpp Outdated

Update src/coreclr/jit/lower.cpp
0cdc541
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings April 24, 2026 21:48

Copilotstarted reviewing on behalf of adamperlin April 24, 2026 21:49 View session

CopilotAI reviewed Apr 24, 2026
View reviewed changes

adamperlin mentioned this pull request Apr 24, 2026
[Wasm RyuJIT]: Fix LIR Semantics in Stackifier Output #127412
Merged

adamperlin added 2 commits April 27, 2026 10:43

Use INS_I_LOAD in genEmitHelperCall to ensure compatibility with wasm64
4a4ae2c

Merge branch 'adamperlin/wasm-fix-call-codegen' of github.com:adamper…
3981152
…lin/runtime into adamperlin/wasm-fix-call-codegen

adamperlin force-pushed the adamperlin/wasm-fix-call-codegen branch from 5c9ee85 to 3981152Compare April 27, 2026 17:46

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegenwasm.cpp Outdated

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

adamperlin added 2 commits April 27, 2026 11:19

Move LowerPEPCall def into lowerwasm.cpp
4a60460

More review feedback
d74680e

CopilotAI review requested due to automatic review settings April 27, 2026 20:00

Copilotstarted reviewing on behalf of adamperlin April 27, 2026 20:00 View session

CopilotAI reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lowerwasm.cpp Outdated

Update src/coreclr/jit/lowerwasm.cpp
29cf060
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings April 27, 2026 20:46

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp

jakobbotsch mentioned this pull request Apr 27, 2026
[Wasm RyuJIT] Load PEP Only Once for JIT Helper Calls #127468
Open

jakobbotsch approved these changes Apr 28, 2026
View reviewed changes

adamperlin merged commit 8f854af into dotnet:mainApr 30, 2026
135 checks passed

adamperlin deleted the adamperlin/wasm-fix-call-codegen branch April 30, 2026 01:18

dotnet-maestroBot mentioned this pull request Apr 30, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#6388
Merged

github-actionsBot locked and limited conversation to collaborators May 30, 2026

pavelsavara added the arch-wasm WebAssembly architecture label Jun 16, 2026

davidwrightonand others added 3 commits April 9, 2026 13:44

Add codegen changes to make calls through PortableEntryPoints stored …
0b80545
…into locations in the R2R file work - Notably, a new level of indirection is needed

Add additional comment about the need for second level of indirection…
9c88d47
… in helper call codegen in Wasm

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
7141714
…-fix-call-codegen

CopilotAI review requested due to automatic review settings April 10, 2026 23:33

github-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 10, 2026

dotnet-policy-serviceBot assigned adamperlin Apr 10, 2026

Copilotstarted reviewing on behalf of adamperlin April 10, 2026 23:34 View session

adamperlin changed the title ~~[Wasm RyuJit] Call Codegen Fixes~~[Wasm RyuJit] Call Codegen Fixes for R2RApr 10, 2026

adamperlin requested review from AndyAyersMS and kg April 10, 2026 23:34

CopilotAI reviewed Apr 10, 2026
View reviewed changes

adamperlin commented Apr 10, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegenwasm.cpp

jkotas reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jkotas reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

build-analysisBot mentioned this pull request Apr 11, 2026
System.Net.NameResolution.Tests DNS failures: Name or service not known #126641
Closed

jakobbotsch reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

SingleAccretion reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

adamperlin added 3 commits April 15, 2026 10:56

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
1878b53
…-fix-call-codegen

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
7ca6386
…-fix-call-codegen

WIP Lowering::LowerPEPCall for Wasm
5e4a83f

jkotas reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jakobbotsch reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

jakobbotsch reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

Copilotstarted reviewing on behalf of adamperlin April 24, 2026 21:14 View session

CopilotAI reviewed Apr 24, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated
Comment threadsrc/coreclr/jit/codegenwasm.cpp Outdated
Comment threadsrc/coreclr/jit/lower.cpp Outdated

Update src/coreclr/jit/lower.cpp
0cdc541
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings April 24, 2026 21:48

Copilotstarted reviewing on behalf of adamperlin April 24, 2026 21:49 View session

CopilotAI reviewed Apr 24, 2026
View reviewed changes

adamperlin mentioned this pull request Apr 24, 2026
[Wasm RyuJIT]: Fix LIR Semantics in Stackifier Output #127412
Merged

adamperlin added 2 commits April 27, 2026 10:43

Use INS_I_LOAD in genEmitHelperCall to ensure compatibility with wasm64
4a4ae2c

Merge branch 'adamperlin/wasm-fix-call-codegen' of github.com:adamper…
3981152
…lin/runtime into adamperlin/wasm-fix-call-codegen

adamperlin force-pushed the adamperlin/wasm-fix-call-codegen branch from 5c9ee85 to 3981152Compare April 27, 2026 17:46

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegenwasm.cpp Outdated

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

adamperlin added 2 commits April 27, 2026 11:19

Move LowerPEPCall def into lowerwasm.cpp
4a60460

More review feedback
d74680e

CopilotAI review requested due to automatic review settings April 27, 2026 20:00

Copilotstarted reviewing on behalf of adamperlin April 27, 2026 20:00 View session

CopilotAI reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lowerwasm.cpp Outdated

Update src/coreclr/jit/lowerwasm.cpp
29cf060
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings April 27, 2026 20:46

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp

jakobbotsch mentioned this pull request Apr 27, 2026
[Wasm RyuJIT] Load PEP Only Once for JIT Helper Calls #127468
Open

jakobbotsch approved these changes Apr 28, 2026
View reviewed changes

adamperlin merged commit 8f854af into dotnet:mainApr 30, 2026
135 checks passed

adamperlin deleted the adamperlin/wasm-fix-call-codegen branch April 30, 2026 01:18

dotnet-maestroBot mentioned this pull request Apr 30, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#6388
Merged

github-actionsBot locked and limited conversation to collaborators May 30, 2026

pavelsavara added the arch-wasm WebAssembly architecture label Jun 16, 2026

davidwrightonand others added 3 commits April 9, 2026 13:44

Add codegen changes to make calls through PortableEntryPoints stored …
0b80545
…into locations in the R2R file work - Notably, a new level of indirection is needed

Add additional comment about the need for second level of indirection…
9c88d47
… in helper call codegen in Wasm

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
7141714
…-fix-call-codegen

CopilotAI review requested due to automatic review settings April 10, 2026 23:33

github-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 10, 2026

dotnet-policy-serviceBot assigned adamperlin Apr 10, 2026

Copilotstarted reviewing on behalf of adamperlin April 10, 2026 23:34 View session

adamperlin changed the title ~~[Wasm RyuJit] Call Codegen Fixes~~[Wasm RyuJit] Call Codegen Fixes for R2RApr 10, 2026

adamperlin requested review from AndyAyersMS and kg April 10, 2026 23:34

CopilotAI reviewed Apr 10, 2026
View reviewed changes

adamperlin commented Apr 10, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegenwasm.cpp

jkotas reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jkotas reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

build-analysisBot mentioned this pull request Apr 11, 2026
System.Net.NameResolution.Tests DNS failures: Name or service not known #126641
Closed

jakobbotsch reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

SingleAccretion reviewed Apr 11, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

adamperlin added 3 commits April 15, 2026 10:56

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
1878b53
…-fix-call-codegen

Merge branch 'main' of github.com:dotnet/runtime into adamperlin/wasm…
7ca6386
…-fix-call-codegen

WIP Lowering::LowerPEPCall for Wasm
5e4a83f

jkotas reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jakobbotsch reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

jakobbotsch reviewed Apr 16, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

Copilotstarted reviewing on behalf of adamperlin April 24, 2026 21:14 View session

CopilotAI reviewed Apr 24, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated
Comment threadsrc/coreclr/jit/codegenwasm.cpp Outdated
Comment threadsrc/coreclr/jit/lower.cpp Outdated

Update src/coreclr/jit/lower.cpp
0cdc541
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings April 24, 2026 21:48

Copilotstarted reviewing on behalf of adamperlin April 24, 2026 21:49 View session

CopilotAI reviewed Apr 24, 2026
View reviewed changes

adamperlin mentioned this pull request Apr 24, 2026
[Wasm RyuJIT]: Fix LIR Semantics in Stackifier Output #127412
Merged

adamperlin added 2 commits April 27, 2026 10:43

Use INS_I_LOAD in genEmitHelperCall to ensure compatibility with wasm64
4a4ae2c

Merge branch 'adamperlin/wasm-fix-call-codegen' of github.com:adamper…
3981152
…lin/runtime into adamperlin/wasm-fix-call-codegen

adamperlin force-pushed the adamperlin/wasm-fix-call-codegen branch from 5c9ee85 to 3981152Compare April 27, 2026 17:46

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lower.cpp Outdated

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegenwasm.cpp Outdated

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp Outdated

adamperlin added 2 commits April 27, 2026 11:19

Move LowerPEPCall def into lowerwasm.cpp
4a60460

More review feedback
d74680e

CopilotAI review requested due to automatic review settings April 27, 2026 20:00

Copilotstarted reviewing on behalf of adamperlin April 27, 2026 20:00 View session

CopilotAI reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/lowerwasm.cpp Outdated

Update src/coreclr/jit/lowerwasm.cpp
29cf060
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings April 27, 2026 20:46

jakobbotsch reviewed Apr 27, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/morph.cpp

jakobbotsch mentioned this pull request Apr 27, 2026
[Wasm RyuJIT] Load PEP Only Once for JIT Helper Calls #127468
Open

jakobbotsch approved these changes Apr 28, 2026
View reviewed changes

adamperlin merged commit 8f854af into dotnet:mainApr 30, 2026
135 checks passed

adamperlin deleted the adamperlin/wasm-fix-call-codegen branch April 30, 2026 01:18

dotnet-maestroBot mentioned this pull request Apr 30, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#6388
Merged

github-actionsBot locked and limited conversation to collaborators May 30, 2026

pavelsavara added the arch-wasm WebAssembly architecture label Jun 16, 2026

Uh oh!

Conversation

adamperlin commented Apr 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lowering Transformation Details

Uh oh!

dotnet-policy-serviceBot commented Apr 10, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

AndyAyersMS commented Apr 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adamperlin commented Apr 13, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkotas commented Apr 13, 2026

Uh oh!

adamperlin commented Apr 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

adamperlin commented Apr 27, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

jakobbotsch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

adamperlin commented Apr 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lowering Transformation Details

Uh oh!

dotnet-policy-serviceBot commented Apr 10, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

AndyAyersMS commented Apr 11, 2026

adamperlin commented Apr 10, 2026•
edited
Loading

adamperlin commented Apr 13, 2026•
edited
Loading

adamperlin commented Apr 27, 2026•
edited
Loading

adamperlin commented Apr 10, 2026•
edited
Loading

adamperlin commented Apr 13, 2026•
edited
Loading

adamperlin commented Apr 27, 2026•
edited
Loading

adamperlin commented Apr 10, 2026•
edited
Loading