Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command

[Copilot]

Description

WasmTestOnChrome and related WASM CI jobs were failing because gen-debug-dump-docs.py was scheduled as a Helix post-command for all non-Windows CoreCLR targets, but the script is not present in the correlation payload for browser/wasi targets.

Changes

• src/libraries/sendtohelixhelp.proj: Added browser and wasi exclusions to the non-Windows HelixPostCommands condition for gen-debug-dump-docs.py, consistent with the existing pattern already used for TestEnvFileName in the same file:

<!-- Before -->
<HelixPostCommandsCondition="'$(TargetOS)' != 'windows'">
<!-- After -->
<HelixPostCommandsCondition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

Changes

• src/libraries/sendtohelixhelp.proj

Testing

Change is a build/CI pipeline configuration fix; validated by inspection against the existing pattern in the same file.

Fixes#126706

[Copilot]

Pull request overview

This PR fixes WASM Helix job failures by preventing gen-debug-dump-docs.py from being added as a Helix post-command on browser/wasi targets, where that script is not present in the correlation payload. The change aligns the post-command gating with the existing TestEnvFileName OS-exclusion pattern already used in the same project file.

Changes:

• Update the non-Windows HelixPostCommands condition to exclude browser and wasi, avoiding a missing-script failure on those targets.

Show a summary per file

File	Description
src/libraries/sendtohelixhelp.proj	Excludes browser/wasi from the non-Windows gen-debug-dump-docs.py Helix post-command condition to prevent Helix post-step failures on WASM jobs.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Copilot]

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0 new

[github-actions]

🤖 Copilot Code Review — PR #126789

Note

This review was generated by Copilot (Claude Opus 4.6).

Holistic Assessment

Motivation: Justified and verified. Issue #126706 documents that gen-debug-dump-docs.py is missing from the Helix correlation payload on browser/wasi targets, causing WasmTestOnChrome failures with [Errno 2] No such file or directory. The error is reproducible across multiple builds.

Approach: Correct and minimal. The one-line condition change narrows the non-Windows HelixPostCommands branch to exclude browser and wasi, following the same pattern already used at line 110 (TestEnvFileName).

Summary: ✅ LGTM. This is a safe, narrowly scoped fix. No new code paths are introduced — the change only prevents an existing post-command from firing on targets where it cannot succeed. The latest merge from main (April 17) only adds an interpmode3 timeout and does not affect this fix.

---

Detailed Findings

✅ Correctness — Condition logic is sound

The updated condition on line 274:

Condition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'"

correctly prevents the shell-style gen-debug-dump-docs.py invocation from running on browser/wasi. The Windows branch (line 270) is unaffected. For the edge case where TargetOS == 'browser' but BrowserHost == 'windows', neither branch fires — which is correct since dump docs are irrelevant for WASM.

✅ Consistency — Matches established pattern

The exclusion mirrors the identical condition at line 110:

<TestEnvFileNameCondition=" '$(Scenario)' != '' and '$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

✅ Completeness — No missing exclusions

The outer PropertyGroup (line 269) is gated on RuntimeFlavor == 'CoreCLR'. Mobile targets (android, ios, tvos, maccatalyst) use Mono, so they never enter this block. No additional exclusions are needed.

✅ No regressions from recent merge

The April 17 merge from main (4f60d942e) only added an interpmode3 timeout entry (line ~40) — unrelated to the dump-docs post-command. The PR's fix remains clean.

Confirmed: No blocking issues. PR is approved by @pavelsavara and ready to merge.

Generated by Code Review for issue #126789 · ◷

[Copilot]

Description

WasmTestOnChrome and related WASM CI jobs were failing because gen-debug-dump-docs.py was scheduled as a Helix post-command for all non-Windows CoreCLR targets, but the script is not present in the correlation payload for browser/wasi targets.

Changes

• src/libraries/sendtohelixhelp.proj: Added browser and wasi exclusions to the non-Windows HelixPostCommands condition for gen-debug-dump-docs.py, consistent with the existing pattern already used for TestEnvFileName in the same file:

<!-- Before -->
<HelixPostCommandsCondition="'$(TargetOS)' != 'windows'">
<!-- After -->
<HelixPostCommandsCondition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

Changes

• src/libraries/sendtohelixhelp.proj

Testing

Change is a build/CI pipeline configuration fix; validated by inspection against the existing pattern in the same file.

Fixes#126706

[Copilot]

Pull request overview

This PR fixes WASM Helix job failures by preventing gen-debug-dump-docs.py from being added as a Helix post-command on browser/wasi targets, where that script is not present in the correlation payload. The change aligns the post-command gating with the existing TestEnvFileName OS-exclusion pattern already used in the same project file.

Changes:

• Update the non-Windows HelixPostCommands condition to exclude browser and wasi, avoiding a missing-script failure on those targets.

Show a summary per file

File	Description
src/libraries/sendtohelixhelp.proj	Excludes browser/wasi from the non-Windows gen-debug-dump-docs.py Helix post-command condition to prevent Helix post-step failures on WASM jobs.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Copilot]

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0 new

[github-actions]

🤖 Copilot Code Review — PR #126789

Note

This review was generated by Copilot (Claude Opus 4.6).

Holistic Assessment

Motivation: Justified and verified. Issue #126706 documents that gen-debug-dump-docs.py is missing from the Helix correlation payload on browser/wasi targets, causing WasmTestOnChrome failures with [Errno 2] No such file or directory. The error is reproducible across multiple builds.

Approach: Correct and minimal. The one-line condition change narrows the non-Windows HelixPostCommands branch to exclude browser and wasi, following the same pattern already used at line 110 (TestEnvFileName).

Summary: ✅ LGTM. This is a safe, narrowly scoped fix. No new code paths are introduced — the change only prevents an existing post-command from firing on targets where it cannot succeed. The latest merge from main (April 17) only adds an interpmode3 timeout and does not affect this fix.

---

Detailed Findings

✅ Correctness — Condition logic is sound

The updated condition on line 274:

Condition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'"

correctly prevents the shell-style gen-debug-dump-docs.py invocation from running on browser/wasi. The Windows branch (line 270) is unaffected. For the edge case where TargetOS == 'browser' but BrowserHost == 'windows', neither branch fires — which is correct since dump docs are irrelevant for WASM.

✅ Consistency — Matches established pattern

The exclusion mirrors the identical condition at line 110:

<TestEnvFileNameCondition=" '$(Scenario)' != '' and '$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

✅ Completeness — No missing exclusions

The outer PropertyGroup (line 269) is gated on RuntimeFlavor == 'CoreCLR'. Mobile targets (android, ios, tvos, maccatalyst) use Mono, so they never enter this block. No additional exclusions are needed.

✅ No regressions from recent merge

The April 17 merge from main (4f60d942e) only added an interpmode3 timeout entry (line ~40) — unrelated to the dump-docs post-command. The PR's fix remains clean.

Confirmed: No blocking issues. PR is approved by @pavelsavara and ready to merge.

Generated by Code Review for issue #126789 · ◷

[Copilot]

Description

WasmTestOnChrome and related WASM CI jobs were failing because gen-debug-dump-docs.py was scheduled as a Helix post-command for all non-Windows CoreCLR targets, but the script is not present in the correlation payload for browser/wasi targets.

Changes

• src/libraries/sendtohelixhelp.proj: Added browser and wasi exclusions to the non-Windows HelixPostCommands condition for gen-debug-dump-docs.py, consistent with the existing pattern already used for TestEnvFileName in the same file:

<!-- Before -->
<HelixPostCommandsCondition="'$(TargetOS)' != 'windows'">
<!-- After -->
<HelixPostCommandsCondition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

Changes

• src/libraries/sendtohelixhelp.proj

Testing

Change is a build/CI pipeline configuration fix; validated by inspection against the existing pattern in the same file.

Fixes#126706

[Copilot]

Pull request overview

This PR fixes WASM Helix job failures by preventing gen-debug-dump-docs.py from being added as a Helix post-command on browser/wasi targets, where that script is not present in the correlation payload. The change aligns the post-command gating with the existing TestEnvFileName OS-exclusion pattern already used in the same project file.

Changes:

• Update the non-Windows HelixPostCommands condition to exclude browser and wasi, avoiding a missing-script failure on those targets.

Show a summary per file

File	Description
src/libraries/sendtohelixhelp.proj	Excludes browser/wasi from the non-Windows gen-debug-dump-docs.py Helix post-command condition to prevent Helix post-step failures on WASM jobs.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Copilot]

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0 new

[github-actions]

🤖 Copilot Code Review — PR #126789

Note

This review was generated by Copilot (Claude Opus 4.6).

Holistic Assessment

Motivation: Justified and verified. Issue #126706 documents that gen-debug-dump-docs.py is missing from the Helix correlation payload on browser/wasi targets, causing WasmTestOnChrome failures with [Errno 2] No such file or directory. The error is reproducible across multiple builds.

Approach: Correct and minimal. The one-line condition change narrows the non-Windows HelixPostCommands branch to exclude browser and wasi, following the same pattern already used at line 110 (TestEnvFileName).

Summary: ✅ LGTM. This is a safe, narrowly scoped fix. No new code paths are introduced — the change only prevents an existing post-command from firing on targets where it cannot succeed. The latest merge from main (April 17) only adds an interpmode3 timeout and does not affect this fix.

---

Detailed Findings

✅ Correctness — Condition logic is sound

The updated condition on line 274:

Condition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'"

correctly prevents the shell-style gen-debug-dump-docs.py invocation from running on browser/wasi. The Windows branch (line 270) is unaffected. For the edge case where TargetOS == 'browser' but BrowserHost == 'windows', neither branch fires — which is correct since dump docs are irrelevant for WASM.

✅ Consistency — Matches established pattern

The exclusion mirrors the identical condition at line 110:

<TestEnvFileNameCondition=" '$(Scenario)' != '' and '$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

✅ Completeness — No missing exclusions

The outer PropertyGroup (line 269) is gated on RuntimeFlavor == 'CoreCLR'. Mobile targets (android, ios, tvos, maccatalyst) use Mono, so they never enter this block. No additional exclusions are needed.

✅ No regressions from recent merge

The April 17 merge from main (4f60d942e) only added an interpmode3 timeout entry (line ~40) — unrelated to the dump-docs post-command. The PR's fix remains clean.

Confirmed: No blocking issues. PR is approved by @pavelsavara and ready to merge.

Generated by Code Review for issue #126789 · ◷

[Copilot]

Description

WasmTestOnChrome and related WASM CI jobs were failing because gen-debug-dump-docs.py was scheduled as a Helix post-command for all non-Windows CoreCLR targets, but the script is not present in the correlation payload for browser/wasi targets.

Changes

• src/libraries/sendtohelixhelp.proj: Added browser and wasi exclusions to the non-Windows HelixPostCommands condition for gen-debug-dump-docs.py, consistent with the existing pattern already used for TestEnvFileName in the same file:

<!-- Before -->
<HelixPostCommandsCondition="'$(TargetOS)' != 'windows'">
<!-- After -->
<HelixPostCommandsCondition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

Changes

• src/libraries/sendtohelixhelp.proj

Testing

Change is a build/CI pipeline configuration fix; validated by inspection against the existing pattern in the same file.

Fixes#126706

[Copilot]

Pull request overview

This PR fixes WASM Helix job failures by preventing gen-debug-dump-docs.py from being added as a Helix post-command on browser/wasi targets, where that script is not present in the correlation payload. The change aligns the post-command gating with the existing TestEnvFileName OS-exclusion pattern already used in the same project file.

Changes:

• Update the non-Windows HelixPostCommands condition to exclude browser and wasi, avoiding a missing-script failure on those targets.

Show a summary per file

File	Description
src/libraries/sendtohelixhelp.proj	Excludes browser/wasi from the non-Windows gen-debug-dump-docs.py Helix post-command condition to prevent Helix post-step failures on WASM jobs.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Copilot]

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0 new

[github-actions]

🤖 Copilot Code Review — PR #126789

Note

This review was generated by Copilot (Claude Opus 4.6).

Holistic Assessment

Motivation: Justified and verified. Issue #126706 documents that gen-debug-dump-docs.py is missing from the Helix correlation payload on browser/wasi targets, causing WasmTestOnChrome failures with [Errno 2] No such file or directory. The error is reproducible across multiple builds.

Approach: Correct and minimal. The one-line condition change narrows the non-Windows HelixPostCommands branch to exclude browser and wasi, following the same pattern already used at line 110 (TestEnvFileName).

Summary: ✅ LGTM. This is a safe, narrowly scoped fix. No new code paths are introduced — the change only prevents an existing post-command from firing on targets where it cannot succeed. The latest merge from main (April 17) only adds an interpmode3 timeout and does not affect this fix.

---

Detailed Findings

✅ Correctness — Condition logic is sound

The updated condition on line 274:

Condition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'"

correctly prevents the shell-style gen-debug-dump-docs.py invocation from running on browser/wasi. The Windows branch (line 270) is unaffected. For the edge case where TargetOS == 'browser' but BrowserHost == 'windows', neither branch fires — which is correct since dump docs are irrelevant for WASM.

✅ Consistency — Matches established pattern

The exclusion mirrors the identical condition at line 110:

<TestEnvFileNameCondition=" '$(Scenario)' != '' and '$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

✅ Completeness — No missing exclusions

The outer PropertyGroup (line 269) is gated on RuntimeFlavor == 'CoreCLR'. Mobile targets (android, ios, tvos, maccatalyst) use Mono, so they never enter this block. No additional exclusions are needed.

✅ No regressions from recent merge

The April 17 merge from main (4f60d942e) only added an interpmode3 timeout entry (line ~40) — unrelated to the dump-docs post-command. The PR's fix remains clean.

Confirmed: No blocking issues. PR is approved by @pavelsavara and ready to merge.

Generated by Code Review for issue #126789 · ◷

[Copilot]

Description

WasmTestOnChrome and related WASM CI jobs were failing because gen-debug-dump-docs.py was scheduled as a Helix post-command for all non-Windows CoreCLR targets, but the script is not present in the correlation payload for browser/wasi targets.

Changes

• src/libraries/sendtohelixhelp.proj: Added browser and wasi exclusions to the non-Windows HelixPostCommands condition for gen-debug-dump-docs.py, consistent with the existing pattern already used for TestEnvFileName in the same file:

<!-- Before -->
<HelixPostCommandsCondition="'$(TargetOS)' != 'windows'">
<!-- After -->
<HelixPostCommandsCondition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

Changes

• src/libraries/sendtohelixhelp.proj

Testing

Change is a build/CI pipeline configuration fix; validated by inspection against the existing pattern in the same file.

Fixes#126706

[Copilot]

Pull request overview

This PR fixes WASM Helix job failures by preventing gen-debug-dump-docs.py from being added as a Helix post-command on browser/wasi targets, where that script is not present in the correlation payload. The change aligns the post-command gating with the existing TestEnvFileName OS-exclusion pattern already used in the same project file.

Changes:

• Update the non-Windows HelixPostCommands condition to exclude browser and wasi, avoiding a missing-script failure on those targets.

Show a summary per file

File	Description
src/libraries/sendtohelixhelp.proj	Excludes browser/wasi from the non-Windows gen-debug-dump-docs.py Helix post-command condition to prevent Helix post-step failures on WASM jobs.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Copilot]

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0 new

[github-actions]

🤖 Copilot Code Review — PR #126789

Note

This review was generated by Copilot (Claude Opus 4.6).

Holistic Assessment

Motivation: Justified and verified. Issue #126706 documents that gen-debug-dump-docs.py is missing from the Helix correlation payload on browser/wasi targets, causing WasmTestOnChrome failures with [Errno 2] No such file or directory. The error is reproducible across multiple builds.

Approach: Correct and minimal. The one-line condition change narrows the non-Windows HelixPostCommands branch to exclude browser and wasi, following the same pattern already used at line 110 (TestEnvFileName).

Summary: ✅ LGTM. This is a safe, narrowly scoped fix. No new code paths are introduced — the change only prevents an existing post-command from firing on targets where it cannot succeed. The latest merge from main (April 17) only adds an interpmode3 timeout and does not affect this fix.

---

Detailed Findings

✅ Correctness — Condition logic is sound

The updated condition on line 274:

Condition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'"

correctly prevents the shell-style gen-debug-dump-docs.py invocation from running on browser/wasi. The Windows branch (line 270) is unaffected. For the edge case where TargetOS == 'browser' but BrowserHost == 'windows', neither branch fires — which is correct since dump docs are irrelevant for WASM.

✅ Consistency — Matches established pattern

The exclusion mirrors the identical condition at line 110:

<TestEnvFileNameCondition=" '$(Scenario)' != '' and '$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

✅ Completeness — No missing exclusions

The outer PropertyGroup (line 269) is gated on RuntimeFlavor == 'CoreCLR'. Mobile targets (android, ios, tvos, maccatalyst) use Mono, so they never enter this block. No additional exclusions are needed.

✅ No regressions from recent merge

The April 17 merge from main (4f60d942e) only added an interpmode3 timeout entry (line ~40) — unrelated to the dump-docs post-command. The PR's fix remains clean.

Confirmed: No blocking issues. PR is approved by @pavelsavara and ready to merge.

Generated by Code Review for issue #126789 · ◷

[Copilot]

Description

WasmTestOnChrome and related WASM CI jobs were failing because gen-debug-dump-docs.py was scheduled as a Helix post-command for all non-Windows CoreCLR targets, but the script is not present in the correlation payload for browser/wasi targets.

Changes

• src/libraries/sendtohelixhelp.proj: Added browser and wasi exclusions to the non-Windows HelixPostCommands condition for gen-debug-dump-docs.py, consistent with the existing pattern already used for TestEnvFileName in the same file:

<!-- Before -->
<HelixPostCommandsCondition="'$(TargetOS)' != 'windows'">
<!-- After -->
<HelixPostCommandsCondition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

Changes

• src/libraries/sendtohelixhelp.proj

Testing

Change is a build/CI pipeline configuration fix; validated by inspection against the existing pattern in the same file.

Fixes#126706

[Copilot]

Pull request overview

This PR fixes WASM Helix job failures by preventing gen-debug-dump-docs.py from being added as a Helix post-command on browser/wasi targets, where that script is not present in the correlation payload. The change aligns the post-command gating with the existing TestEnvFileName OS-exclusion pattern already used in the same project file.

Changes:

• Update the non-Windows HelixPostCommands condition to exclude browser and wasi, avoiding a missing-script failure on those targets.

Show a summary per file

File	Description
src/libraries/sendtohelixhelp.proj	Excludes browser/wasi from the non-Windows gen-debug-dump-docs.py Helix post-command condition to prevent Helix post-step failures on WASM jobs.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Copilot]

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0 new

[github-actions]

🤖 Copilot Code Review — PR #126789

Note

This review was generated by Copilot (Claude Opus 4.6).

Holistic Assessment

Motivation: Justified and verified. Issue #126706 documents that gen-debug-dump-docs.py is missing from the Helix correlation payload on browser/wasi targets, causing WasmTestOnChrome failures with [Errno 2] No such file or directory. The error is reproducible across multiple builds.

Approach: Correct and minimal. The one-line condition change narrows the non-Windows HelixPostCommands branch to exclude browser and wasi, following the same pattern already used at line 110 (TestEnvFileName).

Summary: ✅ LGTM. This is a safe, narrowly scoped fix. No new code paths are introduced — the change only prevents an existing post-command from firing on targets where it cannot succeed. The latest merge from main (April 17) only adds an interpmode3 timeout and does not affect this fix.

---

Detailed Findings

✅ Correctness — Condition logic is sound

The updated condition on line 274:

Condition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'"

correctly prevents the shell-style gen-debug-dump-docs.py invocation from running on browser/wasi. The Windows branch (line 270) is unaffected. For the edge case where TargetOS == 'browser' but BrowserHost == 'windows', neither branch fires — which is correct since dump docs are irrelevant for WASM.

✅ Consistency — Matches established pattern

The exclusion mirrors the identical condition at line 110:

<TestEnvFileNameCondition=" '$(Scenario)' != '' and '$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

✅ Completeness — No missing exclusions

The outer PropertyGroup (line 269) is gated on RuntimeFlavor == 'CoreCLR'. Mobile targets (android, ios, tvos, maccatalyst) use Mono, so they never enter this block. No additional exclusions are needed.

✅ No regressions from recent merge

The April 17 merge from main (4f60d942e) only added an interpmode3 timeout entry (line ~40) — unrelated to the dump-docs post-command. The PR's fix remains clean.

Confirmed: No blocking issues. PR is approved by @pavelsavara and ready to merge.

Generated by Code Review for issue #126789 · ◷

[Copilot]

Description

WasmTestOnChrome and related WASM CI jobs were failing because gen-debug-dump-docs.py was scheduled as a Helix post-command for all non-Windows CoreCLR targets, but the script is not present in the correlation payload for browser/wasi targets.

Changes

• src/libraries/sendtohelixhelp.proj: Added browser and wasi exclusions to the non-Windows HelixPostCommands condition for gen-debug-dump-docs.py, consistent with the existing pattern already used for TestEnvFileName in the same file:

<!-- Before -->
<HelixPostCommandsCondition="'$(TargetOS)' != 'windows'">
<!-- After -->
<HelixPostCommandsCondition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

Changes

• src/libraries/sendtohelixhelp.proj

Testing

Change is a build/CI pipeline configuration fix; validated by inspection against the existing pattern in the same file.

Fixes#126706

[Copilot]

Pull request overview

This PR fixes WASM Helix job failures by preventing gen-debug-dump-docs.py from being added as a Helix post-command on browser/wasi targets, where that script is not present in the correlation payload. The change aligns the post-command gating with the existing TestEnvFileName OS-exclusion pattern already used in the same project file.

Changes:

• Update the non-Windows HelixPostCommands condition to exclude browser and wasi, avoiding a missing-script failure on those targets.

Show a summary per file

File	Description
src/libraries/sendtohelixhelp.proj	Excludes browser/wasi from the non-Windows gen-debug-dump-docs.py Helix post-command condition to prevent Helix post-step failures on WASM jobs.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Copilot]

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0 new

[github-actions]

🤖 Copilot Code Review — PR #126789

Note

This review was generated by Copilot (Claude Opus 4.6).

Holistic Assessment

Motivation: Justified and verified. Issue #126706 documents that gen-debug-dump-docs.py is missing from the Helix correlation payload on browser/wasi targets, causing WasmTestOnChrome failures with [Errno 2] No such file or directory. The error is reproducible across multiple builds.

Approach: Correct and minimal. The one-line condition change narrows the non-Windows HelixPostCommands branch to exclude browser and wasi, following the same pattern already used at line 110 (TestEnvFileName).

Summary: ✅ LGTM. This is a safe, narrowly scoped fix. No new code paths are introduced — the change only prevents an existing post-command from firing on targets where it cannot succeed. The latest merge from main (April 17) only adds an interpmode3 timeout and does not affect this fix.

---

Detailed Findings

✅ Correctness — Condition logic is sound

The updated condition on line 274:

Condition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'"

correctly prevents the shell-style gen-debug-dump-docs.py invocation from running on browser/wasi. The Windows branch (line 270) is unaffected. For the edge case where TargetOS == 'browser' but BrowserHost == 'windows', neither branch fires — which is correct since dump docs are irrelevant for WASM.

✅ Consistency — Matches established pattern

The exclusion mirrors the identical condition at line 110:

<TestEnvFileNameCondition=" '$(Scenario)' != '' and '$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

✅ Completeness — No missing exclusions

The outer PropertyGroup (line 269) is gated on RuntimeFlavor == 'CoreCLR'. Mobile targets (android, ios, tvos, maccatalyst) use Mono, so they never enter this block. No additional exclusions are needed.

✅ No regressions from recent merge

The April 17 merge from main (4f60d942e) only added an interpmode3 timeout entry (line ~40) — unrelated to the dump-docs post-command. The PR's fix remains clean.

Confirmed: No blocking issues. PR is approved by @pavelsavara and ready to merge.

Generated by Code Review for issue #126789 · ◷

[Copilot]

Description

WasmTestOnChrome and related WASM CI jobs were failing because gen-debug-dump-docs.py was scheduled as a Helix post-command for all non-Windows CoreCLR targets, but the script is not present in the correlation payload for browser/wasi targets.

Changes

• src/libraries/sendtohelixhelp.proj: Added browser and wasi exclusions to the non-Windows HelixPostCommands condition for gen-debug-dump-docs.py, consistent with the existing pattern already used for TestEnvFileName in the same file:

<!-- Before -->
<HelixPostCommandsCondition="'$(TargetOS)' != 'windows'">
<!-- After -->
<HelixPostCommandsCondition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

Changes

• src/libraries/sendtohelixhelp.proj

Testing

Change is a build/CI pipeline configuration fix; validated by inspection against the existing pattern in the same file.

Fixes#126706

[Copilot]

Pull request overview

This PR fixes WASM Helix job failures by preventing gen-debug-dump-docs.py from being added as a Helix post-command on browser/wasi targets, where that script is not present in the correlation payload. The change aligns the post-command gating with the existing TestEnvFileName OS-exclusion pattern already used in the same project file.

Changes:

• Update the non-Windows HelixPostCommands condition to exclude browser and wasi, avoiding a missing-script failure on those targets.

Show a summary per file

File	Description
src/libraries/sendtohelixhelp.proj	Excludes browser/wasi from the non-Windows gen-debug-dump-docs.py Helix post-command condition to prevent Helix post-step failures on WASM jobs.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Copilot]

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0 new

[github-actions]

🤖 Copilot Code Review — PR #126789

Note

This review was generated by Copilot (Claude Opus 4.6).

Holistic Assessment

Motivation: Justified and verified. Issue #126706 documents that gen-debug-dump-docs.py is missing from the Helix correlation payload on browser/wasi targets, causing WasmTestOnChrome failures with [Errno 2] No such file or directory. The error is reproducible across multiple builds.

Approach: Correct and minimal. The one-line condition change narrows the non-Windows HelixPostCommands branch to exclude browser and wasi, following the same pattern already used at line 110 (TestEnvFileName).

Summary: ✅ LGTM. This is a safe, narrowly scoped fix. No new code paths are introduced — the change only prevents an existing post-command from firing on targets where it cannot succeed. The latest merge from main (April 17) only adds an interpmode3 timeout and does not affect this fix.

---

Detailed Findings

✅ Correctness — Condition logic is sound

The updated condition on line 274:

Condition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'"

correctly prevents the shell-style gen-debug-dump-docs.py invocation from running on browser/wasi. The Windows branch (line 270) is unaffected. For the edge case where TargetOS == 'browser' but BrowserHost == 'windows', neither branch fires — which is correct since dump docs are irrelevant for WASM.

✅ Consistency — Matches established pattern

The exclusion mirrors the identical condition at line 110:

<TestEnvFileNameCondition=" '$(Scenario)' != '' and '$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

✅ Completeness — No missing exclusions

The outer PropertyGroup (line 269) is gated on RuntimeFlavor == 'CoreCLR'. Mobile targets (android, ios, tvos, maccatalyst) use Mono, so they never enter this block. No additional exclusions are needed.

✅ No regressions from recent merge

The April 17 merge from main (4f60d942e) only added an interpmode3 timeout entry (line ~40) — unrelated to the dump-docs post-command. The PR's fix remains clean.

Confirmed: No blocking issues. PR is approved by @pavelsavara and ready to merge.

Generated by Code Review for issue #126789 · ◷