Set MSBUILDDEBUGPATH in build scripts for reliable crash diagnostics by danmoseley · Pull Request #126806 · dotnet/runtime

danmoseley · 2026-04-12T07:12:16Z

Set MSBUILDDEBUGPATH directly in eng/build.sh for reliable crash diagnostics

PR #126012 added MSBUILDDEBUGPATH as an AzDO pipeline variable in global-build-job.yml so that MSBuild crash diagnostics (MSBuild_*.failure.txt) would be written to artifacts/log/ instead of the system temp directory. However, recent builds that hit the MSB4166 crash (e.g., build 1370423) still show MSBuild writing to the default temp path, indicating the pipeline variable is not reaching the MSBuild process.

Other build scripts (src/coreclr/build-runtime.sh, src/tests/build.sh) already set and export MSBUILDDEBUGPATH independently, which is why "Build Tests" steps work. The "Build product" step calls eng/build.sh, which did not set it.

This PR sets MSBUILDDEBUGPATH directly in eng/build.sh and eng/build.ps1 before any common/build.sh/common/build.ps1 invocations, matching the pattern used by the other scripts. This also:

Creates the directory with mkdir -p before MSBuild starts (MSBuild's EnsureDirectoryExists has no try/catch in its static constructor, so a failed directory creation would silently fall back to the temp dir)
Echoes the path for diagnostic visibility in build logs
Covers both the bootstrap and product build invocations

The existing pipeline variable in global-build-job.yml is left in place as defense-in-depth.

Relates to getting data to fix#92290

…rash diagnostics The MSBUILDDEBUGPATH pipeline variable added in PR dotnet#126012 is not reaching the MSBuild process during Build product steps. Set the env var directly in the build scripts, matching the existing pattern in build-runtime.sh and tests/build.sh. Also create the directory with mkdir -p / New-Item -Force to avoid issues with MSBuild's EnsureDirectoryExists (which has no try/catch in its static constructor). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR ensures MSBuild crash diagnostics (e.g., MSBuild_*.failure.txt from MSB4166) are consistently written under artifacts/log/ by setting up and exporting MSBUILDDEBUGPATH directly in the top-level build scripts (eng/build.sh and eng/build.ps1), rather than relying solely on CI pipeline variables.

Changes:

Set and export MSBUILDDEBUGPATH in eng/build.sh and create the target directory before invoking MSBuild.
Set and export MSBUILDDEBUGPATH in eng/build.ps1, create the target directory, and update it per-configuration when building multiple configurations.

Show a summary per file

File	Description
eng/build.sh	Adds `MSBUILDDEBUGPATH` initialization + `mkdir -p` so MSBuild crash logs land under `artifacts/log/<Config>/MsbuildDebugLogs`.
eng/build.ps1	Adds `MSBUILDDEBUGPATH` initialization + directory creation, and updates the env var per configuration in multi-config builds.

Copilot's findings

Comments suppressed due to low confidence (1)

eng/build.ps1:451

Same as above: inside the per-configuration loop, New-Item errors are non-terminating by default. If directory creation fails, the build continues and MSBuild crash diagnostics may not be captured under artifacts/log. Make directory creation terminating (e.g., -ErrorAction Stop) to ensure reliability.

 $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/$titleCaseConfig/MsbuildDebugLogs"
New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null
$env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir

Files reviewed: 2/2 changed files
Comments generated: 2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Updates top-level build entrypoints to ensure MSBuild crash diagnostics (MSBuild_*.failure.txt from MSB4166/node crashes) are consistently written under artifacts/log/ so CI reliably publishes them.

Changes:

Set and export MSBUILDDEBUGPATH early in eng/build.sh, create the directory, and print it for diagnostics.
Set and export MSBUILDDEBUGPATH early in eng/build.ps1, create the directory, print it, and update it per configuration during multi-config builds.

Show a summary per file

File	Description
eng/build.sh	Exports `MSBUILDDEBUGPATH` to a stable `artifacts/log/<config>/MsbuildDebugLogs` directory before invoking `eng/common/build.sh`.
eng/build.ps1	Exports `MSBUILDDEBUGPATH` to `artifacts/log/<config>/MsbuildDebugLogs`, ensures the directory exists, and adjusts it when iterating configurations.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

Copilot · 2026-04-12T07:19:45Z

+ $titleCaseConfig = $((Get-Culture).TextInfo.ToTitleCase($config))
+
+ # Update MSBuild debug logs directory for this configuration.
+ $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/$titleCaseConfig/MsbuildDebugLogs"
+ New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null
+ $env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir
+ Write-Host "MSBUILDDEBUGPATH=$msbuildDebugLogsDir"


In the multi-configuration loop you update $env:MSBUILDDEBUGPATH per config, but MSBuild node reuse is enabled by default for non-CI runs (/nr:true via eng/common/tools.ps1 where nodeReuse defaults to !$ci). Reused nodes won’t see the updated environment variable, so crash diagnostics may still be written to the previous configuration’s directory, making the per-config directory update potentially misleading. Consider either keeping a single MSBUILDDEBUGPATH for the whole build.ps1 invocation, or disabling node reuse when switching configurations so each config reliably writes to its intended directory.
See below for a potential fix:
# Use a single MSBuild debug logs directory for the entire invocation because # reused MSBuild nodes do not observe environment variable updates made between # configurations. $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/MsbuildDebugLogs" New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null $env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir Write-Host "MSBUILDDEBUGPATH=$msbuildDebugLogsDir" foreach ($config in $configuration) { $titleCaseConfig = $((Get-Culture).TextInfo.ToTitleCase($config))

jkotas · 2026-04-12T21:47:38Z

+# Set up the directory for MSBuild debug logs, so that if MSBuild crashes (MSB4166)
+# the failure.txt diagnostics are written to a known location under artifacts/log
+# where they'll be captured as build artifacts.
+MSBUILDDEBUGPATH="$scriptroot/../artifacts/log/${bootstrapConfig:-Debug}/MsbuildDebugLogs"


Why does this use ${bootstrapConfig:-Debug} ? I would expect it to use actual config for non-bootstrap builds.

jkotas · 2026-04-12T21:48:33Z

 done

 # Set a different path for prebuilt usage tracking for the bootstrap build.
 "$scriptroot/common/build.sh" ${bootstrapArguments[@]+"${bootstrapArguments[@]}"} /p:Subset=bootstrap /p:TrackPrebuiltUsageReportFile=$scriptroot/../artifacts/log/bootstrap-prebuilt-usage.xml -bl:$scriptroot/../artifacts/log/$bootstrapConfig/bootstrap.binlog


Would it be better to put this instrumentation into the common scripts like "$scriptroot/common/build.sh?

jkotas · 2026-04-12T21:49:01Z

The existing pipeline variable in global-build-job.yml is left in place as defense-in-depth.

Defense-in-depth against what?

danmoseley · 2026-04-14T05:12:45Z

Let's see whether we can do in arcade instead

danmoseley · 2026-04-12T07:12:16Z

Set MSBUILDDEBUGPATH directly in eng/build.sh for reliable crash diagnostics

PR #126012 added MSBUILDDEBUGPATH as an AzDO pipeline variable in global-build-job.yml so that MSBuild crash diagnostics (MSBuild_*.failure.txt) would be written to artifacts/log/ instead of the system temp directory. However, recent builds that hit the MSB4166 crash (e.g., build 1370423) still show MSBuild writing to the default temp path, indicating the pipeline variable is not reaching the MSBuild process.

Other build scripts (src/coreclr/build-runtime.sh, src/tests/build.sh) already set and export MSBUILDDEBUGPATH independently, which is why "Build Tests" steps work. The "Build product" step calls eng/build.sh, which did not set it.

This PR sets MSBUILDDEBUGPATH directly in eng/build.sh and eng/build.ps1 before any common/build.sh/common/build.ps1 invocations, matching the pattern used by the other scripts. This also:

Creates the directory with mkdir -p before MSBuild starts (MSBuild's EnsureDirectoryExists has no try/catch in its static constructor, so a failed directory creation would silently fall back to the temp dir)
Echoes the path for diagnostic visibility in build logs
Covers both the bootstrap and product build invocations

The existing pipeline variable in global-build-job.yml is left in place as defense-in-depth.

Relates to getting data to fix#92290

…rash diagnostics The MSBUILDDEBUGPATH pipeline variable added in PR dotnet#126012 is not reaching the MSBuild process during Build product steps. Set the env var directly in the build scripts, matching the existing pattern in build-runtime.sh and tests/build.sh. Also create the directory with mkdir -p / New-Item -Force to avoid issues with MSBuild's EnsureDirectoryExists (which has no try/catch in its static constructor). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR ensures MSBuild crash diagnostics (e.g., MSBuild_*.failure.txt from MSB4166) are consistently written under artifacts/log/ by setting up and exporting MSBUILDDEBUGPATH directly in the top-level build scripts (eng/build.sh and eng/build.ps1), rather than relying solely on CI pipeline variables.

Changes:

Set and export MSBUILDDEBUGPATH in eng/build.sh and create the target directory before invoking MSBuild.
Set and export MSBUILDDEBUGPATH in eng/build.ps1, create the target directory, and update it per-configuration when building multiple configurations.

Show a summary per file

File	Description
eng/build.sh	Adds `MSBUILDDEBUGPATH` initialization + `mkdir -p` so MSBuild crash logs land under `artifacts/log/<Config>/MsbuildDebugLogs`.
eng/build.ps1	Adds `MSBUILDDEBUGPATH` initialization + directory creation, and updates the env var per configuration in multi-config builds.

Copilot's findings

Comments suppressed due to low confidence (1)

eng/build.ps1:451

Same as above: inside the per-configuration loop, New-Item errors are non-terminating by default. If directory creation fails, the build continues and MSBuild crash diagnostics may not be captured under artifacts/log. Make directory creation terminating (e.g., -ErrorAction Stop) to ensure reliability.

 $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/$titleCaseConfig/MsbuildDebugLogs"
New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null
$env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir

Files reviewed: 2/2 changed files
Comments generated: 2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Updates top-level build entrypoints to ensure MSBuild crash diagnostics (MSBuild_*.failure.txt from MSB4166/node crashes) are consistently written under artifacts/log/ so CI reliably publishes them.

Changes:

Set and export MSBUILDDEBUGPATH early in eng/build.sh, create the directory, and print it for diagnostics.
Set and export MSBUILDDEBUGPATH early in eng/build.ps1, create the directory, print it, and update it per configuration during multi-config builds.

Show a summary per file

File	Description
eng/build.sh	Exports `MSBUILDDEBUGPATH` to a stable `artifacts/log/<config>/MsbuildDebugLogs` directory before invoking `eng/common/build.sh`.
eng/build.ps1	Exports `MSBUILDDEBUGPATH` to `artifacts/log/<config>/MsbuildDebugLogs`, ensures the directory exists, and adjusts it when iterating configurations.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

Copilot · 2026-04-12T07:19:45Z

+ $titleCaseConfig = $((Get-Culture).TextInfo.ToTitleCase($config))
+
+ # Update MSBuild debug logs directory for this configuration.
+ $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/$titleCaseConfig/MsbuildDebugLogs"
+ New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null
+ $env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir
+ Write-Host "MSBUILDDEBUGPATH=$msbuildDebugLogsDir"


In the multi-configuration loop you update $env:MSBUILDDEBUGPATH per config, but MSBuild node reuse is enabled by default for non-CI runs (/nr:true via eng/common/tools.ps1 where nodeReuse defaults to !$ci). Reused nodes won’t see the updated environment variable, so crash diagnostics may still be written to the previous configuration’s directory, making the per-config directory update potentially misleading. Consider either keeping a single MSBUILDDEBUGPATH for the whole build.ps1 invocation, or disabling node reuse when switching configurations so each config reliably writes to its intended directory.
See below for a potential fix:
# Use a single MSBuild debug logs directory for the entire invocation because # reused MSBuild nodes do not observe environment variable updates made between # configurations. $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/MsbuildDebugLogs" New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null $env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir Write-Host "MSBUILDDEBUGPATH=$msbuildDebugLogsDir" foreach ($config in $configuration) { $titleCaseConfig = $((Get-Culture).TextInfo.ToTitleCase($config))

jkotas · 2026-04-12T21:47:38Z

+# Set up the directory for MSBuild debug logs, so that if MSBuild crashes (MSB4166)
+# the failure.txt diagnostics are written to a known location under artifacts/log
+# where they'll be captured as build artifacts.
+MSBUILDDEBUGPATH="$scriptroot/../artifacts/log/${bootstrapConfig:-Debug}/MsbuildDebugLogs"


Why does this use ${bootstrapConfig:-Debug} ? I would expect it to use actual config for non-bootstrap builds.

jkotas · 2026-04-12T21:48:33Z

 done

 # Set a different path for prebuilt usage tracking for the bootstrap build.
 "$scriptroot/common/build.sh" ${bootstrapArguments[@]+"${bootstrapArguments[@]}"} /p:Subset=bootstrap /p:TrackPrebuiltUsageReportFile=$scriptroot/../artifacts/log/bootstrap-prebuilt-usage.xml -bl:$scriptroot/../artifacts/log/$bootstrapConfig/bootstrap.binlog


Would it be better to put this instrumentation into the common scripts like "$scriptroot/common/build.sh?

jkotas · 2026-04-12T21:49:01Z

The existing pipeline variable in global-build-job.yml is left in place as defense-in-depth.

Defense-in-depth against what?

danmoseley · 2026-04-14T05:12:45Z

Let's see whether we can do in arcade instead

danmoseley · 2026-04-12T07:12:16Z

Set MSBUILDDEBUGPATH directly in eng/build.sh for reliable crash diagnostics

PR #126012 added MSBUILDDEBUGPATH as an AzDO pipeline variable in global-build-job.yml so that MSBuild crash diagnostics (MSBuild_*.failure.txt) would be written to artifacts/log/ instead of the system temp directory. However, recent builds that hit the MSB4166 crash (e.g., build 1370423) still show MSBuild writing to the default temp path, indicating the pipeline variable is not reaching the MSBuild process.

Other build scripts (src/coreclr/build-runtime.sh, src/tests/build.sh) already set and export MSBUILDDEBUGPATH independently, which is why "Build Tests" steps work. The "Build product" step calls eng/build.sh, which did not set it.

This PR sets MSBUILDDEBUGPATH directly in eng/build.sh and eng/build.ps1 before any common/build.sh/common/build.ps1 invocations, matching the pattern used by the other scripts. This also:

Creates the directory with mkdir -p before MSBuild starts (MSBuild's EnsureDirectoryExists has no try/catch in its static constructor, so a failed directory creation would silently fall back to the temp dir)
Echoes the path for diagnostic visibility in build logs
Covers both the bootstrap and product build invocations

The existing pipeline variable in global-build-job.yml is left in place as defense-in-depth.

Relates to getting data to fix#92290

…rash diagnostics The MSBUILDDEBUGPATH pipeline variable added in PR dotnet#126012 is not reaching the MSBuild process during Build product steps. Set the env var directly in the build scripts, matching the existing pattern in build-runtime.sh and tests/build.sh. Also create the directory with mkdir -p / New-Item -Force to avoid issues with MSBuild's EnsureDirectoryExists (which has no try/catch in its static constructor). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR ensures MSBuild crash diagnostics (e.g., MSBuild_*.failure.txt from MSB4166) are consistently written under artifacts/log/ by setting up and exporting MSBUILDDEBUGPATH directly in the top-level build scripts (eng/build.sh and eng/build.ps1), rather than relying solely on CI pipeline variables.

Changes:

Set and export MSBUILDDEBUGPATH in eng/build.sh and create the target directory before invoking MSBuild.
Set and export MSBUILDDEBUGPATH in eng/build.ps1, create the target directory, and update it per-configuration when building multiple configurations.

Show a summary per file

File	Description
eng/build.sh	Adds `MSBUILDDEBUGPATH` initialization + `mkdir -p` so MSBuild crash logs land under `artifacts/log/<Config>/MsbuildDebugLogs`.
eng/build.ps1	Adds `MSBUILDDEBUGPATH` initialization + directory creation, and updates the env var per configuration in multi-config builds.

Copilot's findings

Comments suppressed due to low confidence (1)

eng/build.ps1:451

Same as above: inside the per-configuration loop, New-Item errors are non-terminating by default. If directory creation fails, the build continues and MSBuild crash diagnostics may not be captured under artifacts/log. Make directory creation terminating (e.g., -ErrorAction Stop) to ensure reliability.

 $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/$titleCaseConfig/MsbuildDebugLogs"
New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null
$env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir

Files reviewed: 2/2 changed files
Comments generated: 2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Updates top-level build entrypoints to ensure MSBuild crash diagnostics (MSBuild_*.failure.txt from MSB4166/node crashes) are consistently written under artifacts/log/ so CI reliably publishes them.

Changes:

Set and export MSBUILDDEBUGPATH early in eng/build.sh, create the directory, and print it for diagnostics.
Set and export MSBUILDDEBUGPATH early in eng/build.ps1, create the directory, print it, and update it per configuration during multi-config builds.

Show a summary per file

File	Description
eng/build.sh	Exports `MSBUILDDEBUGPATH` to a stable `artifacts/log/<config>/MsbuildDebugLogs` directory before invoking `eng/common/build.sh`.
eng/build.ps1	Exports `MSBUILDDEBUGPATH` to `artifacts/log/<config>/MsbuildDebugLogs`, ensures the directory exists, and adjusts it when iterating configurations.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

Copilot · 2026-04-12T07:19:45Z

+ $titleCaseConfig = $((Get-Culture).TextInfo.ToTitleCase($config))
+
+ # Update MSBuild debug logs directory for this configuration.
+ $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/$titleCaseConfig/MsbuildDebugLogs"
+ New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null
+ $env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir
+ Write-Host "MSBUILDDEBUGPATH=$msbuildDebugLogsDir"


In the multi-configuration loop you update $env:MSBUILDDEBUGPATH per config, but MSBuild node reuse is enabled by default for non-CI runs (/nr:true via eng/common/tools.ps1 where nodeReuse defaults to !$ci). Reused nodes won’t see the updated environment variable, so crash diagnostics may still be written to the previous configuration’s directory, making the per-config directory update potentially misleading. Consider either keeping a single MSBUILDDEBUGPATH for the whole build.ps1 invocation, or disabling node reuse when switching configurations so each config reliably writes to its intended directory.
See below for a potential fix:
# Use a single MSBuild debug logs directory for the entire invocation because # reused MSBuild nodes do not observe environment variable updates made between # configurations. $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/MsbuildDebugLogs" New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null $env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir Write-Host "MSBUILDDEBUGPATH=$msbuildDebugLogsDir" foreach ($config in $configuration) { $titleCaseConfig = $((Get-Culture).TextInfo.ToTitleCase($config))

jkotas · 2026-04-12T21:47:38Z

+# Set up the directory for MSBuild debug logs, so that if MSBuild crashes (MSB4166)
+# the failure.txt diagnostics are written to a known location under artifacts/log
+# where they'll be captured as build artifacts.
+MSBUILDDEBUGPATH="$scriptroot/../artifacts/log/${bootstrapConfig:-Debug}/MsbuildDebugLogs"


Why does this use ${bootstrapConfig:-Debug} ? I would expect it to use actual config for non-bootstrap builds.

jkotas · 2026-04-12T21:48:33Z

 done

 # Set a different path for prebuilt usage tracking for the bootstrap build.
 "$scriptroot/common/build.sh" ${bootstrapArguments[@]+"${bootstrapArguments[@]}"} /p:Subset=bootstrap /p:TrackPrebuiltUsageReportFile=$scriptroot/../artifacts/log/bootstrap-prebuilt-usage.xml -bl:$scriptroot/../artifacts/log/$bootstrapConfig/bootstrap.binlog


Would it be better to put this instrumentation into the common scripts like "$scriptroot/common/build.sh?

jkotas · 2026-04-12T21:49:01Z

The existing pipeline variable in global-build-job.yml is left in place as defense-in-depth.

Defense-in-depth against what?

danmoseley · 2026-04-14T05:12:45Z

Let's see whether we can do in arcade instead

danmoseley · 2026-04-12T07:12:16Z

Set MSBUILDDEBUGPATH directly in eng/build.sh for reliable crash diagnostics

PR #126012 added MSBUILDDEBUGPATH as an AzDO pipeline variable in global-build-job.yml so that MSBuild crash diagnostics (MSBuild_*.failure.txt) would be written to artifacts/log/ instead of the system temp directory. However, recent builds that hit the MSB4166 crash (e.g., build 1370423) still show MSBuild writing to the default temp path, indicating the pipeline variable is not reaching the MSBuild process.

Other build scripts (src/coreclr/build-runtime.sh, src/tests/build.sh) already set and export MSBUILDDEBUGPATH independently, which is why "Build Tests" steps work. The "Build product" step calls eng/build.sh, which did not set it.

This PR sets MSBUILDDEBUGPATH directly in eng/build.sh and eng/build.ps1 before any common/build.sh/common/build.ps1 invocations, matching the pattern used by the other scripts. This also:

Creates the directory with mkdir -p before MSBuild starts (MSBuild's EnsureDirectoryExists has no try/catch in its static constructor, so a failed directory creation would silently fall back to the temp dir)
Echoes the path for diagnostic visibility in build logs
Covers both the bootstrap and product build invocations

The existing pipeline variable in global-build-job.yml is left in place as defense-in-depth.

Relates to getting data to fix#92290

…rash diagnostics The MSBUILDDEBUGPATH pipeline variable added in PR dotnet#126012 is not reaching the MSBuild process during Build product steps. Set the env var directly in the build scripts, matching the existing pattern in build-runtime.sh and tests/build.sh. Also create the directory with mkdir -p / New-Item -Force to avoid issues with MSBuild's EnsureDirectoryExists (which has no try/catch in its static constructor). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR ensures MSBuild crash diagnostics (e.g., MSBuild_*.failure.txt from MSB4166) are consistently written under artifacts/log/ by setting up and exporting MSBUILDDEBUGPATH directly in the top-level build scripts (eng/build.sh and eng/build.ps1), rather than relying solely on CI pipeline variables.

Changes:

Set and export MSBUILDDEBUGPATH in eng/build.sh and create the target directory before invoking MSBuild.
Set and export MSBUILDDEBUGPATH in eng/build.ps1, create the target directory, and update it per-configuration when building multiple configurations.

Show a summary per file

File	Description
eng/build.sh	Adds `MSBUILDDEBUGPATH` initialization + `mkdir -p` so MSBuild crash logs land under `artifacts/log/<Config>/MsbuildDebugLogs`.
eng/build.ps1	Adds `MSBUILDDEBUGPATH` initialization + directory creation, and updates the env var per configuration in multi-config builds.

Copilot's findings

Comments suppressed due to low confidence (1)

eng/build.ps1:451

Same as above: inside the per-configuration loop, New-Item errors are non-terminating by default. If directory creation fails, the build continues and MSBuild crash diagnostics may not be captured under artifacts/log. Make directory creation terminating (e.g., -ErrorAction Stop) to ensure reliability.

 $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/$titleCaseConfig/MsbuildDebugLogs"
New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null
$env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir

Files reviewed: 2/2 changed files
Comments generated: 2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Updates top-level build entrypoints to ensure MSBuild crash diagnostics (MSBuild_*.failure.txt from MSB4166/node crashes) are consistently written under artifacts/log/ so CI reliably publishes them.

Changes:

Set and export MSBUILDDEBUGPATH early in eng/build.sh, create the directory, and print it for diagnostics.
Set and export MSBUILDDEBUGPATH early in eng/build.ps1, create the directory, print it, and update it per configuration during multi-config builds.

Show a summary per file

File	Description
eng/build.sh	Exports `MSBUILDDEBUGPATH` to a stable `artifacts/log/<config>/MsbuildDebugLogs` directory before invoking `eng/common/build.sh`.
eng/build.ps1	Exports `MSBUILDDEBUGPATH` to `artifacts/log/<config>/MsbuildDebugLogs`, ensures the directory exists, and adjusts it when iterating configurations.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

Copilot · 2026-04-12T07:19:45Z

+ $titleCaseConfig = $((Get-Culture).TextInfo.ToTitleCase($config))
+
+ # Update MSBuild debug logs directory for this configuration.
+ $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/$titleCaseConfig/MsbuildDebugLogs"
+ New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null
+ $env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir
+ Write-Host "MSBUILDDEBUGPATH=$msbuildDebugLogsDir"


In the multi-configuration loop you update $env:MSBUILDDEBUGPATH per config, but MSBuild node reuse is enabled by default for non-CI runs (/nr:true via eng/common/tools.ps1 where nodeReuse defaults to !$ci). Reused nodes won’t see the updated environment variable, so crash diagnostics may still be written to the previous configuration’s directory, making the per-config directory update potentially misleading. Consider either keeping a single MSBUILDDEBUGPATH for the whole build.ps1 invocation, or disabling node reuse when switching configurations so each config reliably writes to its intended directory.
See below for a potential fix:
# Use a single MSBuild debug logs directory for the entire invocation because # reused MSBuild nodes do not observe environment variable updates made between # configurations. $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/MsbuildDebugLogs" New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null $env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir Write-Host "MSBUILDDEBUGPATH=$msbuildDebugLogsDir" foreach ($config in $configuration) { $titleCaseConfig = $((Get-Culture).TextInfo.ToTitleCase($config))

jkotas · 2026-04-12T21:47:38Z

+# Set up the directory for MSBuild debug logs, so that if MSBuild crashes (MSB4166)
+# the failure.txt diagnostics are written to a known location under artifacts/log
+# where they'll be captured as build artifacts.
+MSBUILDDEBUGPATH="$scriptroot/../artifacts/log/${bootstrapConfig:-Debug}/MsbuildDebugLogs"


Why does this use ${bootstrapConfig:-Debug} ? I would expect it to use actual config for non-bootstrap builds.

jkotas · 2026-04-12T21:48:33Z

 done

 # Set a different path for prebuilt usage tracking for the bootstrap build.
 "$scriptroot/common/build.sh" ${bootstrapArguments[@]+"${bootstrapArguments[@]}"} /p:Subset=bootstrap /p:TrackPrebuiltUsageReportFile=$scriptroot/../artifacts/log/bootstrap-prebuilt-usage.xml -bl:$scriptroot/../artifacts/log/$bootstrapConfig/bootstrap.binlog


Would it be better to put this instrumentation into the common scripts like "$scriptroot/common/build.sh?

jkotas · 2026-04-12T21:49:01Z

The existing pipeline variable in global-build-job.yml is left in place as defense-in-depth.

Defense-in-depth against what?

danmoseley · 2026-04-14T05:12:45Z

Let's see whether we can do in arcade instead

danmoseley · 2026-04-12T07:12:16Z

Set MSBUILDDEBUGPATH directly in eng/build.sh for reliable crash diagnostics

PR #126012 added MSBUILDDEBUGPATH as an AzDO pipeline variable in global-build-job.yml so that MSBuild crash diagnostics (MSBuild_*.failure.txt) would be written to artifacts/log/ instead of the system temp directory. However, recent builds that hit the MSB4166 crash (e.g., build 1370423) still show MSBuild writing to the default temp path, indicating the pipeline variable is not reaching the MSBuild process.

Other build scripts (src/coreclr/build-runtime.sh, src/tests/build.sh) already set and export MSBUILDDEBUGPATH independently, which is why "Build Tests" steps work. The "Build product" step calls eng/build.sh, which did not set it.

This PR sets MSBUILDDEBUGPATH directly in eng/build.sh and eng/build.ps1 before any common/build.sh/common/build.ps1 invocations, matching the pattern used by the other scripts. This also:

Creates the directory with mkdir -p before MSBuild starts (MSBuild's EnsureDirectoryExists has no try/catch in its static constructor, so a failed directory creation would silently fall back to the temp dir)
Echoes the path for diagnostic visibility in build logs
Covers both the bootstrap and product build invocations

The existing pipeline variable in global-build-job.yml is left in place as defense-in-depth.

Relates to getting data to fix#92290

…rash diagnostics The MSBUILDDEBUGPATH pipeline variable added in PR dotnet#126012 is not reaching the MSBuild process during Build product steps. Set the env var directly in the build scripts, matching the existing pattern in build-runtime.sh and tests/build.sh. Also create the directory with mkdir -p / New-Item -Force to avoid issues with MSBuild's EnsureDirectoryExists (which has no try/catch in its static constructor). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR ensures MSBuild crash diagnostics (e.g., MSBuild_*.failure.txt from MSB4166) are consistently written under artifacts/log/ by setting up and exporting MSBUILDDEBUGPATH directly in the top-level build scripts (eng/build.sh and eng/build.ps1), rather than relying solely on CI pipeline variables.

Changes:

Set and export MSBUILDDEBUGPATH in eng/build.sh and create the target directory before invoking MSBuild.
Set and export MSBUILDDEBUGPATH in eng/build.ps1, create the target directory, and update it per-configuration when building multiple configurations.

Show a summary per file

File	Description
eng/build.sh	Adds `MSBUILDDEBUGPATH` initialization + `mkdir -p` so MSBuild crash logs land under `artifacts/log/<Config>/MsbuildDebugLogs`.
eng/build.ps1	Adds `MSBUILDDEBUGPATH` initialization + directory creation, and updates the env var per configuration in multi-config builds.

Copilot's findings

Comments suppressed due to low confidence (1)

eng/build.ps1:451

Same as above: inside the per-configuration loop, New-Item errors are non-terminating by default. If directory creation fails, the build continues and MSBuild crash diagnostics may not be captured under artifacts/log. Make directory creation terminating (e.g., -ErrorAction Stop) to ensure reliability.

 $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/$titleCaseConfig/MsbuildDebugLogs"
New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null
$env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir

Files reviewed: 2/2 changed files
Comments generated: 2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Updates top-level build entrypoints to ensure MSBuild crash diagnostics (MSBuild_*.failure.txt from MSB4166/node crashes) are consistently written under artifacts/log/ so CI reliably publishes them.

Changes:

Set and export MSBUILDDEBUGPATH early in eng/build.sh, create the directory, and print it for diagnostics.
Set and export MSBUILDDEBUGPATH early in eng/build.ps1, create the directory, print it, and update it per configuration during multi-config builds.

Show a summary per file

File	Description
eng/build.sh	Exports `MSBUILDDEBUGPATH` to a stable `artifacts/log/<config>/MsbuildDebugLogs` directory before invoking `eng/common/build.sh`.
eng/build.ps1	Exports `MSBUILDDEBUGPATH` to `artifacts/log/<config>/MsbuildDebugLogs`, ensures the directory exists, and adjusts it when iterating configurations.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

Copilot · 2026-04-12T07:19:45Z

+ $titleCaseConfig = $((Get-Culture).TextInfo.ToTitleCase($config))
+
+ # Update MSBuild debug logs directory for this configuration.
+ $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/$titleCaseConfig/MsbuildDebugLogs"
+ New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null
+ $env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir
+ Write-Host "MSBUILDDEBUGPATH=$msbuildDebugLogsDir"


In the multi-configuration loop you update $env:MSBUILDDEBUGPATH per config, but MSBuild node reuse is enabled by default for non-CI runs (/nr:true via eng/common/tools.ps1 where nodeReuse defaults to !$ci). Reused nodes won’t see the updated environment variable, so crash diagnostics may still be written to the previous configuration’s directory, making the per-config directory update potentially misleading. Consider either keeping a single MSBUILDDEBUGPATH for the whole build.ps1 invocation, or disabling node reuse when switching configurations so each config reliably writes to its intended directory.
See below for a potential fix:
# Use a single MSBuild debug logs directory for the entire invocation because # reused MSBuild nodes do not observe environment variable updates made between # configurations. $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/MsbuildDebugLogs" New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null $env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir Write-Host "MSBUILDDEBUGPATH=$msbuildDebugLogsDir" foreach ($config in $configuration) { $titleCaseConfig = $((Get-Culture).TextInfo.ToTitleCase($config))

jkotas · 2026-04-12T21:47:38Z

+# Set up the directory for MSBuild debug logs, so that if MSBuild crashes (MSB4166)
+# the failure.txt diagnostics are written to a known location under artifacts/log
+# where they'll be captured as build artifacts.
+MSBUILDDEBUGPATH="$scriptroot/../artifacts/log/${bootstrapConfig:-Debug}/MsbuildDebugLogs"


Why does this use ${bootstrapConfig:-Debug} ? I would expect it to use actual config for non-bootstrap builds.

jkotas · 2026-04-12T21:48:33Z

 done

 # Set a different path for prebuilt usage tracking for the bootstrap build.
 "$scriptroot/common/build.sh" ${bootstrapArguments[@]+"${bootstrapArguments[@]}"} /p:Subset=bootstrap /p:TrackPrebuiltUsageReportFile=$scriptroot/../artifacts/log/bootstrap-prebuilt-usage.xml -bl:$scriptroot/../artifacts/log/$bootstrapConfig/bootstrap.binlog


Would it be better to put this instrumentation into the common scripts like "$scriptroot/common/build.sh?

jkotas · 2026-04-12T21:49:01Z

The existing pipeline variable in global-build-job.yml is left in place as defense-in-depth.

Defense-in-depth against what?

danmoseley · 2026-04-14T05:12:45Z

Let's see whether we can do in arcade instead

danmoseley · 2026-04-12T07:12:16Z

Set MSBUILDDEBUGPATH directly in eng/build.sh for reliable crash diagnostics

PR #126012 added MSBUILDDEBUGPATH as an AzDO pipeline variable in global-build-job.yml so that MSBuild crash diagnostics (MSBuild_*.failure.txt) would be written to artifacts/log/ instead of the system temp directory. However, recent builds that hit the MSB4166 crash (e.g., build 1370423) still show MSBuild writing to the default temp path, indicating the pipeline variable is not reaching the MSBuild process.

Other build scripts (src/coreclr/build-runtime.sh, src/tests/build.sh) already set and export MSBUILDDEBUGPATH independently, which is why "Build Tests" steps work. The "Build product" step calls eng/build.sh, which did not set it.

This PR sets MSBUILDDEBUGPATH directly in eng/build.sh and eng/build.ps1 before any common/build.sh/common/build.ps1 invocations, matching the pattern used by the other scripts. This also:

Creates the directory with mkdir -p before MSBuild starts (MSBuild's EnsureDirectoryExists has no try/catch in its static constructor, so a failed directory creation would silently fall back to the temp dir)
Echoes the path for diagnostic visibility in build logs
Covers both the bootstrap and product build invocations

The existing pipeline variable in global-build-job.yml is left in place as defense-in-depth.

Relates to getting data to fix#92290

…rash diagnostics The MSBUILDDEBUGPATH pipeline variable added in PR dotnet#126012 is not reaching the MSBuild process during Build product steps. Set the env var directly in the build scripts, matching the existing pattern in build-runtime.sh and tests/build.sh. Also create the directory with mkdir -p / New-Item -Force to avoid issues with MSBuild's EnsureDirectoryExists (which has no try/catch in its static constructor). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR ensures MSBuild crash diagnostics (e.g., MSBuild_*.failure.txt from MSB4166) are consistently written under artifacts/log/ by setting up and exporting MSBUILDDEBUGPATH directly in the top-level build scripts (eng/build.sh and eng/build.ps1), rather than relying solely on CI pipeline variables.

Changes:

Set and export MSBUILDDEBUGPATH in eng/build.sh and create the target directory before invoking MSBuild.
Set and export MSBUILDDEBUGPATH in eng/build.ps1, create the target directory, and update it per-configuration when building multiple configurations.

Show a summary per file

File	Description
eng/build.sh	Adds `MSBUILDDEBUGPATH` initialization + `mkdir -p` so MSBuild crash logs land under `artifacts/log/<Config>/MsbuildDebugLogs`.
eng/build.ps1	Adds `MSBUILDDEBUGPATH` initialization + directory creation, and updates the env var per configuration in multi-config builds.

Copilot's findings

Comments suppressed due to low confidence (1)

eng/build.ps1:451

Same as above: inside the per-configuration loop, New-Item errors are non-terminating by default. If directory creation fails, the build continues and MSBuild crash diagnostics may not be captured under artifacts/log. Make directory creation terminating (e.g., -ErrorAction Stop) to ensure reliability.

 $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/$titleCaseConfig/MsbuildDebugLogs"
New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null
$env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir

Files reviewed: 2/2 changed files
Comments generated: 2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Updates top-level build entrypoints to ensure MSBuild crash diagnostics (MSBuild_*.failure.txt from MSB4166/node crashes) are consistently written under artifacts/log/ so CI reliably publishes them.

Changes:

Set and export MSBUILDDEBUGPATH early in eng/build.sh, create the directory, and print it for diagnostics.
Set and export MSBUILDDEBUGPATH early in eng/build.ps1, create the directory, print it, and update it per configuration during multi-config builds.

Show a summary per file

File	Description
eng/build.sh	Exports `MSBUILDDEBUGPATH` to a stable `artifacts/log/<config>/MsbuildDebugLogs` directory before invoking `eng/common/build.sh`.
eng/build.ps1	Exports `MSBUILDDEBUGPATH` to `artifacts/log/<config>/MsbuildDebugLogs`, ensures the directory exists, and adjusts it when iterating configurations.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

Copilot · 2026-04-12T07:19:45Z

+ $titleCaseConfig = $((Get-Culture).TextInfo.ToTitleCase($config))
+
+ # Update MSBuild debug logs directory for this configuration.
+ $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/$titleCaseConfig/MsbuildDebugLogs"
+ New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null
+ $env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir
+ Write-Host "MSBUILDDEBUGPATH=$msbuildDebugLogsDir"


In the multi-configuration loop you update $env:MSBUILDDEBUGPATH per config, but MSBuild node reuse is enabled by default for non-CI runs (/nr:true via eng/common/tools.ps1 where nodeReuse defaults to !$ci). Reused nodes won’t see the updated environment variable, so crash diagnostics may still be written to the previous configuration’s directory, making the per-config directory update potentially misleading. Consider either keeping a single MSBUILDDEBUGPATH for the whole build.ps1 invocation, or disabling node reuse when switching configurations so each config reliably writes to its intended directory.
See below for a potential fix:
# Use a single MSBuild debug logs directory for the entire invocation because # reused MSBuild nodes do not observe environment variable updates made between # configurations. $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/MsbuildDebugLogs" New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null $env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir Write-Host "MSBUILDDEBUGPATH=$msbuildDebugLogsDir" foreach ($config in $configuration) { $titleCaseConfig = $((Get-Culture).TextInfo.ToTitleCase($config))

jkotas · 2026-04-12T21:47:38Z

+# Set up the directory for MSBuild debug logs, so that if MSBuild crashes (MSB4166)
+# the failure.txt diagnostics are written to a known location under artifacts/log
+# where they'll be captured as build artifacts.
+MSBUILDDEBUGPATH="$scriptroot/../artifacts/log/${bootstrapConfig:-Debug}/MsbuildDebugLogs"


Why does this use ${bootstrapConfig:-Debug} ? I would expect it to use actual config for non-bootstrap builds.

jkotas · 2026-04-12T21:48:33Z

 done

 # Set a different path for prebuilt usage tracking for the bootstrap build.
 "$scriptroot/common/build.sh" ${bootstrapArguments[@]+"${bootstrapArguments[@]}"} /p:Subset=bootstrap /p:TrackPrebuiltUsageReportFile=$scriptroot/../artifacts/log/bootstrap-prebuilt-usage.xml -bl:$scriptroot/../artifacts/log/$bootstrapConfig/bootstrap.binlog


Would it be better to put this instrumentation into the common scripts like "$scriptroot/common/build.sh?

jkotas · 2026-04-12T21:49:01Z

The existing pipeline variable in global-build-job.yml is left in place as defense-in-depth.

Defense-in-depth against what?

danmoseley · 2026-04-14T05:12:45Z

Let's see whether we can do in arcade instead

danmoseley · 2026-04-12T07:12:16Z

Set MSBUILDDEBUGPATH directly in eng/build.sh for reliable crash diagnostics

PR #126012 added MSBUILDDEBUGPATH as an AzDO pipeline variable in global-build-job.yml so that MSBuild crash diagnostics (MSBuild_*.failure.txt) would be written to artifacts/log/ instead of the system temp directory. However, recent builds that hit the MSB4166 crash (e.g., build 1370423) still show MSBuild writing to the default temp path, indicating the pipeline variable is not reaching the MSBuild process.

Other build scripts (src/coreclr/build-runtime.sh, src/tests/build.sh) already set and export MSBUILDDEBUGPATH independently, which is why "Build Tests" steps work. The "Build product" step calls eng/build.sh, which did not set it.

This PR sets MSBUILDDEBUGPATH directly in eng/build.sh and eng/build.ps1 before any common/build.sh/common/build.ps1 invocations, matching the pattern used by the other scripts. This also:

Creates the directory with mkdir -p before MSBuild starts (MSBuild's EnsureDirectoryExists has no try/catch in its static constructor, so a failed directory creation would silently fall back to the temp dir)
Echoes the path for diagnostic visibility in build logs
Covers both the bootstrap and product build invocations

The existing pipeline variable in global-build-job.yml is left in place as defense-in-depth.

Relates to getting data to fix#92290

…rash diagnostics The MSBUILDDEBUGPATH pipeline variable added in PR dotnet#126012 is not reaching the MSBuild process during Build product steps. Set the env var directly in the build scripts, matching the existing pattern in build-runtime.sh and tests/build.sh. Also create the directory with mkdir -p / New-Item -Force to avoid issues with MSBuild's EnsureDirectoryExists (which has no try/catch in its static constructor). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR ensures MSBuild crash diagnostics (e.g., MSBuild_*.failure.txt from MSB4166) are consistently written under artifacts/log/ by setting up and exporting MSBUILDDEBUGPATH directly in the top-level build scripts (eng/build.sh and eng/build.ps1), rather than relying solely on CI pipeline variables.

Changes:

Set and export MSBUILDDEBUGPATH in eng/build.sh and create the target directory before invoking MSBuild.
Set and export MSBUILDDEBUGPATH in eng/build.ps1, create the target directory, and update it per-configuration when building multiple configurations.

Show a summary per file

File	Description
eng/build.sh	Adds `MSBUILDDEBUGPATH` initialization + `mkdir -p` so MSBuild crash logs land under `artifacts/log/<Config>/MsbuildDebugLogs`.
eng/build.ps1	Adds `MSBUILDDEBUGPATH` initialization + directory creation, and updates the env var per configuration in multi-config builds.

Copilot's findings

Comments suppressed due to low confidence (1)

eng/build.ps1:451

Same as above: inside the per-configuration loop, New-Item errors are non-terminating by default. If directory creation fails, the build continues and MSBuild crash diagnostics may not be captured under artifacts/log. Make directory creation terminating (e.g., -ErrorAction Stop) to ensure reliability.

 $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/$titleCaseConfig/MsbuildDebugLogs"
New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null
$env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir

Files reviewed: 2/2 changed files
Comments generated: 2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Updates top-level build entrypoints to ensure MSBuild crash diagnostics (MSBuild_*.failure.txt from MSB4166/node crashes) are consistently written under artifacts/log/ so CI reliably publishes them.

Changes:

Set and export MSBUILDDEBUGPATH early in eng/build.sh, create the directory, and print it for diagnostics.
Set and export MSBUILDDEBUGPATH early in eng/build.ps1, create the directory, print it, and update it per configuration during multi-config builds.

Show a summary per file

File	Description
eng/build.sh	Exports `MSBUILDDEBUGPATH` to a stable `artifacts/log/<config>/MsbuildDebugLogs` directory before invoking `eng/common/build.sh`.
eng/build.ps1	Exports `MSBUILDDEBUGPATH` to `artifacts/log/<config>/MsbuildDebugLogs`, ensures the directory exists, and adjusts it when iterating configurations.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

Copilot · 2026-04-12T07:19:45Z

+ $titleCaseConfig = $((Get-Culture).TextInfo.ToTitleCase($config))
+
+ # Update MSBuild debug logs directory for this configuration.
+ $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/$titleCaseConfig/MsbuildDebugLogs"
+ New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null
+ $env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir
+ Write-Host "MSBUILDDEBUGPATH=$msbuildDebugLogsDir"


In the multi-configuration loop you update $env:MSBUILDDEBUGPATH per config, but MSBuild node reuse is enabled by default for non-CI runs (/nr:true via eng/common/tools.ps1 where nodeReuse defaults to !$ci). Reused nodes won’t see the updated environment variable, so crash diagnostics may still be written to the previous configuration’s directory, making the per-config directory update potentially misleading. Consider either keeping a single MSBUILDDEBUGPATH for the whole build.ps1 invocation, or disabling node reuse when switching configurations so each config reliably writes to its intended directory.
See below for a potential fix:
# Use a single MSBuild debug logs directory for the entire invocation because # reused MSBuild nodes do not observe environment variable updates made between # configurations. $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/MsbuildDebugLogs" New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null $env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir Write-Host "MSBUILDDEBUGPATH=$msbuildDebugLogsDir" foreach ($config in $configuration) { $titleCaseConfig = $((Get-Culture).TextInfo.ToTitleCase($config))

jkotas · 2026-04-12T21:47:38Z

+# Set up the directory for MSBuild debug logs, so that if MSBuild crashes (MSB4166)
+# the failure.txt diagnostics are written to a known location under artifacts/log
+# where they'll be captured as build artifacts.
+MSBUILDDEBUGPATH="$scriptroot/../artifacts/log/${bootstrapConfig:-Debug}/MsbuildDebugLogs"


Why does this use ${bootstrapConfig:-Debug} ? I would expect it to use actual config for non-bootstrap builds.

jkotas · 2026-04-12T21:48:33Z

 done

 # Set a different path for prebuilt usage tracking for the bootstrap build.
 "$scriptroot/common/build.sh" ${bootstrapArguments[@]+"${bootstrapArguments[@]}"} /p:Subset=bootstrap /p:TrackPrebuiltUsageReportFile=$scriptroot/../artifacts/log/bootstrap-prebuilt-usage.xml -bl:$scriptroot/../artifacts/log/$bootstrapConfig/bootstrap.binlog


Would it be better to put this instrumentation into the common scripts like "$scriptroot/common/build.sh?

jkotas · 2026-04-12T21:49:01Z

The existing pipeline variable in global-build-job.yml is left in place as defense-in-depth.

Defense-in-depth against what?

danmoseley · 2026-04-14T05:12:45Z

Let's see whether we can do in arcade instead

danmoseley · 2026-04-12T07:12:16Z

Set MSBUILDDEBUGPATH directly in eng/build.sh for reliable crash diagnostics

PR #126012 added MSBUILDDEBUGPATH as an AzDO pipeline variable in global-build-job.yml so that MSBuild crash diagnostics (MSBuild_*.failure.txt) would be written to artifacts/log/ instead of the system temp directory. However, recent builds that hit the MSB4166 crash (e.g., build 1370423) still show MSBuild writing to the default temp path, indicating the pipeline variable is not reaching the MSBuild process.

Other build scripts (src/coreclr/build-runtime.sh, src/tests/build.sh) already set and export MSBUILDDEBUGPATH independently, which is why "Build Tests" steps work. The "Build product" step calls eng/build.sh, which did not set it.

This PR sets MSBUILDDEBUGPATH directly in eng/build.sh and eng/build.ps1 before any common/build.sh/common/build.ps1 invocations, matching the pattern used by the other scripts. This also:

Creates the directory with mkdir -p before MSBuild starts (MSBuild's EnsureDirectoryExists has no try/catch in its static constructor, so a failed directory creation would silently fall back to the temp dir)
Echoes the path for diagnostic visibility in build logs
Covers both the bootstrap and product build invocations

The existing pipeline variable in global-build-job.yml is left in place as defense-in-depth.

Relates to getting data to fix#92290

…rash diagnostics The MSBUILDDEBUGPATH pipeline variable added in PR dotnet#126012 is not reaching the MSBuild process during Build product steps. Set the env var directly in the build scripts, matching the existing pattern in build-runtime.sh and tests/build.sh. Also create the directory with mkdir -p / New-Item -Force to avoid issues with MSBuild's EnsureDirectoryExists (which has no try/catch in its static constructor). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR ensures MSBuild crash diagnostics (e.g., MSBuild_*.failure.txt from MSB4166) are consistently written under artifacts/log/ by setting up and exporting MSBUILDDEBUGPATH directly in the top-level build scripts (eng/build.sh and eng/build.ps1), rather than relying solely on CI pipeline variables.

Changes:

Set and export MSBUILDDEBUGPATH in eng/build.sh and create the target directory before invoking MSBuild.
Set and export MSBUILDDEBUGPATH in eng/build.ps1, create the target directory, and update it per-configuration when building multiple configurations.

Show a summary per file

File	Description
eng/build.sh	Adds `MSBUILDDEBUGPATH` initialization + `mkdir -p` so MSBuild crash logs land under `artifacts/log/<Config>/MsbuildDebugLogs`.
eng/build.ps1	Adds `MSBUILDDEBUGPATH` initialization + directory creation, and updates the env var per configuration in multi-config builds.

Copilot's findings

Comments suppressed due to low confidence (1)

eng/build.ps1:451

Same as above: inside the per-configuration loop, New-Item errors are non-terminating by default. If directory creation fails, the build continues and MSBuild crash diagnostics may not be captured under artifacts/log. Make directory creation terminating (e.g., -ErrorAction Stop) to ensure reliability.

 $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/$titleCaseConfig/MsbuildDebugLogs"
New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null
$env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir

Files reviewed: 2/2 changed files
Comments generated: 2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Updates top-level build entrypoints to ensure MSBuild crash diagnostics (MSBuild_*.failure.txt from MSB4166/node crashes) are consistently written under artifacts/log/ so CI reliably publishes them.

Changes:

Set and export MSBUILDDEBUGPATH early in eng/build.sh, create the directory, and print it for diagnostics.
Set and export MSBUILDDEBUGPATH early in eng/build.ps1, create the directory, print it, and update it per configuration during multi-config builds.

Show a summary per file

File	Description
eng/build.sh	Exports `MSBUILDDEBUGPATH` to a stable `artifacts/log/<config>/MsbuildDebugLogs` directory before invoking `eng/common/build.sh`.
eng/build.ps1	Exports `MSBUILDDEBUGPATH` to `artifacts/log/<config>/MsbuildDebugLogs`, ensures the directory exists, and adjusts it when iterating configurations.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

Copilot · 2026-04-12T07:19:45Z

+ $titleCaseConfig = $((Get-Culture).TextInfo.ToTitleCase($config))
+
+ # Update MSBuild debug logs directory for this configuration.
+ $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/$titleCaseConfig/MsbuildDebugLogs"
+ New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null
+ $env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir
+ Write-Host "MSBUILDDEBUGPATH=$msbuildDebugLogsDir"


In the multi-configuration loop you update $env:MSBUILDDEBUGPATH per config, but MSBuild node reuse is enabled by default for non-CI runs (/nr:true via eng/common/tools.ps1 where nodeReuse defaults to !$ci). Reused nodes won’t see the updated environment variable, so crash diagnostics may still be written to the previous configuration’s directory, making the per-config directory update potentially misleading. Consider either keeping a single MSBUILDDEBUGPATH for the whole build.ps1 invocation, or disabling node reuse when switching configurations so each config reliably writes to its intended directory.
See below for a potential fix:
# Use a single MSBuild debug logs directory for the entire invocation because # reused MSBuild nodes do not observe environment variable updates made between # configurations. $msbuildDebugLogsDir = "$PSScriptRoot/../artifacts/log/MsbuildDebugLogs" New-Item -ItemType Directory -Force -Path $msbuildDebugLogsDir | Out-Null $env:MSBUILDDEBUGPATH = $msbuildDebugLogsDir Write-Host "MSBUILDDEBUGPATH=$msbuildDebugLogsDir" foreach ($config in $configuration) { $titleCaseConfig = $((Get-Culture).TextInfo.ToTitleCase($config))

jkotas · 2026-04-12T21:47:38Z

+# Set up the directory for MSBuild debug logs, so that if MSBuild crashes (MSB4166)
+# the failure.txt diagnostics are written to a known location under artifacts/log
+# where they'll be captured as build artifacts.
+MSBUILDDEBUGPATH="$scriptroot/../artifacts/log/${bootstrapConfig:-Debug}/MsbuildDebugLogs"


Why does this use ${bootstrapConfig:-Debug} ? I would expect it to use actual config for non-bootstrap builds.

jkotas · 2026-04-12T21:48:33Z

 done

 # Set a different path for prebuilt usage tracking for the bootstrap build.
 "$scriptroot/common/build.sh" ${bootstrapArguments[@]+"${bootstrapArguments[@]}"} /p:Subset=bootstrap /p:TrackPrebuiltUsageReportFile=$scriptroot/../artifacts/log/bootstrap-prebuilt-usage.xml -bl:$scriptroot/../artifacts/log/$bootstrapConfig/bootstrap.binlog


Would it be better to put this instrumentation into the common scripts like "$scriptroot/common/build.sh?

jkotas · 2026-04-12T21:49:01Z

The existing pipeline variable in global-build-job.yml is left in place as defense-in-depth.

Defense-in-depth against what?

danmoseley · 2026-04-14T05:12:45Z

Let's see whether we can do in arcade instead

CopilotAI review requested due to automatic review settings April 12, 2026 07:12

github-actionsBot added the area-Build-mono label Apr 12, 2026

dotnet-policy-serviceBot assigned danmoseley Apr 12, 2026

Copilotstarted reviewing on behalf of danmoseley April 12, 2026 07:13 View session

Remove issue URL from comments; use git history instead
979dfa1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

danmoseley added area-Infrastructure and removed area-Build-mono labels Apr 12, 2026

github-project-automationBot added this to Runtime Infra Apr 12, 2026

CopilotAI reviewed Apr 12, 2026
View reviewed changes

Comment threadeng/build.ps1
Comment threadeng/build.ps1

danmoseley requested review from Copilot and hoyosjs April 12, 2026 07:15

Log MSBUILDDEBUGPATH inside per-config loop
517582a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilotstarted reviewing on behalf of danmoseley April 12, 2026 07:17 View session

CopilotAI reviewed Apr 12, 2026
View reviewed changes

jkotas reviewed Apr 12, 2026
View reviewed changes

danmoseley closed this Apr 14, 2026

github-project-automationBot moved this to Done in Runtime Infra Apr 14, 2026

danmoseley mentioned this pull request Apr 14, 2026
Set MSBUILDDEBUGPATH in common build scripts for crash diagnostics dotnet/arcade#16715
Merged

github-actionsBot locked and limited conversation to collaborators May 14, 2026

CopilotAI review requested due to automatic review settings April 12, 2026 07:12

github-actionsBot added the area-Build-mono label Apr 12, 2026

dotnet-policy-serviceBot assigned danmoseley Apr 12, 2026

Copilotstarted reviewing on behalf of danmoseley April 12, 2026 07:13 View session

Remove issue URL from comments; use git history instead
979dfa1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

danmoseley added area-Infrastructure and removed area-Build-mono labels Apr 12, 2026

github-project-automationBot added this to Runtime Infra Apr 12, 2026

CopilotAI reviewed Apr 12, 2026
View reviewed changes

Comment threadeng/build.ps1
Comment threadeng/build.ps1

danmoseley requested review from Copilot and hoyosjs April 12, 2026 07:15

Log MSBUILDDEBUGPATH inside per-config loop
517582a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilotstarted reviewing on behalf of danmoseley April 12, 2026 07:17 View session

CopilotAI reviewed Apr 12, 2026
View reviewed changes

jkotas reviewed Apr 12, 2026
View reviewed changes

danmoseley closed this Apr 14, 2026

github-project-automationBot moved this to Done in Runtime Infra Apr 14, 2026

danmoseley mentioned this pull request Apr 14, 2026
Set MSBUILDDEBUGPATH in common build scripts for crash diagnostics dotnet/arcade#16715
Merged

github-actionsBot locked and limited conversation to collaborators May 14, 2026

CopilotAI review requested due to automatic review settings April 12, 2026 07:12

github-actionsBot added the area-Build-mono label Apr 12, 2026

dotnet-policy-serviceBot assigned danmoseley Apr 12, 2026

Copilotstarted reviewing on behalf of danmoseley April 12, 2026 07:13 View session

Remove issue URL from comments; use git history instead
979dfa1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

danmoseley added area-Infrastructure and removed area-Build-mono labels Apr 12, 2026

github-project-automationBot added this to Runtime Infra Apr 12, 2026

CopilotAI reviewed Apr 12, 2026
View reviewed changes

Comment threadeng/build.ps1
Comment threadeng/build.ps1

danmoseley requested review from Copilot and hoyosjs April 12, 2026 07:15

Log MSBUILDDEBUGPATH inside per-config loop
517582a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilotstarted reviewing on behalf of danmoseley April 12, 2026 07:17 View session

CopilotAI reviewed Apr 12, 2026
View reviewed changes

jkotas reviewed Apr 12, 2026
View reviewed changes

danmoseley closed this Apr 14, 2026

github-project-automationBot moved this to Done in Runtime Infra Apr 14, 2026

danmoseley mentioned this pull request Apr 14, 2026
Set MSBUILDDEBUGPATH in common build scripts for crash diagnostics dotnet/arcade#16715
Merged

github-actionsBot locked and limited conversation to collaborators May 14, 2026

CopilotAI review requested due to automatic review settings April 12, 2026 07:12

github-actionsBot added the area-Build-mono label Apr 12, 2026

dotnet-policy-serviceBot assigned danmoseley Apr 12, 2026

Copilotstarted reviewing on behalf of danmoseley April 12, 2026 07:13 View session

Remove issue URL from comments; use git history instead
979dfa1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

danmoseley added area-Infrastructure and removed area-Build-mono labels Apr 12, 2026

github-project-automationBot added this to Runtime Infra Apr 12, 2026

CopilotAI reviewed Apr 12, 2026
View reviewed changes

Comment threadeng/build.ps1
Comment threadeng/build.ps1

danmoseley requested review from Copilot and hoyosjs April 12, 2026 07:15

Log MSBUILDDEBUGPATH inside per-config loop
517582a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilotstarted reviewing on behalf of danmoseley April 12, 2026 07:17 View session

CopilotAI reviewed Apr 12, 2026
View reviewed changes

jkotas reviewed Apr 12, 2026
View reviewed changes

danmoseley closed this Apr 14, 2026

github-project-automationBot moved this to Done in Runtime Infra Apr 14, 2026

danmoseley mentioned this pull request Apr 14, 2026
Set MSBUILDDEBUGPATH in common build scripts for crash diagnostics dotnet/arcade#16715
Merged

github-actionsBot locked and limited conversation to collaborators May 14, 2026

CopilotAI review requested due to automatic review settings April 12, 2026 07:12

github-actionsBot added the area-Build-mono label Apr 12, 2026

dotnet-policy-serviceBot assigned danmoseley Apr 12, 2026

Copilotstarted reviewing on behalf of danmoseley April 12, 2026 07:13 View session

Remove issue URL from comments; use git history instead
979dfa1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

danmoseley added area-Infrastructure and removed area-Build-mono labels Apr 12, 2026

github-project-automationBot added this to Runtime Infra Apr 12, 2026

CopilotAI reviewed Apr 12, 2026
View reviewed changes

Comment threadeng/build.ps1
Comment threadeng/build.ps1

danmoseley requested review from Copilot and hoyosjs April 12, 2026 07:15

Log MSBUILDDEBUGPATH inside per-config loop
517582a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilotstarted reviewing on behalf of danmoseley April 12, 2026 07:17 View session

CopilotAI reviewed Apr 12, 2026
View reviewed changes

jkotas reviewed Apr 12, 2026
View reviewed changes

danmoseley closed this Apr 14, 2026

github-project-automationBot moved this to Done in Runtime Infra Apr 14, 2026

danmoseley mentioned this pull request Apr 14, 2026
Set MSBUILDDEBUGPATH in common build scripts for crash diagnostics dotnet/arcade#16715
Merged

github-actionsBot locked and limited conversation to collaborators May 14, 2026

CopilotAI review requested due to automatic review settings April 12, 2026 07:12

github-actionsBot added the area-Build-mono label Apr 12, 2026

dotnet-policy-serviceBot assigned danmoseley Apr 12, 2026

Copilotstarted reviewing on behalf of danmoseley April 12, 2026 07:13 View session

Remove issue URL from comments; use git history instead
979dfa1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

danmoseley added area-Infrastructure and removed area-Build-mono labels Apr 12, 2026

github-project-automationBot added this to Runtime Infra Apr 12, 2026

CopilotAI reviewed Apr 12, 2026
View reviewed changes

Comment threadeng/build.ps1
Comment threadeng/build.ps1

danmoseley requested review from Copilot and hoyosjs April 12, 2026 07:15

Log MSBUILDDEBUGPATH inside per-config loop
517582a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilotstarted reviewing on behalf of danmoseley April 12, 2026 07:17 View session

CopilotAI reviewed Apr 12, 2026
View reviewed changes

jkotas reviewed Apr 12, 2026
View reviewed changes

danmoseley closed this Apr 14, 2026

github-project-automationBot moved this to Done in Runtime Infra Apr 14, 2026

danmoseley mentioned this pull request Apr 14, 2026
Set MSBUILDDEBUGPATH in common build scripts for crash diagnostics dotnet/arcade#16715
Merged

github-actionsBot locked and limited conversation to collaborators May 14, 2026

CopilotAI review requested due to automatic review settings April 12, 2026 07:12

github-actionsBot added the area-Build-mono label Apr 12, 2026

dotnet-policy-serviceBot assigned danmoseley Apr 12, 2026

Copilotstarted reviewing on behalf of danmoseley April 12, 2026 07:13 View session

Remove issue URL from comments; use git history instead
979dfa1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

danmoseley added area-Infrastructure and removed area-Build-mono labels Apr 12, 2026

github-project-automationBot added this to Runtime Infra Apr 12, 2026

CopilotAI reviewed Apr 12, 2026
View reviewed changes

Comment threadeng/build.ps1
Comment threadeng/build.ps1

danmoseley requested review from Copilot and hoyosjs April 12, 2026 07:15

Log MSBUILDDEBUGPATH inside per-config loop
517582a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilotstarted reviewing on behalf of danmoseley April 12, 2026 07:17 View session

CopilotAI reviewed Apr 12, 2026
View reviewed changes

jkotas reviewed Apr 12, 2026
View reviewed changes

danmoseley closed this Apr 14, 2026

github-project-automationBot moved this to Done in Runtime Infra Apr 14, 2026

danmoseley mentioned this pull request Apr 14, 2026
Set MSBUILDDEBUGPATH in common build scripts for crash diagnostics dotnet/arcade#16715
Merged

github-actionsBot locked and limited conversation to collaborators May 14, 2026

CopilotAI review requested due to automatic review settings April 12, 2026 07:12

github-actionsBot added the area-Build-mono label Apr 12, 2026

dotnet-policy-serviceBot assigned danmoseley Apr 12, 2026

Copilotstarted reviewing on behalf of danmoseley April 12, 2026 07:13 View session

Remove issue URL from comments; use git history instead
979dfa1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

danmoseley added area-Infrastructure and removed area-Build-mono labels Apr 12, 2026

github-project-automationBot added this to Runtime Infra Apr 12, 2026

CopilotAI reviewed Apr 12, 2026
View reviewed changes

Comment threadeng/build.ps1
Comment threadeng/build.ps1

danmoseley requested review from Copilot and hoyosjs April 12, 2026 07:15

Log MSBUILDDEBUGPATH inside per-config loop
517582a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilotstarted reviewing on behalf of danmoseley April 12, 2026 07:17 View session

CopilotAI reviewed Apr 12, 2026
View reviewed changes

jkotas reviewed Apr 12, 2026
View reviewed changes

danmoseley closed this Apr 14, 2026

github-project-automationBot moved this to Done in Runtime Infra Apr 14, 2026

danmoseley mentioned this pull request Apr 14, 2026
Set MSBUILDDEBUGPATH in common build scripts for crash diagnostics dotnet/arcade#16715
Merged

github-actionsBot locked and limited conversation to collaborators May 14, 2026

Uh oh!

Conversation

danmoseley commented Apr 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

CopilotAIApr 12, 2026

Choose a reason for hiding this comment

Uh oh!

jkotasApr 12, 2026

Choose a reason for hiding this comment

Uh oh!

jkotasApr 12, 2026

Choose a reason for hiding this comment

Uh oh!

jkotas commented Apr 12, 2026

Uh oh!

danmoseley commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

danmoseley commented Apr 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

CopilotAIApr 12, 2026

Choose a reason for hiding this comment

Uh oh!

jkotasApr 12, 2026

Choose a reason for hiding this comment

Uh oh!

jkotasApr 12, 2026

Choose a reason for hiding this comment

Uh oh!

jkotas commented Apr 12, 2026

Uh oh!

danmoseley commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

danmoseley commented Apr 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

danmoseley commented Apr 12, 2026•
edited
Loading

danmoseley commented Apr 12, 2026•
edited
Loading

danmoseley commented Apr 12, 2026•
edited
Loading

danmoseley commented Apr 12, 2026•
edited
Loading