Fix UnixConsoleStream regression when stdin/stdout is redirected to a seekable file by Copilot · Pull Request #126844 · dotnet/runtime

Copilot · 2026-04-13T17:27:06Z

Reverts all System.Console source changes from PR #125512 (which introduced RandomAccess.Read/Write based I/O) back to the original Interop.Sys.Read/Write implementation. The FileStream-based approach will be revisited separately.

Adds regression tests that verify Console.OpenStandardInput().CopyTo() and Console.OpenStandardOutput().Write() work correctly when stdin/stdout is redirected to a seekable file.

Description

Reverted ConsolePal.Unix.ConsoleStream.cs to use ConsolePal.Read() with Interop.Sys.Read
Reverted ConsolePal.Unix.cs to use Interop.Sys.Write with the full write loop (EPIPE, EAGAIN handling) and pointer-based UpdatedCachedCursorPosition
Reverted ConsolePal.Wasi.cs to use Interop.Sys.Read/Write directly
Restored Interop.Poll.cs, Interop.Read.cs, Interop.Write.cs references in System.Console.csproj for both WASI and Unix targets
Restored PR Support the FORCE_COLOR emerging standard in ConsoleUtils.EmitAnsiColorCodes #124492's FORCE_COLOR comment in ConsolePal.Unix.cs that was accidentally reverted along with PR Relax RandomAccess type requirements: make Read/Write methods work with non-seekable files #125512 changes
Added ConsoleHandles.cs to System.Console.Tests.csproj (was previously missing)
Added CanCopyStandardInputToStandardOutput test — verifies reading from seekable stdin via CopyTo
Added UnixConsoleStream_SeekableStdoutRedirection_WritesAllContent test — verifies writing to seekable stdout using two separate Write calls to ensure content is concatenated (not overwritten from offset 0), which properly covers the offset-based write regression

dotnet-policy-service · 2026-04-13T17:43:16Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

RandomAccess.Read/Write use pread/pwrite syscalls which always operate at a specified fileOffset. Passing fileOffset:0 for seekable files (e.g., regular files redirected as stdin/stdout) caused reads/writes to always operate at position 0, resulting in infinite loops or incorrect output. The fix creates a FileStream (with bufferSize:0) wrapping the handle when the handle is seekable. FileStream uses OSFileStreamStrategy which tracks the file position and advances it after each read/write, ensuring correct sequential behavior for seekable files. For non-seekable files (pipes, terminals), the existing RandomAccess-based path is used, preserving cursor position tracking for terminals. Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0df60225-7783-4496-abcf-9917387f56e5 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

…g duplication - Replace 'float for GC' FileStream approach with explicit _useFileStreamForIo bool field; FileStream is always held and disposed deterministically - Fix string duplication in stdout test by passing outputContent as RemoteExecutor arg - Add try/catch around File.Delete in finally blocks Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0df60225-7783-4496-abcf-9917387f56e5 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik

@copilot please address my feedback

…onsoleStream, simplify tests - Remove _useFileStreamForIo field and extra comments; always use FileStream for I/O - Change Write() in UnixConsoleStream to call WriteFromConsoleStream(_fileStream, buffer) - Update WriteFromConsoleStream in ConsolePal.Unix.cs and ConsolePal.Wasi.cs to accept FileStream instead of SafeFileHandle; use fs.Write(buffer) which handles both seekable and non-seekable files correctly - Rename SeekableStdinRedirection test to CanCopyStandardInputToStandardOutput and run on all non-mobile platforms (not just AnyUnix); simplify via RemoteInvokeOptions.StartInfo - Simplify SeekableStdoutRedirection test similarly; remove boilerplate try/catch Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/67a83dee-25ae-47d1-ae0f-b4aa1f18265f Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Copilot · 2026-04-14T06:53:15Z

@copilot please address my feedback

Done in adb2b69. All review feedback addressed:

Removed _useFileStreamForIo and extra comments; FileStream is always used for all I/O (handles both seekable and non-seekable correctly)
Write() in UnixConsoleStream now calls WriteFromConsoleStream(_fileStream, buffer)
WriteFromConsoleStream in both ConsolePal.Unix.cs and ConsolePal.Wasi.cs updated to accept FileStream and call fs.Write(buffer)
Tests renamed/simplified and now run on all non-mobile platforms

adamsitnik

@copilot address my feedback

- Fix XML comment in ConsolePal.Wasi.cs Write(FileStream): fd → fs - Remove _handle field from UnixConsoleStream; FileStream owns handle lifetime - Remove Flush() override from UnixConsoleStream (base is a nop; bufferSize:0) - Remove redundant [PlatformSpecific] from two new tests (RemoteExecutor handles it) - Dispose stdoutHandle before WaitForExit so File.ReadAllText can open the file Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ba3bd32e-023a-4160-bf27-f0ae05027d8d Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik · 2026-04-19T20:21:40Z

@jozkee @jkotas @stephentoub I would appreciate your review, as I would like to start a longer leave knowing that I leave no known bugs opened.

For context please refer to #126843

This PR is more or less a revert + tests that are going to ensure we are not going to introduce this bug again.

Copilot

Pull request overview

This PR reverts recent System.Console Unix/WASI I/O changes that used RandomAccess.Read/Write back to the prior Interop.Sys.Read/Write implementation, and adds regression tests for redirected stdin/stdout to seekable files (to prevent hangs/incorrect output).

Changes:

Restore Interop.Sys.Read / Interop.Sys.Write-based console stream I/O on Unix and WASI (including the write loop with EPIPE/EAGAIN handling).
Add/enable regression tests covering seekable stdin and seekable stdout redirection scenarios.
Restore needed interop source inclusions in System.Console.csproj and include ConsoleHandles.cs in the test project.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/libraries/System.Console/tests/System.Console.Tests.csproj	Includes `ConsoleHandles.cs` in the test build.
src/libraries/System.Console/tests/ConsoleHandles.cs	Adds regression tests for seekable stdin/stdout redirection.
src/libraries/System.Console/src/System/ConsolePal.Wasi.cs	Restores `Interop.Sys.Read/Write` + write-loop behavior for WASI.
src/libraries/System.Console/src/System/ConsolePal.Unix.cs	Restores `Interop.Sys.Read/Write` + write-loop behavior and cursor-cache updates.
src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.cs	Switches console stream reads back to `ConsolePal.Read` (Interop-based).
src/libraries/System.Console/src/System.Console.csproj	Re-adds interop source files (Poll/Read/Write) for Unix/WASI builds.

…ression Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/8c4bae7d-c5a8-4e7d-9567-c22ad8c8ff76 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ee38cb6a-7c51-4290-b71e-c815838eb480 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik · 2026-04-30T08:18:14Z

/backport to release/11.0-preview4

github-actions · 2026-04-30T08:18:24Z

Started backporting to release/11.0-preview4 (link to workflow run)

github-actions · 2026-04-30T08:20:30Z

@adamsitnik backporting to release/11.0-preview4 failed, the patch most likely resulted in conflicts. Please backport manually!

git am output

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchCreating an empty commit: Initial planApplying: Fix UnixConsoleStream to handle seekable files correctlyUsing index info to reconstruct a base tree...M	src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csM	src/libraries/System.Console/tests/ConsoleHandles.csM	src/libraries/System.Console/tests/System.Console.Tests.csprojFalling back to patching base and 3-way merge...Auto-merging src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csCONFLICT (content): Merge conflict in src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csAuto-merging src/libraries/System.Console/tests/ConsoleHandles.csCONFLICT (content): Merge conflict in src/libraries/System.Console/tests/ConsoleHandles.cserror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0002 Fix UnixConsoleStream to handle seekable files correctlyError: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

adamsitnik · 2026-04-30T09:00:01Z

I am stupid, it was merged before P4 snap so it's already there...

Copilot · 2026-04-13T17:27:06Z

Reverts all System.Console source changes from PR #125512 (which introduced RandomAccess.Read/Write based I/O) back to the original Interop.Sys.Read/Write implementation. The FileStream-based approach will be revisited separately.

Adds regression tests that verify Console.OpenStandardInput().CopyTo() and Console.OpenStandardOutput().Write() work correctly when stdin/stdout is redirected to a seekable file.

Description

Reverted ConsolePal.Unix.ConsoleStream.cs to use ConsolePal.Read() with Interop.Sys.Read
Reverted ConsolePal.Unix.cs to use Interop.Sys.Write with the full write loop (EPIPE, EAGAIN handling) and pointer-based UpdatedCachedCursorPosition
Reverted ConsolePal.Wasi.cs to use Interop.Sys.Read/Write directly
Restored Interop.Poll.cs, Interop.Read.cs, Interop.Write.cs references in System.Console.csproj for both WASI and Unix targets
Restored PR Support the FORCE_COLOR emerging standard in ConsoleUtils.EmitAnsiColorCodes #124492's FORCE_COLOR comment in ConsolePal.Unix.cs that was accidentally reverted along with PR Relax RandomAccess type requirements: make Read/Write methods work with non-seekable files #125512 changes
Added ConsoleHandles.cs to System.Console.Tests.csproj (was previously missing)
Added CanCopyStandardInputToStandardOutput test — verifies reading from seekable stdin via CopyTo
Added UnixConsoleStream_SeekableStdoutRedirection_WritesAllContent test — verifies writing to seekable stdout using two separate Write calls to ensure content is concatenated (not overwritten from offset 0), which properly covers the offset-based write regression

dotnet-policy-service · 2026-04-13T17:43:16Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

RandomAccess.Read/Write use pread/pwrite syscalls which always operate at a specified fileOffset. Passing fileOffset:0 for seekable files (e.g., regular files redirected as stdin/stdout) caused reads/writes to always operate at position 0, resulting in infinite loops or incorrect output. The fix creates a FileStream (with bufferSize:0) wrapping the handle when the handle is seekable. FileStream uses OSFileStreamStrategy which tracks the file position and advances it after each read/write, ensuring correct sequential behavior for seekable files. For non-seekable files (pipes, terminals), the existing RandomAccess-based path is used, preserving cursor position tracking for terminals. Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0df60225-7783-4496-abcf-9917387f56e5 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

…g duplication - Replace 'float for GC' FileStream approach with explicit _useFileStreamForIo bool field; FileStream is always held and disposed deterministically - Fix string duplication in stdout test by passing outputContent as RemoteExecutor arg - Add try/catch around File.Delete in finally blocks Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0df60225-7783-4496-abcf-9917387f56e5 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik

@copilot please address my feedback

…onsoleStream, simplify tests - Remove _useFileStreamForIo field and extra comments; always use FileStream for I/O - Change Write() in UnixConsoleStream to call WriteFromConsoleStream(_fileStream, buffer) - Update WriteFromConsoleStream in ConsolePal.Unix.cs and ConsolePal.Wasi.cs to accept FileStream instead of SafeFileHandle; use fs.Write(buffer) which handles both seekable and non-seekable files correctly - Rename SeekableStdinRedirection test to CanCopyStandardInputToStandardOutput and run on all non-mobile platforms (not just AnyUnix); simplify via RemoteInvokeOptions.StartInfo - Simplify SeekableStdoutRedirection test similarly; remove boilerplate try/catch Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/67a83dee-25ae-47d1-ae0f-b4aa1f18265f Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Copilot · 2026-04-14T06:53:15Z

@copilot please address my feedback

Done in adb2b69. All review feedback addressed:

Removed _useFileStreamForIo and extra comments; FileStream is always used for all I/O (handles both seekable and non-seekable correctly)
Write() in UnixConsoleStream now calls WriteFromConsoleStream(_fileStream, buffer)
WriteFromConsoleStream in both ConsolePal.Unix.cs and ConsolePal.Wasi.cs updated to accept FileStream and call fs.Write(buffer)
Tests renamed/simplified and now run on all non-mobile platforms

adamsitnik

@copilot address my feedback

- Fix XML comment in ConsolePal.Wasi.cs Write(FileStream): fd → fs - Remove _handle field from UnixConsoleStream; FileStream owns handle lifetime - Remove Flush() override from UnixConsoleStream (base is a nop; bufferSize:0) - Remove redundant [PlatformSpecific] from two new tests (RemoteExecutor handles it) - Dispose stdoutHandle before WaitForExit so File.ReadAllText can open the file Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ba3bd32e-023a-4160-bf27-f0ae05027d8d Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik · 2026-04-19T20:21:40Z

@jozkee @jkotas @stephentoub I would appreciate your review, as I would like to start a longer leave knowing that I leave no known bugs opened.

For context please refer to #126843

This PR is more or less a revert + tests that are going to ensure we are not going to introduce this bug again.

Copilot

Pull request overview

This PR reverts recent System.Console Unix/WASI I/O changes that used RandomAccess.Read/Write back to the prior Interop.Sys.Read/Write implementation, and adds regression tests for redirected stdin/stdout to seekable files (to prevent hangs/incorrect output).

Changes:

Restore Interop.Sys.Read / Interop.Sys.Write-based console stream I/O on Unix and WASI (including the write loop with EPIPE/EAGAIN handling).
Add/enable regression tests covering seekable stdin and seekable stdout redirection scenarios.
Restore needed interop source inclusions in System.Console.csproj and include ConsoleHandles.cs in the test project.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/libraries/System.Console/tests/System.Console.Tests.csproj	Includes `ConsoleHandles.cs` in the test build.
src/libraries/System.Console/tests/ConsoleHandles.cs	Adds regression tests for seekable stdin/stdout redirection.
src/libraries/System.Console/src/System/ConsolePal.Wasi.cs	Restores `Interop.Sys.Read/Write` + write-loop behavior for WASI.
src/libraries/System.Console/src/System/ConsolePal.Unix.cs	Restores `Interop.Sys.Read/Write` + write-loop behavior and cursor-cache updates.
src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.cs	Switches console stream reads back to `ConsolePal.Read` (Interop-based).
src/libraries/System.Console/src/System.Console.csproj	Re-adds interop source files (Poll/Read/Write) for Unix/WASI builds.

…ression Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/8c4bae7d-c5a8-4e7d-9567-c22ad8c8ff76 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ee38cb6a-7c51-4290-b71e-c815838eb480 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik · 2026-04-30T08:18:14Z

/backport to release/11.0-preview4

github-actions · 2026-04-30T08:18:24Z

Started backporting to release/11.0-preview4 (link to workflow run)

github-actions · 2026-04-30T08:20:30Z

@adamsitnik backporting to release/11.0-preview4 failed, the patch most likely resulted in conflicts. Please backport manually!

git am output

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchCreating an empty commit: Initial planApplying: Fix UnixConsoleStream to handle seekable files correctlyUsing index info to reconstruct a base tree...M	src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csM	src/libraries/System.Console/tests/ConsoleHandles.csM	src/libraries/System.Console/tests/System.Console.Tests.csprojFalling back to patching base and 3-way merge...Auto-merging src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csCONFLICT (content): Merge conflict in src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csAuto-merging src/libraries/System.Console/tests/ConsoleHandles.csCONFLICT (content): Merge conflict in src/libraries/System.Console/tests/ConsoleHandles.cserror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0002 Fix UnixConsoleStream to handle seekable files correctlyError: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

adamsitnik · 2026-04-30T09:00:01Z

I am stupid, it was merged before P4 snap so it's already there...

Copilot · 2026-04-13T17:27:06Z

Reverts all System.Console source changes from PR #125512 (which introduced RandomAccess.Read/Write based I/O) back to the original Interop.Sys.Read/Write implementation. The FileStream-based approach will be revisited separately.

Adds regression tests that verify Console.OpenStandardInput().CopyTo() and Console.OpenStandardOutput().Write() work correctly when stdin/stdout is redirected to a seekable file.

Description

Reverted ConsolePal.Unix.ConsoleStream.cs to use ConsolePal.Read() with Interop.Sys.Read
Reverted ConsolePal.Unix.cs to use Interop.Sys.Write with the full write loop (EPIPE, EAGAIN handling) and pointer-based UpdatedCachedCursorPosition
Reverted ConsolePal.Wasi.cs to use Interop.Sys.Read/Write directly
Restored Interop.Poll.cs, Interop.Read.cs, Interop.Write.cs references in System.Console.csproj for both WASI and Unix targets
Restored PR Support the FORCE_COLOR emerging standard in ConsoleUtils.EmitAnsiColorCodes #124492's FORCE_COLOR comment in ConsolePal.Unix.cs that was accidentally reverted along with PR Relax RandomAccess type requirements: make Read/Write methods work with non-seekable files #125512 changes
Added ConsoleHandles.cs to System.Console.Tests.csproj (was previously missing)
Added CanCopyStandardInputToStandardOutput test — verifies reading from seekable stdin via CopyTo
Added UnixConsoleStream_SeekableStdoutRedirection_WritesAllContent test — verifies writing to seekable stdout using two separate Write calls to ensure content is concatenated (not overwritten from offset 0), which properly covers the offset-based write regression

dotnet-policy-service · 2026-04-13T17:43:16Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

RandomAccess.Read/Write use pread/pwrite syscalls which always operate at a specified fileOffset. Passing fileOffset:0 for seekable files (e.g., regular files redirected as stdin/stdout) caused reads/writes to always operate at position 0, resulting in infinite loops or incorrect output. The fix creates a FileStream (with bufferSize:0) wrapping the handle when the handle is seekable. FileStream uses OSFileStreamStrategy which tracks the file position and advances it after each read/write, ensuring correct sequential behavior for seekable files. For non-seekable files (pipes, terminals), the existing RandomAccess-based path is used, preserving cursor position tracking for terminals. Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0df60225-7783-4496-abcf-9917387f56e5 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

…g duplication - Replace 'float for GC' FileStream approach with explicit _useFileStreamForIo bool field; FileStream is always held and disposed deterministically - Fix string duplication in stdout test by passing outputContent as RemoteExecutor arg - Add try/catch around File.Delete in finally blocks Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0df60225-7783-4496-abcf-9917387f56e5 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik

@copilot please address my feedback

…onsoleStream, simplify tests - Remove _useFileStreamForIo field and extra comments; always use FileStream for I/O - Change Write() in UnixConsoleStream to call WriteFromConsoleStream(_fileStream, buffer) - Update WriteFromConsoleStream in ConsolePal.Unix.cs and ConsolePal.Wasi.cs to accept FileStream instead of SafeFileHandle; use fs.Write(buffer) which handles both seekable and non-seekable files correctly - Rename SeekableStdinRedirection test to CanCopyStandardInputToStandardOutput and run on all non-mobile platforms (not just AnyUnix); simplify via RemoteInvokeOptions.StartInfo - Simplify SeekableStdoutRedirection test similarly; remove boilerplate try/catch Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/67a83dee-25ae-47d1-ae0f-b4aa1f18265f Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Copilot · 2026-04-14T06:53:15Z

@copilot please address my feedback

Done in adb2b69. All review feedback addressed:

Removed _useFileStreamForIo and extra comments; FileStream is always used for all I/O (handles both seekable and non-seekable correctly)
Write() in UnixConsoleStream now calls WriteFromConsoleStream(_fileStream, buffer)
WriteFromConsoleStream in both ConsolePal.Unix.cs and ConsolePal.Wasi.cs updated to accept FileStream and call fs.Write(buffer)
Tests renamed/simplified and now run on all non-mobile platforms

adamsitnik

@copilot address my feedback

- Fix XML comment in ConsolePal.Wasi.cs Write(FileStream): fd → fs - Remove _handle field from UnixConsoleStream; FileStream owns handle lifetime - Remove Flush() override from UnixConsoleStream (base is a nop; bufferSize:0) - Remove redundant [PlatformSpecific] from two new tests (RemoteExecutor handles it) - Dispose stdoutHandle before WaitForExit so File.ReadAllText can open the file Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ba3bd32e-023a-4160-bf27-f0ae05027d8d Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik · 2026-04-19T20:21:40Z

@jozkee @jkotas @stephentoub I would appreciate your review, as I would like to start a longer leave knowing that I leave no known bugs opened.

For context please refer to #126843

This PR is more or less a revert + tests that are going to ensure we are not going to introduce this bug again.

Copilot

Pull request overview

This PR reverts recent System.Console Unix/WASI I/O changes that used RandomAccess.Read/Write back to the prior Interop.Sys.Read/Write implementation, and adds regression tests for redirected stdin/stdout to seekable files (to prevent hangs/incorrect output).

Changes:

Restore Interop.Sys.Read / Interop.Sys.Write-based console stream I/O on Unix and WASI (including the write loop with EPIPE/EAGAIN handling).
Add/enable regression tests covering seekable stdin and seekable stdout redirection scenarios.
Restore needed interop source inclusions in System.Console.csproj and include ConsoleHandles.cs in the test project.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/libraries/System.Console/tests/System.Console.Tests.csproj	Includes `ConsoleHandles.cs` in the test build.
src/libraries/System.Console/tests/ConsoleHandles.cs	Adds regression tests for seekable stdin/stdout redirection.
src/libraries/System.Console/src/System/ConsolePal.Wasi.cs	Restores `Interop.Sys.Read/Write` + write-loop behavior for WASI.
src/libraries/System.Console/src/System/ConsolePal.Unix.cs	Restores `Interop.Sys.Read/Write` + write-loop behavior and cursor-cache updates.
src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.cs	Switches console stream reads back to `ConsolePal.Read` (Interop-based).
src/libraries/System.Console/src/System.Console.csproj	Re-adds interop source files (Poll/Read/Write) for Unix/WASI builds.

…ression Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/8c4bae7d-c5a8-4e7d-9567-c22ad8c8ff76 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ee38cb6a-7c51-4290-b71e-c815838eb480 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik · 2026-04-30T08:18:14Z

/backport to release/11.0-preview4

github-actions · 2026-04-30T08:18:24Z

Started backporting to release/11.0-preview4 (link to workflow run)

github-actions · 2026-04-30T08:20:30Z

@adamsitnik backporting to release/11.0-preview4 failed, the patch most likely resulted in conflicts. Please backport manually!

git am output

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchCreating an empty commit: Initial planApplying: Fix UnixConsoleStream to handle seekable files correctlyUsing index info to reconstruct a base tree...M	src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csM	src/libraries/System.Console/tests/ConsoleHandles.csM	src/libraries/System.Console/tests/System.Console.Tests.csprojFalling back to patching base and 3-way merge...Auto-merging src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csCONFLICT (content): Merge conflict in src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csAuto-merging src/libraries/System.Console/tests/ConsoleHandles.csCONFLICT (content): Merge conflict in src/libraries/System.Console/tests/ConsoleHandles.cserror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0002 Fix UnixConsoleStream to handle seekable files correctlyError: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

adamsitnik · 2026-04-30T09:00:01Z

I am stupid, it was merged before P4 snap so it's already there...

Copilot · 2026-04-13T17:27:06Z

Reverts all System.Console source changes from PR #125512 (which introduced RandomAccess.Read/Write based I/O) back to the original Interop.Sys.Read/Write implementation. The FileStream-based approach will be revisited separately.

Adds regression tests that verify Console.OpenStandardInput().CopyTo() and Console.OpenStandardOutput().Write() work correctly when stdin/stdout is redirected to a seekable file.

Description

Reverted ConsolePal.Unix.ConsoleStream.cs to use ConsolePal.Read() with Interop.Sys.Read
Reverted ConsolePal.Unix.cs to use Interop.Sys.Write with the full write loop (EPIPE, EAGAIN handling) and pointer-based UpdatedCachedCursorPosition
Reverted ConsolePal.Wasi.cs to use Interop.Sys.Read/Write directly
Restored Interop.Poll.cs, Interop.Read.cs, Interop.Write.cs references in System.Console.csproj for both WASI and Unix targets
Restored PR Support the FORCE_COLOR emerging standard in ConsoleUtils.EmitAnsiColorCodes #124492's FORCE_COLOR comment in ConsolePal.Unix.cs that was accidentally reverted along with PR Relax RandomAccess type requirements: make Read/Write methods work with non-seekable files #125512 changes
Added ConsoleHandles.cs to System.Console.Tests.csproj (was previously missing)
Added CanCopyStandardInputToStandardOutput test — verifies reading from seekable stdin via CopyTo
Added UnixConsoleStream_SeekableStdoutRedirection_WritesAllContent test — verifies writing to seekable stdout using two separate Write calls to ensure content is concatenated (not overwritten from offset 0), which properly covers the offset-based write regression

dotnet-policy-service · 2026-04-13T17:43:16Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

RandomAccess.Read/Write use pread/pwrite syscalls which always operate at a specified fileOffset. Passing fileOffset:0 for seekable files (e.g., regular files redirected as stdin/stdout) caused reads/writes to always operate at position 0, resulting in infinite loops or incorrect output. The fix creates a FileStream (with bufferSize:0) wrapping the handle when the handle is seekable. FileStream uses OSFileStreamStrategy which tracks the file position and advances it after each read/write, ensuring correct sequential behavior for seekable files. For non-seekable files (pipes, terminals), the existing RandomAccess-based path is used, preserving cursor position tracking for terminals. Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0df60225-7783-4496-abcf-9917387f56e5 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

…g duplication - Replace 'float for GC' FileStream approach with explicit _useFileStreamForIo bool field; FileStream is always held and disposed deterministically - Fix string duplication in stdout test by passing outputContent as RemoteExecutor arg - Add try/catch around File.Delete in finally blocks Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0df60225-7783-4496-abcf-9917387f56e5 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik

@copilot please address my feedback

…onsoleStream, simplify tests - Remove _useFileStreamForIo field and extra comments; always use FileStream for I/O - Change Write() in UnixConsoleStream to call WriteFromConsoleStream(_fileStream, buffer) - Update WriteFromConsoleStream in ConsolePal.Unix.cs and ConsolePal.Wasi.cs to accept FileStream instead of SafeFileHandle; use fs.Write(buffer) which handles both seekable and non-seekable files correctly - Rename SeekableStdinRedirection test to CanCopyStandardInputToStandardOutput and run on all non-mobile platforms (not just AnyUnix); simplify via RemoteInvokeOptions.StartInfo - Simplify SeekableStdoutRedirection test similarly; remove boilerplate try/catch Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/67a83dee-25ae-47d1-ae0f-b4aa1f18265f Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Copilot · 2026-04-14T06:53:15Z

@copilot please address my feedback

Done in adb2b69. All review feedback addressed:

Removed _useFileStreamForIo and extra comments; FileStream is always used for all I/O (handles both seekable and non-seekable correctly)
Write() in UnixConsoleStream now calls WriteFromConsoleStream(_fileStream, buffer)
WriteFromConsoleStream in both ConsolePal.Unix.cs and ConsolePal.Wasi.cs updated to accept FileStream and call fs.Write(buffer)
Tests renamed/simplified and now run on all non-mobile platforms

adamsitnik

@copilot address my feedback

- Fix XML comment in ConsolePal.Wasi.cs Write(FileStream): fd → fs - Remove _handle field from UnixConsoleStream; FileStream owns handle lifetime - Remove Flush() override from UnixConsoleStream (base is a nop; bufferSize:0) - Remove redundant [PlatformSpecific] from two new tests (RemoteExecutor handles it) - Dispose stdoutHandle before WaitForExit so File.ReadAllText can open the file Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ba3bd32e-023a-4160-bf27-f0ae05027d8d Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik · 2026-04-19T20:21:40Z

@jozkee @jkotas @stephentoub I would appreciate your review, as I would like to start a longer leave knowing that I leave no known bugs opened.

For context please refer to #126843

This PR is more or less a revert + tests that are going to ensure we are not going to introduce this bug again.

Copilot

Pull request overview

This PR reverts recent System.Console Unix/WASI I/O changes that used RandomAccess.Read/Write back to the prior Interop.Sys.Read/Write implementation, and adds regression tests for redirected stdin/stdout to seekable files (to prevent hangs/incorrect output).

Changes:

Restore Interop.Sys.Read / Interop.Sys.Write-based console stream I/O on Unix and WASI (including the write loop with EPIPE/EAGAIN handling).
Add/enable regression tests covering seekable stdin and seekable stdout redirection scenarios.
Restore needed interop source inclusions in System.Console.csproj and include ConsoleHandles.cs in the test project.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/libraries/System.Console/tests/System.Console.Tests.csproj	Includes `ConsoleHandles.cs` in the test build.
src/libraries/System.Console/tests/ConsoleHandles.cs	Adds regression tests for seekable stdin/stdout redirection.
src/libraries/System.Console/src/System/ConsolePal.Wasi.cs	Restores `Interop.Sys.Read/Write` + write-loop behavior for WASI.
src/libraries/System.Console/src/System/ConsolePal.Unix.cs	Restores `Interop.Sys.Read/Write` + write-loop behavior and cursor-cache updates.
src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.cs	Switches console stream reads back to `ConsolePal.Read` (Interop-based).
src/libraries/System.Console/src/System.Console.csproj	Re-adds interop source files (Poll/Read/Write) for Unix/WASI builds.

…ression Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/8c4bae7d-c5a8-4e7d-9567-c22ad8c8ff76 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ee38cb6a-7c51-4290-b71e-c815838eb480 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik · 2026-04-30T08:18:14Z

/backport to release/11.0-preview4

github-actions · 2026-04-30T08:18:24Z

Started backporting to release/11.0-preview4 (link to workflow run)

github-actions · 2026-04-30T08:20:30Z

@adamsitnik backporting to release/11.0-preview4 failed, the patch most likely resulted in conflicts. Please backport manually!

git am output

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchCreating an empty commit: Initial planApplying: Fix UnixConsoleStream to handle seekable files correctlyUsing index info to reconstruct a base tree...M	src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csM	src/libraries/System.Console/tests/ConsoleHandles.csM	src/libraries/System.Console/tests/System.Console.Tests.csprojFalling back to patching base and 3-way merge...Auto-merging src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csCONFLICT (content): Merge conflict in src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csAuto-merging src/libraries/System.Console/tests/ConsoleHandles.csCONFLICT (content): Merge conflict in src/libraries/System.Console/tests/ConsoleHandles.cserror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0002 Fix UnixConsoleStream to handle seekable files correctlyError: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

adamsitnik · 2026-04-30T09:00:01Z

I am stupid, it was merged before P4 snap so it's already there...

Copilot · 2026-04-13T17:27:06Z

Reverts all System.Console source changes from PR #125512 (which introduced RandomAccess.Read/Write based I/O) back to the original Interop.Sys.Read/Write implementation. The FileStream-based approach will be revisited separately.

Adds regression tests that verify Console.OpenStandardInput().CopyTo() and Console.OpenStandardOutput().Write() work correctly when stdin/stdout is redirected to a seekable file.

Description

Reverted ConsolePal.Unix.ConsoleStream.cs to use ConsolePal.Read() with Interop.Sys.Read
Reverted ConsolePal.Unix.cs to use Interop.Sys.Write with the full write loop (EPIPE, EAGAIN handling) and pointer-based UpdatedCachedCursorPosition
Reverted ConsolePal.Wasi.cs to use Interop.Sys.Read/Write directly
Restored Interop.Poll.cs, Interop.Read.cs, Interop.Write.cs references in System.Console.csproj for both WASI and Unix targets
Restored PR Support the FORCE_COLOR emerging standard in ConsoleUtils.EmitAnsiColorCodes #124492's FORCE_COLOR comment in ConsolePal.Unix.cs that was accidentally reverted along with PR Relax RandomAccess type requirements: make Read/Write methods work with non-seekable files #125512 changes
Added ConsoleHandles.cs to System.Console.Tests.csproj (was previously missing)
Added CanCopyStandardInputToStandardOutput test — verifies reading from seekable stdin via CopyTo
Added UnixConsoleStream_SeekableStdoutRedirection_WritesAllContent test — verifies writing to seekable stdout using two separate Write calls to ensure content is concatenated (not overwritten from offset 0), which properly covers the offset-based write regression

dotnet-policy-service · 2026-04-13T17:43:16Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

RandomAccess.Read/Write use pread/pwrite syscalls which always operate at a specified fileOffset. Passing fileOffset:0 for seekable files (e.g., regular files redirected as stdin/stdout) caused reads/writes to always operate at position 0, resulting in infinite loops or incorrect output. The fix creates a FileStream (with bufferSize:0) wrapping the handle when the handle is seekable. FileStream uses OSFileStreamStrategy which tracks the file position and advances it after each read/write, ensuring correct sequential behavior for seekable files. For non-seekable files (pipes, terminals), the existing RandomAccess-based path is used, preserving cursor position tracking for terminals. Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0df60225-7783-4496-abcf-9917387f56e5 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

…g duplication - Replace 'float for GC' FileStream approach with explicit _useFileStreamForIo bool field; FileStream is always held and disposed deterministically - Fix string duplication in stdout test by passing outputContent as RemoteExecutor arg - Add try/catch around File.Delete in finally blocks Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0df60225-7783-4496-abcf-9917387f56e5 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik

@copilot please address my feedback

…onsoleStream, simplify tests - Remove _useFileStreamForIo field and extra comments; always use FileStream for I/O - Change Write() in UnixConsoleStream to call WriteFromConsoleStream(_fileStream, buffer) - Update WriteFromConsoleStream in ConsolePal.Unix.cs and ConsolePal.Wasi.cs to accept FileStream instead of SafeFileHandle; use fs.Write(buffer) which handles both seekable and non-seekable files correctly - Rename SeekableStdinRedirection test to CanCopyStandardInputToStandardOutput and run on all non-mobile platforms (not just AnyUnix); simplify via RemoteInvokeOptions.StartInfo - Simplify SeekableStdoutRedirection test similarly; remove boilerplate try/catch Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/67a83dee-25ae-47d1-ae0f-b4aa1f18265f Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Copilot · 2026-04-14T06:53:15Z

@copilot please address my feedback

Done in adb2b69. All review feedback addressed:

Removed _useFileStreamForIo and extra comments; FileStream is always used for all I/O (handles both seekable and non-seekable correctly)
Write() in UnixConsoleStream now calls WriteFromConsoleStream(_fileStream, buffer)
WriteFromConsoleStream in both ConsolePal.Unix.cs and ConsolePal.Wasi.cs updated to accept FileStream and call fs.Write(buffer)
Tests renamed/simplified and now run on all non-mobile platforms

adamsitnik

@copilot address my feedback

- Fix XML comment in ConsolePal.Wasi.cs Write(FileStream): fd → fs - Remove _handle field from UnixConsoleStream; FileStream owns handle lifetime - Remove Flush() override from UnixConsoleStream (base is a nop; bufferSize:0) - Remove redundant [PlatformSpecific] from two new tests (RemoteExecutor handles it) - Dispose stdoutHandle before WaitForExit so File.ReadAllText can open the file Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ba3bd32e-023a-4160-bf27-f0ae05027d8d Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik · 2026-04-19T20:21:40Z

@jozkee @jkotas @stephentoub I would appreciate your review, as I would like to start a longer leave knowing that I leave no known bugs opened.

For context please refer to #126843

This PR is more or less a revert + tests that are going to ensure we are not going to introduce this bug again.

Copilot

Pull request overview

This PR reverts recent System.Console Unix/WASI I/O changes that used RandomAccess.Read/Write back to the prior Interop.Sys.Read/Write implementation, and adds regression tests for redirected stdin/stdout to seekable files (to prevent hangs/incorrect output).

Changes:

Restore Interop.Sys.Read / Interop.Sys.Write-based console stream I/O on Unix and WASI (including the write loop with EPIPE/EAGAIN handling).
Add/enable regression tests covering seekable stdin and seekable stdout redirection scenarios.
Restore needed interop source inclusions in System.Console.csproj and include ConsoleHandles.cs in the test project.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/libraries/System.Console/tests/System.Console.Tests.csproj	Includes `ConsoleHandles.cs` in the test build.
src/libraries/System.Console/tests/ConsoleHandles.cs	Adds regression tests for seekable stdin/stdout redirection.
src/libraries/System.Console/src/System/ConsolePal.Wasi.cs	Restores `Interop.Sys.Read/Write` + write-loop behavior for WASI.
src/libraries/System.Console/src/System/ConsolePal.Unix.cs	Restores `Interop.Sys.Read/Write` + write-loop behavior and cursor-cache updates.
src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.cs	Switches console stream reads back to `ConsolePal.Read` (Interop-based).
src/libraries/System.Console/src/System.Console.csproj	Re-adds interop source files (Poll/Read/Write) for Unix/WASI builds.

…ression Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/8c4bae7d-c5a8-4e7d-9567-c22ad8c8ff76 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ee38cb6a-7c51-4290-b71e-c815838eb480 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik · 2026-04-30T08:18:14Z

/backport to release/11.0-preview4

github-actions · 2026-04-30T08:18:24Z

Started backporting to release/11.0-preview4 (link to workflow run)

github-actions · 2026-04-30T08:20:30Z

@adamsitnik backporting to release/11.0-preview4 failed, the patch most likely resulted in conflicts. Please backport manually!

git am output

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchCreating an empty commit: Initial planApplying: Fix UnixConsoleStream to handle seekable files correctlyUsing index info to reconstruct a base tree...M	src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csM	src/libraries/System.Console/tests/ConsoleHandles.csM	src/libraries/System.Console/tests/System.Console.Tests.csprojFalling back to patching base and 3-way merge...Auto-merging src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csCONFLICT (content): Merge conflict in src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csAuto-merging src/libraries/System.Console/tests/ConsoleHandles.csCONFLICT (content): Merge conflict in src/libraries/System.Console/tests/ConsoleHandles.cserror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0002 Fix UnixConsoleStream to handle seekable files correctlyError: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

adamsitnik · 2026-04-30T09:00:01Z

I am stupid, it was merged before P4 snap so it's already there...

Copilot · 2026-04-13T17:27:06Z

Reverts all System.Console source changes from PR #125512 (which introduced RandomAccess.Read/Write based I/O) back to the original Interop.Sys.Read/Write implementation. The FileStream-based approach will be revisited separately.

Adds regression tests that verify Console.OpenStandardInput().CopyTo() and Console.OpenStandardOutput().Write() work correctly when stdin/stdout is redirected to a seekable file.

Description

Reverted ConsolePal.Unix.ConsoleStream.cs to use ConsolePal.Read() with Interop.Sys.Read
Reverted ConsolePal.Unix.cs to use Interop.Sys.Write with the full write loop (EPIPE, EAGAIN handling) and pointer-based UpdatedCachedCursorPosition
Reverted ConsolePal.Wasi.cs to use Interop.Sys.Read/Write directly
Restored Interop.Poll.cs, Interop.Read.cs, Interop.Write.cs references in System.Console.csproj for both WASI and Unix targets
Restored PR Support the FORCE_COLOR emerging standard in ConsoleUtils.EmitAnsiColorCodes #124492's FORCE_COLOR comment in ConsolePal.Unix.cs that was accidentally reverted along with PR Relax RandomAccess type requirements: make Read/Write methods work with non-seekable files #125512 changes
Added ConsoleHandles.cs to System.Console.Tests.csproj (was previously missing)
Added CanCopyStandardInputToStandardOutput test — verifies reading from seekable stdin via CopyTo
Added UnixConsoleStream_SeekableStdoutRedirection_WritesAllContent test — verifies writing to seekable stdout using two separate Write calls to ensure content is concatenated (not overwritten from offset 0), which properly covers the offset-based write regression

dotnet-policy-service · 2026-04-13T17:43:16Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

RandomAccess.Read/Write use pread/pwrite syscalls which always operate at a specified fileOffset. Passing fileOffset:0 for seekable files (e.g., regular files redirected as stdin/stdout) caused reads/writes to always operate at position 0, resulting in infinite loops or incorrect output. The fix creates a FileStream (with bufferSize:0) wrapping the handle when the handle is seekable. FileStream uses OSFileStreamStrategy which tracks the file position and advances it after each read/write, ensuring correct sequential behavior for seekable files. For non-seekable files (pipes, terminals), the existing RandomAccess-based path is used, preserving cursor position tracking for terminals. Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0df60225-7783-4496-abcf-9917387f56e5 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

…g duplication - Replace 'float for GC' FileStream approach with explicit _useFileStreamForIo bool field; FileStream is always held and disposed deterministically - Fix string duplication in stdout test by passing outputContent as RemoteExecutor arg - Add try/catch around File.Delete in finally blocks Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0df60225-7783-4496-abcf-9917387f56e5 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik

@copilot please address my feedback

…onsoleStream, simplify tests - Remove _useFileStreamForIo field and extra comments; always use FileStream for I/O - Change Write() in UnixConsoleStream to call WriteFromConsoleStream(_fileStream, buffer) - Update WriteFromConsoleStream in ConsolePal.Unix.cs and ConsolePal.Wasi.cs to accept FileStream instead of SafeFileHandle; use fs.Write(buffer) which handles both seekable and non-seekable files correctly - Rename SeekableStdinRedirection test to CanCopyStandardInputToStandardOutput and run on all non-mobile platforms (not just AnyUnix); simplify via RemoteInvokeOptions.StartInfo - Simplify SeekableStdoutRedirection test similarly; remove boilerplate try/catch Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/67a83dee-25ae-47d1-ae0f-b4aa1f18265f Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Copilot · 2026-04-14T06:53:15Z

@copilot please address my feedback

Done in adb2b69. All review feedback addressed:

Removed _useFileStreamForIo and extra comments; FileStream is always used for all I/O (handles both seekable and non-seekable correctly)
Write() in UnixConsoleStream now calls WriteFromConsoleStream(_fileStream, buffer)
WriteFromConsoleStream in both ConsolePal.Unix.cs and ConsolePal.Wasi.cs updated to accept FileStream and call fs.Write(buffer)
Tests renamed/simplified and now run on all non-mobile platforms

adamsitnik

@copilot address my feedback

- Fix XML comment in ConsolePal.Wasi.cs Write(FileStream): fd → fs - Remove _handle field from UnixConsoleStream; FileStream owns handle lifetime - Remove Flush() override from UnixConsoleStream (base is a nop; bufferSize:0) - Remove redundant [PlatformSpecific] from two new tests (RemoteExecutor handles it) - Dispose stdoutHandle before WaitForExit so File.ReadAllText can open the file Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ba3bd32e-023a-4160-bf27-f0ae05027d8d Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik · 2026-04-19T20:21:40Z

@jozkee @jkotas @stephentoub I would appreciate your review, as I would like to start a longer leave knowing that I leave no known bugs opened.

For context please refer to #126843

This PR is more or less a revert + tests that are going to ensure we are not going to introduce this bug again.

Copilot

Pull request overview

This PR reverts recent System.Console Unix/WASI I/O changes that used RandomAccess.Read/Write back to the prior Interop.Sys.Read/Write implementation, and adds regression tests for redirected stdin/stdout to seekable files (to prevent hangs/incorrect output).

Changes:

Restore Interop.Sys.Read / Interop.Sys.Write-based console stream I/O on Unix and WASI (including the write loop with EPIPE/EAGAIN handling).
Add/enable regression tests covering seekable stdin and seekable stdout redirection scenarios.
Restore needed interop source inclusions in System.Console.csproj and include ConsoleHandles.cs in the test project.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/libraries/System.Console/tests/System.Console.Tests.csproj	Includes `ConsoleHandles.cs` in the test build.
src/libraries/System.Console/tests/ConsoleHandles.cs	Adds regression tests for seekable stdin/stdout redirection.
src/libraries/System.Console/src/System/ConsolePal.Wasi.cs	Restores `Interop.Sys.Read/Write` + write-loop behavior for WASI.
src/libraries/System.Console/src/System/ConsolePal.Unix.cs	Restores `Interop.Sys.Read/Write` + write-loop behavior and cursor-cache updates.
src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.cs	Switches console stream reads back to `ConsolePal.Read` (Interop-based).
src/libraries/System.Console/src/System.Console.csproj	Re-adds interop source files (Poll/Read/Write) for Unix/WASI builds.

…ression Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/8c4bae7d-c5a8-4e7d-9567-c22ad8c8ff76 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ee38cb6a-7c51-4290-b71e-c815838eb480 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik · 2026-04-30T08:18:14Z

/backport to release/11.0-preview4

github-actions · 2026-04-30T08:18:24Z

Started backporting to release/11.0-preview4 (link to workflow run)

github-actions · 2026-04-30T08:20:30Z

@adamsitnik backporting to release/11.0-preview4 failed, the patch most likely resulted in conflicts. Please backport manually!

git am output

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchCreating an empty commit: Initial planApplying: Fix UnixConsoleStream to handle seekable files correctlyUsing index info to reconstruct a base tree...M	src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csM	src/libraries/System.Console/tests/ConsoleHandles.csM	src/libraries/System.Console/tests/System.Console.Tests.csprojFalling back to patching base and 3-way merge...Auto-merging src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csCONFLICT (content): Merge conflict in src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csAuto-merging src/libraries/System.Console/tests/ConsoleHandles.csCONFLICT (content): Merge conflict in src/libraries/System.Console/tests/ConsoleHandles.cserror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0002 Fix UnixConsoleStream to handle seekable files correctlyError: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

adamsitnik · 2026-04-30T09:00:01Z

I am stupid, it was merged before P4 snap so it's already there...

Copilot · 2026-04-13T17:27:06Z

Reverts all System.Console source changes from PR #125512 (which introduced RandomAccess.Read/Write based I/O) back to the original Interop.Sys.Read/Write implementation. The FileStream-based approach will be revisited separately.

Adds regression tests that verify Console.OpenStandardInput().CopyTo() and Console.OpenStandardOutput().Write() work correctly when stdin/stdout is redirected to a seekable file.

Description

Reverted ConsolePal.Unix.ConsoleStream.cs to use ConsolePal.Read() with Interop.Sys.Read
Reverted ConsolePal.Unix.cs to use Interop.Sys.Write with the full write loop (EPIPE, EAGAIN handling) and pointer-based UpdatedCachedCursorPosition
Reverted ConsolePal.Wasi.cs to use Interop.Sys.Read/Write directly
Restored Interop.Poll.cs, Interop.Read.cs, Interop.Write.cs references in System.Console.csproj for both WASI and Unix targets
Restored PR Support the FORCE_COLOR emerging standard in ConsoleUtils.EmitAnsiColorCodes #124492's FORCE_COLOR comment in ConsolePal.Unix.cs that was accidentally reverted along with PR Relax RandomAccess type requirements: make Read/Write methods work with non-seekable files #125512 changes
Added ConsoleHandles.cs to System.Console.Tests.csproj (was previously missing)
Added CanCopyStandardInputToStandardOutput test — verifies reading from seekable stdin via CopyTo
Added UnixConsoleStream_SeekableStdoutRedirection_WritesAllContent test — verifies writing to seekable stdout using two separate Write calls to ensure content is concatenated (not overwritten from offset 0), which properly covers the offset-based write regression

dotnet-policy-service · 2026-04-13T17:43:16Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

RandomAccess.Read/Write use pread/pwrite syscalls which always operate at a specified fileOffset. Passing fileOffset:0 for seekable files (e.g., regular files redirected as stdin/stdout) caused reads/writes to always operate at position 0, resulting in infinite loops or incorrect output. The fix creates a FileStream (with bufferSize:0) wrapping the handle when the handle is seekable. FileStream uses OSFileStreamStrategy which tracks the file position and advances it after each read/write, ensuring correct sequential behavior for seekable files. For non-seekable files (pipes, terminals), the existing RandomAccess-based path is used, preserving cursor position tracking for terminals. Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0df60225-7783-4496-abcf-9917387f56e5 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

…g duplication - Replace 'float for GC' FileStream approach with explicit _useFileStreamForIo bool field; FileStream is always held and disposed deterministically - Fix string duplication in stdout test by passing outputContent as RemoteExecutor arg - Add try/catch around File.Delete in finally blocks Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0df60225-7783-4496-abcf-9917387f56e5 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik

@copilot please address my feedback

…onsoleStream, simplify tests - Remove _useFileStreamForIo field and extra comments; always use FileStream for I/O - Change Write() in UnixConsoleStream to call WriteFromConsoleStream(_fileStream, buffer) - Update WriteFromConsoleStream in ConsolePal.Unix.cs and ConsolePal.Wasi.cs to accept FileStream instead of SafeFileHandle; use fs.Write(buffer) which handles both seekable and non-seekable files correctly - Rename SeekableStdinRedirection test to CanCopyStandardInputToStandardOutput and run on all non-mobile platforms (not just AnyUnix); simplify via RemoteInvokeOptions.StartInfo - Simplify SeekableStdoutRedirection test similarly; remove boilerplate try/catch Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/67a83dee-25ae-47d1-ae0f-b4aa1f18265f Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Copilot · 2026-04-14T06:53:15Z

@copilot please address my feedback

Done in adb2b69. All review feedback addressed:

Removed _useFileStreamForIo and extra comments; FileStream is always used for all I/O (handles both seekable and non-seekable correctly)
Write() in UnixConsoleStream now calls WriteFromConsoleStream(_fileStream, buffer)
WriteFromConsoleStream in both ConsolePal.Unix.cs and ConsolePal.Wasi.cs updated to accept FileStream and call fs.Write(buffer)
Tests renamed/simplified and now run on all non-mobile platforms

adamsitnik

@copilot address my feedback

- Fix XML comment in ConsolePal.Wasi.cs Write(FileStream): fd → fs - Remove _handle field from UnixConsoleStream; FileStream owns handle lifetime - Remove Flush() override from UnixConsoleStream (base is a nop; bufferSize:0) - Remove redundant [PlatformSpecific] from two new tests (RemoteExecutor handles it) - Dispose stdoutHandle before WaitForExit so File.ReadAllText can open the file Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ba3bd32e-023a-4160-bf27-f0ae05027d8d Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik · 2026-04-19T20:21:40Z

@jozkee @jkotas @stephentoub I would appreciate your review, as I would like to start a longer leave knowing that I leave no known bugs opened.

For context please refer to #126843

This PR is more or less a revert + tests that are going to ensure we are not going to introduce this bug again.

Copilot

Pull request overview

This PR reverts recent System.Console Unix/WASI I/O changes that used RandomAccess.Read/Write back to the prior Interop.Sys.Read/Write implementation, and adds regression tests for redirected stdin/stdout to seekable files (to prevent hangs/incorrect output).

Changes:

Restore Interop.Sys.Read / Interop.Sys.Write-based console stream I/O on Unix and WASI (including the write loop with EPIPE/EAGAIN handling).
Add/enable regression tests covering seekable stdin and seekable stdout redirection scenarios.
Restore needed interop source inclusions in System.Console.csproj and include ConsoleHandles.cs in the test project.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/libraries/System.Console/tests/System.Console.Tests.csproj	Includes `ConsoleHandles.cs` in the test build.
src/libraries/System.Console/tests/ConsoleHandles.cs	Adds regression tests for seekable stdin/stdout redirection.
src/libraries/System.Console/src/System/ConsolePal.Wasi.cs	Restores `Interop.Sys.Read/Write` + write-loop behavior for WASI.
src/libraries/System.Console/src/System/ConsolePal.Unix.cs	Restores `Interop.Sys.Read/Write` + write-loop behavior and cursor-cache updates.
src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.cs	Switches console stream reads back to `ConsolePal.Read` (Interop-based).
src/libraries/System.Console/src/System.Console.csproj	Re-adds interop source files (Poll/Read/Write) for Unix/WASI builds.

…ression Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/8c4bae7d-c5a8-4e7d-9567-c22ad8c8ff76 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ee38cb6a-7c51-4290-b71e-c815838eb480 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik · 2026-04-30T08:18:14Z

/backport to release/11.0-preview4

github-actions · 2026-04-30T08:18:24Z

Started backporting to release/11.0-preview4 (link to workflow run)

github-actions · 2026-04-30T08:20:30Z

@adamsitnik backporting to release/11.0-preview4 failed, the patch most likely resulted in conflicts. Please backport manually!

git am output

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchCreating an empty commit: Initial planApplying: Fix UnixConsoleStream to handle seekable files correctlyUsing index info to reconstruct a base tree...M	src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csM	src/libraries/System.Console/tests/ConsoleHandles.csM	src/libraries/System.Console/tests/System.Console.Tests.csprojFalling back to patching base and 3-way merge...Auto-merging src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csCONFLICT (content): Merge conflict in src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csAuto-merging src/libraries/System.Console/tests/ConsoleHandles.csCONFLICT (content): Merge conflict in src/libraries/System.Console/tests/ConsoleHandles.cserror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0002 Fix UnixConsoleStream to handle seekable files correctlyError: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

adamsitnik · 2026-04-30T09:00:01Z

I am stupid, it was merged before P4 snap so it's already there...

Copilot · 2026-04-13T17:27:06Z

Reverts all System.Console source changes from PR #125512 (which introduced RandomAccess.Read/Write based I/O) back to the original Interop.Sys.Read/Write implementation. The FileStream-based approach will be revisited separately.

Adds regression tests that verify Console.OpenStandardInput().CopyTo() and Console.OpenStandardOutput().Write() work correctly when stdin/stdout is redirected to a seekable file.

Description

Reverted ConsolePal.Unix.ConsoleStream.cs to use ConsolePal.Read() with Interop.Sys.Read
Reverted ConsolePal.Unix.cs to use Interop.Sys.Write with the full write loop (EPIPE, EAGAIN handling) and pointer-based UpdatedCachedCursorPosition
Reverted ConsolePal.Wasi.cs to use Interop.Sys.Read/Write directly
Restored Interop.Poll.cs, Interop.Read.cs, Interop.Write.cs references in System.Console.csproj for both WASI and Unix targets
Restored PR Support the FORCE_COLOR emerging standard in ConsoleUtils.EmitAnsiColorCodes #124492's FORCE_COLOR comment in ConsolePal.Unix.cs that was accidentally reverted along with PR Relax RandomAccess type requirements: make Read/Write methods work with non-seekable files #125512 changes
Added ConsoleHandles.cs to System.Console.Tests.csproj (was previously missing)
Added CanCopyStandardInputToStandardOutput test — verifies reading from seekable stdin via CopyTo
Added UnixConsoleStream_SeekableStdoutRedirection_WritesAllContent test — verifies writing to seekable stdout using two separate Write calls to ensure content is concatenated (not overwritten from offset 0), which properly covers the offset-based write regression

dotnet-policy-service · 2026-04-13T17:43:16Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

RandomAccess.Read/Write use pread/pwrite syscalls which always operate at a specified fileOffset. Passing fileOffset:0 for seekable files (e.g., regular files redirected as stdin/stdout) caused reads/writes to always operate at position 0, resulting in infinite loops or incorrect output. The fix creates a FileStream (with bufferSize:0) wrapping the handle when the handle is seekable. FileStream uses OSFileStreamStrategy which tracks the file position and advances it after each read/write, ensuring correct sequential behavior for seekable files. For non-seekable files (pipes, terminals), the existing RandomAccess-based path is used, preserving cursor position tracking for terminals. Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0df60225-7783-4496-abcf-9917387f56e5 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

…g duplication - Replace 'float for GC' FileStream approach with explicit _useFileStreamForIo bool field; FileStream is always held and disposed deterministically - Fix string duplication in stdout test by passing outputContent as RemoteExecutor arg - Add try/catch around File.Delete in finally blocks Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0df60225-7783-4496-abcf-9917387f56e5 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik

@copilot please address my feedback

…onsoleStream, simplify tests - Remove _useFileStreamForIo field and extra comments; always use FileStream for I/O - Change Write() in UnixConsoleStream to call WriteFromConsoleStream(_fileStream, buffer) - Update WriteFromConsoleStream in ConsolePal.Unix.cs and ConsolePal.Wasi.cs to accept FileStream instead of SafeFileHandle; use fs.Write(buffer) which handles both seekable and non-seekable files correctly - Rename SeekableStdinRedirection test to CanCopyStandardInputToStandardOutput and run on all non-mobile platforms (not just AnyUnix); simplify via RemoteInvokeOptions.StartInfo - Simplify SeekableStdoutRedirection test similarly; remove boilerplate try/catch Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/67a83dee-25ae-47d1-ae0f-b4aa1f18265f Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Copilot · 2026-04-14T06:53:15Z

@copilot please address my feedback

Done in adb2b69. All review feedback addressed:

Removed _useFileStreamForIo and extra comments; FileStream is always used for all I/O (handles both seekable and non-seekable correctly)
Write() in UnixConsoleStream now calls WriteFromConsoleStream(_fileStream, buffer)
WriteFromConsoleStream in both ConsolePal.Unix.cs and ConsolePal.Wasi.cs updated to accept FileStream and call fs.Write(buffer)
Tests renamed/simplified and now run on all non-mobile platforms

adamsitnik

@copilot address my feedback

- Fix XML comment in ConsolePal.Wasi.cs Write(FileStream): fd → fs - Remove _handle field from UnixConsoleStream; FileStream owns handle lifetime - Remove Flush() override from UnixConsoleStream (base is a nop; bufferSize:0) - Remove redundant [PlatformSpecific] from two new tests (RemoteExecutor handles it) - Dispose stdoutHandle before WaitForExit so File.ReadAllText can open the file Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ba3bd32e-023a-4160-bf27-f0ae05027d8d Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik · 2026-04-19T20:21:40Z

@jozkee @jkotas @stephentoub I would appreciate your review, as I would like to start a longer leave knowing that I leave no known bugs opened.

For context please refer to #126843

This PR is more or less a revert + tests that are going to ensure we are not going to introduce this bug again.

Copilot

Pull request overview

This PR reverts recent System.Console Unix/WASI I/O changes that used RandomAccess.Read/Write back to the prior Interop.Sys.Read/Write implementation, and adds regression tests for redirected stdin/stdout to seekable files (to prevent hangs/incorrect output).

Changes:

Restore Interop.Sys.Read / Interop.Sys.Write-based console stream I/O on Unix and WASI (including the write loop with EPIPE/EAGAIN handling).
Add/enable regression tests covering seekable stdin and seekable stdout redirection scenarios.
Restore needed interop source inclusions in System.Console.csproj and include ConsoleHandles.cs in the test project.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/libraries/System.Console/tests/System.Console.Tests.csproj	Includes `ConsoleHandles.cs` in the test build.
src/libraries/System.Console/tests/ConsoleHandles.cs	Adds regression tests for seekable stdin/stdout redirection.
src/libraries/System.Console/src/System/ConsolePal.Wasi.cs	Restores `Interop.Sys.Read/Write` + write-loop behavior for WASI.
src/libraries/System.Console/src/System/ConsolePal.Unix.cs	Restores `Interop.Sys.Read/Write` + write-loop behavior and cursor-cache updates.
src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.cs	Switches console stream reads back to `ConsolePal.Read` (Interop-based).
src/libraries/System.Console/src/System.Console.csproj	Re-adds interop source files (Poll/Read/Write) for Unix/WASI builds.

…ression Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/8c4bae7d-c5a8-4e7d-9567-c22ad8c8ff76 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ee38cb6a-7c51-4290-b71e-c815838eb480 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

adamsitnik · 2026-04-30T08:18:14Z

/backport to release/11.0-preview4

github-actions · 2026-04-30T08:18:24Z

Started backporting to release/11.0-preview4 (link to workflow run)

github-actions · 2026-04-30T08:20:30Z

@adamsitnik backporting to release/11.0-preview4 failed, the patch most likely resulted in conflicts. Please backport manually!

git am output

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchCreating an empty commit: Initial planApplying: Fix UnixConsoleStream to handle seekable files correctlyUsing index info to reconstruct a base tree...M	src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csM	src/libraries/System.Console/tests/ConsoleHandles.csM	src/libraries/System.Console/tests/System.Console.Tests.csprojFalling back to patching base and 3-way merge...Auto-merging src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csCONFLICT (content): Merge conflict in src/libraries/System.Console/src/System/ConsolePal.Unix.ConsoleStream.csAuto-merging src/libraries/System.Console/tests/ConsoleHandles.csCONFLICT (content): Merge conflict in src/libraries/System.Console/tests/ConsoleHandles.cserror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0002 Fix UnixConsoleStream to handle seekable files correctlyError: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

adamsitnik · 2026-04-30T09:00:01Z

I am stupid, it was merged before P4 snap so it's already there...

Initial plan
f37fc58

CopilotAI assigned Copilot and adamsitnik Apr 13, 2026

CopilotAI requested review from Copilot and removed request for Copilot April 13, 2026 17:27

Copilotstarted work on behalf of adamsitnik April 13, 2026 17:27 View session

CopilotAI linked an issue Apr 13, 2026 that may be closed by this pull request
Bug in UnixConsoleStream when working with seekable files #126843
Closed

github-actionsBot added the area-System.IO label Apr 13, 2026

CopilotAI requested review from Copilot and removed request for Copilot April 13, 2026 18:15

CopilotAI requested review from Copilot and removed request for Copilot April 13, 2026 18:17

CopilotAI changed the title ~~[WIP] Fix bug in UnixConsoleStream when working with seekable files~~Fix UnixConsoleStream when stdin/stdout is redirected to a seekable fileApr 13, 2026

Copilotfinished work on behalf of adamsitnik April 13, 2026 18:20

CopilotAI requested a review from adamsitnik April 13, 2026 18:20

build-analysisBot mentioned this pull request Apr 14, 2026
Android WebSocket failure #121518
Open

adamsitnik requested changes Apr 14, 2026
View reviewed changes

Copilotstarted work on behalf of adamsitnik April 14, 2026 06:27 View session

CopilotAI requested review from Copilot and removed request for Copilot April 14, 2026 06:53

Copilotfinished work on behalf of adamsitnik April 14, 2026 06:56

CopilotAI requested a review from adamsitnik April 14, 2026 06:56

adamsitnik reviewed Apr 14, 2026
View reviewed changes

Copilotstarted work on behalf of adamsitnik April 14, 2026 08:04 View session

adamsitnik added this to the 11.0.0 milestone Apr 19, 2026

Copilotstarted reviewing on behalf of adamsitnik April 19, 2026 20:18 View session

adamsitnik requested review from jkotas and jozkee April 19, 2026 20:19

adamsitnik enabled auto-merge (squash) April 19, 2026 20:23

CopilotAI reviewed Apr 19, 2026
View reviewed changes

Copilotstarted work on behalf of adamsitnik April 19, 2026 20:37 View session

Split stdout test into two writes to better cover seekable offset reg…
fdd0a2e
…ression Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/8c4bae7d-c5a8-4e7d-9567-c22ad8c8ff76 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

auto-merge was automatically disabled April 19, 2026 20:44
Head branch was pushed to by a user without write access

Copilotfinished work on behalf of adamsitnik April 19, 2026 20:45

CopilotAI requested a review from adamsitnik April 19, 2026 20:45

Copilotstarted work on behalf of adamsitnik April 19, 2026 20:45 View session

Restore PR#124492FORCE_COLOR comment that was accidentally reverted
5107f24
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/ee38cb6a-7c51-4290-b71e-c815838eb480 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

CopilotAI requested review from Copilot and removed request for Copilot April 19, 2026 20:50

Copilotfinished work on behalf of adamsitnik April 19, 2026 20:51

jkotas approved these changes Apr 19, 2026
View reviewed changes

adamsitnik merged commit afd1456 into mainApr 20, 2026
91 of 97 checks passed

adamsitnik deleted the copilot/fix-unix-console-stream-bug branch April 20, 2026 05:57

dotnet-maestroBot mentioned this pull request Apr 21, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#6162
Merged

EgorBo mentioned this pull request Apr 29, 2026
[main] Source code updates from dotnet/dotnet #127324
Closed

richlander mentioned this pull request May 4, 2026
CI: revert smoke-test '| cat > file' workaround when .NET 11 preview 4 SDK ships richlander/dotnet-inspect#319
Closed
3 tasks

adamsitnik changed the title ~~Add tests for UnixConsoleStream when stdin/stdout is redirected to a seekable file~~Fix UnixConsoleStream regression when stdin/stdout is redirected to a seekable fileMay 5, 2026

adamsitnik mentioned this pull request May 5, 2026
Redirecting console app output to file gets mangled in 11.0.0-preview.3 #127784
Closed

github-actionsBot locked and limited conversation to collaborators Jun 4, 2026