Uh oh!
There was an error while loading. Please reload this page.
[ios-clr] Generalize Moq test guards and exclude DI tests on Apple mobile - #127056
[ios-clr] Generalize Moq test guards and exclude DI tests on Apple mobile#127056kotlarmilos wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces Apple mobile CoreCLR test failures by skipping Moq-based tests when the test host is effectively “aggressively trimmed” (where Moq/Castle.DynamicProxy can lose required reflection metadata), and by excluding DI test projects that expect types removed by trimming.
Changes:
- Add
PlatformDetection.IsNotBuiltWithAggressiveTrimmingto Moq-using tests alongsideIsReflectionEmitSupported. - Remove now-stale Apple mobile
ActiveIssueannotations on affected tests. - Update
src/libraries/tests.projto excludeDI.TestsandDI.External.Testson Apple mobile CoreCLR configurations.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/tests.proj | Excludes DI test projects for Apple mobile CoreCLR where trimming breaks assumptions. |
| src/libraries/Microsoft.Extensions.DependencyModel/tests/CompilationLibraryTests.cs | Adds aggressive-trimming guard to the Moq-based test. |
| src/libraries/Microsoft.Extensions.DependencyModel/tests/CompositeResolverTests.cs | Adds aggressive-trimming guard to Moq-based tests. |
| src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/Internal/HostTests.cs | Adds aggressive-trimming guard to Moq-based host lifecycle tests. |
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/InvokeWithRefLikeArgs.cs | Adds aggressive-trimming guard and removes Apple mobile ActiveIssue for the Moq-based test. |
| src/libraries/System.Runtime/tests/System.Text.Encoding.Tests/Encoding/TranscodingStreamTests.cs | Adds aggressive-trimming guard to multiple Moq-based tests and removes Apple mobile ActiveIssue usage. |
| // Moq heavily utilizes RefEmit, which does not work on most aot workloads | ||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] | ||
| [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] | ||
| [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported), nameof(PlatformDetection.IsNotBuiltWithAggressiveTrimming))] | ||
| public void AsyncMethods_ReturnCanceledTaskIfCancellationTokenTripped() |
There was a problem hiding this comment.
Even with these new Moq/trim guards, this file still contains an unguarded [Fact] ReadTimeout_WriteTimeout_NotSupported that instantiates new Mock<Stream>() (currently unused) and will still execute Moq/Castle code paths. On Apple mobile / aggressive trimming this can still fail during mock creation; either remove the Moq usage from that test (since the mock isn’t used) or add the same IsNotBuiltWithAggressiveTrimming/IsReflectionEmitSupported guard to it.
| } | ||
| [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] | ||
| [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported), nameof(PlatformDetection.IsNotBuiltWithAggressiveTrimming))] |
There was a problem hiding this comment.
Write_WithPartialData doesn’t appear to use Moq, so adding IsNotBuiltWithAggressiveTrimming here further reduces coverage in trimmed builds without addressing a Moq/Castle failure mode. If the intent is only to skip tests that actually create mocks, consider dropping the aggressive-trimming condition (or the entire Reflection.Emit condition) for this particular test.
| [ConditionalFact(typeof(PlatformDetection),nameof(PlatformDetection.IsReflectionEmitSupported),nameof(PlatformDetection.IsNotBuiltWithAggressiveTrimming))] | |
| [ConditionalFact(typeof(PlatformDetection),nameof(PlatformDetection.IsReflectionEmitSupported))] |
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
…bile Moq relies on Castle DynamicProxy, which uses Reflection.Emit and reads runtime metadata that aggressive trimming strips. Replace the temporary [ActiveIssue(dotnet#124344, IsAppleMobile && IsCoreCLR)] band-aids with the proper IsNotBuiltWithAggressiveTrimming guard on the existing ConditionalFact, matching the established pattern for Moq-based tests. Microsoft.Extensions.DependencyInjection.Tests and the corresponding ExternalContainers (Stashbox-based) tests are already excluded on Mono AOT iOS/tvOS/MacCatalyst (dotnet#50724), NativeAOT (Ref.Emit heavy, >2/3 failing), tvOS (dotnet#60713 timeouts), and Android (crashes). Apple mobile CoreCLR shares the same fundamental Ref.Emit + aggressive-trim constraint; classify both as "Not supported on Apple mobile" alongside the existing entries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bb4f1fc to
e2a9915Comparekotlarmilos
commented
Apr 17, 2026
This needs to be revisited, looks like the only platform running aggressive trimming with these tests, closing for now. |
Description
Part of splitting #125439 into smaller, self-contained PRs. Two related changes:
[ActiveIssue(#124344, IsAppleMobile && IsCoreCLR)]band-aids withIsNotBuiltWithAggressiveTrimmingon the existingConditionalFact. Castle DynamicProxy (used by Moq) needs runtime metadata that aggressive trimming strips, so the correct guard is aggressive-trimming, not runtime flavor. Matches the established repo-wide pattern for Moq-based tests.Microsoft.Extensions.DependencyInjection.Testsand itsExternalContainers(Stashbox-based) sibling are already excluded on Mono AOT iOS/tvOS/MacCatalyst ([wasm][tests][eat] Multiple test failures with EnableAggressiveTrimming #50724), NativeAOT (>2/3 failing due to Ref.Emit), tvOS ([iOS/tvOS] Small set of test suites time out on devices #60713), and Android (crashes). Classify both as "Not supported on Apple mobile" in the Apple-mobile CoreCLRItemGroup, consistent with those precedents.Changes
Source (remove stale ActiveIssue, add
IsNotBuiltWithAggressiveTrimmingto existingConditionalFact):Microsoft.Extensions.DependencyModel/tests/CompilationLibraryTests.csMicrosoft.Extensions.DependencyModel/tests/CompositeResolverTests.csMicrosoft.Extensions.Hosting/tests/UnitTests/Internal/HostTests.csSystem.Runtime/tests/System.Runtime.Tests/System/Reflection/InvokeWithRefLikeArgs.csSystem.Text.Encoding/tests/System.Text.Encoding.Tests/Encoding/TranscodingStreamTests.csProject:
src/libraries/tests.proj— addMicrosoft.Extensions.DependencyInjection.Tests.csprojandMicrosoft.Extensions.DependencyInjection.ExternalContainers.Tests.csprojunder theNot supported on Apple mobilegroup.Note
This PR description was drafted with assistance from GitHub Copilot.