[cDAC] Add Apple to RuntimeInfoOperatingSystem - #127289

Merged
max-charlamb merged 1 commit into
dotnet:mainfrom
max-charlamb:cdac-runtime-info-apple
Apr 22, 2026
Merged

[cDAC] Add Apple to RuntimeInfoOperatingSystem#127289
max-charlamb merged 1 commit into
dotnet:mainfrom
max-charlamb:cdac-runtime-info-apple

Conversation

@max-charlamb

@max-charlambmax-charlamb commented Apr 22, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Note

This PR description was drafted with AI (Copilot CLI) assistance.

Summary

Adds a dedicated Apple value to RuntimeInfoOperatingSystem so the cDAC can distinguish Apple platforms (macOS / iOS / tvOS / MacCatalyst) from other Unix targets. The native data descriptor emits the new Apple string whenever TARGET_APPLE is defined, checked before the generic TARGET_UNIX arm.

Fixes#127282.

Motivation

CallingConventionInfo in #126408 needs to set IsAppleArm64ABI only on Apple platforms, because Apple ARM64 uses different stack-argument alignment than Linux ARM64 (natural alignment for primitives, 4-byte alignment for float HFAs, vs. Linux's uniform 8-byte slots). With today's enum collapsing everything non-Windows/non-Browser into Unix, that check cannot be expressed and IsAppleArm64ABI is effectively hardcoded.

Changes

  • src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.cs — add Apple to the enum.
  • src/coreclr/vm/datadescriptor/datadescriptor.inc — emit CDAC_GLOBAL_STRING(OperatingSystem, Apple) when TARGET_APPLE is defined, before the TARGET_UNIX arm. Follows the existing #ifdef guard pattern.
  • docs/design/datacontracts/RuntimeInfo.md — document the new value and clarify that Apple is still POSIX for != Windows checks.
  • src/native/managed/cdac/tests/DumpTests/RuntimeInfoDumpTests.cs — map dump metadata "osx" to Apple (was Unix); "linux"/"freebsd" stay Unix.

Compatibility

The enum is parsed via Enum.TryParse(ignoreCase: true):

  • Old runtime + new cDAC: old runtimes still emit "Unix" on macOS, so dumps look identical to today.
  • New runtime + old cDAC: old cDACs fail to parse "Apple" and return Unknown; every production check is == Windows / != Windows, which is unaffected.

No RuntimeInfo contract version bump is needed — V1 is defined in terms of parsing, not the specific token set.

Where the enum is used

All usages are inside src/native/managed/cdac; an org-wide GitHub search found no references outside dotnet/runtime and the dotnet/dotnet VMR mirror, and dotnet/diagnostics has zero references.

Definition

  • Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.cs — enum + IRuntimeInfo.GetTargetOperatingSystem().

Production (parser + consumers)

  • Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeInfo_1.cs — Enum.TryParse(ignoreCase: true) of the OperatingSystem global, fallback to Unknown.
  • Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs — != Windows.
  • …/StackWalk/Context/AMD64/AMD64Unwinder.cs (2 sites) — != Windows → _unixAMD64ABI, and a Debug.Assert(... == Windows) on the Windows-only path.
  • …/StackWalk/Context/X86/X86Unwinder.cs — != Windows.

Tests

  • tests/RuntimeInfoTests.cs — theory data auto-generated from the enum; picks up Apple automatically.
  • tests/DumpTests/RuntimeInfoDumpTests.cs — dump-metadata → enum map (updated by this PR).

Call-site audit

All current GetTargetOperatingSystem() consumers compare against Windows, not Unix, so adding Apple changes no runtime behavior:

SiteCheck
AMD64Unwinder.cs:34!= Windows → sets _unixAMD64ABI. Apple x64 is Unix AMD64 ABI ✓
AMD64Unwinder.cs:853Debug.Assert(... == Windows) on Windows path ✓
X86Unwinder.cs:37!= Windows (x86 has no Apple target) ✓
SOSDacImpl.cs:745!= Windows ✓

Follow-up in #126408 will flip IsAppleArm64ABI = os == Unix to os == Apple.

Testing

  • Microsoft.Diagnostics.DataContractReader.Tests — all 1751 tests pass, including the auto-generated "apple" round-trip case in RuntimeInfoTests.GetTargetOperatingSystemTest.
  • Dump test mapping updated so existing macOS dump configs validate against Apple.
  • The native datadescriptor.inc change is a preprocessor-only addition following the existing pattern and is inert on non-Apple builds.

Max Charlamb
[cDAC] Add Apple to RuntimeInfoOperatingSystem
ead6745
Adds a dedicated Apple value to the RuntimeInfoOperatingSystem enum in
IRuntimeInfo so that cDAC consumers can distinguish Apple platforms
(macOS / iOS / tvOS / MacCatalyst) from other Unix targets. The native
data descriptor emits the new Apple string whenever TARGET_APPLE is
defined, which is checked before the generic TARGET_UNIX arm.
This is needed by CallingConventionInfo (see dotnet#127282) to reliably set
IsAppleArm64ABI for Apple ARM64 stack-argument alignment rules, which
differ from Linux ARM64. Existing != Windows callers (unwinders,
SOSDacImpl) continue to behave correctly for Apple targets since Apple
platforms are still POSIX for their purposes.
The enum is parsed with Enum.TryParse(ignoreCase: true), so older
cDACs reading dumps from updated runtimes will simply see Unknown, and
newer cDACs reading dumps from older runtimes will still see Unix (no
behavioral regression). No RuntimeInfo contract version bump is
required.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings April 22, 2026 16:48
@dotnet-policy-service

dotnet-policy-serviceBot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

CopilotAI reviewed Apr 22, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an Apple operating system discriminator to the cDAC RuntimeInfo contract so consumers can reliably distinguish Apple targets (macOS/iOS/tvOS/MacCatalyst) from other Unix platforms.

Changes:

  • Added RuntimeInfoOperatingSystem.Apple to the managed contract enum.
  • Updated the CoreCLR data descriptor to emit OperatingSystem = "Apple" when TARGET_APPLE is defined (checked before TARGET_UNIX).
  • Updated dump-based tests and contract documentation to account for the new OS value.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

FileDescription
src/native/managed/cdac/tests/DumpTests/RuntimeInfoDumpTests.csMaps dump metadata "osx" to the new RuntimeInfoOperatingSystem.Apple.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.csAdds the Apple enum value for RuntimeInfoOperatingSystem.
src/coreclr/vm/datadescriptor/datadescriptor.incEmits OperatingSystem=Apple under TARGET_APPLE before the TARGET_UNIX arm.
docs/design/datacontracts/RuntimeInfo.mdDocuments the new Apple value and intended semantics.

Comment threaddocs/design/datacontracts/RuntimeInfo.md
@max-charlamb
max-charlamb enabled auto-merge (squash) April 22, 2026 17:12
@max-charlamb

max-charlamb commented Apr 22, 2026

Copy link
Copy Markdown
MemberAuthor

/ba-g cDAC only change and cDAC legs pass

@max-charlamb
max-charlamb merged commit 20f699e into dotnet:mainApr 22, 2026
111 of 132 checks passed
@max-charlamb
max-charlamb deleted the cdac-runtime-info-apple branch April 22, 2026 19:20
This was referenced Apr 22, 2026
Open
Open
Closed
Open
Closed
@dotnet-maestrodotnet-maestroBot mentioned this pull request Apr 23, 2026
Merged
CopilotAI mentioned this pull request Apr 23, 2026
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 24, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rcj1rcj1rcj1 approved these changes

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[cDAC] CallingConventionInfo cannot distinguish Apple ARM64 from Linux ARM64

3 participants

@max-charlamb@rcj1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[cDAC] Add Apple to RuntimeInfoOperatingSystem - #127289
Merged
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:cdac-runtime-info-apple
Apr 22, 2026
Merged
[cDAC] Add Apple to RuntimeInfoOperatingSystem#127289
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:cdac-runtime-info-apple
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Note
This PR description was drafted with AI (Copilot CLI) assistance.
Summary
Adds a dedicated Apple value to RuntimeInfoOperatingSystem so the cDAC can distinguish Apple platforms (macOS / iOS / tvOS / MacCatalyst) from other Unix targets. The native data descriptor emits the new Apple string whenever TARGET_APPLE is defined, checked before the generic TARGET_UNIX arm.
Fixes#127282.
Motivation
CallingConventionInfo in #126408 needs to set IsAppleArm64ABI only on Apple platforms, because Apple ARM64 uses different stack-argument alignment than Linux ARM64 (natural alignment for primitives, 4-byte alignment for float HFAs, vs. Linux's uniform 8-byte slots). With today's enum collapsing everything non-Windows/non-Browser into Unix, that check cannot be expressed and IsAppleArm64ABI is effectively hardcoded.
Changes
  • src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.cs — add Apple to the enum.
  • src/coreclr/vm/datadescriptor/datadescriptor.inc — emit CDAC_GLOBAL_STRING(OperatingSystem, Apple) when TARGET_APPLE is defined, before the TARGET_UNIX arm. Follows the existing #ifdef guard pattern.
  • docs/design/datacontracts/RuntimeInfo.md — document the new value and clarify that Apple is still POSIX for != Windows checks.
  • src/native/managed/cdac/tests/DumpTests/RuntimeInfoDumpTests.cs — map dump metadata "osx" to Apple (was Unix); "linux"/"freebsd" stay Unix.
Compatibility
The enum is parsed via Enum.TryParse(ignoreCase: true):
  • Old runtime + new cDAC: old runtimes still emit "Unix" on macOS, so dumps look identical to today.
  • New runtime + old cDAC: old cDACs fail to parse "Apple" and return Unknown; every production check is == Windows / != Windows, which is unaffected.
No RuntimeInfo contract version bump is needed — V1 is defined in terms of parsing, not the specific token set.
Where the enum is used
All usages are inside src/native/managed/cdac; an org-wide GitHub search found no references outside dotnet/runtime and the dotnet/dotnet VMR mirror, and dotnet/diagnostics has zero references.
Definition
  • Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.cs — enum + IRuntimeInfo.GetTargetOperatingSystem().
Production (parser + consumers)
  • Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeInfo_1.cs — Enum.TryParse(ignoreCase: true) of the OperatingSystem global, fallback to Unknown.
  • Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs — != Windows.
  • …/StackWalk/Context/AMD64/AMD64Unwinder.cs (2 sites) — != Windows → _unixAMD64ABI, and a Debug.Assert(... == Windows) on the Windows-only path.
  • …/StackWalk/Context/X86/X86Unwinder.cs — != Windows.
Tests
  • tests/RuntimeInfoTests.cs — theory data auto-generated from the enum; picks up Apple automatically.
  • tests/DumpTests/RuntimeInfoDumpTests.cs — dump-metadata → enum map (updated by this PR).
Call-site audit
All current GetTargetOperatingSystem() consumers compare against Windows, not Unix, so adding Apple changes no runtime behavior:
SiteCheck
AMD64Unwinder.cs:34!= Windows → sets _unixAMD64ABI. Apple x64 is Unix AMD64 ABI ✓
AMD64Unwinder.cs:853Debug.Assert(... == Windows) on Windows path ✓
X86Unwinder.cs:37!= Windows (x86 has no Apple target) ✓
SOSDacImpl.cs:745!= Windows ✓
Follow-up in #126408 will flip IsAppleArm64ABI = os == Unix to os == Apple.
Testing
  • Microsoft.Diagnostics.DataContractReader.Tests — all 1751 tests pass, including the auto-generated "apple" round-trip case in RuntimeInfoTests.GetTargetOperatingSystemTest.
  • Dump test mapping updated so existing macOS dump configs validate against Apple.
  • The native datadescriptor.inc change is a preprocessor-only addition following the existing pattern and is inert on non-Apple builds.
Max Charlamb
[cDAC] Add Apple to RuntimeInfoOperatingSystem
ead6745
Adds a dedicated Apple value to the RuntimeInfoOperatingSystem enum in
IRuntimeInfo so that cDAC consumers can distinguish Apple platforms
(macOS / iOS / tvOS / MacCatalyst) from other Unix targets. The native
data descriptor emits the new Apple string whenever TARGET_APPLE is
defined, which is checked before the generic TARGET_UNIX arm.
This is needed by CallingConventionInfo (see dotnet#127282) to reliably set
IsAppleArm64ABI for Apple ARM64 stack-argument alignment rules, which
differ from Linux ARM64. Existing != Windows callers (unwinders,
SOSDacImpl) continue to behave correctly for Apple targets since Apple
platforms are still POSIX for their purposes.
The enum is parsed with Enum.TryParse(ignoreCase: true), so older
cDACs reading dumps from updated runtimes will simply see Unknown, and
newer cDACs reading dumps from older runtimes will still see Unix (no
behavioral regression). No RuntimeInfo contract version bump is
required.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
April 22, 2026 16:48
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 22, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Apr 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Adds an Apple operating system discriminator to the cDAC RuntimeInfo contract so consumers can reliably distinguish Apple targets (macOS/iOS/tvOS/MacCatalyst) from other Unix platforms.
Changes:
  • Added RuntimeInfoOperatingSystem.Apple to the managed contract enum.
  • Updated the CoreCLR data descriptor to emit OperatingSystem = "Apple" when TARGET_APPLE is defined (checked before TARGET_UNIX).
  • Updated dump-based tests and contract documentation to account for the new OS value.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
FileDescription
src/native/managed/cdac/tests/DumpTests/RuntimeInfoDumpTests.csMaps dump metadata "osx" to the new RuntimeInfoOperatingSystem.Apple.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.csAdds the Apple enum value for RuntimeInfoOperatingSystem.
src/coreclr/vm/datadescriptor/datadescriptor.incEmits OperatingSystem=Apple under TARGET_APPLE before the TARGET_UNIX arm.
docs/design/datacontracts/RuntimeInfo.mdDocuments the new Apple value and intended semantics.
Comment threaddocs/design/datacontracts/RuntimeInfo.md
@max-charlamb
max-charlamb
enabled auto-merge (squash)
April 22, 2026 17:12
@max-charlamb
max-charlamb
commented
Apr 22, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change and cDAC legs pass
@max-charlamb
max-charlamb
merged commit 20f699e
into
dotnet:mainApr 22, 2026

111 of 132 checks passed

@max-charlamb
max-charlamb
deleted the

cdac-runtime-info-apple

branch
April 22, 2026 19:20

This was referenced Apr 22, 2026

Open


Open


Closed


Open


Closed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 23, 2026
 Merged

CopilotAI
mentioned this pull request
Apr 23, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 24, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rcj1rcj1rcj1 approved these changes

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[cDAC] CallingConventionInfo cannot distinguish Apple ARM64 from Linux ARM64


3 participants

@max-charlamb@rcj1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] Add Apple to RuntimeInfoOperatingSystem - #127289
Merged
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:cdac-runtime-info-apple
Apr 22, 2026
Merged
[cDAC] Add Apple to RuntimeInfoOperatingSystem#127289
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:cdac-runtime-info-apple
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Note
This PR description was drafted with AI (Copilot CLI) assistance.
Summary
Adds a dedicated Apple value to RuntimeInfoOperatingSystem so the cDAC can distinguish Apple platforms (macOS / iOS / tvOS / MacCatalyst) from other Unix targets. The native data descriptor emits the new Apple string whenever TARGET_APPLE is defined, checked before the generic TARGET_UNIX arm.
Fixes#127282.
Motivation
CallingConventionInfo in #126408 needs to set IsAppleArm64ABI only on Apple platforms, because Apple ARM64 uses different stack-argument alignment than Linux ARM64 (natural alignment for primitives, 4-byte alignment for float HFAs, vs. Linux's uniform 8-byte slots). With today's enum collapsing everything non-Windows/non-Browser into Unix, that check cannot be expressed and IsAppleArm64ABI is effectively hardcoded.
Changes
  • src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.cs — add Apple to the enum.
  • src/coreclr/vm/datadescriptor/datadescriptor.inc — emit CDAC_GLOBAL_STRING(OperatingSystem, Apple) when TARGET_APPLE is defined, before the TARGET_UNIX arm. Follows the existing #ifdef guard pattern.
  • docs/design/datacontracts/RuntimeInfo.md — document the new value and clarify that Apple is still POSIX for != Windows checks.
  • src/native/managed/cdac/tests/DumpTests/RuntimeInfoDumpTests.cs — map dump metadata "osx" to Apple (was Unix); "linux"/"freebsd" stay Unix.
Compatibility
The enum is parsed via Enum.TryParse(ignoreCase: true):
  • Old runtime + new cDAC: old runtimes still emit "Unix" on macOS, so dumps look identical to today.
  • New runtime + old cDAC: old cDACs fail to parse "Apple" and return Unknown; every production check is == Windows / != Windows, which is unaffected.
No RuntimeInfo contract version bump is needed — V1 is defined in terms of parsing, not the specific token set.
Where the enum is used
All usages are inside src/native/managed/cdac; an org-wide GitHub search found no references outside dotnet/runtime and the dotnet/dotnet VMR mirror, and dotnet/diagnostics has zero references.
Definition
  • Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.cs — enum + IRuntimeInfo.GetTargetOperatingSystem().
Production (parser + consumers)
  • Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeInfo_1.cs — Enum.TryParse(ignoreCase: true) of the OperatingSystem global, fallback to Unknown.
  • Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs — != Windows.
  • …/StackWalk/Context/AMD64/AMD64Unwinder.cs (2 sites) — != Windows → _unixAMD64ABI, and a Debug.Assert(... == Windows) on the Windows-only path.
  • …/StackWalk/Context/X86/X86Unwinder.cs — != Windows.
Tests
  • tests/RuntimeInfoTests.cs — theory data auto-generated from the enum; picks up Apple automatically.
  • tests/DumpTests/RuntimeInfoDumpTests.cs — dump-metadata → enum map (updated by this PR).
Call-site audit
All current GetTargetOperatingSystem() consumers compare against Windows, not Unix, so adding Apple changes no runtime behavior:
SiteCheck
AMD64Unwinder.cs:34!= Windows → sets _unixAMD64ABI. Apple x64 is Unix AMD64 ABI ✓
AMD64Unwinder.cs:853Debug.Assert(... == Windows) on Windows path ✓
X86Unwinder.cs:37!= Windows (x86 has no Apple target) ✓
SOSDacImpl.cs:745!= Windows ✓
Follow-up in #126408 will flip IsAppleArm64ABI = os == Unix to os == Apple.
Testing
  • Microsoft.Diagnostics.DataContractReader.Tests — all 1751 tests pass, including the auto-generated "apple" round-trip case in RuntimeInfoTests.GetTargetOperatingSystemTest.
  • Dump test mapping updated so existing macOS dump configs validate against Apple.
  • The native datadescriptor.inc change is a preprocessor-only addition following the existing pattern and is inert on non-Apple builds.
Max Charlamb
[cDAC] Add Apple to RuntimeInfoOperatingSystem
ead6745
Adds a dedicated Apple value to the RuntimeInfoOperatingSystem enum in
IRuntimeInfo so that cDAC consumers can distinguish Apple platforms
(macOS / iOS / tvOS / MacCatalyst) from other Unix targets. The native
data descriptor emits the new Apple string whenever TARGET_APPLE is
defined, which is checked before the generic TARGET_UNIX arm.
This is needed by CallingConventionInfo (see dotnet#127282) to reliably set
IsAppleArm64ABI for Apple ARM64 stack-argument alignment rules, which
differ from Linux ARM64. Existing != Windows callers (unwinders,
SOSDacImpl) continue to behave correctly for Apple targets since Apple
platforms are still POSIX for their purposes.
The enum is parsed with Enum.TryParse(ignoreCase: true), so older
cDACs reading dumps from updated runtimes will simply see Unknown, and
newer cDACs reading dumps from older runtimes will still see Unix (no
behavioral regression). No RuntimeInfo contract version bump is
required.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
April 22, 2026 16:48
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 22, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Apr 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Adds an Apple operating system discriminator to the cDAC RuntimeInfo contract so consumers can reliably distinguish Apple targets (macOS/iOS/tvOS/MacCatalyst) from other Unix platforms.
Changes:
  • Added RuntimeInfoOperatingSystem.Apple to the managed contract enum.
  • Updated the CoreCLR data descriptor to emit OperatingSystem = "Apple" when TARGET_APPLE is defined (checked before TARGET_UNIX).
  • Updated dump-based tests and contract documentation to account for the new OS value.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
FileDescription
src/native/managed/cdac/tests/DumpTests/RuntimeInfoDumpTests.csMaps dump metadata "osx" to the new RuntimeInfoOperatingSystem.Apple.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.csAdds the Apple enum value for RuntimeInfoOperatingSystem.
src/coreclr/vm/datadescriptor/datadescriptor.incEmits OperatingSystem=Apple under TARGET_APPLE before the TARGET_UNIX arm.
docs/design/datacontracts/RuntimeInfo.mdDocuments the new Apple value and intended semantics.
Comment threaddocs/design/datacontracts/RuntimeInfo.md
@max-charlamb
max-charlamb
enabled auto-merge (squash)
April 22, 2026 17:12
@max-charlamb
max-charlamb
commented
Apr 22, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change and cDAC legs pass
@max-charlamb
max-charlamb
merged commit 20f699e
into
dotnet:mainApr 22, 2026

111 of 132 checks passed

@max-charlamb
max-charlamb
deleted the

cdac-runtime-info-apple

branch
April 22, 2026 19:20

This was referenced Apr 22, 2026

Open


Open


Closed


Open


Closed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 23, 2026
 Merged

CopilotAI
mentioned this pull request
Apr 23, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 24, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rcj1rcj1rcj1 approved these changes

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[cDAC] CallingConventionInfo cannot distinguish Apple ARM64 from Linux ARM64


3 participants

@max-charlamb@rcj1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] Add Apple to RuntimeInfoOperatingSystem - #127289
Merged
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:cdac-runtime-info-apple
Apr 22, 2026
Merged
[cDAC] Add Apple to RuntimeInfoOperatingSystem#127289
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:cdac-runtime-info-apple
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Note
This PR description was drafted with AI (Copilot CLI) assistance.
Summary
Adds a dedicated Apple value to RuntimeInfoOperatingSystem so the cDAC can distinguish Apple platforms (macOS / iOS / tvOS / MacCatalyst) from other Unix targets. The native data descriptor emits the new Apple string whenever TARGET_APPLE is defined, checked before the generic TARGET_UNIX arm.
Fixes#127282.
Motivation
CallingConventionInfo in #126408 needs to set IsAppleArm64ABI only on Apple platforms, because Apple ARM64 uses different stack-argument alignment than Linux ARM64 (natural alignment for primitives, 4-byte alignment for float HFAs, vs. Linux's uniform 8-byte slots). With today's enum collapsing everything non-Windows/non-Browser into Unix, that check cannot be expressed and IsAppleArm64ABI is effectively hardcoded.
Changes
  • src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.cs — add Apple to the enum.
  • src/coreclr/vm/datadescriptor/datadescriptor.inc — emit CDAC_GLOBAL_STRING(OperatingSystem, Apple) when TARGET_APPLE is defined, before the TARGET_UNIX arm. Follows the existing #ifdef guard pattern.
  • docs/design/datacontracts/RuntimeInfo.md — document the new value and clarify that Apple is still POSIX for != Windows checks.
  • src/native/managed/cdac/tests/DumpTests/RuntimeInfoDumpTests.cs — map dump metadata "osx" to Apple (was Unix); "linux"/"freebsd" stay Unix.
Compatibility
The enum is parsed via Enum.TryParse(ignoreCase: true):
  • Old runtime + new cDAC: old runtimes still emit "Unix" on macOS, so dumps look identical to today.
  • New runtime + old cDAC: old cDACs fail to parse "Apple" and return Unknown; every production check is == Windows / != Windows, which is unaffected.
No RuntimeInfo contract version bump is needed — V1 is defined in terms of parsing, not the specific token set.
Where the enum is used
All usages are inside src/native/managed/cdac; an org-wide GitHub search found no references outside dotnet/runtime and the dotnet/dotnet VMR mirror, and dotnet/diagnostics has zero references.
Definition
  • Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.cs — enum + IRuntimeInfo.GetTargetOperatingSystem().
Production (parser + consumers)
  • Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeInfo_1.cs — Enum.TryParse(ignoreCase: true) of the OperatingSystem global, fallback to Unknown.
  • Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs — != Windows.
  • …/StackWalk/Context/AMD64/AMD64Unwinder.cs (2 sites) — != Windows → _unixAMD64ABI, and a Debug.Assert(... == Windows) on the Windows-only path.
  • …/StackWalk/Context/X86/X86Unwinder.cs — != Windows.
Tests
  • tests/RuntimeInfoTests.cs — theory data auto-generated from the enum; picks up Apple automatically.
  • tests/DumpTests/RuntimeInfoDumpTests.cs — dump-metadata → enum map (updated by this PR).
Call-site audit
All current GetTargetOperatingSystem() consumers compare against Windows, not Unix, so adding Apple changes no runtime behavior:
SiteCheck
AMD64Unwinder.cs:34!= Windows → sets _unixAMD64ABI. Apple x64 is Unix AMD64 ABI ✓
AMD64Unwinder.cs:853Debug.Assert(... == Windows) on Windows path ✓
X86Unwinder.cs:37!= Windows (x86 has no Apple target) ✓
SOSDacImpl.cs:745!= Windows ✓
Follow-up in #126408 will flip IsAppleArm64ABI = os == Unix to os == Apple.
Testing
  • Microsoft.Diagnostics.DataContractReader.Tests — all 1751 tests pass, including the auto-generated "apple" round-trip case in RuntimeInfoTests.GetTargetOperatingSystemTest.
  • Dump test mapping updated so existing macOS dump configs validate against Apple.
  • The native datadescriptor.inc change is a preprocessor-only addition following the existing pattern and is inert on non-Apple builds.
Max Charlamb
[cDAC] Add Apple to RuntimeInfoOperatingSystem
ead6745
Adds a dedicated Apple value to the RuntimeInfoOperatingSystem enum in
IRuntimeInfo so that cDAC consumers can distinguish Apple platforms
(macOS / iOS / tvOS / MacCatalyst) from other Unix targets. The native
data descriptor emits the new Apple string whenever TARGET_APPLE is
defined, which is checked before the generic TARGET_UNIX arm.
This is needed by CallingConventionInfo (see dotnet#127282) to reliably set
IsAppleArm64ABI for Apple ARM64 stack-argument alignment rules, which
differ from Linux ARM64. Existing != Windows callers (unwinders,
SOSDacImpl) continue to behave correctly for Apple targets since Apple
platforms are still POSIX for their purposes.
The enum is parsed with Enum.TryParse(ignoreCase: true), so older
cDACs reading dumps from updated runtimes will simply see Unknown, and
newer cDACs reading dumps from older runtimes will still see Unix (no
behavioral regression). No RuntimeInfo contract version bump is
required.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
April 22, 2026 16:48
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 22, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Apr 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Adds an Apple operating system discriminator to the cDAC RuntimeInfo contract so consumers can reliably distinguish Apple targets (macOS/iOS/tvOS/MacCatalyst) from other Unix platforms.
Changes:
  • Added RuntimeInfoOperatingSystem.Apple to the managed contract enum.
  • Updated the CoreCLR data descriptor to emit OperatingSystem = "Apple" when TARGET_APPLE is defined (checked before TARGET_UNIX).
  • Updated dump-based tests and contract documentation to account for the new OS value.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
FileDescription
src/native/managed/cdac/tests/DumpTests/RuntimeInfoDumpTests.csMaps dump metadata "osx" to the new RuntimeInfoOperatingSystem.Apple.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.csAdds the Apple enum value for RuntimeInfoOperatingSystem.
src/coreclr/vm/datadescriptor/datadescriptor.incEmits OperatingSystem=Apple under TARGET_APPLE before the TARGET_UNIX arm.
docs/design/datacontracts/RuntimeInfo.mdDocuments the new Apple value and intended semantics.
Comment threaddocs/design/datacontracts/RuntimeInfo.md
@max-charlamb
max-charlamb
enabled auto-merge (squash)
April 22, 2026 17:12
@max-charlamb
max-charlamb
commented
Apr 22, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change and cDAC legs pass
@max-charlamb
max-charlamb
merged commit 20f699e
into
dotnet:mainApr 22, 2026

111 of 132 checks passed

@max-charlamb
max-charlamb
deleted the

cdac-runtime-info-apple

branch
April 22, 2026 19:20

This was referenced Apr 22, 2026

Open


Open


Closed


Open


Closed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 23, 2026
 Merged

CopilotAI
mentioned this pull request
Apr 23, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 24, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rcj1rcj1rcj1 approved these changes

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[cDAC] CallingConventionInfo cannot distinguish Apple ARM64 from Linux ARM64


3 participants

@max-charlamb@rcj1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[cDAC] Add Apple to RuntimeInfoOperatingSystem - #127289
Merged
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:cdac-runtime-info-apple
Apr 22, 2026
Merged
[cDAC] Add Apple to RuntimeInfoOperatingSystem#127289
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:cdac-runtime-info-apple
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Note
This PR description was drafted with AI (Copilot CLI) assistance.
Summary
Adds a dedicated Apple value to RuntimeInfoOperatingSystem so the cDAC can distinguish Apple platforms (macOS / iOS / tvOS / MacCatalyst) from other Unix targets. The native data descriptor emits the new Apple string whenever TARGET_APPLE is defined, checked before the generic TARGET_UNIX arm.
Fixes#127282.
Motivation
CallingConventionInfo in #126408 needs to set IsAppleArm64ABI only on Apple platforms, because Apple ARM64 uses different stack-argument alignment than Linux ARM64 (natural alignment for primitives, 4-byte alignment for float HFAs, vs. Linux's uniform 8-byte slots). With today's enum collapsing everything non-Windows/non-Browser into Unix, that check cannot be expressed and IsAppleArm64ABI is effectively hardcoded.
Changes
  • src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.cs — add Apple to the enum.
  • src/coreclr/vm/datadescriptor/datadescriptor.inc — emit CDAC_GLOBAL_STRING(OperatingSystem, Apple) when TARGET_APPLE is defined, before the TARGET_UNIX arm. Follows the existing #ifdef guard pattern.
  • docs/design/datacontracts/RuntimeInfo.md — document the new value and clarify that Apple is still POSIX for != Windows checks.
  • src/native/managed/cdac/tests/DumpTests/RuntimeInfoDumpTests.cs — map dump metadata "osx" to Apple (was Unix); "linux"/"freebsd" stay Unix.
Compatibility
The enum is parsed via Enum.TryParse(ignoreCase: true):
  • Old runtime + new cDAC: old runtimes still emit "Unix" on macOS, so dumps look identical to today.
  • New runtime + old cDAC: old cDACs fail to parse "Apple" and return Unknown; every production check is == Windows / != Windows, which is unaffected.
No RuntimeInfo contract version bump is needed — V1 is defined in terms of parsing, not the specific token set.
Where the enum is used
All usages are inside src/native/managed/cdac; an org-wide GitHub search found no references outside dotnet/runtime and the dotnet/dotnet VMR mirror, and dotnet/diagnostics has zero references.
Definition
  • Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.cs — enum + IRuntimeInfo.GetTargetOperatingSystem().
Production (parser + consumers)
  • Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeInfo_1.cs — Enum.TryParse(ignoreCase: true) of the OperatingSystem global, fallback to Unknown.
  • Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs — != Windows.
  • …/StackWalk/Context/AMD64/AMD64Unwinder.cs (2 sites) — != Windows → _unixAMD64ABI, and a Debug.Assert(... == Windows) on the Windows-only path.
  • …/StackWalk/Context/X86/X86Unwinder.cs — != Windows.
Tests
  • tests/RuntimeInfoTests.cs — theory data auto-generated from the enum; picks up Apple automatically.
  • tests/DumpTests/RuntimeInfoDumpTests.cs — dump-metadata → enum map (updated by this PR).
Call-site audit
All current GetTargetOperatingSystem() consumers compare against Windows, not Unix, so adding Apple changes no runtime behavior:
SiteCheck
AMD64Unwinder.cs:34!= Windows → sets _unixAMD64ABI. Apple x64 is Unix AMD64 ABI ✓
AMD64Unwinder.cs:853Debug.Assert(... == Windows) on Windows path ✓
X86Unwinder.cs:37!= Windows (x86 has no Apple target) ✓
SOSDacImpl.cs:745!= Windows ✓
Follow-up in #126408 will flip IsAppleArm64ABI = os == Unix to os == Apple.
Testing
  • Microsoft.Diagnostics.DataContractReader.Tests — all 1751 tests pass, including the auto-generated "apple" round-trip case in RuntimeInfoTests.GetTargetOperatingSystemTest.
  • Dump test mapping updated so existing macOS dump configs validate against Apple.
  • The native datadescriptor.inc change is a preprocessor-only addition following the existing pattern and is inert on non-Apple builds.
Max Charlamb
[cDAC] Add Apple to RuntimeInfoOperatingSystem
ead6745
Adds a dedicated Apple value to the RuntimeInfoOperatingSystem enum in
IRuntimeInfo so that cDAC consumers can distinguish Apple platforms
(macOS / iOS / tvOS / MacCatalyst) from other Unix targets. The native
data descriptor emits the new Apple string whenever TARGET_APPLE is
defined, which is checked before the generic TARGET_UNIX arm.
This is needed by CallingConventionInfo (see dotnet#127282) to reliably set
IsAppleArm64ABI for Apple ARM64 stack-argument alignment rules, which
differ from Linux ARM64. Existing != Windows callers (unwinders,
SOSDacImpl) continue to behave correctly for Apple targets since Apple
platforms are still POSIX for their purposes.
The enum is parsed with Enum.TryParse(ignoreCase: true), so older
cDACs reading dumps from updated runtimes will simply see Unknown, and
newer cDACs reading dumps from older runtimes will still see Unix (no
behavioral regression). No RuntimeInfo contract version bump is
required.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
April 22, 2026 16:48
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 22, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Apr 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Adds an Apple operating system discriminator to the cDAC RuntimeInfo contract so consumers can reliably distinguish Apple targets (macOS/iOS/tvOS/MacCatalyst) from other Unix platforms.
Changes:
  • Added RuntimeInfoOperatingSystem.Apple to the managed contract enum.
  • Updated the CoreCLR data descriptor to emit OperatingSystem = "Apple" when TARGET_APPLE is defined (checked before TARGET_UNIX).
  • Updated dump-based tests and contract documentation to account for the new OS value.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
FileDescription
src/native/managed/cdac/tests/DumpTests/RuntimeInfoDumpTests.csMaps dump metadata "osx" to the new RuntimeInfoOperatingSystem.Apple.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.csAdds the Apple enum value for RuntimeInfoOperatingSystem.
src/coreclr/vm/datadescriptor/datadescriptor.incEmits OperatingSystem=Apple under TARGET_APPLE before the TARGET_UNIX arm.
docs/design/datacontracts/RuntimeInfo.mdDocuments the new Apple value and intended semantics.
Comment threaddocs/design/datacontracts/RuntimeInfo.md
@max-charlamb
max-charlamb
enabled auto-merge (squash)
April 22, 2026 17:12
@max-charlamb
max-charlamb
commented
Apr 22, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change and cDAC legs pass
@max-charlamb
max-charlamb
merged commit 20f699e
into
dotnet:mainApr 22, 2026

111 of 132 checks passed

@max-charlamb
max-charlamb
deleted the

cdac-runtime-info-apple

branch
April 22, 2026 19:20

This was referenced Apr 22, 2026

Open


Open


Closed


Open


Closed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 23, 2026
 Merged

CopilotAI
mentioned this pull request
Apr 23, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 24, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rcj1rcj1rcj1 approved these changes

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[cDAC] CallingConventionInfo cannot distinguish Apple ARM64 from Linux ARM64


3 participants

@max-charlamb@rcj1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] Add Apple to RuntimeInfoOperatingSystem - #127289
Merged
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:cdac-runtime-info-apple
Apr 22, 2026
Merged
[cDAC] Add Apple to RuntimeInfoOperatingSystem#127289
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:cdac-runtime-info-apple
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Note
This PR description was drafted with AI (Copilot CLI) assistance.
Summary
Adds a dedicated Apple value to RuntimeInfoOperatingSystem so the cDAC can distinguish Apple platforms (macOS / iOS / tvOS / MacCatalyst) from other Unix targets. The native data descriptor emits the new Apple string whenever TARGET_APPLE is defined, checked before the generic TARGET_UNIX arm.
Fixes#127282.
Motivation
CallingConventionInfo in #126408 needs to set IsAppleArm64ABI only on Apple platforms, because Apple ARM64 uses different stack-argument alignment than Linux ARM64 (natural alignment for primitives, 4-byte alignment for float HFAs, vs. Linux's uniform 8-byte slots). With today's enum collapsing everything non-Windows/non-Browser into Unix, that check cannot be expressed and IsAppleArm64ABI is effectively hardcoded.
Changes
  • src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.cs — add Apple to the enum.
  • src/coreclr/vm/datadescriptor/datadescriptor.inc — emit CDAC_GLOBAL_STRING(OperatingSystem, Apple) when TARGET_APPLE is defined, before the TARGET_UNIX arm. Follows the existing #ifdef guard pattern.
  • docs/design/datacontracts/RuntimeInfo.md — document the new value and clarify that Apple is still POSIX for != Windows checks.
  • src/native/managed/cdac/tests/DumpTests/RuntimeInfoDumpTests.cs — map dump metadata "osx" to Apple (was Unix); "linux"/"freebsd" stay Unix.
Compatibility
The enum is parsed via Enum.TryParse(ignoreCase: true):
  • Old runtime + new cDAC: old runtimes still emit "Unix" on macOS, so dumps look identical to today.
  • New runtime + old cDAC: old cDACs fail to parse "Apple" and return Unknown; every production check is == Windows / != Windows, which is unaffected.
No RuntimeInfo contract version bump is needed — V1 is defined in terms of parsing, not the specific token set.
Where the enum is used
All usages are inside src/native/managed/cdac; an org-wide GitHub search found no references outside dotnet/runtime and the dotnet/dotnet VMR mirror, and dotnet/diagnostics has zero references.
Definition
  • Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.cs — enum + IRuntimeInfo.GetTargetOperatingSystem().
Production (parser + consumers)
  • Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeInfo_1.cs — Enum.TryParse(ignoreCase: true) of the OperatingSystem global, fallback to Unknown.
  • Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs — != Windows.
  • …/StackWalk/Context/AMD64/AMD64Unwinder.cs (2 sites) — != Windows → _unixAMD64ABI, and a Debug.Assert(... == Windows) on the Windows-only path.
  • …/StackWalk/Context/X86/X86Unwinder.cs — != Windows.
Tests
  • tests/RuntimeInfoTests.cs — theory data auto-generated from the enum; picks up Apple automatically.
  • tests/DumpTests/RuntimeInfoDumpTests.cs — dump-metadata → enum map (updated by this PR).
Call-site audit
All current GetTargetOperatingSystem() consumers compare against Windows, not Unix, so adding Apple changes no runtime behavior:
SiteCheck
AMD64Unwinder.cs:34!= Windows → sets _unixAMD64ABI. Apple x64 is Unix AMD64 ABI ✓
AMD64Unwinder.cs:853Debug.Assert(... == Windows) on Windows path ✓
X86Unwinder.cs:37!= Windows (x86 has no Apple target) ✓
SOSDacImpl.cs:745!= Windows ✓
Follow-up in #126408 will flip IsAppleArm64ABI = os == Unix to os == Apple.
Testing
  • Microsoft.Diagnostics.DataContractReader.Tests — all 1751 tests pass, including the auto-generated "apple" round-trip case in RuntimeInfoTests.GetTargetOperatingSystemTest.
  • Dump test mapping updated so existing macOS dump configs validate against Apple.
  • The native datadescriptor.inc change is a preprocessor-only addition following the existing pattern and is inert on non-Apple builds.
Max Charlamb
[cDAC] Add Apple to RuntimeInfoOperatingSystem
ead6745
Adds a dedicated Apple value to the RuntimeInfoOperatingSystem enum in
IRuntimeInfo so that cDAC consumers can distinguish Apple platforms
(macOS / iOS / tvOS / MacCatalyst) from other Unix targets. The native
data descriptor emits the new Apple string whenever TARGET_APPLE is
defined, which is checked before the generic TARGET_UNIX arm.
This is needed by CallingConventionInfo (see dotnet#127282) to reliably set
IsAppleArm64ABI for Apple ARM64 stack-argument alignment rules, which
differ from Linux ARM64. Existing != Windows callers (unwinders,
SOSDacImpl) continue to behave correctly for Apple targets since Apple
platforms are still POSIX for their purposes.
The enum is parsed with Enum.TryParse(ignoreCase: true), so older
cDACs reading dumps from updated runtimes will simply see Unknown, and
newer cDACs reading dumps from older runtimes will still see Unix (no
behavioral regression). No RuntimeInfo contract version bump is
required.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
April 22, 2026 16:48
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 22, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Apr 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Adds an Apple operating system discriminator to the cDAC RuntimeInfo contract so consumers can reliably distinguish Apple targets (macOS/iOS/tvOS/MacCatalyst) from other Unix platforms.
Changes:
  • Added RuntimeInfoOperatingSystem.Apple to the managed contract enum.
  • Updated the CoreCLR data descriptor to emit OperatingSystem = "Apple" when TARGET_APPLE is defined (checked before TARGET_UNIX).
  • Updated dump-based tests and contract documentation to account for the new OS value.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
FileDescription
src/native/managed/cdac/tests/DumpTests/RuntimeInfoDumpTests.csMaps dump metadata "osx" to the new RuntimeInfoOperatingSystem.Apple.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.csAdds the Apple enum value for RuntimeInfoOperatingSystem.
src/coreclr/vm/datadescriptor/datadescriptor.incEmits OperatingSystem=Apple under TARGET_APPLE before the TARGET_UNIX arm.
docs/design/datacontracts/RuntimeInfo.mdDocuments the new Apple value and intended semantics.
Comment threaddocs/design/datacontracts/RuntimeInfo.md
@max-charlamb
max-charlamb
enabled auto-merge (squash)
April 22, 2026 17:12
@max-charlamb
max-charlamb
commented
Apr 22, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change and cDAC legs pass
@max-charlamb
max-charlamb
merged commit 20f699e
into
dotnet:mainApr 22, 2026

111 of 132 checks passed

@max-charlamb
max-charlamb
deleted the

cdac-runtime-info-apple

branch
April 22, 2026 19:20

This was referenced Apr 22, 2026

Open


Open


Closed


Open


Closed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 23, 2026
 Merged

CopilotAI
mentioned this pull request
Apr 23, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 24, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rcj1rcj1rcj1 approved these changes

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[cDAC] CallingConventionInfo cannot distinguish Apple ARM64 from Linux ARM64


3 participants

@max-charlamb@rcj1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] Add Apple to RuntimeInfoOperatingSystem - #127289
Merged
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:cdac-runtime-info-apple
Apr 22, 2026
Merged
[cDAC] Add Apple to RuntimeInfoOperatingSystem#127289
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:cdac-runtime-info-apple
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Note
This PR description was drafted with AI (Copilot CLI) assistance.
Summary
Adds a dedicated Apple value to RuntimeInfoOperatingSystem so the cDAC can distinguish Apple platforms (macOS / iOS / tvOS / MacCatalyst) from other Unix targets. The native data descriptor emits the new Apple string whenever TARGET_APPLE is defined, checked before the generic TARGET_UNIX arm.
Fixes#127282.
Motivation
CallingConventionInfo in #126408 needs to set IsAppleArm64ABI only on Apple platforms, because Apple ARM64 uses different stack-argument alignment than Linux ARM64 (natural alignment for primitives, 4-byte alignment for float HFAs, vs. Linux's uniform 8-byte slots). With today's enum collapsing everything non-Windows/non-Browser into Unix, that check cannot be expressed and IsAppleArm64ABI is effectively hardcoded.
Changes
  • src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.cs — add Apple to the enum.
  • src/coreclr/vm/datadescriptor/datadescriptor.inc — emit CDAC_GLOBAL_STRING(OperatingSystem, Apple) when TARGET_APPLE is defined, before the TARGET_UNIX arm. Follows the existing #ifdef guard pattern.
  • docs/design/datacontracts/RuntimeInfo.md — document the new value and clarify that Apple is still POSIX for != Windows checks.
  • src/native/managed/cdac/tests/DumpTests/RuntimeInfoDumpTests.cs — map dump metadata "osx" to Apple (was Unix); "linux"/"freebsd" stay Unix.
Compatibility
The enum is parsed via Enum.TryParse(ignoreCase: true):
  • Old runtime + new cDAC: old runtimes still emit "Unix" on macOS, so dumps look identical to today.
  • New runtime + old cDAC: old cDACs fail to parse "Apple" and return Unknown; every production check is == Windows / != Windows, which is unaffected.
No RuntimeInfo contract version bump is needed — V1 is defined in terms of parsing, not the specific token set.
Where the enum is used
All usages are inside src/native/managed/cdac; an org-wide GitHub search found no references outside dotnet/runtime and the dotnet/dotnet VMR mirror, and dotnet/diagnostics has zero references.
Definition
  • Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.cs — enum + IRuntimeInfo.GetTargetOperatingSystem().
Production (parser + consumers)
  • Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeInfo_1.cs — Enum.TryParse(ignoreCase: true) of the OperatingSystem global, fallback to Unknown.
  • Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs — != Windows.
  • …/StackWalk/Context/AMD64/AMD64Unwinder.cs (2 sites) — != Windows → _unixAMD64ABI, and a Debug.Assert(... == Windows) on the Windows-only path.
  • …/StackWalk/Context/X86/X86Unwinder.cs — != Windows.
Tests
  • tests/RuntimeInfoTests.cs — theory data auto-generated from the enum; picks up Apple automatically.
  • tests/DumpTests/RuntimeInfoDumpTests.cs — dump-metadata → enum map (updated by this PR).
Call-site audit
All current GetTargetOperatingSystem() consumers compare against Windows, not Unix, so adding Apple changes no runtime behavior:
SiteCheck
AMD64Unwinder.cs:34!= Windows → sets _unixAMD64ABI. Apple x64 is Unix AMD64 ABI ✓
AMD64Unwinder.cs:853Debug.Assert(... == Windows) on Windows path ✓
X86Unwinder.cs:37!= Windows (x86 has no Apple target) ✓
SOSDacImpl.cs:745!= Windows ✓
Follow-up in #126408 will flip IsAppleArm64ABI = os == Unix to os == Apple.
Testing
  • Microsoft.Diagnostics.DataContractReader.Tests — all 1751 tests pass, including the auto-generated "apple" round-trip case in RuntimeInfoTests.GetTargetOperatingSystemTest.
  • Dump test mapping updated so existing macOS dump configs validate against Apple.
  • The native datadescriptor.inc change is a preprocessor-only addition following the existing pattern and is inert on non-Apple builds.
Max Charlamb
[cDAC] Add Apple to RuntimeInfoOperatingSystem
ead6745
Adds a dedicated Apple value to the RuntimeInfoOperatingSystem enum in
IRuntimeInfo so that cDAC consumers can distinguish Apple platforms
(macOS / iOS / tvOS / MacCatalyst) from other Unix targets. The native
data descriptor emits the new Apple string whenever TARGET_APPLE is
defined, which is checked before the generic TARGET_UNIX arm.
This is needed by CallingConventionInfo (see dotnet#127282) to reliably set
IsAppleArm64ABI for Apple ARM64 stack-argument alignment rules, which
differ from Linux ARM64. Existing != Windows callers (unwinders,
SOSDacImpl) continue to behave correctly for Apple targets since Apple
platforms are still POSIX for their purposes.
The enum is parsed with Enum.TryParse(ignoreCase: true), so older
cDACs reading dumps from updated runtimes will simply see Unknown, and
newer cDACs reading dumps from older runtimes will still see Unix (no
behavioral regression). No RuntimeInfo contract version bump is
required.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
April 22, 2026 16:48
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 22, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Apr 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Adds an Apple operating system discriminator to the cDAC RuntimeInfo contract so consumers can reliably distinguish Apple targets (macOS/iOS/tvOS/MacCatalyst) from other Unix platforms.
Changes:
  • Added RuntimeInfoOperatingSystem.Apple to the managed contract enum.
  • Updated the CoreCLR data descriptor to emit OperatingSystem = "Apple" when TARGET_APPLE is defined (checked before TARGET_UNIX).
  • Updated dump-based tests and contract documentation to account for the new OS value.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
FileDescription
src/native/managed/cdac/tests/DumpTests/RuntimeInfoDumpTests.csMaps dump metadata "osx" to the new RuntimeInfoOperatingSystem.Apple.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.csAdds the Apple enum value for RuntimeInfoOperatingSystem.
src/coreclr/vm/datadescriptor/datadescriptor.incEmits OperatingSystem=Apple under TARGET_APPLE before the TARGET_UNIX arm.
docs/design/datacontracts/RuntimeInfo.mdDocuments the new Apple value and intended semantics.
Comment threaddocs/design/datacontracts/RuntimeInfo.md
@max-charlamb
max-charlamb
enabled auto-merge (squash)
April 22, 2026 17:12
@max-charlamb
max-charlamb
commented
Apr 22, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change and cDAC legs pass
@max-charlamb
max-charlamb
merged commit 20f699e
into
dotnet:mainApr 22, 2026

111 of 132 checks passed

@max-charlamb
max-charlamb
deleted the

cdac-runtime-info-apple

branch
April 22, 2026 19:20

This was referenced Apr 22, 2026

Open


Open


Closed


Open


Closed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 23, 2026
 Merged

CopilotAI
mentioned this pull request
Apr 23, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 24, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rcj1rcj1rcj1 approved these changes

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[cDAC] CallingConventionInfo cannot distinguish Apple ARM64 from Linux ARM64


3 participants

@max-charlamb@rcj1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[cDAC] Add Apple to RuntimeInfoOperatingSystem - #127289
Merged
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:cdac-runtime-info-apple
Apr 22, 2026
Merged
[cDAC] Add Apple to RuntimeInfoOperatingSystem#127289
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:cdac-runtime-info-apple
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Note
This PR description was drafted with AI (Copilot CLI) assistance.
Summary
Adds a dedicated Apple value to RuntimeInfoOperatingSystem so the cDAC can distinguish Apple platforms (macOS / iOS / tvOS / MacCatalyst) from other Unix targets. The native data descriptor emits the new Apple string whenever TARGET_APPLE is defined, checked before the generic TARGET_UNIX arm.
Fixes#127282.
Motivation
CallingConventionInfo in #126408 needs to set IsAppleArm64ABI only on Apple platforms, because Apple ARM64 uses different stack-argument alignment than Linux ARM64 (natural alignment for primitives, 4-byte alignment for float HFAs, vs. Linux's uniform 8-byte slots). With today's enum collapsing everything non-Windows/non-Browser into Unix, that check cannot be expressed and IsAppleArm64ABI is effectively hardcoded.
Changes
  • src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.cs — add Apple to the enum.
  • src/coreclr/vm/datadescriptor/datadescriptor.inc — emit CDAC_GLOBAL_STRING(OperatingSystem, Apple) when TARGET_APPLE is defined, before the TARGET_UNIX arm. Follows the existing #ifdef guard pattern.
  • docs/design/datacontracts/RuntimeInfo.md — document the new value and clarify that Apple is still POSIX for != Windows checks.
  • src/native/managed/cdac/tests/DumpTests/RuntimeInfoDumpTests.cs — map dump metadata "osx" to Apple (was Unix); "linux"/"freebsd" stay Unix.
Compatibility
The enum is parsed via Enum.TryParse(ignoreCase: true):
  • Old runtime + new cDAC: old runtimes still emit "Unix" on macOS, so dumps look identical to today.
  • New runtime + old cDAC: old cDACs fail to parse "Apple" and return Unknown; every production check is == Windows / != Windows, which is unaffected.
No RuntimeInfo contract version bump is needed — V1 is defined in terms of parsing, not the specific token set.
Where the enum is used
All usages are inside src/native/managed/cdac; an org-wide GitHub search found no references outside dotnet/runtime and the dotnet/dotnet VMR mirror, and dotnet/diagnostics has zero references.
Definition
  • Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.cs — enum + IRuntimeInfo.GetTargetOperatingSystem().
Production (parser + consumers)
  • Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeInfo_1.cs — Enum.TryParse(ignoreCase: true) of the OperatingSystem global, fallback to Unknown.
  • Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs — != Windows.
  • …/StackWalk/Context/AMD64/AMD64Unwinder.cs (2 sites) — != Windows → _unixAMD64ABI, and a Debug.Assert(... == Windows) on the Windows-only path.
  • …/StackWalk/Context/X86/X86Unwinder.cs — != Windows.
Tests
  • tests/RuntimeInfoTests.cs — theory data auto-generated from the enum; picks up Apple automatically.
  • tests/DumpTests/RuntimeInfoDumpTests.cs — dump-metadata → enum map (updated by this PR).
Call-site audit
All current GetTargetOperatingSystem() consumers compare against Windows, not Unix, so adding Apple changes no runtime behavior:
SiteCheck
AMD64Unwinder.cs:34!= Windows → sets _unixAMD64ABI. Apple x64 is Unix AMD64 ABI ✓
AMD64Unwinder.cs:853Debug.Assert(... == Windows) on Windows path ✓
X86Unwinder.cs:37!= Windows (x86 has no Apple target) ✓
SOSDacImpl.cs:745!= Windows ✓
Follow-up in #126408 will flip IsAppleArm64ABI = os == Unix to os == Apple.
Testing
  • Microsoft.Diagnostics.DataContractReader.Tests — all 1751 tests pass, including the auto-generated "apple" round-trip case in RuntimeInfoTests.GetTargetOperatingSystemTest.
  • Dump test mapping updated so existing macOS dump configs validate against Apple.
  • The native datadescriptor.inc change is a preprocessor-only addition following the existing pattern and is inert on non-Apple builds.
Max Charlamb
[cDAC] Add Apple to RuntimeInfoOperatingSystem
ead6745
Adds a dedicated Apple value to the RuntimeInfoOperatingSystem enum in
IRuntimeInfo so that cDAC consumers can distinguish Apple platforms
(macOS / iOS / tvOS / MacCatalyst) from other Unix targets. The native
data descriptor emits the new Apple string whenever TARGET_APPLE is
defined, which is checked before the generic TARGET_UNIX arm.
This is needed by CallingConventionInfo (see dotnet#127282) to reliably set
IsAppleArm64ABI for Apple ARM64 stack-argument alignment rules, which
differ from Linux ARM64. Existing != Windows callers (unwinders,
SOSDacImpl) continue to behave correctly for Apple targets since Apple
platforms are still POSIX for their purposes.
The enum is parsed with Enum.TryParse(ignoreCase: true), so older
cDACs reading dumps from updated runtimes will simply see Unknown, and
newer cDACs reading dumps from older runtimes will still see Unix (no
behavioral regression). No RuntimeInfo contract version bump is
required.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
April 22, 2026 16:48
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 22, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Apr 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Adds an Apple operating system discriminator to the cDAC RuntimeInfo contract so consumers can reliably distinguish Apple targets (macOS/iOS/tvOS/MacCatalyst) from other Unix platforms.
Changes:
  • Added RuntimeInfoOperatingSystem.Apple to the managed contract enum.
  • Updated the CoreCLR data descriptor to emit OperatingSystem = "Apple" when TARGET_APPLE is defined (checked before TARGET_UNIX).
  • Updated dump-based tests and contract documentation to account for the new OS value.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
FileDescription
src/native/managed/cdac/tests/DumpTests/RuntimeInfoDumpTests.csMaps dump metadata "osx" to the new RuntimeInfoOperatingSystem.Apple.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeInfo.csAdds the Apple enum value for RuntimeInfoOperatingSystem.
src/coreclr/vm/datadescriptor/datadescriptor.incEmits OperatingSystem=Apple under TARGET_APPLE before the TARGET_UNIX arm.
docs/design/datacontracts/RuntimeInfo.mdDocuments the new Apple value and intended semantics.
Comment threaddocs/design/datacontracts/RuntimeInfo.md
@max-charlamb
max-charlamb
enabled auto-merge (squash)
April 22, 2026 17:12
@max-charlamb
max-charlamb
commented
Apr 22, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change and cDAC legs pass
@max-charlamb
max-charlamb
merged commit 20f699e
into
dotnet:mainApr 22, 2026

111 of 132 checks passed

@max-charlamb
max-charlamb
deleted the

cdac-runtime-info-apple

branch
April 22, 2026 19:20

This was referenced Apr 22, 2026

Open


Open


Closed


Open


Closed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 23, 2026
 Merged

CopilotAI
mentioned this pull request
Apr 23, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 24, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rcj1rcj1rcj1 approved these changes

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[cDAC] CallingConventionInfo cannot distinguish Apple ARM64 from Linux ARM64


3 participants

@max-charlamb@rcj1