Restore ExecutionContext from dispatcher instead of from interpreter/JIT'ed code

[jakobbotsch]

Remove RestoreExecutionContext call from JIT resumption code and from the interpreter. Instead encode the ExecutionContext's location in the continuation and let the dispatcher restore it. This removes a TLS access + helper call from the resumption path (avoiding the TLS and inlining the helper call in the dispatcher).

Improves suspension/resumption performance by about 7-8% and is also a good size improvement. Removing the call from the resumption path allows keeping the continuation in a volatile register, which also helps register allocation in a number of cases.

Diffs before JIT-EE GUID update

Micro benchmark with warmup

usingSystem;usingSystem.Diagnostics;usingSystem.Runtime.CompilerServices;usingSystem.Threading;usingSystem.Threading.Tasks;namespaceAsyncMicro;publicclassProgram{staticvoidMain(){NullAwaiterna=newNullAwaiter();for(inti=0;i<10;i++){for(intj=0;j<100;j++){Taskt=Foo(100,na);while(!t.IsCompleted){na.Continue();}}Thread.Sleep(100);}for(inti=0;i<50;i++){Taskt=Foo(10_000_000,na);while(!t.IsCompleted){na.Continue();}}}staticints_value;staticasyncTaskFoo(intn,NullAwaiterna){for(inti=0;i<n;i++){s_value+=i;}Stopwatchtimer=Stopwatch.StartNew();for(inti=0;i<n;i++){awaitna;}if(n>100)Console.WriteLine("Took {0:F1} ms",timer.Elapsed.TotalMilliseconds);}privateclassNullAwaiter:ICriticalNotifyCompletion{publicActionContinue;publicNullAwaiterGetAwaiter()=>this;publicboolIsCompleted=>false;publicvoidGetResult(){}publicvoidUnsafeOnCompleted(Actioncontinuation){Continue=continuation;}publicvoidOnCompleted(Actioncontinuation){thrownewNotImplementedException();}}}

About 7-8% improvement:

-Took 268.5 ms-Took 265.9 ms-Took 267.9 ms-Took 270.0 ms-Took 269.4 ms+Took 249.4 ms+Took 248.3 ms+Took 250.3 ms+Took 249.2 ms+Took 248.9 ms

NativeAOT test sizes

BaseSize	DiffSize	Delta	Percent	Name
31,037,440	30,944,256	-93,184	-0.300%	System.Net.Http.Functional.Tests.exe
16,847,872	16,803,328	-44,544	-0.264%	System.Linq.AsyncEnumerable.Tests.exe
115,269,120	115,089,408	-179,712	-0.156%	System.Text.Json.SourceGeneration.Roslyn4.4.Tests.exe
20,942,336	20,912,640	-29,696	-0.142%	System.Net.Quic.Functional.Tests.exe
20,033,024	20,005,376	-27,648	-0.138%	System.Formats.Tar.Tests.exe
19,558,912	19,533,824	-25,088	-0.128%	System.IO.Compression.Tests.exe
10,055,168	10,042,880	-12,288	-0.122%	System.IO.Compression.ZipFile.Tests.exe
14,901,760	14,883,840	-17,920	-0.120%	System.Xml.Linq.Streaming.Tests.exe
16,778,752	16,758,784	-19,968	-0.119%	System.Xml.Linq.Misc.Tests.exe
28,789,760	28,757,504	-32,256	-0.112%	System.Net.Http.WinHttpHandler.Functional.Tests.exe
16,516,608	16,498,176	-18,432	-0.112%	System.Xml.Linq.Events.Tests.exe
17,065,472	17,046,528	-18,944	-0.111%	System.Xml.Linq.xNodeBuilder.Tests.exe
22,732,800	22,708,224	-24,576	-0.108%	System.Net.Sockets.Tests.exe
16,671,744	16,653,824	-17,920	-0.107%	System.Xml.Linq.Properties.Tests.exe
17,123,840	17,105,920	-17,920	-0.105%	System.Xml.Linq.TreeManipulation.Tests.exe
17,007,616	16,989,696	-17,920	-0.105%	System.Xml.Linq.xNodeReader.Tests.exe
20,003,840	19,982,848	-20,992	-0.105%	System.Net.WebSockets.Client.Tests.exe
19,053,056	19,034,112	-18,944	-0.099%	System.Net.HttpListener.Tests.exe
10,660,864	10,650,624	-10,240	-0.096%	System.IO.Pipelines.Tests.exe
20,267,008	20,248,064	-18,944	-0.093%	System.Threading.Tasks.Dataflow.Tests.exe
17,728,512	17,713,664	-14,848	-0.084%	System.Threading.Tasks.Extensions.Tests.exe
14,569,472	14,557,696	-11,776	-0.081%	System.Net.WebClient.Tests.exe
11,992,064	11,982,336	-9,728	-0.081%	System.IO.Tests.exe
21,089,792	21,072,896	-16,896	-0.080%	System.Net.Requests.Tests.exe
21,708,800	21,691,392	-17,408	-0.080%	System.IO.FileSystem.Tests.exe
10,278,912	10,270,720	-8,192	-0.080%	System.Threading.Channels.Tests.exe
27,894,272	27,874,304	-19,968	-0.072%	System.Net.Security.Tests.exe
18,447,872	18,434,560	-13,312	-0.072%	System.Threading.Tasks.Parallel.Tests.exe
13,242,368	13,233,152	-9,216	-0.070%	System.IO.Packaging.Tests.exe
9,731,072	9,724,416	-6,656	-0.068%	System.Threading.RateLimiting.Tests.exe
33,165,312	33,142,784	-22,528	-0.068%	System.Private.Xml.Tests.exe
13,869,056	13,859,840	-9,216	-0.066%	Microsoft.Extensions.Configuration.Functional.Tests.exe
19,545,600	19,532,800	-12,800	-0.065%	System.Diagnostics.Process.Tests.exe
12,849,664	12,841,472	-8,192	-0.064%	System.Xml.Schema.Extensions.Tests.exe
12,416,000	12,408,320	-7,680	-0.062%	System.Xml.Linq.SDMSample.Tests.exe
17,431,552	17,420,800	-10,752	-0.062%	System.Net.Ping.Functional.Tests.exe
20,540,416	20,527,616	-12,800	-0.062%	System.Threading.Tasks.Tests.exe
15,759,872	15,750,144	-9,728	-0.062%	System.Windows.Extensions.Tests.exe
10,056,192	10,050,048	-6,144	-0.061%	System.Net.ServerSentEvents.Tests.exe
15,102,464	15,093,248	-9,216	-0.061%	System.Drawing.Primitives.Tests.exe
17,571,840	17,561,088	-10,752	-0.061%	MetricOuterLoop1.Tests.exe
17,566,720	17,555,968	-10,752	-0.061%	MetricOuterLoop.Tests.exe
19,289,600	19,277,824	-11,776	-0.061%	System.IO.Pipes.Tests.exe
17,791,488	17,780,736	-10,752	-0.060%	System.Formats.Tar.Manual.Tests.exe
17,967,616	17,956,864	-10,752	-0.060%	System.Threading.ThreadPool.WindowsThreadPool.Tests.exe
17,329,152	17,318,912	-10,240	-0.059%	System.Threading.Timer.Tests.exe
14,130,176	14,121,984	-8,192	-0.058%	System.DirectoryServices.Protocols.Tests.exe
17,616,896	17,606,656	-10,240	-0.058%	System.Threading.Thread.Tests.exe
19,681,792	19,670,528	-11,264	-0.057%	System.Net.Http.Unit.Tests.exe
17,160,192	17,150,464	-9,728	-0.057%	System.Runtime.Serialization.Formatters.Disabled.Tests.exe
17,967,104	17,956,864	-10,240	-0.057%	System.Threading.ThreadPool.Tests.exe
19,870,720	19,859,456	-11,264	-0.057%	System.Text.Encoding.Tests.exe
18,774,016	18,763,264	-10,752	-0.057%	Microsoft.Extensions.FileProviders.Physical.Tests.exe
27,160,064	27,144,704	-15,360	-0.057%	Microsoft.Extensions.Hosting.Unit.Tests.exe
17,214,976	17,205,248	-9,728	-0.057%	System.Net.ServicePoint.Tests.exe
17,312,768	17,303,040	-9,728	-0.056%	System.Security.Principal.Windows.Tests.exe
17,230,848	17,221,120	-9,728	-0.056%	System.ComponentModel.EventBasedAsync.Tests.exe
18,128,896	18,118,656	-10,240	-0.056%	System.Diagnostics.TextWriterTraceListener.Tests.exe
17,298,944	17,289,216	-9,728	-0.056%	System.Security.Claims.Tests.exe
17,431,040	17,421,312	-9,728	-0.056%	System.Diagnostics.TraceSource.Tests.exe
17,282,048	17,272,320	-9,728	-0.056%	System.Threading.Overlapped.Tests.exe
18,177,536	18,167,296	-10,240	-0.056%	System.Text.Encoding.CodePages.Tests.exe
17,356,288	17,346,560	-9,728	-0.056%	Microsoft.Win32.SystemEvents.Tests.exe
18,586,624	18,576,384	-10,240	-0.055%	ComInterfaceGenerator.Tests.exe
17,661,440	17,651,712	-9,728	-0.055%	System.IO.FileSystem.Watcher.Tests.exe
9,251,840	9,246,720	-5,120	-0.055%	Microsoft.Bcl.AsyncInterfaces.Tests.exe
13,941,248	13,933,568	-7,680	-0.055%	Microsoft.Extensions.Configuration.Xml.Tests.exe
18,492,928	18,482,688	-10,240	-0.055%	Microsoft.Extensions.Configuration.Tests.exe
17,662,976	17,653,248	-9,728	-0.055%	System.Buffers.Tests.exe
18,489,344	18,479,104	-10,240	-0.055%	Microsoft.Extensions.Hosting.Systemd.Tests.exe
15,080,448	15,072,256	-8,192	-0.054%	System.Security.Cryptography.Cng.Tests.exe
17,154,048	17,144,832	-9,216	-0.054%	IcuAppLocal.Tests.exe
15,039,488	15,031,296	-8,192	-0.054%	System.Data.DataSetExtensions.Tests.exe
18,062,336	18,052,608	-9,728	-0.054%	System.Console.Tests.exe
17,288,192	17,278,976	-9,216	-0.053%	System.Runtime.InteropServices.RuntimeInformation.Tests.exe
17,361,408	17,352,192	-9,216	-0.053%	System.Diagnostics.StackTrace.Tests.exe
18,455,552	18,445,824	-9,728	-0.053%	Microsoft.Extensions.Configuration.FileExtensions.Tests.exe
17,235,968	17,226,752	-9,216	-0.053%	System.Runtime.InvariantTimezone.Tests.exe
18,518,016	18,508,288	-9,728	-0.053%	System.IO.MemoryMappedFiles.Tests.exe
18,693,632	18,683,904	-9,728	-0.052%	Microsoft.Extensions.Logging.Console.Tests.exe
18,032,128	18,022,912	-9,216	-0.051%	Microsoft.Extensions.Diagnostics.Tests.exe
16,107,008	16,098,816	-8,192	-0.051%	System.Data.Odbc.Tests.exe
24,284,672	24,272,384	-12,288	-0.051%	Microsoft.Extensions.Http.Tests.exe
20,532,736	20,522,496	-10,240	-0.050%	System.Runtime.Extensions.Tests.exe
18,371,584	18,362,368	-9,216	-0.050%	System.Threading.Tests.exe
18,356,736	18,347,520	-9,216	-0.050%	Microsoft.Extensions.FileProviders.Composite.Tests.exe
18,381,824	18,372,608	-9,216	-0.050%	Microsoft.Extensions.Primitives.Tests.exe
11,331,072	11,325,440	-5,632	-0.050%	System.Net.WebSockets.Tests.exe
19,295,744	19,286,016	-9,728	-0.050%	System.Net.Primitives.Functional.Tests.exe
19,972,608	19,962,880	-9,728	-0.049%	Microsoft.Extensions.Logging.Tests.exe
11,588,096	11,582,464	-5,632	-0.049%	System.Net.Http.Json.Unit.Tests.exe
19,744,768	19,735,040	-9,728	-0.049%	System.Resources.ResourceManager.Tests.exe
9,334,784	9,330,176	-4,608	-0.049%	Microsoft.Extensions.Diagnostics.Abstractions.Tests.exe
18,833,920	18,824,704	-9,216	-0.049%	System.Runtime.Caching.Tests.exe
19,080,192	19,070,976	-9,216	-0.048%	Microsoft.Extensions.Hosting.WindowsServices.Tests.exe
9,660,416	9,655,808	-4,608	-0.048%	Microsoft.Extensions.Hosting.Functional.Tests.exe
20,475,904	20,466,176	-9,728	-0.048%	System.Diagnostics.DiagnosticSource.Tests.exe
20,741,632	20,731,904	-9,728	-0.047%	System.Collections.Concurrent.Tests.exe
10,106,368	10,101,760	-4,608	-0.046%	Microsoft.Extensions.Caching.Memory.Tests.exe
20,234,752	20,225,536	-9,216	-0.046%	System.Runtime.InteropServices.Tests.exe
20,454,912	20,445,696	-9,216	-0.045%	System.Reflection.Tests.exe
19,486,208	19,477,504	-8,704	-0.045%	Microsoft.Extensions.Configuration.UserSecrets.Tests.exe
11,274,240	11,269,120	-5,120	-0.045%	System.IO.Compression.Brotli.Tests.exe
19,555,840	19,547,136	-8,704	-0.045%	Microsoft.Extensions.Configuration.Json.Tests.exe
23,405,056	23,394,816	-10,240	-0.044%	System.Memory.Tests.exe
25,891,328	25,880,064	-11,264	-0.044%	System.Text.Json.SourceGeneration.Roslyn3.11.Tests.exe
10,510,336	10,505,728	-4,608	-0.044%	Microsoft.Extensions.Options.Tests.exe
9,442,816	9,438,720	-4,096	-0.043%	Microsoft.Extensions.Logging.Testing.Tests.exe
26,440,704	26,429,440	-11,264	-0.043%	System.ComponentModel.TypeConverter.Tests.exe
21,622,784	21,613,568	-9,216	-0.043%	System.Data.OleDb.Tests.exe
26,006,528	25,996,288	-10,240	-0.039%	System.Globalization.Nls.Tests.exe
20,808,704	20,801,024	-7,680	-0.037%	System.Security.Cryptography.Csp.Tests.exe
29,403,136	29,392,384	-10,752	-0.037%	Microsoft.Extensions.DependencyModel.Tests.exe
26,095,616	26,085,888	-9,728	-0.037%	System.Globalization.Tests.exe
21,072,384	21,064,704	-7,680	-0.036%	Microsoft.Extensions.Logging.EventSource.Tests.exe
45,486,080	45,470,208	-15,872	-0.035%	System.Security.Cryptography.Tests.exe
32,739,840	32,730,112	-9,728	-0.030%	System.Linq.Expressions.Tests.exe
33,385,984	33,376,256	-9,728	-0.029%	Microsoft.Bcl.Cryptography.Tests.exe
44,704,768	44,693,504	-11,264	-0.025%	System.Runtime.Tests.exe
2,233,344	2,232,832	-512	-0.023%	clrjit.dll
10,494,464	10,492,928	-1,536	-0.015%	System.Net.Http.WinHttpHandler.Unit.Tests.exe
10,586,112	10,584,576	-1,536	-0.015%	Common.Tests.exe
9,026,048	9,025,024	-1,024	-0.011%	Microsoft.Extensions.FileSystemGlobbing.Tests.exe
9,347,584	9,346,560	-1,024	-0.011%	System.Security.Permissions.Tests.exe
9,612,800	9,611,776	-1,024	-0.011%	System.Diagnostics.EventLog.Tests.exe
12,185,088	12,184,064	-1,024	-0.008%	System.Net.NetworkInformation.Functional.Tests.exe
15,386,112	15,385,088	-1,024	-0.007%	System.Globalization.Extensions.Nls.Tests.exe
15,386,112	15,385,088	-1,024	-0.007%	System.Globalization.Extensions.Tests.exe
8,743,936	8,743,424	-512	-0.006%	Invariant.Tests.exe
8,975,872	8,975,360	-512	-0.006%	System.Net.Primitives.Pal.Tests.exe
8,798,208	8,797,696	-512	-0.006%	System.Resources.Reader.Tests.exe
8,667,136	8,666,624	-512	-0.006%	System.Runtime.CompilerServices.Unsafe.Tests.exe
8,916,480	8,915,968	-512	-0.006%	System.IO.Pipes.AccessControl.Tests.exe
9,027,072	9,026,560	-512	-0.006%	System.Net.NameResolution.Pal.Tests.exe
9,191,936	9,191,424	-512	-0.006%	Microsoft.Extensions.Configuration.EnvironmentVariables.Tests.exe
8,763,904	8,763,392	-512	-0.006%	Microsoft.Bcl.TimeProvider.Tests.exe
8,609,792	8,609,280	-512	-0.006%	System.Composition.Runtime.Tests.exe
9,129,472	9,128,960	-512	-0.006%	System.Security.AccessControl.Tests.exe
8,803,328	8,802,816	-512	-0.006%	System.Web.HttpUtility.Tests.exe
9,041,920	9,041,408	-512	-0.006%	Microsoft.Extensions.Configuration.CommandLine.Tests.exe
8,638,464	8,637,952	-512	-0.006%	System.Globalization.CalendarsWithConfigSwitch.Tests.exe
8,533,504	8,532,992	-512	-0.006%	System.ComponentModel.Tests.exe
8,686,592	8,686,080	-512	-0.006%	System.Security.Cryptography.ProtectedData.Tests.exe
8,755,712	8,755,200	-512	-0.006%	System.IO.FileSystem.DriveInfo.Tests.exe
8,977,408	8,976,896	-512	-0.006%	Microsoft.Win32.Registry.Tests.exe
8,685,568	8,685,056	-512	-0.006%	System.IO.FileSystem.Manual.Tests.exe
9,095,680	9,095,168	-512	-0.006%	System.IO.FileSystem.AccessControl.Tests.exe
10,048,512	10,048,000	-512	-0.005%	System.Diagnostics.Debug.Tests.exe
11,179,520	11,179,008	-512	-0.005%	System.Text.Encodings.Web.Tests.exe
11,034,112	11,033,600	-512	-0.005%	System.Runtime.Numerics.Tests.exe
11,363,328	11,362,816	-512	-0.005%	System.Net.Security.Unit.Tests.exe
9,337,344	9,336,832	-512	-0.005%	System.IO.IsolatedStorage.Tests.exe
9,748,992	9,749,504	+512	+0.005%	System.Formats.Asn1.Tests.exe
9,473,536	9,473,024	-512	-0.005%	Microsoft.Extensions.Configuration.Ini.Tests.exe
10,936,320	10,935,808	-512	-0.005%	System.Runtime.Intrinsics.Tests.exe
9,571,328	9,570,816	-512	-0.005%	System.Memory.Data.Tests.exe
9,660,928	9,660,416	-512	-0.005%	System.IO.UnmanagedMemoryStream.Tests.exe
9,524,736	9,524,224	-512	-0.005%	System.IO.Hashing.Tests.exe
9,361,920	9,361,408	-512	-0.005%	System.Net.Mail.Unit.Tests.exe
11,590,144	11,589,632	-512	-0.004%	System.Resources.Extensions.Tests.exe
11,469,312	11,468,800	-512	-0.004%	System.IO.Ports.Tests.exe
11,779,072	11,778,560	-512	-0.004%	System.Security.Cryptography.Cose.Tests.exe
17,824,768	17,824,256	-512	-0.003%	System.Collections.Tests.exe
18,770,432	18,770,944	+512	+0.003%	System.Numerics.Vectors.Tests.exe
22,320,640	22,320,128	-512	-0.002%	System.Security.Cryptography.Pkcs.Tests.exe
8,988,672	8,988,672	0	0.000%	System.Runtime.Serialization.Primitives.Tests.exe
8,690,176	8,690,176	0	0.000%	System.Security.SecureString.Tests.exe
9,201,664	9,201,664	0	0.000%	System.ServiceProcess.ServiceController.Tests.exe
7,318,016	7,318,016	0	0.000%	XUnitLogChecker.exe
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
84,480	84,480	0	0.000%	System.Globalization.Native.dll
108,032	108,032	0	0.000%	CMakeCXXCompilerId.exe
108,032	108,032	0	0.000%	CMakeCCompilerId.exe
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
8,673,280	8,673,280	0	0.000%	System.Runtime.InteropServices.ComDisabled.Tests.exe
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
8,608,768	8,608,768	0	0.000%	System.Xml.Linq.Axes.Tests.exe
9,069,056	9,069,056	0	0.000%	System.ValueTuple.Tests.exe
8,945,152	8,945,152	0	0.000%	System.Threading.AccessControl.Tests.exe
9,690,112	9,690,112	0	0.000%	System.Text.RegularExpressions.Unit.Tests.exe
8,543,232	8,543,232	0	0.000%	System.Text.Encoding.Extensions.Tests.exe
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
536,096	536,096	0	0.000%	msquic.dll
8,529,408	8,529,408	0	0.000%	System.IO.FileSystem.Primitives.Tests.exe
8,532,480	8,532,480	0	0.000%	System.Runtime.CompilerServices.VisualC.Tests.exe
536,096	536,096	0	0.000%	msquic.dll
1,308,672	1,308,672	0	0.000%	mscordbi.dll
1,501,696	1,501,696	0	0.000%	mscordaccore.dll
1,501,696	1,501,696	0	0.000%	mscordaccore_amd64_amd64_42.42.42.42424.dll
361,984	361,984	0	0.000%	hostpolicy.dll
350,208	350,208	0	0.000%	hostfxr.dll
62,464	62,464	0	0.000%	createdump.exe
210,944	210,944	0	0.000%	corerun.exe
4,955,648	4,955,648	0	0.000%	coreclr.dll
722,944	722,944	0	0.000%	clrgcexp.dll
678,400	678,400	0	0.000%	clrgc.dll
307,200	307,200	0	0.000%	clretwrc.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
84,480	84,480	0	0.000%	System.Globalization.Native.dll
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
696,320	696,320	0	0.000%	FileCheck.exe
9,956,352	9,956,352	0	0.000%	llvm-mca.exe
13,419,520	13,419,520	0	0.000%	crossgen2.exe
7,703,040	7,703,040	0	0.000%	ilasm.exe
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
15,940,096	15,940,096	0	0.000%	ilc.exe
8,938,496	8,938,496	0	0.000%	Microsoft.Bcl.Memory.Tests.exe
8,578,048	8,578,048	0	0.000%	Microsoft.Bcl.Numerics.Tests.exe
8,587,264	8,587,264	0	0.000%	Microsoft.Extensions.Hosting.Abstractions.Tests.exe
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
9,947,648	9,947,648	0	0.000%	LibraryImportGenerator.Tests.exe
8,655,872	8,655,872	0	0.000%	System.Runtime.Handles.Tests.exe
16,973,824	16,973,824	0	0.000%	System.Private.CoreLib.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
8,591,360	8,591,360	0	0.000%	System.Resources.Writer.Tests.exe
9,011,200	9,011,200	0	0.000%	System.Reflection.TypeExtensions.Tests.exe
12,271,104	12,271,104	0	0.000%	System.Reflection.Metadata.Tests.exe
8,849,920	8,849,920	0	0.000%	System.Reflection.Extensions.Tests.exe
9,350,656	9,350,656	0	0.000%	System.Reflection.Context.Tests.exe
8,704,512	8,704,512	0	0.000%	System.Private.Uri.Unit.Tests.exe
9,631,744	9,631,744	0	0.000%	System.Private.Uri.Functional.Tests.exe
9,785,856	9,785,856	0	0.000%	System.Net.WebProxy.Tests.exe
8,627,200	8,627,200	0	0.000%	System.Net.WebHeaderCollection.Tests.exe
9,300,992	9,300,992	0	0.000%	System.Net.Primitives.UnitTests.Tests.exe
15,486,976	15,486,976	0	0.000%	System.Linq.Tests.exe
696,320	696,320	0	0.000%	FileCheck.exe
9,150,976	9,150,976	0	0.000%	System.Globalization.Calendars.Tests.exe
9,837,568	9,837,568	0	0.000%	System.Formats.Nrbf.Tests.exe
8,534,528	8,534,528	0	0.000%	System.Diagnostics.Tools.Tests.exe
8,702,464	8,702,464	0	0.000%	System.Diagnostics.FileVersionInfo.Tests.exe
8,547,840	8,547,840	0	0.000%	System.Diagnostics.Contracts.Tests.exe
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
8,649,216	8,649,216	0	0.000%	Microsoft.Win32.Primitives.Tests.exe
9,934,336	9,934,336	0	0.000%	System.Collections.NonGeneric.Tests.exe
9,734,656	9,734,656	0	0.000%	System.Collections.Specialized.Tests.exe
9,147,392	9,147,392	0	0.000%	System.ComponentModel.Primitives.Tests.exe
8,544,768	8,544,768	0	0.000%	System.Composition.AttributeModel.Tests.exe
9,615,872	9,615,872	0	0.000%	System.Composition.Convention.Tests.exe
8,821,760	8,821,760	0	0.000%	System.Console.Manual.Tests.exe
8,632,832	8,632,832	0	0.000%	Microsoft.Win32.Registry.AccessControl.Tests.exe
9,956,352	9,956,352	0	0.000%	llvm-mca.exe

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR changes CoreCLR runtime-async suspension/resumption so the dispatcher (managed AsyncHelpers) restores ExecutionContext, instead of having interpreter/JIT resumption stubs call a restore helper. The continuation’s flags now encode the ExecutionContext storage slot, enabling the dispatcher to restore without an extra TLS lookup + helper call on the hot resumption path.

Changes:

• Add continuation support for locating/storing the ExecutionContext via encoded indices in continuation flags (VM + managed + JIT + interpreter).
• Remove RestoreExecutionContext calls from interpreter and JIT resumption code; add restoration to the dispatcher loop.
• Preserve BBF_ASYNC_RESUMPTION across certain flow optimizations that may bypass resumption stubs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/object.h	Adds VM helper to locate ExecutionContext storage in a continuation via encoded flag bits.
src/coreclr/vm/interpexec.cpp	Writes captured ExecutionContext via the encoded slot; removes interpreter-side restore on resume.
src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs	Moves ExecutionContext restore into dispatcher; adjusts flag layout and RestoreExecutionContext signature to avoid TLS lookup.
src/coreclr/jit/fgopt.cpp	Copies BBF_ASYNC_RESUMPTION during certain jump/switch/flow optimizations to preserve async side-entry affordances.
src/coreclr/jit/async.cpp	Updates continuation layout/flag encoding for ExecutionContext; removes JIT-side restore on resumption.
src/coreclr/interpreter/inc/interpretershared.h	Removes interpreter suspend-data field that stored a raw execution-context offset.
src/coreclr/interpreter/compiler.cpp	Encodes ExecutionContext slot in flags and updates interpreter continuation layout accordingly.
src/coreclr/inc/corinfo.h	Updates CorInfoContinuationFlags bit assignments to include ExecutionContext index encoding.

Comments suppressed due to low confidence (2)

src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs:554

• RuntimeAsyncStackState contains managed reference fields, but this local is left uninitialized before its address is stored in TLS (awaitState.Push(&stackState)). This can expose garbage references to the GC (and Push only initializes a subset of fields), risking GC crashes/corruption. Initialize stackState to default (or otherwise fully clear all reference fields before any GC safepoint) before calling Push.

 RuntimeAsyncStackState stackState;
ref RuntimeAsyncAwaitState awaitState = ref t_runtimeAsyncAwaitState;
awaitState.Push(&stackState);

src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs:655

• Same issue as in DispatchContinuations: RuntimeAsyncStackState stackState; is uninitialized even though the struct contains managed references and its address is pushed into TLS via awaitState.Push(&stackState). This can leave garbage object references visible to the GC until fields are explicitly set. Ensure stackState is zero-initialized (e.g., = default) or otherwise cleared before pushing.

 RuntimeAsyncStackState stackState;
ref RuntimeAsyncAwaitState awaitState = ref t_runtimeAsyncAwaitState;
awaitState.Push(&stackState);

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/coreclr/interpreter/compiler.cpp:6007

• InterpAsyncSuspendData.restoreExecutionContextMethod is still populated, but after removing the interpreter-side RestoreExecutionContext call there don’t appear to be any remaining reads of this field. Consider removing the field from InterpAsyncSuspendData (and this assignment) to reduce per-suspension metadata size and avoid dead state.

 suspendData->keepAliveOffset = keepAliveOffset + OFFSETOF__CORINFO_Continuation__data;
suspendData->captureSyncContextMethod = asyncInfo.captureContinuationContextMethHnd;
suspendData->restoreExecutionContextMethod = asyncInfo.restoreExecutionContextMethHnd;
suspendData->restoreContextsOnSuspensionMethod = asyncInfo.restoreContextsOnSuspensionMethHnd;

[Copilot]

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

src/coreclr/interpreter/compiler.cpp:6007

• CORINFO_ASYNC_INFO no longer exposes restoreExecutionContextMethHnd, but the interpreter still stores asyncInfo.restoreExecutionContextMethHnd into InterpAsyncSuspendData. This will fail to compile and should be removed/rewired now that execution context restoration is done by the dispatcher.

 suspendData->keepAliveOffset = keepAliveOffset + OFFSETOF__CORINFO_Continuation__data;
suspendData->captureSyncContextMethod = asyncInfo.captureContinuationContextMethHnd;
suspendData->restoreExecutionContextMethod = asyncInfo.restoreExecutionContextMethHnd;
suspendData->restoreContextsOnSuspensionMethod = asyncInfo.restoreContextsOnSuspensionMethHnd;

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

[jakobbotsch]

PTAL @VSadov (async) @AndyAyersMS (JIT) @davidwrighton /@janvorli (interpreter)

[AndyAyersMS]

JIT changes look good.

[VSadov]

LGTM. Thanks!

[jakobbotsch]

Will merge this, @janvorli@davidwrighton let me know if you have any comments on the interpreter change and I can address it in a follow-up.

[jakobbotsch]

Remove RestoreExecutionContext call from JIT resumption code and from the interpreter. Instead encode the ExecutionContext's location in the continuation and let the dispatcher restore it. This removes a TLS access + helper call from the resumption path (avoiding the TLS and inlining the helper call in the dispatcher).

Improves suspension/resumption performance by about 7-8% and is also a good size improvement. Removing the call from the resumption path allows keeping the continuation in a volatile register, which also helps register allocation in a number of cases.

Diffs before JIT-EE GUID update

Micro benchmark with warmup

usingSystem;usingSystem.Diagnostics;usingSystem.Runtime.CompilerServices;usingSystem.Threading;usingSystem.Threading.Tasks;namespaceAsyncMicro;publicclassProgram{staticvoidMain(){NullAwaiterna=newNullAwaiter();for(inti=0;i<10;i++){for(intj=0;j<100;j++){Taskt=Foo(100,na);while(!t.IsCompleted){na.Continue();}}Thread.Sleep(100);}for(inti=0;i<50;i++){Taskt=Foo(10_000_000,na);while(!t.IsCompleted){na.Continue();}}}staticints_value;staticasyncTaskFoo(intn,NullAwaiterna){for(inti=0;i<n;i++){s_value+=i;}Stopwatchtimer=Stopwatch.StartNew();for(inti=0;i<n;i++){awaitna;}if(n>100)Console.WriteLine("Took {0:F1} ms",timer.Elapsed.TotalMilliseconds);}privateclassNullAwaiter:ICriticalNotifyCompletion{publicActionContinue;publicNullAwaiterGetAwaiter()=>this;publicboolIsCompleted=>false;publicvoidGetResult(){}publicvoidUnsafeOnCompleted(Actioncontinuation){Continue=continuation;}publicvoidOnCompleted(Actioncontinuation){thrownewNotImplementedException();}}}

About 7-8% improvement:

-Took 268.5 ms-Took 265.9 ms-Took 267.9 ms-Took 270.0 ms-Took 269.4 ms+Took 249.4 ms+Took 248.3 ms+Took 250.3 ms+Took 249.2 ms+Took 248.9 ms

NativeAOT test sizes

BaseSize	DiffSize	Delta	Percent	Name
31,037,440	30,944,256	-93,184	-0.300%	System.Net.Http.Functional.Tests.exe
16,847,872	16,803,328	-44,544	-0.264%	System.Linq.AsyncEnumerable.Tests.exe
115,269,120	115,089,408	-179,712	-0.156%	System.Text.Json.SourceGeneration.Roslyn4.4.Tests.exe
20,942,336	20,912,640	-29,696	-0.142%	System.Net.Quic.Functional.Tests.exe
20,033,024	20,005,376	-27,648	-0.138%	System.Formats.Tar.Tests.exe
19,558,912	19,533,824	-25,088	-0.128%	System.IO.Compression.Tests.exe
10,055,168	10,042,880	-12,288	-0.122%	System.IO.Compression.ZipFile.Tests.exe
14,901,760	14,883,840	-17,920	-0.120%	System.Xml.Linq.Streaming.Tests.exe
16,778,752	16,758,784	-19,968	-0.119%	System.Xml.Linq.Misc.Tests.exe
28,789,760	28,757,504	-32,256	-0.112%	System.Net.Http.WinHttpHandler.Functional.Tests.exe
16,516,608	16,498,176	-18,432	-0.112%	System.Xml.Linq.Events.Tests.exe
17,065,472	17,046,528	-18,944	-0.111%	System.Xml.Linq.xNodeBuilder.Tests.exe
22,732,800	22,708,224	-24,576	-0.108%	System.Net.Sockets.Tests.exe
16,671,744	16,653,824	-17,920	-0.107%	System.Xml.Linq.Properties.Tests.exe
17,123,840	17,105,920	-17,920	-0.105%	System.Xml.Linq.TreeManipulation.Tests.exe
17,007,616	16,989,696	-17,920	-0.105%	System.Xml.Linq.xNodeReader.Tests.exe
20,003,840	19,982,848	-20,992	-0.105%	System.Net.WebSockets.Client.Tests.exe
19,053,056	19,034,112	-18,944	-0.099%	System.Net.HttpListener.Tests.exe
10,660,864	10,650,624	-10,240	-0.096%	System.IO.Pipelines.Tests.exe
20,267,008	20,248,064	-18,944	-0.093%	System.Threading.Tasks.Dataflow.Tests.exe
17,728,512	17,713,664	-14,848	-0.084%	System.Threading.Tasks.Extensions.Tests.exe
14,569,472	14,557,696	-11,776	-0.081%	System.Net.WebClient.Tests.exe
11,992,064	11,982,336	-9,728	-0.081%	System.IO.Tests.exe
21,089,792	21,072,896	-16,896	-0.080%	System.Net.Requests.Tests.exe
21,708,800	21,691,392	-17,408	-0.080%	System.IO.FileSystem.Tests.exe
10,278,912	10,270,720	-8,192	-0.080%	System.Threading.Channels.Tests.exe
27,894,272	27,874,304	-19,968	-0.072%	System.Net.Security.Tests.exe
18,447,872	18,434,560	-13,312	-0.072%	System.Threading.Tasks.Parallel.Tests.exe
13,242,368	13,233,152	-9,216	-0.070%	System.IO.Packaging.Tests.exe
9,731,072	9,724,416	-6,656	-0.068%	System.Threading.RateLimiting.Tests.exe
33,165,312	33,142,784	-22,528	-0.068%	System.Private.Xml.Tests.exe
13,869,056	13,859,840	-9,216	-0.066%	Microsoft.Extensions.Configuration.Functional.Tests.exe
19,545,600	19,532,800	-12,800	-0.065%	System.Diagnostics.Process.Tests.exe
12,849,664	12,841,472	-8,192	-0.064%	System.Xml.Schema.Extensions.Tests.exe
12,416,000	12,408,320	-7,680	-0.062%	System.Xml.Linq.SDMSample.Tests.exe
17,431,552	17,420,800	-10,752	-0.062%	System.Net.Ping.Functional.Tests.exe
20,540,416	20,527,616	-12,800	-0.062%	System.Threading.Tasks.Tests.exe
15,759,872	15,750,144	-9,728	-0.062%	System.Windows.Extensions.Tests.exe
10,056,192	10,050,048	-6,144	-0.061%	System.Net.ServerSentEvents.Tests.exe
15,102,464	15,093,248	-9,216	-0.061%	System.Drawing.Primitives.Tests.exe
17,571,840	17,561,088	-10,752	-0.061%	MetricOuterLoop1.Tests.exe
17,566,720	17,555,968	-10,752	-0.061%	MetricOuterLoop.Tests.exe
19,289,600	19,277,824	-11,776	-0.061%	System.IO.Pipes.Tests.exe
17,791,488	17,780,736	-10,752	-0.060%	System.Formats.Tar.Manual.Tests.exe
17,967,616	17,956,864	-10,752	-0.060%	System.Threading.ThreadPool.WindowsThreadPool.Tests.exe
17,329,152	17,318,912	-10,240	-0.059%	System.Threading.Timer.Tests.exe
14,130,176	14,121,984	-8,192	-0.058%	System.DirectoryServices.Protocols.Tests.exe
17,616,896	17,606,656	-10,240	-0.058%	System.Threading.Thread.Tests.exe
19,681,792	19,670,528	-11,264	-0.057%	System.Net.Http.Unit.Tests.exe
17,160,192	17,150,464	-9,728	-0.057%	System.Runtime.Serialization.Formatters.Disabled.Tests.exe
17,967,104	17,956,864	-10,240	-0.057%	System.Threading.ThreadPool.Tests.exe
19,870,720	19,859,456	-11,264	-0.057%	System.Text.Encoding.Tests.exe
18,774,016	18,763,264	-10,752	-0.057%	Microsoft.Extensions.FileProviders.Physical.Tests.exe
27,160,064	27,144,704	-15,360	-0.057%	Microsoft.Extensions.Hosting.Unit.Tests.exe
17,214,976	17,205,248	-9,728	-0.057%	System.Net.ServicePoint.Tests.exe
17,312,768	17,303,040	-9,728	-0.056%	System.Security.Principal.Windows.Tests.exe
17,230,848	17,221,120	-9,728	-0.056%	System.ComponentModel.EventBasedAsync.Tests.exe
18,128,896	18,118,656	-10,240	-0.056%	System.Diagnostics.TextWriterTraceListener.Tests.exe
17,298,944	17,289,216	-9,728	-0.056%	System.Security.Claims.Tests.exe
17,431,040	17,421,312	-9,728	-0.056%	System.Diagnostics.TraceSource.Tests.exe
17,282,048	17,272,320	-9,728	-0.056%	System.Threading.Overlapped.Tests.exe
18,177,536	18,167,296	-10,240	-0.056%	System.Text.Encoding.CodePages.Tests.exe
17,356,288	17,346,560	-9,728	-0.056%	Microsoft.Win32.SystemEvents.Tests.exe
18,586,624	18,576,384	-10,240	-0.055%	ComInterfaceGenerator.Tests.exe
17,661,440	17,651,712	-9,728	-0.055%	System.IO.FileSystem.Watcher.Tests.exe
9,251,840	9,246,720	-5,120	-0.055%	Microsoft.Bcl.AsyncInterfaces.Tests.exe
13,941,248	13,933,568	-7,680	-0.055%	Microsoft.Extensions.Configuration.Xml.Tests.exe
18,492,928	18,482,688	-10,240	-0.055%	Microsoft.Extensions.Configuration.Tests.exe
17,662,976	17,653,248	-9,728	-0.055%	System.Buffers.Tests.exe
18,489,344	18,479,104	-10,240	-0.055%	Microsoft.Extensions.Hosting.Systemd.Tests.exe
15,080,448	15,072,256	-8,192	-0.054%	System.Security.Cryptography.Cng.Tests.exe
17,154,048	17,144,832	-9,216	-0.054%	IcuAppLocal.Tests.exe
15,039,488	15,031,296	-8,192	-0.054%	System.Data.DataSetExtensions.Tests.exe
18,062,336	18,052,608	-9,728	-0.054%	System.Console.Tests.exe
17,288,192	17,278,976	-9,216	-0.053%	System.Runtime.InteropServices.RuntimeInformation.Tests.exe
17,361,408	17,352,192	-9,216	-0.053%	System.Diagnostics.StackTrace.Tests.exe
18,455,552	18,445,824	-9,728	-0.053%	Microsoft.Extensions.Configuration.FileExtensions.Tests.exe
17,235,968	17,226,752	-9,216	-0.053%	System.Runtime.InvariantTimezone.Tests.exe
18,518,016	18,508,288	-9,728	-0.053%	System.IO.MemoryMappedFiles.Tests.exe
18,693,632	18,683,904	-9,728	-0.052%	Microsoft.Extensions.Logging.Console.Tests.exe
18,032,128	18,022,912	-9,216	-0.051%	Microsoft.Extensions.Diagnostics.Tests.exe
16,107,008	16,098,816	-8,192	-0.051%	System.Data.Odbc.Tests.exe
24,284,672	24,272,384	-12,288	-0.051%	Microsoft.Extensions.Http.Tests.exe
20,532,736	20,522,496	-10,240	-0.050%	System.Runtime.Extensions.Tests.exe
18,371,584	18,362,368	-9,216	-0.050%	System.Threading.Tests.exe
18,356,736	18,347,520	-9,216	-0.050%	Microsoft.Extensions.FileProviders.Composite.Tests.exe
18,381,824	18,372,608	-9,216	-0.050%	Microsoft.Extensions.Primitives.Tests.exe
11,331,072	11,325,440	-5,632	-0.050%	System.Net.WebSockets.Tests.exe
19,295,744	19,286,016	-9,728	-0.050%	System.Net.Primitives.Functional.Tests.exe
19,972,608	19,962,880	-9,728	-0.049%	Microsoft.Extensions.Logging.Tests.exe
11,588,096	11,582,464	-5,632	-0.049%	System.Net.Http.Json.Unit.Tests.exe
19,744,768	19,735,040	-9,728	-0.049%	System.Resources.ResourceManager.Tests.exe
9,334,784	9,330,176	-4,608	-0.049%	Microsoft.Extensions.Diagnostics.Abstractions.Tests.exe
18,833,920	18,824,704	-9,216	-0.049%	System.Runtime.Caching.Tests.exe
19,080,192	19,070,976	-9,216	-0.048%	Microsoft.Extensions.Hosting.WindowsServices.Tests.exe
9,660,416	9,655,808	-4,608	-0.048%	Microsoft.Extensions.Hosting.Functional.Tests.exe
20,475,904	20,466,176	-9,728	-0.048%	System.Diagnostics.DiagnosticSource.Tests.exe
20,741,632	20,731,904	-9,728	-0.047%	System.Collections.Concurrent.Tests.exe
10,106,368	10,101,760	-4,608	-0.046%	Microsoft.Extensions.Caching.Memory.Tests.exe
20,234,752	20,225,536	-9,216	-0.046%	System.Runtime.InteropServices.Tests.exe
20,454,912	20,445,696	-9,216	-0.045%	System.Reflection.Tests.exe
19,486,208	19,477,504	-8,704	-0.045%	Microsoft.Extensions.Configuration.UserSecrets.Tests.exe
11,274,240	11,269,120	-5,120	-0.045%	System.IO.Compression.Brotli.Tests.exe
19,555,840	19,547,136	-8,704	-0.045%	Microsoft.Extensions.Configuration.Json.Tests.exe
23,405,056	23,394,816	-10,240	-0.044%	System.Memory.Tests.exe
25,891,328	25,880,064	-11,264	-0.044%	System.Text.Json.SourceGeneration.Roslyn3.11.Tests.exe
10,510,336	10,505,728	-4,608	-0.044%	Microsoft.Extensions.Options.Tests.exe
9,442,816	9,438,720	-4,096	-0.043%	Microsoft.Extensions.Logging.Testing.Tests.exe
26,440,704	26,429,440	-11,264	-0.043%	System.ComponentModel.TypeConverter.Tests.exe
21,622,784	21,613,568	-9,216	-0.043%	System.Data.OleDb.Tests.exe
26,006,528	25,996,288	-10,240	-0.039%	System.Globalization.Nls.Tests.exe
20,808,704	20,801,024	-7,680	-0.037%	System.Security.Cryptography.Csp.Tests.exe
29,403,136	29,392,384	-10,752	-0.037%	Microsoft.Extensions.DependencyModel.Tests.exe
26,095,616	26,085,888	-9,728	-0.037%	System.Globalization.Tests.exe
21,072,384	21,064,704	-7,680	-0.036%	Microsoft.Extensions.Logging.EventSource.Tests.exe
45,486,080	45,470,208	-15,872	-0.035%	System.Security.Cryptography.Tests.exe
32,739,840	32,730,112	-9,728	-0.030%	System.Linq.Expressions.Tests.exe
33,385,984	33,376,256	-9,728	-0.029%	Microsoft.Bcl.Cryptography.Tests.exe
44,704,768	44,693,504	-11,264	-0.025%	System.Runtime.Tests.exe
2,233,344	2,232,832	-512	-0.023%	clrjit.dll
10,494,464	10,492,928	-1,536	-0.015%	System.Net.Http.WinHttpHandler.Unit.Tests.exe
10,586,112	10,584,576	-1,536	-0.015%	Common.Tests.exe
9,026,048	9,025,024	-1,024	-0.011%	Microsoft.Extensions.FileSystemGlobbing.Tests.exe
9,347,584	9,346,560	-1,024	-0.011%	System.Security.Permissions.Tests.exe
9,612,800	9,611,776	-1,024	-0.011%	System.Diagnostics.EventLog.Tests.exe
12,185,088	12,184,064	-1,024	-0.008%	System.Net.NetworkInformation.Functional.Tests.exe
15,386,112	15,385,088	-1,024	-0.007%	System.Globalization.Extensions.Nls.Tests.exe
15,386,112	15,385,088	-1,024	-0.007%	System.Globalization.Extensions.Tests.exe
8,743,936	8,743,424	-512	-0.006%	Invariant.Tests.exe
8,975,872	8,975,360	-512	-0.006%	System.Net.Primitives.Pal.Tests.exe
8,798,208	8,797,696	-512	-0.006%	System.Resources.Reader.Tests.exe
8,667,136	8,666,624	-512	-0.006%	System.Runtime.CompilerServices.Unsafe.Tests.exe
8,916,480	8,915,968	-512	-0.006%	System.IO.Pipes.AccessControl.Tests.exe
9,027,072	9,026,560	-512	-0.006%	System.Net.NameResolution.Pal.Tests.exe
9,191,936	9,191,424	-512	-0.006%	Microsoft.Extensions.Configuration.EnvironmentVariables.Tests.exe
8,763,904	8,763,392	-512	-0.006%	Microsoft.Bcl.TimeProvider.Tests.exe
8,609,792	8,609,280	-512	-0.006%	System.Composition.Runtime.Tests.exe
9,129,472	9,128,960	-512	-0.006%	System.Security.AccessControl.Tests.exe
8,803,328	8,802,816	-512	-0.006%	System.Web.HttpUtility.Tests.exe
9,041,920	9,041,408	-512	-0.006%	Microsoft.Extensions.Configuration.CommandLine.Tests.exe
8,638,464	8,637,952	-512	-0.006%	System.Globalization.CalendarsWithConfigSwitch.Tests.exe
8,533,504	8,532,992	-512	-0.006%	System.ComponentModel.Tests.exe
8,686,592	8,686,080	-512	-0.006%	System.Security.Cryptography.ProtectedData.Tests.exe
8,755,712	8,755,200	-512	-0.006%	System.IO.FileSystem.DriveInfo.Tests.exe
8,977,408	8,976,896	-512	-0.006%	Microsoft.Win32.Registry.Tests.exe
8,685,568	8,685,056	-512	-0.006%	System.IO.FileSystem.Manual.Tests.exe
9,095,680	9,095,168	-512	-0.006%	System.IO.FileSystem.AccessControl.Tests.exe
10,048,512	10,048,000	-512	-0.005%	System.Diagnostics.Debug.Tests.exe
11,179,520	11,179,008	-512	-0.005%	System.Text.Encodings.Web.Tests.exe
11,034,112	11,033,600	-512	-0.005%	System.Runtime.Numerics.Tests.exe
11,363,328	11,362,816	-512	-0.005%	System.Net.Security.Unit.Tests.exe
9,337,344	9,336,832	-512	-0.005%	System.IO.IsolatedStorage.Tests.exe
9,748,992	9,749,504	+512	+0.005%	System.Formats.Asn1.Tests.exe
9,473,536	9,473,024	-512	-0.005%	Microsoft.Extensions.Configuration.Ini.Tests.exe
10,936,320	10,935,808	-512	-0.005%	System.Runtime.Intrinsics.Tests.exe
9,571,328	9,570,816	-512	-0.005%	System.Memory.Data.Tests.exe
9,660,928	9,660,416	-512	-0.005%	System.IO.UnmanagedMemoryStream.Tests.exe
9,524,736	9,524,224	-512	-0.005%	System.IO.Hashing.Tests.exe
9,361,920	9,361,408	-512	-0.005%	System.Net.Mail.Unit.Tests.exe
11,590,144	11,589,632	-512	-0.004%	System.Resources.Extensions.Tests.exe
11,469,312	11,468,800	-512	-0.004%	System.IO.Ports.Tests.exe
11,779,072	11,778,560	-512	-0.004%	System.Security.Cryptography.Cose.Tests.exe
17,824,768	17,824,256	-512	-0.003%	System.Collections.Tests.exe
18,770,432	18,770,944	+512	+0.003%	System.Numerics.Vectors.Tests.exe
22,320,640	22,320,128	-512	-0.002%	System.Security.Cryptography.Pkcs.Tests.exe
8,988,672	8,988,672	0	0.000%	System.Runtime.Serialization.Primitives.Tests.exe
8,690,176	8,690,176	0	0.000%	System.Security.SecureString.Tests.exe
9,201,664	9,201,664	0	0.000%	System.ServiceProcess.ServiceController.Tests.exe
7,318,016	7,318,016	0	0.000%	XUnitLogChecker.exe
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
84,480	84,480	0	0.000%	System.Globalization.Native.dll
108,032	108,032	0	0.000%	CMakeCXXCompilerId.exe
108,032	108,032	0	0.000%	CMakeCCompilerId.exe
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
8,673,280	8,673,280	0	0.000%	System.Runtime.InteropServices.ComDisabled.Tests.exe
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
8,608,768	8,608,768	0	0.000%	System.Xml.Linq.Axes.Tests.exe
9,069,056	9,069,056	0	0.000%	System.ValueTuple.Tests.exe
8,945,152	8,945,152	0	0.000%	System.Threading.AccessControl.Tests.exe
9,690,112	9,690,112	0	0.000%	System.Text.RegularExpressions.Unit.Tests.exe
8,543,232	8,543,232	0	0.000%	System.Text.Encoding.Extensions.Tests.exe
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
536,096	536,096	0	0.000%	msquic.dll
8,529,408	8,529,408	0	0.000%	System.IO.FileSystem.Primitives.Tests.exe
8,532,480	8,532,480	0	0.000%	System.Runtime.CompilerServices.VisualC.Tests.exe
536,096	536,096	0	0.000%	msquic.dll
1,308,672	1,308,672	0	0.000%	mscordbi.dll
1,501,696	1,501,696	0	0.000%	mscordaccore.dll
1,501,696	1,501,696	0	0.000%	mscordaccore_amd64_amd64_42.42.42.42424.dll
361,984	361,984	0	0.000%	hostpolicy.dll
350,208	350,208	0	0.000%	hostfxr.dll
62,464	62,464	0	0.000%	createdump.exe
210,944	210,944	0	0.000%	corerun.exe
4,955,648	4,955,648	0	0.000%	coreclr.dll
722,944	722,944	0	0.000%	clrgcexp.dll
678,400	678,400	0	0.000%	clrgc.dll
307,200	307,200	0	0.000%	clretwrc.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
84,480	84,480	0	0.000%	System.Globalization.Native.dll
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
696,320	696,320	0	0.000%	FileCheck.exe
9,956,352	9,956,352	0	0.000%	llvm-mca.exe
13,419,520	13,419,520	0	0.000%	crossgen2.exe
7,703,040	7,703,040	0	0.000%	ilasm.exe
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
15,940,096	15,940,096	0	0.000%	ilc.exe
8,938,496	8,938,496	0	0.000%	Microsoft.Bcl.Memory.Tests.exe
8,578,048	8,578,048	0	0.000%	Microsoft.Bcl.Numerics.Tests.exe
8,587,264	8,587,264	0	0.000%	Microsoft.Extensions.Hosting.Abstractions.Tests.exe
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
9,947,648	9,947,648	0	0.000%	LibraryImportGenerator.Tests.exe
8,655,872	8,655,872	0	0.000%	System.Runtime.Handles.Tests.exe
16,973,824	16,973,824	0	0.000%	System.Private.CoreLib.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
8,591,360	8,591,360	0	0.000%	System.Resources.Writer.Tests.exe
9,011,200	9,011,200	0	0.000%	System.Reflection.TypeExtensions.Tests.exe
12,271,104	12,271,104	0	0.000%	System.Reflection.Metadata.Tests.exe
8,849,920	8,849,920	0	0.000%	System.Reflection.Extensions.Tests.exe
9,350,656	9,350,656	0	0.000%	System.Reflection.Context.Tests.exe
8,704,512	8,704,512	0	0.000%	System.Private.Uri.Unit.Tests.exe
9,631,744	9,631,744	0	0.000%	System.Private.Uri.Functional.Tests.exe
9,785,856	9,785,856	0	0.000%	System.Net.WebProxy.Tests.exe
8,627,200	8,627,200	0	0.000%	System.Net.WebHeaderCollection.Tests.exe
9,300,992	9,300,992	0	0.000%	System.Net.Primitives.UnitTests.Tests.exe
15,486,976	15,486,976	0	0.000%	System.Linq.Tests.exe
696,320	696,320	0	0.000%	FileCheck.exe
9,150,976	9,150,976	0	0.000%	System.Globalization.Calendars.Tests.exe
9,837,568	9,837,568	0	0.000%	System.Formats.Nrbf.Tests.exe
8,534,528	8,534,528	0	0.000%	System.Diagnostics.Tools.Tests.exe
8,702,464	8,702,464	0	0.000%	System.Diagnostics.FileVersionInfo.Tests.exe
8,547,840	8,547,840	0	0.000%	System.Diagnostics.Contracts.Tests.exe
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
8,649,216	8,649,216	0	0.000%	Microsoft.Win32.Primitives.Tests.exe
9,934,336	9,934,336	0	0.000%	System.Collections.NonGeneric.Tests.exe
9,734,656	9,734,656	0	0.000%	System.Collections.Specialized.Tests.exe
9,147,392	9,147,392	0	0.000%	System.ComponentModel.Primitives.Tests.exe
8,544,768	8,544,768	0	0.000%	System.Composition.AttributeModel.Tests.exe
9,615,872	9,615,872	0	0.000%	System.Composition.Convention.Tests.exe
8,821,760	8,821,760	0	0.000%	System.Console.Manual.Tests.exe
8,632,832	8,632,832	0	0.000%	Microsoft.Win32.Registry.AccessControl.Tests.exe
9,956,352	9,956,352	0	0.000%	llvm-mca.exe

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR changes CoreCLR runtime-async suspension/resumption so the dispatcher (managed AsyncHelpers) restores ExecutionContext, instead of having interpreter/JIT resumption stubs call a restore helper. The continuation’s flags now encode the ExecutionContext storage slot, enabling the dispatcher to restore without an extra TLS lookup + helper call on the hot resumption path.

Changes:

• Add continuation support for locating/storing the ExecutionContext via encoded indices in continuation flags (VM + managed + JIT + interpreter).
• Remove RestoreExecutionContext calls from interpreter and JIT resumption code; add restoration to the dispatcher loop.
• Preserve BBF_ASYNC_RESUMPTION across certain flow optimizations that may bypass resumption stubs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/object.h	Adds VM helper to locate ExecutionContext storage in a continuation via encoded flag bits.
src/coreclr/vm/interpexec.cpp	Writes captured ExecutionContext via the encoded slot; removes interpreter-side restore on resume.
src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs	Moves ExecutionContext restore into dispatcher; adjusts flag layout and RestoreExecutionContext signature to avoid TLS lookup.
src/coreclr/jit/fgopt.cpp	Copies BBF_ASYNC_RESUMPTION during certain jump/switch/flow optimizations to preserve async side-entry affordances.
src/coreclr/jit/async.cpp	Updates continuation layout/flag encoding for ExecutionContext; removes JIT-side restore on resumption.
src/coreclr/interpreter/inc/interpretershared.h	Removes interpreter suspend-data field that stored a raw execution-context offset.
src/coreclr/interpreter/compiler.cpp	Encodes ExecutionContext slot in flags and updates interpreter continuation layout accordingly.
src/coreclr/inc/corinfo.h	Updates CorInfoContinuationFlags bit assignments to include ExecutionContext index encoding.

Comments suppressed due to low confidence (2)

src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs:554

• RuntimeAsyncStackState contains managed reference fields, but this local is left uninitialized before its address is stored in TLS (awaitState.Push(&stackState)). This can expose garbage references to the GC (and Push only initializes a subset of fields), risking GC crashes/corruption. Initialize stackState to default (or otherwise fully clear all reference fields before any GC safepoint) before calling Push.

 RuntimeAsyncStackState stackState;
ref RuntimeAsyncAwaitState awaitState = ref t_runtimeAsyncAwaitState;
awaitState.Push(&stackState);

src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs:655

• Same issue as in DispatchContinuations: RuntimeAsyncStackState stackState; is uninitialized even though the struct contains managed references and its address is pushed into TLS via awaitState.Push(&stackState). This can leave garbage object references visible to the GC until fields are explicitly set. Ensure stackState is zero-initialized (e.g., = default) or otherwise cleared before pushing.

 RuntimeAsyncStackState stackState;
ref RuntimeAsyncAwaitState awaitState = ref t_runtimeAsyncAwaitState;
awaitState.Push(&stackState);

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/coreclr/interpreter/compiler.cpp:6007

• InterpAsyncSuspendData.restoreExecutionContextMethod is still populated, but after removing the interpreter-side RestoreExecutionContext call there don’t appear to be any remaining reads of this field. Consider removing the field from InterpAsyncSuspendData (and this assignment) to reduce per-suspension metadata size and avoid dead state.

 suspendData->keepAliveOffset = keepAliveOffset + OFFSETOF__CORINFO_Continuation__data;
suspendData->captureSyncContextMethod = asyncInfo.captureContinuationContextMethHnd;
suspendData->restoreExecutionContextMethod = asyncInfo.restoreExecutionContextMethHnd;
suspendData->restoreContextsOnSuspensionMethod = asyncInfo.restoreContextsOnSuspensionMethHnd;

[Copilot]

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

src/coreclr/interpreter/compiler.cpp:6007

• CORINFO_ASYNC_INFO no longer exposes restoreExecutionContextMethHnd, but the interpreter still stores asyncInfo.restoreExecutionContextMethHnd into InterpAsyncSuspendData. This will fail to compile and should be removed/rewired now that execution context restoration is done by the dispatcher.

 suspendData->keepAliveOffset = keepAliveOffset + OFFSETOF__CORINFO_Continuation__data;
suspendData->captureSyncContextMethod = asyncInfo.captureContinuationContextMethHnd;
suspendData->restoreExecutionContextMethod = asyncInfo.restoreExecutionContextMethHnd;
suspendData->restoreContextsOnSuspensionMethod = asyncInfo.restoreContextsOnSuspensionMethHnd;

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

[jakobbotsch]

PTAL @VSadov (async) @AndyAyersMS (JIT) @davidwrighton /@janvorli (interpreter)

[AndyAyersMS]

JIT changes look good.

[VSadov]

LGTM. Thanks!

[jakobbotsch]

Will merge this, @janvorli@davidwrighton let me know if you have any comments on the interpreter change and I can address it in a follow-up.

[jakobbotsch]

Remove RestoreExecutionContext call from JIT resumption code and from the interpreter. Instead encode the ExecutionContext's location in the continuation and let the dispatcher restore it. This removes a TLS access + helper call from the resumption path (avoiding the TLS and inlining the helper call in the dispatcher).

Improves suspension/resumption performance by about 7-8% and is also a good size improvement. Removing the call from the resumption path allows keeping the continuation in a volatile register, which also helps register allocation in a number of cases.

Diffs before JIT-EE GUID update

Micro benchmark with warmup

usingSystem;usingSystem.Diagnostics;usingSystem.Runtime.CompilerServices;usingSystem.Threading;usingSystem.Threading.Tasks;namespaceAsyncMicro;publicclassProgram{staticvoidMain(){NullAwaiterna=newNullAwaiter();for(inti=0;i<10;i++){for(intj=0;j<100;j++){Taskt=Foo(100,na);while(!t.IsCompleted){na.Continue();}}Thread.Sleep(100);}for(inti=0;i<50;i++){Taskt=Foo(10_000_000,na);while(!t.IsCompleted){na.Continue();}}}staticints_value;staticasyncTaskFoo(intn,NullAwaiterna){for(inti=0;i<n;i++){s_value+=i;}Stopwatchtimer=Stopwatch.StartNew();for(inti=0;i<n;i++){awaitna;}if(n>100)Console.WriteLine("Took {0:F1} ms",timer.Elapsed.TotalMilliseconds);}privateclassNullAwaiter:ICriticalNotifyCompletion{publicActionContinue;publicNullAwaiterGetAwaiter()=>this;publicboolIsCompleted=>false;publicvoidGetResult(){}publicvoidUnsafeOnCompleted(Actioncontinuation){Continue=continuation;}publicvoidOnCompleted(Actioncontinuation){thrownewNotImplementedException();}}}

About 7-8% improvement:

-Took 268.5 ms-Took 265.9 ms-Took 267.9 ms-Took 270.0 ms-Took 269.4 ms+Took 249.4 ms+Took 248.3 ms+Took 250.3 ms+Took 249.2 ms+Took 248.9 ms

NativeAOT test sizes

BaseSize	DiffSize	Delta	Percent	Name
31,037,440	30,944,256	-93,184	-0.300%	System.Net.Http.Functional.Tests.exe
16,847,872	16,803,328	-44,544	-0.264%	System.Linq.AsyncEnumerable.Tests.exe
115,269,120	115,089,408	-179,712	-0.156%	System.Text.Json.SourceGeneration.Roslyn4.4.Tests.exe
20,942,336	20,912,640	-29,696	-0.142%	System.Net.Quic.Functional.Tests.exe
20,033,024	20,005,376	-27,648	-0.138%	System.Formats.Tar.Tests.exe
19,558,912	19,533,824	-25,088	-0.128%	System.IO.Compression.Tests.exe
10,055,168	10,042,880	-12,288	-0.122%	System.IO.Compression.ZipFile.Tests.exe
14,901,760	14,883,840	-17,920	-0.120%	System.Xml.Linq.Streaming.Tests.exe
16,778,752	16,758,784	-19,968	-0.119%	System.Xml.Linq.Misc.Tests.exe
28,789,760	28,757,504	-32,256	-0.112%	System.Net.Http.WinHttpHandler.Functional.Tests.exe
16,516,608	16,498,176	-18,432	-0.112%	System.Xml.Linq.Events.Tests.exe
17,065,472	17,046,528	-18,944	-0.111%	System.Xml.Linq.xNodeBuilder.Tests.exe
22,732,800	22,708,224	-24,576	-0.108%	System.Net.Sockets.Tests.exe
16,671,744	16,653,824	-17,920	-0.107%	System.Xml.Linq.Properties.Tests.exe
17,123,840	17,105,920	-17,920	-0.105%	System.Xml.Linq.TreeManipulation.Tests.exe
17,007,616	16,989,696	-17,920	-0.105%	System.Xml.Linq.xNodeReader.Tests.exe
20,003,840	19,982,848	-20,992	-0.105%	System.Net.WebSockets.Client.Tests.exe
19,053,056	19,034,112	-18,944	-0.099%	System.Net.HttpListener.Tests.exe
10,660,864	10,650,624	-10,240	-0.096%	System.IO.Pipelines.Tests.exe
20,267,008	20,248,064	-18,944	-0.093%	System.Threading.Tasks.Dataflow.Tests.exe
17,728,512	17,713,664	-14,848	-0.084%	System.Threading.Tasks.Extensions.Tests.exe
14,569,472	14,557,696	-11,776	-0.081%	System.Net.WebClient.Tests.exe
11,992,064	11,982,336	-9,728	-0.081%	System.IO.Tests.exe
21,089,792	21,072,896	-16,896	-0.080%	System.Net.Requests.Tests.exe
21,708,800	21,691,392	-17,408	-0.080%	System.IO.FileSystem.Tests.exe
10,278,912	10,270,720	-8,192	-0.080%	System.Threading.Channels.Tests.exe
27,894,272	27,874,304	-19,968	-0.072%	System.Net.Security.Tests.exe
18,447,872	18,434,560	-13,312	-0.072%	System.Threading.Tasks.Parallel.Tests.exe
13,242,368	13,233,152	-9,216	-0.070%	System.IO.Packaging.Tests.exe
9,731,072	9,724,416	-6,656	-0.068%	System.Threading.RateLimiting.Tests.exe
33,165,312	33,142,784	-22,528	-0.068%	System.Private.Xml.Tests.exe
13,869,056	13,859,840	-9,216	-0.066%	Microsoft.Extensions.Configuration.Functional.Tests.exe
19,545,600	19,532,800	-12,800	-0.065%	System.Diagnostics.Process.Tests.exe
12,849,664	12,841,472	-8,192	-0.064%	System.Xml.Schema.Extensions.Tests.exe
12,416,000	12,408,320	-7,680	-0.062%	System.Xml.Linq.SDMSample.Tests.exe
17,431,552	17,420,800	-10,752	-0.062%	System.Net.Ping.Functional.Tests.exe
20,540,416	20,527,616	-12,800	-0.062%	System.Threading.Tasks.Tests.exe
15,759,872	15,750,144	-9,728	-0.062%	System.Windows.Extensions.Tests.exe
10,056,192	10,050,048	-6,144	-0.061%	System.Net.ServerSentEvents.Tests.exe
15,102,464	15,093,248	-9,216	-0.061%	System.Drawing.Primitives.Tests.exe
17,571,840	17,561,088	-10,752	-0.061%	MetricOuterLoop1.Tests.exe
17,566,720	17,555,968	-10,752	-0.061%	MetricOuterLoop.Tests.exe
19,289,600	19,277,824	-11,776	-0.061%	System.IO.Pipes.Tests.exe
17,791,488	17,780,736	-10,752	-0.060%	System.Formats.Tar.Manual.Tests.exe
17,967,616	17,956,864	-10,752	-0.060%	System.Threading.ThreadPool.WindowsThreadPool.Tests.exe
17,329,152	17,318,912	-10,240	-0.059%	System.Threading.Timer.Tests.exe
14,130,176	14,121,984	-8,192	-0.058%	System.DirectoryServices.Protocols.Tests.exe
17,616,896	17,606,656	-10,240	-0.058%	System.Threading.Thread.Tests.exe
19,681,792	19,670,528	-11,264	-0.057%	System.Net.Http.Unit.Tests.exe
17,160,192	17,150,464	-9,728	-0.057%	System.Runtime.Serialization.Formatters.Disabled.Tests.exe
17,967,104	17,956,864	-10,240	-0.057%	System.Threading.ThreadPool.Tests.exe
19,870,720	19,859,456	-11,264	-0.057%	System.Text.Encoding.Tests.exe
18,774,016	18,763,264	-10,752	-0.057%	Microsoft.Extensions.FileProviders.Physical.Tests.exe
27,160,064	27,144,704	-15,360	-0.057%	Microsoft.Extensions.Hosting.Unit.Tests.exe
17,214,976	17,205,248	-9,728	-0.057%	System.Net.ServicePoint.Tests.exe
17,312,768	17,303,040	-9,728	-0.056%	System.Security.Principal.Windows.Tests.exe
17,230,848	17,221,120	-9,728	-0.056%	System.ComponentModel.EventBasedAsync.Tests.exe
18,128,896	18,118,656	-10,240	-0.056%	System.Diagnostics.TextWriterTraceListener.Tests.exe
17,298,944	17,289,216	-9,728	-0.056%	System.Security.Claims.Tests.exe
17,431,040	17,421,312	-9,728	-0.056%	System.Diagnostics.TraceSource.Tests.exe
17,282,048	17,272,320	-9,728	-0.056%	System.Threading.Overlapped.Tests.exe
18,177,536	18,167,296	-10,240	-0.056%	System.Text.Encoding.CodePages.Tests.exe
17,356,288	17,346,560	-9,728	-0.056%	Microsoft.Win32.SystemEvents.Tests.exe
18,586,624	18,576,384	-10,240	-0.055%	ComInterfaceGenerator.Tests.exe
17,661,440	17,651,712	-9,728	-0.055%	System.IO.FileSystem.Watcher.Tests.exe
9,251,840	9,246,720	-5,120	-0.055%	Microsoft.Bcl.AsyncInterfaces.Tests.exe
13,941,248	13,933,568	-7,680	-0.055%	Microsoft.Extensions.Configuration.Xml.Tests.exe
18,492,928	18,482,688	-10,240	-0.055%	Microsoft.Extensions.Configuration.Tests.exe
17,662,976	17,653,248	-9,728	-0.055%	System.Buffers.Tests.exe
18,489,344	18,479,104	-10,240	-0.055%	Microsoft.Extensions.Hosting.Systemd.Tests.exe
15,080,448	15,072,256	-8,192	-0.054%	System.Security.Cryptography.Cng.Tests.exe
17,154,048	17,144,832	-9,216	-0.054%	IcuAppLocal.Tests.exe
15,039,488	15,031,296	-8,192	-0.054%	System.Data.DataSetExtensions.Tests.exe
18,062,336	18,052,608	-9,728	-0.054%	System.Console.Tests.exe
17,288,192	17,278,976	-9,216	-0.053%	System.Runtime.InteropServices.RuntimeInformation.Tests.exe
17,361,408	17,352,192	-9,216	-0.053%	System.Diagnostics.StackTrace.Tests.exe
18,455,552	18,445,824	-9,728	-0.053%	Microsoft.Extensions.Configuration.FileExtensions.Tests.exe
17,235,968	17,226,752	-9,216	-0.053%	System.Runtime.InvariantTimezone.Tests.exe
18,518,016	18,508,288	-9,728	-0.053%	System.IO.MemoryMappedFiles.Tests.exe
18,693,632	18,683,904	-9,728	-0.052%	Microsoft.Extensions.Logging.Console.Tests.exe
18,032,128	18,022,912	-9,216	-0.051%	Microsoft.Extensions.Diagnostics.Tests.exe
16,107,008	16,098,816	-8,192	-0.051%	System.Data.Odbc.Tests.exe
24,284,672	24,272,384	-12,288	-0.051%	Microsoft.Extensions.Http.Tests.exe
20,532,736	20,522,496	-10,240	-0.050%	System.Runtime.Extensions.Tests.exe
18,371,584	18,362,368	-9,216	-0.050%	System.Threading.Tests.exe
18,356,736	18,347,520	-9,216	-0.050%	Microsoft.Extensions.FileProviders.Composite.Tests.exe
18,381,824	18,372,608	-9,216	-0.050%	Microsoft.Extensions.Primitives.Tests.exe
11,331,072	11,325,440	-5,632	-0.050%	System.Net.WebSockets.Tests.exe
19,295,744	19,286,016	-9,728	-0.050%	System.Net.Primitives.Functional.Tests.exe
19,972,608	19,962,880	-9,728	-0.049%	Microsoft.Extensions.Logging.Tests.exe
11,588,096	11,582,464	-5,632	-0.049%	System.Net.Http.Json.Unit.Tests.exe
19,744,768	19,735,040	-9,728	-0.049%	System.Resources.ResourceManager.Tests.exe
9,334,784	9,330,176	-4,608	-0.049%	Microsoft.Extensions.Diagnostics.Abstractions.Tests.exe
18,833,920	18,824,704	-9,216	-0.049%	System.Runtime.Caching.Tests.exe
19,080,192	19,070,976	-9,216	-0.048%	Microsoft.Extensions.Hosting.WindowsServices.Tests.exe
9,660,416	9,655,808	-4,608	-0.048%	Microsoft.Extensions.Hosting.Functional.Tests.exe
20,475,904	20,466,176	-9,728	-0.048%	System.Diagnostics.DiagnosticSource.Tests.exe
20,741,632	20,731,904	-9,728	-0.047%	System.Collections.Concurrent.Tests.exe
10,106,368	10,101,760	-4,608	-0.046%	Microsoft.Extensions.Caching.Memory.Tests.exe
20,234,752	20,225,536	-9,216	-0.046%	System.Runtime.InteropServices.Tests.exe
20,454,912	20,445,696	-9,216	-0.045%	System.Reflection.Tests.exe
19,486,208	19,477,504	-8,704	-0.045%	Microsoft.Extensions.Configuration.UserSecrets.Tests.exe
11,274,240	11,269,120	-5,120	-0.045%	System.IO.Compression.Brotli.Tests.exe
19,555,840	19,547,136	-8,704	-0.045%	Microsoft.Extensions.Configuration.Json.Tests.exe
23,405,056	23,394,816	-10,240	-0.044%	System.Memory.Tests.exe
25,891,328	25,880,064	-11,264	-0.044%	System.Text.Json.SourceGeneration.Roslyn3.11.Tests.exe
10,510,336	10,505,728	-4,608	-0.044%	Microsoft.Extensions.Options.Tests.exe
9,442,816	9,438,720	-4,096	-0.043%	Microsoft.Extensions.Logging.Testing.Tests.exe
26,440,704	26,429,440	-11,264	-0.043%	System.ComponentModel.TypeConverter.Tests.exe
21,622,784	21,613,568	-9,216	-0.043%	System.Data.OleDb.Tests.exe
26,006,528	25,996,288	-10,240	-0.039%	System.Globalization.Nls.Tests.exe
20,808,704	20,801,024	-7,680	-0.037%	System.Security.Cryptography.Csp.Tests.exe
29,403,136	29,392,384	-10,752	-0.037%	Microsoft.Extensions.DependencyModel.Tests.exe
26,095,616	26,085,888	-9,728	-0.037%	System.Globalization.Tests.exe
21,072,384	21,064,704	-7,680	-0.036%	Microsoft.Extensions.Logging.EventSource.Tests.exe
45,486,080	45,470,208	-15,872	-0.035%	System.Security.Cryptography.Tests.exe
32,739,840	32,730,112	-9,728	-0.030%	System.Linq.Expressions.Tests.exe
33,385,984	33,376,256	-9,728	-0.029%	Microsoft.Bcl.Cryptography.Tests.exe
44,704,768	44,693,504	-11,264	-0.025%	System.Runtime.Tests.exe
2,233,344	2,232,832	-512	-0.023%	clrjit.dll
10,494,464	10,492,928	-1,536	-0.015%	System.Net.Http.WinHttpHandler.Unit.Tests.exe
10,586,112	10,584,576	-1,536	-0.015%	Common.Tests.exe
9,026,048	9,025,024	-1,024	-0.011%	Microsoft.Extensions.FileSystemGlobbing.Tests.exe
9,347,584	9,346,560	-1,024	-0.011%	System.Security.Permissions.Tests.exe
9,612,800	9,611,776	-1,024	-0.011%	System.Diagnostics.EventLog.Tests.exe
12,185,088	12,184,064	-1,024	-0.008%	System.Net.NetworkInformation.Functional.Tests.exe
15,386,112	15,385,088	-1,024	-0.007%	System.Globalization.Extensions.Nls.Tests.exe
15,386,112	15,385,088	-1,024	-0.007%	System.Globalization.Extensions.Tests.exe
8,743,936	8,743,424	-512	-0.006%	Invariant.Tests.exe
8,975,872	8,975,360	-512	-0.006%	System.Net.Primitives.Pal.Tests.exe
8,798,208	8,797,696	-512	-0.006%	System.Resources.Reader.Tests.exe
8,667,136	8,666,624	-512	-0.006%	System.Runtime.CompilerServices.Unsafe.Tests.exe
8,916,480	8,915,968	-512	-0.006%	System.IO.Pipes.AccessControl.Tests.exe
9,027,072	9,026,560	-512	-0.006%	System.Net.NameResolution.Pal.Tests.exe
9,191,936	9,191,424	-512	-0.006%	Microsoft.Extensions.Configuration.EnvironmentVariables.Tests.exe
8,763,904	8,763,392	-512	-0.006%	Microsoft.Bcl.TimeProvider.Tests.exe
8,609,792	8,609,280	-512	-0.006%	System.Composition.Runtime.Tests.exe
9,129,472	9,128,960	-512	-0.006%	System.Security.AccessControl.Tests.exe
8,803,328	8,802,816	-512	-0.006%	System.Web.HttpUtility.Tests.exe
9,041,920	9,041,408	-512	-0.006%	Microsoft.Extensions.Configuration.CommandLine.Tests.exe
8,638,464	8,637,952	-512	-0.006%	System.Globalization.CalendarsWithConfigSwitch.Tests.exe
8,533,504	8,532,992	-512	-0.006%	System.ComponentModel.Tests.exe
8,686,592	8,686,080	-512	-0.006%	System.Security.Cryptography.ProtectedData.Tests.exe
8,755,712	8,755,200	-512	-0.006%	System.IO.FileSystem.DriveInfo.Tests.exe
8,977,408	8,976,896	-512	-0.006%	Microsoft.Win32.Registry.Tests.exe
8,685,568	8,685,056	-512	-0.006%	System.IO.FileSystem.Manual.Tests.exe
9,095,680	9,095,168	-512	-0.006%	System.IO.FileSystem.AccessControl.Tests.exe
10,048,512	10,048,000	-512	-0.005%	System.Diagnostics.Debug.Tests.exe
11,179,520	11,179,008	-512	-0.005%	System.Text.Encodings.Web.Tests.exe
11,034,112	11,033,600	-512	-0.005%	System.Runtime.Numerics.Tests.exe
11,363,328	11,362,816	-512	-0.005%	System.Net.Security.Unit.Tests.exe
9,337,344	9,336,832	-512	-0.005%	System.IO.IsolatedStorage.Tests.exe
9,748,992	9,749,504	+512	+0.005%	System.Formats.Asn1.Tests.exe
9,473,536	9,473,024	-512	-0.005%	Microsoft.Extensions.Configuration.Ini.Tests.exe
10,936,320	10,935,808	-512	-0.005%	System.Runtime.Intrinsics.Tests.exe
9,571,328	9,570,816	-512	-0.005%	System.Memory.Data.Tests.exe
9,660,928	9,660,416	-512	-0.005%	System.IO.UnmanagedMemoryStream.Tests.exe
9,524,736	9,524,224	-512	-0.005%	System.IO.Hashing.Tests.exe
9,361,920	9,361,408	-512	-0.005%	System.Net.Mail.Unit.Tests.exe
11,590,144	11,589,632	-512	-0.004%	System.Resources.Extensions.Tests.exe
11,469,312	11,468,800	-512	-0.004%	System.IO.Ports.Tests.exe
11,779,072	11,778,560	-512	-0.004%	System.Security.Cryptography.Cose.Tests.exe
17,824,768	17,824,256	-512	-0.003%	System.Collections.Tests.exe
18,770,432	18,770,944	+512	+0.003%	System.Numerics.Vectors.Tests.exe
22,320,640	22,320,128	-512	-0.002%	System.Security.Cryptography.Pkcs.Tests.exe
8,988,672	8,988,672	0	0.000%	System.Runtime.Serialization.Primitives.Tests.exe
8,690,176	8,690,176	0	0.000%	System.Security.SecureString.Tests.exe
9,201,664	9,201,664	0	0.000%	System.ServiceProcess.ServiceController.Tests.exe
7,318,016	7,318,016	0	0.000%	XUnitLogChecker.exe
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
84,480	84,480	0	0.000%	System.Globalization.Native.dll
108,032	108,032	0	0.000%	CMakeCXXCompilerId.exe
108,032	108,032	0	0.000%	CMakeCCompilerId.exe
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
8,673,280	8,673,280	0	0.000%	System.Runtime.InteropServices.ComDisabled.Tests.exe
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
8,608,768	8,608,768	0	0.000%	System.Xml.Linq.Axes.Tests.exe
9,069,056	9,069,056	0	0.000%	System.ValueTuple.Tests.exe
8,945,152	8,945,152	0	0.000%	System.Threading.AccessControl.Tests.exe
9,690,112	9,690,112	0	0.000%	System.Text.RegularExpressions.Unit.Tests.exe
8,543,232	8,543,232	0	0.000%	System.Text.Encoding.Extensions.Tests.exe
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
536,096	536,096	0	0.000%	msquic.dll
8,529,408	8,529,408	0	0.000%	System.IO.FileSystem.Primitives.Tests.exe
8,532,480	8,532,480	0	0.000%	System.Runtime.CompilerServices.VisualC.Tests.exe
536,096	536,096	0	0.000%	msquic.dll
1,308,672	1,308,672	0	0.000%	mscordbi.dll
1,501,696	1,501,696	0	0.000%	mscordaccore.dll
1,501,696	1,501,696	0	0.000%	mscordaccore_amd64_amd64_42.42.42.42424.dll
361,984	361,984	0	0.000%	hostpolicy.dll
350,208	350,208	0	0.000%	hostfxr.dll
62,464	62,464	0	0.000%	createdump.exe
210,944	210,944	0	0.000%	corerun.exe
4,955,648	4,955,648	0	0.000%	coreclr.dll
722,944	722,944	0	0.000%	clrgcexp.dll
678,400	678,400	0	0.000%	clrgc.dll
307,200	307,200	0	0.000%	clretwrc.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
84,480	84,480	0	0.000%	System.Globalization.Native.dll
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
696,320	696,320	0	0.000%	FileCheck.exe
9,956,352	9,956,352	0	0.000%	llvm-mca.exe
13,419,520	13,419,520	0	0.000%	crossgen2.exe
7,703,040	7,703,040	0	0.000%	ilasm.exe
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
15,940,096	15,940,096	0	0.000%	ilc.exe
8,938,496	8,938,496	0	0.000%	Microsoft.Bcl.Memory.Tests.exe
8,578,048	8,578,048	0	0.000%	Microsoft.Bcl.Numerics.Tests.exe
8,587,264	8,587,264	0	0.000%	Microsoft.Extensions.Hosting.Abstractions.Tests.exe
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
9,947,648	9,947,648	0	0.000%	LibraryImportGenerator.Tests.exe
8,655,872	8,655,872	0	0.000%	System.Runtime.Handles.Tests.exe
16,973,824	16,973,824	0	0.000%	System.Private.CoreLib.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
8,591,360	8,591,360	0	0.000%	System.Resources.Writer.Tests.exe
9,011,200	9,011,200	0	0.000%	System.Reflection.TypeExtensions.Tests.exe
12,271,104	12,271,104	0	0.000%	System.Reflection.Metadata.Tests.exe
8,849,920	8,849,920	0	0.000%	System.Reflection.Extensions.Tests.exe
9,350,656	9,350,656	0	0.000%	System.Reflection.Context.Tests.exe
8,704,512	8,704,512	0	0.000%	System.Private.Uri.Unit.Tests.exe
9,631,744	9,631,744	0	0.000%	System.Private.Uri.Functional.Tests.exe
9,785,856	9,785,856	0	0.000%	System.Net.WebProxy.Tests.exe
8,627,200	8,627,200	0	0.000%	System.Net.WebHeaderCollection.Tests.exe
9,300,992	9,300,992	0	0.000%	System.Net.Primitives.UnitTests.Tests.exe
15,486,976	15,486,976	0	0.000%	System.Linq.Tests.exe
696,320	696,320	0	0.000%	FileCheck.exe
9,150,976	9,150,976	0	0.000%	System.Globalization.Calendars.Tests.exe
9,837,568	9,837,568	0	0.000%	System.Formats.Nrbf.Tests.exe
8,534,528	8,534,528	0	0.000%	System.Diagnostics.Tools.Tests.exe
8,702,464	8,702,464	0	0.000%	System.Diagnostics.FileVersionInfo.Tests.exe
8,547,840	8,547,840	0	0.000%	System.Diagnostics.Contracts.Tests.exe
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
8,649,216	8,649,216	0	0.000%	Microsoft.Win32.Primitives.Tests.exe
9,934,336	9,934,336	0	0.000%	System.Collections.NonGeneric.Tests.exe
9,734,656	9,734,656	0	0.000%	System.Collections.Specialized.Tests.exe
9,147,392	9,147,392	0	0.000%	System.ComponentModel.Primitives.Tests.exe
8,544,768	8,544,768	0	0.000%	System.Composition.AttributeModel.Tests.exe
9,615,872	9,615,872	0	0.000%	System.Composition.Convention.Tests.exe
8,821,760	8,821,760	0	0.000%	System.Console.Manual.Tests.exe
8,632,832	8,632,832	0	0.000%	Microsoft.Win32.Registry.AccessControl.Tests.exe
9,956,352	9,956,352	0	0.000%	llvm-mca.exe

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR changes CoreCLR runtime-async suspension/resumption so the dispatcher (managed AsyncHelpers) restores ExecutionContext, instead of having interpreter/JIT resumption stubs call a restore helper. The continuation’s flags now encode the ExecutionContext storage slot, enabling the dispatcher to restore without an extra TLS lookup + helper call on the hot resumption path.

Changes:

• Add continuation support for locating/storing the ExecutionContext via encoded indices in continuation flags (VM + managed + JIT + interpreter).
• Remove RestoreExecutionContext calls from interpreter and JIT resumption code; add restoration to the dispatcher loop.
• Preserve BBF_ASYNC_RESUMPTION across certain flow optimizations that may bypass resumption stubs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/object.h	Adds VM helper to locate ExecutionContext storage in a continuation via encoded flag bits.
src/coreclr/vm/interpexec.cpp	Writes captured ExecutionContext via the encoded slot; removes interpreter-side restore on resume.
src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs	Moves ExecutionContext restore into dispatcher; adjusts flag layout and RestoreExecutionContext signature to avoid TLS lookup.
src/coreclr/jit/fgopt.cpp	Copies BBF_ASYNC_RESUMPTION during certain jump/switch/flow optimizations to preserve async side-entry affordances.
src/coreclr/jit/async.cpp	Updates continuation layout/flag encoding for ExecutionContext; removes JIT-side restore on resumption.
src/coreclr/interpreter/inc/interpretershared.h	Removes interpreter suspend-data field that stored a raw execution-context offset.
src/coreclr/interpreter/compiler.cpp	Encodes ExecutionContext slot in flags and updates interpreter continuation layout accordingly.
src/coreclr/inc/corinfo.h	Updates CorInfoContinuationFlags bit assignments to include ExecutionContext index encoding.

Comments suppressed due to low confidence (2)

src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs:554

• RuntimeAsyncStackState contains managed reference fields, but this local is left uninitialized before its address is stored in TLS (awaitState.Push(&stackState)). This can expose garbage references to the GC (and Push only initializes a subset of fields), risking GC crashes/corruption. Initialize stackState to default (or otherwise fully clear all reference fields before any GC safepoint) before calling Push.

 RuntimeAsyncStackState stackState;
ref RuntimeAsyncAwaitState awaitState = ref t_runtimeAsyncAwaitState;
awaitState.Push(&stackState);

src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs:655

• Same issue as in DispatchContinuations: RuntimeAsyncStackState stackState; is uninitialized even though the struct contains managed references and its address is pushed into TLS via awaitState.Push(&stackState). This can leave garbage object references visible to the GC until fields are explicitly set. Ensure stackState is zero-initialized (e.g., = default) or otherwise cleared before pushing.

 RuntimeAsyncStackState stackState;
ref RuntimeAsyncAwaitState awaitState = ref t_runtimeAsyncAwaitState;
awaitState.Push(&stackState);

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/coreclr/interpreter/compiler.cpp:6007

• InterpAsyncSuspendData.restoreExecutionContextMethod is still populated, but after removing the interpreter-side RestoreExecutionContext call there don’t appear to be any remaining reads of this field. Consider removing the field from InterpAsyncSuspendData (and this assignment) to reduce per-suspension metadata size and avoid dead state.

 suspendData->keepAliveOffset = keepAliveOffset + OFFSETOF__CORINFO_Continuation__data;
suspendData->captureSyncContextMethod = asyncInfo.captureContinuationContextMethHnd;
suspendData->restoreExecutionContextMethod = asyncInfo.restoreExecutionContextMethHnd;
suspendData->restoreContextsOnSuspensionMethod = asyncInfo.restoreContextsOnSuspensionMethHnd;

[Copilot]

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

src/coreclr/interpreter/compiler.cpp:6007

• CORINFO_ASYNC_INFO no longer exposes restoreExecutionContextMethHnd, but the interpreter still stores asyncInfo.restoreExecutionContextMethHnd into InterpAsyncSuspendData. This will fail to compile and should be removed/rewired now that execution context restoration is done by the dispatcher.

 suspendData->keepAliveOffset = keepAliveOffset + OFFSETOF__CORINFO_Continuation__data;
suspendData->captureSyncContextMethod = asyncInfo.captureContinuationContextMethHnd;
suspendData->restoreExecutionContextMethod = asyncInfo.restoreExecutionContextMethHnd;
suspendData->restoreContextsOnSuspensionMethod = asyncInfo.restoreContextsOnSuspensionMethHnd;

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

[jakobbotsch]

PTAL @VSadov (async) @AndyAyersMS (JIT) @davidwrighton /@janvorli (interpreter)

[AndyAyersMS]

JIT changes look good.

[VSadov]

LGTM. Thanks!

[jakobbotsch]

Will merge this, @janvorli@davidwrighton let me know if you have any comments on the interpreter change and I can address it in a follow-up.

[jakobbotsch]

Remove RestoreExecutionContext call from JIT resumption code and from the interpreter. Instead encode the ExecutionContext's location in the continuation and let the dispatcher restore it. This removes a TLS access + helper call from the resumption path (avoiding the TLS and inlining the helper call in the dispatcher).

Improves suspension/resumption performance by about 7-8% and is also a good size improvement. Removing the call from the resumption path allows keeping the continuation in a volatile register, which also helps register allocation in a number of cases.

Diffs before JIT-EE GUID update

Micro benchmark with warmup

usingSystem;usingSystem.Diagnostics;usingSystem.Runtime.CompilerServices;usingSystem.Threading;usingSystem.Threading.Tasks;namespaceAsyncMicro;publicclassProgram{staticvoidMain(){NullAwaiterna=newNullAwaiter();for(inti=0;i<10;i++){for(intj=0;j<100;j++){Taskt=Foo(100,na);while(!t.IsCompleted){na.Continue();}}Thread.Sleep(100);}for(inti=0;i<50;i++){Taskt=Foo(10_000_000,na);while(!t.IsCompleted){na.Continue();}}}staticints_value;staticasyncTaskFoo(intn,NullAwaiterna){for(inti=0;i<n;i++){s_value+=i;}Stopwatchtimer=Stopwatch.StartNew();for(inti=0;i<n;i++){awaitna;}if(n>100)Console.WriteLine("Took {0:F1} ms",timer.Elapsed.TotalMilliseconds);}privateclassNullAwaiter:ICriticalNotifyCompletion{publicActionContinue;publicNullAwaiterGetAwaiter()=>this;publicboolIsCompleted=>false;publicvoidGetResult(){}publicvoidUnsafeOnCompleted(Actioncontinuation){Continue=continuation;}publicvoidOnCompleted(Actioncontinuation){thrownewNotImplementedException();}}}

About 7-8% improvement:

-Took 268.5 ms-Took 265.9 ms-Took 267.9 ms-Took 270.0 ms-Took 269.4 ms+Took 249.4 ms+Took 248.3 ms+Took 250.3 ms+Took 249.2 ms+Took 248.9 ms

NativeAOT test sizes

BaseSize	DiffSize	Delta	Percent	Name
31,037,440	30,944,256	-93,184	-0.300%	System.Net.Http.Functional.Tests.exe
16,847,872	16,803,328	-44,544	-0.264%	System.Linq.AsyncEnumerable.Tests.exe
115,269,120	115,089,408	-179,712	-0.156%	System.Text.Json.SourceGeneration.Roslyn4.4.Tests.exe
20,942,336	20,912,640	-29,696	-0.142%	System.Net.Quic.Functional.Tests.exe
20,033,024	20,005,376	-27,648	-0.138%	System.Formats.Tar.Tests.exe
19,558,912	19,533,824	-25,088	-0.128%	System.IO.Compression.Tests.exe
10,055,168	10,042,880	-12,288	-0.122%	System.IO.Compression.ZipFile.Tests.exe
14,901,760	14,883,840	-17,920	-0.120%	System.Xml.Linq.Streaming.Tests.exe
16,778,752	16,758,784	-19,968	-0.119%	System.Xml.Linq.Misc.Tests.exe
28,789,760	28,757,504	-32,256	-0.112%	System.Net.Http.WinHttpHandler.Functional.Tests.exe
16,516,608	16,498,176	-18,432	-0.112%	System.Xml.Linq.Events.Tests.exe
17,065,472	17,046,528	-18,944	-0.111%	System.Xml.Linq.xNodeBuilder.Tests.exe
22,732,800	22,708,224	-24,576	-0.108%	System.Net.Sockets.Tests.exe
16,671,744	16,653,824	-17,920	-0.107%	System.Xml.Linq.Properties.Tests.exe
17,123,840	17,105,920	-17,920	-0.105%	System.Xml.Linq.TreeManipulation.Tests.exe
17,007,616	16,989,696	-17,920	-0.105%	System.Xml.Linq.xNodeReader.Tests.exe
20,003,840	19,982,848	-20,992	-0.105%	System.Net.WebSockets.Client.Tests.exe
19,053,056	19,034,112	-18,944	-0.099%	System.Net.HttpListener.Tests.exe
10,660,864	10,650,624	-10,240	-0.096%	System.IO.Pipelines.Tests.exe
20,267,008	20,248,064	-18,944	-0.093%	System.Threading.Tasks.Dataflow.Tests.exe
17,728,512	17,713,664	-14,848	-0.084%	System.Threading.Tasks.Extensions.Tests.exe
14,569,472	14,557,696	-11,776	-0.081%	System.Net.WebClient.Tests.exe
11,992,064	11,982,336	-9,728	-0.081%	System.IO.Tests.exe
21,089,792	21,072,896	-16,896	-0.080%	System.Net.Requests.Tests.exe
21,708,800	21,691,392	-17,408	-0.080%	System.IO.FileSystem.Tests.exe
10,278,912	10,270,720	-8,192	-0.080%	System.Threading.Channels.Tests.exe
27,894,272	27,874,304	-19,968	-0.072%	System.Net.Security.Tests.exe
18,447,872	18,434,560	-13,312	-0.072%	System.Threading.Tasks.Parallel.Tests.exe
13,242,368	13,233,152	-9,216	-0.070%	System.IO.Packaging.Tests.exe
9,731,072	9,724,416	-6,656	-0.068%	System.Threading.RateLimiting.Tests.exe
33,165,312	33,142,784	-22,528	-0.068%	System.Private.Xml.Tests.exe
13,869,056	13,859,840	-9,216	-0.066%	Microsoft.Extensions.Configuration.Functional.Tests.exe
19,545,600	19,532,800	-12,800	-0.065%	System.Diagnostics.Process.Tests.exe
12,849,664	12,841,472	-8,192	-0.064%	System.Xml.Schema.Extensions.Tests.exe
12,416,000	12,408,320	-7,680	-0.062%	System.Xml.Linq.SDMSample.Tests.exe
17,431,552	17,420,800	-10,752	-0.062%	System.Net.Ping.Functional.Tests.exe
20,540,416	20,527,616	-12,800	-0.062%	System.Threading.Tasks.Tests.exe
15,759,872	15,750,144	-9,728	-0.062%	System.Windows.Extensions.Tests.exe
10,056,192	10,050,048	-6,144	-0.061%	System.Net.ServerSentEvents.Tests.exe
15,102,464	15,093,248	-9,216	-0.061%	System.Drawing.Primitives.Tests.exe
17,571,840	17,561,088	-10,752	-0.061%	MetricOuterLoop1.Tests.exe
17,566,720	17,555,968	-10,752	-0.061%	MetricOuterLoop.Tests.exe
19,289,600	19,277,824	-11,776	-0.061%	System.IO.Pipes.Tests.exe
17,791,488	17,780,736	-10,752	-0.060%	System.Formats.Tar.Manual.Tests.exe
17,967,616	17,956,864	-10,752	-0.060%	System.Threading.ThreadPool.WindowsThreadPool.Tests.exe
17,329,152	17,318,912	-10,240	-0.059%	System.Threading.Timer.Tests.exe
14,130,176	14,121,984	-8,192	-0.058%	System.DirectoryServices.Protocols.Tests.exe
17,616,896	17,606,656	-10,240	-0.058%	System.Threading.Thread.Tests.exe
19,681,792	19,670,528	-11,264	-0.057%	System.Net.Http.Unit.Tests.exe
17,160,192	17,150,464	-9,728	-0.057%	System.Runtime.Serialization.Formatters.Disabled.Tests.exe
17,967,104	17,956,864	-10,240	-0.057%	System.Threading.ThreadPool.Tests.exe
19,870,720	19,859,456	-11,264	-0.057%	System.Text.Encoding.Tests.exe
18,774,016	18,763,264	-10,752	-0.057%	Microsoft.Extensions.FileProviders.Physical.Tests.exe
27,160,064	27,144,704	-15,360	-0.057%	Microsoft.Extensions.Hosting.Unit.Tests.exe
17,214,976	17,205,248	-9,728	-0.057%	System.Net.ServicePoint.Tests.exe
17,312,768	17,303,040	-9,728	-0.056%	System.Security.Principal.Windows.Tests.exe
17,230,848	17,221,120	-9,728	-0.056%	System.ComponentModel.EventBasedAsync.Tests.exe
18,128,896	18,118,656	-10,240	-0.056%	System.Diagnostics.TextWriterTraceListener.Tests.exe
17,298,944	17,289,216	-9,728	-0.056%	System.Security.Claims.Tests.exe
17,431,040	17,421,312	-9,728	-0.056%	System.Diagnostics.TraceSource.Tests.exe
17,282,048	17,272,320	-9,728	-0.056%	System.Threading.Overlapped.Tests.exe
18,177,536	18,167,296	-10,240	-0.056%	System.Text.Encoding.CodePages.Tests.exe
17,356,288	17,346,560	-9,728	-0.056%	Microsoft.Win32.SystemEvents.Tests.exe
18,586,624	18,576,384	-10,240	-0.055%	ComInterfaceGenerator.Tests.exe
17,661,440	17,651,712	-9,728	-0.055%	System.IO.FileSystem.Watcher.Tests.exe
9,251,840	9,246,720	-5,120	-0.055%	Microsoft.Bcl.AsyncInterfaces.Tests.exe
13,941,248	13,933,568	-7,680	-0.055%	Microsoft.Extensions.Configuration.Xml.Tests.exe
18,492,928	18,482,688	-10,240	-0.055%	Microsoft.Extensions.Configuration.Tests.exe
17,662,976	17,653,248	-9,728	-0.055%	System.Buffers.Tests.exe
18,489,344	18,479,104	-10,240	-0.055%	Microsoft.Extensions.Hosting.Systemd.Tests.exe
15,080,448	15,072,256	-8,192	-0.054%	System.Security.Cryptography.Cng.Tests.exe
17,154,048	17,144,832	-9,216	-0.054%	IcuAppLocal.Tests.exe
15,039,488	15,031,296	-8,192	-0.054%	System.Data.DataSetExtensions.Tests.exe
18,062,336	18,052,608	-9,728	-0.054%	System.Console.Tests.exe
17,288,192	17,278,976	-9,216	-0.053%	System.Runtime.InteropServices.RuntimeInformation.Tests.exe
17,361,408	17,352,192	-9,216	-0.053%	System.Diagnostics.StackTrace.Tests.exe
18,455,552	18,445,824	-9,728	-0.053%	Microsoft.Extensions.Configuration.FileExtensions.Tests.exe
17,235,968	17,226,752	-9,216	-0.053%	System.Runtime.InvariantTimezone.Tests.exe
18,518,016	18,508,288	-9,728	-0.053%	System.IO.MemoryMappedFiles.Tests.exe
18,693,632	18,683,904	-9,728	-0.052%	Microsoft.Extensions.Logging.Console.Tests.exe
18,032,128	18,022,912	-9,216	-0.051%	Microsoft.Extensions.Diagnostics.Tests.exe
16,107,008	16,098,816	-8,192	-0.051%	System.Data.Odbc.Tests.exe
24,284,672	24,272,384	-12,288	-0.051%	Microsoft.Extensions.Http.Tests.exe
20,532,736	20,522,496	-10,240	-0.050%	System.Runtime.Extensions.Tests.exe
18,371,584	18,362,368	-9,216	-0.050%	System.Threading.Tests.exe
18,356,736	18,347,520	-9,216	-0.050%	Microsoft.Extensions.FileProviders.Composite.Tests.exe
18,381,824	18,372,608	-9,216	-0.050%	Microsoft.Extensions.Primitives.Tests.exe
11,331,072	11,325,440	-5,632	-0.050%	System.Net.WebSockets.Tests.exe
19,295,744	19,286,016	-9,728	-0.050%	System.Net.Primitives.Functional.Tests.exe
19,972,608	19,962,880	-9,728	-0.049%	Microsoft.Extensions.Logging.Tests.exe
11,588,096	11,582,464	-5,632	-0.049%	System.Net.Http.Json.Unit.Tests.exe
19,744,768	19,735,040	-9,728	-0.049%	System.Resources.ResourceManager.Tests.exe
9,334,784	9,330,176	-4,608	-0.049%	Microsoft.Extensions.Diagnostics.Abstractions.Tests.exe
18,833,920	18,824,704	-9,216	-0.049%	System.Runtime.Caching.Tests.exe
19,080,192	19,070,976	-9,216	-0.048%	Microsoft.Extensions.Hosting.WindowsServices.Tests.exe
9,660,416	9,655,808	-4,608	-0.048%	Microsoft.Extensions.Hosting.Functional.Tests.exe
20,475,904	20,466,176	-9,728	-0.048%	System.Diagnostics.DiagnosticSource.Tests.exe
20,741,632	20,731,904	-9,728	-0.047%	System.Collections.Concurrent.Tests.exe
10,106,368	10,101,760	-4,608	-0.046%	Microsoft.Extensions.Caching.Memory.Tests.exe
20,234,752	20,225,536	-9,216	-0.046%	System.Runtime.InteropServices.Tests.exe
20,454,912	20,445,696	-9,216	-0.045%	System.Reflection.Tests.exe
19,486,208	19,477,504	-8,704	-0.045%	Microsoft.Extensions.Configuration.UserSecrets.Tests.exe
11,274,240	11,269,120	-5,120	-0.045%	System.IO.Compression.Brotli.Tests.exe
19,555,840	19,547,136	-8,704	-0.045%	Microsoft.Extensions.Configuration.Json.Tests.exe
23,405,056	23,394,816	-10,240	-0.044%	System.Memory.Tests.exe
25,891,328	25,880,064	-11,264	-0.044%	System.Text.Json.SourceGeneration.Roslyn3.11.Tests.exe
10,510,336	10,505,728	-4,608	-0.044%	Microsoft.Extensions.Options.Tests.exe
9,442,816	9,438,720	-4,096	-0.043%	Microsoft.Extensions.Logging.Testing.Tests.exe
26,440,704	26,429,440	-11,264	-0.043%	System.ComponentModel.TypeConverter.Tests.exe
21,622,784	21,613,568	-9,216	-0.043%	System.Data.OleDb.Tests.exe
26,006,528	25,996,288	-10,240	-0.039%	System.Globalization.Nls.Tests.exe
20,808,704	20,801,024	-7,680	-0.037%	System.Security.Cryptography.Csp.Tests.exe
29,403,136	29,392,384	-10,752	-0.037%	Microsoft.Extensions.DependencyModel.Tests.exe
26,095,616	26,085,888	-9,728	-0.037%	System.Globalization.Tests.exe
21,072,384	21,064,704	-7,680	-0.036%	Microsoft.Extensions.Logging.EventSource.Tests.exe
45,486,080	45,470,208	-15,872	-0.035%	System.Security.Cryptography.Tests.exe
32,739,840	32,730,112	-9,728	-0.030%	System.Linq.Expressions.Tests.exe
33,385,984	33,376,256	-9,728	-0.029%	Microsoft.Bcl.Cryptography.Tests.exe
44,704,768	44,693,504	-11,264	-0.025%	System.Runtime.Tests.exe
2,233,344	2,232,832	-512	-0.023%	clrjit.dll
10,494,464	10,492,928	-1,536	-0.015%	System.Net.Http.WinHttpHandler.Unit.Tests.exe
10,586,112	10,584,576	-1,536	-0.015%	Common.Tests.exe
9,026,048	9,025,024	-1,024	-0.011%	Microsoft.Extensions.FileSystemGlobbing.Tests.exe
9,347,584	9,346,560	-1,024	-0.011%	System.Security.Permissions.Tests.exe
9,612,800	9,611,776	-1,024	-0.011%	System.Diagnostics.EventLog.Tests.exe
12,185,088	12,184,064	-1,024	-0.008%	System.Net.NetworkInformation.Functional.Tests.exe
15,386,112	15,385,088	-1,024	-0.007%	System.Globalization.Extensions.Nls.Tests.exe
15,386,112	15,385,088	-1,024	-0.007%	System.Globalization.Extensions.Tests.exe
8,743,936	8,743,424	-512	-0.006%	Invariant.Tests.exe
8,975,872	8,975,360	-512	-0.006%	System.Net.Primitives.Pal.Tests.exe
8,798,208	8,797,696	-512	-0.006%	System.Resources.Reader.Tests.exe
8,667,136	8,666,624	-512	-0.006%	System.Runtime.CompilerServices.Unsafe.Tests.exe
8,916,480	8,915,968	-512	-0.006%	System.IO.Pipes.AccessControl.Tests.exe
9,027,072	9,026,560	-512	-0.006%	System.Net.NameResolution.Pal.Tests.exe
9,191,936	9,191,424	-512	-0.006%	Microsoft.Extensions.Configuration.EnvironmentVariables.Tests.exe
8,763,904	8,763,392	-512	-0.006%	Microsoft.Bcl.TimeProvider.Tests.exe
8,609,792	8,609,280	-512	-0.006%	System.Composition.Runtime.Tests.exe
9,129,472	9,128,960	-512	-0.006%	System.Security.AccessControl.Tests.exe
8,803,328	8,802,816	-512	-0.006%	System.Web.HttpUtility.Tests.exe
9,041,920	9,041,408	-512	-0.006%	Microsoft.Extensions.Configuration.CommandLine.Tests.exe
8,638,464	8,637,952	-512	-0.006%	System.Globalization.CalendarsWithConfigSwitch.Tests.exe
8,533,504	8,532,992	-512	-0.006%	System.ComponentModel.Tests.exe
8,686,592	8,686,080	-512	-0.006%	System.Security.Cryptography.ProtectedData.Tests.exe
8,755,712	8,755,200	-512	-0.006%	System.IO.FileSystem.DriveInfo.Tests.exe
8,977,408	8,976,896	-512	-0.006%	Microsoft.Win32.Registry.Tests.exe
8,685,568	8,685,056	-512	-0.006%	System.IO.FileSystem.Manual.Tests.exe
9,095,680	9,095,168	-512	-0.006%	System.IO.FileSystem.AccessControl.Tests.exe
10,048,512	10,048,000	-512	-0.005%	System.Diagnostics.Debug.Tests.exe
11,179,520	11,179,008	-512	-0.005%	System.Text.Encodings.Web.Tests.exe
11,034,112	11,033,600	-512	-0.005%	System.Runtime.Numerics.Tests.exe
11,363,328	11,362,816	-512	-0.005%	System.Net.Security.Unit.Tests.exe
9,337,344	9,336,832	-512	-0.005%	System.IO.IsolatedStorage.Tests.exe
9,748,992	9,749,504	+512	+0.005%	System.Formats.Asn1.Tests.exe
9,473,536	9,473,024	-512	-0.005%	Microsoft.Extensions.Configuration.Ini.Tests.exe
10,936,320	10,935,808	-512	-0.005%	System.Runtime.Intrinsics.Tests.exe
9,571,328	9,570,816	-512	-0.005%	System.Memory.Data.Tests.exe
9,660,928	9,660,416	-512	-0.005%	System.IO.UnmanagedMemoryStream.Tests.exe
9,524,736	9,524,224	-512	-0.005%	System.IO.Hashing.Tests.exe
9,361,920	9,361,408	-512	-0.005%	System.Net.Mail.Unit.Tests.exe
11,590,144	11,589,632	-512	-0.004%	System.Resources.Extensions.Tests.exe
11,469,312	11,468,800	-512	-0.004%	System.IO.Ports.Tests.exe
11,779,072	11,778,560	-512	-0.004%	System.Security.Cryptography.Cose.Tests.exe
17,824,768	17,824,256	-512	-0.003%	System.Collections.Tests.exe
18,770,432	18,770,944	+512	+0.003%	System.Numerics.Vectors.Tests.exe
22,320,640	22,320,128	-512	-0.002%	System.Security.Cryptography.Pkcs.Tests.exe
8,988,672	8,988,672	0	0.000%	System.Runtime.Serialization.Primitives.Tests.exe
8,690,176	8,690,176	0	0.000%	System.Security.SecureString.Tests.exe
9,201,664	9,201,664	0	0.000%	System.ServiceProcess.ServiceController.Tests.exe
7,318,016	7,318,016	0	0.000%	XUnitLogChecker.exe
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
84,480	84,480	0	0.000%	System.Globalization.Native.dll
108,032	108,032	0	0.000%	CMakeCXXCompilerId.exe
108,032	108,032	0	0.000%	CMakeCCompilerId.exe
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
8,673,280	8,673,280	0	0.000%	System.Runtime.InteropServices.ComDisabled.Tests.exe
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
8,608,768	8,608,768	0	0.000%	System.Xml.Linq.Axes.Tests.exe
9,069,056	9,069,056	0	0.000%	System.ValueTuple.Tests.exe
8,945,152	8,945,152	0	0.000%	System.Threading.AccessControl.Tests.exe
9,690,112	9,690,112	0	0.000%	System.Text.RegularExpressions.Unit.Tests.exe
8,543,232	8,543,232	0	0.000%	System.Text.Encoding.Extensions.Tests.exe
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
536,096	536,096	0	0.000%	msquic.dll
8,529,408	8,529,408	0	0.000%	System.IO.FileSystem.Primitives.Tests.exe
8,532,480	8,532,480	0	0.000%	System.Runtime.CompilerServices.VisualC.Tests.exe
536,096	536,096	0	0.000%	msquic.dll
1,308,672	1,308,672	0	0.000%	mscordbi.dll
1,501,696	1,501,696	0	0.000%	mscordaccore.dll
1,501,696	1,501,696	0	0.000%	mscordaccore_amd64_amd64_42.42.42.42424.dll
361,984	361,984	0	0.000%	hostpolicy.dll
350,208	350,208	0	0.000%	hostfxr.dll
62,464	62,464	0	0.000%	createdump.exe
210,944	210,944	0	0.000%	corerun.exe
4,955,648	4,955,648	0	0.000%	coreclr.dll
722,944	722,944	0	0.000%	clrgcexp.dll
678,400	678,400	0	0.000%	clrgc.dll
307,200	307,200	0	0.000%	clretwrc.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
84,480	84,480	0	0.000%	System.Globalization.Native.dll
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
696,320	696,320	0	0.000%	FileCheck.exe
9,956,352	9,956,352	0	0.000%	llvm-mca.exe
13,419,520	13,419,520	0	0.000%	crossgen2.exe
7,703,040	7,703,040	0	0.000%	ilasm.exe
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
15,940,096	15,940,096	0	0.000%	ilc.exe
8,938,496	8,938,496	0	0.000%	Microsoft.Bcl.Memory.Tests.exe
8,578,048	8,578,048	0	0.000%	Microsoft.Bcl.Numerics.Tests.exe
8,587,264	8,587,264	0	0.000%	Microsoft.Extensions.Hosting.Abstractions.Tests.exe
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
9,947,648	9,947,648	0	0.000%	LibraryImportGenerator.Tests.exe
8,655,872	8,655,872	0	0.000%	System.Runtime.Handles.Tests.exe
16,973,824	16,973,824	0	0.000%	System.Private.CoreLib.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
8,591,360	8,591,360	0	0.000%	System.Resources.Writer.Tests.exe
9,011,200	9,011,200	0	0.000%	System.Reflection.TypeExtensions.Tests.exe
12,271,104	12,271,104	0	0.000%	System.Reflection.Metadata.Tests.exe
8,849,920	8,849,920	0	0.000%	System.Reflection.Extensions.Tests.exe
9,350,656	9,350,656	0	0.000%	System.Reflection.Context.Tests.exe
8,704,512	8,704,512	0	0.000%	System.Private.Uri.Unit.Tests.exe
9,631,744	9,631,744	0	0.000%	System.Private.Uri.Functional.Tests.exe
9,785,856	9,785,856	0	0.000%	System.Net.WebProxy.Tests.exe
8,627,200	8,627,200	0	0.000%	System.Net.WebHeaderCollection.Tests.exe
9,300,992	9,300,992	0	0.000%	System.Net.Primitives.UnitTests.Tests.exe
15,486,976	15,486,976	0	0.000%	System.Linq.Tests.exe
696,320	696,320	0	0.000%	FileCheck.exe
9,150,976	9,150,976	0	0.000%	System.Globalization.Calendars.Tests.exe
9,837,568	9,837,568	0	0.000%	System.Formats.Nrbf.Tests.exe
8,534,528	8,534,528	0	0.000%	System.Diagnostics.Tools.Tests.exe
8,702,464	8,702,464	0	0.000%	System.Diagnostics.FileVersionInfo.Tests.exe
8,547,840	8,547,840	0	0.000%	System.Diagnostics.Contracts.Tests.exe
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
8,649,216	8,649,216	0	0.000%	Microsoft.Win32.Primitives.Tests.exe
9,934,336	9,934,336	0	0.000%	System.Collections.NonGeneric.Tests.exe
9,734,656	9,734,656	0	0.000%	System.Collections.Specialized.Tests.exe
9,147,392	9,147,392	0	0.000%	System.ComponentModel.Primitives.Tests.exe
8,544,768	8,544,768	0	0.000%	System.Composition.AttributeModel.Tests.exe
9,615,872	9,615,872	0	0.000%	System.Composition.Convention.Tests.exe
8,821,760	8,821,760	0	0.000%	System.Console.Manual.Tests.exe
8,632,832	8,632,832	0	0.000%	Microsoft.Win32.Registry.AccessControl.Tests.exe
9,956,352	9,956,352	0	0.000%	llvm-mca.exe

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR changes CoreCLR runtime-async suspension/resumption so the dispatcher (managed AsyncHelpers) restores ExecutionContext, instead of having interpreter/JIT resumption stubs call a restore helper. The continuation’s flags now encode the ExecutionContext storage slot, enabling the dispatcher to restore without an extra TLS lookup + helper call on the hot resumption path.

Changes:

• Add continuation support for locating/storing the ExecutionContext via encoded indices in continuation flags (VM + managed + JIT + interpreter).
• Remove RestoreExecutionContext calls from interpreter and JIT resumption code; add restoration to the dispatcher loop.
• Preserve BBF_ASYNC_RESUMPTION across certain flow optimizations that may bypass resumption stubs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/object.h	Adds VM helper to locate ExecutionContext storage in a continuation via encoded flag bits.
src/coreclr/vm/interpexec.cpp	Writes captured ExecutionContext via the encoded slot; removes interpreter-side restore on resume.
src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs	Moves ExecutionContext restore into dispatcher; adjusts flag layout and RestoreExecutionContext signature to avoid TLS lookup.
src/coreclr/jit/fgopt.cpp	Copies BBF_ASYNC_RESUMPTION during certain jump/switch/flow optimizations to preserve async side-entry affordances.
src/coreclr/jit/async.cpp	Updates continuation layout/flag encoding for ExecutionContext; removes JIT-side restore on resumption.
src/coreclr/interpreter/inc/interpretershared.h	Removes interpreter suspend-data field that stored a raw execution-context offset.
src/coreclr/interpreter/compiler.cpp	Encodes ExecutionContext slot in flags and updates interpreter continuation layout accordingly.
src/coreclr/inc/corinfo.h	Updates CorInfoContinuationFlags bit assignments to include ExecutionContext index encoding.

Comments suppressed due to low confidence (2)

src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs:554

• RuntimeAsyncStackState contains managed reference fields, but this local is left uninitialized before its address is stored in TLS (awaitState.Push(&stackState)). This can expose garbage references to the GC (and Push only initializes a subset of fields), risking GC crashes/corruption. Initialize stackState to default (or otherwise fully clear all reference fields before any GC safepoint) before calling Push.

 RuntimeAsyncStackState stackState;
ref RuntimeAsyncAwaitState awaitState = ref t_runtimeAsyncAwaitState;
awaitState.Push(&stackState);

src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs:655

• Same issue as in DispatchContinuations: RuntimeAsyncStackState stackState; is uninitialized even though the struct contains managed references and its address is pushed into TLS via awaitState.Push(&stackState). This can leave garbage object references visible to the GC until fields are explicitly set. Ensure stackState is zero-initialized (e.g., = default) or otherwise cleared before pushing.

 RuntimeAsyncStackState stackState;
ref RuntimeAsyncAwaitState awaitState = ref t_runtimeAsyncAwaitState;
awaitState.Push(&stackState);

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/coreclr/interpreter/compiler.cpp:6007

• InterpAsyncSuspendData.restoreExecutionContextMethod is still populated, but after removing the interpreter-side RestoreExecutionContext call there don’t appear to be any remaining reads of this field. Consider removing the field from InterpAsyncSuspendData (and this assignment) to reduce per-suspension metadata size and avoid dead state.

 suspendData->keepAliveOffset = keepAliveOffset + OFFSETOF__CORINFO_Continuation__data;
suspendData->captureSyncContextMethod = asyncInfo.captureContinuationContextMethHnd;
suspendData->restoreExecutionContextMethod = asyncInfo.restoreExecutionContextMethHnd;
suspendData->restoreContextsOnSuspensionMethod = asyncInfo.restoreContextsOnSuspensionMethHnd;

[Copilot]

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

src/coreclr/interpreter/compiler.cpp:6007

• CORINFO_ASYNC_INFO no longer exposes restoreExecutionContextMethHnd, but the interpreter still stores asyncInfo.restoreExecutionContextMethHnd into InterpAsyncSuspendData. This will fail to compile and should be removed/rewired now that execution context restoration is done by the dispatcher.

 suspendData->keepAliveOffset = keepAliveOffset + OFFSETOF__CORINFO_Continuation__data;
suspendData->captureSyncContextMethod = asyncInfo.captureContinuationContextMethHnd;
suspendData->restoreExecutionContextMethod = asyncInfo.restoreExecutionContextMethHnd;
suspendData->restoreContextsOnSuspensionMethod = asyncInfo.restoreContextsOnSuspensionMethHnd;

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

[jakobbotsch]

PTAL @VSadov (async) @AndyAyersMS (JIT) @davidwrighton /@janvorli (interpreter)

[AndyAyersMS]

JIT changes look good.

[VSadov]

LGTM. Thanks!

[jakobbotsch]

Will merge this, @janvorli@davidwrighton let me know if you have any comments on the interpreter change and I can address it in a follow-up.

[jakobbotsch]

Remove RestoreExecutionContext call from JIT resumption code and from the interpreter. Instead encode the ExecutionContext's location in the continuation and let the dispatcher restore it. This removes a TLS access + helper call from the resumption path (avoiding the TLS and inlining the helper call in the dispatcher).

Improves suspension/resumption performance by about 7-8% and is also a good size improvement. Removing the call from the resumption path allows keeping the continuation in a volatile register, which also helps register allocation in a number of cases.

Diffs before JIT-EE GUID update

Micro benchmark with warmup

usingSystem;usingSystem.Diagnostics;usingSystem.Runtime.CompilerServices;usingSystem.Threading;usingSystem.Threading.Tasks;namespaceAsyncMicro;publicclassProgram{staticvoidMain(){NullAwaiterna=newNullAwaiter();for(inti=0;i<10;i++){for(intj=0;j<100;j++){Taskt=Foo(100,na);while(!t.IsCompleted){na.Continue();}}Thread.Sleep(100);}for(inti=0;i<50;i++){Taskt=Foo(10_000_000,na);while(!t.IsCompleted){na.Continue();}}}staticints_value;staticasyncTaskFoo(intn,NullAwaiterna){for(inti=0;i<n;i++){s_value+=i;}Stopwatchtimer=Stopwatch.StartNew();for(inti=0;i<n;i++){awaitna;}if(n>100)Console.WriteLine("Took {0:F1} ms",timer.Elapsed.TotalMilliseconds);}privateclassNullAwaiter:ICriticalNotifyCompletion{publicActionContinue;publicNullAwaiterGetAwaiter()=>this;publicboolIsCompleted=>false;publicvoidGetResult(){}publicvoidUnsafeOnCompleted(Actioncontinuation){Continue=continuation;}publicvoidOnCompleted(Actioncontinuation){thrownewNotImplementedException();}}}

About 7-8% improvement:

-Took 268.5 ms-Took 265.9 ms-Took 267.9 ms-Took 270.0 ms-Took 269.4 ms+Took 249.4 ms+Took 248.3 ms+Took 250.3 ms+Took 249.2 ms+Took 248.9 ms

NativeAOT test sizes

BaseSize	DiffSize	Delta	Percent	Name
31,037,440	30,944,256	-93,184	-0.300%	System.Net.Http.Functional.Tests.exe
16,847,872	16,803,328	-44,544	-0.264%	System.Linq.AsyncEnumerable.Tests.exe
115,269,120	115,089,408	-179,712	-0.156%	System.Text.Json.SourceGeneration.Roslyn4.4.Tests.exe
20,942,336	20,912,640	-29,696	-0.142%	System.Net.Quic.Functional.Tests.exe
20,033,024	20,005,376	-27,648	-0.138%	System.Formats.Tar.Tests.exe
19,558,912	19,533,824	-25,088	-0.128%	System.IO.Compression.Tests.exe
10,055,168	10,042,880	-12,288	-0.122%	System.IO.Compression.ZipFile.Tests.exe
14,901,760	14,883,840	-17,920	-0.120%	System.Xml.Linq.Streaming.Tests.exe
16,778,752	16,758,784	-19,968	-0.119%	System.Xml.Linq.Misc.Tests.exe
28,789,760	28,757,504	-32,256	-0.112%	System.Net.Http.WinHttpHandler.Functional.Tests.exe
16,516,608	16,498,176	-18,432	-0.112%	System.Xml.Linq.Events.Tests.exe
17,065,472	17,046,528	-18,944	-0.111%	System.Xml.Linq.xNodeBuilder.Tests.exe
22,732,800	22,708,224	-24,576	-0.108%	System.Net.Sockets.Tests.exe
16,671,744	16,653,824	-17,920	-0.107%	System.Xml.Linq.Properties.Tests.exe
17,123,840	17,105,920	-17,920	-0.105%	System.Xml.Linq.TreeManipulation.Tests.exe
17,007,616	16,989,696	-17,920	-0.105%	System.Xml.Linq.xNodeReader.Tests.exe
20,003,840	19,982,848	-20,992	-0.105%	System.Net.WebSockets.Client.Tests.exe
19,053,056	19,034,112	-18,944	-0.099%	System.Net.HttpListener.Tests.exe
10,660,864	10,650,624	-10,240	-0.096%	System.IO.Pipelines.Tests.exe
20,267,008	20,248,064	-18,944	-0.093%	System.Threading.Tasks.Dataflow.Tests.exe
17,728,512	17,713,664	-14,848	-0.084%	System.Threading.Tasks.Extensions.Tests.exe
14,569,472	14,557,696	-11,776	-0.081%	System.Net.WebClient.Tests.exe
11,992,064	11,982,336	-9,728	-0.081%	System.IO.Tests.exe
21,089,792	21,072,896	-16,896	-0.080%	System.Net.Requests.Tests.exe
21,708,800	21,691,392	-17,408	-0.080%	System.IO.FileSystem.Tests.exe
10,278,912	10,270,720	-8,192	-0.080%	System.Threading.Channels.Tests.exe
27,894,272	27,874,304	-19,968	-0.072%	System.Net.Security.Tests.exe
18,447,872	18,434,560	-13,312	-0.072%	System.Threading.Tasks.Parallel.Tests.exe
13,242,368	13,233,152	-9,216	-0.070%	System.IO.Packaging.Tests.exe
9,731,072	9,724,416	-6,656	-0.068%	System.Threading.RateLimiting.Tests.exe
33,165,312	33,142,784	-22,528	-0.068%	System.Private.Xml.Tests.exe
13,869,056	13,859,840	-9,216	-0.066%	Microsoft.Extensions.Configuration.Functional.Tests.exe
19,545,600	19,532,800	-12,800	-0.065%	System.Diagnostics.Process.Tests.exe
12,849,664	12,841,472	-8,192	-0.064%	System.Xml.Schema.Extensions.Tests.exe
12,416,000	12,408,320	-7,680	-0.062%	System.Xml.Linq.SDMSample.Tests.exe
17,431,552	17,420,800	-10,752	-0.062%	System.Net.Ping.Functional.Tests.exe
20,540,416	20,527,616	-12,800	-0.062%	System.Threading.Tasks.Tests.exe
15,759,872	15,750,144	-9,728	-0.062%	System.Windows.Extensions.Tests.exe
10,056,192	10,050,048	-6,144	-0.061%	System.Net.ServerSentEvents.Tests.exe
15,102,464	15,093,248	-9,216	-0.061%	System.Drawing.Primitives.Tests.exe
17,571,840	17,561,088	-10,752	-0.061%	MetricOuterLoop1.Tests.exe
17,566,720	17,555,968	-10,752	-0.061%	MetricOuterLoop.Tests.exe
19,289,600	19,277,824	-11,776	-0.061%	System.IO.Pipes.Tests.exe
17,791,488	17,780,736	-10,752	-0.060%	System.Formats.Tar.Manual.Tests.exe
17,967,616	17,956,864	-10,752	-0.060%	System.Threading.ThreadPool.WindowsThreadPool.Tests.exe
17,329,152	17,318,912	-10,240	-0.059%	System.Threading.Timer.Tests.exe
14,130,176	14,121,984	-8,192	-0.058%	System.DirectoryServices.Protocols.Tests.exe
17,616,896	17,606,656	-10,240	-0.058%	System.Threading.Thread.Tests.exe
19,681,792	19,670,528	-11,264	-0.057%	System.Net.Http.Unit.Tests.exe
17,160,192	17,150,464	-9,728	-0.057%	System.Runtime.Serialization.Formatters.Disabled.Tests.exe
17,967,104	17,956,864	-10,240	-0.057%	System.Threading.ThreadPool.Tests.exe
19,870,720	19,859,456	-11,264	-0.057%	System.Text.Encoding.Tests.exe
18,774,016	18,763,264	-10,752	-0.057%	Microsoft.Extensions.FileProviders.Physical.Tests.exe
27,160,064	27,144,704	-15,360	-0.057%	Microsoft.Extensions.Hosting.Unit.Tests.exe
17,214,976	17,205,248	-9,728	-0.057%	System.Net.ServicePoint.Tests.exe
17,312,768	17,303,040	-9,728	-0.056%	System.Security.Principal.Windows.Tests.exe
17,230,848	17,221,120	-9,728	-0.056%	System.ComponentModel.EventBasedAsync.Tests.exe
18,128,896	18,118,656	-10,240	-0.056%	System.Diagnostics.TextWriterTraceListener.Tests.exe
17,298,944	17,289,216	-9,728	-0.056%	System.Security.Claims.Tests.exe
17,431,040	17,421,312	-9,728	-0.056%	System.Diagnostics.TraceSource.Tests.exe
17,282,048	17,272,320	-9,728	-0.056%	System.Threading.Overlapped.Tests.exe
18,177,536	18,167,296	-10,240	-0.056%	System.Text.Encoding.CodePages.Tests.exe
17,356,288	17,346,560	-9,728	-0.056%	Microsoft.Win32.SystemEvents.Tests.exe
18,586,624	18,576,384	-10,240	-0.055%	ComInterfaceGenerator.Tests.exe
17,661,440	17,651,712	-9,728	-0.055%	System.IO.FileSystem.Watcher.Tests.exe
9,251,840	9,246,720	-5,120	-0.055%	Microsoft.Bcl.AsyncInterfaces.Tests.exe
13,941,248	13,933,568	-7,680	-0.055%	Microsoft.Extensions.Configuration.Xml.Tests.exe
18,492,928	18,482,688	-10,240	-0.055%	Microsoft.Extensions.Configuration.Tests.exe
17,662,976	17,653,248	-9,728	-0.055%	System.Buffers.Tests.exe
18,489,344	18,479,104	-10,240	-0.055%	Microsoft.Extensions.Hosting.Systemd.Tests.exe
15,080,448	15,072,256	-8,192	-0.054%	System.Security.Cryptography.Cng.Tests.exe
17,154,048	17,144,832	-9,216	-0.054%	IcuAppLocal.Tests.exe
15,039,488	15,031,296	-8,192	-0.054%	System.Data.DataSetExtensions.Tests.exe
18,062,336	18,052,608	-9,728	-0.054%	System.Console.Tests.exe
17,288,192	17,278,976	-9,216	-0.053%	System.Runtime.InteropServices.RuntimeInformation.Tests.exe
17,361,408	17,352,192	-9,216	-0.053%	System.Diagnostics.StackTrace.Tests.exe
18,455,552	18,445,824	-9,728	-0.053%	Microsoft.Extensions.Configuration.FileExtensions.Tests.exe
17,235,968	17,226,752	-9,216	-0.053%	System.Runtime.InvariantTimezone.Tests.exe
18,518,016	18,508,288	-9,728	-0.053%	System.IO.MemoryMappedFiles.Tests.exe
18,693,632	18,683,904	-9,728	-0.052%	Microsoft.Extensions.Logging.Console.Tests.exe
18,032,128	18,022,912	-9,216	-0.051%	Microsoft.Extensions.Diagnostics.Tests.exe
16,107,008	16,098,816	-8,192	-0.051%	System.Data.Odbc.Tests.exe
24,284,672	24,272,384	-12,288	-0.051%	Microsoft.Extensions.Http.Tests.exe
20,532,736	20,522,496	-10,240	-0.050%	System.Runtime.Extensions.Tests.exe
18,371,584	18,362,368	-9,216	-0.050%	System.Threading.Tests.exe
18,356,736	18,347,520	-9,216	-0.050%	Microsoft.Extensions.FileProviders.Composite.Tests.exe
18,381,824	18,372,608	-9,216	-0.050%	Microsoft.Extensions.Primitives.Tests.exe
11,331,072	11,325,440	-5,632	-0.050%	System.Net.WebSockets.Tests.exe
19,295,744	19,286,016	-9,728	-0.050%	System.Net.Primitives.Functional.Tests.exe
19,972,608	19,962,880	-9,728	-0.049%	Microsoft.Extensions.Logging.Tests.exe
11,588,096	11,582,464	-5,632	-0.049%	System.Net.Http.Json.Unit.Tests.exe
19,744,768	19,735,040	-9,728	-0.049%	System.Resources.ResourceManager.Tests.exe
9,334,784	9,330,176	-4,608	-0.049%	Microsoft.Extensions.Diagnostics.Abstractions.Tests.exe
18,833,920	18,824,704	-9,216	-0.049%	System.Runtime.Caching.Tests.exe
19,080,192	19,070,976	-9,216	-0.048%	Microsoft.Extensions.Hosting.WindowsServices.Tests.exe
9,660,416	9,655,808	-4,608	-0.048%	Microsoft.Extensions.Hosting.Functional.Tests.exe
20,475,904	20,466,176	-9,728	-0.048%	System.Diagnostics.DiagnosticSource.Tests.exe
20,741,632	20,731,904	-9,728	-0.047%	System.Collections.Concurrent.Tests.exe
10,106,368	10,101,760	-4,608	-0.046%	Microsoft.Extensions.Caching.Memory.Tests.exe
20,234,752	20,225,536	-9,216	-0.046%	System.Runtime.InteropServices.Tests.exe
20,454,912	20,445,696	-9,216	-0.045%	System.Reflection.Tests.exe
19,486,208	19,477,504	-8,704	-0.045%	Microsoft.Extensions.Configuration.UserSecrets.Tests.exe
11,274,240	11,269,120	-5,120	-0.045%	System.IO.Compression.Brotli.Tests.exe
19,555,840	19,547,136	-8,704	-0.045%	Microsoft.Extensions.Configuration.Json.Tests.exe
23,405,056	23,394,816	-10,240	-0.044%	System.Memory.Tests.exe
25,891,328	25,880,064	-11,264	-0.044%	System.Text.Json.SourceGeneration.Roslyn3.11.Tests.exe
10,510,336	10,505,728	-4,608	-0.044%	Microsoft.Extensions.Options.Tests.exe
9,442,816	9,438,720	-4,096	-0.043%	Microsoft.Extensions.Logging.Testing.Tests.exe
26,440,704	26,429,440	-11,264	-0.043%	System.ComponentModel.TypeConverter.Tests.exe
21,622,784	21,613,568	-9,216	-0.043%	System.Data.OleDb.Tests.exe
26,006,528	25,996,288	-10,240	-0.039%	System.Globalization.Nls.Tests.exe
20,808,704	20,801,024	-7,680	-0.037%	System.Security.Cryptography.Csp.Tests.exe
29,403,136	29,392,384	-10,752	-0.037%	Microsoft.Extensions.DependencyModel.Tests.exe
26,095,616	26,085,888	-9,728	-0.037%	System.Globalization.Tests.exe
21,072,384	21,064,704	-7,680	-0.036%	Microsoft.Extensions.Logging.EventSource.Tests.exe
45,486,080	45,470,208	-15,872	-0.035%	System.Security.Cryptography.Tests.exe
32,739,840	32,730,112	-9,728	-0.030%	System.Linq.Expressions.Tests.exe
33,385,984	33,376,256	-9,728	-0.029%	Microsoft.Bcl.Cryptography.Tests.exe
44,704,768	44,693,504	-11,264	-0.025%	System.Runtime.Tests.exe
2,233,344	2,232,832	-512	-0.023%	clrjit.dll
10,494,464	10,492,928	-1,536	-0.015%	System.Net.Http.WinHttpHandler.Unit.Tests.exe
10,586,112	10,584,576	-1,536	-0.015%	Common.Tests.exe
9,026,048	9,025,024	-1,024	-0.011%	Microsoft.Extensions.FileSystemGlobbing.Tests.exe
9,347,584	9,346,560	-1,024	-0.011%	System.Security.Permissions.Tests.exe
9,612,800	9,611,776	-1,024	-0.011%	System.Diagnostics.EventLog.Tests.exe
12,185,088	12,184,064	-1,024	-0.008%	System.Net.NetworkInformation.Functional.Tests.exe
15,386,112	15,385,088	-1,024	-0.007%	System.Globalization.Extensions.Nls.Tests.exe
15,386,112	15,385,088	-1,024	-0.007%	System.Globalization.Extensions.Tests.exe
8,743,936	8,743,424	-512	-0.006%	Invariant.Tests.exe
8,975,872	8,975,360	-512	-0.006%	System.Net.Primitives.Pal.Tests.exe
8,798,208	8,797,696	-512	-0.006%	System.Resources.Reader.Tests.exe
8,667,136	8,666,624	-512	-0.006%	System.Runtime.CompilerServices.Unsafe.Tests.exe
8,916,480	8,915,968	-512	-0.006%	System.IO.Pipes.AccessControl.Tests.exe
9,027,072	9,026,560	-512	-0.006%	System.Net.NameResolution.Pal.Tests.exe
9,191,936	9,191,424	-512	-0.006%	Microsoft.Extensions.Configuration.EnvironmentVariables.Tests.exe
8,763,904	8,763,392	-512	-0.006%	Microsoft.Bcl.TimeProvider.Tests.exe
8,609,792	8,609,280	-512	-0.006%	System.Composition.Runtime.Tests.exe
9,129,472	9,128,960	-512	-0.006%	System.Security.AccessControl.Tests.exe
8,803,328	8,802,816	-512	-0.006%	System.Web.HttpUtility.Tests.exe
9,041,920	9,041,408	-512	-0.006%	Microsoft.Extensions.Configuration.CommandLine.Tests.exe
8,638,464	8,637,952	-512	-0.006%	System.Globalization.CalendarsWithConfigSwitch.Tests.exe
8,533,504	8,532,992	-512	-0.006%	System.ComponentModel.Tests.exe
8,686,592	8,686,080	-512	-0.006%	System.Security.Cryptography.ProtectedData.Tests.exe
8,755,712	8,755,200	-512	-0.006%	System.IO.FileSystem.DriveInfo.Tests.exe
8,977,408	8,976,896	-512	-0.006%	Microsoft.Win32.Registry.Tests.exe
8,685,568	8,685,056	-512	-0.006%	System.IO.FileSystem.Manual.Tests.exe
9,095,680	9,095,168	-512	-0.006%	System.IO.FileSystem.AccessControl.Tests.exe
10,048,512	10,048,000	-512	-0.005%	System.Diagnostics.Debug.Tests.exe
11,179,520	11,179,008	-512	-0.005%	System.Text.Encodings.Web.Tests.exe
11,034,112	11,033,600	-512	-0.005%	System.Runtime.Numerics.Tests.exe
11,363,328	11,362,816	-512	-0.005%	System.Net.Security.Unit.Tests.exe
9,337,344	9,336,832	-512	-0.005%	System.IO.IsolatedStorage.Tests.exe
9,748,992	9,749,504	+512	+0.005%	System.Formats.Asn1.Tests.exe
9,473,536	9,473,024	-512	-0.005%	Microsoft.Extensions.Configuration.Ini.Tests.exe
10,936,320	10,935,808	-512	-0.005%	System.Runtime.Intrinsics.Tests.exe
9,571,328	9,570,816	-512	-0.005%	System.Memory.Data.Tests.exe
9,660,928	9,660,416	-512	-0.005%	System.IO.UnmanagedMemoryStream.Tests.exe
9,524,736	9,524,224	-512	-0.005%	System.IO.Hashing.Tests.exe
9,361,920	9,361,408	-512	-0.005%	System.Net.Mail.Unit.Tests.exe
11,590,144	11,589,632	-512	-0.004%	System.Resources.Extensions.Tests.exe
11,469,312	11,468,800	-512	-0.004%	System.IO.Ports.Tests.exe
11,779,072	11,778,560	-512	-0.004%	System.Security.Cryptography.Cose.Tests.exe
17,824,768	17,824,256	-512	-0.003%	System.Collections.Tests.exe
18,770,432	18,770,944	+512	+0.003%	System.Numerics.Vectors.Tests.exe
22,320,640	22,320,128	-512	-0.002%	System.Security.Cryptography.Pkcs.Tests.exe
8,988,672	8,988,672	0	0.000%	System.Runtime.Serialization.Primitives.Tests.exe
8,690,176	8,690,176	0	0.000%	System.Security.SecureString.Tests.exe
9,201,664	9,201,664	0	0.000%	System.ServiceProcess.ServiceController.Tests.exe
7,318,016	7,318,016	0	0.000%	XUnitLogChecker.exe
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
84,480	84,480	0	0.000%	System.Globalization.Native.dll
108,032	108,032	0	0.000%	CMakeCXXCompilerId.exe
108,032	108,032	0	0.000%	CMakeCCompilerId.exe
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
8,673,280	8,673,280	0	0.000%	System.Runtime.InteropServices.ComDisabled.Tests.exe
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
8,608,768	8,608,768	0	0.000%	System.Xml.Linq.Axes.Tests.exe
9,069,056	9,069,056	0	0.000%	System.ValueTuple.Tests.exe
8,945,152	8,945,152	0	0.000%	System.Threading.AccessControl.Tests.exe
9,690,112	9,690,112	0	0.000%	System.Text.RegularExpressions.Unit.Tests.exe
8,543,232	8,543,232	0	0.000%	System.Text.Encoding.Extensions.Tests.exe
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
536,096	536,096	0	0.000%	msquic.dll
8,529,408	8,529,408	0	0.000%	System.IO.FileSystem.Primitives.Tests.exe
8,532,480	8,532,480	0	0.000%	System.Runtime.CompilerServices.VisualC.Tests.exe
536,096	536,096	0	0.000%	msquic.dll
1,308,672	1,308,672	0	0.000%	mscordbi.dll
1,501,696	1,501,696	0	0.000%	mscordaccore.dll
1,501,696	1,501,696	0	0.000%	mscordaccore_amd64_amd64_42.42.42.42424.dll
361,984	361,984	0	0.000%	hostpolicy.dll
350,208	350,208	0	0.000%	hostfxr.dll
62,464	62,464	0	0.000%	createdump.exe
210,944	210,944	0	0.000%	corerun.exe
4,955,648	4,955,648	0	0.000%	coreclr.dll
722,944	722,944	0	0.000%	clrgcexp.dll
678,400	678,400	0	0.000%	clrgc.dll
307,200	307,200	0	0.000%	clretwrc.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
84,480	84,480	0	0.000%	System.Globalization.Native.dll
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
696,320	696,320	0	0.000%	FileCheck.exe
9,956,352	9,956,352	0	0.000%	llvm-mca.exe
13,419,520	13,419,520	0	0.000%	crossgen2.exe
7,703,040	7,703,040	0	0.000%	ilasm.exe
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
15,940,096	15,940,096	0	0.000%	ilc.exe
8,938,496	8,938,496	0	0.000%	Microsoft.Bcl.Memory.Tests.exe
8,578,048	8,578,048	0	0.000%	Microsoft.Bcl.Numerics.Tests.exe
8,587,264	8,587,264	0	0.000%	Microsoft.Extensions.Hosting.Abstractions.Tests.exe
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
9,947,648	9,947,648	0	0.000%	LibraryImportGenerator.Tests.exe
8,655,872	8,655,872	0	0.000%	System.Runtime.Handles.Tests.exe
16,973,824	16,973,824	0	0.000%	System.Private.CoreLib.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
8,591,360	8,591,360	0	0.000%	System.Resources.Writer.Tests.exe
9,011,200	9,011,200	0	0.000%	System.Reflection.TypeExtensions.Tests.exe
12,271,104	12,271,104	0	0.000%	System.Reflection.Metadata.Tests.exe
8,849,920	8,849,920	0	0.000%	System.Reflection.Extensions.Tests.exe
9,350,656	9,350,656	0	0.000%	System.Reflection.Context.Tests.exe
8,704,512	8,704,512	0	0.000%	System.Private.Uri.Unit.Tests.exe
9,631,744	9,631,744	0	0.000%	System.Private.Uri.Functional.Tests.exe
9,785,856	9,785,856	0	0.000%	System.Net.WebProxy.Tests.exe
8,627,200	8,627,200	0	0.000%	System.Net.WebHeaderCollection.Tests.exe
9,300,992	9,300,992	0	0.000%	System.Net.Primitives.UnitTests.Tests.exe
15,486,976	15,486,976	0	0.000%	System.Linq.Tests.exe
696,320	696,320	0	0.000%	FileCheck.exe
9,150,976	9,150,976	0	0.000%	System.Globalization.Calendars.Tests.exe
9,837,568	9,837,568	0	0.000%	System.Formats.Nrbf.Tests.exe
8,534,528	8,534,528	0	0.000%	System.Diagnostics.Tools.Tests.exe
8,702,464	8,702,464	0	0.000%	System.Diagnostics.FileVersionInfo.Tests.exe
8,547,840	8,547,840	0	0.000%	System.Diagnostics.Contracts.Tests.exe
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
8,649,216	8,649,216	0	0.000%	Microsoft.Win32.Primitives.Tests.exe
9,934,336	9,934,336	0	0.000%	System.Collections.NonGeneric.Tests.exe
9,734,656	9,734,656	0	0.000%	System.Collections.Specialized.Tests.exe
9,147,392	9,147,392	0	0.000%	System.ComponentModel.Primitives.Tests.exe
8,544,768	8,544,768	0	0.000%	System.Composition.AttributeModel.Tests.exe
9,615,872	9,615,872	0	0.000%	System.Composition.Convention.Tests.exe
8,821,760	8,821,760	0	0.000%	System.Console.Manual.Tests.exe
8,632,832	8,632,832	0	0.000%	Microsoft.Win32.Registry.AccessControl.Tests.exe
9,956,352	9,956,352	0	0.000%	llvm-mca.exe

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR changes CoreCLR runtime-async suspension/resumption so the dispatcher (managed AsyncHelpers) restores ExecutionContext, instead of having interpreter/JIT resumption stubs call a restore helper. The continuation’s flags now encode the ExecutionContext storage slot, enabling the dispatcher to restore without an extra TLS lookup + helper call on the hot resumption path.

Changes:

• Add continuation support for locating/storing the ExecutionContext via encoded indices in continuation flags (VM + managed + JIT + interpreter).
• Remove RestoreExecutionContext calls from interpreter and JIT resumption code; add restoration to the dispatcher loop.
• Preserve BBF_ASYNC_RESUMPTION across certain flow optimizations that may bypass resumption stubs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/object.h	Adds VM helper to locate ExecutionContext storage in a continuation via encoded flag bits.
src/coreclr/vm/interpexec.cpp	Writes captured ExecutionContext via the encoded slot; removes interpreter-side restore on resume.
src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs	Moves ExecutionContext restore into dispatcher; adjusts flag layout and RestoreExecutionContext signature to avoid TLS lookup.
src/coreclr/jit/fgopt.cpp	Copies BBF_ASYNC_RESUMPTION during certain jump/switch/flow optimizations to preserve async side-entry affordances.
src/coreclr/jit/async.cpp	Updates continuation layout/flag encoding for ExecutionContext; removes JIT-side restore on resumption.
src/coreclr/interpreter/inc/interpretershared.h	Removes interpreter suspend-data field that stored a raw execution-context offset.
src/coreclr/interpreter/compiler.cpp	Encodes ExecutionContext slot in flags and updates interpreter continuation layout accordingly.
src/coreclr/inc/corinfo.h	Updates CorInfoContinuationFlags bit assignments to include ExecutionContext index encoding.

Comments suppressed due to low confidence (2)

src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs:554

• RuntimeAsyncStackState contains managed reference fields, but this local is left uninitialized before its address is stored in TLS (awaitState.Push(&stackState)). This can expose garbage references to the GC (and Push only initializes a subset of fields), risking GC crashes/corruption. Initialize stackState to default (or otherwise fully clear all reference fields before any GC safepoint) before calling Push.

 RuntimeAsyncStackState stackState;
ref RuntimeAsyncAwaitState awaitState = ref t_runtimeAsyncAwaitState;
awaitState.Push(&stackState);

src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs:655

• Same issue as in DispatchContinuations: RuntimeAsyncStackState stackState; is uninitialized even though the struct contains managed references and its address is pushed into TLS via awaitState.Push(&stackState). This can leave garbage object references visible to the GC until fields are explicitly set. Ensure stackState is zero-initialized (e.g., = default) or otherwise cleared before pushing.

 RuntimeAsyncStackState stackState;
ref RuntimeAsyncAwaitState awaitState = ref t_runtimeAsyncAwaitState;
awaitState.Push(&stackState);

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/coreclr/interpreter/compiler.cpp:6007

• InterpAsyncSuspendData.restoreExecutionContextMethod is still populated, but after removing the interpreter-side RestoreExecutionContext call there don’t appear to be any remaining reads of this field. Consider removing the field from InterpAsyncSuspendData (and this assignment) to reduce per-suspension metadata size and avoid dead state.

 suspendData->keepAliveOffset = keepAliveOffset + OFFSETOF__CORINFO_Continuation__data;
suspendData->captureSyncContextMethod = asyncInfo.captureContinuationContextMethHnd;
suspendData->restoreExecutionContextMethod = asyncInfo.restoreExecutionContextMethHnd;
suspendData->restoreContextsOnSuspensionMethod = asyncInfo.restoreContextsOnSuspensionMethHnd;

[Copilot]

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

src/coreclr/interpreter/compiler.cpp:6007

• CORINFO_ASYNC_INFO no longer exposes restoreExecutionContextMethHnd, but the interpreter still stores asyncInfo.restoreExecutionContextMethHnd into InterpAsyncSuspendData. This will fail to compile and should be removed/rewired now that execution context restoration is done by the dispatcher.

 suspendData->keepAliveOffset = keepAliveOffset + OFFSETOF__CORINFO_Continuation__data;
suspendData->captureSyncContextMethod = asyncInfo.captureContinuationContextMethHnd;
suspendData->restoreExecutionContextMethod = asyncInfo.restoreExecutionContextMethHnd;
suspendData->restoreContextsOnSuspensionMethod = asyncInfo.restoreContextsOnSuspensionMethHnd;

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

[jakobbotsch]

PTAL @VSadov (async) @AndyAyersMS (JIT) @davidwrighton /@janvorli (interpreter)

[AndyAyersMS]

JIT changes look good.

[VSadov]

LGTM. Thanks!

[jakobbotsch]

Will merge this, @janvorli@davidwrighton let me know if you have any comments on the interpreter change and I can address it in a follow-up.

[jakobbotsch]

Remove RestoreExecutionContext call from JIT resumption code and from the interpreter. Instead encode the ExecutionContext's location in the continuation and let the dispatcher restore it. This removes a TLS access + helper call from the resumption path (avoiding the TLS and inlining the helper call in the dispatcher).

Improves suspension/resumption performance by about 7-8% and is also a good size improvement. Removing the call from the resumption path allows keeping the continuation in a volatile register, which also helps register allocation in a number of cases.

Diffs before JIT-EE GUID update

Micro benchmark with warmup

usingSystem;usingSystem.Diagnostics;usingSystem.Runtime.CompilerServices;usingSystem.Threading;usingSystem.Threading.Tasks;namespaceAsyncMicro;publicclassProgram{staticvoidMain(){NullAwaiterna=newNullAwaiter();for(inti=0;i<10;i++){for(intj=0;j<100;j++){Taskt=Foo(100,na);while(!t.IsCompleted){na.Continue();}}Thread.Sleep(100);}for(inti=0;i<50;i++){Taskt=Foo(10_000_000,na);while(!t.IsCompleted){na.Continue();}}}staticints_value;staticasyncTaskFoo(intn,NullAwaiterna){for(inti=0;i<n;i++){s_value+=i;}Stopwatchtimer=Stopwatch.StartNew();for(inti=0;i<n;i++){awaitna;}if(n>100)Console.WriteLine("Took {0:F1} ms",timer.Elapsed.TotalMilliseconds);}privateclassNullAwaiter:ICriticalNotifyCompletion{publicActionContinue;publicNullAwaiterGetAwaiter()=>this;publicboolIsCompleted=>false;publicvoidGetResult(){}publicvoidUnsafeOnCompleted(Actioncontinuation){Continue=continuation;}publicvoidOnCompleted(Actioncontinuation){thrownewNotImplementedException();}}}

About 7-8% improvement:

-Took 268.5 ms-Took 265.9 ms-Took 267.9 ms-Took 270.0 ms-Took 269.4 ms+Took 249.4 ms+Took 248.3 ms+Took 250.3 ms+Took 249.2 ms+Took 248.9 ms

NativeAOT test sizes

BaseSize	DiffSize	Delta	Percent	Name
31,037,440	30,944,256	-93,184	-0.300%	System.Net.Http.Functional.Tests.exe
16,847,872	16,803,328	-44,544	-0.264%	System.Linq.AsyncEnumerable.Tests.exe
115,269,120	115,089,408	-179,712	-0.156%	System.Text.Json.SourceGeneration.Roslyn4.4.Tests.exe
20,942,336	20,912,640	-29,696	-0.142%	System.Net.Quic.Functional.Tests.exe
20,033,024	20,005,376	-27,648	-0.138%	System.Formats.Tar.Tests.exe
19,558,912	19,533,824	-25,088	-0.128%	System.IO.Compression.Tests.exe
10,055,168	10,042,880	-12,288	-0.122%	System.IO.Compression.ZipFile.Tests.exe
14,901,760	14,883,840	-17,920	-0.120%	System.Xml.Linq.Streaming.Tests.exe
16,778,752	16,758,784	-19,968	-0.119%	System.Xml.Linq.Misc.Tests.exe
28,789,760	28,757,504	-32,256	-0.112%	System.Net.Http.WinHttpHandler.Functional.Tests.exe
16,516,608	16,498,176	-18,432	-0.112%	System.Xml.Linq.Events.Tests.exe
17,065,472	17,046,528	-18,944	-0.111%	System.Xml.Linq.xNodeBuilder.Tests.exe
22,732,800	22,708,224	-24,576	-0.108%	System.Net.Sockets.Tests.exe
16,671,744	16,653,824	-17,920	-0.107%	System.Xml.Linq.Properties.Tests.exe
17,123,840	17,105,920	-17,920	-0.105%	System.Xml.Linq.TreeManipulation.Tests.exe
17,007,616	16,989,696	-17,920	-0.105%	System.Xml.Linq.xNodeReader.Tests.exe
20,003,840	19,982,848	-20,992	-0.105%	System.Net.WebSockets.Client.Tests.exe
19,053,056	19,034,112	-18,944	-0.099%	System.Net.HttpListener.Tests.exe
10,660,864	10,650,624	-10,240	-0.096%	System.IO.Pipelines.Tests.exe
20,267,008	20,248,064	-18,944	-0.093%	System.Threading.Tasks.Dataflow.Tests.exe
17,728,512	17,713,664	-14,848	-0.084%	System.Threading.Tasks.Extensions.Tests.exe
14,569,472	14,557,696	-11,776	-0.081%	System.Net.WebClient.Tests.exe
11,992,064	11,982,336	-9,728	-0.081%	System.IO.Tests.exe
21,089,792	21,072,896	-16,896	-0.080%	System.Net.Requests.Tests.exe
21,708,800	21,691,392	-17,408	-0.080%	System.IO.FileSystem.Tests.exe
10,278,912	10,270,720	-8,192	-0.080%	System.Threading.Channels.Tests.exe
27,894,272	27,874,304	-19,968	-0.072%	System.Net.Security.Tests.exe
18,447,872	18,434,560	-13,312	-0.072%	System.Threading.Tasks.Parallel.Tests.exe
13,242,368	13,233,152	-9,216	-0.070%	System.IO.Packaging.Tests.exe
9,731,072	9,724,416	-6,656	-0.068%	System.Threading.RateLimiting.Tests.exe
33,165,312	33,142,784	-22,528	-0.068%	System.Private.Xml.Tests.exe
13,869,056	13,859,840	-9,216	-0.066%	Microsoft.Extensions.Configuration.Functional.Tests.exe
19,545,600	19,532,800	-12,800	-0.065%	System.Diagnostics.Process.Tests.exe
12,849,664	12,841,472	-8,192	-0.064%	System.Xml.Schema.Extensions.Tests.exe
12,416,000	12,408,320	-7,680	-0.062%	System.Xml.Linq.SDMSample.Tests.exe
17,431,552	17,420,800	-10,752	-0.062%	System.Net.Ping.Functional.Tests.exe
20,540,416	20,527,616	-12,800	-0.062%	System.Threading.Tasks.Tests.exe
15,759,872	15,750,144	-9,728	-0.062%	System.Windows.Extensions.Tests.exe
10,056,192	10,050,048	-6,144	-0.061%	System.Net.ServerSentEvents.Tests.exe
15,102,464	15,093,248	-9,216	-0.061%	System.Drawing.Primitives.Tests.exe
17,571,840	17,561,088	-10,752	-0.061%	MetricOuterLoop1.Tests.exe
17,566,720	17,555,968	-10,752	-0.061%	MetricOuterLoop.Tests.exe
19,289,600	19,277,824	-11,776	-0.061%	System.IO.Pipes.Tests.exe
17,791,488	17,780,736	-10,752	-0.060%	System.Formats.Tar.Manual.Tests.exe
17,967,616	17,956,864	-10,752	-0.060%	System.Threading.ThreadPool.WindowsThreadPool.Tests.exe
17,329,152	17,318,912	-10,240	-0.059%	System.Threading.Timer.Tests.exe
14,130,176	14,121,984	-8,192	-0.058%	System.DirectoryServices.Protocols.Tests.exe
17,616,896	17,606,656	-10,240	-0.058%	System.Threading.Thread.Tests.exe
19,681,792	19,670,528	-11,264	-0.057%	System.Net.Http.Unit.Tests.exe
17,160,192	17,150,464	-9,728	-0.057%	System.Runtime.Serialization.Formatters.Disabled.Tests.exe
17,967,104	17,956,864	-10,240	-0.057%	System.Threading.ThreadPool.Tests.exe
19,870,720	19,859,456	-11,264	-0.057%	System.Text.Encoding.Tests.exe
18,774,016	18,763,264	-10,752	-0.057%	Microsoft.Extensions.FileProviders.Physical.Tests.exe
27,160,064	27,144,704	-15,360	-0.057%	Microsoft.Extensions.Hosting.Unit.Tests.exe
17,214,976	17,205,248	-9,728	-0.057%	System.Net.ServicePoint.Tests.exe
17,312,768	17,303,040	-9,728	-0.056%	System.Security.Principal.Windows.Tests.exe
17,230,848	17,221,120	-9,728	-0.056%	System.ComponentModel.EventBasedAsync.Tests.exe
18,128,896	18,118,656	-10,240	-0.056%	System.Diagnostics.TextWriterTraceListener.Tests.exe
17,298,944	17,289,216	-9,728	-0.056%	System.Security.Claims.Tests.exe
17,431,040	17,421,312	-9,728	-0.056%	System.Diagnostics.TraceSource.Tests.exe
17,282,048	17,272,320	-9,728	-0.056%	System.Threading.Overlapped.Tests.exe
18,177,536	18,167,296	-10,240	-0.056%	System.Text.Encoding.CodePages.Tests.exe
17,356,288	17,346,560	-9,728	-0.056%	Microsoft.Win32.SystemEvents.Tests.exe
18,586,624	18,576,384	-10,240	-0.055%	ComInterfaceGenerator.Tests.exe
17,661,440	17,651,712	-9,728	-0.055%	System.IO.FileSystem.Watcher.Tests.exe
9,251,840	9,246,720	-5,120	-0.055%	Microsoft.Bcl.AsyncInterfaces.Tests.exe
13,941,248	13,933,568	-7,680	-0.055%	Microsoft.Extensions.Configuration.Xml.Tests.exe
18,492,928	18,482,688	-10,240	-0.055%	Microsoft.Extensions.Configuration.Tests.exe
17,662,976	17,653,248	-9,728	-0.055%	System.Buffers.Tests.exe
18,489,344	18,479,104	-10,240	-0.055%	Microsoft.Extensions.Hosting.Systemd.Tests.exe
15,080,448	15,072,256	-8,192	-0.054%	System.Security.Cryptography.Cng.Tests.exe
17,154,048	17,144,832	-9,216	-0.054%	IcuAppLocal.Tests.exe
15,039,488	15,031,296	-8,192	-0.054%	System.Data.DataSetExtensions.Tests.exe
18,062,336	18,052,608	-9,728	-0.054%	System.Console.Tests.exe
17,288,192	17,278,976	-9,216	-0.053%	System.Runtime.InteropServices.RuntimeInformation.Tests.exe
17,361,408	17,352,192	-9,216	-0.053%	System.Diagnostics.StackTrace.Tests.exe
18,455,552	18,445,824	-9,728	-0.053%	Microsoft.Extensions.Configuration.FileExtensions.Tests.exe
17,235,968	17,226,752	-9,216	-0.053%	System.Runtime.InvariantTimezone.Tests.exe
18,518,016	18,508,288	-9,728	-0.053%	System.IO.MemoryMappedFiles.Tests.exe
18,693,632	18,683,904	-9,728	-0.052%	Microsoft.Extensions.Logging.Console.Tests.exe
18,032,128	18,022,912	-9,216	-0.051%	Microsoft.Extensions.Diagnostics.Tests.exe
16,107,008	16,098,816	-8,192	-0.051%	System.Data.Odbc.Tests.exe
24,284,672	24,272,384	-12,288	-0.051%	Microsoft.Extensions.Http.Tests.exe
20,532,736	20,522,496	-10,240	-0.050%	System.Runtime.Extensions.Tests.exe
18,371,584	18,362,368	-9,216	-0.050%	System.Threading.Tests.exe
18,356,736	18,347,520	-9,216	-0.050%	Microsoft.Extensions.FileProviders.Composite.Tests.exe
18,381,824	18,372,608	-9,216	-0.050%	Microsoft.Extensions.Primitives.Tests.exe
11,331,072	11,325,440	-5,632	-0.050%	System.Net.WebSockets.Tests.exe
19,295,744	19,286,016	-9,728	-0.050%	System.Net.Primitives.Functional.Tests.exe
19,972,608	19,962,880	-9,728	-0.049%	Microsoft.Extensions.Logging.Tests.exe
11,588,096	11,582,464	-5,632	-0.049%	System.Net.Http.Json.Unit.Tests.exe
19,744,768	19,735,040	-9,728	-0.049%	System.Resources.ResourceManager.Tests.exe
9,334,784	9,330,176	-4,608	-0.049%	Microsoft.Extensions.Diagnostics.Abstractions.Tests.exe
18,833,920	18,824,704	-9,216	-0.049%	System.Runtime.Caching.Tests.exe
19,080,192	19,070,976	-9,216	-0.048%	Microsoft.Extensions.Hosting.WindowsServices.Tests.exe
9,660,416	9,655,808	-4,608	-0.048%	Microsoft.Extensions.Hosting.Functional.Tests.exe
20,475,904	20,466,176	-9,728	-0.048%	System.Diagnostics.DiagnosticSource.Tests.exe
20,741,632	20,731,904	-9,728	-0.047%	System.Collections.Concurrent.Tests.exe
10,106,368	10,101,760	-4,608	-0.046%	Microsoft.Extensions.Caching.Memory.Tests.exe
20,234,752	20,225,536	-9,216	-0.046%	System.Runtime.InteropServices.Tests.exe
20,454,912	20,445,696	-9,216	-0.045%	System.Reflection.Tests.exe
19,486,208	19,477,504	-8,704	-0.045%	Microsoft.Extensions.Configuration.UserSecrets.Tests.exe
11,274,240	11,269,120	-5,120	-0.045%	System.IO.Compression.Brotli.Tests.exe
19,555,840	19,547,136	-8,704	-0.045%	Microsoft.Extensions.Configuration.Json.Tests.exe
23,405,056	23,394,816	-10,240	-0.044%	System.Memory.Tests.exe
25,891,328	25,880,064	-11,264	-0.044%	System.Text.Json.SourceGeneration.Roslyn3.11.Tests.exe
10,510,336	10,505,728	-4,608	-0.044%	Microsoft.Extensions.Options.Tests.exe
9,442,816	9,438,720	-4,096	-0.043%	Microsoft.Extensions.Logging.Testing.Tests.exe
26,440,704	26,429,440	-11,264	-0.043%	System.ComponentModel.TypeConverter.Tests.exe
21,622,784	21,613,568	-9,216	-0.043%	System.Data.OleDb.Tests.exe
26,006,528	25,996,288	-10,240	-0.039%	System.Globalization.Nls.Tests.exe
20,808,704	20,801,024	-7,680	-0.037%	System.Security.Cryptography.Csp.Tests.exe
29,403,136	29,392,384	-10,752	-0.037%	Microsoft.Extensions.DependencyModel.Tests.exe
26,095,616	26,085,888	-9,728	-0.037%	System.Globalization.Tests.exe
21,072,384	21,064,704	-7,680	-0.036%	Microsoft.Extensions.Logging.EventSource.Tests.exe
45,486,080	45,470,208	-15,872	-0.035%	System.Security.Cryptography.Tests.exe
32,739,840	32,730,112	-9,728	-0.030%	System.Linq.Expressions.Tests.exe
33,385,984	33,376,256	-9,728	-0.029%	Microsoft.Bcl.Cryptography.Tests.exe
44,704,768	44,693,504	-11,264	-0.025%	System.Runtime.Tests.exe
2,233,344	2,232,832	-512	-0.023%	clrjit.dll
10,494,464	10,492,928	-1,536	-0.015%	System.Net.Http.WinHttpHandler.Unit.Tests.exe
10,586,112	10,584,576	-1,536	-0.015%	Common.Tests.exe
9,026,048	9,025,024	-1,024	-0.011%	Microsoft.Extensions.FileSystemGlobbing.Tests.exe
9,347,584	9,346,560	-1,024	-0.011%	System.Security.Permissions.Tests.exe
9,612,800	9,611,776	-1,024	-0.011%	System.Diagnostics.EventLog.Tests.exe
12,185,088	12,184,064	-1,024	-0.008%	System.Net.NetworkInformation.Functional.Tests.exe
15,386,112	15,385,088	-1,024	-0.007%	System.Globalization.Extensions.Nls.Tests.exe
15,386,112	15,385,088	-1,024	-0.007%	System.Globalization.Extensions.Tests.exe
8,743,936	8,743,424	-512	-0.006%	Invariant.Tests.exe
8,975,872	8,975,360	-512	-0.006%	System.Net.Primitives.Pal.Tests.exe
8,798,208	8,797,696	-512	-0.006%	System.Resources.Reader.Tests.exe
8,667,136	8,666,624	-512	-0.006%	System.Runtime.CompilerServices.Unsafe.Tests.exe
8,916,480	8,915,968	-512	-0.006%	System.IO.Pipes.AccessControl.Tests.exe
9,027,072	9,026,560	-512	-0.006%	System.Net.NameResolution.Pal.Tests.exe
9,191,936	9,191,424	-512	-0.006%	Microsoft.Extensions.Configuration.EnvironmentVariables.Tests.exe
8,763,904	8,763,392	-512	-0.006%	Microsoft.Bcl.TimeProvider.Tests.exe
8,609,792	8,609,280	-512	-0.006%	System.Composition.Runtime.Tests.exe
9,129,472	9,128,960	-512	-0.006%	System.Security.AccessControl.Tests.exe
8,803,328	8,802,816	-512	-0.006%	System.Web.HttpUtility.Tests.exe
9,041,920	9,041,408	-512	-0.006%	Microsoft.Extensions.Configuration.CommandLine.Tests.exe
8,638,464	8,637,952	-512	-0.006%	System.Globalization.CalendarsWithConfigSwitch.Tests.exe
8,533,504	8,532,992	-512	-0.006%	System.ComponentModel.Tests.exe
8,686,592	8,686,080	-512	-0.006%	System.Security.Cryptography.ProtectedData.Tests.exe
8,755,712	8,755,200	-512	-0.006%	System.IO.FileSystem.DriveInfo.Tests.exe
8,977,408	8,976,896	-512	-0.006%	Microsoft.Win32.Registry.Tests.exe
8,685,568	8,685,056	-512	-0.006%	System.IO.FileSystem.Manual.Tests.exe
9,095,680	9,095,168	-512	-0.006%	System.IO.FileSystem.AccessControl.Tests.exe
10,048,512	10,048,000	-512	-0.005%	System.Diagnostics.Debug.Tests.exe
11,179,520	11,179,008	-512	-0.005%	System.Text.Encodings.Web.Tests.exe
11,034,112	11,033,600	-512	-0.005%	System.Runtime.Numerics.Tests.exe
11,363,328	11,362,816	-512	-0.005%	System.Net.Security.Unit.Tests.exe
9,337,344	9,336,832	-512	-0.005%	System.IO.IsolatedStorage.Tests.exe
9,748,992	9,749,504	+512	+0.005%	System.Formats.Asn1.Tests.exe
9,473,536	9,473,024	-512	-0.005%	Microsoft.Extensions.Configuration.Ini.Tests.exe
10,936,320	10,935,808	-512	-0.005%	System.Runtime.Intrinsics.Tests.exe
9,571,328	9,570,816	-512	-0.005%	System.Memory.Data.Tests.exe
9,660,928	9,660,416	-512	-0.005%	System.IO.UnmanagedMemoryStream.Tests.exe
9,524,736	9,524,224	-512	-0.005%	System.IO.Hashing.Tests.exe
9,361,920	9,361,408	-512	-0.005%	System.Net.Mail.Unit.Tests.exe
11,590,144	11,589,632	-512	-0.004%	System.Resources.Extensions.Tests.exe
11,469,312	11,468,800	-512	-0.004%	System.IO.Ports.Tests.exe
11,779,072	11,778,560	-512	-0.004%	System.Security.Cryptography.Cose.Tests.exe
17,824,768	17,824,256	-512	-0.003%	System.Collections.Tests.exe
18,770,432	18,770,944	+512	+0.003%	System.Numerics.Vectors.Tests.exe
22,320,640	22,320,128	-512	-0.002%	System.Security.Cryptography.Pkcs.Tests.exe
8,988,672	8,988,672	0	0.000%	System.Runtime.Serialization.Primitives.Tests.exe
8,690,176	8,690,176	0	0.000%	System.Security.SecureString.Tests.exe
9,201,664	9,201,664	0	0.000%	System.ServiceProcess.ServiceController.Tests.exe
7,318,016	7,318,016	0	0.000%	XUnitLogChecker.exe
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
84,480	84,480	0	0.000%	System.Globalization.Native.dll
108,032	108,032	0	0.000%	CMakeCXXCompilerId.exe
108,032	108,032	0	0.000%	CMakeCCompilerId.exe
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
8,673,280	8,673,280	0	0.000%	System.Runtime.InteropServices.ComDisabled.Tests.exe
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
8,608,768	8,608,768	0	0.000%	System.Xml.Linq.Axes.Tests.exe
9,069,056	9,069,056	0	0.000%	System.ValueTuple.Tests.exe
8,945,152	8,945,152	0	0.000%	System.Threading.AccessControl.Tests.exe
9,690,112	9,690,112	0	0.000%	System.Text.RegularExpressions.Unit.Tests.exe
8,543,232	8,543,232	0	0.000%	System.Text.Encoding.Extensions.Tests.exe
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
536,096	536,096	0	0.000%	msquic.dll
8,529,408	8,529,408	0	0.000%	System.IO.FileSystem.Primitives.Tests.exe
8,532,480	8,532,480	0	0.000%	System.Runtime.CompilerServices.VisualC.Tests.exe
536,096	536,096	0	0.000%	msquic.dll
1,308,672	1,308,672	0	0.000%	mscordbi.dll
1,501,696	1,501,696	0	0.000%	mscordaccore.dll
1,501,696	1,501,696	0	0.000%	mscordaccore_amd64_amd64_42.42.42.42424.dll
361,984	361,984	0	0.000%	hostpolicy.dll
350,208	350,208	0	0.000%	hostfxr.dll
62,464	62,464	0	0.000%	createdump.exe
210,944	210,944	0	0.000%	corerun.exe
4,955,648	4,955,648	0	0.000%	coreclr.dll
722,944	722,944	0	0.000%	clrgcexp.dll
678,400	678,400	0	0.000%	clrgc.dll
307,200	307,200	0	0.000%	clretwrc.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
84,480	84,480	0	0.000%	System.Globalization.Native.dll
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
696,320	696,320	0	0.000%	FileCheck.exe
9,956,352	9,956,352	0	0.000%	llvm-mca.exe
13,419,520	13,419,520	0	0.000%	crossgen2.exe
7,703,040	7,703,040	0	0.000%	ilasm.exe
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
15,940,096	15,940,096	0	0.000%	ilc.exe
8,938,496	8,938,496	0	0.000%	Microsoft.Bcl.Memory.Tests.exe
8,578,048	8,578,048	0	0.000%	Microsoft.Bcl.Numerics.Tests.exe
8,587,264	8,587,264	0	0.000%	Microsoft.Extensions.Hosting.Abstractions.Tests.exe
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
9,947,648	9,947,648	0	0.000%	LibraryImportGenerator.Tests.exe
8,655,872	8,655,872	0	0.000%	System.Runtime.Handles.Tests.exe
16,973,824	16,973,824	0	0.000%	System.Private.CoreLib.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
8,591,360	8,591,360	0	0.000%	System.Resources.Writer.Tests.exe
9,011,200	9,011,200	0	0.000%	System.Reflection.TypeExtensions.Tests.exe
12,271,104	12,271,104	0	0.000%	System.Reflection.Metadata.Tests.exe
8,849,920	8,849,920	0	0.000%	System.Reflection.Extensions.Tests.exe
9,350,656	9,350,656	0	0.000%	System.Reflection.Context.Tests.exe
8,704,512	8,704,512	0	0.000%	System.Private.Uri.Unit.Tests.exe
9,631,744	9,631,744	0	0.000%	System.Private.Uri.Functional.Tests.exe
9,785,856	9,785,856	0	0.000%	System.Net.WebProxy.Tests.exe
8,627,200	8,627,200	0	0.000%	System.Net.WebHeaderCollection.Tests.exe
9,300,992	9,300,992	0	0.000%	System.Net.Primitives.UnitTests.Tests.exe
15,486,976	15,486,976	0	0.000%	System.Linq.Tests.exe
696,320	696,320	0	0.000%	FileCheck.exe
9,150,976	9,150,976	0	0.000%	System.Globalization.Calendars.Tests.exe
9,837,568	9,837,568	0	0.000%	System.Formats.Nrbf.Tests.exe
8,534,528	8,534,528	0	0.000%	System.Diagnostics.Tools.Tests.exe
8,702,464	8,702,464	0	0.000%	System.Diagnostics.FileVersionInfo.Tests.exe
8,547,840	8,547,840	0	0.000%	System.Diagnostics.Contracts.Tests.exe
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
8,649,216	8,649,216	0	0.000%	Microsoft.Win32.Primitives.Tests.exe
9,934,336	9,934,336	0	0.000%	System.Collections.NonGeneric.Tests.exe
9,734,656	9,734,656	0	0.000%	System.Collections.Specialized.Tests.exe
9,147,392	9,147,392	0	0.000%	System.ComponentModel.Primitives.Tests.exe
8,544,768	8,544,768	0	0.000%	System.Composition.AttributeModel.Tests.exe
9,615,872	9,615,872	0	0.000%	System.Composition.Convention.Tests.exe
8,821,760	8,821,760	0	0.000%	System.Console.Manual.Tests.exe
8,632,832	8,632,832	0	0.000%	Microsoft.Win32.Registry.AccessControl.Tests.exe
9,956,352	9,956,352	0	0.000%	llvm-mca.exe

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR changes CoreCLR runtime-async suspension/resumption so the dispatcher (managed AsyncHelpers) restores ExecutionContext, instead of having interpreter/JIT resumption stubs call a restore helper. The continuation’s flags now encode the ExecutionContext storage slot, enabling the dispatcher to restore without an extra TLS lookup + helper call on the hot resumption path.

Changes:

• Add continuation support for locating/storing the ExecutionContext via encoded indices in continuation flags (VM + managed + JIT + interpreter).
• Remove RestoreExecutionContext calls from interpreter and JIT resumption code; add restoration to the dispatcher loop.
• Preserve BBF_ASYNC_RESUMPTION across certain flow optimizations that may bypass resumption stubs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/object.h	Adds VM helper to locate ExecutionContext storage in a continuation via encoded flag bits.
src/coreclr/vm/interpexec.cpp	Writes captured ExecutionContext via the encoded slot; removes interpreter-side restore on resume.
src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs	Moves ExecutionContext restore into dispatcher; adjusts flag layout and RestoreExecutionContext signature to avoid TLS lookup.
src/coreclr/jit/fgopt.cpp	Copies BBF_ASYNC_RESUMPTION during certain jump/switch/flow optimizations to preserve async side-entry affordances.
src/coreclr/jit/async.cpp	Updates continuation layout/flag encoding for ExecutionContext; removes JIT-side restore on resumption.
src/coreclr/interpreter/inc/interpretershared.h	Removes interpreter suspend-data field that stored a raw execution-context offset.
src/coreclr/interpreter/compiler.cpp	Encodes ExecutionContext slot in flags and updates interpreter continuation layout accordingly.
src/coreclr/inc/corinfo.h	Updates CorInfoContinuationFlags bit assignments to include ExecutionContext index encoding.

Comments suppressed due to low confidence (2)

src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs:554

• RuntimeAsyncStackState contains managed reference fields, but this local is left uninitialized before its address is stored in TLS (awaitState.Push(&stackState)). This can expose garbage references to the GC (and Push only initializes a subset of fields), risking GC crashes/corruption. Initialize stackState to default (or otherwise fully clear all reference fields before any GC safepoint) before calling Push.

 RuntimeAsyncStackState stackState;
ref RuntimeAsyncAwaitState awaitState = ref t_runtimeAsyncAwaitState;
awaitState.Push(&stackState);

src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs:655

• Same issue as in DispatchContinuations: RuntimeAsyncStackState stackState; is uninitialized even though the struct contains managed references and its address is pushed into TLS via awaitState.Push(&stackState). This can leave garbage object references visible to the GC until fields are explicitly set. Ensure stackState is zero-initialized (e.g., = default) or otherwise cleared before pushing.

 RuntimeAsyncStackState stackState;
ref RuntimeAsyncAwaitState awaitState = ref t_runtimeAsyncAwaitState;
awaitState.Push(&stackState);

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/coreclr/interpreter/compiler.cpp:6007

• InterpAsyncSuspendData.restoreExecutionContextMethod is still populated, but after removing the interpreter-side RestoreExecutionContext call there don’t appear to be any remaining reads of this field. Consider removing the field from InterpAsyncSuspendData (and this assignment) to reduce per-suspension metadata size and avoid dead state.

 suspendData->keepAliveOffset = keepAliveOffset + OFFSETOF__CORINFO_Continuation__data;
suspendData->captureSyncContextMethod = asyncInfo.captureContinuationContextMethHnd;
suspendData->restoreExecutionContextMethod = asyncInfo.restoreExecutionContextMethHnd;
suspendData->restoreContextsOnSuspensionMethod = asyncInfo.restoreContextsOnSuspensionMethHnd;

[Copilot]

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

src/coreclr/interpreter/compiler.cpp:6007

• CORINFO_ASYNC_INFO no longer exposes restoreExecutionContextMethHnd, but the interpreter still stores asyncInfo.restoreExecutionContextMethHnd into InterpAsyncSuspendData. This will fail to compile and should be removed/rewired now that execution context restoration is done by the dispatcher.

 suspendData->keepAliveOffset = keepAliveOffset + OFFSETOF__CORINFO_Continuation__data;
suspendData->captureSyncContextMethod = asyncInfo.captureContinuationContextMethHnd;
suspendData->restoreExecutionContextMethod = asyncInfo.restoreExecutionContextMethHnd;
suspendData->restoreContextsOnSuspensionMethod = asyncInfo.restoreContextsOnSuspensionMethHnd;

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

[jakobbotsch]

PTAL @VSadov (async) @AndyAyersMS (JIT) @davidwrighton /@janvorli (interpreter)

[AndyAyersMS]

JIT changes look good.

[VSadov]

LGTM. Thanks!

[jakobbotsch]

Will merge this, @janvorli@davidwrighton let me know if you have any comments on the interpreter change and I can address it in a follow-up.

[jakobbotsch]

Remove RestoreExecutionContext call from JIT resumption code and from the interpreter. Instead encode the ExecutionContext's location in the continuation and let the dispatcher restore it. This removes a TLS access + helper call from the resumption path (avoiding the TLS and inlining the helper call in the dispatcher).

Improves suspension/resumption performance by about 7-8% and is also a good size improvement. Removing the call from the resumption path allows keeping the continuation in a volatile register, which also helps register allocation in a number of cases.

Diffs before JIT-EE GUID update

Micro benchmark with warmup

usingSystem;usingSystem.Diagnostics;usingSystem.Runtime.CompilerServices;usingSystem.Threading;usingSystem.Threading.Tasks;namespaceAsyncMicro;publicclassProgram{staticvoidMain(){NullAwaiterna=newNullAwaiter();for(inti=0;i<10;i++){for(intj=0;j<100;j++){Taskt=Foo(100,na);while(!t.IsCompleted){na.Continue();}}Thread.Sleep(100);}for(inti=0;i<50;i++){Taskt=Foo(10_000_000,na);while(!t.IsCompleted){na.Continue();}}}staticints_value;staticasyncTaskFoo(intn,NullAwaiterna){for(inti=0;i<n;i++){s_value+=i;}Stopwatchtimer=Stopwatch.StartNew();for(inti=0;i<n;i++){awaitna;}if(n>100)Console.WriteLine("Took {0:F1} ms",timer.Elapsed.TotalMilliseconds);}privateclassNullAwaiter:ICriticalNotifyCompletion{publicActionContinue;publicNullAwaiterGetAwaiter()=>this;publicboolIsCompleted=>false;publicvoidGetResult(){}publicvoidUnsafeOnCompleted(Actioncontinuation){Continue=continuation;}publicvoidOnCompleted(Actioncontinuation){thrownewNotImplementedException();}}}

About 7-8% improvement:

-Took 268.5 ms-Took 265.9 ms-Took 267.9 ms-Took 270.0 ms-Took 269.4 ms+Took 249.4 ms+Took 248.3 ms+Took 250.3 ms+Took 249.2 ms+Took 248.9 ms

NativeAOT test sizes

BaseSize	DiffSize	Delta	Percent	Name
31,037,440	30,944,256	-93,184	-0.300%	System.Net.Http.Functional.Tests.exe
16,847,872	16,803,328	-44,544	-0.264%	System.Linq.AsyncEnumerable.Tests.exe
115,269,120	115,089,408	-179,712	-0.156%	System.Text.Json.SourceGeneration.Roslyn4.4.Tests.exe
20,942,336	20,912,640	-29,696	-0.142%	System.Net.Quic.Functional.Tests.exe
20,033,024	20,005,376	-27,648	-0.138%	System.Formats.Tar.Tests.exe
19,558,912	19,533,824	-25,088	-0.128%	System.IO.Compression.Tests.exe
10,055,168	10,042,880	-12,288	-0.122%	System.IO.Compression.ZipFile.Tests.exe
14,901,760	14,883,840	-17,920	-0.120%	System.Xml.Linq.Streaming.Tests.exe
16,778,752	16,758,784	-19,968	-0.119%	System.Xml.Linq.Misc.Tests.exe
28,789,760	28,757,504	-32,256	-0.112%	System.Net.Http.WinHttpHandler.Functional.Tests.exe
16,516,608	16,498,176	-18,432	-0.112%	System.Xml.Linq.Events.Tests.exe
17,065,472	17,046,528	-18,944	-0.111%	System.Xml.Linq.xNodeBuilder.Tests.exe
22,732,800	22,708,224	-24,576	-0.108%	System.Net.Sockets.Tests.exe
16,671,744	16,653,824	-17,920	-0.107%	System.Xml.Linq.Properties.Tests.exe
17,123,840	17,105,920	-17,920	-0.105%	System.Xml.Linq.TreeManipulation.Tests.exe
17,007,616	16,989,696	-17,920	-0.105%	System.Xml.Linq.xNodeReader.Tests.exe
20,003,840	19,982,848	-20,992	-0.105%	System.Net.WebSockets.Client.Tests.exe
19,053,056	19,034,112	-18,944	-0.099%	System.Net.HttpListener.Tests.exe
10,660,864	10,650,624	-10,240	-0.096%	System.IO.Pipelines.Tests.exe
20,267,008	20,248,064	-18,944	-0.093%	System.Threading.Tasks.Dataflow.Tests.exe
17,728,512	17,713,664	-14,848	-0.084%	System.Threading.Tasks.Extensions.Tests.exe
14,569,472	14,557,696	-11,776	-0.081%	System.Net.WebClient.Tests.exe
11,992,064	11,982,336	-9,728	-0.081%	System.IO.Tests.exe
21,089,792	21,072,896	-16,896	-0.080%	System.Net.Requests.Tests.exe
21,708,800	21,691,392	-17,408	-0.080%	System.IO.FileSystem.Tests.exe
10,278,912	10,270,720	-8,192	-0.080%	System.Threading.Channels.Tests.exe
27,894,272	27,874,304	-19,968	-0.072%	System.Net.Security.Tests.exe
18,447,872	18,434,560	-13,312	-0.072%	System.Threading.Tasks.Parallel.Tests.exe
13,242,368	13,233,152	-9,216	-0.070%	System.IO.Packaging.Tests.exe
9,731,072	9,724,416	-6,656	-0.068%	System.Threading.RateLimiting.Tests.exe
33,165,312	33,142,784	-22,528	-0.068%	System.Private.Xml.Tests.exe
13,869,056	13,859,840	-9,216	-0.066%	Microsoft.Extensions.Configuration.Functional.Tests.exe
19,545,600	19,532,800	-12,800	-0.065%	System.Diagnostics.Process.Tests.exe
12,849,664	12,841,472	-8,192	-0.064%	System.Xml.Schema.Extensions.Tests.exe
12,416,000	12,408,320	-7,680	-0.062%	System.Xml.Linq.SDMSample.Tests.exe
17,431,552	17,420,800	-10,752	-0.062%	System.Net.Ping.Functional.Tests.exe
20,540,416	20,527,616	-12,800	-0.062%	System.Threading.Tasks.Tests.exe
15,759,872	15,750,144	-9,728	-0.062%	System.Windows.Extensions.Tests.exe
10,056,192	10,050,048	-6,144	-0.061%	System.Net.ServerSentEvents.Tests.exe
15,102,464	15,093,248	-9,216	-0.061%	System.Drawing.Primitives.Tests.exe
17,571,840	17,561,088	-10,752	-0.061%	MetricOuterLoop1.Tests.exe
17,566,720	17,555,968	-10,752	-0.061%	MetricOuterLoop.Tests.exe
19,289,600	19,277,824	-11,776	-0.061%	System.IO.Pipes.Tests.exe
17,791,488	17,780,736	-10,752	-0.060%	System.Formats.Tar.Manual.Tests.exe
17,967,616	17,956,864	-10,752	-0.060%	System.Threading.ThreadPool.WindowsThreadPool.Tests.exe
17,329,152	17,318,912	-10,240	-0.059%	System.Threading.Timer.Tests.exe
14,130,176	14,121,984	-8,192	-0.058%	System.DirectoryServices.Protocols.Tests.exe
17,616,896	17,606,656	-10,240	-0.058%	System.Threading.Thread.Tests.exe
19,681,792	19,670,528	-11,264	-0.057%	System.Net.Http.Unit.Tests.exe
17,160,192	17,150,464	-9,728	-0.057%	System.Runtime.Serialization.Formatters.Disabled.Tests.exe
17,967,104	17,956,864	-10,240	-0.057%	System.Threading.ThreadPool.Tests.exe
19,870,720	19,859,456	-11,264	-0.057%	System.Text.Encoding.Tests.exe
18,774,016	18,763,264	-10,752	-0.057%	Microsoft.Extensions.FileProviders.Physical.Tests.exe
27,160,064	27,144,704	-15,360	-0.057%	Microsoft.Extensions.Hosting.Unit.Tests.exe
17,214,976	17,205,248	-9,728	-0.057%	System.Net.ServicePoint.Tests.exe
17,312,768	17,303,040	-9,728	-0.056%	System.Security.Principal.Windows.Tests.exe
17,230,848	17,221,120	-9,728	-0.056%	System.ComponentModel.EventBasedAsync.Tests.exe
18,128,896	18,118,656	-10,240	-0.056%	System.Diagnostics.TextWriterTraceListener.Tests.exe
17,298,944	17,289,216	-9,728	-0.056%	System.Security.Claims.Tests.exe
17,431,040	17,421,312	-9,728	-0.056%	System.Diagnostics.TraceSource.Tests.exe
17,282,048	17,272,320	-9,728	-0.056%	System.Threading.Overlapped.Tests.exe
18,177,536	18,167,296	-10,240	-0.056%	System.Text.Encoding.CodePages.Tests.exe
17,356,288	17,346,560	-9,728	-0.056%	Microsoft.Win32.SystemEvents.Tests.exe
18,586,624	18,576,384	-10,240	-0.055%	ComInterfaceGenerator.Tests.exe
17,661,440	17,651,712	-9,728	-0.055%	System.IO.FileSystem.Watcher.Tests.exe
9,251,840	9,246,720	-5,120	-0.055%	Microsoft.Bcl.AsyncInterfaces.Tests.exe
13,941,248	13,933,568	-7,680	-0.055%	Microsoft.Extensions.Configuration.Xml.Tests.exe
18,492,928	18,482,688	-10,240	-0.055%	Microsoft.Extensions.Configuration.Tests.exe
17,662,976	17,653,248	-9,728	-0.055%	System.Buffers.Tests.exe
18,489,344	18,479,104	-10,240	-0.055%	Microsoft.Extensions.Hosting.Systemd.Tests.exe
15,080,448	15,072,256	-8,192	-0.054%	System.Security.Cryptography.Cng.Tests.exe
17,154,048	17,144,832	-9,216	-0.054%	IcuAppLocal.Tests.exe
15,039,488	15,031,296	-8,192	-0.054%	System.Data.DataSetExtensions.Tests.exe
18,062,336	18,052,608	-9,728	-0.054%	System.Console.Tests.exe
17,288,192	17,278,976	-9,216	-0.053%	System.Runtime.InteropServices.RuntimeInformation.Tests.exe
17,361,408	17,352,192	-9,216	-0.053%	System.Diagnostics.StackTrace.Tests.exe
18,455,552	18,445,824	-9,728	-0.053%	Microsoft.Extensions.Configuration.FileExtensions.Tests.exe
17,235,968	17,226,752	-9,216	-0.053%	System.Runtime.InvariantTimezone.Tests.exe
18,518,016	18,508,288	-9,728	-0.053%	System.IO.MemoryMappedFiles.Tests.exe
18,693,632	18,683,904	-9,728	-0.052%	Microsoft.Extensions.Logging.Console.Tests.exe
18,032,128	18,022,912	-9,216	-0.051%	Microsoft.Extensions.Diagnostics.Tests.exe
16,107,008	16,098,816	-8,192	-0.051%	System.Data.Odbc.Tests.exe
24,284,672	24,272,384	-12,288	-0.051%	Microsoft.Extensions.Http.Tests.exe
20,532,736	20,522,496	-10,240	-0.050%	System.Runtime.Extensions.Tests.exe
18,371,584	18,362,368	-9,216	-0.050%	System.Threading.Tests.exe
18,356,736	18,347,520	-9,216	-0.050%	Microsoft.Extensions.FileProviders.Composite.Tests.exe
18,381,824	18,372,608	-9,216	-0.050%	Microsoft.Extensions.Primitives.Tests.exe
11,331,072	11,325,440	-5,632	-0.050%	System.Net.WebSockets.Tests.exe
19,295,744	19,286,016	-9,728	-0.050%	System.Net.Primitives.Functional.Tests.exe
19,972,608	19,962,880	-9,728	-0.049%	Microsoft.Extensions.Logging.Tests.exe
11,588,096	11,582,464	-5,632	-0.049%	System.Net.Http.Json.Unit.Tests.exe
19,744,768	19,735,040	-9,728	-0.049%	System.Resources.ResourceManager.Tests.exe
9,334,784	9,330,176	-4,608	-0.049%	Microsoft.Extensions.Diagnostics.Abstractions.Tests.exe
18,833,920	18,824,704	-9,216	-0.049%	System.Runtime.Caching.Tests.exe
19,080,192	19,070,976	-9,216	-0.048%	Microsoft.Extensions.Hosting.WindowsServices.Tests.exe
9,660,416	9,655,808	-4,608	-0.048%	Microsoft.Extensions.Hosting.Functional.Tests.exe
20,475,904	20,466,176	-9,728	-0.048%	System.Diagnostics.DiagnosticSource.Tests.exe
20,741,632	20,731,904	-9,728	-0.047%	System.Collections.Concurrent.Tests.exe
10,106,368	10,101,760	-4,608	-0.046%	Microsoft.Extensions.Caching.Memory.Tests.exe
20,234,752	20,225,536	-9,216	-0.046%	System.Runtime.InteropServices.Tests.exe
20,454,912	20,445,696	-9,216	-0.045%	System.Reflection.Tests.exe
19,486,208	19,477,504	-8,704	-0.045%	Microsoft.Extensions.Configuration.UserSecrets.Tests.exe
11,274,240	11,269,120	-5,120	-0.045%	System.IO.Compression.Brotli.Tests.exe
19,555,840	19,547,136	-8,704	-0.045%	Microsoft.Extensions.Configuration.Json.Tests.exe
23,405,056	23,394,816	-10,240	-0.044%	System.Memory.Tests.exe
25,891,328	25,880,064	-11,264	-0.044%	System.Text.Json.SourceGeneration.Roslyn3.11.Tests.exe
10,510,336	10,505,728	-4,608	-0.044%	Microsoft.Extensions.Options.Tests.exe
9,442,816	9,438,720	-4,096	-0.043%	Microsoft.Extensions.Logging.Testing.Tests.exe
26,440,704	26,429,440	-11,264	-0.043%	System.ComponentModel.TypeConverter.Tests.exe
21,622,784	21,613,568	-9,216	-0.043%	System.Data.OleDb.Tests.exe
26,006,528	25,996,288	-10,240	-0.039%	System.Globalization.Nls.Tests.exe
20,808,704	20,801,024	-7,680	-0.037%	System.Security.Cryptography.Csp.Tests.exe
29,403,136	29,392,384	-10,752	-0.037%	Microsoft.Extensions.DependencyModel.Tests.exe
26,095,616	26,085,888	-9,728	-0.037%	System.Globalization.Tests.exe
21,072,384	21,064,704	-7,680	-0.036%	Microsoft.Extensions.Logging.EventSource.Tests.exe
45,486,080	45,470,208	-15,872	-0.035%	System.Security.Cryptography.Tests.exe
32,739,840	32,730,112	-9,728	-0.030%	System.Linq.Expressions.Tests.exe
33,385,984	33,376,256	-9,728	-0.029%	Microsoft.Bcl.Cryptography.Tests.exe
44,704,768	44,693,504	-11,264	-0.025%	System.Runtime.Tests.exe
2,233,344	2,232,832	-512	-0.023%	clrjit.dll
10,494,464	10,492,928	-1,536	-0.015%	System.Net.Http.WinHttpHandler.Unit.Tests.exe
10,586,112	10,584,576	-1,536	-0.015%	Common.Tests.exe
9,026,048	9,025,024	-1,024	-0.011%	Microsoft.Extensions.FileSystemGlobbing.Tests.exe
9,347,584	9,346,560	-1,024	-0.011%	System.Security.Permissions.Tests.exe
9,612,800	9,611,776	-1,024	-0.011%	System.Diagnostics.EventLog.Tests.exe
12,185,088	12,184,064	-1,024	-0.008%	System.Net.NetworkInformation.Functional.Tests.exe
15,386,112	15,385,088	-1,024	-0.007%	System.Globalization.Extensions.Nls.Tests.exe
15,386,112	15,385,088	-1,024	-0.007%	System.Globalization.Extensions.Tests.exe
8,743,936	8,743,424	-512	-0.006%	Invariant.Tests.exe
8,975,872	8,975,360	-512	-0.006%	System.Net.Primitives.Pal.Tests.exe
8,798,208	8,797,696	-512	-0.006%	System.Resources.Reader.Tests.exe
8,667,136	8,666,624	-512	-0.006%	System.Runtime.CompilerServices.Unsafe.Tests.exe
8,916,480	8,915,968	-512	-0.006%	System.IO.Pipes.AccessControl.Tests.exe
9,027,072	9,026,560	-512	-0.006%	System.Net.NameResolution.Pal.Tests.exe
9,191,936	9,191,424	-512	-0.006%	Microsoft.Extensions.Configuration.EnvironmentVariables.Tests.exe
8,763,904	8,763,392	-512	-0.006%	Microsoft.Bcl.TimeProvider.Tests.exe
8,609,792	8,609,280	-512	-0.006%	System.Composition.Runtime.Tests.exe
9,129,472	9,128,960	-512	-0.006%	System.Security.AccessControl.Tests.exe
8,803,328	8,802,816	-512	-0.006%	System.Web.HttpUtility.Tests.exe
9,041,920	9,041,408	-512	-0.006%	Microsoft.Extensions.Configuration.CommandLine.Tests.exe
8,638,464	8,637,952	-512	-0.006%	System.Globalization.CalendarsWithConfigSwitch.Tests.exe
8,533,504	8,532,992	-512	-0.006%	System.ComponentModel.Tests.exe
8,686,592	8,686,080	-512	-0.006%	System.Security.Cryptography.ProtectedData.Tests.exe
8,755,712	8,755,200	-512	-0.006%	System.IO.FileSystem.DriveInfo.Tests.exe
8,977,408	8,976,896	-512	-0.006%	Microsoft.Win32.Registry.Tests.exe
8,685,568	8,685,056	-512	-0.006%	System.IO.FileSystem.Manual.Tests.exe
9,095,680	9,095,168	-512	-0.006%	System.IO.FileSystem.AccessControl.Tests.exe
10,048,512	10,048,000	-512	-0.005%	System.Diagnostics.Debug.Tests.exe
11,179,520	11,179,008	-512	-0.005%	System.Text.Encodings.Web.Tests.exe
11,034,112	11,033,600	-512	-0.005%	System.Runtime.Numerics.Tests.exe
11,363,328	11,362,816	-512	-0.005%	System.Net.Security.Unit.Tests.exe
9,337,344	9,336,832	-512	-0.005%	System.IO.IsolatedStorage.Tests.exe
9,748,992	9,749,504	+512	+0.005%	System.Formats.Asn1.Tests.exe
9,473,536	9,473,024	-512	-0.005%	Microsoft.Extensions.Configuration.Ini.Tests.exe
10,936,320	10,935,808	-512	-0.005%	System.Runtime.Intrinsics.Tests.exe
9,571,328	9,570,816	-512	-0.005%	System.Memory.Data.Tests.exe
9,660,928	9,660,416	-512	-0.005%	System.IO.UnmanagedMemoryStream.Tests.exe
9,524,736	9,524,224	-512	-0.005%	System.IO.Hashing.Tests.exe
9,361,920	9,361,408	-512	-0.005%	System.Net.Mail.Unit.Tests.exe
11,590,144	11,589,632	-512	-0.004%	System.Resources.Extensions.Tests.exe
11,469,312	11,468,800	-512	-0.004%	System.IO.Ports.Tests.exe
11,779,072	11,778,560	-512	-0.004%	System.Security.Cryptography.Cose.Tests.exe
17,824,768	17,824,256	-512	-0.003%	System.Collections.Tests.exe
18,770,432	18,770,944	+512	+0.003%	System.Numerics.Vectors.Tests.exe
22,320,640	22,320,128	-512	-0.002%	System.Security.Cryptography.Pkcs.Tests.exe
8,988,672	8,988,672	0	0.000%	System.Runtime.Serialization.Primitives.Tests.exe
8,690,176	8,690,176	0	0.000%	System.Security.SecureString.Tests.exe
9,201,664	9,201,664	0	0.000%	System.ServiceProcess.ServiceController.Tests.exe
7,318,016	7,318,016	0	0.000%	XUnitLogChecker.exe
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
84,480	84,480	0	0.000%	System.Globalization.Native.dll
108,032	108,032	0	0.000%	CMakeCXXCompilerId.exe
108,032	108,032	0	0.000%	CMakeCCompilerId.exe
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
8,673,280	8,673,280	0	0.000%	System.Runtime.InteropServices.ComDisabled.Tests.exe
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
8,608,768	8,608,768	0	0.000%	System.Xml.Linq.Axes.Tests.exe
9,069,056	9,069,056	0	0.000%	System.ValueTuple.Tests.exe
8,945,152	8,945,152	0	0.000%	System.Threading.AccessControl.Tests.exe
9,690,112	9,690,112	0	0.000%	System.Text.RegularExpressions.Unit.Tests.exe
8,543,232	8,543,232	0	0.000%	System.Text.Encoding.Extensions.Tests.exe
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
536,096	536,096	0	0.000%	msquic.dll
8,529,408	8,529,408	0	0.000%	System.IO.FileSystem.Primitives.Tests.exe
8,532,480	8,532,480	0	0.000%	System.Runtime.CompilerServices.VisualC.Tests.exe
536,096	536,096	0	0.000%	msquic.dll
1,308,672	1,308,672	0	0.000%	mscordbi.dll
1,501,696	1,501,696	0	0.000%	mscordaccore.dll
1,501,696	1,501,696	0	0.000%	mscordaccore_amd64_amd64_42.42.42.42424.dll
361,984	361,984	0	0.000%	hostpolicy.dll
350,208	350,208	0	0.000%	hostfxr.dll
62,464	62,464	0	0.000%	createdump.exe
210,944	210,944	0	0.000%	corerun.exe
4,955,648	4,955,648	0	0.000%	coreclr.dll
722,944	722,944	0	0.000%	clrgcexp.dll
678,400	678,400	0	0.000%	clrgc.dll
307,200	307,200	0	0.000%	clretwrc.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
84,480	84,480	0	0.000%	System.Globalization.Native.dll
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
696,320	696,320	0	0.000%	FileCheck.exe
9,956,352	9,956,352	0	0.000%	llvm-mca.exe
13,419,520	13,419,520	0	0.000%	crossgen2.exe
7,703,040	7,703,040	0	0.000%	ilasm.exe
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
15,940,096	15,940,096	0	0.000%	ilc.exe
8,938,496	8,938,496	0	0.000%	Microsoft.Bcl.Memory.Tests.exe
8,578,048	8,578,048	0	0.000%	Microsoft.Bcl.Numerics.Tests.exe
8,587,264	8,587,264	0	0.000%	Microsoft.Extensions.Hosting.Abstractions.Tests.exe
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
9,947,648	9,947,648	0	0.000%	LibraryImportGenerator.Tests.exe
8,655,872	8,655,872	0	0.000%	System.Runtime.Handles.Tests.exe
16,973,824	16,973,824	0	0.000%	System.Private.CoreLib.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
8,591,360	8,591,360	0	0.000%	System.Resources.Writer.Tests.exe
9,011,200	9,011,200	0	0.000%	System.Reflection.TypeExtensions.Tests.exe
12,271,104	12,271,104	0	0.000%	System.Reflection.Metadata.Tests.exe
8,849,920	8,849,920	0	0.000%	System.Reflection.Extensions.Tests.exe
9,350,656	9,350,656	0	0.000%	System.Reflection.Context.Tests.exe
8,704,512	8,704,512	0	0.000%	System.Private.Uri.Unit.Tests.exe
9,631,744	9,631,744	0	0.000%	System.Private.Uri.Functional.Tests.exe
9,785,856	9,785,856	0	0.000%	System.Net.WebProxy.Tests.exe
8,627,200	8,627,200	0	0.000%	System.Net.WebHeaderCollection.Tests.exe
9,300,992	9,300,992	0	0.000%	System.Net.Primitives.UnitTests.Tests.exe
15,486,976	15,486,976	0	0.000%	System.Linq.Tests.exe
696,320	696,320	0	0.000%	FileCheck.exe
9,150,976	9,150,976	0	0.000%	System.Globalization.Calendars.Tests.exe
9,837,568	9,837,568	0	0.000%	System.Formats.Nrbf.Tests.exe
8,534,528	8,534,528	0	0.000%	System.Diagnostics.Tools.Tests.exe
8,702,464	8,702,464	0	0.000%	System.Diagnostics.FileVersionInfo.Tests.exe
8,547,840	8,547,840	0	0.000%	System.Diagnostics.Contracts.Tests.exe
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
8,649,216	8,649,216	0	0.000%	Microsoft.Win32.Primitives.Tests.exe
9,934,336	9,934,336	0	0.000%	System.Collections.NonGeneric.Tests.exe
9,734,656	9,734,656	0	0.000%	System.Collections.Specialized.Tests.exe
9,147,392	9,147,392	0	0.000%	System.ComponentModel.Primitives.Tests.exe
8,544,768	8,544,768	0	0.000%	System.Composition.AttributeModel.Tests.exe
9,615,872	9,615,872	0	0.000%	System.Composition.Convention.Tests.exe
8,821,760	8,821,760	0	0.000%	System.Console.Manual.Tests.exe
8,632,832	8,632,832	0	0.000%	Microsoft.Win32.Registry.AccessControl.Tests.exe
9,956,352	9,956,352	0	0.000%	llvm-mca.exe

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR changes CoreCLR runtime-async suspension/resumption so the dispatcher (managed AsyncHelpers) restores ExecutionContext, instead of having interpreter/JIT resumption stubs call a restore helper. The continuation’s flags now encode the ExecutionContext storage slot, enabling the dispatcher to restore without an extra TLS lookup + helper call on the hot resumption path.

Changes:

• Add continuation support for locating/storing the ExecutionContext via encoded indices in continuation flags (VM + managed + JIT + interpreter).
• Remove RestoreExecutionContext calls from interpreter and JIT resumption code; add restoration to the dispatcher loop.
• Preserve BBF_ASYNC_RESUMPTION across certain flow optimizations that may bypass resumption stubs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/object.h	Adds VM helper to locate ExecutionContext storage in a continuation via encoded flag bits.
src/coreclr/vm/interpexec.cpp	Writes captured ExecutionContext via the encoded slot; removes interpreter-side restore on resume.
src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs	Moves ExecutionContext restore into dispatcher; adjusts flag layout and RestoreExecutionContext signature to avoid TLS lookup.
src/coreclr/jit/fgopt.cpp	Copies BBF_ASYNC_RESUMPTION during certain jump/switch/flow optimizations to preserve async side-entry affordances.
src/coreclr/jit/async.cpp	Updates continuation layout/flag encoding for ExecutionContext; removes JIT-side restore on resumption.
src/coreclr/interpreter/inc/interpretershared.h	Removes interpreter suspend-data field that stored a raw execution-context offset.
src/coreclr/interpreter/compiler.cpp	Encodes ExecutionContext slot in flags and updates interpreter continuation layout accordingly.
src/coreclr/inc/corinfo.h	Updates CorInfoContinuationFlags bit assignments to include ExecutionContext index encoding.

Comments suppressed due to low confidence (2)

src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs:554

• RuntimeAsyncStackState contains managed reference fields, but this local is left uninitialized before its address is stored in TLS (awaitState.Push(&stackState)). This can expose garbage references to the GC (and Push only initializes a subset of fields), risking GC crashes/corruption. Initialize stackState to default (or otherwise fully clear all reference fields before any GC safepoint) before calling Push.

 RuntimeAsyncStackState stackState;
ref RuntimeAsyncAwaitState awaitState = ref t_runtimeAsyncAwaitState;
awaitState.Push(&stackState);

src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs:655

• Same issue as in DispatchContinuations: RuntimeAsyncStackState stackState; is uninitialized even though the struct contains managed references and its address is pushed into TLS via awaitState.Push(&stackState). This can leave garbage object references visible to the GC until fields are explicitly set. Ensure stackState is zero-initialized (e.g., = default) or otherwise cleared before pushing.

 RuntimeAsyncStackState stackState;
ref RuntimeAsyncAwaitState awaitState = ref t_runtimeAsyncAwaitState;
awaitState.Push(&stackState);

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/coreclr/interpreter/compiler.cpp:6007

• InterpAsyncSuspendData.restoreExecutionContextMethod is still populated, but after removing the interpreter-side RestoreExecutionContext call there don’t appear to be any remaining reads of this field. Consider removing the field from InterpAsyncSuspendData (and this assignment) to reduce per-suspension metadata size and avoid dead state.

 suspendData->keepAliveOffset = keepAliveOffset + OFFSETOF__CORINFO_Continuation__data;
suspendData->captureSyncContextMethod = asyncInfo.captureContinuationContextMethHnd;
suspendData->restoreExecutionContextMethod = asyncInfo.restoreExecutionContextMethHnd;
suspendData->restoreContextsOnSuspensionMethod = asyncInfo.restoreContextsOnSuspensionMethHnd;

[Copilot]

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

src/coreclr/interpreter/compiler.cpp:6007

• CORINFO_ASYNC_INFO no longer exposes restoreExecutionContextMethHnd, but the interpreter still stores asyncInfo.restoreExecutionContextMethHnd into InterpAsyncSuspendData. This will fail to compile and should be removed/rewired now that execution context restoration is done by the dispatcher.

 suspendData->keepAliveOffset = keepAliveOffset + OFFSETOF__CORINFO_Continuation__data;
suspendData->captureSyncContextMethod = asyncInfo.captureContinuationContextMethHnd;
suspendData->restoreExecutionContextMethod = asyncInfo.restoreExecutionContextMethHnd;
suspendData->restoreContextsOnSuspensionMethod = asyncInfo.restoreContextsOnSuspensionMethHnd;

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

[jakobbotsch]

PTAL @VSadov (async) @AndyAyersMS (JIT) @davidwrighton /@janvorli (interpreter)

[AndyAyersMS]

JIT changes look good.

[VSadov]

LGTM. Thanks!

[jakobbotsch]

Will merge this, @janvorli@davidwrighton let me know if you have any comments on the interpreter change and I can address it in a follow-up.

[jakobbotsch]

Remove RestoreExecutionContext call from JIT resumption code and from the interpreter. Instead encode the ExecutionContext's location in the continuation and let the dispatcher restore it. This removes a TLS access + helper call from the resumption path (avoiding the TLS and inlining the helper call in the dispatcher).

Improves suspension/resumption performance by about 7-8% and is also a good size improvement. Removing the call from the resumption path allows keeping the continuation in a volatile register, which also helps register allocation in a number of cases.

Diffs before JIT-EE GUID update

Micro benchmark with warmup

usingSystem;usingSystem.Diagnostics;usingSystem.Runtime.CompilerServices;usingSystem.Threading;usingSystem.Threading.Tasks;namespaceAsyncMicro;publicclassProgram{staticvoidMain(){NullAwaiterna=newNullAwaiter();for(inti=0;i<10;i++){for(intj=0;j<100;j++){Taskt=Foo(100,na);while(!t.IsCompleted){na.Continue();}}Thread.Sleep(100);}for(inti=0;i<50;i++){Taskt=Foo(10_000_000,na);while(!t.IsCompleted){na.Continue();}}}staticints_value;staticasyncTaskFoo(intn,NullAwaiterna){for(inti=0;i<n;i++){s_value+=i;}Stopwatchtimer=Stopwatch.StartNew();for(inti=0;i<n;i++){awaitna;}if(n>100)Console.WriteLine("Took {0:F1} ms",timer.Elapsed.TotalMilliseconds);}privateclassNullAwaiter:ICriticalNotifyCompletion{publicActionContinue;publicNullAwaiterGetAwaiter()=>this;publicboolIsCompleted=>false;publicvoidGetResult(){}publicvoidUnsafeOnCompleted(Actioncontinuation){Continue=continuation;}publicvoidOnCompleted(Actioncontinuation){thrownewNotImplementedException();}}}

About 7-8% improvement:

-Took 268.5 ms-Took 265.9 ms-Took 267.9 ms-Took 270.0 ms-Took 269.4 ms+Took 249.4 ms+Took 248.3 ms+Took 250.3 ms+Took 249.2 ms+Took 248.9 ms

NativeAOT test sizes

BaseSize	DiffSize	Delta	Percent	Name
31,037,440	30,944,256	-93,184	-0.300%	System.Net.Http.Functional.Tests.exe
16,847,872	16,803,328	-44,544	-0.264%	System.Linq.AsyncEnumerable.Tests.exe
115,269,120	115,089,408	-179,712	-0.156%	System.Text.Json.SourceGeneration.Roslyn4.4.Tests.exe
20,942,336	20,912,640	-29,696	-0.142%	System.Net.Quic.Functional.Tests.exe
20,033,024	20,005,376	-27,648	-0.138%	System.Formats.Tar.Tests.exe
19,558,912	19,533,824	-25,088	-0.128%	System.IO.Compression.Tests.exe
10,055,168	10,042,880	-12,288	-0.122%	System.IO.Compression.ZipFile.Tests.exe
14,901,760	14,883,840	-17,920	-0.120%	System.Xml.Linq.Streaming.Tests.exe
16,778,752	16,758,784	-19,968	-0.119%	System.Xml.Linq.Misc.Tests.exe
28,789,760	28,757,504	-32,256	-0.112%	System.Net.Http.WinHttpHandler.Functional.Tests.exe
16,516,608	16,498,176	-18,432	-0.112%	System.Xml.Linq.Events.Tests.exe
17,065,472	17,046,528	-18,944	-0.111%	System.Xml.Linq.xNodeBuilder.Tests.exe
22,732,800	22,708,224	-24,576	-0.108%	System.Net.Sockets.Tests.exe
16,671,744	16,653,824	-17,920	-0.107%	System.Xml.Linq.Properties.Tests.exe
17,123,840	17,105,920	-17,920	-0.105%	System.Xml.Linq.TreeManipulation.Tests.exe
17,007,616	16,989,696	-17,920	-0.105%	System.Xml.Linq.xNodeReader.Tests.exe
20,003,840	19,982,848	-20,992	-0.105%	System.Net.WebSockets.Client.Tests.exe
19,053,056	19,034,112	-18,944	-0.099%	System.Net.HttpListener.Tests.exe
10,660,864	10,650,624	-10,240	-0.096%	System.IO.Pipelines.Tests.exe
20,267,008	20,248,064	-18,944	-0.093%	System.Threading.Tasks.Dataflow.Tests.exe
17,728,512	17,713,664	-14,848	-0.084%	System.Threading.Tasks.Extensions.Tests.exe
14,569,472	14,557,696	-11,776	-0.081%	System.Net.WebClient.Tests.exe
11,992,064	11,982,336	-9,728	-0.081%	System.IO.Tests.exe
21,089,792	21,072,896	-16,896	-0.080%	System.Net.Requests.Tests.exe
21,708,800	21,691,392	-17,408	-0.080%	System.IO.FileSystem.Tests.exe
10,278,912	10,270,720	-8,192	-0.080%	System.Threading.Channels.Tests.exe
27,894,272	27,874,304	-19,968	-0.072%	System.Net.Security.Tests.exe
18,447,872	18,434,560	-13,312	-0.072%	System.Threading.Tasks.Parallel.Tests.exe
13,242,368	13,233,152	-9,216	-0.070%	System.IO.Packaging.Tests.exe
9,731,072	9,724,416	-6,656	-0.068%	System.Threading.RateLimiting.Tests.exe
33,165,312	33,142,784	-22,528	-0.068%	System.Private.Xml.Tests.exe
13,869,056	13,859,840	-9,216	-0.066%	Microsoft.Extensions.Configuration.Functional.Tests.exe
19,545,600	19,532,800	-12,800	-0.065%	System.Diagnostics.Process.Tests.exe
12,849,664	12,841,472	-8,192	-0.064%	System.Xml.Schema.Extensions.Tests.exe
12,416,000	12,408,320	-7,680	-0.062%	System.Xml.Linq.SDMSample.Tests.exe
17,431,552	17,420,800	-10,752	-0.062%	System.Net.Ping.Functional.Tests.exe
20,540,416	20,527,616	-12,800	-0.062%	System.Threading.Tasks.Tests.exe
15,759,872	15,750,144	-9,728	-0.062%	System.Windows.Extensions.Tests.exe
10,056,192	10,050,048	-6,144	-0.061%	System.Net.ServerSentEvents.Tests.exe
15,102,464	15,093,248	-9,216	-0.061%	System.Drawing.Primitives.Tests.exe
17,571,840	17,561,088	-10,752	-0.061%	MetricOuterLoop1.Tests.exe
17,566,720	17,555,968	-10,752	-0.061%	MetricOuterLoop.Tests.exe
19,289,600	19,277,824	-11,776	-0.061%	System.IO.Pipes.Tests.exe
17,791,488	17,780,736	-10,752	-0.060%	System.Formats.Tar.Manual.Tests.exe
17,967,616	17,956,864	-10,752	-0.060%	System.Threading.ThreadPool.WindowsThreadPool.Tests.exe
17,329,152	17,318,912	-10,240	-0.059%	System.Threading.Timer.Tests.exe
14,130,176	14,121,984	-8,192	-0.058%	System.DirectoryServices.Protocols.Tests.exe
17,616,896	17,606,656	-10,240	-0.058%	System.Threading.Thread.Tests.exe
19,681,792	19,670,528	-11,264	-0.057%	System.Net.Http.Unit.Tests.exe
17,160,192	17,150,464	-9,728	-0.057%	System.Runtime.Serialization.Formatters.Disabled.Tests.exe
17,967,104	17,956,864	-10,240	-0.057%	System.Threading.ThreadPool.Tests.exe
19,870,720	19,859,456	-11,264	-0.057%	System.Text.Encoding.Tests.exe
18,774,016	18,763,264	-10,752	-0.057%	Microsoft.Extensions.FileProviders.Physical.Tests.exe
27,160,064	27,144,704	-15,360	-0.057%	Microsoft.Extensions.Hosting.Unit.Tests.exe
17,214,976	17,205,248	-9,728	-0.057%	System.Net.ServicePoint.Tests.exe
17,312,768	17,303,040	-9,728	-0.056%	System.Security.Principal.Windows.Tests.exe
17,230,848	17,221,120	-9,728	-0.056%	System.ComponentModel.EventBasedAsync.Tests.exe
18,128,896	18,118,656	-10,240	-0.056%	System.Diagnostics.TextWriterTraceListener.Tests.exe
17,298,944	17,289,216	-9,728	-0.056%	System.Security.Claims.Tests.exe
17,431,040	17,421,312	-9,728	-0.056%	System.Diagnostics.TraceSource.Tests.exe
17,282,048	17,272,320	-9,728	-0.056%	System.Threading.Overlapped.Tests.exe
18,177,536	18,167,296	-10,240	-0.056%	System.Text.Encoding.CodePages.Tests.exe
17,356,288	17,346,560	-9,728	-0.056%	Microsoft.Win32.SystemEvents.Tests.exe
18,586,624	18,576,384	-10,240	-0.055%	ComInterfaceGenerator.Tests.exe
17,661,440	17,651,712	-9,728	-0.055%	System.IO.FileSystem.Watcher.Tests.exe
9,251,840	9,246,720	-5,120	-0.055%	Microsoft.Bcl.AsyncInterfaces.Tests.exe
13,941,248	13,933,568	-7,680	-0.055%	Microsoft.Extensions.Configuration.Xml.Tests.exe
18,492,928	18,482,688	-10,240	-0.055%	Microsoft.Extensions.Configuration.Tests.exe
17,662,976	17,653,248	-9,728	-0.055%	System.Buffers.Tests.exe
18,489,344	18,479,104	-10,240	-0.055%	Microsoft.Extensions.Hosting.Systemd.Tests.exe
15,080,448	15,072,256	-8,192	-0.054%	System.Security.Cryptography.Cng.Tests.exe
17,154,048	17,144,832	-9,216	-0.054%	IcuAppLocal.Tests.exe
15,039,488	15,031,296	-8,192	-0.054%	System.Data.DataSetExtensions.Tests.exe
18,062,336	18,052,608	-9,728	-0.054%	System.Console.Tests.exe
17,288,192	17,278,976	-9,216	-0.053%	System.Runtime.InteropServices.RuntimeInformation.Tests.exe
17,361,408	17,352,192	-9,216	-0.053%	System.Diagnostics.StackTrace.Tests.exe
18,455,552	18,445,824	-9,728	-0.053%	Microsoft.Extensions.Configuration.FileExtensions.Tests.exe
17,235,968	17,226,752	-9,216	-0.053%	System.Runtime.InvariantTimezone.Tests.exe
18,518,016	18,508,288	-9,728	-0.053%	System.IO.MemoryMappedFiles.Tests.exe
18,693,632	18,683,904	-9,728	-0.052%	Microsoft.Extensions.Logging.Console.Tests.exe
18,032,128	18,022,912	-9,216	-0.051%	Microsoft.Extensions.Diagnostics.Tests.exe
16,107,008	16,098,816	-8,192	-0.051%	System.Data.Odbc.Tests.exe
24,284,672	24,272,384	-12,288	-0.051%	Microsoft.Extensions.Http.Tests.exe
20,532,736	20,522,496	-10,240	-0.050%	System.Runtime.Extensions.Tests.exe
18,371,584	18,362,368	-9,216	-0.050%	System.Threading.Tests.exe
18,356,736	18,347,520	-9,216	-0.050%	Microsoft.Extensions.FileProviders.Composite.Tests.exe
18,381,824	18,372,608	-9,216	-0.050%	Microsoft.Extensions.Primitives.Tests.exe
11,331,072	11,325,440	-5,632	-0.050%	System.Net.WebSockets.Tests.exe
19,295,744	19,286,016	-9,728	-0.050%	System.Net.Primitives.Functional.Tests.exe
19,972,608	19,962,880	-9,728	-0.049%	Microsoft.Extensions.Logging.Tests.exe
11,588,096	11,582,464	-5,632	-0.049%	System.Net.Http.Json.Unit.Tests.exe
19,744,768	19,735,040	-9,728	-0.049%	System.Resources.ResourceManager.Tests.exe
9,334,784	9,330,176	-4,608	-0.049%	Microsoft.Extensions.Diagnostics.Abstractions.Tests.exe
18,833,920	18,824,704	-9,216	-0.049%	System.Runtime.Caching.Tests.exe
19,080,192	19,070,976	-9,216	-0.048%	Microsoft.Extensions.Hosting.WindowsServices.Tests.exe
9,660,416	9,655,808	-4,608	-0.048%	Microsoft.Extensions.Hosting.Functional.Tests.exe
20,475,904	20,466,176	-9,728	-0.048%	System.Diagnostics.DiagnosticSource.Tests.exe
20,741,632	20,731,904	-9,728	-0.047%	System.Collections.Concurrent.Tests.exe
10,106,368	10,101,760	-4,608	-0.046%	Microsoft.Extensions.Caching.Memory.Tests.exe
20,234,752	20,225,536	-9,216	-0.046%	System.Runtime.InteropServices.Tests.exe
20,454,912	20,445,696	-9,216	-0.045%	System.Reflection.Tests.exe
19,486,208	19,477,504	-8,704	-0.045%	Microsoft.Extensions.Configuration.UserSecrets.Tests.exe
11,274,240	11,269,120	-5,120	-0.045%	System.IO.Compression.Brotli.Tests.exe
19,555,840	19,547,136	-8,704	-0.045%	Microsoft.Extensions.Configuration.Json.Tests.exe
23,405,056	23,394,816	-10,240	-0.044%	System.Memory.Tests.exe
25,891,328	25,880,064	-11,264	-0.044%	System.Text.Json.SourceGeneration.Roslyn3.11.Tests.exe
10,510,336	10,505,728	-4,608	-0.044%	Microsoft.Extensions.Options.Tests.exe
9,442,816	9,438,720	-4,096	-0.043%	Microsoft.Extensions.Logging.Testing.Tests.exe
26,440,704	26,429,440	-11,264	-0.043%	System.ComponentModel.TypeConverter.Tests.exe
21,622,784	21,613,568	-9,216	-0.043%	System.Data.OleDb.Tests.exe
26,006,528	25,996,288	-10,240	-0.039%	System.Globalization.Nls.Tests.exe
20,808,704	20,801,024	-7,680	-0.037%	System.Security.Cryptography.Csp.Tests.exe
29,403,136	29,392,384	-10,752	-0.037%	Microsoft.Extensions.DependencyModel.Tests.exe
26,095,616	26,085,888	-9,728	-0.037%	System.Globalization.Tests.exe
21,072,384	21,064,704	-7,680	-0.036%	Microsoft.Extensions.Logging.EventSource.Tests.exe
45,486,080	45,470,208	-15,872	-0.035%	System.Security.Cryptography.Tests.exe
32,739,840	32,730,112	-9,728	-0.030%	System.Linq.Expressions.Tests.exe
33,385,984	33,376,256	-9,728	-0.029%	Microsoft.Bcl.Cryptography.Tests.exe
44,704,768	44,693,504	-11,264	-0.025%	System.Runtime.Tests.exe
2,233,344	2,232,832	-512	-0.023%	clrjit.dll
10,494,464	10,492,928	-1,536	-0.015%	System.Net.Http.WinHttpHandler.Unit.Tests.exe
10,586,112	10,584,576	-1,536	-0.015%	Common.Tests.exe
9,026,048	9,025,024	-1,024	-0.011%	Microsoft.Extensions.FileSystemGlobbing.Tests.exe
9,347,584	9,346,560	-1,024	-0.011%	System.Security.Permissions.Tests.exe
9,612,800	9,611,776	-1,024	-0.011%	System.Diagnostics.EventLog.Tests.exe
12,185,088	12,184,064	-1,024	-0.008%	System.Net.NetworkInformation.Functional.Tests.exe
15,386,112	15,385,088	-1,024	-0.007%	System.Globalization.Extensions.Nls.Tests.exe
15,386,112	15,385,088	-1,024	-0.007%	System.Globalization.Extensions.Tests.exe
8,743,936	8,743,424	-512	-0.006%	Invariant.Tests.exe
8,975,872	8,975,360	-512	-0.006%	System.Net.Primitives.Pal.Tests.exe
8,798,208	8,797,696	-512	-0.006%	System.Resources.Reader.Tests.exe
8,667,136	8,666,624	-512	-0.006%	System.Runtime.CompilerServices.Unsafe.Tests.exe
8,916,480	8,915,968	-512	-0.006%	System.IO.Pipes.AccessControl.Tests.exe
9,027,072	9,026,560	-512	-0.006%	System.Net.NameResolution.Pal.Tests.exe
9,191,936	9,191,424	-512	-0.006%	Microsoft.Extensions.Configuration.EnvironmentVariables.Tests.exe
8,763,904	8,763,392	-512	-0.006%	Microsoft.Bcl.TimeProvider.Tests.exe
8,609,792	8,609,280	-512	-0.006%	System.Composition.Runtime.Tests.exe
9,129,472	9,128,960	-512	-0.006%	System.Security.AccessControl.Tests.exe
8,803,328	8,802,816	-512	-0.006%	System.Web.HttpUtility.Tests.exe
9,041,920	9,041,408	-512	-0.006%	Microsoft.Extensions.Configuration.CommandLine.Tests.exe
8,638,464	8,637,952	-512	-0.006%	System.Globalization.CalendarsWithConfigSwitch.Tests.exe
8,533,504	8,532,992	-512	-0.006%	System.ComponentModel.Tests.exe
8,686,592	8,686,080	-512	-0.006%	System.Security.Cryptography.ProtectedData.Tests.exe
8,755,712	8,755,200	-512	-0.006%	System.IO.FileSystem.DriveInfo.Tests.exe
8,977,408	8,976,896	-512	-0.006%	Microsoft.Win32.Registry.Tests.exe
8,685,568	8,685,056	-512	-0.006%	System.IO.FileSystem.Manual.Tests.exe
9,095,680	9,095,168	-512	-0.006%	System.IO.FileSystem.AccessControl.Tests.exe
10,048,512	10,048,000	-512	-0.005%	System.Diagnostics.Debug.Tests.exe
11,179,520	11,179,008	-512	-0.005%	System.Text.Encodings.Web.Tests.exe
11,034,112	11,033,600	-512	-0.005%	System.Runtime.Numerics.Tests.exe
11,363,328	11,362,816	-512	-0.005%	System.Net.Security.Unit.Tests.exe
9,337,344	9,336,832	-512	-0.005%	System.IO.IsolatedStorage.Tests.exe
9,748,992	9,749,504	+512	+0.005%	System.Formats.Asn1.Tests.exe
9,473,536	9,473,024	-512	-0.005%	Microsoft.Extensions.Configuration.Ini.Tests.exe
10,936,320	10,935,808	-512	-0.005%	System.Runtime.Intrinsics.Tests.exe
9,571,328	9,570,816	-512	-0.005%	System.Memory.Data.Tests.exe
9,660,928	9,660,416	-512	-0.005%	System.IO.UnmanagedMemoryStream.Tests.exe
9,524,736	9,524,224	-512	-0.005%	System.IO.Hashing.Tests.exe
9,361,920	9,361,408	-512	-0.005%	System.Net.Mail.Unit.Tests.exe
11,590,144	11,589,632	-512	-0.004%	System.Resources.Extensions.Tests.exe
11,469,312	11,468,800	-512	-0.004%	System.IO.Ports.Tests.exe
11,779,072	11,778,560	-512	-0.004%	System.Security.Cryptography.Cose.Tests.exe
17,824,768	17,824,256	-512	-0.003%	System.Collections.Tests.exe
18,770,432	18,770,944	+512	+0.003%	System.Numerics.Vectors.Tests.exe
22,320,640	22,320,128	-512	-0.002%	System.Security.Cryptography.Pkcs.Tests.exe
8,988,672	8,988,672	0	0.000%	System.Runtime.Serialization.Primitives.Tests.exe
8,690,176	8,690,176	0	0.000%	System.Security.SecureString.Tests.exe
9,201,664	9,201,664	0	0.000%	System.ServiceProcess.ServiceController.Tests.exe
7,318,016	7,318,016	0	0.000%	XUnitLogChecker.exe
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
84,480	84,480	0	0.000%	System.Globalization.Native.dll
108,032	108,032	0	0.000%	CMakeCXXCompilerId.exe
108,032	108,032	0	0.000%	CMakeCCompilerId.exe
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
8,673,280	8,673,280	0	0.000%	System.Runtime.InteropServices.ComDisabled.Tests.exe
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
8,608,768	8,608,768	0	0.000%	System.Xml.Linq.Axes.Tests.exe
9,069,056	9,069,056	0	0.000%	System.ValueTuple.Tests.exe
8,945,152	8,945,152	0	0.000%	System.Threading.AccessControl.Tests.exe
9,690,112	9,690,112	0	0.000%	System.Text.RegularExpressions.Unit.Tests.exe
8,543,232	8,543,232	0	0.000%	System.Text.Encoding.Extensions.Tests.exe
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
536,096	536,096	0	0.000%	msquic.dll
8,529,408	8,529,408	0	0.000%	System.IO.FileSystem.Primitives.Tests.exe
8,532,480	8,532,480	0	0.000%	System.Runtime.CompilerServices.VisualC.Tests.exe
536,096	536,096	0	0.000%	msquic.dll
1,308,672	1,308,672	0	0.000%	mscordbi.dll
1,501,696	1,501,696	0	0.000%	mscordaccore.dll
1,501,696	1,501,696	0	0.000%	mscordaccore_amd64_amd64_42.42.42.42424.dll
361,984	361,984	0	0.000%	hostpolicy.dll
350,208	350,208	0	0.000%	hostfxr.dll
62,464	62,464	0	0.000%	createdump.exe
210,944	210,944	0	0.000%	corerun.exe
4,955,648	4,955,648	0	0.000%	coreclr.dll
722,944	722,944	0	0.000%	clrgcexp.dll
678,400	678,400	0	0.000%	clrgc.dll
307,200	307,200	0	0.000%	clretwrc.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
84,480	84,480	0	0.000%	System.Globalization.Native.dll
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
696,320	696,320	0	0.000%	FileCheck.exe
9,956,352	9,956,352	0	0.000%	llvm-mca.exe
13,419,520	13,419,520	0	0.000%	crossgen2.exe
7,703,040	7,703,040	0	0.000%	ilasm.exe
1,377,280	1,377,280	0	0.000%	System.IO.Compression.Native.dll
15,940,096	15,940,096	0	0.000%	ilc.exe
8,938,496	8,938,496	0	0.000%	Microsoft.Bcl.Memory.Tests.exe
8,578,048	8,578,048	0	0.000%	Microsoft.Bcl.Numerics.Tests.exe
8,587,264	8,587,264	0	0.000%	Microsoft.Extensions.Hosting.Abstractions.Tests.exe
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
9,947,648	9,947,648	0	0.000%	LibraryImportGenerator.Tests.exe
8,655,872	8,655,872	0	0.000%	System.Runtime.Handles.Tests.exe
16,973,824	16,973,824	0	0.000%	System.Private.CoreLib.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
8,591,360	8,591,360	0	0.000%	System.Resources.Writer.Tests.exe
9,011,200	9,011,200	0	0.000%	System.Reflection.TypeExtensions.Tests.exe
12,271,104	12,271,104	0	0.000%	System.Reflection.Metadata.Tests.exe
8,849,920	8,849,920	0	0.000%	System.Reflection.Extensions.Tests.exe
9,350,656	9,350,656	0	0.000%	System.Reflection.Context.Tests.exe
8,704,512	8,704,512	0	0.000%	System.Private.Uri.Unit.Tests.exe
9,631,744	9,631,744	0	0.000%	System.Private.Uri.Functional.Tests.exe
9,785,856	9,785,856	0	0.000%	System.Net.WebProxy.Tests.exe
8,627,200	8,627,200	0	0.000%	System.Net.WebHeaderCollection.Tests.exe
9,300,992	9,300,992	0	0.000%	System.Net.Primitives.UnitTests.Tests.exe
15,486,976	15,486,976	0	0.000%	System.Linq.Tests.exe
696,320	696,320	0	0.000%	FileCheck.exe
9,150,976	9,150,976	0	0.000%	System.Globalization.Calendars.Tests.exe
9,837,568	9,837,568	0	0.000%	System.Formats.Nrbf.Tests.exe
8,534,528	8,534,528	0	0.000%	System.Diagnostics.Tools.Tests.exe
8,702,464	8,702,464	0	0.000%	System.Diagnostics.FileVersionInfo.Tests.exe
8,547,840	8,547,840	0	0.000%	System.Diagnostics.Contracts.Tests.exe
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
1,754,512	1,754,512	0	0.000%	Microsoft.DiaSymReader.Native.arm.dll
2,247,784	2,247,784	0	0.000%	Microsoft.DiaSymReader.Native.arm64.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
1,935,296	1,935,296	0	0.000%	Microsoft.DiaSymReader.Native.x86.dll
2,309,152	2,309,152	0	0.000%	Microsoft.DiaSymReader.Native.amd64.dll
8,649,216	8,649,216	0	0.000%	Microsoft.Win32.Primitives.Tests.exe
9,934,336	9,934,336	0	0.000%	System.Collections.NonGeneric.Tests.exe
9,734,656	9,734,656	0	0.000%	System.Collections.Specialized.Tests.exe
9,147,392	9,147,392	0	0.000%	System.ComponentModel.Primitives.Tests.exe
8,544,768	8,544,768	0	0.000%	System.Composition.AttributeModel.Tests.exe
9,615,872	9,615,872	0	0.000%	System.Composition.Convention.Tests.exe
8,821,760	8,821,760	0	0.000%	System.Console.Manual.Tests.exe
8,632,832	8,632,832	0	0.000%	Microsoft.Win32.Registry.AccessControl.Tests.exe
9,956,352	9,956,352	0	0.000%	llvm-mca.exe

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR changes CoreCLR runtime-async suspension/resumption so the dispatcher (managed AsyncHelpers) restores ExecutionContext, instead of having interpreter/JIT resumption stubs call a restore helper. The continuation’s flags now encode the ExecutionContext storage slot, enabling the dispatcher to restore without an extra TLS lookup + helper call on the hot resumption path.

Changes:

• Add continuation support for locating/storing the ExecutionContext via encoded indices in continuation flags (VM + managed + JIT + interpreter).
• Remove RestoreExecutionContext calls from interpreter and JIT resumption code; add restoration to the dispatcher loop.
• Preserve BBF_ASYNC_RESUMPTION across certain flow optimizations that may bypass resumption stubs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/object.h	Adds VM helper to locate ExecutionContext storage in a continuation via encoded flag bits.
src/coreclr/vm/interpexec.cpp	Writes captured ExecutionContext via the encoded slot; removes interpreter-side restore on resume.
src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs	Moves ExecutionContext restore into dispatcher; adjusts flag layout and RestoreExecutionContext signature to avoid TLS lookup.
src/coreclr/jit/fgopt.cpp	Copies BBF_ASYNC_RESUMPTION during certain jump/switch/flow optimizations to preserve async side-entry affordances.
src/coreclr/jit/async.cpp	Updates continuation layout/flag encoding for ExecutionContext; removes JIT-side restore on resumption.
src/coreclr/interpreter/inc/interpretershared.h	Removes interpreter suspend-data field that stored a raw execution-context offset.
src/coreclr/interpreter/compiler.cpp	Encodes ExecutionContext slot in flags and updates interpreter continuation layout accordingly.
src/coreclr/inc/corinfo.h	Updates CorInfoContinuationFlags bit assignments to include ExecutionContext index encoding.

Comments suppressed due to low confidence (2)

src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs:554

• RuntimeAsyncStackState contains managed reference fields, but this local is left uninitialized before its address is stored in TLS (awaitState.Push(&stackState)). This can expose garbage references to the GC (and Push only initializes a subset of fields), risking GC crashes/corruption. Initialize stackState to default (or otherwise fully clear all reference fields before any GC safepoint) before calling Push.

 RuntimeAsyncStackState stackState;
ref RuntimeAsyncAwaitState awaitState = ref t_runtimeAsyncAwaitState;
awaitState.Push(&stackState);

src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs:655

• Same issue as in DispatchContinuations: RuntimeAsyncStackState stackState; is uninitialized even though the struct contains managed references and its address is pushed into TLS via awaitState.Push(&stackState). This can leave garbage object references visible to the GC until fields are explicitly set. Ensure stackState is zero-initialized (e.g., = default) or otherwise cleared before pushing.

 RuntimeAsyncStackState stackState;
ref RuntimeAsyncAwaitState awaitState = ref t_runtimeAsyncAwaitState;
awaitState.Push(&stackState);

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/coreclr/interpreter/compiler.cpp:6007

• InterpAsyncSuspendData.restoreExecutionContextMethod is still populated, but after removing the interpreter-side RestoreExecutionContext call there don’t appear to be any remaining reads of this field. Consider removing the field from InterpAsyncSuspendData (and this assignment) to reduce per-suspension metadata size and avoid dead state.

 suspendData->keepAliveOffset = keepAliveOffset + OFFSETOF__CORINFO_Continuation__data;
suspendData->captureSyncContextMethod = asyncInfo.captureContinuationContextMethHnd;
suspendData->restoreExecutionContextMethod = asyncInfo.restoreExecutionContextMethHnd;
suspendData->restoreContextsOnSuspensionMethod = asyncInfo.restoreContextsOnSuspensionMethHnd;

[Copilot]

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

src/coreclr/interpreter/compiler.cpp:6007

• CORINFO_ASYNC_INFO no longer exposes restoreExecutionContextMethHnd, but the interpreter still stores asyncInfo.restoreExecutionContextMethHnd into InterpAsyncSuspendData. This will fail to compile and should be removed/rewired now that execution context restoration is done by the dispatcher.

 suspendData->keepAliveOffset = keepAliveOffset + OFFSETOF__CORINFO_Continuation__data;
suspendData->captureSyncContextMethod = asyncInfo.captureContinuationContextMethHnd;
suspendData->restoreExecutionContextMethod = asyncInfo.restoreExecutionContextMethHnd;
suspendData->restoreContextsOnSuspensionMethod = asyncInfo.restoreContextsOnSuspensionMethHnd;

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

[jakobbotsch]

PTAL @VSadov (async) @AndyAyersMS (JIT) @davidwrighton /@janvorli (interpreter)

[AndyAyersMS]

JIT changes look good.

[VSadov]

LGTM. Thanks!

[jakobbotsch]

Will merge this, @janvorli@davidwrighton let me know if you have any comments on the interpreter change and I can address it in a follow-up.