[cDAC] Use locally-built crossgen2 for dump test debuggees - #127561

Merged
max-charlamb merged 1 commit into
dotnet:mainfrom
max-charlamb:fix/dump-tests-use-local-crossgen2
Apr 30, 2026
Merged

[cDAC] Use locally-built crossgen2 for dump test debuggees#127561
max-charlamb merged 1 commit into
dotnet:mainfrom
max-charlamb:fix/dump-tests-use-local-crossgen2

Conversation

@max-charlamb

@max-charlambmax-charlamb commented Apr 29, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Note

This PR was created with the assistance of GitHub Copilot (AI-generated content).

Problem

The AsyncContinuationDumpTests (and potentially other R2R dump tests) fail in CI because the debuggee apps are R2R-compiled with the SDK's bundled crossgen2 instead of the locally-built one. When the locally-built runtime removes or changes types between previews (e.g. PR #127336 removing ExecutionAndSyncBlockStore), the SDK's crossgen2 emits R2R thunks referencing types that no longer exist, causing TypeLoadException or null globals at runtime.

Root Cause

Two issues prevent the locally-built crossgen2 from being used:

  1. NuGet pack layout mismatch: The SDK's ResolveReadyToRunCompilers task expects crossgen2 at PackagePath/tools/crossgen2.exe (NuGet pack layout), but the local build produces a flat layout with crossgen2.exe at the root of Crossgen2InBuildDir. targetingpacks.targets alone cannot fix this because it only updates PackageDirectory without restructuring the layout.

  2. Missing property propagation: The child dotnet publish process doesn't inherit RuntimeConfiguration, TargetArchitecture, TargetOS, or BuildArchitecture from the outer build, causing crossgen2 and runtime pack paths to resolve incorrectly (especially in cross-build scenarios like building on linux-x64 for linux-arm).

Fix

Debuggees/Directory.Build.targets

  • Import targetingpacks.targets for runtime/targeting pack resolution
  • Import tests.readytorun.targets via AfterMicrosoftNETSdkTargets to override ResolveReadyToRunCompilers after the SDK defines it, pointing directly at the locally-built crossgen2

DumpTests.targets

  • Add _DebuggeeRuntimeConfig property (falls back from RuntimeConfiguration -> Configuration -> Debug)
  • Add _DebuggeePublishProps to propagate RuntimeConfiguration, TargetArchitecture, TargetOS, and BuildArchitecture to child dotnet publish calls

prepare-cdac-helix-steps.yml

  • Add runtimeConfiguration parameter (default: Checked) and pass it to BuildDebuggeesOnly so crossgen2 is found under the correct Checked artifacts path

CopilotAI review requested due to automatic review settings April 29, 2026 14:01
@max-charlamb
max-charlamb requested a review from rcj1April 29, 2026 14:04
@dotnet-policy-service

dotnet-policy-serviceBot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

@max-charlambmax-charlamb added NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 29, 2026
CopilotAI reviewed Apr 29, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes dump-test debuggee ReadyToRun (R2R) version-skew by ensuring the dump-test debuggees are R2R-compiled using the locally-built crossgen2 that matches the runtime under test, and by flowing the runtime build configuration into the debuggee publish step so crossgen2 is resolved from the correct artifacts directory.

Changes:

  • Import eng/targetingpacks.targets for DumpTests debuggee projects so UpdateLocalCrossgen2Pack redirects crossgen2 to the in-repo build output (instead of the SDK pack).
  • Pass /p:RuntimeConfiguration=... to debuggee dotnet publish invocations so crossgen2 lookup uses the intended CoreCLR artifacts configuration (e.g., checked vs release).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
src/native/managed/cdac/tests/DumpTests/DumpTests.targetsThreads RuntimeConfiguration into debuggee publish so crossgen2 is resolved from the correct locally-built artifacts layout.
src/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targetsImports eng/targetingpacks.targets to activate local crossgen2 pack redirection for debuggee R2R publishing.

Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets Outdated
Comment threadsrc/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets
CopilotAI review requested due to automatic review settings April 29, 2026 17:31
CopilotAI reviewed Apr 29, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets Outdated
@max-charlamb
max-charlamb marked this pull request as draft April 29, 2026 18:33
CopilotAI review requested due to automatic review settings April 29, 2026 21:24
CopilotAI reviewed Apr 29, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment threadsrc/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets
This was referenced Apr 30, 2026
Open
Open
Open
Open
@max-charlambmax-charlamb removed the NO-REVIEW Experimental/testing PR, do NOT review it label Apr 30, 2026
@max-charlamb
max-charlamb marked this pull request as ready for review April 30, 2026 15:23
Max Charlamb
[cDAC] Use locally-built crossgen2 for dump test debuggees
1bb0e4b
Import targetingpacks.targets and tests.readytorun.targets (via
AfterMicrosoftNETSdkTargets) in debuggee Directory.Build.targets to
ensure R2R publish uses the locally-built crossgen2 instead of the
SDK's bundled version.
Propagate RuntimeConfiguration, TargetArchitecture, TargetOS, and
BuildArchitecture to child dotnet-publish so that crossgen2 and
runtime pack paths resolve correctly in cross-build scenarios.
Pass RuntimeConfiguration=Checked from the pipeline YAML so that
BuildDebuggeesOnly finds crossgen2 under the Checked artifacts path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
max-charlambforce-pushed the fix/dump-tests-use-local-crossgen2 branch from 6ad3960 to 1bb0e4bCompareApril 30, 2026 17:05
@max-charlamb

max-charlamb commented Apr 30, 2026

Copy link
Copy Markdown
MemberAuthor

/ba-g cDAC only change

@max-charlamb
max-charlamb merged commit 550500a into dotnet:mainApr 30, 2026
173 of 183 checks passed
@max-charlamb
max-charlamb deleted the fix/dump-tests-use-local-crossgen2 branch April 30, 2026 20:04
@build-analysisbuild-analysisBot mentioned this pull request Apr 30, 2026
Closed
@dotnet-maestrodotnet-maestroBot mentioned this pull request May 1, 2026
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 31, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@steveisoksteveisoksteveisok approved these changes
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-cdac

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@steveisok
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[cDAC] Use locally-built crossgen2 for dump test debuggees - #127561
Merged
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:fix/dump-tests-use-local-crossgen2
Apr 30, 2026
Merged
[cDAC] Use locally-built crossgen2 for dump test debuggees#127561
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:fix/dump-tests-use-local-crossgen2
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Note
This PR was created with the assistance of GitHub Copilot (AI-generated content).
Problem
The AsyncContinuationDumpTests (and potentially other R2R dump tests) fail in CI because the debuggee apps are R2R-compiled with the SDK's bundled crossgen2 instead of the locally-built one. When the locally-built runtime removes or changes types between previews (e.g. PR #127336 removing ExecutionAndSyncBlockStore), the SDK's crossgen2 emits R2R thunks referencing types that no longer exist, causing TypeLoadException or null globals at runtime.
Root Cause
Two issues prevent the locally-built crossgen2 from being used:
  1. NuGet pack layout mismatch: The SDK's ResolveReadyToRunCompilers task expects crossgen2 at PackagePath/tools/crossgen2.exe (NuGet pack layout), but the local build produces a flat layout with crossgen2.exe at the root of Crossgen2InBuildDir. targetingpacks.targets alone cannot fix this because it only updates PackageDirectory without restructuring the layout.
  2. Missing property propagation: The child dotnet publish process doesn't inherit RuntimeConfiguration, TargetArchitecture, TargetOS, or BuildArchitecture from the outer build, causing crossgen2 and runtime pack paths to resolve incorrectly (especially in cross-build scenarios like building on linux-x64 for linux-arm).
Fix
Debuggees/Directory.Build.targets
  • Import targetingpacks.targets for runtime/targeting pack resolution
  • Import tests.readytorun.targets via AfterMicrosoftNETSdkTargets to override ResolveReadyToRunCompilers after the SDK defines it, pointing directly at the locally-built crossgen2
DumpTests.targets
  • Add _DebuggeeRuntimeConfig property (falls back from RuntimeConfiguration -> Configuration -> Debug)
  • Add _DebuggeePublishProps to propagate RuntimeConfiguration, TargetArchitecture, TargetOS, and BuildArchitecture to child dotnet publish calls
prepare-cdac-helix-steps.yml
  • Add runtimeConfiguration parameter (default: Checked) and pass it to BuildDebuggeesOnly so crossgen2 is found under the correct Checked artifacts path
CopilotAI
review requested due to automatic review settings
April 29, 2026 14:01
@max-charlamb
max-charlamb
requested a review
from rcj1April 29, 2026 14:04
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 29, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@max-charlambmax-charlamb
added

NO-REVIEW
Experimental/testing PR, do NOT review it
labels
Apr 29, 2026
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR fixes dump-test debuggee ReadyToRun (R2R) version-skew by ensuring the dump-test debuggees are R2R-compiled using the locally-built crossgen2 that matches the runtime under test, and by flowing the runtime build configuration into the debuggee publish step so crossgen2 is resolved from the correct artifacts directory.
Changes:
  • Import eng/targetingpacks.targets for DumpTests debuggee projects so UpdateLocalCrossgen2Pack redirects crossgen2 to the in-repo build output (instead of the SDK pack).
  • Pass /p:RuntimeConfiguration=... to debuggee dotnet publish invocations so crossgen2 lookup uses the intended CoreCLR artifacts configuration (e.g., checked vs release).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
FileDescription
src/native/managed/cdac/tests/DumpTests/DumpTests.targetsThreads RuntimeConfiguration into debuggee publish so crossgen2 is resolved from the correct locally-built artifacts layout.
src/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targetsImports eng/targetingpacks.targets to activate local crossgen2 pack redirection for debuggee R2R publishing.
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Outdated

Comment threadsrc/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets
CopilotAI
review requested due to automatic review settings
April 29, 2026 17:31
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Outdated

@max-charlamb
max-charlamb
marked this pull request as draft
April 29, 2026 18:33
CopilotAI
review requested due to automatic review settings
April 29, 2026 21:24
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets

This was referenced Apr 30, 2026

Open


Open


Open


Open

@max-charlambmax-charlamb
removed
the 
NO-REVIEW
Experimental/testing PR, do NOT review it
label
Apr 30, 2026
@max-charlamb
max-charlamb
marked this pull request as ready for review
April 30, 2026 15:23
Max Charlamb
[cDAC] Use locally-built crossgen2 for dump test debuggees
1bb0e4b
Import targetingpacks.targets and tests.readytorun.targets (via
AfterMicrosoftNETSdkTargets) in debuggee Directory.Build.targets to
ensure R2R publish uses the locally-built crossgen2 instead of the
SDK's bundled version.
Propagate RuntimeConfiguration, TargetArchitecture, TargetOS, and
BuildArchitecture to child dotnet-publish so that crossgen2 and
runtime pack paths resolve correctly in cross-build scenarios.
Pass RuntimeConfiguration=Checked from the pipeline YAML so that
BuildDebuggeesOnly finds crossgen2 under the Checked artifacts path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
max-charlambforce-pushed
the
fix/dump-tests-use-local-crossgen2
branch
from
6ad3960 to
1bb0e4bCompareApril 30, 2026 17:05
@max-charlamb
max-charlamb
commented
Apr 30, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change
@max-charlamb
max-charlamb
merged commit 550500a
into
dotnet:mainApr 30, 2026

173 of 183 checks passed

@max-charlamb
max-charlamb
deleted the

fix/dump-tests-use-local-crossgen2

branch
April 30, 2026 20:04
@build-analysisbuild-analysisBot
mentioned this pull request
Apr 30, 2026

Closed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 1, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 31, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@steveisoksteveisoksteveisok approved these changes
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@steveisok

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] Use locally-built crossgen2 for dump test debuggees - #127561
Merged
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:fix/dump-tests-use-local-crossgen2
Apr 30, 2026
Merged
[cDAC] Use locally-built crossgen2 for dump test debuggees#127561
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:fix/dump-tests-use-local-crossgen2
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Note
This PR was created with the assistance of GitHub Copilot (AI-generated content).
Problem
The AsyncContinuationDumpTests (and potentially other R2R dump tests) fail in CI because the debuggee apps are R2R-compiled with the SDK's bundled crossgen2 instead of the locally-built one. When the locally-built runtime removes or changes types between previews (e.g. PR #127336 removing ExecutionAndSyncBlockStore), the SDK's crossgen2 emits R2R thunks referencing types that no longer exist, causing TypeLoadException or null globals at runtime.
Root Cause
Two issues prevent the locally-built crossgen2 from being used:
  1. NuGet pack layout mismatch: The SDK's ResolveReadyToRunCompilers task expects crossgen2 at PackagePath/tools/crossgen2.exe (NuGet pack layout), but the local build produces a flat layout with crossgen2.exe at the root of Crossgen2InBuildDir. targetingpacks.targets alone cannot fix this because it only updates PackageDirectory without restructuring the layout.
  2. Missing property propagation: The child dotnet publish process doesn't inherit RuntimeConfiguration, TargetArchitecture, TargetOS, or BuildArchitecture from the outer build, causing crossgen2 and runtime pack paths to resolve incorrectly (especially in cross-build scenarios like building on linux-x64 for linux-arm).
Fix
Debuggees/Directory.Build.targets
  • Import targetingpacks.targets for runtime/targeting pack resolution
  • Import tests.readytorun.targets via AfterMicrosoftNETSdkTargets to override ResolveReadyToRunCompilers after the SDK defines it, pointing directly at the locally-built crossgen2
DumpTests.targets
  • Add _DebuggeeRuntimeConfig property (falls back from RuntimeConfiguration -> Configuration -> Debug)
  • Add _DebuggeePublishProps to propagate RuntimeConfiguration, TargetArchitecture, TargetOS, and BuildArchitecture to child dotnet publish calls
prepare-cdac-helix-steps.yml
  • Add runtimeConfiguration parameter (default: Checked) and pass it to BuildDebuggeesOnly so crossgen2 is found under the correct Checked artifacts path
CopilotAI
review requested due to automatic review settings
April 29, 2026 14:01
@max-charlamb
max-charlamb
requested a review
from rcj1April 29, 2026 14:04
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 29, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@max-charlambmax-charlamb
added

NO-REVIEW
Experimental/testing PR, do NOT review it
labels
Apr 29, 2026
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR fixes dump-test debuggee ReadyToRun (R2R) version-skew by ensuring the dump-test debuggees are R2R-compiled using the locally-built crossgen2 that matches the runtime under test, and by flowing the runtime build configuration into the debuggee publish step so crossgen2 is resolved from the correct artifacts directory.
Changes:
  • Import eng/targetingpacks.targets for DumpTests debuggee projects so UpdateLocalCrossgen2Pack redirects crossgen2 to the in-repo build output (instead of the SDK pack).
  • Pass /p:RuntimeConfiguration=... to debuggee dotnet publish invocations so crossgen2 lookup uses the intended CoreCLR artifacts configuration (e.g., checked vs release).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
FileDescription
src/native/managed/cdac/tests/DumpTests/DumpTests.targetsThreads RuntimeConfiguration into debuggee publish so crossgen2 is resolved from the correct locally-built artifacts layout.
src/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targetsImports eng/targetingpacks.targets to activate local crossgen2 pack redirection for debuggee R2R publishing.
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Outdated

Comment threadsrc/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets
CopilotAI
review requested due to automatic review settings
April 29, 2026 17:31
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Outdated

@max-charlamb
max-charlamb
marked this pull request as draft
April 29, 2026 18:33
CopilotAI
review requested due to automatic review settings
April 29, 2026 21:24
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets

This was referenced Apr 30, 2026

Open


Open


Open


Open

@max-charlambmax-charlamb
removed
the 
NO-REVIEW
Experimental/testing PR, do NOT review it
label
Apr 30, 2026
@max-charlamb
max-charlamb
marked this pull request as ready for review
April 30, 2026 15:23
Max Charlamb
[cDAC] Use locally-built crossgen2 for dump test debuggees
1bb0e4b
Import targetingpacks.targets and tests.readytorun.targets (via
AfterMicrosoftNETSdkTargets) in debuggee Directory.Build.targets to
ensure R2R publish uses the locally-built crossgen2 instead of the
SDK's bundled version.
Propagate RuntimeConfiguration, TargetArchitecture, TargetOS, and
BuildArchitecture to child dotnet-publish so that crossgen2 and
runtime pack paths resolve correctly in cross-build scenarios.
Pass RuntimeConfiguration=Checked from the pipeline YAML so that
BuildDebuggeesOnly finds crossgen2 under the Checked artifacts path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
max-charlambforce-pushed
the
fix/dump-tests-use-local-crossgen2
branch
from
6ad3960 to
1bb0e4bCompareApril 30, 2026 17:05
@max-charlamb
max-charlamb
commented
Apr 30, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change
@max-charlamb
max-charlamb
merged commit 550500a
into
dotnet:mainApr 30, 2026

173 of 183 checks passed

@max-charlamb
max-charlamb
deleted the

fix/dump-tests-use-local-crossgen2

branch
April 30, 2026 20:04
@build-analysisbuild-analysisBot
mentioned this pull request
Apr 30, 2026

Closed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 1, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 31, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@steveisoksteveisoksteveisok approved these changes
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@steveisok

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] Use locally-built crossgen2 for dump test debuggees - #127561
Merged
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:fix/dump-tests-use-local-crossgen2
Apr 30, 2026
Merged
[cDAC] Use locally-built crossgen2 for dump test debuggees#127561
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:fix/dump-tests-use-local-crossgen2
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Note
This PR was created with the assistance of GitHub Copilot (AI-generated content).
Problem
The AsyncContinuationDumpTests (and potentially other R2R dump tests) fail in CI because the debuggee apps are R2R-compiled with the SDK's bundled crossgen2 instead of the locally-built one. When the locally-built runtime removes or changes types between previews (e.g. PR #127336 removing ExecutionAndSyncBlockStore), the SDK's crossgen2 emits R2R thunks referencing types that no longer exist, causing TypeLoadException or null globals at runtime.
Root Cause
Two issues prevent the locally-built crossgen2 from being used:
  1. NuGet pack layout mismatch: The SDK's ResolveReadyToRunCompilers task expects crossgen2 at PackagePath/tools/crossgen2.exe (NuGet pack layout), but the local build produces a flat layout with crossgen2.exe at the root of Crossgen2InBuildDir. targetingpacks.targets alone cannot fix this because it only updates PackageDirectory without restructuring the layout.
  2. Missing property propagation: The child dotnet publish process doesn't inherit RuntimeConfiguration, TargetArchitecture, TargetOS, or BuildArchitecture from the outer build, causing crossgen2 and runtime pack paths to resolve incorrectly (especially in cross-build scenarios like building on linux-x64 for linux-arm).
Fix
Debuggees/Directory.Build.targets
  • Import targetingpacks.targets for runtime/targeting pack resolution
  • Import tests.readytorun.targets via AfterMicrosoftNETSdkTargets to override ResolveReadyToRunCompilers after the SDK defines it, pointing directly at the locally-built crossgen2
DumpTests.targets
  • Add _DebuggeeRuntimeConfig property (falls back from RuntimeConfiguration -> Configuration -> Debug)
  • Add _DebuggeePublishProps to propagate RuntimeConfiguration, TargetArchitecture, TargetOS, and BuildArchitecture to child dotnet publish calls
prepare-cdac-helix-steps.yml
  • Add runtimeConfiguration parameter (default: Checked) and pass it to BuildDebuggeesOnly so crossgen2 is found under the correct Checked artifacts path
CopilotAI
review requested due to automatic review settings
April 29, 2026 14:01
@max-charlamb
max-charlamb
requested a review
from rcj1April 29, 2026 14:04
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 29, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@max-charlambmax-charlamb
added

NO-REVIEW
Experimental/testing PR, do NOT review it
labels
Apr 29, 2026
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR fixes dump-test debuggee ReadyToRun (R2R) version-skew by ensuring the dump-test debuggees are R2R-compiled using the locally-built crossgen2 that matches the runtime under test, and by flowing the runtime build configuration into the debuggee publish step so crossgen2 is resolved from the correct artifacts directory.
Changes:
  • Import eng/targetingpacks.targets for DumpTests debuggee projects so UpdateLocalCrossgen2Pack redirects crossgen2 to the in-repo build output (instead of the SDK pack).
  • Pass /p:RuntimeConfiguration=... to debuggee dotnet publish invocations so crossgen2 lookup uses the intended CoreCLR artifacts configuration (e.g., checked vs release).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
FileDescription
src/native/managed/cdac/tests/DumpTests/DumpTests.targetsThreads RuntimeConfiguration into debuggee publish so crossgen2 is resolved from the correct locally-built artifacts layout.
src/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targetsImports eng/targetingpacks.targets to activate local crossgen2 pack redirection for debuggee R2R publishing.
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Outdated

Comment threadsrc/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets
CopilotAI
review requested due to automatic review settings
April 29, 2026 17:31
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Outdated

@max-charlamb
max-charlamb
marked this pull request as draft
April 29, 2026 18:33
CopilotAI
review requested due to automatic review settings
April 29, 2026 21:24
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets

This was referenced Apr 30, 2026

Open


Open


Open


Open

@max-charlambmax-charlamb
removed
the 
NO-REVIEW
Experimental/testing PR, do NOT review it
label
Apr 30, 2026
@max-charlamb
max-charlamb
marked this pull request as ready for review
April 30, 2026 15:23
Max Charlamb
[cDAC] Use locally-built crossgen2 for dump test debuggees
1bb0e4b
Import targetingpacks.targets and tests.readytorun.targets (via
AfterMicrosoftNETSdkTargets) in debuggee Directory.Build.targets to
ensure R2R publish uses the locally-built crossgen2 instead of the
SDK's bundled version.
Propagate RuntimeConfiguration, TargetArchitecture, TargetOS, and
BuildArchitecture to child dotnet-publish so that crossgen2 and
runtime pack paths resolve correctly in cross-build scenarios.
Pass RuntimeConfiguration=Checked from the pipeline YAML so that
BuildDebuggeesOnly finds crossgen2 under the Checked artifacts path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
max-charlambforce-pushed
the
fix/dump-tests-use-local-crossgen2
branch
from
6ad3960 to
1bb0e4bCompareApril 30, 2026 17:05
@max-charlamb
max-charlamb
commented
Apr 30, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change
@max-charlamb
max-charlamb
merged commit 550500a
into
dotnet:mainApr 30, 2026

173 of 183 checks passed

@max-charlamb
max-charlamb
deleted the

fix/dump-tests-use-local-crossgen2

branch
April 30, 2026 20:04
@build-analysisbuild-analysisBot
mentioned this pull request
Apr 30, 2026

Closed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 1, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 31, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@steveisoksteveisoksteveisok approved these changes
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@steveisok

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[cDAC] Use locally-built crossgen2 for dump test debuggees - #127561
Merged
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:fix/dump-tests-use-local-crossgen2
Apr 30, 2026
Merged
[cDAC] Use locally-built crossgen2 for dump test debuggees#127561
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:fix/dump-tests-use-local-crossgen2
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Note
This PR was created with the assistance of GitHub Copilot (AI-generated content).
Problem
The AsyncContinuationDumpTests (and potentially other R2R dump tests) fail in CI because the debuggee apps are R2R-compiled with the SDK's bundled crossgen2 instead of the locally-built one. When the locally-built runtime removes or changes types between previews (e.g. PR #127336 removing ExecutionAndSyncBlockStore), the SDK's crossgen2 emits R2R thunks referencing types that no longer exist, causing TypeLoadException or null globals at runtime.
Root Cause
Two issues prevent the locally-built crossgen2 from being used:
  1. NuGet pack layout mismatch: The SDK's ResolveReadyToRunCompilers task expects crossgen2 at PackagePath/tools/crossgen2.exe (NuGet pack layout), but the local build produces a flat layout with crossgen2.exe at the root of Crossgen2InBuildDir. targetingpacks.targets alone cannot fix this because it only updates PackageDirectory without restructuring the layout.
  2. Missing property propagation: The child dotnet publish process doesn't inherit RuntimeConfiguration, TargetArchitecture, TargetOS, or BuildArchitecture from the outer build, causing crossgen2 and runtime pack paths to resolve incorrectly (especially in cross-build scenarios like building on linux-x64 for linux-arm).
Fix
Debuggees/Directory.Build.targets
  • Import targetingpacks.targets for runtime/targeting pack resolution
  • Import tests.readytorun.targets via AfterMicrosoftNETSdkTargets to override ResolveReadyToRunCompilers after the SDK defines it, pointing directly at the locally-built crossgen2
DumpTests.targets
  • Add _DebuggeeRuntimeConfig property (falls back from RuntimeConfiguration -> Configuration -> Debug)
  • Add _DebuggeePublishProps to propagate RuntimeConfiguration, TargetArchitecture, TargetOS, and BuildArchitecture to child dotnet publish calls
prepare-cdac-helix-steps.yml
  • Add runtimeConfiguration parameter (default: Checked) and pass it to BuildDebuggeesOnly so crossgen2 is found under the correct Checked artifacts path
CopilotAI
review requested due to automatic review settings
April 29, 2026 14:01
@max-charlamb
max-charlamb
requested a review
from rcj1April 29, 2026 14:04
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 29, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@max-charlambmax-charlamb
added

NO-REVIEW
Experimental/testing PR, do NOT review it
labels
Apr 29, 2026
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR fixes dump-test debuggee ReadyToRun (R2R) version-skew by ensuring the dump-test debuggees are R2R-compiled using the locally-built crossgen2 that matches the runtime under test, and by flowing the runtime build configuration into the debuggee publish step so crossgen2 is resolved from the correct artifacts directory.
Changes:
  • Import eng/targetingpacks.targets for DumpTests debuggee projects so UpdateLocalCrossgen2Pack redirects crossgen2 to the in-repo build output (instead of the SDK pack).
  • Pass /p:RuntimeConfiguration=... to debuggee dotnet publish invocations so crossgen2 lookup uses the intended CoreCLR artifacts configuration (e.g., checked vs release).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
FileDescription
src/native/managed/cdac/tests/DumpTests/DumpTests.targetsThreads RuntimeConfiguration into debuggee publish so crossgen2 is resolved from the correct locally-built artifacts layout.
src/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targetsImports eng/targetingpacks.targets to activate local crossgen2 pack redirection for debuggee R2R publishing.
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Outdated

Comment threadsrc/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets
CopilotAI
review requested due to automatic review settings
April 29, 2026 17:31
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Outdated

@max-charlamb
max-charlamb
marked this pull request as draft
April 29, 2026 18:33
CopilotAI
review requested due to automatic review settings
April 29, 2026 21:24
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets

This was referenced Apr 30, 2026

Open


Open


Open


Open

@max-charlambmax-charlamb
removed
the 
NO-REVIEW
Experimental/testing PR, do NOT review it
label
Apr 30, 2026
@max-charlamb
max-charlamb
marked this pull request as ready for review
April 30, 2026 15:23
Max Charlamb
[cDAC] Use locally-built crossgen2 for dump test debuggees
1bb0e4b
Import targetingpacks.targets and tests.readytorun.targets (via
AfterMicrosoftNETSdkTargets) in debuggee Directory.Build.targets to
ensure R2R publish uses the locally-built crossgen2 instead of the
SDK's bundled version.
Propagate RuntimeConfiguration, TargetArchitecture, TargetOS, and
BuildArchitecture to child dotnet-publish so that crossgen2 and
runtime pack paths resolve correctly in cross-build scenarios.
Pass RuntimeConfiguration=Checked from the pipeline YAML so that
BuildDebuggeesOnly finds crossgen2 under the Checked artifacts path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
max-charlambforce-pushed
the
fix/dump-tests-use-local-crossgen2
branch
from
6ad3960 to
1bb0e4bCompareApril 30, 2026 17:05
@max-charlamb
max-charlamb
commented
Apr 30, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change
@max-charlamb
max-charlamb
merged commit 550500a
into
dotnet:mainApr 30, 2026

173 of 183 checks passed

@max-charlamb
max-charlamb
deleted the

fix/dump-tests-use-local-crossgen2

branch
April 30, 2026 20:04
@build-analysisbuild-analysisBot
mentioned this pull request
Apr 30, 2026

Closed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 1, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 31, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@steveisoksteveisoksteveisok approved these changes
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@steveisok

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] Use locally-built crossgen2 for dump test debuggees - #127561
Merged
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:fix/dump-tests-use-local-crossgen2
Apr 30, 2026
Merged
[cDAC] Use locally-built crossgen2 for dump test debuggees#127561
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:fix/dump-tests-use-local-crossgen2
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Note
This PR was created with the assistance of GitHub Copilot (AI-generated content).
Problem
The AsyncContinuationDumpTests (and potentially other R2R dump tests) fail in CI because the debuggee apps are R2R-compiled with the SDK's bundled crossgen2 instead of the locally-built one. When the locally-built runtime removes or changes types between previews (e.g. PR #127336 removing ExecutionAndSyncBlockStore), the SDK's crossgen2 emits R2R thunks referencing types that no longer exist, causing TypeLoadException or null globals at runtime.
Root Cause
Two issues prevent the locally-built crossgen2 from being used:
  1. NuGet pack layout mismatch: The SDK's ResolveReadyToRunCompilers task expects crossgen2 at PackagePath/tools/crossgen2.exe (NuGet pack layout), but the local build produces a flat layout with crossgen2.exe at the root of Crossgen2InBuildDir. targetingpacks.targets alone cannot fix this because it only updates PackageDirectory without restructuring the layout.
  2. Missing property propagation: The child dotnet publish process doesn't inherit RuntimeConfiguration, TargetArchitecture, TargetOS, or BuildArchitecture from the outer build, causing crossgen2 and runtime pack paths to resolve incorrectly (especially in cross-build scenarios like building on linux-x64 for linux-arm).
Fix
Debuggees/Directory.Build.targets
  • Import targetingpacks.targets for runtime/targeting pack resolution
  • Import tests.readytorun.targets via AfterMicrosoftNETSdkTargets to override ResolveReadyToRunCompilers after the SDK defines it, pointing directly at the locally-built crossgen2
DumpTests.targets
  • Add _DebuggeeRuntimeConfig property (falls back from RuntimeConfiguration -> Configuration -> Debug)
  • Add _DebuggeePublishProps to propagate RuntimeConfiguration, TargetArchitecture, TargetOS, and BuildArchitecture to child dotnet publish calls
prepare-cdac-helix-steps.yml
  • Add runtimeConfiguration parameter (default: Checked) and pass it to BuildDebuggeesOnly so crossgen2 is found under the correct Checked artifacts path
CopilotAI
review requested due to automatic review settings
April 29, 2026 14:01
@max-charlamb
max-charlamb
requested a review
from rcj1April 29, 2026 14:04
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 29, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@max-charlambmax-charlamb
added

NO-REVIEW
Experimental/testing PR, do NOT review it
labels
Apr 29, 2026
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR fixes dump-test debuggee ReadyToRun (R2R) version-skew by ensuring the dump-test debuggees are R2R-compiled using the locally-built crossgen2 that matches the runtime under test, and by flowing the runtime build configuration into the debuggee publish step so crossgen2 is resolved from the correct artifacts directory.
Changes:
  • Import eng/targetingpacks.targets for DumpTests debuggee projects so UpdateLocalCrossgen2Pack redirects crossgen2 to the in-repo build output (instead of the SDK pack).
  • Pass /p:RuntimeConfiguration=... to debuggee dotnet publish invocations so crossgen2 lookup uses the intended CoreCLR artifacts configuration (e.g., checked vs release).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
FileDescription
src/native/managed/cdac/tests/DumpTests/DumpTests.targetsThreads RuntimeConfiguration into debuggee publish so crossgen2 is resolved from the correct locally-built artifacts layout.
src/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targetsImports eng/targetingpacks.targets to activate local crossgen2 pack redirection for debuggee R2R publishing.
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Outdated

Comment threadsrc/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets
CopilotAI
review requested due to automatic review settings
April 29, 2026 17:31
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Outdated

@max-charlamb
max-charlamb
marked this pull request as draft
April 29, 2026 18:33
CopilotAI
review requested due to automatic review settings
April 29, 2026 21:24
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets

This was referenced Apr 30, 2026

Open


Open


Open


Open

@max-charlambmax-charlamb
removed
the 
NO-REVIEW
Experimental/testing PR, do NOT review it
label
Apr 30, 2026
@max-charlamb
max-charlamb
marked this pull request as ready for review
April 30, 2026 15:23
Max Charlamb
[cDAC] Use locally-built crossgen2 for dump test debuggees
1bb0e4b
Import targetingpacks.targets and tests.readytorun.targets (via
AfterMicrosoftNETSdkTargets) in debuggee Directory.Build.targets to
ensure R2R publish uses the locally-built crossgen2 instead of the
SDK's bundled version.
Propagate RuntimeConfiguration, TargetArchitecture, TargetOS, and
BuildArchitecture to child dotnet-publish so that crossgen2 and
runtime pack paths resolve correctly in cross-build scenarios.
Pass RuntimeConfiguration=Checked from the pipeline YAML so that
BuildDebuggeesOnly finds crossgen2 under the Checked artifacts path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
max-charlambforce-pushed
the
fix/dump-tests-use-local-crossgen2
branch
from
6ad3960 to
1bb0e4bCompareApril 30, 2026 17:05
@max-charlamb
max-charlamb
commented
Apr 30, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change
@max-charlamb
max-charlamb
merged commit 550500a
into
dotnet:mainApr 30, 2026

173 of 183 checks passed

@max-charlamb
max-charlamb
deleted the

fix/dump-tests-use-local-crossgen2

branch
April 30, 2026 20:04
@build-analysisbuild-analysisBot
mentioned this pull request
Apr 30, 2026

Closed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 1, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 31, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@steveisoksteveisoksteveisok approved these changes
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@steveisok

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] Use locally-built crossgen2 for dump test debuggees - #127561
Merged
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:fix/dump-tests-use-local-crossgen2
Apr 30, 2026
Merged
[cDAC] Use locally-built crossgen2 for dump test debuggees#127561
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:fix/dump-tests-use-local-crossgen2
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Note
This PR was created with the assistance of GitHub Copilot (AI-generated content).
Problem
The AsyncContinuationDumpTests (and potentially other R2R dump tests) fail in CI because the debuggee apps are R2R-compiled with the SDK's bundled crossgen2 instead of the locally-built one. When the locally-built runtime removes or changes types between previews (e.g. PR #127336 removing ExecutionAndSyncBlockStore), the SDK's crossgen2 emits R2R thunks referencing types that no longer exist, causing TypeLoadException or null globals at runtime.
Root Cause
Two issues prevent the locally-built crossgen2 from being used:
  1. NuGet pack layout mismatch: The SDK's ResolveReadyToRunCompilers task expects crossgen2 at PackagePath/tools/crossgen2.exe (NuGet pack layout), but the local build produces a flat layout with crossgen2.exe at the root of Crossgen2InBuildDir. targetingpacks.targets alone cannot fix this because it only updates PackageDirectory without restructuring the layout.
  2. Missing property propagation: The child dotnet publish process doesn't inherit RuntimeConfiguration, TargetArchitecture, TargetOS, or BuildArchitecture from the outer build, causing crossgen2 and runtime pack paths to resolve incorrectly (especially in cross-build scenarios like building on linux-x64 for linux-arm).
Fix
Debuggees/Directory.Build.targets
  • Import targetingpacks.targets for runtime/targeting pack resolution
  • Import tests.readytorun.targets via AfterMicrosoftNETSdkTargets to override ResolveReadyToRunCompilers after the SDK defines it, pointing directly at the locally-built crossgen2
DumpTests.targets
  • Add _DebuggeeRuntimeConfig property (falls back from RuntimeConfiguration -> Configuration -> Debug)
  • Add _DebuggeePublishProps to propagate RuntimeConfiguration, TargetArchitecture, TargetOS, and BuildArchitecture to child dotnet publish calls
prepare-cdac-helix-steps.yml
  • Add runtimeConfiguration parameter (default: Checked) and pass it to BuildDebuggeesOnly so crossgen2 is found under the correct Checked artifacts path
CopilotAI
review requested due to automatic review settings
April 29, 2026 14:01
@max-charlamb
max-charlamb
requested a review
from rcj1April 29, 2026 14:04
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 29, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@max-charlambmax-charlamb
added

NO-REVIEW
Experimental/testing PR, do NOT review it
labels
Apr 29, 2026
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR fixes dump-test debuggee ReadyToRun (R2R) version-skew by ensuring the dump-test debuggees are R2R-compiled using the locally-built crossgen2 that matches the runtime under test, and by flowing the runtime build configuration into the debuggee publish step so crossgen2 is resolved from the correct artifacts directory.
Changes:
  • Import eng/targetingpacks.targets for DumpTests debuggee projects so UpdateLocalCrossgen2Pack redirects crossgen2 to the in-repo build output (instead of the SDK pack).
  • Pass /p:RuntimeConfiguration=... to debuggee dotnet publish invocations so crossgen2 lookup uses the intended CoreCLR artifacts configuration (e.g., checked vs release).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
FileDescription
src/native/managed/cdac/tests/DumpTests/DumpTests.targetsThreads RuntimeConfiguration into debuggee publish so crossgen2 is resolved from the correct locally-built artifacts layout.
src/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targetsImports eng/targetingpacks.targets to activate local crossgen2 pack redirection for debuggee R2R publishing.
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Outdated

Comment threadsrc/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets
CopilotAI
review requested due to automatic review settings
April 29, 2026 17:31
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Outdated

@max-charlamb
max-charlamb
marked this pull request as draft
April 29, 2026 18:33
CopilotAI
review requested due to automatic review settings
April 29, 2026 21:24
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets

This was referenced Apr 30, 2026

Open


Open


Open


Open

@max-charlambmax-charlamb
removed
the 
NO-REVIEW
Experimental/testing PR, do NOT review it
label
Apr 30, 2026
@max-charlamb
max-charlamb
marked this pull request as ready for review
April 30, 2026 15:23
Max Charlamb
[cDAC] Use locally-built crossgen2 for dump test debuggees
1bb0e4b
Import targetingpacks.targets and tests.readytorun.targets (via
AfterMicrosoftNETSdkTargets) in debuggee Directory.Build.targets to
ensure R2R publish uses the locally-built crossgen2 instead of the
SDK's bundled version.
Propagate RuntimeConfiguration, TargetArchitecture, TargetOS, and
BuildArchitecture to child dotnet-publish so that crossgen2 and
runtime pack paths resolve correctly in cross-build scenarios.
Pass RuntimeConfiguration=Checked from the pipeline YAML so that
BuildDebuggeesOnly finds crossgen2 under the Checked artifacts path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
max-charlambforce-pushed
the
fix/dump-tests-use-local-crossgen2
branch
from
6ad3960 to
1bb0e4bCompareApril 30, 2026 17:05
@max-charlamb
max-charlamb
commented
Apr 30, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change
@max-charlamb
max-charlamb
merged commit 550500a
into
dotnet:mainApr 30, 2026

173 of 183 checks passed

@max-charlamb
max-charlamb
deleted the

fix/dump-tests-use-local-crossgen2

branch
April 30, 2026 20:04
@build-analysisbuild-analysisBot
mentioned this pull request
Apr 30, 2026

Closed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 1, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 31, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@steveisoksteveisoksteveisok approved these changes
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@steveisok

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[cDAC] Use locally-built crossgen2 for dump test debuggees - #127561
Merged
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:fix/dump-tests-use-local-crossgen2
Apr 30, 2026
Merged
[cDAC] Use locally-built crossgen2 for dump test debuggees#127561
max-charlamb merged 1 commit into
dotnet:mainfrom 
max-charlamb:fix/dump-tests-use-local-crossgen2
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Note
This PR was created with the assistance of GitHub Copilot (AI-generated content).
Problem
The AsyncContinuationDumpTests (and potentially other R2R dump tests) fail in CI because the debuggee apps are R2R-compiled with the SDK's bundled crossgen2 instead of the locally-built one. When the locally-built runtime removes or changes types between previews (e.g. PR #127336 removing ExecutionAndSyncBlockStore), the SDK's crossgen2 emits R2R thunks referencing types that no longer exist, causing TypeLoadException or null globals at runtime.
Root Cause
Two issues prevent the locally-built crossgen2 from being used:
  1. NuGet pack layout mismatch: The SDK's ResolveReadyToRunCompilers task expects crossgen2 at PackagePath/tools/crossgen2.exe (NuGet pack layout), but the local build produces a flat layout with crossgen2.exe at the root of Crossgen2InBuildDir. targetingpacks.targets alone cannot fix this because it only updates PackageDirectory without restructuring the layout.
  2. Missing property propagation: The child dotnet publish process doesn't inherit RuntimeConfiguration, TargetArchitecture, TargetOS, or BuildArchitecture from the outer build, causing crossgen2 and runtime pack paths to resolve incorrectly (especially in cross-build scenarios like building on linux-x64 for linux-arm).
Fix
Debuggees/Directory.Build.targets
  • Import targetingpacks.targets for runtime/targeting pack resolution
  • Import tests.readytorun.targets via AfterMicrosoftNETSdkTargets to override ResolveReadyToRunCompilers after the SDK defines it, pointing directly at the locally-built crossgen2
DumpTests.targets
  • Add _DebuggeeRuntimeConfig property (falls back from RuntimeConfiguration -> Configuration -> Debug)
  • Add _DebuggeePublishProps to propagate RuntimeConfiguration, TargetArchitecture, TargetOS, and BuildArchitecture to child dotnet publish calls
prepare-cdac-helix-steps.yml
  • Add runtimeConfiguration parameter (default: Checked) and pass it to BuildDebuggeesOnly so crossgen2 is found under the correct Checked artifacts path
CopilotAI
review requested due to automatic review settings
April 29, 2026 14:01
@max-charlamb
max-charlamb
requested a review
from rcj1April 29, 2026 14:04
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 29, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@max-charlambmax-charlamb
added

NO-REVIEW
Experimental/testing PR, do NOT review it
labels
Apr 29, 2026
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR fixes dump-test debuggee ReadyToRun (R2R) version-skew by ensuring the dump-test debuggees are R2R-compiled using the locally-built crossgen2 that matches the runtime under test, and by flowing the runtime build configuration into the debuggee publish step so crossgen2 is resolved from the correct artifacts directory.
Changes:
  • Import eng/targetingpacks.targets for DumpTests debuggee projects so UpdateLocalCrossgen2Pack redirects crossgen2 to the in-repo build output (instead of the SDK pack).
  • Pass /p:RuntimeConfiguration=... to debuggee dotnet publish invocations so crossgen2 lookup uses the intended CoreCLR artifacts configuration (e.g., checked vs release).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
FileDescription
src/native/managed/cdac/tests/DumpTests/DumpTests.targetsThreads RuntimeConfiguration into debuggee publish so crossgen2 is resolved from the correct locally-built artifacts layout.
src/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targetsImports eng/targetingpacks.targets to activate local crossgen2 pack redirection for debuggee R2R publishing.
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Outdated

Comment threadsrc/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets
CopilotAI
review requested due to automatic review settings
April 29, 2026 17:31
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Comment threadsrc/native/managed/cdac/tests/DumpTests/DumpTests.targets
Outdated

@max-charlamb
max-charlamb
marked this pull request as draft
April 29, 2026 18:33
CopilotAI
review requested due to automatic review settings
April 29, 2026 21:24
CopilotAI
reviewed
Apr 29, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comment threadsrc/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets

This was referenced Apr 30, 2026

Open


Open


Open


Open

@max-charlambmax-charlamb
removed
the 
NO-REVIEW
Experimental/testing PR, do NOT review it
label
Apr 30, 2026
@max-charlamb
max-charlamb
marked this pull request as ready for review
April 30, 2026 15:23
Max Charlamb
[cDAC] Use locally-built crossgen2 for dump test debuggees
1bb0e4b
Import targetingpacks.targets and tests.readytorun.targets (via
AfterMicrosoftNETSdkTargets) in debuggee Directory.Build.targets to
ensure R2R publish uses the locally-built crossgen2 instead of the
SDK's bundled version.
Propagate RuntimeConfiguration, TargetArchitecture, TargetOS, and
BuildArchitecture to child dotnet-publish so that crossgen2 and
runtime pack paths resolve correctly in cross-build scenarios.
Pass RuntimeConfiguration=Checked from the pipeline YAML so that
BuildDebuggeesOnly finds crossgen2 under the Checked artifacts path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
max-charlambforce-pushed
the
fix/dump-tests-use-local-crossgen2
branch
from
6ad3960 to
1bb0e4bCompareApril 30, 2026 17:05
@max-charlamb
max-charlamb
commented
Apr 30, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change
@max-charlamb
max-charlamb
merged commit 550500a
into
dotnet:mainApr 30, 2026

173 of 183 checks passed

@max-charlamb
max-charlamb
deleted the

fix/dump-tests-use-local-crossgen2

branch
April 30, 2026 20:04
@build-analysisbuild-analysisBot
mentioned this pull request
Apr 30, 2026

Closed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 1, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 31, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@steveisoksteveisoksteveisok approved these changes
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@steveisok