Don't report a interp->native transition when it is done from a pinvoke method by BrzVlad · Pull Request #127660 · dotnet/runtime

BrzVlad · 2026-05-01T19:41:11Z

We didn't report these transitions when they were triggered from ILStubs because they already explicitly do this. Following the change of using transient IL belonging to the actual PInvoke method rather than separate ILStub methods (which should contain the same logic as the ILStub used to), we would now report the same event twice. We need therefore to also ignore the case where we are doing a PInvoke call from an actual PInvoke method.

Fixes src/tests/profiler/transitions/transitions.csproj which regressed after #126509 on interpreter.

…ke method We didn't report these transitions when they were triggered from ILStubs because they already explicitly do this. Following the change of using transient IL belonging to the actual PInvoke method rather than separate ILStub methods (which should contain the same logic as the ILStub used to), we would now report the same event twice. We need therefore to also ignore the case where we are doing a PInvoke call from an actual PInvoke method. Fixes src/tests/profiler/transitions/transitions.csproj.

BrzVlad · 2026-05-01T19:42:06Z

/azp run runtime-interpreter

azure-pipelines · 2026-05-01T19:42:15Z

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-policy-service · 2026-05-01T19:42:22Z

Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR adjusts CoreCLR interpreter profiling transition reporting to avoid double-counting managed↔unmanaged transition events when the interpreter executes transient-IL-backed P/Invoke methods (post-#126509). This restores expected behavior for profiler transition tests by suppressing interpreter-side transition callbacks in cases where the P/Invoke body already performs the transition notifications.

Changes:

Suppress ProfilerManagedToUnmanagedTransitionMD / ProfilerUnmanagedToManagedTransitionMD callbacks in the interpreter calli-with-transition path when the currently interpreted method is a P/Invoke.
Preserve the existing suppression for IL stubs, extending it to P/Invoke methods now that the transient IL is attributed to the P/Invoke MethodDesc.

BrzVlad · 2026-05-01T19:41:11Z

We didn't report these transitions when they were triggered from ILStubs because they already explicitly do this. Following the change of using transient IL belonging to the actual PInvoke method rather than separate ILStub methods (which should contain the same logic as the ILStub used to), we would now report the same event twice. We need therefore to also ignore the case where we are doing a PInvoke call from an actual PInvoke method.

Fixes src/tests/profiler/transitions/transitions.csproj which regressed after #126509 on interpreter.

…ke method We didn't report these transitions when they were triggered from ILStubs because they already explicitly do this. Following the change of using transient IL belonging to the actual PInvoke method rather than separate ILStub methods (which should contain the same logic as the ILStub used to), we would now report the same event twice. We need therefore to also ignore the case where we are doing a PInvoke call from an actual PInvoke method. Fixes src/tests/profiler/transitions/transitions.csproj.

BrzVlad · 2026-05-01T19:42:06Z

/azp run runtime-interpreter

azure-pipelines · 2026-05-01T19:42:15Z

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-policy-service · 2026-05-01T19:42:22Z

Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR adjusts CoreCLR interpreter profiling transition reporting to avoid double-counting managed↔unmanaged transition events when the interpreter executes transient-IL-backed P/Invoke methods (post-#126509). This restores expected behavior for profiler transition tests by suppressing interpreter-side transition callbacks in cases where the P/Invoke body already performs the transition notifications.

Changes:

Suppress ProfilerManagedToUnmanagedTransitionMD / ProfilerUnmanagedToManagedTransitionMD callbacks in the interpreter calli-with-transition path when the currently interpreted method is a P/Invoke.
Preserve the existing suppression for IL stubs, extending it to P/Invoke methods now that the transient IL is attributed to the P/Invoke MethodDesc.

BrzVlad · 2026-05-01T19:41:11Z

We didn't report these transitions when they were triggered from ILStubs because they already explicitly do this. Following the change of using transient IL belonging to the actual PInvoke method rather than separate ILStub methods (which should contain the same logic as the ILStub used to), we would now report the same event twice. We need therefore to also ignore the case where we are doing a PInvoke call from an actual PInvoke method.

Fixes src/tests/profiler/transitions/transitions.csproj which regressed after #126509 on interpreter.

…ke method We didn't report these transitions when they were triggered from ILStubs because they already explicitly do this. Following the change of using transient IL belonging to the actual PInvoke method rather than separate ILStub methods (which should contain the same logic as the ILStub used to), we would now report the same event twice. We need therefore to also ignore the case where we are doing a PInvoke call from an actual PInvoke method. Fixes src/tests/profiler/transitions/transitions.csproj.

BrzVlad · 2026-05-01T19:42:06Z

/azp run runtime-interpreter

azure-pipelines · 2026-05-01T19:42:15Z

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-policy-service · 2026-05-01T19:42:22Z

Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR adjusts CoreCLR interpreter profiling transition reporting to avoid double-counting managed↔unmanaged transition events when the interpreter executes transient-IL-backed P/Invoke methods (post-#126509). This restores expected behavior for profiler transition tests by suppressing interpreter-side transition callbacks in cases where the P/Invoke body already performs the transition notifications.

Changes:

Suppress ProfilerManagedToUnmanagedTransitionMD / ProfilerUnmanagedToManagedTransitionMD callbacks in the interpreter calli-with-transition path when the currently interpreted method is a P/Invoke.
Preserve the existing suppression for IL stubs, extending it to P/Invoke methods now that the transient IL is attributed to the P/Invoke MethodDesc.

BrzVlad · 2026-05-01T19:41:11Z

We didn't report these transitions when they were triggered from ILStubs because they already explicitly do this. Following the change of using transient IL belonging to the actual PInvoke method rather than separate ILStub methods (which should contain the same logic as the ILStub used to), we would now report the same event twice. We need therefore to also ignore the case where we are doing a PInvoke call from an actual PInvoke method.

Fixes src/tests/profiler/transitions/transitions.csproj which regressed after #126509 on interpreter.

…ke method We didn't report these transitions when they were triggered from ILStubs because they already explicitly do this. Following the change of using transient IL belonging to the actual PInvoke method rather than separate ILStub methods (which should contain the same logic as the ILStub used to), we would now report the same event twice. We need therefore to also ignore the case where we are doing a PInvoke call from an actual PInvoke method. Fixes src/tests/profiler/transitions/transitions.csproj.

BrzVlad · 2026-05-01T19:42:06Z

/azp run runtime-interpreter

azure-pipelines · 2026-05-01T19:42:15Z

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-policy-service · 2026-05-01T19:42:22Z

Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR adjusts CoreCLR interpreter profiling transition reporting to avoid double-counting managed↔unmanaged transition events when the interpreter executes transient-IL-backed P/Invoke methods (post-#126509). This restores expected behavior for profiler transition tests by suppressing interpreter-side transition callbacks in cases where the P/Invoke body already performs the transition notifications.

Changes:

Suppress ProfilerManagedToUnmanagedTransitionMD / ProfilerUnmanagedToManagedTransitionMD callbacks in the interpreter calli-with-transition path when the currently interpreted method is a P/Invoke.
Preserve the existing suppression for IL stubs, extending it to P/Invoke methods now that the transient IL is attributed to the P/Invoke MethodDesc.

BrzVlad · 2026-05-01T19:41:11Z

We didn't report these transitions when they were triggered from ILStubs because they already explicitly do this. Following the change of using transient IL belonging to the actual PInvoke method rather than separate ILStub methods (which should contain the same logic as the ILStub used to), we would now report the same event twice. We need therefore to also ignore the case where we are doing a PInvoke call from an actual PInvoke method.

Fixes src/tests/profiler/transitions/transitions.csproj which regressed after #126509 on interpreter.

…ke method We didn't report these transitions when they were triggered from ILStubs because they already explicitly do this. Following the change of using transient IL belonging to the actual PInvoke method rather than separate ILStub methods (which should contain the same logic as the ILStub used to), we would now report the same event twice. We need therefore to also ignore the case where we are doing a PInvoke call from an actual PInvoke method. Fixes src/tests/profiler/transitions/transitions.csproj.

BrzVlad · 2026-05-01T19:42:06Z

/azp run runtime-interpreter

azure-pipelines · 2026-05-01T19:42:15Z

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-policy-service · 2026-05-01T19:42:22Z

Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR adjusts CoreCLR interpreter profiling transition reporting to avoid double-counting managed↔unmanaged transition events when the interpreter executes transient-IL-backed P/Invoke methods (post-#126509). This restores expected behavior for profiler transition tests by suppressing interpreter-side transition callbacks in cases where the P/Invoke body already performs the transition notifications.

Changes:

Suppress ProfilerManagedToUnmanagedTransitionMD / ProfilerUnmanagedToManagedTransitionMD callbacks in the interpreter calli-with-transition path when the currently interpreted method is a P/Invoke.
Preserve the existing suppression for IL stubs, extending it to P/Invoke methods now that the transient IL is attributed to the P/Invoke MethodDesc.

BrzVlad · 2026-05-01T19:41:11Z

We didn't report these transitions when they were triggered from ILStubs because they already explicitly do this. Following the change of using transient IL belonging to the actual PInvoke method rather than separate ILStub methods (which should contain the same logic as the ILStub used to), we would now report the same event twice. We need therefore to also ignore the case where we are doing a PInvoke call from an actual PInvoke method.

Fixes src/tests/profiler/transitions/transitions.csproj which regressed after #126509 on interpreter.

…ke method We didn't report these transitions when they were triggered from ILStubs because they already explicitly do this. Following the change of using transient IL belonging to the actual PInvoke method rather than separate ILStub methods (which should contain the same logic as the ILStub used to), we would now report the same event twice. We need therefore to also ignore the case where we are doing a PInvoke call from an actual PInvoke method. Fixes src/tests/profiler/transitions/transitions.csproj.

BrzVlad · 2026-05-01T19:42:06Z

/azp run runtime-interpreter

azure-pipelines · 2026-05-01T19:42:15Z

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-policy-service · 2026-05-01T19:42:22Z

Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR adjusts CoreCLR interpreter profiling transition reporting to avoid double-counting managed↔unmanaged transition events when the interpreter executes transient-IL-backed P/Invoke methods (post-#126509). This restores expected behavior for profiler transition tests by suppressing interpreter-side transition callbacks in cases where the P/Invoke body already performs the transition notifications.

Changes:

Suppress ProfilerManagedToUnmanagedTransitionMD / ProfilerUnmanagedToManagedTransitionMD callbacks in the interpreter calli-with-transition path when the currently interpreted method is a P/Invoke.
Preserve the existing suppression for IL stubs, extending it to P/Invoke methods now that the transient IL is attributed to the P/Invoke MethodDesc.

BrzVlad · 2026-05-01T19:41:11Z

We didn't report these transitions when they were triggered from ILStubs because they already explicitly do this. Following the change of using transient IL belonging to the actual PInvoke method rather than separate ILStub methods (which should contain the same logic as the ILStub used to), we would now report the same event twice. We need therefore to also ignore the case where we are doing a PInvoke call from an actual PInvoke method.

Fixes src/tests/profiler/transitions/transitions.csproj which regressed after #126509 on interpreter.

…ke method We didn't report these transitions when they were triggered from ILStubs because they already explicitly do this. Following the change of using transient IL belonging to the actual PInvoke method rather than separate ILStub methods (which should contain the same logic as the ILStub used to), we would now report the same event twice. We need therefore to also ignore the case where we are doing a PInvoke call from an actual PInvoke method. Fixes src/tests/profiler/transitions/transitions.csproj.

BrzVlad · 2026-05-01T19:42:06Z

/azp run runtime-interpreter

azure-pipelines · 2026-05-01T19:42:15Z

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-policy-service · 2026-05-01T19:42:22Z

Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR adjusts CoreCLR interpreter profiling transition reporting to avoid double-counting managed↔unmanaged transition events when the interpreter executes transient-IL-backed P/Invoke methods (post-#126509). This restores expected behavior for profiler transition tests by suppressing interpreter-side transition callbacks in cases where the P/Invoke body already performs the transition notifications.

Changes:

Suppress ProfilerManagedToUnmanagedTransitionMD / ProfilerUnmanagedToManagedTransitionMD callbacks in the interpreter calli-with-transition path when the currently interpreted method is a P/Invoke.
Preserve the existing suppression for IL stubs, extending it to P/Invoke methods now that the transient IL is attributed to the P/Invoke MethodDesc.

BrzVlad · 2026-05-01T19:41:11Z

We didn't report these transitions when they were triggered from ILStubs because they already explicitly do this. Following the change of using transient IL belonging to the actual PInvoke method rather than separate ILStub methods (which should contain the same logic as the ILStub used to), we would now report the same event twice. We need therefore to also ignore the case where we are doing a PInvoke call from an actual PInvoke method.

Fixes src/tests/profiler/transitions/transitions.csproj which regressed after #126509 on interpreter.

…ke method We didn't report these transitions when they were triggered from ILStubs because they already explicitly do this. Following the change of using transient IL belonging to the actual PInvoke method rather than separate ILStub methods (which should contain the same logic as the ILStub used to), we would now report the same event twice. We need therefore to also ignore the case where we are doing a PInvoke call from an actual PInvoke method. Fixes src/tests/profiler/transitions/transitions.csproj.

BrzVlad · 2026-05-01T19:42:06Z

/azp run runtime-interpreter

azure-pipelines · 2026-05-01T19:42:15Z

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-policy-service · 2026-05-01T19:42:22Z

Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR adjusts CoreCLR interpreter profiling transition reporting to avoid double-counting managed↔unmanaged transition events when the interpreter executes transient-IL-backed P/Invoke methods (post-#126509). This restores expected behavior for profiler transition tests by suppressing interpreter-side transition callbacks in cases where the P/Invoke body already performs the transition notifications.

Changes:

Suppress ProfilerManagedToUnmanagedTransitionMD / ProfilerUnmanagedToManagedTransitionMD callbacks in the interpreter calli-with-transition path when the currently interpreted method is a P/Invoke.
Preserve the existing suppression for IL stubs, extending it to P/Invoke methods now that the transient IL is attributed to the P/Invoke MethodDesc.

CopilotAI review requested due to automatic review settings May 1, 2026 19:41

BrzVlad requested review from janvorli and kg as code owners May 1, 2026 19:41

BrzVlad added the area-CodeGen-Interpreter-coreclr label May 1, 2026

Copilotstarted reviewing on behalf of BrzVlad May 1, 2026 19:41 View session

BrzVlad requested a review from jkoritzinsky May 1, 2026 19:41

dotnet-policy-serviceBot assigned BrzVlad May 1, 2026

CopilotAI reviewed May 1, 2026
View reviewed changes

jkoritzinsky approved these changes May 1, 2026
View reviewed changes

BrzVlad merged commit 11a3209 into dotnet:mainMay 2, 2026
126 of 132 checks passed

dotnet-maestroBot mentioned this pull request May 3, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#6423
Merged

github-actionsBot locked and limited conversation to collaborators Jun 2, 2026