Replace GetOsPageSize() with minipal_getpagesize() in CoreCLR

[pavelsavara]

Fixes#127550

Summary

Remove the GetOsPageSize() wrapper from utilcode and replace all call sites in CoreCLR with the new minipal_getpagesize() API introduced in #127328.

Motivation

PR #127328 introduced minipal_getpagesize() in src/native/minipal/ospagesize.h as the canonical way to query the OS page size across all platforms:

• Windows: inline constant 4096 (no syscall)
• WASM: inline constant 16384 (reduced from the 64KB memory.grow granularity)
• Unix: cached getpagesize() result (queried once per process)

The old GetOsPageSize() in src/coreclr/utilcode/util.cpp duplicated this logic with slightly different behavior (used GetSystemInfo().dwAllocationGranularity on the PAL path, hardcoded 0x1000 on Windows). Consolidating on the minipal version eliminates the duplication and ensures consistent page-size semantics, particularly for WASM where the correct value is 16KB.

Changes

minipal_getpagesize() API

• Return type changed from size_t to uint32_t so the value matches the natural width used by call sites and avoids (uint32_t) casts at every use.
• Windows and WASM remain inline compile-time constants (the GC requires this to fold into a constant for alignment math).

CoreCLR consumers

• RemovedGetOsPageSize() and GetOsPageSizeUncached() definitions from src/coreclr/utilcode/util.cpp
• RemovedGetOsPageSize() declaration from src/coreclr/inc/utilcode.h
• Added#include <minipal/ospagesize.h> to utilcode.h (covers all VM/utilcode consumers) and to the two PAL test files that don't include utilcode.h
• Replaced all GetOsPageSize() call sites with minipal_getpagesize()
• Removed redundant (uint32_t) and (ptrdiff_t) casts at call sites now that minipal_getpagesize() returns uint32_t
• FixedHARD_GUARD_REGION_SIZE being defined twice in threads.h (removed the redundant first definition)
• FixedSIZEOF_DEFAULT_STACK_GUARANTEE and HARD_GUARD_REGION_SIZE macro hygiene (wrapped in outer parentheses, removed pointless 1 * multiplier)
• AdjustedROUND_DOWN_TO_PAGE/ROUND_UP_TO_PAGE in codeman.h to widen the page size to size_t before the bit-NOT mask, avoiding MSVC C4319 (zero-extending uint32_t to size_t)

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR standardizes CoreCLR’s “OS page size” queries by removing the utilcode GetOsPageSize() wrapper and migrating call sites to the canonical minipal_getpagesize() API (including updating a few page-size-related macros and PAL tests). This helps ensure consistent semantics across platforms (notably WASM’s 16KB page size behavior).

Changes:

• Removed GetOsPageSize() / GetOsPageSizeUncached() from utilcode and updated all CoreCLR call sites to use minipal_getpagesize().
• Added/propagated minipal/ospagesize.h inclusion (via utilcode.h and directly in a couple PAL tests).
• Cleaned up some page-size-related macro definitions (duplicate define removal + extra parentheses).

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/native/managed/cdac/tests/PrecodeStubsTests.cs	Updates embedded native-code comment to reflect minipal_getpagesize().
src/coreclr/vm/virtualcallstub.cpp	Uses minipal_getpagesize() for reserve/commit alignment and page computations.
src/coreclr/vm/threads.h	Replaces page-size macros with minipal_getpagesize() and removes duplicate define.
src/coreclr/vm/threads.cpp	Replaces page-size uses in asserts/debug logging/guard-page math with minipal_getpagesize().
src/coreclr/vm/peimagelayout.cpp	Uses minipal_getpagesize() for mapping alignment and validation.
src/coreclr/vm/loaderallocator.cpp	Uses minipal_getpagesize() for collectible heap sizing constants.
src/coreclr/vm/jitinterface.h	Updates UNIX null-check offset definition to use minipal_getpagesize().
src/coreclr/vm/jitinterface.cpp	Reports osPageSize via minipal_getpagesize() in EE info.
src/coreclr/vm/i386/jitinterfacex86.cpp	Updates debug asserts to use minipal_getpagesize().
src/coreclr/vm/hosting.cpp	Updates UEF section page calculations to use minipal_getpagesize().
src/coreclr/vm/frames.cpp	Updates “frame order” relaxation logic to use minipal_getpagesize().
src/coreclr/vm/excep.h	Uses minipal_getpagesize() for NULL_AREA_SIZE on UNIX.
src/coreclr/vm/debughelp.cpp	Uses minipal_getpagesize() when walking/touching pages for readability checks.
src/coreclr/vm/codeman.h	Updates rounding-to-page macros and comments to use minipal_getpagesize().
src/coreclr/vm/ceemain.cpp	Aligns mini-metadata buffer sizing using minipal_getpagesize().
src/coreclr/vm/appdomain.hpp	Updates loader heap reserve/commit sizing macros to use minipal_getpagesize().
src/coreclr/utilcode/util.cpp	Removes the old GetOsPageSize* implementations.
src/coreclr/utilcode/loaderheap.cpp	Uses minipal_getpagesize() for commit sizing alignment.
src/coreclr/utilcode/interleavedloaderheap.cpp	Uses minipal_getpagesize() for alignment/assertions.
src/coreclr/utilcode/explicitcontrolloaderheap.cpp	Uses minipal_getpagesize() for commit block sizing and alignment.
src/coreclr/utilcode/executableallocator.cpp	Uses minipal_getpagesize() when randomizing preferred range start.
src/coreclr/utilcode/dacutil.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/utilcode/clrhost_nodependencies.cpp	Uses minipal_getpagesize() for page-aligned region checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test3/test3.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test2/test2.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/inc/utilcode.h	Includes minipal/ospagesize.h and removes GetOsPageSize() declaration.
src/coreclr/inc/pedecoder.inl	Uses minipal_getpagesize() when temporarily setting decoder size to 2 pages.
src/coreclr/inc/loaderheap.h	Updates stub code page sizing logic to use minipal_getpagesize().
src/coreclr/debug/di/shimlocaldatatarget.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/debug/daccess/enummem.cpp	Uses minipal_getpagesize() for page-chunked memory reporting.

[Copilot]

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated no new comments.

[tannergooding]

Windows: inline constant 4096 (no syscall)

Pretty sure this is not a guarantee of Windows. You are expected to call GetSystemInfo() and read the dwPageSize property. https://devblogs.microsoft.com/oldnewthing/20210510-00/?p=105200 notably goes over some processors that deviate and where Windows has attempted deviations in the past.

I would rather expect that this also makes no difference as to perf for the GC. While we cannot know the page size for certain, we can know that it should only ever be a power of 2 and so we can manually optimize the divisions or modulus ourselves via an unsigned right shift -or- simple bitmasking. -- When we query on startup simply cache the log2(pageSize) and then right shift by it for any latter division.

Many other OS are trending towards to larger page sizes on Arm64 (often 16KB) even, particularly for servers, and I wouldn't be surprised if that changes for Windows as well.

[pavelsavara]

You are expected to call GetSystemInfo() and read the dwPageSize property.

Done

[Copilot]

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.

[jkotas]

Pretty sure this is not a guarantee of Windows.

It is guaranteed on Windows in practice. Every other piece of software for Windows (including many places in Windows itself) has 4kB page size hardcoded somewhere. In case they figure out how to change the page size, it will be an opt-in. We can update this and other places where we depend on the page size indirectly as part of opt-in.

Many other OS are trending towards to larger page sizes on Arm64 (often 16KB) even, particularly for servers

There are also equivalent features being built into the hardware that merge the adjacent page entries into a single TLB cache entry. It provides most of the benefit of large page sizes without breaking software compatibility.

[Copilot]

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.

[jkotas]

Thanks

[am11]

nit: standard C11 version

[Copilot]

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.

[pavelsavara]

/ba-g unrelated CI issues

[pavelsavara]

/ba-g first ba-g didn't work

[pavelsavara]

/ba-g second ba-g didn't work

[pavelsavara]

/ba-g third ba-g didn't work

[pavelsavara]

/ba-g 4th ba-g didn't work

[pavelsavara]

Fixes#127550

Summary

Remove the GetOsPageSize() wrapper from utilcode and replace all call sites in CoreCLR with the new minipal_getpagesize() API introduced in #127328.

Motivation

PR #127328 introduced minipal_getpagesize() in src/native/minipal/ospagesize.h as the canonical way to query the OS page size across all platforms:

• Windows: inline constant 4096 (no syscall)
• WASM: inline constant 16384 (reduced from the 64KB memory.grow granularity)
• Unix: cached getpagesize() result (queried once per process)

The old GetOsPageSize() in src/coreclr/utilcode/util.cpp duplicated this logic with slightly different behavior (used GetSystemInfo().dwAllocationGranularity on the PAL path, hardcoded 0x1000 on Windows). Consolidating on the minipal version eliminates the duplication and ensures consistent page-size semantics, particularly for WASM where the correct value is 16KB.

Changes

minipal_getpagesize() API

• Return type changed from size_t to uint32_t so the value matches the natural width used by call sites and avoids (uint32_t) casts at every use.
• Windows and WASM remain inline compile-time constants (the GC requires this to fold into a constant for alignment math).

CoreCLR consumers

• RemovedGetOsPageSize() and GetOsPageSizeUncached() definitions from src/coreclr/utilcode/util.cpp
• RemovedGetOsPageSize() declaration from src/coreclr/inc/utilcode.h
• Added#include <minipal/ospagesize.h> to utilcode.h (covers all VM/utilcode consumers) and to the two PAL test files that don't include utilcode.h
• Replaced all GetOsPageSize() call sites with minipal_getpagesize()
• Removed redundant (uint32_t) and (ptrdiff_t) casts at call sites now that minipal_getpagesize() returns uint32_t
• FixedHARD_GUARD_REGION_SIZE being defined twice in threads.h (removed the redundant first definition)
• FixedSIZEOF_DEFAULT_STACK_GUARANTEE and HARD_GUARD_REGION_SIZE macro hygiene (wrapped in outer parentheses, removed pointless 1 * multiplier)
• AdjustedROUND_DOWN_TO_PAGE/ROUND_UP_TO_PAGE in codeman.h to widen the page size to size_t before the bit-NOT mask, avoiding MSVC C4319 (zero-extending uint32_t to size_t)

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR standardizes CoreCLR’s “OS page size” queries by removing the utilcode GetOsPageSize() wrapper and migrating call sites to the canonical minipal_getpagesize() API (including updating a few page-size-related macros and PAL tests). This helps ensure consistent semantics across platforms (notably WASM’s 16KB page size behavior).

Changes:

• Removed GetOsPageSize() / GetOsPageSizeUncached() from utilcode and updated all CoreCLR call sites to use minipal_getpagesize().
• Added/propagated minipal/ospagesize.h inclusion (via utilcode.h and directly in a couple PAL tests).
• Cleaned up some page-size-related macro definitions (duplicate define removal + extra parentheses).

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/native/managed/cdac/tests/PrecodeStubsTests.cs	Updates embedded native-code comment to reflect minipal_getpagesize().
src/coreclr/vm/virtualcallstub.cpp	Uses minipal_getpagesize() for reserve/commit alignment and page computations.
src/coreclr/vm/threads.h	Replaces page-size macros with minipal_getpagesize() and removes duplicate define.
src/coreclr/vm/threads.cpp	Replaces page-size uses in asserts/debug logging/guard-page math with minipal_getpagesize().
src/coreclr/vm/peimagelayout.cpp	Uses minipal_getpagesize() for mapping alignment and validation.
src/coreclr/vm/loaderallocator.cpp	Uses minipal_getpagesize() for collectible heap sizing constants.
src/coreclr/vm/jitinterface.h	Updates UNIX null-check offset definition to use minipal_getpagesize().
src/coreclr/vm/jitinterface.cpp	Reports osPageSize via minipal_getpagesize() in EE info.
src/coreclr/vm/i386/jitinterfacex86.cpp	Updates debug asserts to use minipal_getpagesize().
src/coreclr/vm/hosting.cpp	Updates UEF section page calculations to use minipal_getpagesize().
src/coreclr/vm/frames.cpp	Updates “frame order” relaxation logic to use minipal_getpagesize().
src/coreclr/vm/excep.h	Uses minipal_getpagesize() for NULL_AREA_SIZE on UNIX.
src/coreclr/vm/debughelp.cpp	Uses minipal_getpagesize() when walking/touching pages for readability checks.
src/coreclr/vm/codeman.h	Updates rounding-to-page macros and comments to use minipal_getpagesize().
src/coreclr/vm/ceemain.cpp	Aligns mini-metadata buffer sizing using minipal_getpagesize().
src/coreclr/vm/appdomain.hpp	Updates loader heap reserve/commit sizing macros to use minipal_getpagesize().
src/coreclr/utilcode/util.cpp	Removes the old GetOsPageSize* implementations.
src/coreclr/utilcode/loaderheap.cpp	Uses minipal_getpagesize() for commit sizing alignment.
src/coreclr/utilcode/interleavedloaderheap.cpp	Uses minipal_getpagesize() for alignment/assertions.
src/coreclr/utilcode/explicitcontrolloaderheap.cpp	Uses minipal_getpagesize() for commit block sizing and alignment.
src/coreclr/utilcode/executableallocator.cpp	Uses minipal_getpagesize() when randomizing preferred range start.
src/coreclr/utilcode/dacutil.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/utilcode/clrhost_nodependencies.cpp	Uses minipal_getpagesize() for page-aligned region checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test3/test3.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test2/test2.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/inc/utilcode.h	Includes minipal/ospagesize.h and removes GetOsPageSize() declaration.
src/coreclr/inc/pedecoder.inl	Uses minipal_getpagesize() when temporarily setting decoder size to 2 pages.
src/coreclr/inc/loaderheap.h	Updates stub code page sizing logic to use minipal_getpagesize().
src/coreclr/debug/di/shimlocaldatatarget.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/debug/daccess/enummem.cpp	Uses minipal_getpagesize() for page-chunked memory reporting.

[Copilot]

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated no new comments.

[tannergooding]

Windows: inline constant 4096 (no syscall)

Pretty sure this is not a guarantee of Windows. You are expected to call GetSystemInfo() and read the dwPageSize property. https://devblogs.microsoft.com/oldnewthing/20210510-00/?p=105200 notably goes over some processors that deviate and where Windows has attempted deviations in the past.

I would rather expect that this also makes no difference as to perf for the GC. While we cannot know the page size for certain, we can know that it should only ever be a power of 2 and so we can manually optimize the divisions or modulus ourselves via an unsigned right shift -or- simple bitmasking. -- When we query on startup simply cache the log2(pageSize) and then right shift by it for any latter division.

Many other OS are trending towards to larger page sizes on Arm64 (often 16KB) even, particularly for servers, and I wouldn't be surprised if that changes for Windows as well.

[pavelsavara]

You are expected to call GetSystemInfo() and read the dwPageSize property.

Done

[Copilot]

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.

[jkotas]

Pretty sure this is not a guarantee of Windows.

It is guaranteed on Windows in practice. Every other piece of software for Windows (including many places in Windows itself) has 4kB page size hardcoded somewhere. In case they figure out how to change the page size, it will be an opt-in. We can update this and other places where we depend on the page size indirectly as part of opt-in.

Many other OS are trending towards to larger page sizes on Arm64 (often 16KB) even, particularly for servers

There are also equivalent features being built into the hardware that merge the adjacent page entries into a single TLB cache entry. It provides most of the benefit of large page sizes without breaking software compatibility.

[Copilot]

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.

[jkotas]

Thanks

[am11]

nit: standard C11 version

[Copilot]

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.

[pavelsavara]

/ba-g unrelated CI issues

[pavelsavara]

/ba-g first ba-g didn't work

[pavelsavara]

/ba-g second ba-g didn't work

[pavelsavara]

/ba-g third ba-g didn't work

[pavelsavara]

/ba-g 4th ba-g didn't work

[pavelsavara]

Fixes#127550

Summary

Remove the GetOsPageSize() wrapper from utilcode and replace all call sites in CoreCLR with the new minipal_getpagesize() API introduced in #127328.

Motivation

PR #127328 introduced minipal_getpagesize() in src/native/minipal/ospagesize.h as the canonical way to query the OS page size across all platforms:

• Windows: inline constant 4096 (no syscall)
• WASM: inline constant 16384 (reduced from the 64KB memory.grow granularity)
• Unix: cached getpagesize() result (queried once per process)

The old GetOsPageSize() in src/coreclr/utilcode/util.cpp duplicated this logic with slightly different behavior (used GetSystemInfo().dwAllocationGranularity on the PAL path, hardcoded 0x1000 on Windows). Consolidating on the minipal version eliminates the duplication and ensures consistent page-size semantics, particularly for WASM where the correct value is 16KB.

Changes

minipal_getpagesize() API

• Return type changed from size_t to uint32_t so the value matches the natural width used by call sites and avoids (uint32_t) casts at every use.
• Windows and WASM remain inline compile-time constants (the GC requires this to fold into a constant for alignment math).

CoreCLR consumers

• RemovedGetOsPageSize() and GetOsPageSizeUncached() definitions from src/coreclr/utilcode/util.cpp
• RemovedGetOsPageSize() declaration from src/coreclr/inc/utilcode.h
• Added#include <minipal/ospagesize.h> to utilcode.h (covers all VM/utilcode consumers) and to the two PAL test files that don't include utilcode.h
• Replaced all GetOsPageSize() call sites with minipal_getpagesize()
• Removed redundant (uint32_t) and (ptrdiff_t) casts at call sites now that minipal_getpagesize() returns uint32_t
• FixedHARD_GUARD_REGION_SIZE being defined twice in threads.h (removed the redundant first definition)
• FixedSIZEOF_DEFAULT_STACK_GUARANTEE and HARD_GUARD_REGION_SIZE macro hygiene (wrapped in outer parentheses, removed pointless 1 * multiplier)
• AdjustedROUND_DOWN_TO_PAGE/ROUND_UP_TO_PAGE in codeman.h to widen the page size to size_t before the bit-NOT mask, avoiding MSVC C4319 (zero-extending uint32_t to size_t)

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR standardizes CoreCLR’s “OS page size” queries by removing the utilcode GetOsPageSize() wrapper and migrating call sites to the canonical minipal_getpagesize() API (including updating a few page-size-related macros and PAL tests). This helps ensure consistent semantics across platforms (notably WASM’s 16KB page size behavior).

Changes:

• Removed GetOsPageSize() / GetOsPageSizeUncached() from utilcode and updated all CoreCLR call sites to use minipal_getpagesize().
• Added/propagated minipal/ospagesize.h inclusion (via utilcode.h and directly in a couple PAL tests).
• Cleaned up some page-size-related macro definitions (duplicate define removal + extra parentheses).

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/native/managed/cdac/tests/PrecodeStubsTests.cs	Updates embedded native-code comment to reflect minipal_getpagesize().
src/coreclr/vm/virtualcallstub.cpp	Uses minipal_getpagesize() for reserve/commit alignment and page computations.
src/coreclr/vm/threads.h	Replaces page-size macros with minipal_getpagesize() and removes duplicate define.
src/coreclr/vm/threads.cpp	Replaces page-size uses in asserts/debug logging/guard-page math with minipal_getpagesize().
src/coreclr/vm/peimagelayout.cpp	Uses minipal_getpagesize() for mapping alignment and validation.
src/coreclr/vm/loaderallocator.cpp	Uses minipal_getpagesize() for collectible heap sizing constants.
src/coreclr/vm/jitinterface.h	Updates UNIX null-check offset definition to use minipal_getpagesize().
src/coreclr/vm/jitinterface.cpp	Reports osPageSize via minipal_getpagesize() in EE info.
src/coreclr/vm/i386/jitinterfacex86.cpp	Updates debug asserts to use minipal_getpagesize().
src/coreclr/vm/hosting.cpp	Updates UEF section page calculations to use minipal_getpagesize().
src/coreclr/vm/frames.cpp	Updates “frame order” relaxation logic to use minipal_getpagesize().
src/coreclr/vm/excep.h	Uses minipal_getpagesize() for NULL_AREA_SIZE on UNIX.
src/coreclr/vm/debughelp.cpp	Uses minipal_getpagesize() when walking/touching pages for readability checks.
src/coreclr/vm/codeman.h	Updates rounding-to-page macros and comments to use minipal_getpagesize().
src/coreclr/vm/ceemain.cpp	Aligns mini-metadata buffer sizing using minipal_getpagesize().
src/coreclr/vm/appdomain.hpp	Updates loader heap reserve/commit sizing macros to use minipal_getpagesize().
src/coreclr/utilcode/util.cpp	Removes the old GetOsPageSize* implementations.
src/coreclr/utilcode/loaderheap.cpp	Uses minipal_getpagesize() for commit sizing alignment.
src/coreclr/utilcode/interleavedloaderheap.cpp	Uses minipal_getpagesize() for alignment/assertions.
src/coreclr/utilcode/explicitcontrolloaderheap.cpp	Uses minipal_getpagesize() for commit block sizing and alignment.
src/coreclr/utilcode/executableallocator.cpp	Uses minipal_getpagesize() when randomizing preferred range start.
src/coreclr/utilcode/dacutil.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/utilcode/clrhost_nodependencies.cpp	Uses minipal_getpagesize() for page-aligned region checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test3/test3.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test2/test2.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/inc/utilcode.h	Includes minipal/ospagesize.h and removes GetOsPageSize() declaration.
src/coreclr/inc/pedecoder.inl	Uses minipal_getpagesize() when temporarily setting decoder size to 2 pages.
src/coreclr/inc/loaderheap.h	Updates stub code page sizing logic to use minipal_getpagesize().
src/coreclr/debug/di/shimlocaldatatarget.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/debug/daccess/enummem.cpp	Uses minipal_getpagesize() for page-chunked memory reporting.

[Copilot]

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated no new comments.

[tannergooding]

Windows: inline constant 4096 (no syscall)

Pretty sure this is not a guarantee of Windows. You are expected to call GetSystemInfo() and read the dwPageSize property. https://devblogs.microsoft.com/oldnewthing/20210510-00/?p=105200 notably goes over some processors that deviate and where Windows has attempted deviations in the past.

I would rather expect that this also makes no difference as to perf for the GC. While we cannot know the page size for certain, we can know that it should only ever be a power of 2 and so we can manually optimize the divisions or modulus ourselves via an unsigned right shift -or- simple bitmasking. -- When we query on startup simply cache the log2(pageSize) and then right shift by it for any latter division.

Many other OS are trending towards to larger page sizes on Arm64 (often 16KB) even, particularly for servers, and I wouldn't be surprised if that changes for Windows as well.

[pavelsavara]

You are expected to call GetSystemInfo() and read the dwPageSize property.

Done

[Copilot]

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.

[jkotas]

Pretty sure this is not a guarantee of Windows.

It is guaranteed on Windows in practice. Every other piece of software for Windows (including many places in Windows itself) has 4kB page size hardcoded somewhere. In case they figure out how to change the page size, it will be an opt-in. We can update this and other places where we depend on the page size indirectly as part of opt-in.

Many other OS are trending towards to larger page sizes on Arm64 (often 16KB) even, particularly for servers

There are also equivalent features being built into the hardware that merge the adjacent page entries into a single TLB cache entry. It provides most of the benefit of large page sizes without breaking software compatibility.

[Copilot]

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.

[jkotas]

Thanks

[am11]

nit: standard C11 version

[Copilot]

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.

[pavelsavara]

/ba-g unrelated CI issues

[pavelsavara]

/ba-g first ba-g didn't work

[pavelsavara]

/ba-g second ba-g didn't work

[pavelsavara]

/ba-g third ba-g didn't work

[pavelsavara]

/ba-g 4th ba-g didn't work

[pavelsavara]

Fixes#127550

Summary

Remove the GetOsPageSize() wrapper from utilcode and replace all call sites in CoreCLR with the new minipal_getpagesize() API introduced in #127328.

Motivation

PR #127328 introduced minipal_getpagesize() in src/native/minipal/ospagesize.h as the canonical way to query the OS page size across all platforms:

• Windows: inline constant 4096 (no syscall)
• WASM: inline constant 16384 (reduced from the 64KB memory.grow granularity)
• Unix: cached getpagesize() result (queried once per process)

The old GetOsPageSize() in src/coreclr/utilcode/util.cpp duplicated this logic with slightly different behavior (used GetSystemInfo().dwAllocationGranularity on the PAL path, hardcoded 0x1000 on Windows). Consolidating on the minipal version eliminates the duplication and ensures consistent page-size semantics, particularly for WASM where the correct value is 16KB.

Changes

minipal_getpagesize() API

• Return type changed from size_t to uint32_t so the value matches the natural width used by call sites and avoids (uint32_t) casts at every use.
• Windows and WASM remain inline compile-time constants (the GC requires this to fold into a constant for alignment math).

CoreCLR consumers

• RemovedGetOsPageSize() and GetOsPageSizeUncached() definitions from src/coreclr/utilcode/util.cpp
• RemovedGetOsPageSize() declaration from src/coreclr/inc/utilcode.h
• Added#include <minipal/ospagesize.h> to utilcode.h (covers all VM/utilcode consumers) and to the two PAL test files that don't include utilcode.h
• Replaced all GetOsPageSize() call sites with minipal_getpagesize()
• Removed redundant (uint32_t) and (ptrdiff_t) casts at call sites now that minipal_getpagesize() returns uint32_t
• FixedHARD_GUARD_REGION_SIZE being defined twice in threads.h (removed the redundant first definition)
• FixedSIZEOF_DEFAULT_STACK_GUARANTEE and HARD_GUARD_REGION_SIZE macro hygiene (wrapped in outer parentheses, removed pointless 1 * multiplier)
• AdjustedROUND_DOWN_TO_PAGE/ROUND_UP_TO_PAGE in codeman.h to widen the page size to size_t before the bit-NOT mask, avoiding MSVC C4319 (zero-extending uint32_t to size_t)

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR standardizes CoreCLR’s “OS page size” queries by removing the utilcode GetOsPageSize() wrapper and migrating call sites to the canonical minipal_getpagesize() API (including updating a few page-size-related macros and PAL tests). This helps ensure consistent semantics across platforms (notably WASM’s 16KB page size behavior).

Changes:

• Removed GetOsPageSize() / GetOsPageSizeUncached() from utilcode and updated all CoreCLR call sites to use minipal_getpagesize().
• Added/propagated minipal/ospagesize.h inclusion (via utilcode.h and directly in a couple PAL tests).
• Cleaned up some page-size-related macro definitions (duplicate define removal + extra parentheses).

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/native/managed/cdac/tests/PrecodeStubsTests.cs	Updates embedded native-code comment to reflect minipal_getpagesize().
src/coreclr/vm/virtualcallstub.cpp	Uses minipal_getpagesize() for reserve/commit alignment and page computations.
src/coreclr/vm/threads.h	Replaces page-size macros with minipal_getpagesize() and removes duplicate define.
src/coreclr/vm/threads.cpp	Replaces page-size uses in asserts/debug logging/guard-page math with minipal_getpagesize().
src/coreclr/vm/peimagelayout.cpp	Uses minipal_getpagesize() for mapping alignment and validation.
src/coreclr/vm/loaderallocator.cpp	Uses minipal_getpagesize() for collectible heap sizing constants.
src/coreclr/vm/jitinterface.h	Updates UNIX null-check offset definition to use minipal_getpagesize().
src/coreclr/vm/jitinterface.cpp	Reports osPageSize via minipal_getpagesize() in EE info.
src/coreclr/vm/i386/jitinterfacex86.cpp	Updates debug asserts to use minipal_getpagesize().
src/coreclr/vm/hosting.cpp	Updates UEF section page calculations to use minipal_getpagesize().
src/coreclr/vm/frames.cpp	Updates “frame order” relaxation logic to use minipal_getpagesize().
src/coreclr/vm/excep.h	Uses minipal_getpagesize() for NULL_AREA_SIZE on UNIX.
src/coreclr/vm/debughelp.cpp	Uses minipal_getpagesize() when walking/touching pages for readability checks.
src/coreclr/vm/codeman.h	Updates rounding-to-page macros and comments to use minipal_getpagesize().
src/coreclr/vm/ceemain.cpp	Aligns mini-metadata buffer sizing using minipal_getpagesize().
src/coreclr/vm/appdomain.hpp	Updates loader heap reserve/commit sizing macros to use minipal_getpagesize().
src/coreclr/utilcode/util.cpp	Removes the old GetOsPageSize* implementations.
src/coreclr/utilcode/loaderheap.cpp	Uses minipal_getpagesize() for commit sizing alignment.
src/coreclr/utilcode/interleavedloaderheap.cpp	Uses minipal_getpagesize() for alignment/assertions.
src/coreclr/utilcode/explicitcontrolloaderheap.cpp	Uses minipal_getpagesize() for commit block sizing and alignment.
src/coreclr/utilcode/executableallocator.cpp	Uses minipal_getpagesize() when randomizing preferred range start.
src/coreclr/utilcode/dacutil.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/utilcode/clrhost_nodependencies.cpp	Uses minipal_getpagesize() for page-aligned region checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test3/test3.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test2/test2.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/inc/utilcode.h	Includes minipal/ospagesize.h and removes GetOsPageSize() declaration.
src/coreclr/inc/pedecoder.inl	Uses minipal_getpagesize() when temporarily setting decoder size to 2 pages.
src/coreclr/inc/loaderheap.h	Updates stub code page sizing logic to use minipal_getpagesize().
src/coreclr/debug/di/shimlocaldatatarget.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/debug/daccess/enummem.cpp	Uses minipal_getpagesize() for page-chunked memory reporting.

[Copilot]

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated no new comments.

[tannergooding]

Windows: inline constant 4096 (no syscall)

Pretty sure this is not a guarantee of Windows. You are expected to call GetSystemInfo() and read the dwPageSize property. https://devblogs.microsoft.com/oldnewthing/20210510-00/?p=105200 notably goes over some processors that deviate and where Windows has attempted deviations in the past.

I would rather expect that this also makes no difference as to perf for the GC. While we cannot know the page size for certain, we can know that it should only ever be a power of 2 and so we can manually optimize the divisions or modulus ourselves via an unsigned right shift -or- simple bitmasking. -- When we query on startup simply cache the log2(pageSize) and then right shift by it for any latter division.

Many other OS are trending towards to larger page sizes on Arm64 (often 16KB) even, particularly for servers, and I wouldn't be surprised if that changes for Windows as well.

[pavelsavara]

You are expected to call GetSystemInfo() and read the dwPageSize property.

Done

[Copilot]

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.

[jkotas]

Pretty sure this is not a guarantee of Windows.

It is guaranteed on Windows in practice. Every other piece of software for Windows (including many places in Windows itself) has 4kB page size hardcoded somewhere. In case they figure out how to change the page size, it will be an opt-in. We can update this and other places where we depend on the page size indirectly as part of opt-in.

Many other OS are trending towards to larger page sizes on Arm64 (often 16KB) even, particularly for servers

There are also equivalent features being built into the hardware that merge the adjacent page entries into a single TLB cache entry. It provides most of the benefit of large page sizes without breaking software compatibility.

[Copilot]

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.

[jkotas]

Thanks

[am11]

nit: standard C11 version

[Copilot]

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.

[pavelsavara]

/ba-g unrelated CI issues

[pavelsavara]

/ba-g first ba-g didn't work

[pavelsavara]

/ba-g second ba-g didn't work

[pavelsavara]

/ba-g third ba-g didn't work

[pavelsavara]

/ba-g 4th ba-g didn't work

[pavelsavara]

Fixes#127550

Summary

Remove the GetOsPageSize() wrapper from utilcode and replace all call sites in CoreCLR with the new minipal_getpagesize() API introduced in #127328.

Motivation

PR #127328 introduced minipal_getpagesize() in src/native/minipal/ospagesize.h as the canonical way to query the OS page size across all platforms:

• Windows: inline constant 4096 (no syscall)
• WASM: inline constant 16384 (reduced from the 64KB memory.grow granularity)
• Unix: cached getpagesize() result (queried once per process)

The old GetOsPageSize() in src/coreclr/utilcode/util.cpp duplicated this logic with slightly different behavior (used GetSystemInfo().dwAllocationGranularity on the PAL path, hardcoded 0x1000 on Windows). Consolidating on the minipal version eliminates the duplication and ensures consistent page-size semantics, particularly for WASM where the correct value is 16KB.

Changes

minipal_getpagesize() API

• Return type changed from size_t to uint32_t so the value matches the natural width used by call sites and avoids (uint32_t) casts at every use.
• Windows and WASM remain inline compile-time constants (the GC requires this to fold into a constant for alignment math).

CoreCLR consumers

• RemovedGetOsPageSize() and GetOsPageSizeUncached() definitions from src/coreclr/utilcode/util.cpp
• RemovedGetOsPageSize() declaration from src/coreclr/inc/utilcode.h
• Added#include <minipal/ospagesize.h> to utilcode.h (covers all VM/utilcode consumers) and to the two PAL test files that don't include utilcode.h
• Replaced all GetOsPageSize() call sites with minipal_getpagesize()
• Removed redundant (uint32_t) and (ptrdiff_t) casts at call sites now that minipal_getpagesize() returns uint32_t
• FixedHARD_GUARD_REGION_SIZE being defined twice in threads.h (removed the redundant first definition)
• FixedSIZEOF_DEFAULT_STACK_GUARANTEE and HARD_GUARD_REGION_SIZE macro hygiene (wrapped in outer parentheses, removed pointless 1 * multiplier)
• AdjustedROUND_DOWN_TO_PAGE/ROUND_UP_TO_PAGE in codeman.h to widen the page size to size_t before the bit-NOT mask, avoiding MSVC C4319 (zero-extending uint32_t to size_t)

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR standardizes CoreCLR’s “OS page size” queries by removing the utilcode GetOsPageSize() wrapper and migrating call sites to the canonical minipal_getpagesize() API (including updating a few page-size-related macros and PAL tests). This helps ensure consistent semantics across platforms (notably WASM’s 16KB page size behavior).

Changes:

• Removed GetOsPageSize() / GetOsPageSizeUncached() from utilcode and updated all CoreCLR call sites to use minipal_getpagesize().
• Added/propagated minipal/ospagesize.h inclusion (via utilcode.h and directly in a couple PAL tests).
• Cleaned up some page-size-related macro definitions (duplicate define removal + extra parentheses).

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/native/managed/cdac/tests/PrecodeStubsTests.cs	Updates embedded native-code comment to reflect minipal_getpagesize().
src/coreclr/vm/virtualcallstub.cpp	Uses minipal_getpagesize() for reserve/commit alignment and page computations.
src/coreclr/vm/threads.h	Replaces page-size macros with minipal_getpagesize() and removes duplicate define.
src/coreclr/vm/threads.cpp	Replaces page-size uses in asserts/debug logging/guard-page math with minipal_getpagesize().
src/coreclr/vm/peimagelayout.cpp	Uses minipal_getpagesize() for mapping alignment and validation.
src/coreclr/vm/loaderallocator.cpp	Uses minipal_getpagesize() for collectible heap sizing constants.
src/coreclr/vm/jitinterface.h	Updates UNIX null-check offset definition to use minipal_getpagesize().
src/coreclr/vm/jitinterface.cpp	Reports osPageSize via minipal_getpagesize() in EE info.
src/coreclr/vm/i386/jitinterfacex86.cpp	Updates debug asserts to use minipal_getpagesize().
src/coreclr/vm/hosting.cpp	Updates UEF section page calculations to use minipal_getpagesize().
src/coreclr/vm/frames.cpp	Updates “frame order” relaxation logic to use minipal_getpagesize().
src/coreclr/vm/excep.h	Uses minipal_getpagesize() for NULL_AREA_SIZE on UNIX.
src/coreclr/vm/debughelp.cpp	Uses minipal_getpagesize() when walking/touching pages for readability checks.
src/coreclr/vm/codeman.h	Updates rounding-to-page macros and comments to use minipal_getpagesize().
src/coreclr/vm/ceemain.cpp	Aligns mini-metadata buffer sizing using minipal_getpagesize().
src/coreclr/vm/appdomain.hpp	Updates loader heap reserve/commit sizing macros to use minipal_getpagesize().
src/coreclr/utilcode/util.cpp	Removes the old GetOsPageSize* implementations.
src/coreclr/utilcode/loaderheap.cpp	Uses minipal_getpagesize() for commit sizing alignment.
src/coreclr/utilcode/interleavedloaderheap.cpp	Uses minipal_getpagesize() for alignment/assertions.
src/coreclr/utilcode/explicitcontrolloaderheap.cpp	Uses minipal_getpagesize() for commit block sizing and alignment.
src/coreclr/utilcode/executableallocator.cpp	Uses minipal_getpagesize() when randomizing preferred range start.
src/coreclr/utilcode/dacutil.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/utilcode/clrhost_nodependencies.cpp	Uses minipal_getpagesize() for page-aligned region checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test3/test3.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test2/test2.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/inc/utilcode.h	Includes minipal/ospagesize.h and removes GetOsPageSize() declaration.
src/coreclr/inc/pedecoder.inl	Uses minipal_getpagesize() when temporarily setting decoder size to 2 pages.
src/coreclr/inc/loaderheap.h	Updates stub code page sizing logic to use minipal_getpagesize().
src/coreclr/debug/di/shimlocaldatatarget.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/debug/daccess/enummem.cpp	Uses minipal_getpagesize() for page-chunked memory reporting.

[Copilot]

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated no new comments.

[tannergooding]

Windows: inline constant 4096 (no syscall)

Pretty sure this is not a guarantee of Windows. You are expected to call GetSystemInfo() and read the dwPageSize property. https://devblogs.microsoft.com/oldnewthing/20210510-00/?p=105200 notably goes over some processors that deviate and where Windows has attempted deviations in the past.

I would rather expect that this also makes no difference as to perf for the GC. While we cannot know the page size for certain, we can know that it should only ever be a power of 2 and so we can manually optimize the divisions or modulus ourselves via an unsigned right shift -or- simple bitmasking. -- When we query on startup simply cache the log2(pageSize) and then right shift by it for any latter division.

Many other OS are trending towards to larger page sizes on Arm64 (often 16KB) even, particularly for servers, and I wouldn't be surprised if that changes for Windows as well.

[pavelsavara]

You are expected to call GetSystemInfo() and read the dwPageSize property.

Done

[Copilot]

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.

[jkotas]

Pretty sure this is not a guarantee of Windows.

It is guaranteed on Windows in practice. Every other piece of software for Windows (including many places in Windows itself) has 4kB page size hardcoded somewhere. In case they figure out how to change the page size, it will be an opt-in. We can update this and other places where we depend on the page size indirectly as part of opt-in.

Many other OS are trending towards to larger page sizes on Arm64 (often 16KB) even, particularly for servers

There are also equivalent features being built into the hardware that merge the adjacent page entries into a single TLB cache entry. It provides most of the benefit of large page sizes without breaking software compatibility.

[Copilot]

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.

[jkotas]

Thanks

[am11]

nit: standard C11 version

[Copilot]

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.

[pavelsavara]

/ba-g unrelated CI issues

[pavelsavara]

/ba-g first ba-g didn't work

[pavelsavara]

/ba-g second ba-g didn't work

[pavelsavara]

/ba-g third ba-g didn't work

[pavelsavara]

/ba-g 4th ba-g didn't work

[pavelsavara]

Fixes#127550

Summary

Remove the GetOsPageSize() wrapper from utilcode and replace all call sites in CoreCLR with the new minipal_getpagesize() API introduced in #127328.

Motivation

PR #127328 introduced minipal_getpagesize() in src/native/minipal/ospagesize.h as the canonical way to query the OS page size across all platforms:

• Windows: inline constant 4096 (no syscall)
• WASM: inline constant 16384 (reduced from the 64KB memory.grow granularity)
• Unix: cached getpagesize() result (queried once per process)

The old GetOsPageSize() in src/coreclr/utilcode/util.cpp duplicated this logic with slightly different behavior (used GetSystemInfo().dwAllocationGranularity on the PAL path, hardcoded 0x1000 on Windows). Consolidating on the minipal version eliminates the duplication and ensures consistent page-size semantics, particularly for WASM where the correct value is 16KB.

Changes

minipal_getpagesize() API

• Return type changed from size_t to uint32_t so the value matches the natural width used by call sites and avoids (uint32_t) casts at every use.
• Windows and WASM remain inline compile-time constants (the GC requires this to fold into a constant for alignment math).

CoreCLR consumers

• RemovedGetOsPageSize() and GetOsPageSizeUncached() definitions from src/coreclr/utilcode/util.cpp
• RemovedGetOsPageSize() declaration from src/coreclr/inc/utilcode.h
• Added#include <minipal/ospagesize.h> to utilcode.h (covers all VM/utilcode consumers) and to the two PAL test files that don't include utilcode.h
• Replaced all GetOsPageSize() call sites with minipal_getpagesize()
• Removed redundant (uint32_t) and (ptrdiff_t) casts at call sites now that minipal_getpagesize() returns uint32_t
• FixedHARD_GUARD_REGION_SIZE being defined twice in threads.h (removed the redundant first definition)
• FixedSIZEOF_DEFAULT_STACK_GUARANTEE and HARD_GUARD_REGION_SIZE macro hygiene (wrapped in outer parentheses, removed pointless 1 * multiplier)
• AdjustedROUND_DOWN_TO_PAGE/ROUND_UP_TO_PAGE in codeman.h to widen the page size to size_t before the bit-NOT mask, avoiding MSVC C4319 (zero-extending uint32_t to size_t)

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR standardizes CoreCLR’s “OS page size” queries by removing the utilcode GetOsPageSize() wrapper and migrating call sites to the canonical minipal_getpagesize() API (including updating a few page-size-related macros and PAL tests). This helps ensure consistent semantics across platforms (notably WASM’s 16KB page size behavior).

Changes:

• Removed GetOsPageSize() / GetOsPageSizeUncached() from utilcode and updated all CoreCLR call sites to use minipal_getpagesize().
• Added/propagated minipal/ospagesize.h inclusion (via utilcode.h and directly in a couple PAL tests).
• Cleaned up some page-size-related macro definitions (duplicate define removal + extra parentheses).

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/native/managed/cdac/tests/PrecodeStubsTests.cs	Updates embedded native-code comment to reflect minipal_getpagesize().
src/coreclr/vm/virtualcallstub.cpp	Uses minipal_getpagesize() for reserve/commit alignment and page computations.
src/coreclr/vm/threads.h	Replaces page-size macros with minipal_getpagesize() and removes duplicate define.
src/coreclr/vm/threads.cpp	Replaces page-size uses in asserts/debug logging/guard-page math with minipal_getpagesize().
src/coreclr/vm/peimagelayout.cpp	Uses minipal_getpagesize() for mapping alignment and validation.
src/coreclr/vm/loaderallocator.cpp	Uses minipal_getpagesize() for collectible heap sizing constants.
src/coreclr/vm/jitinterface.h	Updates UNIX null-check offset definition to use minipal_getpagesize().
src/coreclr/vm/jitinterface.cpp	Reports osPageSize via minipal_getpagesize() in EE info.
src/coreclr/vm/i386/jitinterfacex86.cpp	Updates debug asserts to use minipal_getpagesize().
src/coreclr/vm/hosting.cpp	Updates UEF section page calculations to use minipal_getpagesize().
src/coreclr/vm/frames.cpp	Updates “frame order” relaxation logic to use minipal_getpagesize().
src/coreclr/vm/excep.h	Uses minipal_getpagesize() for NULL_AREA_SIZE on UNIX.
src/coreclr/vm/debughelp.cpp	Uses minipal_getpagesize() when walking/touching pages for readability checks.
src/coreclr/vm/codeman.h	Updates rounding-to-page macros and comments to use minipal_getpagesize().
src/coreclr/vm/ceemain.cpp	Aligns mini-metadata buffer sizing using minipal_getpagesize().
src/coreclr/vm/appdomain.hpp	Updates loader heap reserve/commit sizing macros to use minipal_getpagesize().
src/coreclr/utilcode/util.cpp	Removes the old GetOsPageSize* implementations.
src/coreclr/utilcode/loaderheap.cpp	Uses minipal_getpagesize() for commit sizing alignment.
src/coreclr/utilcode/interleavedloaderheap.cpp	Uses minipal_getpagesize() for alignment/assertions.
src/coreclr/utilcode/explicitcontrolloaderheap.cpp	Uses minipal_getpagesize() for commit block sizing and alignment.
src/coreclr/utilcode/executableallocator.cpp	Uses minipal_getpagesize() when randomizing preferred range start.
src/coreclr/utilcode/dacutil.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/utilcode/clrhost_nodependencies.cpp	Uses minipal_getpagesize() for page-aligned region checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test3/test3.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test2/test2.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/inc/utilcode.h	Includes minipal/ospagesize.h and removes GetOsPageSize() declaration.
src/coreclr/inc/pedecoder.inl	Uses minipal_getpagesize() when temporarily setting decoder size to 2 pages.
src/coreclr/inc/loaderheap.h	Updates stub code page sizing logic to use minipal_getpagesize().
src/coreclr/debug/di/shimlocaldatatarget.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/debug/daccess/enummem.cpp	Uses minipal_getpagesize() for page-chunked memory reporting.

[Copilot]

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated no new comments.

[tannergooding]

Windows: inline constant 4096 (no syscall)

Pretty sure this is not a guarantee of Windows. You are expected to call GetSystemInfo() and read the dwPageSize property. https://devblogs.microsoft.com/oldnewthing/20210510-00/?p=105200 notably goes over some processors that deviate and where Windows has attempted deviations in the past.

I would rather expect that this also makes no difference as to perf for the GC. While we cannot know the page size for certain, we can know that it should only ever be a power of 2 and so we can manually optimize the divisions or modulus ourselves via an unsigned right shift -or- simple bitmasking. -- When we query on startup simply cache the log2(pageSize) and then right shift by it for any latter division.

Many other OS are trending towards to larger page sizes on Arm64 (often 16KB) even, particularly for servers, and I wouldn't be surprised if that changes for Windows as well.

[pavelsavara]

You are expected to call GetSystemInfo() and read the dwPageSize property.

Done

[Copilot]

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.

[jkotas]

Pretty sure this is not a guarantee of Windows.

It is guaranteed on Windows in practice. Every other piece of software for Windows (including many places in Windows itself) has 4kB page size hardcoded somewhere. In case they figure out how to change the page size, it will be an opt-in. We can update this and other places where we depend on the page size indirectly as part of opt-in.

Many other OS are trending towards to larger page sizes on Arm64 (often 16KB) even, particularly for servers

There are also equivalent features being built into the hardware that merge the adjacent page entries into a single TLB cache entry. It provides most of the benefit of large page sizes without breaking software compatibility.

[Copilot]

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.

[jkotas]

Thanks

[am11]

nit: standard C11 version

[Copilot]

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.

[pavelsavara]

/ba-g unrelated CI issues

[pavelsavara]

/ba-g first ba-g didn't work

[pavelsavara]

/ba-g second ba-g didn't work

[pavelsavara]

/ba-g third ba-g didn't work

[pavelsavara]

/ba-g 4th ba-g didn't work

[pavelsavara]

Fixes#127550

Summary

Remove the GetOsPageSize() wrapper from utilcode and replace all call sites in CoreCLR with the new minipal_getpagesize() API introduced in #127328.

Motivation

PR #127328 introduced minipal_getpagesize() in src/native/minipal/ospagesize.h as the canonical way to query the OS page size across all platforms:

• Windows: inline constant 4096 (no syscall)
• WASM: inline constant 16384 (reduced from the 64KB memory.grow granularity)
• Unix: cached getpagesize() result (queried once per process)

The old GetOsPageSize() in src/coreclr/utilcode/util.cpp duplicated this logic with slightly different behavior (used GetSystemInfo().dwAllocationGranularity on the PAL path, hardcoded 0x1000 on Windows). Consolidating on the minipal version eliminates the duplication and ensures consistent page-size semantics, particularly for WASM where the correct value is 16KB.

Changes

minipal_getpagesize() API

• Return type changed from size_t to uint32_t so the value matches the natural width used by call sites and avoids (uint32_t) casts at every use.
• Windows and WASM remain inline compile-time constants (the GC requires this to fold into a constant for alignment math).

CoreCLR consumers

• RemovedGetOsPageSize() and GetOsPageSizeUncached() definitions from src/coreclr/utilcode/util.cpp
• RemovedGetOsPageSize() declaration from src/coreclr/inc/utilcode.h
• Added#include <minipal/ospagesize.h> to utilcode.h (covers all VM/utilcode consumers) and to the two PAL test files that don't include utilcode.h
• Replaced all GetOsPageSize() call sites with minipal_getpagesize()
• Removed redundant (uint32_t) and (ptrdiff_t) casts at call sites now that minipal_getpagesize() returns uint32_t
• FixedHARD_GUARD_REGION_SIZE being defined twice in threads.h (removed the redundant first definition)
• FixedSIZEOF_DEFAULT_STACK_GUARANTEE and HARD_GUARD_REGION_SIZE macro hygiene (wrapped in outer parentheses, removed pointless 1 * multiplier)
• AdjustedROUND_DOWN_TO_PAGE/ROUND_UP_TO_PAGE in codeman.h to widen the page size to size_t before the bit-NOT mask, avoiding MSVC C4319 (zero-extending uint32_t to size_t)

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR standardizes CoreCLR’s “OS page size” queries by removing the utilcode GetOsPageSize() wrapper and migrating call sites to the canonical minipal_getpagesize() API (including updating a few page-size-related macros and PAL tests). This helps ensure consistent semantics across platforms (notably WASM’s 16KB page size behavior).

Changes:

• Removed GetOsPageSize() / GetOsPageSizeUncached() from utilcode and updated all CoreCLR call sites to use minipal_getpagesize().
• Added/propagated minipal/ospagesize.h inclusion (via utilcode.h and directly in a couple PAL tests).
• Cleaned up some page-size-related macro definitions (duplicate define removal + extra parentheses).

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/native/managed/cdac/tests/PrecodeStubsTests.cs	Updates embedded native-code comment to reflect minipal_getpagesize().
src/coreclr/vm/virtualcallstub.cpp	Uses minipal_getpagesize() for reserve/commit alignment and page computations.
src/coreclr/vm/threads.h	Replaces page-size macros with minipal_getpagesize() and removes duplicate define.
src/coreclr/vm/threads.cpp	Replaces page-size uses in asserts/debug logging/guard-page math with minipal_getpagesize().
src/coreclr/vm/peimagelayout.cpp	Uses minipal_getpagesize() for mapping alignment and validation.
src/coreclr/vm/loaderallocator.cpp	Uses minipal_getpagesize() for collectible heap sizing constants.
src/coreclr/vm/jitinterface.h	Updates UNIX null-check offset definition to use minipal_getpagesize().
src/coreclr/vm/jitinterface.cpp	Reports osPageSize via minipal_getpagesize() in EE info.
src/coreclr/vm/i386/jitinterfacex86.cpp	Updates debug asserts to use minipal_getpagesize().
src/coreclr/vm/hosting.cpp	Updates UEF section page calculations to use minipal_getpagesize().
src/coreclr/vm/frames.cpp	Updates “frame order” relaxation logic to use minipal_getpagesize().
src/coreclr/vm/excep.h	Uses minipal_getpagesize() for NULL_AREA_SIZE on UNIX.
src/coreclr/vm/debughelp.cpp	Uses minipal_getpagesize() when walking/touching pages for readability checks.
src/coreclr/vm/codeman.h	Updates rounding-to-page macros and comments to use minipal_getpagesize().
src/coreclr/vm/ceemain.cpp	Aligns mini-metadata buffer sizing using minipal_getpagesize().
src/coreclr/vm/appdomain.hpp	Updates loader heap reserve/commit sizing macros to use minipal_getpagesize().
src/coreclr/utilcode/util.cpp	Removes the old GetOsPageSize* implementations.
src/coreclr/utilcode/loaderheap.cpp	Uses minipal_getpagesize() for commit sizing alignment.
src/coreclr/utilcode/interleavedloaderheap.cpp	Uses minipal_getpagesize() for alignment/assertions.
src/coreclr/utilcode/explicitcontrolloaderheap.cpp	Uses minipal_getpagesize() for commit block sizing and alignment.
src/coreclr/utilcode/executableallocator.cpp	Uses minipal_getpagesize() when randomizing preferred range start.
src/coreclr/utilcode/dacutil.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/utilcode/clrhost_nodependencies.cpp	Uses minipal_getpagesize() for page-aligned region checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test3/test3.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test2/test2.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/inc/utilcode.h	Includes minipal/ospagesize.h and removes GetOsPageSize() declaration.
src/coreclr/inc/pedecoder.inl	Uses minipal_getpagesize() when temporarily setting decoder size to 2 pages.
src/coreclr/inc/loaderheap.h	Updates stub code page sizing logic to use minipal_getpagesize().
src/coreclr/debug/di/shimlocaldatatarget.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/debug/daccess/enummem.cpp	Uses minipal_getpagesize() for page-chunked memory reporting.

[Copilot]

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated no new comments.

[tannergooding]

Windows: inline constant 4096 (no syscall)

Pretty sure this is not a guarantee of Windows. You are expected to call GetSystemInfo() and read the dwPageSize property. https://devblogs.microsoft.com/oldnewthing/20210510-00/?p=105200 notably goes over some processors that deviate and where Windows has attempted deviations in the past.

I would rather expect that this also makes no difference as to perf for the GC. While we cannot know the page size for certain, we can know that it should only ever be a power of 2 and so we can manually optimize the divisions or modulus ourselves via an unsigned right shift -or- simple bitmasking. -- When we query on startup simply cache the log2(pageSize) and then right shift by it for any latter division.

Many other OS are trending towards to larger page sizes on Arm64 (often 16KB) even, particularly for servers, and I wouldn't be surprised if that changes for Windows as well.

[pavelsavara]

You are expected to call GetSystemInfo() and read the dwPageSize property.

Done

[Copilot]

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.

[jkotas]

Pretty sure this is not a guarantee of Windows.

It is guaranteed on Windows in practice. Every other piece of software for Windows (including many places in Windows itself) has 4kB page size hardcoded somewhere. In case they figure out how to change the page size, it will be an opt-in. We can update this and other places where we depend on the page size indirectly as part of opt-in.

Many other OS are trending towards to larger page sizes on Arm64 (often 16KB) even, particularly for servers

There are also equivalent features being built into the hardware that merge the adjacent page entries into a single TLB cache entry. It provides most of the benefit of large page sizes without breaking software compatibility.

[Copilot]

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.

[jkotas]

Thanks

[am11]

nit: standard C11 version

[Copilot]

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.

[pavelsavara]

/ba-g unrelated CI issues

[pavelsavara]

/ba-g first ba-g didn't work

[pavelsavara]

/ba-g second ba-g didn't work

[pavelsavara]

/ba-g third ba-g didn't work

[pavelsavara]

/ba-g 4th ba-g didn't work

[pavelsavara]

Fixes#127550

Summary

Remove the GetOsPageSize() wrapper from utilcode and replace all call sites in CoreCLR with the new minipal_getpagesize() API introduced in #127328.

Motivation

PR #127328 introduced minipal_getpagesize() in src/native/minipal/ospagesize.h as the canonical way to query the OS page size across all platforms:

• Windows: inline constant 4096 (no syscall)
• WASM: inline constant 16384 (reduced from the 64KB memory.grow granularity)
• Unix: cached getpagesize() result (queried once per process)

The old GetOsPageSize() in src/coreclr/utilcode/util.cpp duplicated this logic with slightly different behavior (used GetSystemInfo().dwAllocationGranularity on the PAL path, hardcoded 0x1000 on Windows). Consolidating on the minipal version eliminates the duplication and ensures consistent page-size semantics, particularly for WASM where the correct value is 16KB.

Changes

minipal_getpagesize() API

• Return type changed from size_t to uint32_t so the value matches the natural width used by call sites and avoids (uint32_t) casts at every use.
• Windows and WASM remain inline compile-time constants (the GC requires this to fold into a constant for alignment math).

CoreCLR consumers

• RemovedGetOsPageSize() and GetOsPageSizeUncached() definitions from src/coreclr/utilcode/util.cpp
• RemovedGetOsPageSize() declaration from src/coreclr/inc/utilcode.h
• Added#include <minipal/ospagesize.h> to utilcode.h (covers all VM/utilcode consumers) and to the two PAL test files that don't include utilcode.h
• Replaced all GetOsPageSize() call sites with minipal_getpagesize()
• Removed redundant (uint32_t) and (ptrdiff_t) casts at call sites now that minipal_getpagesize() returns uint32_t
• FixedHARD_GUARD_REGION_SIZE being defined twice in threads.h (removed the redundant first definition)
• FixedSIZEOF_DEFAULT_STACK_GUARANTEE and HARD_GUARD_REGION_SIZE macro hygiene (wrapped in outer parentheses, removed pointless 1 * multiplier)
• AdjustedROUND_DOWN_TO_PAGE/ROUND_UP_TO_PAGE in codeman.h to widen the page size to size_t before the bit-NOT mask, avoiding MSVC C4319 (zero-extending uint32_t to size_t)

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR standardizes CoreCLR’s “OS page size” queries by removing the utilcode GetOsPageSize() wrapper and migrating call sites to the canonical minipal_getpagesize() API (including updating a few page-size-related macros and PAL tests). This helps ensure consistent semantics across platforms (notably WASM’s 16KB page size behavior).

Changes:

• Removed GetOsPageSize() / GetOsPageSizeUncached() from utilcode and updated all CoreCLR call sites to use minipal_getpagesize().
• Added/propagated minipal/ospagesize.h inclusion (via utilcode.h and directly in a couple PAL tests).
• Cleaned up some page-size-related macro definitions (duplicate define removal + extra parentheses).

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/native/managed/cdac/tests/PrecodeStubsTests.cs	Updates embedded native-code comment to reflect minipal_getpagesize().
src/coreclr/vm/virtualcallstub.cpp	Uses minipal_getpagesize() for reserve/commit alignment and page computations.
src/coreclr/vm/threads.h	Replaces page-size macros with minipal_getpagesize() and removes duplicate define.
src/coreclr/vm/threads.cpp	Replaces page-size uses in asserts/debug logging/guard-page math with minipal_getpagesize().
src/coreclr/vm/peimagelayout.cpp	Uses minipal_getpagesize() for mapping alignment and validation.
src/coreclr/vm/loaderallocator.cpp	Uses minipal_getpagesize() for collectible heap sizing constants.
src/coreclr/vm/jitinterface.h	Updates UNIX null-check offset definition to use minipal_getpagesize().
src/coreclr/vm/jitinterface.cpp	Reports osPageSize via minipal_getpagesize() in EE info.
src/coreclr/vm/i386/jitinterfacex86.cpp	Updates debug asserts to use minipal_getpagesize().
src/coreclr/vm/hosting.cpp	Updates UEF section page calculations to use minipal_getpagesize().
src/coreclr/vm/frames.cpp	Updates “frame order” relaxation logic to use minipal_getpagesize().
src/coreclr/vm/excep.h	Uses minipal_getpagesize() for NULL_AREA_SIZE on UNIX.
src/coreclr/vm/debughelp.cpp	Uses minipal_getpagesize() when walking/touching pages for readability checks.
src/coreclr/vm/codeman.h	Updates rounding-to-page macros and comments to use minipal_getpagesize().
src/coreclr/vm/ceemain.cpp	Aligns mini-metadata buffer sizing using minipal_getpagesize().
src/coreclr/vm/appdomain.hpp	Updates loader heap reserve/commit sizing macros to use minipal_getpagesize().
src/coreclr/utilcode/util.cpp	Removes the old GetOsPageSize* implementations.
src/coreclr/utilcode/loaderheap.cpp	Uses minipal_getpagesize() for commit sizing alignment.
src/coreclr/utilcode/interleavedloaderheap.cpp	Uses minipal_getpagesize() for alignment/assertions.
src/coreclr/utilcode/explicitcontrolloaderheap.cpp	Uses minipal_getpagesize() for commit block sizing and alignment.
src/coreclr/utilcode/executableallocator.cpp	Uses minipal_getpagesize() when randomizing preferred range start.
src/coreclr/utilcode/dacutil.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/utilcode/clrhost_nodependencies.cpp	Uses minipal_getpagesize() for page-aligned region checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test3/test3.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test2/test2.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/inc/utilcode.h	Includes minipal/ospagesize.h and removes GetOsPageSize() declaration.
src/coreclr/inc/pedecoder.inl	Uses minipal_getpagesize() when temporarily setting decoder size to 2 pages.
src/coreclr/inc/loaderheap.h	Updates stub code page sizing logic to use minipal_getpagesize().
src/coreclr/debug/di/shimlocaldatatarget.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/debug/daccess/enummem.cpp	Uses minipal_getpagesize() for page-chunked memory reporting.

[Copilot]

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated no new comments.

[tannergooding]

Windows: inline constant 4096 (no syscall)

Pretty sure this is not a guarantee of Windows. You are expected to call GetSystemInfo() and read the dwPageSize property. https://devblogs.microsoft.com/oldnewthing/20210510-00/?p=105200 notably goes over some processors that deviate and where Windows has attempted deviations in the past.

I would rather expect that this also makes no difference as to perf for the GC. While we cannot know the page size for certain, we can know that it should only ever be a power of 2 and so we can manually optimize the divisions or modulus ourselves via an unsigned right shift -or- simple bitmasking. -- When we query on startup simply cache the log2(pageSize) and then right shift by it for any latter division.

Many other OS are trending towards to larger page sizes on Arm64 (often 16KB) even, particularly for servers, and I wouldn't be surprised if that changes for Windows as well.

[pavelsavara]

You are expected to call GetSystemInfo() and read the dwPageSize property.

Done

[Copilot]

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.

[jkotas]

Pretty sure this is not a guarantee of Windows.

It is guaranteed on Windows in practice. Every other piece of software for Windows (including many places in Windows itself) has 4kB page size hardcoded somewhere. In case they figure out how to change the page size, it will be an opt-in. We can update this and other places where we depend on the page size indirectly as part of opt-in.

Many other OS are trending towards to larger page sizes on Arm64 (often 16KB) even, particularly for servers

There are also equivalent features being built into the hardware that merge the adjacent page entries into a single TLB cache entry. It provides most of the benefit of large page sizes without breaking software compatibility.

[Copilot]

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.

[jkotas]

Thanks

[am11]

nit: standard C11 version

[Copilot]

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.

[pavelsavara]

/ba-g unrelated CI issues

[pavelsavara]

/ba-g first ba-g didn't work

[pavelsavara]

/ba-g second ba-g didn't work

[pavelsavara]

/ba-g third ba-g didn't work

[pavelsavara]

/ba-g 4th ba-g didn't work