[cDAC] Implement DacDbi APIs TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo - #128001

Merged
rcj1 merged 11 commits into
mainfrom
copilot/implement-typehandle-to-expanded-type-info
May 19, 2026
Merged

[cDAC] Implement DacDbi APIs TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo#128001
rcj1 merged 11 commits into
mainfrom
copilot/implement-typehandle-to-expanded-type-info

Conversation

CopilotAI commented May 10, 2026•
edited by rcj1
Loading

Copy link
Copy Markdown
Contributor

After #128058 goes in the memcpy from a VMPTR will be awkward but correct. I figured it's ok that it's awkward because this is not really something we should be doing all the time.

CopilotAI requested review from Copilot and removed request for CopilotMay 10, 2026 01:09
@rcj1rcj1 changed the title [cDAC] Use little-endian writes for IPCE structs and properly type DacDbi API parameters[cDAC] Add DacDbi APIs to fill DebuggerIPCE_ExpandedTypeDataMay 10, 2026
@dotnet-policy-service

dotnet-policy-serviceBot commented May 10, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

@build-analysisbuild-analysisBot mentioned this pull request May 10, 2026
Open
3 tasks
CopilotAI review requested due to automatic review settings May 10, 2026 04:17
CopilotAI reviewed May 10, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the cDAC DacDbi surface to produce DebuggerIPCE_ExpandedTypeData for a type handle or object address, and adds a RuntimeTypeSystem contract helper for recognizing the System.Object method table (so ELEMENT_TYPE_OBJECT can be reported distinctly from ELEMENT_TYPE_CLASS).

Changes:

  • Add IRuntimeTypeSystem.IsObject(TypeHandle) and plumb a new ObjectMethodTable global through the contract + test mocks.
  • Implement TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo in the managed DacDbiImpl, including little-endian writes matching native Portable<T>.
  • Update native DBI interface/IDL and call sites to route “type id -> type info” through TypeHandleToExpandedTypeInfo, and remove GetObjectExpandedTypeInfoFromID.
Show a summary per file
FileDescription
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.RuntimeTypeSystem.csAdds a mock global for the Object method table and patches it to System.Object’s MT in the mock target.
src/native/managed/cdac/tests/MethodTableTests.csExtends contract globals and asserts IsObject behavior for FreeObject MT vs System.Object MT.
src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.csAdds dump-based assertions for IsObject across object/free/string MTs.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csIntroduces managed projections of AreValueTypesBoxed and DebuggerIPCE_*TypeData and updates method signatures to typed pointers.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csImplements TypeHandleToExpandedTypeInfo / GetObjectExpandedTypeInfo and shared filling helpers with Portable-compatible endianness.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.csReads the ObjectMethodTable global and implements IsObject.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.csAdds the new IsObject(TypeHandle) API to the public contract interface.
src/coreclr/inc/dacdbi.idlChanges TypeHandleToExpandedTypeInfo to take a raw UINT64 and drops GetObjectExpandedTypeInfoFromID.
src/coreclr/debug/inc/dacdbistructures.hGives AreValueTypesBoxed explicit values (0/1/2).
src/coreclr/debug/inc/dacdbiinterface.hUpdates the COM interface signature and removes GetObjectExpandedTypeInfoFromID.
src/coreclr/debug/di/rstype.cppUpdates RS to call the new TypeHandleToExpandedTypeInfo signature (but currently extracts the handle unsafely).
src/coreclr/debug/di/process.cppRoutes GetTypeForTypeID through TypeHandleToExpandedTypeInfo using COR_TYPEID.token1.
src/coreclr/debug/daccess/dacdbiimpl.hUpdates DAC interface declaration to match the new signature.
src/coreclr/debug/daccess/dacdbiimpl.cppRemoves the old FromID method and updates implementation/callers for the new signature + zero-inits output structs.
docs/design/datacontracts/RuntimeTypeSystem.mdDocuments IsObject and the ObjectMethodTable global (but the globals table still has an incorrect FreeObject global name).

Copilot's findings

  • Files reviewed: 15/15 changed files
  • Comments generated: 5

Comment threadsrc/coreclr/debug/di/rstype.cpp Outdated
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs Outdated
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md Outdated
This was referenced May 10, 2026
Open
Open
@rcj1
Potential fix for pull request finding
a2de94a
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings May 10, 2026 15:54
CopilotAI reviewed May 10, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 15/15 changed files
  • Comments generated: 3

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs Outdated
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/coreclr/debug/inc/dacdbiinterface.h
@rcj1
Potential fix for pull request finding
511c52b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings May 12, 2026 03:45
CopilotAI reviewed May 12, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 15/15 changed files
  • Comments generated: 3

Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
CopilotAI changed the title [cDAC] Add DacDbi APIs to fill DebuggerIPCE_ExpandedTypeDataSwitch DacDbi expanded type info APIs back to VMPTR inputsMay 12, 2026
CopilotAI requested a review from rcj1May 12, 2026 04:04
@rcj1
rcj1 marked this pull request as ready for review May 12, 2026 17:23
@rcj1
rcj1 requested review from max-charlamb and noahfalkMay 12, 2026 17:24
CopilotAI reviewed May 12, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 15/15 changed files
  • Comments generated: 3

Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/di/rstype.cpp Outdated
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
noahfalk
noahfalk reviewed May 14, 2026
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated
Comment threadsrc/coreclr/debug/inc/dacdbiinterface.h Outdated
CopilotAI review requested due to automatic review settings May 15, 2026 17:21
CopilotAI reviewed May 15, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 15/15 changed files
  • Comments generated: 1

Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated
@rcj1
Potential fix for pull request finding
2fbaf2b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings May 17, 2026 04:13
CopilotAI reviewed May 17, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 15/15 changed files
  • Comments generated: 0 new

@build-analysisbuild-analysisBot mentioned this pull request May 17, 2026
Closed
max-charlamb
max-charlamb reviewed May 18, 2026
View reviewed changes
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs Outdated
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs Outdated
@rcj1rcj1 mentioned this pull request May 18, 2026
Merged
noahfalk
noahfalk approved these changes May 18, 2026
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated
@build-analysisbuild-analysisBot mentioned this pull request May 18, 2026
Open
CopilotAI review requested due to automatic review settings May 18, 2026 22:43
CopilotAI reviewed May 18, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 15/15 changed files
  • Comments generated: 0 new

@rcj1

rcj1 commented May 19, 2026

Copy link
Copy Markdown
Contributor

/ba-g shebang analyzer issue

@rcj1
rcj1 merged commit e795eda into mainMay 19, 2026
121 of 127 checks passed
@rcj1
rcj1 deleted the copilot/implement-typehandle-to-expanded-type-info branch May 19, 2026 02:55
@dotnet-maestrodotnet-maestroBot mentioned this pull request May 20, 2026
Merged
@dotnet-milestone-botdotnet-milestone-botBot added this to the 11.0-preview6 milestone May 21, 2026
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jun 21, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@max-charlambmax-charlambmax-charlamb left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@rcj1rcj1

Copilot code reviewCopilot

Labels

area-Diagnostics-cdac

Projects

None yet

Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

5 participants

@rcj1@noahfalk@max-charlamb
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[cDAC] Implement DacDbi APIs TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo - #128001
Merged
rcj1 merged 11 commits into
mainfrom 
copilot/implement-typehandle-to-expanded-type-info
May 19, 2026
Merged
[cDAC] Implement DacDbi APIs TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo#128001
rcj1 merged 11 commits into
mainfrom 
copilot/implement-typehandle-to-expanded-type-info
Conversation
CopilotAI
commented
May 10, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
After #128058 goes in the memcpy from a VMPTR will be awkward but correct. I figured it's ok that it's awkward because this is not really something we should be doing all the time.
CopilotAI
requested review from
Copilot
and removed request for
CopilotMay 10, 2026 01:09
@rcj1rcj1
changed the title
[cDAC] Use little-endian writes for IPCE structs and properly type DacDbi API parameters[cDAC] Add DacDbi APIs to fill DebuggerIPCE_ExpandedTypeDataMay 10, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 10, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@build-analysisbuild-analysisBot
mentioned this pull request
May 10, 2026

Open

3 tasks
CopilotAI
review requested due to automatic review settings
May 10, 2026 04:17
CopilotAI
reviewed
May 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR extends the cDAC DacDbi surface to produce DebuggerIPCE_ExpandedTypeData for a type handle or object address, and adds a RuntimeTypeSystem contract helper for recognizing the System.Object method table (so ELEMENT_TYPE_OBJECT can be reported distinctly from ELEMENT_TYPE_CLASS).
Changes:
  • Add IRuntimeTypeSystem.IsObject(TypeHandle) and plumb a new ObjectMethodTable global through the contract + test mocks.
  • Implement TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo in the managed DacDbiImpl, including little-endian writes matching native Portable<T>.
  • Update native DBI interface/IDL and call sites to route “type id -> type info” through TypeHandleToExpandedTypeInfo, and remove GetObjectExpandedTypeInfoFromID.
Show a summary per file
FileDescription
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.RuntimeTypeSystem.csAdds a mock global for the Object method table and patches it to System.Object’s MT in the mock target.
src/native/managed/cdac/tests/MethodTableTests.csExtends contract globals and asserts IsObject behavior for FreeObject MT vs System.Object MT.
src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.csAdds dump-based assertions for IsObject across object/free/string MTs.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csIntroduces managed projections of AreValueTypesBoxed and DebuggerIPCE_*TypeData and updates method signatures to typed pointers.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csImplements TypeHandleToExpandedTypeInfo / GetObjectExpandedTypeInfo and shared filling helpers with Portable-compatible endianness.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.csReads the ObjectMethodTable global and implements IsObject.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.csAdds the new IsObject(TypeHandle) API to the public contract interface.
src/coreclr/inc/dacdbi.idlChanges TypeHandleToExpandedTypeInfo to take a raw UINT64 and drops GetObjectExpandedTypeInfoFromID.
src/coreclr/debug/inc/dacdbistructures.hGives AreValueTypesBoxed explicit values (0/1/2).
src/coreclr/debug/inc/dacdbiinterface.hUpdates the COM interface signature and removes GetObjectExpandedTypeInfoFromID.
src/coreclr/debug/di/rstype.cppUpdates RS to call the new TypeHandleToExpandedTypeInfo signature (but currently extracts the handle unsafely).
src/coreclr/debug/di/process.cppRoutes GetTypeForTypeID through TypeHandleToExpandedTypeInfo using COR_TYPEID.token1.
src/coreclr/debug/daccess/dacdbiimpl.hUpdates DAC interface declaration to match the new signature.
src/coreclr/debug/daccess/dacdbiimpl.cppRemoves the old FromID method and updates implementation/callers for the new signature + zero-inits output structs.
docs/design/datacontracts/RuntimeTypeSystem.mdDocuments IsObject and the ObjectMethodTable global (but the globals table still has an incorrect FreeObject global name).
Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 5
Comment threadsrc/coreclr/debug/di/rstype.cpp
Outdated

Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated


This was referenced May 10, 2026

Open


Open

@rcj1
Potential fix for pull request finding
a2de94a
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 10, 2026 15:54
CopilotAI
reviewed
May 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/coreclr/debug/inc/dacdbiinterface.h
@rcj1
Potential fix for pull request finding
511c52b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 12, 2026 03:45
CopilotAI
reviewed
May 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
CopilotAI
changed the title
[cDAC] Add DacDbi APIs to fill DebuggerIPCE_ExpandedTypeDataSwitch DacDbi expanded type info APIs back to VMPTR inputsMay 12, 2026
CopilotAI
requested a review
from rcj1May 12, 2026 04:04
@rcj1
rcj1
marked this pull request as ready for review
May 12, 2026 17:23
@rcj1
rcj1
requested review from
max-charlamb and noahfalkMay 12, 2026 17:24
CopilotAI
reviewed
May 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/di/rstype.cpp
Outdated

Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
noahfalk
noahfalk
reviewed
May 14, 2026
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

Comment threadsrc/coreclr/debug/inc/dacdbiinterface.h
Outdated

CopilotAI
review requested due to automatic review settings
May 15, 2026 17:21
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 1
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

@rcj1
Potential fix for pull request finding
2fbaf2b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 17, 2026 04:13
CopilotAI
reviewed
May 17, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
May 17, 2026

Closed

max-charlamb
max-charlamb
reviewed
May 18, 2026
View reviewed changes
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

@rcj1rcj1
mentioned this pull request
May 18, 2026
 Merged

noahfalk
noahfalk
approved these changes
May 18, 2026
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 18, 2026

Open

CopilotAI
review requested due to automatic review settings
May 18, 2026 22:43
CopilotAI
reviewed
May 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 0 new
@rcj1
rcj1
commented
May 19, 2026

Copy link


Copy Markdown

Contributor
/ba-g shebang analyzer issue
@rcj1
rcj1
merged commit e795eda
into
mainMay 19, 2026

121 of 127 checks passed

@rcj1
rcj1
deleted the

copilot/implement-typehandle-to-expanded-type-info

branch
May 19, 2026 02:55
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 20, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 21, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@max-charlambmax-charlambmax-charlamb left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

5 participants

@rcj1@noahfalk@max-charlamb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] Implement DacDbi APIs TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo - #128001
Merged
rcj1 merged 11 commits into
mainfrom 
copilot/implement-typehandle-to-expanded-type-info
May 19, 2026
Merged
[cDAC] Implement DacDbi APIs TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo#128001
rcj1 merged 11 commits into
mainfrom 
copilot/implement-typehandle-to-expanded-type-info
Conversation
CopilotAI
commented
May 10, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
After #128058 goes in the memcpy from a VMPTR will be awkward but correct. I figured it's ok that it's awkward because this is not really something we should be doing all the time.
CopilotAI
requested review from
Copilot
and removed request for
CopilotMay 10, 2026 01:09
@rcj1rcj1
changed the title
[cDAC] Use little-endian writes for IPCE structs and properly type DacDbi API parameters[cDAC] Add DacDbi APIs to fill DebuggerIPCE_ExpandedTypeDataMay 10, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 10, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@build-analysisbuild-analysisBot
mentioned this pull request
May 10, 2026

Open

3 tasks
CopilotAI
review requested due to automatic review settings
May 10, 2026 04:17
CopilotAI
reviewed
May 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR extends the cDAC DacDbi surface to produce DebuggerIPCE_ExpandedTypeData for a type handle or object address, and adds a RuntimeTypeSystem contract helper for recognizing the System.Object method table (so ELEMENT_TYPE_OBJECT can be reported distinctly from ELEMENT_TYPE_CLASS).
Changes:
  • Add IRuntimeTypeSystem.IsObject(TypeHandle) and plumb a new ObjectMethodTable global through the contract + test mocks.
  • Implement TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo in the managed DacDbiImpl, including little-endian writes matching native Portable<T>.
  • Update native DBI interface/IDL and call sites to route “type id -> type info” through TypeHandleToExpandedTypeInfo, and remove GetObjectExpandedTypeInfoFromID.
Show a summary per file
FileDescription
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.RuntimeTypeSystem.csAdds a mock global for the Object method table and patches it to System.Object’s MT in the mock target.
src/native/managed/cdac/tests/MethodTableTests.csExtends contract globals and asserts IsObject behavior for FreeObject MT vs System.Object MT.
src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.csAdds dump-based assertions for IsObject across object/free/string MTs.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csIntroduces managed projections of AreValueTypesBoxed and DebuggerIPCE_*TypeData and updates method signatures to typed pointers.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csImplements TypeHandleToExpandedTypeInfo / GetObjectExpandedTypeInfo and shared filling helpers with Portable-compatible endianness.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.csReads the ObjectMethodTable global and implements IsObject.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.csAdds the new IsObject(TypeHandle) API to the public contract interface.
src/coreclr/inc/dacdbi.idlChanges TypeHandleToExpandedTypeInfo to take a raw UINT64 and drops GetObjectExpandedTypeInfoFromID.
src/coreclr/debug/inc/dacdbistructures.hGives AreValueTypesBoxed explicit values (0/1/2).
src/coreclr/debug/inc/dacdbiinterface.hUpdates the COM interface signature and removes GetObjectExpandedTypeInfoFromID.
src/coreclr/debug/di/rstype.cppUpdates RS to call the new TypeHandleToExpandedTypeInfo signature (but currently extracts the handle unsafely).
src/coreclr/debug/di/process.cppRoutes GetTypeForTypeID through TypeHandleToExpandedTypeInfo using COR_TYPEID.token1.
src/coreclr/debug/daccess/dacdbiimpl.hUpdates DAC interface declaration to match the new signature.
src/coreclr/debug/daccess/dacdbiimpl.cppRemoves the old FromID method and updates implementation/callers for the new signature + zero-inits output structs.
docs/design/datacontracts/RuntimeTypeSystem.mdDocuments IsObject and the ObjectMethodTable global (but the globals table still has an incorrect FreeObject global name).
Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 5
Comment threadsrc/coreclr/debug/di/rstype.cpp
Outdated

Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated


This was referenced May 10, 2026

Open


Open

@rcj1
Potential fix for pull request finding
a2de94a
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 10, 2026 15:54
CopilotAI
reviewed
May 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/coreclr/debug/inc/dacdbiinterface.h
@rcj1
Potential fix for pull request finding
511c52b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 12, 2026 03:45
CopilotAI
reviewed
May 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
CopilotAI
changed the title
[cDAC] Add DacDbi APIs to fill DebuggerIPCE_ExpandedTypeDataSwitch DacDbi expanded type info APIs back to VMPTR inputsMay 12, 2026
CopilotAI
requested a review
from rcj1May 12, 2026 04:04
@rcj1
rcj1
marked this pull request as ready for review
May 12, 2026 17:23
@rcj1
rcj1
requested review from
max-charlamb and noahfalkMay 12, 2026 17:24
CopilotAI
reviewed
May 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/di/rstype.cpp
Outdated

Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
noahfalk
noahfalk
reviewed
May 14, 2026
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

Comment threadsrc/coreclr/debug/inc/dacdbiinterface.h
Outdated

CopilotAI
review requested due to automatic review settings
May 15, 2026 17:21
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 1
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

@rcj1
Potential fix for pull request finding
2fbaf2b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 17, 2026 04:13
CopilotAI
reviewed
May 17, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
May 17, 2026

Closed

max-charlamb
max-charlamb
reviewed
May 18, 2026
View reviewed changes
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

@rcj1rcj1
mentioned this pull request
May 18, 2026
 Merged

noahfalk
noahfalk
approved these changes
May 18, 2026
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 18, 2026

Open

CopilotAI
review requested due to automatic review settings
May 18, 2026 22:43
CopilotAI
reviewed
May 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 0 new
@rcj1
rcj1
commented
May 19, 2026

Copy link


Copy Markdown

Contributor
/ba-g shebang analyzer issue
@rcj1
rcj1
merged commit e795eda
into
mainMay 19, 2026

121 of 127 checks passed

@rcj1
rcj1
deleted the

copilot/implement-typehandle-to-expanded-type-info

branch
May 19, 2026 02:55
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 20, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 21, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@max-charlambmax-charlambmax-charlamb left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

5 participants

@rcj1@noahfalk@max-charlamb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] Implement DacDbi APIs TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo - #128001
Merged
rcj1 merged 11 commits into
mainfrom 
copilot/implement-typehandle-to-expanded-type-info
May 19, 2026
Merged
[cDAC] Implement DacDbi APIs TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo#128001
rcj1 merged 11 commits into
mainfrom 
copilot/implement-typehandle-to-expanded-type-info
Conversation
CopilotAI
commented
May 10, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
After #128058 goes in the memcpy from a VMPTR will be awkward but correct. I figured it's ok that it's awkward because this is not really something we should be doing all the time.
CopilotAI
requested review from
Copilot
and removed request for
CopilotMay 10, 2026 01:09
@rcj1rcj1
changed the title
[cDAC] Use little-endian writes for IPCE structs and properly type DacDbi API parameters[cDAC] Add DacDbi APIs to fill DebuggerIPCE_ExpandedTypeDataMay 10, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 10, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@build-analysisbuild-analysisBot
mentioned this pull request
May 10, 2026

Open

3 tasks
CopilotAI
review requested due to automatic review settings
May 10, 2026 04:17
CopilotAI
reviewed
May 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR extends the cDAC DacDbi surface to produce DebuggerIPCE_ExpandedTypeData for a type handle or object address, and adds a RuntimeTypeSystem contract helper for recognizing the System.Object method table (so ELEMENT_TYPE_OBJECT can be reported distinctly from ELEMENT_TYPE_CLASS).
Changes:
  • Add IRuntimeTypeSystem.IsObject(TypeHandle) and plumb a new ObjectMethodTable global through the contract + test mocks.
  • Implement TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo in the managed DacDbiImpl, including little-endian writes matching native Portable<T>.
  • Update native DBI interface/IDL and call sites to route “type id -> type info” through TypeHandleToExpandedTypeInfo, and remove GetObjectExpandedTypeInfoFromID.
Show a summary per file
FileDescription
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.RuntimeTypeSystem.csAdds a mock global for the Object method table and patches it to System.Object’s MT in the mock target.
src/native/managed/cdac/tests/MethodTableTests.csExtends contract globals and asserts IsObject behavior for FreeObject MT vs System.Object MT.
src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.csAdds dump-based assertions for IsObject across object/free/string MTs.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csIntroduces managed projections of AreValueTypesBoxed and DebuggerIPCE_*TypeData and updates method signatures to typed pointers.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csImplements TypeHandleToExpandedTypeInfo / GetObjectExpandedTypeInfo and shared filling helpers with Portable-compatible endianness.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.csReads the ObjectMethodTable global and implements IsObject.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.csAdds the new IsObject(TypeHandle) API to the public contract interface.
src/coreclr/inc/dacdbi.idlChanges TypeHandleToExpandedTypeInfo to take a raw UINT64 and drops GetObjectExpandedTypeInfoFromID.
src/coreclr/debug/inc/dacdbistructures.hGives AreValueTypesBoxed explicit values (0/1/2).
src/coreclr/debug/inc/dacdbiinterface.hUpdates the COM interface signature and removes GetObjectExpandedTypeInfoFromID.
src/coreclr/debug/di/rstype.cppUpdates RS to call the new TypeHandleToExpandedTypeInfo signature (but currently extracts the handle unsafely).
src/coreclr/debug/di/process.cppRoutes GetTypeForTypeID through TypeHandleToExpandedTypeInfo using COR_TYPEID.token1.
src/coreclr/debug/daccess/dacdbiimpl.hUpdates DAC interface declaration to match the new signature.
src/coreclr/debug/daccess/dacdbiimpl.cppRemoves the old FromID method and updates implementation/callers for the new signature + zero-inits output structs.
docs/design/datacontracts/RuntimeTypeSystem.mdDocuments IsObject and the ObjectMethodTable global (but the globals table still has an incorrect FreeObject global name).
Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 5
Comment threadsrc/coreclr/debug/di/rstype.cpp
Outdated

Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated


This was referenced May 10, 2026

Open


Open

@rcj1
Potential fix for pull request finding
a2de94a
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 10, 2026 15:54
CopilotAI
reviewed
May 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/coreclr/debug/inc/dacdbiinterface.h
@rcj1
Potential fix for pull request finding
511c52b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 12, 2026 03:45
CopilotAI
reviewed
May 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
CopilotAI
changed the title
[cDAC] Add DacDbi APIs to fill DebuggerIPCE_ExpandedTypeDataSwitch DacDbi expanded type info APIs back to VMPTR inputsMay 12, 2026
CopilotAI
requested a review
from rcj1May 12, 2026 04:04
@rcj1
rcj1
marked this pull request as ready for review
May 12, 2026 17:23
@rcj1
rcj1
requested review from
max-charlamb and noahfalkMay 12, 2026 17:24
CopilotAI
reviewed
May 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/di/rstype.cpp
Outdated

Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
noahfalk
noahfalk
reviewed
May 14, 2026
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

Comment threadsrc/coreclr/debug/inc/dacdbiinterface.h
Outdated

CopilotAI
review requested due to automatic review settings
May 15, 2026 17:21
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 1
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

@rcj1
Potential fix for pull request finding
2fbaf2b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 17, 2026 04:13
CopilotAI
reviewed
May 17, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
May 17, 2026

Closed

max-charlamb
max-charlamb
reviewed
May 18, 2026
View reviewed changes
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

@rcj1rcj1
mentioned this pull request
May 18, 2026
 Merged

noahfalk
noahfalk
approved these changes
May 18, 2026
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 18, 2026

Open

CopilotAI
review requested due to automatic review settings
May 18, 2026 22:43
CopilotAI
reviewed
May 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 0 new
@rcj1
rcj1
commented
May 19, 2026

Copy link


Copy Markdown

Contributor
/ba-g shebang analyzer issue
@rcj1
rcj1
merged commit e795eda
into
mainMay 19, 2026

121 of 127 checks passed

@rcj1
rcj1
deleted the

copilot/implement-typehandle-to-expanded-type-info

branch
May 19, 2026 02:55
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 20, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 21, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@max-charlambmax-charlambmax-charlamb left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

5 participants

@rcj1@noahfalk@max-charlamb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[cDAC] Implement DacDbi APIs TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo - #128001
Merged
rcj1 merged 11 commits into
mainfrom 
copilot/implement-typehandle-to-expanded-type-info
May 19, 2026
Merged
[cDAC] Implement DacDbi APIs TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo#128001
rcj1 merged 11 commits into
mainfrom 
copilot/implement-typehandle-to-expanded-type-info
Conversation
CopilotAI
commented
May 10, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
After #128058 goes in the memcpy from a VMPTR will be awkward but correct. I figured it's ok that it's awkward because this is not really something we should be doing all the time.
CopilotAI
requested review from
Copilot
and removed request for
CopilotMay 10, 2026 01:09
@rcj1rcj1
changed the title
[cDAC] Use little-endian writes for IPCE structs and properly type DacDbi API parameters[cDAC] Add DacDbi APIs to fill DebuggerIPCE_ExpandedTypeDataMay 10, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 10, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@build-analysisbuild-analysisBot
mentioned this pull request
May 10, 2026

Open

3 tasks
CopilotAI
review requested due to automatic review settings
May 10, 2026 04:17
CopilotAI
reviewed
May 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR extends the cDAC DacDbi surface to produce DebuggerIPCE_ExpandedTypeData for a type handle or object address, and adds a RuntimeTypeSystem contract helper for recognizing the System.Object method table (so ELEMENT_TYPE_OBJECT can be reported distinctly from ELEMENT_TYPE_CLASS).
Changes:
  • Add IRuntimeTypeSystem.IsObject(TypeHandle) and plumb a new ObjectMethodTable global through the contract + test mocks.
  • Implement TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo in the managed DacDbiImpl, including little-endian writes matching native Portable<T>.
  • Update native DBI interface/IDL and call sites to route “type id -> type info” through TypeHandleToExpandedTypeInfo, and remove GetObjectExpandedTypeInfoFromID.
Show a summary per file
FileDescription
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.RuntimeTypeSystem.csAdds a mock global for the Object method table and patches it to System.Object’s MT in the mock target.
src/native/managed/cdac/tests/MethodTableTests.csExtends contract globals and asserts IsObject behavior for FreeObject MT vs System.Object MT.
src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.csAdds dump-based assertions for IsObject across object/free/string MTs.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csIntroduces managed projections of AreValueTypesBoxed and DebuggerIPCE_*TypeData and updates method signatures to typed pointers.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csImplements TypeHandleToExpandedTypeInfo / GetObjectExpandedTypeInfo and shared filling helpers with Portable-compatible endianness.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.csReads the ObjectMethodTable global and implements IsObject.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.csAdds the new IsObject(TypeHandle) API to the public contract interface.
src/coreclr/inc/dacdbi.idlChanges TypeHandleToExpandedTypeInfo to take a raw UINT64 and drops GetObjectExpandedTypeInfoFromID.
src/coreclr/debug/inc/dacdbistructures.hGives AreValueTypesBoxed explicit values (0/1/2).
src/coreclr/debug/inc/dacdbiinterface.hUpdates the COM interface signature and removes GetObjectExpandedTypeInfoFromID.
src/coreclr/debug/di/rstype.cppUpdates RS to call the new TypeHandleToExpandedTypeInfo signature (but currently extracts the handle unsafely).
src/coreclr/debug/di/process.cppRoutes GetTypeForTypeID through TypeHandleToExpandedTypeInfo using COR_TYPEID.token1.
src/coreclr/debug/daccess/dacdbiimpl.hUpdates DAC interface declaration to match the new signature.
src/coreclr/debug/daccess/dacdbiimpl.cppRemoves the old FromID method and updates implementation/callers for the new signature + zero-inits output structs.
docs/design/datacontracts/RuntimeTypeSystem.mdDocuments IsObject and the ObjectMethodTable global (but the globals table still has an incorrect FreeObject global name).
Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 5
Comment threadsrc/coreclr/debug/di/rstype.cpp
Outdated

Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated


This was referenced May 10, 2026

Open


Open

@rcj1
Potential fix for pull request finding
a2de94a
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 10, 2026 15:54
CopilotAI
reviewed
May 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/coreclr/debug/inc/dacdbiinterface.h
@rcj1
Potential fix for pull request finding
511c52b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 12, 2026 03:45
CopilotAI
reviewed
May 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
CopilotAI
changed the title
[cDAC] Add DacDbi APIs to fill DebuggerIPCE_ExpandedTypeDataSwitch DacDbi expanded type info APIs back to VMPTR inputsMay 12, 2026
CopilotAI
requested a review
from rcj1May 12, 2026 04:04
@rcj1
rcj1
marked this pull request as ready for review
May 12, 2026 17:23
@rcj1
rcj1
requested review from
max-charlamb and noahfalkMay 12, 2026 17:24
CopilotAI
reviewed
May 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/di/rstype.cpp
Outdated

Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
noahfalk
noahfalk
reviewed
May 14, 2026
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

Comment threadsrc/coreclr/debug/inc/dacdbiinterface.h
Outdated

CopilotAI
review requested due to automatic review settings
May 15, 2026 17:21
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 1
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

@rcj1
Potential fix for pull request finding
2fbaf2b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 17, 2026 04:13
CopilotAI
reviewed
May 17, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
May 17, 2026

Closed

max-charlamb
max-charlamb
reviewed
May 18, 2026
View reviewed changes
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

@rcj1rcj1
mentioned this pull request
May 18, 2026
 Merged

noahfalk
noahfalk
approved these changes
May 18, 2026
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 18, 2026

Open

CopilotAI
review requested due to automatic review settings
May 18, 2026 22:43
CopilotAI
reviewed
May 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 0 new
@rcj1
rcj1
commented
May 19, 2026

Copy link


Copy Markdown

Contributor
/ba-g shebang analyzer issue
@rcj1
rcj1
merged commit e795eda
into
mainMay 19, 2026

121 of 127 checks passed

@rcj1
rcj1
deleted the

copilot/implement-typehandle-to-expanded-type-info

branch
May 19, 2026 02:55
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 20, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 21, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@max-charlambmax-charlambmax-charlamb left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

5 participants

@rcj1@noahfalk@max-charlamb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] Implement DacDbi APIs TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo - #128001
Merged
rcj1 merged 11 commits into
mainfrom 
copilot/implement-typehandle-to-expanded-type-info
May 19, 2026
Merged
[cDAC] Implement DacDbi APIs TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo#128001
rcj1 merged 11 commits into
mainfrom 
copilot/implement-typehandle-to-expanded-type-info
Conversation
CopilotAI
commented
May 10, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
After #128058 goes in the memcpy from a VMPTR will be awkward but correct. I figured it's ok that it's awkward because this is not really something we should be doing all the time.
CopilotAI
requested review from
Copilot
and removed request for
CopilotMay 10, 2026 01:09
@rcj1rcj1
changed the title
[cDAC] Use little-endian writes for IPCE structs and properly type DacDbi API parameters[cDAC] Add DacDbi APIs to fill DebuggerIPCE_ExpandedTypeDataMay 10, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 10, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@build-analysisbuild-analysisBot
mentioned this pull request
May 10, 2026

Open

3 tasks
CopilotAI
review requested due to automatic review settings
May 10, 2026 04:17
CopilotAI
reviewed
May 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR extends the cDAC DacDbi surface to produce DebuggerIPCE_ExpandedTypeData for a type handle or object address, and adds a RuntimeTypeSystem contract helper for recognizing the System.Object method table (so ELEMENT_TYPE_OBJECT can be reported distinctly from ELEMENT_TYPE_CLASS).
Changes:
  • Add IRuntimeTypeSystem.IsObject(TypeHandle) and plumb a new ObjectMethodTable global through the contract + test mocks.
  • Implement TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo in the managed DacDbiImpl, including little-endian writes matching native Portable<T>.
  • Update native DBI interface/IDL and call sites to route “type id -> type info” through TypeHandleToExpandedTypeInfo, and remove GetObjectExpandedTypeInfoFromID.
Show a summary per file
FileDescription
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.RuntimeTypeSystem.csAdds a mock global for the Object method table and patches it to System.Object’s MT in the mock target.
src/native/managed/cdac/tests/MethodTableTests.csExtends contract globals and asserts IsObject behavior for FreeObject MT vs System.Object MT.
src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.csAdds dump-based assertions for IsObject across object/free/string MTs.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csIntroduces managed projections of AreValueTypesBoxed and DebuggerIPCE_*TypeData and updates method signatures to typed pointers.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csImplements TypeHandleToExpandedTypeInfo / GetObjectExpandedTypeInfo and shared filling helpers with Portable-compatible endianness.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.csReads the ObjectMethodTable global and implements IsObject.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.csAdds the new IsObject(TypeHandle) API to the public contract interface.
src/coreclr/inc/dacdbi.idlChanges TypeHandleToExpandedTypeInfo to take a raw UINT64 and drops GetObjectExpandedTypeInfoFromID.
src/coreclr/debug/inc/dacdbistructures.hGives AreValueTypesBoxed explicit values (0/1/2).
src/coreclr/debug/inc/dacdbiinterface.hUpdates the COM interface signature and removes GetObjectExpandedTypeInfoFromID.
src/coreclr/debug/di/rstype.cppUpdates RS to call the new TypeHandleToExpandedTypeInfo signature (but currently extracts the handle unsafely).
src/coreclr/debug/di/process.cppRoutes GetTypeForTypeID through TypeHandleToExpandedTypeInfo using COR_TYPEID.token1.
src/coreclr/debug/daccess/dacdbiimpl.hUpdates DAC interface declaration to match the new signature.
src/coreclr/debug/daccess/dacdbiimpl.cppRemoves the old FromID method and updates implementation/callers for the new signature + zero-inits output structs.
docs/design/datacontracts/RuntimeTypeSystem.mdDocuments IsObject and the ObjectMethodTable global (but the globals table still has an incorrect FreeObject global name).
Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 5
Comment threadsrc/coreclr/debug/di/rstype.cpp
Outdated

Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated


This was referenced May 10, 2026

Open


Open

@rcj1
Potential fix for pull request finding
a2de94a
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 10, 2026 15:54
CopilotAI
reviewed
May 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/coreclr/debug/inc/dacdbiinterface.h
@rcj1
Potential fix for pull request finding
511c52b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 12, 2026 03:45
CopilotAI
reviewed
May 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
CopilotAI
changed the title
[cDAC] Add DacDbi APIs to fill DebuggerIPCE_ExpandedTypeDataSwitch DacDbi expanded type info APIs back to VMPTR inputsMay 12, 2026
CopilotAI
requested a review
from rcj1May 12, 2026 04:04
@rcj1
rcj1
marked this pull request as ready for review
May 12, 2026 17:23
@rcj1
rcj1
requested review from
max-charlamb and noahfalkMay 12, 2026 17:24
CopilotAI
reviewed
May 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/di/rstype.cpp
Outdated

Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
noahfalk
noahfalk
reviewed
May 14, 2026
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

Comment threadsrc/coreclr/debug/inc/dacdbiinterface.h
Outdated

CopilotAI
review requested due to automatic review settings
May 15, 2026 17:21
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 1
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

@rcj1
Potential fix for pull request finding
2fbaf2b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 17, 2026 04:13
CopilotAI
reviewed
May 17, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
May 17, 2026

Closed

max-charlamb
max-charlamb
reviewed
May 18, 2026
View reviewed changes
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

@rcj1rcj1
mentioned this pull request
May 18, 2026
 Merged

noahfalk
noahfalk
approved these changes
May 18, 2026
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 18, 2026

Open

CopilotAI
review requested due to automatic review settings
May 18, 2026 22:43
CopilotAI
reviewed
May 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 0 new
@rcj1
rcj1
commented
May 19, 2026

Copy link


Copy Markdown

Contributor
/ba-g shebang analyzer issue
@rcj1
rcj1
merged commit e795eda
into
mainMay 19, 2026

121 of 127 checks passed

@rcj1
rcj1
deleted the

copilot/implement-typehandle-to-expanded-type-info

branch
May 19, 2026 02:55
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 20, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 21, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@max-charlambmax-charlambmax-charlamb left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

5 participants

@rcj1@noahfalk@max-charlamb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] Implement DacDbi APIs TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo - #128001
Merged
rcj1 merged 11 commits into
mainfrom 
copilot/implement-typehandle-to-expanded-type-info
May 19, 2026
Merged
[cDAC] Implement DacDbi APIs TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo#128001
rcj1 merged 11 commits into
mainfrom 
copilot/implement-typehandle-to-expanded-type-info
Conversation
CopilotAI
commented
May 10, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
After #128058 goes in the memcpy from a VMPTR will be awkward but correct. I figured it's ok that it's awkward because this is not really something we should be doing all the time.
CopilotAI
requested review from
Copilot
and removed request for
CopilotMay 10, 2026 01:09
@rcj1rcj1
changed the title
[cDAC] Use little-endian writes for IPCE structs and properly type DacDbi API parameters[cDAC] Add DacDbi APIs to fill DebuggerIPCE_ExpandedTypeDataMay 10, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 10, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@build-analysisbuild-analysisBot
mentioned this pull request
May 10, 2026

Open

3 tasks
CopilotAI
review requested due to automatic review settings
May 10, 2026 04:17
CopilotAI
reviewed
May 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR extends the cDAC DacDbi surface to produce DebuggerIPCE_ExpandedTypeData for a type handle or object address, and adds a RuntimeTypeSystem contract helper for recognizing the System.Object method table (so ELEMENT_TYPE_OBJECT can be reported distinctly from ELEMENT_TYPE_CLASS).
Changes:
  • Add IRuntimeTypeSystem.IsObject(TypeHandle) and plumb a new ObjectMethodTable global through the contract + test mocks.
  • Implement TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo in the managed DacDbiImpl, including little-endian writes matching native Portable<T>.
  • Update native DBI interface/IDL and call sites to route “type id -> type info” through TypeHandleToExpandedTypeInfo, and remove GetObjectExpandedTypeInfoFromID.
Show a summary per file
FileDescription
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.RuntimeTypeSystem.csAdds a mock global for the Object method table and patches it to System.Object’s MT in the mock target.
src/native/managed/cdac/tests/MethodTableTests.csExtends contract globals and asserts IsObject behavior for FreeObject MT vs System.Object MT.
src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.csAdds dump-based assertions for IsObject across object/free/string MTs.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csIntroduces managed projections of AreValueTypesBoxed and DebuggerIPCE_*TypeData and updates method signatures to typed pointers.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csImplements TypeHandleToExpandedTypeInfo / GetObjectExpandedTypeInfo and shared filling helpers with Portable-compatible endianness.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.csReads the ObjectMethodTable global and implements IsObject.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.csAdds the new IsObject(TypeHandle) API to the public contract interface.
src/coreclr/inc/dacdbi.idlChanges TypeHandleToExpandedTypeInfo to take a raw UINT64 and drops GetObjectExpandedTypeInfoFromID.
src/coreclr/debug/inc/dacdbistructures.hGives AreValueTypesBoxed explicit values (0/1/2).
src/coreclr/debug/inc/dacdbiinterface.hUpdates the COM interface signature and removes GetObjectExpandedTypeInfoFromID.
src/coreclr/debug/di/rstype.cppUpdates RS to call the new TypeHandleToExpandedTypeInfo signature (but currently extracts the handle unsafely).
src/coreclr/debug/di/process.cppRoutes GetTypeForTypeID through TypeHandleToExpandedTypeInfo using COR_TYPEID.token1.
src/coreclr/debug/daccess/dacdbiimpl.hUpdates DAC interface declaration to match the new signature.
src/coreclr/debug/daccess/dacdbiimpl.cppRemoves the old FromID method and updates implementation/callers for the new signature + zero-inits output structs.
docs/design/datacontracts/RuntimeTypeSystem.mdDocuments IsObject and the ObjectMethodTable global (but the globals table still has an incorrect FreeObject global name).
Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 5
Comment threadsrc/coreclr/debug/di/rstype.cpp
Outdated

Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated


This was referenced May 10, 2026

Open


Open

@rcj1
Potential fix for pull request finding
a2de94a
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 10, 2026 15:54
CopilotAI
reviewed
May 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/coreclr/debug/inc/dacdbiinterface.h
@rcj1
Potential fix for pull request finding
511c52b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 12, 2026 03:45
CopilotAI
reviewed
May 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
CopilotAI
changed the title
[cDAC] Add DacDbi APIs to fill DebuggerIPCE_ExpandedTypeDataSwitch DacDbi expanded type info APIs back to VMPTR inputsMay 12, 2026
CopilotAI
requested a review
from rcj1May 12, 2026 04:04
@rcj1
rcj1
marked this pull request as ready for review
May 12, 2026 17:23
@rcj1
rcj1
requested review from
max-charlamb and noahfalkMay 12, 2026 17:24
CopilotAI
reviewed
May 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/di/rstype.cpp
Outdated

Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
noahfalk
noahfalk
reviewed
May 14, 2026
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

Comment threadsrc/coreclr/debug/inc/dacdbiinterface.h
Outdated

CopilotAI
review requested due to automatic review settings
May 15, 2026 17:21
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 1
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

@rcj1
Potential fix for pull request finding
2fbaf2b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 17, 2026 04:13
CopilotAI
reviewed
May 17, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
May 17, 2026

Closed

max-charlamb
max-charlamb
reviewed
May 18, 2026
View reviewed changes
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

@rcj1rcj1
mentioned this pull request
May 18, 2026
 Merged

noahfalk
noahfalk
approved these changes
May 18, 2026
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 18, 2026

Open

CopilotAI
review requested due to automatic review settings
May 18, 2026 22:43
CopilotAI
reviewed
May 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 0 new
@rcj1
rcj1
commented
May 19, 2026

Copy link


Copy Markdown

Contributor
/ba-g shebang analyzer issue
@rcj1
rcj1
merged commit e795eda
into
mainMay 19, 2026

121 of 127 checks passed

@rcj1
rcj1
deleted the

copilot/implement-typehandle-to-expanded-type-info

branch
May 19, 2026 02:55
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 20, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 21, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@max-charlambmax-charlambmax-charlamb left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

5 participants

@rcj1@noahfalk@max-charlamb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[cDAC] Implement DacDbi APIs TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo - #128001
Merged
rcj1 merged 11 commits into
mainfrom 
copilot/implement-typehandle-to-expanded-type-info
May 19, 2026
Merged
[cDAC] Implement DacDbi APIs TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo#128001
rcj1 merged 11 commits into
mainfrom 
copilot/implement-typehandle-to-expanded-type-info
Conversation
CopilotAI
commented
May 10, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
After #128058 goes in the memcpy from a VMPTR will be awkward but correct. I figured it's ok that it's awkward because this is not really something we should be doing all the time.
CopilotAI
requested review from
Copilot
and removed request for
CopilotMay 10, 2026 01:09
@rcj1rcj1
changed the title
[cDAC] Use little-endian writes for IPCE structs and properly type DacDbi API parameters[cDAC] Add DacDbi APIs to fill DebuggerIPCE_ExpandedTypeDataMay 10, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 10, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@build-analysisbuild-analysisBot
mentioned this pull request
May 10, 2026

Open

3 tasks
CopilotAI
review requested due to automatic review settings
May 10, 2026 04:17
CopilotAI
reviewed
May 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR extends the cDAC DacDbi surface to produce DebuggerIPCE_ExpandedTypeData for a type handle or object address, and adds a RuntimeTypeSystem contract helper for recognizing the System.Object method table (so ELEMENT_TYPE_OBJECT can be reported distinctly from ELEMENT_TYPE_CLASS).
Changes:
  • Add IRuntimeTypeSystem.IsObject(TypeHandle) and plumb a new ObjectMethodTable global through the contract + test mocks.
  • Implement TypeHandleToExpandedTypeInfo and GetObjectExpandedTypeInfo in the managed DacDbiImpl, including little-endian writes matching native Portable<T>.
  • Update native DBI interface/IDL and call sites to route “type id -> type info” through TypeHandleToExpandedTypeInfo, and remove GetObjectExpandedTypeInfoFromID.
Show a summary per file
FileDescription
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.RuntimeTypeSystem.csAdds a mock global for the Object method table and patches it to System.Object’s MT in the mock target.
src/native/managed/cdac/tests/MethodTableTests.csExtends contract globals and asserts IsObject behavior for FreeObject MT vs System.Object MT.
src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.csAdds dump-based assertions for IsObject across object/free/string MTs.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csIntroduces managed projections of AreValueTypesBoxed and DebuggerIPCE_*TypeData and updates method signatures to typed pointers.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csImplements TypeHandleToExpandedTypeInfo / GetObjectExpandedTypeInfo and shared filling helpers with Portable-compatible endianness.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.csReads the ObjectMethodTable global and implements IsObject.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.csAdds the new IsObject(TypeHandle) API to the public contract interface.
src/coreclr/inc/dacdbi.idlChanges TypeHandleToExpandedTypeInfo to take a raw UINT64 and drops GetObjectExpandedTypeInfoFromID.
src/coreclr/debug/inc/dacdbistructures.hGives AreValueTypesBoxed explicit values (0/1/2).
src/coreclr/debug/inc/dacdbiinterface.hUpdates the COM interface signature and removes GetObjectExpandedTypeInfoFromID.
src/coreclr/debug/di/rstype.cppUpdates RS to call the new TypeHandleToExpandedTypeInfo signature (but currently extracts the handle unsafely).
src/coreclr/debug/di/process.cppRoutes GetTypeForTypeID through TypeHandleToExpandedTypeInfo using COR_TYPEID.token1.
src/coreclr/debug/daccess/dacdbiimpl.hUpdates DAC interface declaration to match the new signature.
src/coreclr/debug/daccess/dacdbiimpl.cppRemoves the old FromID method and updates implementation/callers for the new signature + zero-inits output structs.
docs/design/datacontracts/RuntimeTypeSystem.mdDocuments IsObject and the ObjectMethodTable global (but the globals table still has an incorrect FreeObject global name).
Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 5
Comment threadsrc/coreclr/debug/di/rstype.cpp
Outdated

Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated


This was referenced May 10, 2026

Open


Open

@rcj1
Potential fix for pull request finding
a2de94a
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 10, 2026 15:54
CopilotAI
reviewed
May 10, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/coreclr/debug/inc/dacdbiinterface.h
@rcj1
Potential fix for pull request finding
511c52b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 12, 2026 03:45
CopilotAI
reviewed
May 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
CopilotAI
changed the title
[cDAC] Add DacDbi APIs to fill DebuggerIPCE_ExpandedTypeDataSwitch DacDbi expanded type info APIs back to VMPTR inputsMay 12, 2026
CopilotAI
requested a review
from rcj1May 12, 2026 04:04
@rcj1
rcj1
marked this pull request as ready for review
May 12, 2026 17:23
@rcj1
rcj1
requested review from
max-charlamb and noahfalkMay 12, 2026 17:24
CopilotAI
reviewed
May 12, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/di/rstype.cpp
Outdated

Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
noahfalk
noahfalk
reviewed
May 14, 2026
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

Comment threadsrc/coreclr/debug/inc/dacdbiinterface.h
Outdated

CopilotAI
review requested due to automatic review settings
May 15, 2026 17:21
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 1
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

@rcj1
Potential fix for pull request finding
2fbaf2b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 17, 2026 04:13
CopilotAI
reviewed
May 17, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
May 17, 2026

Closed

max-charlamb
max-charlamb
reviewed
May 18, 2026
View reviewed changes
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

@rcj1rcj1
mentioned this pull request
May 18, 2026
 Merged

noahfalk
noahfalk
approved these changes
May 18, 2026
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 18, 2026

Open

CopilotAI
review requested due to automatic review settings
May 18, 2026 22:43
CopilotAI
reviewed
May 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 15/15 changed files
  • Comments generated: 0 new
@rcj1
rcj1
commented
May 19, 2026

Copy link


Copy Markdown

Contributor
/ba-g shebang analyzer issue
@rcj1
rcj1
merged commit e795eda
into
mainMay 19, 2026

121 of 127 checks passed

@rcj1
rcj1
deleted the

copilot/implement-typehandle-to-expanded-type-info

branch
May 19, 2026 02:55
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 20, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 21, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@max-charlambmax-charlambmax-charlamb left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

5 participants

@rcj1@noahfalk@max-charlamb