[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames - #128241

Merged
rcj1 merged 13 commits into
mainfrom
copilot/add-dacdbi-getframes-api
May 19, 2026
Merged

[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames#128241
rcj1 merged 13 commits into
mainfrom
copilot/add-dacdbi-getframes-api

Conversation

CopilotAI commented May 15, 2026•
edited by rcj1
Loading

Copy link
Copy Markdown
Contributor

New StackWalk cDAC APIs:

IEnumerable<StackFrameData>GetFrames(TargetPointerthreadPointer)=>thrownewNotImplementedException();boolIsExceptionHandlingHelperInlinedCallFrame(TargetPointerframeAddress)=>thrownewNotImplementedException();DebuggerEvalDataGetDebuggerEvalData(TargetPointerfuncEvalFrameAddress)=>thrownewNotImplementedException();

@rcj1
Implement DacDbi GetCountOfInternalFrames and EnumerateInternalFrames…
2185748
… in cDAC via new Thread_1.GetFrames
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI requested review from Copilot and removed request for CopilotMay 15, 2026 02:21
@rcj1rcj1 added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 15, 2026
@rcj1rcj1 added the NO-REVIEW Experimental/testing PR, do NOT review it label May 15, 2026
@dotnet-policy-service

dotnet-policy-serviceBot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

CopilotAI review requested due to automatic review settings May 15, 2026 04:32
CopilotAI reviewed May 15, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

The PR's title and description say it deletes a single unused field (nativeCodeJITInfoToken) from DebuggerIPCE_JITFuncData, but the actual diff is a much larger reshape: the legacy DebuggerIPCE_* IPC structs (FuncData, JITFuncData, STRData) are renamed to Debugger_* and moved/restructured, the DAC Debugger_STRData now stores ctx/rd as CORDB_ADDRESS pointers into dbi-allocated buffers, Frame::GetStubFrameType() is added so GetInternalFrameType can replace its old transition/interception heuristics, and the cDAC gains real implementations of GetCountOfInternalFrames/EnumerateInternalFrames plus a new IStackWalk.GetFrames/IsExceptionHandlingHelperInlinedCallFrame/GetDebuggerEvalData surface (with tests and contract docs). The PR description significantly understates the scope of changes.

Changes:

  • Rename and restructure the dbi/DAC stack frame IPC structs and switch Debugger_STRData::ctx/rd to caller-allocated buffers referenced by CORDB_ADDRESS.
  • Add Frame::GetStubFrameType() polymorphic dispatch and rewrite DacDbiInterfaceImpl::GetInternalFrameType on top of it.
  • Add cDAC IStackWalk.GetFrames/IsExceptionHandlingHelperInlinedCallFrame/GetDebuggerEvalData and use them to implement GetCountOfInternalFrames/EnumerateInternalFrames, with new mock infrastructure and tests.
Show a summary per file
FileDescription
src/coreclr/debug/inc/dbgipcevents.hRemoves legacy DebuggerIPCE_FuncData/JITFuncData/STRData definitions (now defined in dacdbistructures.h).
src/coreclr/debug/inc/dacdbistructures.hAdds renamed Debugger_FuncData/Debugger_JITFuncData/Debugger_STRData with ctx/rd as CORDB_ADDRESS.
src/coreclr/debug/inc/dacdbistructures.inlUpdates NativeCodeFunctionData ctor to take Debugger_JITFuncData*.
src/coreclr/debug/inc/dacdbiinterface.hRenames the IPC struct in interface signatures and comments.
src/coreclr/inc/dacdbi.idlRenames DebuggerIPCE_STRData to Debugger_STRData in IDL.
src/coreclr/debug/daccess/dacdbiimpl.hUpdates dacdbi impl signatures to renamed types.
src/coreclr/debug/daccess/dacdbiimplstackwalk.cppUpdates rename, switches to caller-allocated ctx/rd, rewrites GetInternalFrameType via GetStubFrameType(); leaves a duplicate pJITFuncData->enCVersion assignment.
src/coreclr/vm/frames.h / frames.cppAdds Frame::StubFrameType enum, virtual GetStubFrameType_Impl per subclass, and dispatch.
src/coreclr/vm/datadescriptor/datadescriptor.incExposes DebuggerEval::m_methodToken/m_pAssembly to the cDAC data descriptor.
src/coreclr/debug/ee/debugger.h / debugger.cppAdds m_pAssembly to DebuggerEval and initializes it.
src/coreclr/debug/di/rsthread.cpp / rsstackwalk.cpp / rspriv.hUpdates dbi-side rename and allocates DT_CONTEXT/DebuggerREGDISPLAY for the new Debugger_STRData protocol.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStackWalk.csAdds InternalFrameType, StackFrameData, DebuggerEvalData, and three new IStackWalk methods.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/StackWalk_1.csImplements GetFrames, IsExceptionHandlingHelperInlinedCallFrame, GetDebuggerEvalData.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.csAdds GetInternalFrameType/IsExceptionHandlingHelperInlinedCallFrame; the latter omits the FrameHasActiveCall check.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Thread_1.csAdds using System.Collections.Generic; (looks unused locally — only the using is shown changed).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/Frames/DebuggerEval.csReads new MethodToken/AssemblyPtr fields.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csDefines managed mirrors of the new Debugger_* structs and the EnumerateInternalFrames callback signature.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csProvides cDAC implementations of GetCountOfInternalFrames/EnumerateInternalFrames with DEBUG-only DAC cross-validation.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Frame.csNew mock Frame layouts and MockFrameBuilder helper.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Thread.csAdds a public Frame accessor on MockThread.
src/native/managed/cdac/tests/StackWalkTests.csNew tests for GetFrames, EH-helper ICF detection, and GetDebuggerEvalData.
docs/design/datacontracts/StackWalk.mdDocuments the new APIs and EH-helper marker constant.

Copilot's findings

  • Files reviewed: 26/26 changed files
  • Comments generated: 2

Comment thread....Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.cs Outdated
Comment threadsrc/coreclr/debug/daccess/dacdbiimplstackwalk.cpp Outdated
CopilotAI review requested due to automatic review settings May 15, 2026 04:39
CopilotAI reviewed May 15, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 25/25 changed files
  • Comments generated: 5

Comment threadsrc/coreclr/debug/inc/dbgipcevents.h
Comment threadsrc/coreclr/debug/daccess/dacdbiimplstackwalk.cpp Outdated
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs Outdated
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
@rcj1
Potential fix for pull request finding
1c8ffb3
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings May 15, 2026 04:56
CopilotAI reviewed May 15, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 25/25 changed files
  • Comments generated: 3

Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Comment threadsrc/coreclr/debug/inc/dacdbistructures.inl Outdated
Comment threadsrc/coreclr/debug/inc/dbgipcevents.h
@rcj1rcj1 changed the title Delete unused nativeCodeJITInfoToken from DebuggerIPCE_JITFuncData[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 15, 2026
@rcj1rcj1 removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels May 15, 2026
@rcj1
rcj1 marked this pull request as ready for review May 15, 2026 05:10
@rcj1
rcj1 requested review from max-charlamb and noahfalkMay 15, 2026 05:10
CopilotAI reviewed May 16, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 26/26 changed files
  • Comments generated: 1

Comment thread...t.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameHelpers.cs
@rcj1
Potential fix for pull request finding
b1f3049
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings May 16, 2026 03:59
CopilotAI reviewed May 16, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 26/26 changed files
  • Comments generated: 0 new

This was referenced May 16, 2026
Closed
Open
@rcj1rcj1 changed the title [cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames[cDAC] [WIP] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 18, 2026
@rcj1
rcj1 marked this pull request as draft May 18, 2026 18:24
noahfalk
noahfalk approved these changes May 18, 2026
View reviewed changes

@noahfalknoahfalk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good to me modulo a few comments inline

Comment threadsrc/coreclr/debug/inc/dacdbistructures.h Outdated
Comment threadsrc/coreclr/vm/frames.h
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs Outdated
Comment threadsrc/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Frame.cs Outdated
@rcj1rcj1 changed the title [cDAC] [WIP] implement EnumerateInternalFrames and GetCountOfInternalFrames[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 18, 2026
@rcj1
rcj1 marked this pull request as ready for review May 18, 2026 23:03
CopilotAI review requested due to automatic review settings May 18, 2026 23:03
CopilotAI reviewed May 18, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new

@build-analysisbuild-analysisBot mentioned this pull request May 19, 2026
Closed
CopilotAI review requested due to automatic review settings May 19, 2026 04:48
CopilotAI reviewed May 19, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new

@rcj1rcj1 mentioned this pull request May 19, 2026
Closed
@rcj1

rcj1 commented May 19, 2026

Copy link
Copy Markdown
Contributor

/ba-g #128372

@rcj1
rcj1 merged commit fb7020f into mainMay 19, 2026
121 of 126 checks passed
@rcj1
rcj1 deleted the copilot/add-dacdbi-getframes-api branch May 19, 2026 14:00
@dotnet-maestrodotnet-maestroBot mentioned this pull request May 20, 2026
Merged
@dotnet-milestone-botdotnet-milestone-botBot added this to the 11.0-preview6 milestone May 21, 2026
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jun 21, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rcj1rcj1rcj1 left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@max-charlambmax-charlambAwaiting requested review from max-charlamb

Assignees

@rcj1rcj1

Copilot code reviewCopilot

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames - #128241
Merged
rcj1 merged 13 commits into
mainfrom 
copilot/add-dacdbi-getframes-api
May 19, 2026
Merged
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames#128241
rcj1 merged 13 commits into
mainfrom 
copilot/add-dacdbi-getframes-api
Conversation
CopilotAI
commented
May 15, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
New StackWalk cDAC APIs:
IEnumerable<StackFrameData>GetFrames(TargetPointerthreadPointer)=>thrownewNotImplementedException();boolIsExceptionHandlingHelperInlinedCallFrame(TargetPointerframeAddress)=>thrownewNotImplementedException();DebuggerEvalDataGetDebuggerEvalData(TargetPointerfuncEvalFrameAddress)=>thrownewNotImplementedException();
@rcj1
Implement DacDbi GetCountOfInternalFrames and EnumerateInternalFrames…
2185748
… in cDAC via new Thread_1.GetFrames
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotMay 15, 2026 02:21
@rcj1rcj1
added
the 
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
May 15, 2026
@rcj1rcj1
added
the 
NO-REVIEW
Experimental/testing PR, do NOT review it
label
May 15, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 15, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
review requested due to automatic review settings
May 15, 2026 04:32
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
The PR's title and description say it deletes a single unused field (nativeCodeJITInfoToken) from DebuggerIPCE_JITFuncData, but the actual diff is a much larger reshape: the legacy DebuggerIPCE_* IPC structs (FuncData, JITFuncData, STRData) are renamed to Debugger_* and moved/restructured, the DAC Debugger_STRData now stores ctx/rd as CORDB_ADDRESS pointers into dbi-allocated buffers, Frame::GetStubFrameType() is added so GetInternalFrameType can replace its old transition/interception heuristics, and the cDAC gains real implementations of GetCountOfInternalFrames/EnumerateInternalFrames plus a new IStackWalk.GetFrames/IsExceptionHandlingHelperInlinedCallFrame/GetDebuggerEvalData surface (with tests and contract docs). The PR description significantly understates the scope of changes.
Changes:
  • Rename and restructure the dbi/DAC stack frame IPC structs and switch Debugger_STRData::ctx/rd to caller-allocated buffers referenced by CORDB_ADDRESS.
  • Add Frame::GetStubFrameType() polymorphic dispatch and rewrite DacDbiInterfaceImpl::GetInternalFrameType on top of it.
  • Add cDAC IStackWalk.GetFrames/IsExceptionHandlingHelperInlinedCallFrame/GetDebuggerEvalData and use them to implement GetCountOfInternalFrames/EnumerateInternalFrames, with new mock infrastructure and tests.
Show a summary per file
FileDescription
src/coreclr/debug/inc/dbgipcevents.hRemoves legacy DebuggerIPCE_FuncData/JITFuncData/STRData definitions (now defined in dacdbistructures.h).
src/coreclr/debug/inc/dacdbistructures.hAdds renamed Debugger_FuncData/Debugger_JITFuncData/Debugger_STRData with ctx/rd as CORDB_ADDRESS.
src/coreclr/debug/inc/dacdbistructures.inlUpdates NativeCodeFunctionData ctor to take Debugger_JITFuncData*.
src/coreclr/debug/inc/dacdbiinterface.hRenames the IPC struct in interface signatures and comments.
src/coreclr/inc/dacdbi.idlRenames DebuggerIPCE_STRData to Debugger_STRData in IDL.
src/coreclr/debug/daccess/dacdbiimpl.hUpdates dacdbi impl signatures to renamed types.
src/coreclr/debug/daccess/dacdbiimplstackwalk.cppUpdates rename, switches to caller-allocated ctx/rd, rewrites GetInternalFrameType via GetStubFrameType(); leaves a duplicate pJITFuncData->enCVersion assignment.
src/coreclr/vm/frames.h / frames.cppAdds Frame::StubFrameType enum, virtual GetStubFrameType_Impl per subclass, and dispatch.
src/coreclr/vm/datadescriptor/datadescriptor.incExposes DebuggerEval::m_methodToken/m_pAssembly to the cDAC data descriptor.
src/coreclr/debug/ee/debugger.h / debugger.cppAdds m_pAssembly to DebuggerEval and initializes it.
src/coreclr/debug/di/rsthread.cpp / rsstackwalk.cpp / rspriv.hUpdates dbi-side rename and allocates DT_CONTEXT/DebuggerREGDISPLAY for the new Debugger_STRData protocol.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStackWalk.csAdds InternalFrameType, StackFrameData, DebuggerEvalData, and three new IStackWalk methods.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/StackWalk_1.csImplements GetFrames, IsExceptionHandlingHelperInlinedCallFrame, GetDebuggerEvalData.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.csAdds GetInternalFrameType/IsExceptionHandlingHelperInlinedCallFrame; the latter omits the FrameHasActiveCall check.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Thread_1.csAdds using System.Collections.Generic; (looks unused locally — only the using is shown changed).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/Frames/DebuggerEval.csReads new MethodToken/AssemblyPtr fields.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csDefines managed mirrors of the new Debugger_* structs and the EnumerateInternalFrames callback signature.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csProvides cDAC implementations of GetCountOfInternalFrames/EnumerateInternalFrames with DEBUG-only DAC cross-validation.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Frame.csNew mock Frame layouts and MockFrameBuilder helper.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Thread.csAdds a public Frame accessor on MockThread.
src/native/managed/cdac/tests/StackWalkTests.csNew tests for GetFrames, EH-helper ICF detection, and GetDebuggerEvalData.
docs/design/datacontracts/StackWalk.mdDocuments the new APIs and EH-helper marker constant.
Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 2
Comment thread....Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.cs
Outdated

Comment threadsrc/coreclr/debug/daccess/dacdbiimplstackwalk.cpp
Outdated

CopilotAI
review requested due to automatic review settings
May 15, 2026 04:39
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 25/25 changed files
  • Comments generated: 5
Comment threadsrc/coreclr/debug/inc/dbgipcevents.h
Comment threadsrc/coreclr/debug/daccess/dacdbiimplstackwalk.cpp
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
@rcj1
Potential fix for pull request finding
1c8ffb3
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 15, 2026 04:56
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 25/25 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Comment threadsrc/coreclr/debug/inc/dacdbistructures.inl
Outdated

Comment threadsrc/coreclr/debug/inc/dbgipcevents.h
@rcj1rcj1
changed the title
Delete unused nativeCodeJITInfoToken from DebuggerIPCE_JITFuncData[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 15, 2026
@rcj1rcj1
removed

NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
labels
May 15, 2026
@rcj1
rcj1
marked this pull request as ready for review
May 15, 2026 05:10
@rcj1
rcj1
requested review from
max-charlamb and noahfalkMay 15, 2026 05:10
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 1
Comment thread...t.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameHelpers.cs
@rcj1
Potential fix for pull request finding
b1f3049
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 16, 2026 03:59
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 0 new

This was referenced May 16, 2026

Closed


Open

@rcj1rcj1
changed the title
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames[cDAC] [WIP] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 18, 2026
@rcj1
rcj1
marked this pull request as draft
May 18, 2026 18:24
noahfalk
noahfalk
approved these changes
May 18, 2026
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good to me modulo a few comments inline
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Outdated

Comment threadsrc/coreclr/vm/frames.h
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Frame.cs
Outdated

@rcj1rcj1
changed the title
[cDAC] [WIP] implement EnumerateInternalFrames and GetCountOfInternalFrames[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 18, 2026
@rcj1
rcj1
marked this pull request as ready for review
May 18, 2026 23:03
CopilotAI
review requested due to automatic review settings
May 18, 2026 23:03
CopilotAI
reviewed
May 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
May 19, 2026

Closed

CopilotAI
review requested due to automatic review settings
May 19, 2026 04:48
CopilotAI
reviewed
May 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new
@rcj1rcj1
mentioned this pull request
May 19, 2026

Closed

@rcj1
rcj1
commented
May 19, 2026

Copy link


Copy Markdown

Contributor
/ba-g #128372
@rcj1
rcj1
merged commit fb7020f
into
mainMay 19, 2026

121 of 126 checks passed

@rcj1
rcj1
deleted the

copilot/add-dacdbi-getframes-api

branch
May 19, 2026 14:00
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 20, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 21, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@rcj1rcj1rcj1 left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@max-charlambmax-charlambAwaiting requested review from max-charlamb

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames - #128241
Merged
rcj1 merged 13 commits into
mainfrom 
copilot/add-dacdbi-getframes-api
May 19, 2026
Merged
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames#128241
rcj1 merged 13 commits into
mainfrom 
copilot/add-dacdbi-getframes-api
Conversation
CopilotAI
commented
May 15, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
New StackWalk cDAC APIs:
IEnumerable<StackFrameData>GetFrames(TargetPointerthreadPointer)=>thrownewNotImplementedException();boolIsExceptionHandlingHelperInlinedCallFrame(TargetPointerframeAddress)=>thrownewNotImplementedException();DebuggerEvalDataGetDebuggerEvalData(TargetPointerfuncEvalFrameAddress)=>thrownewNotImplementedException();
@rcj1
Implement DacDbi GetCountOfInternalFrames and EnumerateInternalFrames…
2185748
… in cDAC via new Thread_1.GetFrames
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotMay 15, 2026 02:21
@rcj1rcj1
added
the 
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
May 15, 2026
@rcj1rcj1
added
the 
NO-REVIEW
Experimental/testing PR, do NOT review it
label
May 15, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 15, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
review requested due to automatic review settings
May 15, 2026 04:32
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
The PR's title and description say it deletes a single unused field (nativeCodeJITInfoToken) from DebuggerIPCE_JITFuncData, but the actual diff is a much larger reshape: the legacy DebuggerIPCE_* IPC structs (FuncData, JITFuncData, STRData) are renamed to Debugger_* and moved/restructured, the DAC Debugger_STRData now stores ctx/rd as CORDB_ADDRESS pointers into dbi-allocated buffers, Frame::GetStubFrameType() is added so GetInternalFrameType can replace its old transition/interception heuristics, and the cDAC gains real implementations of GetCountOfInternalFrames/EnumerateInternalFrames plus a new IStackWalk.GetFrames/IsExceptionHandlingHelperInlinedCallFrame/GetDebuggerEvalData surface (with tests and contract docs). The PR description significantly understates the scope of changes.
Changes:
  • Rename and restructure the dbi/DAC stack frame IPC structs and switch Debugger_STRData::ctx/rd to caller-allocated buffers referenced by CORDB_ADDRESS.
  • Add Frame::GetStubFrameType() polymorphic dispatch and rewrite DacDbiInterfaceImpl::GetInternalFrameType on top of it.
  • Add cDAC IStackWalk.GetFrames/IsExceptionHandlingHelperInlinedCallFrame/GetDebuggerEvalData and use them to implement GetCountOfInternalFrames/EnumerateInternalFrames, with new mock infrastructure and tests.
Show a summary per file
FileDescription
src/coreclr/debug/inc/dbgipcevents.hRemoves legacy DebuggerIPCE_FuncData/JITFuncData/STRData definitions (now defined in dacdbistructures.h).
src/coreclr/debug/inc/dacdbistructures.hAdds renamed Debugger_FuncData/Debugger_JITFuncData/Debugger_STRData with ctx/rd as CORDB_ADDRESS.
src/coreclr/debug/inc/dacdbistructures.inlUpdates NativeCodeFunctionData ctor to take Debugger_JITFuncData*.
src/coreclr/debug/inc/dacdbiinterface.hRenames the IPC struct in interface signatures and comments.
src/coreclr/inc/dacdbi.idlRenames DebuggerIPCE_STRData to Debugger_STRData in IDL.
src/coreclr/debug/daccess/dacdbiimpl.hUpdates dacdbi impl signatures to renamed types.
src/coreclr/debug/daccess/dacdbiimplstackwalk.cppUpdates rename, switches to caller-allocated ctx/rd, rewrites GetInternalFrameType via GetStubFrameType(); leaves a duplicate pJITFuncData->enCVersion assignment.
src/coreclr/vm/frames.h / frames.cppAdds Frame::StubFrameType enum, virtual GetStubFrameType_Impl per subclass, and dispatch.
src/coreclr/vm/datadescriptor/datadescriptor.incExposes DebuggerEval::m_methodToken/m_pAssembly to the cDAC data descriptor.
src/coreclr/debug/ee/debugger.h / debugger.cppAdds m_pAssembly to DebuggerEval and initializes it.
src/coreclr/debug/di/rsthread.cpp / rsstackwalk.cpp / rspriv.hUpdates dbi-side rename and allocates DT_CONTEXT/DebuggerREGDISPLAY for the new Debugger_STRData protocol.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStackWalk.csAdds InternalFrameType, StackFrameData, DebuggerEvalData, and three new IStackWalk methods.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/StackWalk_1.csImplements GetFrames, IsExceptionHandlingHelperInlinedCallFrame, GetDebuggerEvalData.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.csAdds GetInternalFrameType/IsExceptionHandlingHelperInlinedCallFrame; the latter omits the FrameHasActiveCall check.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Thread_1.csAdds using System.Collections.Generic; (looks unused locally — only the using is shown changed).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/Frames/DebuggerEval.csReads new MethodToken/AssemblyPtr fields.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csDefines managed mirrors of the new Debugger_* structs and the EnumerateInternalFrames callback signature.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csProvides cDAC implementations of GetCountOfInternalFrames/EnumerateInternalFrames with DEBUG-only DAC cross-validation.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Frame.csNew mock Frame layouts and MockFrameBuilder helper.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Thread.csAdds a public Frame accessor on MockThread.
src/native/managed/cdac/tests/StackWalkTests.csNew tests for GetFrames, EH-helper ICF detection, and GetDebuggerEvalData.
docs/design/datacontracts/StackWalk.mdDocuments the new APIs and EH-helper marker constant.
Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 2
Comment thread....Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.cs
Outdated

Comment threadsrc/coreclr/debug/daccess/dacdbiimplstackwalk.cpp
Outdated

CopilotAI
review requested due to automatic review settings
May 15, 2026 04:39
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 25/25 changed files
  • Comments generated: 5
Comment threadsrc/coreclr/debug/inc/dbgipcevents.h
Comment threadsrc/coreclr/debug/daccess/dacdbiimplstackwalk.cpp
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
@rcj1
Potential fix for pull request finding
1c8ffb3
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 15, 2026 04:56
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 25/25 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Comment threadsrc/coreclr/debug/inc/dacdbistructures.inl
Outdated

Comment threadsrc/coreclr/debug/inc/dbgipcevents.h
@rcj1rcj1
changed the title
Delete unused nativeCodeJITInfoToken from DebuggerIPCE_JITFuncData[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 15, 2026
@rcj1rcj1
removed

NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
labels
May 15, 2026
@rcj1
rcj1
marked this pull request as ready for review
May 15, 2026 05:10
@rcj1
rcj1
requested review from
max-charlamb and noahfalkMay 15, 2026 05:10
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 1
Comment thread...t.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameHelpers.cs
@rcj1
Potential fix for pull request finding
b1f3049
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 16, 2026 03:59
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 0 new

This was referenced May 16, 2026

Closed


Open

@rcj1rcj1
changed the title
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames[cDAC] [WIP] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 18, 2026
@rcj1
rcj1
marked this pull request as draft
May 18, 2026 18:24
noahfalk
noahfalk
approved these changes
May 18, 2026
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good to me modulo a few comments inline
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Outdated

Comment threadsrc/coreclr/vm/frames.h
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Frame.cs
Outdated

@rcj1rcj1
changed the title
[cDAC] [WIP] implement EnumerateInternalFrames and GetCountOfInternalFrames[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 18, 2026
@rcj1
rcj1
marked this pull request as ready for review
May 18, 2026 23:03
CopilotAI
review requested due to automatic review settings
May 18, 2026 23:03
CopilotAI
reviewed
May 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
May 19, 2026

Closed

CopilotAI
review requested due to automatic review settings
May 19, 2026 04:48
CopilotAI
reviewed
May 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new
@rcj1rcj1
mentioned this pull request
May 19, 2026

Closed

@rcj1
rcj1
commented
May 19, 2026

Copy link


Copy Markdown

Contributor
/ba-g #128372
@rcj1
rcj1
merged commit fb7020f
into
mainMay 19, 2026

121 of 126 checks passed

@rcj1
rcj1
deleted the

copilot/add-dacdbi-getframes-api

branch
May 19, 2026 14:00
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 20, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 21, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@rcj1rcj1rcj1 left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@max-charlambmax-charlambAwaiting requested review from max-charlamb

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames - #128241
Merged
rcj1 merged 13 commits into
mainfrom 
copilot/add-dacdbi-getframes-api
May 19, 2026
Merged
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames#128241
rcj1 merged 13 commits into
mainfrom 
copilot/add-dacdbi-getframes-api
Conversation
CopilotAI
commented
May 15, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
New StackWalk cDAC APIs:
IEnumerable<StackFrameData>GetFrames(TargetPointerthreadPointer)=>thrownewNotImplementedException();boolIsExceptionHandlingHelperInlinedCallFrame(TargetPointerframeAddress)=>thrownewNotImplementedException();DebuggerEvalDataGetDebuggerEvalData(TargetPointerfuncEvalFrameAddress)=>thrownewNotImplementedException();
@rcj1
Implement DacDbi GetCountOfInternalFrames and EnumerateInternalFrames…
2185748
… in cDAC via new Thread_1.GetFrames
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotMay 15, 2026 02:21
@rcj1rcj1
added
the 
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
May 15, 2026
@rcj1rcj1
added
the 
NO-REVIEW
Experimental/testing PR, do NOT review it
label
May 15, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 15, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
review requested due to automatic review settings
May 15, 2026 04:32
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
The PR's title and description say it deletes a single unused field (nativeCodeJITInfoToken) from DebuggerIPCE_JITFuncData, but the actual diff is a much larger reshape: the legacy DebuggerIPCE_* IPC structs (FuncData, JITFuncData, STRData) are renamed to Debugger_* and moved/restructured, the DAC Debugger_STRData now stores ctx/rd as CORDB_ADDRESS pointers into dbi-allocated buffers, Frame::GetStubFrameType() is added so GetInternalFrameType can replace its old transition/interception heuristics, and the cDAC gains real implementations of GetCountOfInternalFrames/EnumerateInternalFrames plus a new IStackWalk.GetFrames/IsExceptionHandlingHelperInlinedCallFrame/GetDebuggerEvalData surface (with tests and contract docs). The PR description significantly understates the scope of changes.
Changes:
  • Rename and restructure the dbi/DAC stack frame IPC structs and switch Debugger_STRData::ctx/rd to caller-allocated buffers referenced by CORDB_ADDRESS.
  • Add Frame::GetStubFrameType() polymorphic dispatch and rewrite DacDbiInterfaceImpl::GetInternalFrameType on top of it.
  • Add cDAC IStackWalk.GetFrames/IsExceptionHandlingHelperInlinedCallFrame/GetDebuggerEvalData and use them to implement GetCountOfInternalFrames/EnumerateInternalFrames, with new mock infrastructure and tests.
Show a summary per file
FileDescription
src/coreclr/debug/inc/dbgipcevents.hRemoves legacy DebuggerIPCE_FuncData/JITFuncData/STRData definitions (now defined in dacdbistructures.h).
src/coreclr/debug/inc/dacdbistructures.hAdds renamed Debugger_FuncData/Debugger_JITFuncData/Debugger_STRData with ctx/rd as CORDB_ADDRESS.
src/coreclr/debug/inc/dacdbistructures.inlUpdates NativeCodeFunctionData ctor to take Debugger_JITFuncData*.
src/coreclr/debug/inc/dacdbiinterface.hRenames the IPC struct in interface signatures and comments.
src/coreclr/inc/dacdbi.idlRenames DebuggerIPCE_STRData to Debugger_STRData in IDL.
src/coreclr/debug/daccess/dacdbiimpl.hUpdates dacdbi impl signatures to renamed types.
src/coreclr/debug/daccess/dacdbiimplstackwalk.cppUpdates rename, switches to caller-allocated ctx/rd, rewrites GetInternalFrameType via GetStubFrameType(); leaves a duplicate pJITFuncData->enCVersion assignment.
src/coreclr/vm/frames.h / frames.cppAdds Frame::StubFrameType enum, virtual GetStubFrameType_Impl per subclass, and dispatch.
src/coreclr/vm/datadescriptor/datadescriptor.incExposes DebuggerEval::m_methodToken/m_pAssembly to the cDAC data descriptor.
src/coreclr/debug/ee/debugger.h / debugger.cppAdds m_pAssembly to DebuggerEval and initializes it.
src/coreclr/debug/di/rsthread.cpp / rsstackwalk.cpp / rspriv.hUpdates dbi-side rename and allocates DT_CONTEXT/DebuggerREGDISPLAY for the new Debugger_STRData protocol.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStackWalk.csAdds InternalFrameType, StackFrameData, DebuggerEvalData, and three new IStackWalk methods.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/StackWalk_1.csImplements GetFrames, IsExceptionHandlingHelperInlinedCallFrame, GetDebuggerEvalData.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.csAdds GetInternalFrameType/IsExceptionHandlingHelperInlinedCallFrame; the latter omits the FrameHasActiveCall check.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Thread_1.csAdds using System.Collections.Generic; (looks unused locally — only the using is shown changed).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/Frames/DebuggerEval.csReads new MethodToken/AssemblyPtr fields.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csDefines managed mirrors of the new Debugger_* structs and the EnumerateInternalFrames callback signature.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csProvides cDAC implementations of GetCountOfInternalFrames/EnumerateInternalFrames with DEBUG-only DAC cross-validation.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Frame.csNew mock Frame layouts and MockFrameBuilder helper.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Thread.csAdds a public Frame accessor on MockThread.
src/native/managed/cdac/tests/StackWalkTests.csNew tests for GetFrames, EH-helper ICF detection, and GetDebuggerEvalData.
docs/design/datacontracts/StackWalk.mdDocuments the new APIs and EH-helper marker constant.
Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 2
Comment thread....Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.cs
Outdated

Comment threadsrc/coreclr/debug/daccess/dacdbiimplstackwalk.cpp
Outdated

CopilotAI
review requested due to automatic review settings
May 15, 2026 04:39
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 25/25 changed files
  • Comments generated: 5
Comment threadsrc/coreclr/debug/inc/dbgipcevents.h
Comment threadsrc/coreclr/debug/daccess/dacdbiimplstackwalk.cpp
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
@rcj1
Potential fix for pull request finding
1c8ffb3
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 15, 2026 04:56
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 25/25 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Comment threadsrc/coreclr/debug/inc/dacdbistructures.inl
Outdated

Comment threadsrc/coreclr/debug/inc/dbgipcevents.h
@rcj1rcj1
changed the title
Delete unused nativeCodeJITInfoToken from DebuggerIPCE_JITFuncData[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 15, 2026
@rcj1rcj1
removed

NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
labels
May 15, 2026
@rcj1
rcj1
marked this pull request as ready for review
May 15, 2026 05:10
@rcj1
rcj1
requested review from
max-charlamb and noahfalkMay 15, 2026 05:10
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 1
Comment thread...t.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameHelpers.cs
@rcj1
Potential fix for pull request finding
b1f3049
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 16, 2026 03:59
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 0 new

This was referenced May 16, 2026

Closed


Open

@rcj1rcj1
changed the title
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames[cDAC] [WIP] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 18, 2026
@rcj1
rcj1
marked this pull request as draft
May 18, 2026 18:24
noahfalk
noahfalk
approved these changes
May 18, 2026
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good to me modulo a few comments inline
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Outdated

Comment threadsrc/coreclr/vm/frames.h
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Frame.cs
Outdated

@rcj1rcj1
changed the title
[cDAC] [WIP] implement EnumerateInternalFrames and GetCountOfInternalFrames[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 18, 2026
@rcj1
rcj1
marked this pull request as ready for review
May 18, 2026 23:03
CopilotAI
review requested due to automatic review settings
May 18, 2026 23:03
CopilotAI
reviewed
May 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
May 19, 2026

Closed

CopilotAI
review requested due to automatic review settings
May 19, 2026 04:48
CopilotAI
reviewed
May 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new
@rcj1rcj1
mentioned this pull request
May 19, 2026

Closed

@rcj1
rcj1
commented
May 19, 2026

Copy link


Copy Markdown

Contributor
/ba-g #128372
@rcj1
rcj1
merged commit fb7020f
into
mainMay 19, 2026

121 of 126 checks passed

@rcj1
rcj1
deleted the

copilot/add-dacdbi-getframes-api

branch
May 19, 2026 14:00
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 20, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 21, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@rcj1rcj1rcj1 left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@max-charlambmax-charlambAwaiting requested review from max-charlamb

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames - #128241
Merged
rcj1 merged 13 commits into
mainfrom 
copilot/add-dacdbi-getframes-api
May 19, 2026
Merged
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames#128241
rcj1 merged 13 commits into
mainfrom 
copilot/add-dacdbi-getframes-api
Conversation
CopilotAI
commented
May 15, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
New StackWalk cDAC APIs:
IEnumerable<StackFrameData>GetFrames(TargetPointerthreadPointer)=>thrownewNotImplementedException();boolIsExceptionHandlingHelperInlinedCallFrame(TargetPointerframeAddress)=>thrownewNotImplementedException();DebuggerEvalDataGetDebuggerEvalData(TargetPointerfuncEvalFrameAddress)=>thrownewNotImplementedException();
@rcj1
Implement DacDbi GetCountOfInternalFrames and EnumerateInternalFrames…
2185748
… in cDAC via new Thread_1.GetFrames
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotMay 15, 2026 02:21
@rcj1rcj1
added
the 
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
May 15, 2026
@rcj1rcj1
added
the 
NO-REVIEW
Experimental/testing PR, do NOT review it
label
May 15, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 15, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
review requested due to automatic review settings
May 15, 2026 04:32
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
The PR's title and description say it deletes a single unused field (nativeCodeJITInfoToken) from DebuggerIPCE_JITFuncData, but the actual diff is a much larger reshape: the legacy DebuggerIPCE_* IPC structs (FuncData, JITFuncData, STRData) are renamed to Debugger_* and moved/restructured, the DAC Debugger_STRData now stores ctx/rd as CORDB_ADDRESS pointers into dbi-allocated buffers, Frame::GetStubFrameType() is added so GetInternalFrameType can replace its old transition/interception heuristics, and the cDAC gains real implementations of GetCountOfInternalFrames/EnumerateInternalFrames plus a new IStackWalk.GetFrames/IsExceptionHandlingHelperInlinedCallFrame/GetDebuggerEvalData surface (with tests and contract docs). The PR description significantly understates the scope of changes.
Changes:
  • Rename and restructure the dbi/DAC stack frame IPC structs and switch Debugger_STRData::ctx/rd to caller-allocated buffers referenced by CORDB_ADDRESS.
  • Add Frame::GetStubFrameType() polymorphic dispatch and rewrite DacDbiInterfaceImpl::GetInternalFrameType on top of it.
  • Add cDAC IStackWalk.GetFrames/IsExceptionHandlingHelperInlinedCallFrame/GetDebuggerEvalData and use them to implement GetCountOfInternalFrames/EnumerateInternalFrames, with new mock infrastructure and tests.
Show a summary per file
FileDescription
src/coreclr/debug/inc/dbgipcevents.hRemoves legacy DebuggerIPCE_FuncData/JITFuncData/STRData definitions (now defined in dacdbistructures.h).
src/coreclr/debug/inc/dacdbistructures.hAdds renamed Debugger_FuncData/Debugger_JITFuncData/Debugger_STRData with ctx/rd as CORDB_ADDRESS.
src/coreclr/debug/inc/dacdbistructures.inlUpdates NativeCodeFunctionData ctor to take Debugger_JITFuncData*.
src/coreclr/debug/inc/dacdbiinterface.hRenames the IPC struct in interface signatures and comments.
src/coreclr/inc/dacdbi.idlRenames DebuggerIPCE_STRData to Debugger_STRData in IDL.
src/coreclr/debug/daccess/dacdbiimpl.hUpdates dacdbi impl signatures to renamed types.
src/coreclr/debug/daccess/dacdbiimplstackwalk.cppUpdates rename, switches to caller-allocated ctx/rd, rewrites GetInternalFrameType via GetStubFrameType(); leaves a duplicate pJITFuncData->enCVersion assignment.
src/coreclr/vm/frames.h / frames.cppAdds Frame::StubFrameType enum, virtual GetStubFrameType_Impl per subclass, and dispatch.
src/coreclr/vm/datadescriptor/datadescriptor.incExposes DebuggerEval::m_methodToken/m_pAssembly to the cDAC data descriptor.
src/coreclr/debug/ee/debugger.h / debugger.cppAdds m_pAssembly to DebuggerEval and initializes it.
src/coreclr/debug/di/rsthread.cpp / rsstackwalk.cpp / rspriv.hUpdates dbi-side rename and allocates DT_CONTEXT/DebuggerREGDISPLAY for the new Debugger_STRData protocol.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStackWalk.csAdds InternalFrameType, StackFrameData, DebuggerEvalData, and three new IStackWalk methods.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/StackWalk_1.csImplements GetFrames, IsExceptionHandlingHelperInlinedCallFrame, GetDebuggerEvalData.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.csAdds GetInternalFrameType/IsExceptionHandlingHelperInlinedCallFrame; the latter omits the FrameHasActiveCall check.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Thread_1.csAdds using System.Collections.Generic; (looks unused locally — only the using is shown changed).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/Frames/DebuggerEval.csReads new MethodToken/AssemblyPtr fields.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csDefines managed mirrors of the new Debugger_* structs and the EnumerateInternalFrames callback signature.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csProvides cDAC implementations of GetCountOfInternalFrames/EnumerateInternalFrames with DEBUG-only DAC cross-validation.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Frame.csNew mock Frame layouts and MockFrameBuilder helper.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Thread.csAdds a public Frame accessor on MockThread.
src/native/managed/cdac/tests/StackWalkTests.csNew tests for GetFrames, EH-helper ICF detection, and GetDebuggerEvalData.
docs/design/datacontracts/StackWalk.mdDocuments the new APIs and EH-helper marker constant.
Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 2
Comment thread....Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.cs
Outdated

Comment threadsrc/coreclr/debug/daccess/dacdbiimplstackwalk.cpp
Outdated

CopilotAI
review requested due to automatic review settings
May 15, 2026 04:39
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 25/25 changed files
  • Comments generated: 5
Comment threadsrc/coreclr/debug/inc/dbgipcevents.h
Comment threadsrc/coreclr/debug/daccess/dacdbiimplstackwalk.cpp
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
@rcj1
Potential fix for pull request finding
1c8ffb3
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 15, 2026 04:56
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 25/25 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Comment threadsrc/coreclr/debug/inc/dacdbistructures.inl
Outdated

Comment threadsrc/coreclr/debug/inc/dbgipcevents.h
@rcj1rcj1
changed the title
Delete unused nativeCodeJITInfoToken from DebuggerIPCE_JITFuncData[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 15, 2026
@rcj1rcj1
removed

NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
labels
May 15, 2026
@rcj1
rcj1
marked this pull request as ready for review
May 15, 2026 05:10
@rcj1
rcj1
requested review from
max-charlamb and noahfalkMay 15, 2026 05:10
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 1
Comment thread...t.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameHelpers.cs
@rcj1
Potential fix for pull request finding
b1f3049
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 16, 2026 03:59
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 0 new

This was referenced May 16, 2026

Closed


Open

@rcj1rcj1
changed the title
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames[cDAC] [WIP] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 18, 2026
@rcj1
rcj1
marked this pull request as draft
May 18, 2026 18:24
noahfalk
noahfalk
approved these changes
May 18, 2026
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good to me modulo a few comments inline
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Outdated

Comment threadsrc/coreclr/vm/frames.h
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Frame.cs
Outdated

@rcj1rcj1
changed the title
[cDAC] [WIP] implement EnumerateInternalFrames and GetCountOfInternalFrames[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 18, 2026
@rcj1
rcj1
marked this pull request as ready for review
May 18, 2026 23:03
CopilotAI
review requested due to automatic review settings
May 18, 2026 23:03
CopilotAI
reviewed
May 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
May 19, 2026

Closed

CopilotAI
review requested due to automatic review settings
May 19, 2026 04:48
CopilotAI
reviewed
May 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new
@rcj1rcj1
mentioned this pull request
May 19, 2026

Closed

@rcj1
rcj1
commented
May 19, 2026

Copy link


Copy Markdown

Contributor
/ba-g #128372
@rcj1
rcj1
merged commit fb7020f
into
mainMay 19, 2026

121 of 126 checks passed

@rcj1
rcj1
deleted the

copilot/add-dacdbi-getframes-api

branch
May 19, 2026 14:00
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 20, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 21, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@rcj1rcj1rcj1 left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@max-charlambmax-charlambAwaiting requested review from max-charlamb

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames - #128241
Merged
rcj1 merged 13 commits into
mainfrom 
copilot/add-dacdbi-getframes-api
May 19, 2026
Merged
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames#128241
rcj1 merged 13 commits into
mainfrom 
copilot/add-dacdbi-getframes-api
Conversation
CopilotAI
commented
May 15, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
New StackWalk cDAC APIs:
IEnumerable<StackFrameData>GetFrames(TargetPointerthreadPointer)=>thrownewNotImplementedException();boolIsExceptionHandlingHelperInlinedCallFrame(TargetPointerframeAddress)=>thrownewNotImplementedException();DebuggerEvalDataGetDebuggerEvalData(TargetPointerfuncEvalFrameAddress)=>thrownewNotImplementedException();
@rcj1
Implement DacDbi GetCountOfInternalFrames and EnumerateInternalFrames…
2185748
… in cDAC via new Thread_1.GetFrames
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotMay 15, 2026 02:21
@rcj1rcj1
added
the 
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
May 15, 2026
@rcj1rcj1
added
the 
NO-REVIEW
Experimental/testing PR, do NOT review it
label
May 15, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 15, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
review requested due to automatic review settings
May 15, 2026 04:32
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
The PR's title and description say it deletes a single unused field (nativeCodeJITInfoToken) from DebuggerIPCE_JITFuncData, but the actual diff is a much larger reshape: the legacy DebuggerIPCE_* IPC structs (FuncData, JITFuncData, STRData) are renamed to Debugger_* and moved/restructured, the DAC Debugger_STRData now stores ctx/rd as CORDB_ADDRESS pointers into dbi-allocated buffers, Frame::GetStubFrameType() is added so GetInternalFrameType can replace its old transition/interception heuristics, and the cDAC gains real implementations of GetCountOfInternalFrames/EnumerateInternalFrames plus a new IStackWalk.GetFrames/IsExceptionHandlingHelperInlinedCallFrame/GetDebuggerEvalData surface (with tests and contract docs). The PR description significantly understates the scope of changes.
Changes:
  • Rename and restructure the dbi/DAC stack frame IPC structs and switch Debugger_STRData::ctx/rd to caller-allocated buffers referenced by CORDB_ADDRESS.
  • Add Frame::GetStubFrameType() polymorphic dispatch and rewrite DacDbiInterfaceImpl::GetInternalFrameType on top of it.
  • Add cDAC IStackWalk.GetFrames/IsExceptionHandlingHelperInlinedCallFrame/GetDebuggerEvalData and use them to implement GetCountOfInternalFrames/EnumerateInternalFrames, with new mock infrastructure and tests.
Show a summary per file
FileDescription
src/coreclr/debug/inc/dbgipcevents.hRemoves legacy DebuggerIPCE_FuncData/JITFuncData/STRData definitions (now defined in dacdbistructures.h).
src/coreclr/debug/inc/dacdbistructures.hAdds renamed Debugger_FuncData/Debugger_JITFuncData/Debugger_STRData with ctx/rd as CORDB_ADDRESS.
src/coreclr/debug/inc/dacdbistructures.inlUpdates NativeCodeFunctionData ctor to take Debugger_JITFuncData*.
src/coreclr/debug/inc/dacdbiinterface.hRenames the IPC struct in interface signatures and comments.
src/coreclr/inc/dacdbi.idlRenames DebuggerIPCE_STRData to Debugger_STRData in IDL.
src/coreclr/debug/daccess/dacdbiimpl.hUpdates dacdbi impl signatures to renamed types.
src/coreclr/debug/daccess/dacdbiimplstackwalk.cppUpdates rename, switches to caller-allocated ctx/rd, rewrites GetInternalFrameType via GetStubFrameType(); leaves a duplicate pJITFuncData->enCVersion assignment.
src/coreclr/vm/frames.h / frames.cppAdds Frame::StubFrameType enum, virtual GetStubFrameType_Impl per subclass, and dispatch.
src/coreclr/vm/datadescriptor/datadescriptor.incExposes DebuggerEval::m_methodToken/m_pAssembly to the cDAC data descriptor.
src/coreclr/debug/ee/debugger.h / debugger.cppAdds m_pAssembly to DebuggerEval and initializes it.
src/coreclr/debug/di/rsthread.cpp / rsstackwalk.cpp / rspriv.hUpdates dbi-side rename and allocates DT_CONTEXT/DebuggerREGDISPLAY for the new Debugger_STRData protocol.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStackWalk.csAdds InternalFrameType, StackFrameData, DebuggerEvalData, and three new IStackWalk methods.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/StackWalk_1.csImplements GetFrames, IsExceptionHandlingHelperInlinedCallFrame, GetDebuggerEvalData.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.csAdds GetInternalFrameType/IsExceptionHandlingHelperInlinedCallFrame; the latter omits the FrameHasActiveCall check.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Thread_1.csAdds using System.Collections.Generic; (looks unused locally — only the using is shown changed).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/Frames/DebuggerEval.csReads new MethodToken/AssemblyPtr fields.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csDefines managed mirrors of the new Debugger_* structs and the EnumerateInternalFrames callback signature.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csProvides cDAC implementations of GetCountOfInternalFrames/EnumerateInternalFrames with DEBUG-only DAC cross-validation.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Frame.csNew mock Frame layouts and MockFrameBuilder helper.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Thread.csAdds a public Frame accessor on MockThread.
src/native/managed/cdac/tests/StackWalkTests.csNew tests for GetFrames, EH-helper ICF detection, and GetDebuggerEvalData.
docs/design/datacontracts/StackWalk.mdDocuments the new APIs and EH-helper marker constant.
Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 2
Comment thread....Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.cs
Outdated

Comment threadsrc/coreclr/debug/daccess/dacdbiimplstackwalk.cpp
Outdated

CopilotAI
review requested due to automatic review settings
May 15, 2026 04:39
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 25/25 changed files
  • Comments generated: 5
Comment threadsrc/coreclr/debug/inc/dbgipcevents.h
Comment threadsrc/coreclr/debug/daccess/dacdbiimplstackwalk.cpp
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
@rcj1
Potential fix for pull request finding
1c8ffb3
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 15, 2026 04:56
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 25/25 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Comment threadsrc/coreclr/debug/inc/dacdbistructures.inl
Outdated

Comment threadsrc/coreclr/debug/inc/dbgipcevents.h
@rcj1rcj1
changed the title
Delete unused nativeCodeJITInfoToken from DebuggerIPCE_JITFuncData[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 15, 2026
@rcj1rcj1
removed

NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
labels
May 15, 2026
@rcj1
rcj1
marked this pull request as ready for review
May 15, 2026 05:10
@rcj1
rcj1
requested review from
max-charlamb and noahfalkMay 15, 2026 05:10
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 1
Comment thread...t.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameHelpers.cs
@rcj1
Potential fix for pull request finding
b1f3049
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 16, 2026 03:59
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 0 new

This was referenced May 16, 2026

Closed


Open

@rcj1rcj1
changed the title
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames[cDAC] [WIP] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 18, 2026
@rcj1
rcj1
marked this pull request as draft
May 18, 2026 18:24
noahfalk
noahfalk
approved these changes
May 18, 2026
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good to me modulo a few comments inline
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Outdated

Comment threadsrc/coreclr/vm/frames.h
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Frame.cs
Outdated

@rcj1rcj1
changed the title
[cDAC] [WIP] implement EnumerateInternalFrames and GetCountOfInternalFrames[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 18, 2026
@rcj1
rcj1
marked this pull request as ready for review
May 18, 2026 23:03
CopilotAI
review requested due to automatic review settings
May 18, 2026 23:03
CopilotAI
reviewed
May 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
May 19, 2026

Closed

CopilotAI
review requested due to automatic review settings
May 19, 2026 04:48
CopilotAI
reviewed
May 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new
@rcj1rcj1
mentioned this pull request
May 19, 2026

Closed

@rcj1
rcj1
commented
May 19, 2026

Copy link


Copy Markdown

Contributor
/ba-g #128372
@rcj1
rcj1
merged commit fb7020f
into
mainMay 19, 2026

121 of 126 checks passed

@rcj1
rcj1
deleted the

copilot/add-dacdbi-getframes-api

branch
May 19, 2026 14:00
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 20, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 21, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@rcj1rcj1rcj1 left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@max-charlambmax-charlambAwaiting requested review from max-charlamb

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames - #128241
Merged
rcj1 merged 13 commits into
mainfrom 
copilot/add-dacdbi-getframes-api
May 19, 2026
Merged
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames#128241
rcj1 merged 13 commits into
mainfrom 
copilot/add-dacdbi-getframes-api
Conversation
CopilotAI
commented
May 15, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
New StackWalk cDAC APIs:
IEnumerable<StackFrameData>GetFrames(TargetPointerthreadPointer)=>thrownewNotImplementedException();boolIsExceptionHandlingHelperInlinedCallFrame(TargetPointerframeAddress)=>thrownewNotImplementedException();DebuggerEvalDataGetDebuggerEvalData(TargetPointerfuncEvalFrameAddress)=>thrownewNotImplementedException();
@rcj1
Implement DacDbi GetCountOfInternalFrames and EnumerateInternalFrames…
2185748
… in cDAC via new Thread_1.GetFrames
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotMay 15, 2026 02:21
@rcj1rcj1
added
the 
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
May 15, 2026
@rcj1rcj1
added
the 
NO-REVIEW
Experimental/testing PR, do NOT review it
label
May 15, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 15, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
review requested due to automatic review settings
May 15, 2026 04:32
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
The PR's title and description say it deletes a single unused field (nativeCodeJITInfoToken) from DebuggerIPCE_JITFuncData, but the actual diff is a much larger reshape: the legacy DebuggerIPCE_* IPC structs (FuncData, JITFuncData, STRData) are renamed to Debugger_* and moved/restructured, the DAC Debugger_STRData now stores ctx/rd as CORDB_ADDRESS pointers into dbi-allocated buffers, Frame::GetStubFrameType() is added so GetInternalFrameType can replace its old transition/interception heuristics, and the cDAC gains real implementations of GetCountOfInternalFrames/EnumerateInternalFrames plus a new IStackWalk.GetFrames/IsExceptionHandlingHelperInlinedCallFrame/GetDebuggerEvalData surface (with tests and contract docs). The PR description significantly understates the scope of changes.
Changes:
  • Rename and restructure the dbi/DAC stack frame IPC structs and switch Debugger_STRData::ctx/rd to caller-allocated buffers referenced by CORDB_ADDRESS.
  • Add Frame::GetStubFrameType() polymorphic dispatch and rewrite DacDbiInterfaceImpl::GetInternalFrameType on top of it.
  • Add cDAC IStackWalk.GetFrames/IsExceptionHandlingHelperInlinedCallFrame/GetDebuggerEvalData and use them to implement GetCountOfInternalFrames/EnumerateInternalFrames, with new mock infrastructure and tests.
Show a summary per file
FileDescription
src/coreclr/debug/inc/dbgipcevents.hRemoves legacy DebuggerIPCE_FuncData/JITFuncData/STRData definitions (now defined in dacdbistructures.h).
src/coreclr/debug/inc/dacdbistructures.hAdds renamed Debugger_FuncData/Debugger_JITFuncData/Debugger_STRData with ctx/rd as CORDB_ADDRESS.
src/coreclr/debug/inc/dacdbistructures.inlUpdates NativeCodeFunctionData ctor to take Debugger_JITFuncData*.
src/coreclr/debug/inc/dacdbiinterface.hRenames the IPC struct in interface signatures and comments.
src/coreclr/inc/dacdbi.idlRenames DebuggerIPCE_STRData to Debugger_STRData in IDL.
src/coreclr/debug/daccess/dacdbiimpl.hUpdates dacdbi impl signatures to renamed types.
src/coreclr/debug/daccess/dacdbiimplstackwalk.cppUpdates rename, switches to caller-allocated ctx/rd, rewrites GetInternalFrameType via GetStubFrameType(); leaves a duplicate pJITFuncData->enCVersion assignment.
src/coreclr/vm/frames.h / frames.cppAdds Frame::StubFrameType enum, virtual GetStubFrameType_Impl per subclass, and dispatch.
src/coreclr/vm/datadescriptor/datadescriptor.incExposes DebuggerEval::m_methodToken/m_pAssembly to the cDAC data descriptor.
src/coreclr/debug/ee/debugger.h / debugger.cppAdds m_pAssembly to DebuggerEval and initializes it.
src/coreclr/debug/di/rsthread.cpp / rsstackwalk.cpp / rspriv.hUpdates dbi-side rename and allocates DT_CONTEXT/DebuggerREGDISPLAY for the new Debugger_STRData protocol.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStackWalk.csAdds InternalFrameType, StackFrameData, DebuggerEvalData, and three new IStackWalk methods.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/StackWalk_1.csImplements GetFrames, IsExceptionHandlingHelperInlinedCallFrame, GetDebuggerEvalData.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.csAdds GetInternalFrameType/IsExceptionHandlingHelperInlinedCallFrame; the latter omits the FrameHasActiveCall check.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Thread_1.csAdds using System.Collections.Generic; (looks unused locally — only the using is shown changed).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/Frames/DebuggerEval.csReads new MethodToken/AssemblyPtr fields.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csDefines managed mirrors of the new Debugger_* structs and the EnumerateInternalFrames callback signature.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csProvides cDAC implementations of GetCountOfInternalFrames/EnumerateInternalFrames with DEBUG-only DAC cross-validation.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Frame.csNew mock Frame layouts and MockFrameBuilder helper.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Thread.csAdds a public Frame accessor on MockThread.
src/native/managed/cdac/tests/StackWalkTests.csNew tests for GetFrames, EH-helper ICF detection, and GetDebuggerEvalData.
docs/design/datacontracts/StackWalk.mdDocuments the new APIs and EH-helper marker constant.
Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 2
Comment thread....Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.cs
Outdated

Comment threadsrc/coreclr/debug/daccess/dacdbiimplstackwalk.cpp
Outdated

CopilotAI
review requested due to automatic review settings
May 15, 2026 04:39
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 25/25 changed files
  • Comments generated: 5
Comment threadsrc/coreclr/debug/inc/dbgipcevents.h
Comment threadsrc/coreclr/debug/daccess/dacdbiimplstackwalk.cpp
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
@rcj1
Potential fix for pull request finding
1c8ffb3
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 15, 2026 04:56
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 25/25 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Comment threadsrc/coreclr/debug/inc/dacdbistructures.inl
Outdated

Comment threadsrc/coreclr/debug/inc/dbgipcevents.h
@rcj1rcj1
changed the title
Delete unused nativeCodeJITInfoToken from DebuggerIPCE_JITFuncData[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 15, 2026
@rcj1rcj1
removed

NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
labels
May 15, 2026
@rcj1
rcj1
marked this pull request as ready for review
May 15, 2026 05:10
@rcj1
rcj1
requested review from
max-charlamb and noahfalkMay 15, 2026 05:10
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 1
Comment thread...t.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameHelpers.cs
@rcj1
Potential fix for pull request finding
b1f3049
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 16, 2026 03:59
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 0 new

This was referenced May 16, 2026

Closed


Open

@rcj1rcj1
changed the title
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames[cDAC] [WIP] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 18, 2026
@rcj1
rcj1
marked this pull request as draft
May 18, 2026 18:24
noahfalk
noahfalk
approved these changes
May 18, 2026
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good to me modulo a few comments inline
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Outdated

Comment threadsrc/coreclr/vm/frames.h
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Frame.cs
Outdated

@rcj1rcj1
changed the title
[cDAC] [WIP] implement EnumerateInternalFrames and GetCountOfInternalFrames[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 18, 2026
@rcj1
rcj1
marked this pull request as ready for review
May 18, 2026 23:03
CopilotAI
review requested due to automatic review settings
May 18, 2026 23:03
CopilotAI
reviewed
May 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
May 19, 2026

Closed

CopilotAI
review requested due to automatic review settings
May 19, 2026 04:48
CopilotAI
reviewed
May 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new
@rcj1rcj1
mentioned this pull request
May 19, 2026

Closed

@rcj1
rcj1
commented
May 19, 2026

Copy link


Copy Markdown

Contributor
/ba-g #128372
@rcj1
rcj1
merged commit fb7020f
into
mainMay 19, 2026

121 of 126 checks passed

@rcj1
rcj1
deleted the

copilot/add-dacdbi-getframes-api

branch
May 19, 2026 14:00
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 20, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 21, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@rcj1rcj1rcj1 left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@max-charlambmax-charlambAwaiting requested review from max-charlamb

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames - #128241
Merged
rcj1 merged 13 commits into
mainfrom 
copilot/add-dacdbi-getframes-api
May 19, 2026
Merged
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames#128241
rcj1 merged 13 commits into
mainfrom 
copilot/add-dacdbi-getframes-api
Conversation
CopilotAI
commented
May 15, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
New StackWalk cDAC APIs:
IEnumerable<StackFrameData>GetFrames(TargetPointerthreadPointer)=>thrownewNotImplementedException();boolIsExceptionHandlingHelperInlinedCallFrame(TargetPointerframeAddress)=>thrownewNotImplementedException();DebuggerEvalDataGetDebuggerEvalData(TargetPointerfuncEvalFrameAddress)=>thrownewNotImplementedException();
@rcj1
Implement DacDbi GetCountOfInternalFrames and EnumerateInternalFrames…
2185748
… in cDAC via new Thread_1.GetFrames
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotMay 15, 2026 02:21
@rcj1rcj1
added
the 
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
May 15, 2026
@rcj1rcj1
added
the 
NO-REVIEW
Experimental/testing PR, do NOT review it
label
May 15, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 15, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
review requested due to automatic review settings
May 15, 2026 04:32
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
The PR's title and description say it deletes a single unused field (nativeCodeJITInfoToken) from DebuggerIPCE_JITFuncData, but the actual diff is a much larger reshape: the legacy DebuggerIPCE_* IPC structs (FuncData, JITFuncData, STRData) are renamed to Debugger_* and moved/restructured, the DAC Debugger_STRData now stores ctx/rd as CORDB_ADDRESS pointers into dbi-allocated buffers, Frame::GetStubFrameType() is added so GetInternalFrameType can replace its old transition/interception heuristics, and the cDAC gains real implementations of GetCountOfInternalFrames/EnumerateInternalFrames plus a new IStackWalk.GetFrames/IsExceptionHandlingHelperInlinedCallFrame/GetDebuggerEvalData surface (with tests and contract docs). The PR description significantly understates the scope of changes.
Changes:
  • Rename and restructure the dbi/DAC stack frame IPC structs and switch Debugger_STRData::ctx/rd to caller-allocated buffers referenced by CORDB_ADDRESS.
  • Add Frame::GetStubFrameType() polymorphic dispatch and rewrite DacDbiInterfaceImpl::GetInternalFrameType on top of it.
  • Add cDAC IStackWalk.GetFrames/IsExceptionHandlingHelperInlinedCallFrame/GetDebuggerEvalData and use them to implement GetCountOfInternalFrames/EnumerateInternalFrames, with new mock infrastructure and tests.
Show a summary per file
FileDescription
src/coreclr/debug/inc/dbgipcevents.hRemoves legacy DebuggerIPCE_FuncData/JITFuncData/STRData definitions (now defined in dacdbistructures.h).
src/coreclr/debug/inc/dacdbistructures.hAdds renamed Debugger_FuncData/Debugger_JITFuncData/Debugger_STRData with ctx/rd as CORDB_ADDRESS.
src/coreclr/debug/inc/dacdbistructures.inlUpdates NativeCodeFunctionData ctor to take Debugger_JITFuncData*.
src/coreclr/debug/inc/dacdbiinterface.hRenames the IPC struct in interface signatures and comments.
src/coreclr/inc/dacdbi.idlRenames DebuggerIPCE_STRData to Debugger_STRData in IDL.
src/coreclr/debug/daccess/dacdbiimpl.hUpdates dacdbi impl signatures to renamed types.
src/coreclr/debug/daccess/dacdbiimplstackwalk.cppUpdates rename, switches to caller-allocated ctx/rd, rewrites GetInternalFrameType via GetStubFrameType(); leaves a duplicate pJITFuncData->enCVersion assignment.
src/coreclr/vm/frames.h / frames.cppAdds Frame::StubFrameType enum, virtual GetStubFrameType_Impl per subclass, and dispatch.
src/coreclr/vm/datadescriptor/datadescriptor.incExposes DebuggerEval::m_methodToken/m_pAssembly to the cDAC data descriptor.
src/coreclr/debug/ee/debugger.h / debugger.cppAdds m_pAssembly to DebuggerEval and initializes it.
src/coreclr/debug/di/rsthread.cpp / rsstackwalk.cpp / rspriv.hUpdates dbi-side rename and allocates DT_CONTEXT/DebuggerREGDISPLAY for the new Debugger_STRData protocol.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStackWalk.csAdds InternalFrameType, StackFrameData, DebuggerEvalData, and three new IStackWalk methods.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/StackWalk_1.csImplements GetFrames, IsExceptionHandlingHelperInlinedCallFrame, GetDebuggerEvalData.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.csAdds GetInternalFrameType/IsExceptionHandlingHelperInlinedCallFrame; the latter omits the FrameHasActiveCall check.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Thread_1.csAdds using System.Collections.Generic; (looks unused locally — only the using is shown changed).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/Frames/DebuggerEval.csReads new MethodToken/AssemblyPtr fields.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csDefines managed mirrors of the new Debugger_* structs and the EnumerateInternalFrames callback signature.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csProvides cDAC implementations of GetCountOfInternalFrames/EnumerateInternalFrames with DEBUG-only DAC cross-validation.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Frame.csNew mock Frame layouts and MockFrameBuilder helper.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Thread.csAdds a public Frame accessor on MockThread.
src/native/managed/cdac/tests/StackWalkTests.csNew tests for GetFrames, EH-helper ICF detection, and GetDebuggerEvalData.
docs/design/datacontracts/StackWalk.mdDocuments the new APIs and EH-helper marker constant.
Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 2
Comment thread....Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.cs
Outdated

Comment threadsrc/coreclr/debug/daccess/dacdbiimplstackwalk.cpp
Outdated

CopilotAI
review requested due to automatic review settings
May 15, 2026 04:39
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 25/25 changed files
  • Comments generated: 5
Comment threadsrc/coreclr/debug/inc/dbgipcevents.h
Comment threadsrc/coreclr/debug/daccess/dacdbiimplstackwalk.cpp
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
@rcj1
Potential fix for pull request finding
1c8ffb3
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 15, 2026 04:56
CopilotAI
reviewed
May 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 25/25 changed files
  • Comments generated: 3
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Comment threadsrc/coreclr/debug/inc/dacdbistructures.inl
Outdated

Comment threadsrc/coreclr/debug/inc/dbgipcevents.h
@rcj1rcj1
changed the title
Delete unused nativeCodeJITInfoToken from DebuggerIPCE_JITFuncData[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 15, 2026
@rcj1rcj1
removed

NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
labels
May 15, 2026
@rcj1
rcj1
marked this pull request as ready for review
May 15, 2026 05:10
@rcj1
rcj1
requested review from
max-charlamb and noahfalkMay 15, 2026 05:10
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 1
Comment thread...t.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameHelpers.cs
@rcj1
Potential fix for pull request finding
b1f3049
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
May 16, 2026 03:59
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 26/26 changed files
  • Comments generated: 0 new

This was referenced May 16, 2026

Closed


Open

@rcj1rcj1
changed the title
[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFrames[cDAC] [WIP] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 18, 2026
@rcj1
rcj1
marked this pull request as draft
May 18, 2026 18:24
noahfalk
noahfalk
approved these changes
May 18, 2026
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good to me modulo a few comments inline
Comment threadsrc/coreclr/debug/inc/dacdbistructures.h
Outdated

Comment threadsrc/coreclr/vm/frames.h
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Frame.cs
Outdated

@rcj1rcj1
changed the title
[cDAC] [WIP] implement EnumerateInternalFrames and GetCountOfInternalFrames[cDAC] implement EnumerateInternalFrames and GetCountOfInternalFramesMay 18, 2026
@rcj1
rcj1
marked this pull request as ready for review
May 18, 2026 23:03
CopilotAI
review requested due to automatic review settings
May 18, 2026 23:03
CopilotAI
reviewed
May 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new
@build-analysisbuild-analysisBot
mentioned this pull request
May 19, 2026

Closed

CopilotAI
review requested due to automatic review settings
May 19, 2026 04:48
CopilotAI
reviewed
May 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new
@rcj1rcj1
mentioned this pull request
May 19, 2026

Closed

@rcj1
rcj1
commented
May 19, 2026

Copy link


Copy Markdown

Contributor
/ba-g #128372
@rcj1
rcj1
merged commit fb7020f
into
mainMay 19, 2026

121 of 126 checks passed

@rcj1
rcj1
deleted the

copilot/add-dacdbi-getframes-api

branch
May 19, 2026 14:00
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 20, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 21, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@rcj1rcj1rcj1 left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@max-charlambmax-charlambAwaiting requested review from max-charlamb

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk