Cleanup some of the intrinsic fallback implementations to make it easier to add support for new types - #128454

Merged
tannergooding merged 6 commits into
dotnet:mainfrom
tannergooding:vector-shuffle
May 22, 2026
Merged

Cleanup some of the intrinsic fallback implementations to make it easier to add support for new types#128454
tannergooding merged 6 commits into
dotnet:mainfrom
tannergooding:vector-shuffle

Conversation

@tannergooding

@tannergoodingtannergooding commented May 21, 2026•
edited
Loading

Copy link
Copy Markdown
Member

This adds a couple helpers to the internal Scalar<T> type making it easier to centralize type classification and simplifies various implementations to use those, making it easier to add new types (char and Half) in the future.

It also simplifies the Shuffle/ShuffleNative implementation to go through a single centralized internal method, ensuring we don't have a bunch of complex logic unnecessarily duplicated and that all types are properly supported. This last part means that it adds the missing nint/nuint shuffle overloads which were approved as part of the general expansion to support those types. The two proposals (shuffle and nint/nuint) went up at similar times and we had done a blanket approval for the latter (across 3 proposals), so it was just missed.

The ref assembly sources had also been manually updated on a number of occasions, so this regenerates them (which also alphabetized some of the entries).

CopilotAI review requested due to automatic review settings May 21, 2026 15:23
@dotnet-policy-service

dotnet-policy-serviceBot commented May 21, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

CopilotAI reviewed May 21, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors several SIMD intrinsic fallback implementations to centralize scalar type classification (via Scalar<T>) and to de-duplicate Shuffle / ShuffleNative fallback logic across the Vector64/128/256/512 and Vector<T> APIs. It also regenerates the System.Numerics.Vectors ref source.

Changes:

  • Introduce Scalar<T>.IsSupported, IsUnsigned, and IsFloatingPoint helpers and update multiple intrinsic fallbacks to use them.
  • Consolidate Shuffle / ShuffleNative fallback implementations via shared generic helpers (per vector width) to reduce duplicated per-type code.
  • Regenerate System.Numerics.Vectors ref sources (mostly formatting/alphabetization).

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.csAdds centralized scalar type classification helpers and simplifies some scalar ops to reuse existing helpers.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.csUses Scalar<T> helpers for classification and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.csUses Scalar<T> helpers and consolidates Shuffle / ShuffleNative logic through shared helpers.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.csUses Scalar<T> helpers and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.csUses Scalar<T> helpers and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/ISimdVector_2.csRemoves an unused CodeAnalysis using.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/SimdVectorExtensions.csRemoves unused usings.
src/libraries/System.Private.CoreLib/src/System/Numerics/Vector.csReplaces repeated typeof(T) classification checks with Scalar<T> helpers in multiple ops.
src/libraries/System.Private.CoreLib/src/System/Numerics/Vector_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Numerics.Vectors/ref/System.Numerics.Vectors.csRegenerated ref source (primarily type name formatting / ordering).

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs Outdated
jozkee
jozkee reviewed May 21, 2026
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Numerics/Vector.cs
jozkee
jozkee approved these changes May 21, 2026
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
@tannergooding
tannergooding enabled auto-merge (squash) May 21, 2026 19:18
CopilotAI review requested due to automatic review settings May 21, 2026 20:11
CopilotAI reviewed May 21, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs Outdated
CopilotAI review requested due to automatic review settings May 21, 2026 21:14
CopilotAI reviewed May 21, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs Outdated
CopilotAI review requested due to automatic review settings May 21, 2026 21:23
CopilotAI reviewed May 21, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 6 comments.

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
@tannergooding
Fix indentation
4a756b9
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@tannergooding

tannergooding commented May 21, 2026

Copy link
Copy Markdown
MemberAuthor

Sometimes copilot suggestions are a space off and it just tries to correct itself after the fact -.-

Ended up fixing the indentation manually to be correct.

CopilotAI review requested due to automatic review settings May 22, 2026 03:29
CopilotAI reviewed May 22, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.cs
@tannergooding
tannergooding disabled auto-merge May 22, 2026 04:44
CopilotAI review requested due to automatic review settings May 22, 2026 05:49
CopilotAI reviewed May 22, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
@tannergooding
tannergooding enabled auto-merge (squash) May 22, 2026 06:27
@tannergooding

tannergooding commented May 22, 2026

Copy link
Copy Markdown
MemberAuthor

Figured out the mono interpreter failure. Will do a follow up PR to resolve the problem so that IsSupported can still be centralized, have undone that part of the change for getting the bigger simplification in.

@build-analysisbuild-analysisBot mentioned this pull request May 22, 2026
Open
3 tasks
@tannergooding
tannergooding merged commit d2161b7 into dotnet:mainMay 22, 2026
154 checks passed
@tannergooding
tannergooding deleted the vector-shuffle branch May 22, 2026 14:48
@dotnet-maestrodotnet-maestroBot mentioned this pull request May 23, 2026
Merged
@dotnet-milestone-botdotnet-milestone-botBot added this to the 11.0-preview6 milestone May 23, 2026
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jun 23, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tarekghtarekghtarekgh approved these changes
@jozkeejozkeejozkee approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-System.Runtime.Intrinsics

Projects

None yet

Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@tannergooding@tarekgh@jozkee
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Cleanup some of the intrinsic fallback implementations to make it easier to add support for new types - #128454
Merged
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:vector-shuffle
May 22, 2026
Merged
Cleanup some of the intrinsic fallback implementations to make it easier to add support for new types#128454
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:vector-shuffle
Conversation
@tannergooding
@tannergoodingtannergooding
commented
May 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This adds a couple helpers to the internal Scalar<T> type making it easier to centralize type classification and simplifies various implementations to use those, making it easier to add new types (char and Half) in the future.
It also simplifies the Shuffle/ShuffleNative implementation to go through a single centralized internal method, ensuring we don't have a bunch of complex logic unnecessarily duplicated and that all types are properly supported. This last part means that it adds the missing nint/nuint shuffle overloads which were approved as part of the general expansion to support those types. The two proposals (shuffle and nint/nuint) went up at similar times and we had done a blanket approval for the latter (across 3 proposals), so it was just missed.
The ref assembly sources had also been manually updated on a number of occasions, so this regenerates them (which also alphabetized some of the entries).
CopilotAI
review requested due to automatic review settings
May 21, 2026 15:23
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 21, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR refactors several SIMD intrinsic fallback implementations to centralize scalar type classification (via Scalar<T>) and to de-duplicate Shuffle / ShuffleNative fallback logic across the Vector64/128/256/512 and Vector<T> APIs. It also regenerates the System.Numerics.Vectors ref source.
Changes:
  • Introduce Scalar<T>.IsSupported, IsUnsigned, and IsFloatingPoint helpers and update multiple intrinsic fallbacks to use them.
  • Consolidate Shuffle / ShuffleNative fallback implementations via shared generic helpers (per vector width) to reduce duplicated per-type code.
  • Regenerate System.Numerics.Vectors ref sources (mostly formatting/alphabetization).
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.csAdds centralized scalar type classification helpers and simplifies some scalar ops to reuse existing helpers.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.csUses Scalar<T> helpers for classification and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.csUses Scalar<T> helpers and consolidates Shuffle / ShuffleNative logic through shared helpers.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.csUses Scalar<T> helpers and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.csUses Scalar<T> helpers and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/ISimdVector_2.csRemoves an unused CodeAnalysis using.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/SimdVectorExtensions.csRemoves unused usings.
src/libraries/System.Private.CoreLib/src/System/Numerics/Vector.csReplaces repeated typeof(T) classification checks with Scalar<T> helpers in multiple ops.
src/libraries/System.Private.CoreLib/src/System/Numerics/Vector_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Numerics.Vectors/ref/System.Numerics.Vectors.csRegenerated ref source (primarily type name formatting / ordering).
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Outdated

jozkee
jozkee
reviewed
May 21, 2026
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Numerics/Vector.cs
jozkee
jozkee
approved these changes
May 21, 2026
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
@tannergooding
tannergooding
enabled auto-merge (squash)
May 21, 2026 19:18
CopilotAI
review requested due to automatic review settings
May 21, 2026 20:11
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Outdated

CopilotAI
review requested due to automatic review settings
May 21, 2026 21:14
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Outdated

CopilotAI
review requested due to automatic review settings
May 21, 2026 21:23
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 6 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
@tannergooding
Fix indentation
4a756b9
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@tannergooding
tannergooding
commented
May 21, 2026

Copy link


Copy Markdown

MemberAuthor
Sometimes copilot suggestions are a space off and it just tries to correct itself after the fact -.-
Ended up fixing the indentation manually to be correct.
CopilotAI
review requested due to automatic review settings
May 22, 2026 03:29
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.cs
@tannergooding
tannergooding
disabled auto-merge
May 22, 2026 04:44
CopilotAI
review requested due to automatic review settings
May 22, 2026 05:49
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
@tannergooding
tannergooding
enabled auto-merge (squash)
May 22, 2026 06:27
@tannergooding
tannergooding
commented
May 22, 2026

Copy link


Copy Markdown

MemberAuthor
Figured out the mono interpreter failure. Will do a follow up PR to resolve the problem so that IsSupported can still be centralized, have undone that part of the change for getting the bigger simplification in.
@build-analysisbuild-analysisBot
mentioned this pull request
May 22, 2026

Open

3 tasks
@tannergooding
tannergooding
merged commit d2161b7
into
dotnet:mainMay 22, 2026

154 checks passed

@tannergooding
tannergooding
deleted the

vector-shuffle

branch
May 22, 2026 14:48
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 23, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 23, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tarekghtarekghtarekgh approved these changes
@jozkeejozkeejozkee approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-System.Runtime.Intrinsics

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@tannergooding@tarekgh@jozkee

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cleanup some of the intrinsic fallback implementations to make it easier to add support for new types - #128454
Merged
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:vector-shuffle
May 22, 2026
Merged
Cleanup some of the intrinsic fallback implementations to make it easier to add support for new types#128454
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:vector-shuffle
Conversation
@tannergooding
@tannergoodingtannergooding
commented
May 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This adds a couple helpers to the internal Scalar<T> type making it easier to centralize type classification and simplifies various implementations to use those, making it easier to add new types (char and Half) in the future.
It also simplifies the Shuffle/ShuffleNative implementation to go through a single centralized internal method, ensuring we don't have a bunch of complex logic unnecessarily duplicated and that all types are properly supported. This last part means that it adds the missing nint/nuint shuffle overloads which were approved as part of the general expansion to support those types. The two proposals (shuffle and nint/nuint) went up at similar times and we had done a blanket approval for the latter (across 3 proposals), so it was just missed.
The ref assembly sources had also been manually updated on a number of occasions, so this regenerates them (which also alphabetized some of the entries).
CopilotAI
review requested due to automatic review settings
May 21, 2026 15:23
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 21, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR refactors several SIMD intrinsic fallback implementations to centralize scalar type classification (via Scalar<T>) and to de-duplicate Shuffle / ShuffleNative fallback logic across the Vector64/128/256/512 and Vector<T> APIs. It also regenerates the System.Numerics.Vectors ref source.
Changes:
  • Introduce Scalar<T>.IsSupported, IsUnsigned, and IsFloatingPoint helpers and update multiple intrinsic fallbacks to use them.
  • Consolidate Shuffle / ShuffleNative fallback implementations via shared generic helpers (per vector width) to reduce duplicated per-type code.
  • Regenerate System.Numerics.Vectors ref sources (mostly formatting/alphabetization).
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.csAdds centralized scalar type classification helpers and simplifies some scalar ops to reuse existing helpers.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.csUses Scalar<T> helpers for classification and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.csUses Scalar<T> helpers and consolidates Shuffle / ShuffleNative logic through shared helpers.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.csUses Scalar<T> helpers and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.csUses Scalar<T> helpers and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/ISimdVector_2.csRemoves an unused CodeAnalysis using.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/SimdVectorExtensions.csRemoves unused usings.
src/libraries/System.Private.CoreLib/src/System/Numerics/Vector.csReplaces repeated typeof(T) classification checks with Scalar<T> helpers in multiple ops.
src/libraries/System.Private.CoreLib/src/System/Numerics/Vector_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Numerics.Vectors/ref/System.Numerics.Vectors.csRegenerated ref source (primarily type name formatting / ordering).
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Outdated

jozkee
jozkee
reviewed
May 21, 2026
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Numerics/Vector.cs
jozkee
jozkee
approved these changes
May 21, 2026
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
@tannergooding
tannergooding
enabled auto-merge (squash)
May 21, 2026 19:18
CopilotAI
review requested due to automatic review settings
May 21, 2026 20:11
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Outdated

CopilotAI
review requested due to automatic review settings
May 21, 2026 21:14
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Outdated

CopilotAI
review requested due to automatic review settings
May 21, 2026 21:23
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 6 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
@tannergooding
Fix indentation
4a756b9
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@tannergooding
tannergooding
commented
May 21, 2026

Copy link


Copy Markdown

MemberAuthor
Sometimes copilot suggestions are a space off and it just tries to correct itself after the fact -.-
Ended up fixing the indentation manually to be correct.
CopilotAI
review requested due to automatic review settings
May 22, 2026 03:29
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.cs
@tannergooding
tannergooding
disabled auto-merge
May 22, 2026 04:44
CopilotAI
review requested due to automatic review settings
May 22, 2026 05:49
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
@tannergooding
tannergooding
enabled auto-merge (squash)
May 22, 2026 06:27
@tannergooding
tannergooding
commented
May 22, 2026

Copy link


Copy Markdown

MemberAuthor
Figured out the mono interpreter failure. Will do a follow up PR to resolve the problem so that IsSupported can still be centralized, have undone that part of the change for getting the bigger simplification in.
@build-analysisbuild-analysisBot
mentioned this pull request
May 22, 2026

Open

3 tasks
@tannergooding
tannergooding
merged commit d2161b7
into
dotnet:mainMay 22, 2026

154 checks passed

@tannergooding
tannergooding
deleted the

vector-shuffle

branch
May 22, 2026 14:48
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 23, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 23, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tarekghtarekghtarekgh approved these changes
@jozkeejozkeejozkee approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-System.Runtime.Intrinsics

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@tannergooding@tarekgh@jozkee

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cleanup some of the intrinsic fallback implementations to make it easier to add support for new types - #128454
Merged
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:vector-shuffle
May 22, 2026
Merged
Cleanup some of the intrinsic fallback implementations to make it easier to add support for new types#128454
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:vector-shuffle
Conversation
@tannergooding
@tannergoodingtannergooding
commented
May 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This adds a couple helpers to the internal Scalar<T> type making it easier to centralize type classification and simplifies various implementations to use those, making it easier to add new types (char and Half) in the future.
It also simplifies the Shuffle/ShuffleNative implementation to go through a single centralized internal method, ensuring we don't have a bunch of complex logic unnecessarily duplicated and that all types are properly supported. This last part means that it adds the missing nint/nuint shuffle overloads which were approved as part of the general expansion to support those types. The two proposals (shuffle and nint/nuint) went up at similar times and we had done a blanket approval for the latter (across 3 proposals), so it was just missed.
The ref assembly sources had also been manually updated on a number of occasions, so this regenerates them (which also alphabetized some of the entries).
CopilotAI
review requested due to automatic review settings
May 21, 2026 15:23
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 21, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR refactors several SIMD intrinsic fallback implementations to centralize scalar type classification (via Scalar<T>) and to de-duplicate Shuffle / ShuffleNative fallback logic across the Vector64/128/256/512 and Vector<T> APIs. It also regenerates the System.Numerics.Vectors ref source.
Changes:
  • Introduce Scalar<T>.IsSupported, IsUnsigned, and IsFloatingPoint helpers and update multiple intrinsic fallbacks to use them.
  • Consolidate Shuffle / ShuffleNative fallback implementations via shared generic helpers (per vector width) to reduce duplicated per-type code.
  • Regenerate System.Numerics.Vectors ref sources (mostly formatting/alphabetization).
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.csAdds centralized scalar type classification helpers and simplifies some scalar ops to reuse existing helpers.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.csUses Scalar<T> helpers for classification and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.csUses Scalar<T> helpers and consolidates Shuffle / ShuffleNative logic through shared helpers.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.csUses Scalar<T> helpers and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.csUses Scalar<T> helpers and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/ISimdVector_2.csRemoves an unused CodeAnalysis using.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/SimdVectorExtensions.csRemoves unused usings.
src/libraries/System.Private.CoreLib/src/System/Numerics/Vector.csReplaces repeated typeof(T) classification checks with Scalar<T> helpers in multiple ops.
src/libraries/System.Private.CoreLib/src/System/Numerics/Vector_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Numerics.Vectors/ref/System.Numerics.Vectors.csRegenerated ref source (primarily type name formatting / ordering).
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Outdated

jozkee
jozkee
reviewed
May 21, 2026
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Numerics/Vector.cs
jozkee
jozkee
approved these changes
May 21, 2026
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
@tannergooding
tannergooding
enabled auto-merge (squash)
May 21, 2026 19:18
CopilotAI
review requested due to automatic review settings
May 21, 2026 20:11
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Outdated

CopilotAI
review requested due to automatic review settings
May 21, 2026 21:14
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Outdated

CopilotAI
review requested due to automatic review settings
May 21, 2026 21:23
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 6 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
@tannergooding
Fix indentation
4a756b9
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@tannergooding
tannergooding
commented
May 21, 2026

Copy link


Copy Markdown

MemberAuthor
Sometimes copilot suggestions are a space off and it just tries to correct itself after the fact -.-
Ended up fixing the indentation manually to be correct.
CopilotAI
review requested due to automatic review settings
May 22, 2026 03:29
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.cs
@tannergooding
tannergooding
disabled auto-merge
May 22, 2026 04:44
CopilotAI
review requested due to automatic review settings
May 22, 2026 05:49
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
@tannergooding
tannergooding
enabled auto-merge (squash)
May 22, 2026 06:27
@tannergooding
tannergooding
commented
May 22, 2026

Copy link


Copy Markdown

MemberAuthor
Figured out the mono interpreter failure. Will do a follow up PR to resolve the problem so that IsSupported can still be centralized, have undone that part of the change for getting the bigger simplification in.
@build-analysisbuild-analysisBot
mentioned this pull request
May 22, 2026

Open

3 tasks
@tannergooding
tannergooding
merged commit d2161b7
into
dotnet:mainMay 22, 2026

154 checks passed

@tannergooding
tannergooding
deleted the

vector-shuffle

branch
May 22, 2026 14:48
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 23, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 23, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tarekghtarekghtarekgh approved these changes
@jozkeejozkeejozkee approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-System.Runtime.Intrinsics

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@tannergooding@tarekgh@jozkee

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Cleanup some of the intrinsic fallback implementations to make it easier to add support for new types - #128454
Merged
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:vector-shuffle
May 22, 2026
Merged
Cleanup some of the intrinsic fallback implementations to make it easier to add support for new types#128454
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:vector-shuffle
Conversation
@tannergooding
@tannergoodingtannergooding
commented
May 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This adds a couple helpers to the internal Scalar<T> type making it easier to centralize type classification and simplifies various implementations to use those, making it easier to add new types (char and Half) in the future.
It also simplifies the Shuffle/ShuffleNative implementation to go through a single centralized internal method, ensuring we don't have a bunch of complex logic unnecessarily duplicated and that all types are properly supported. This last part means that it adds the missing nint/nuint shuffle overloads which were approved as part of the general expansion to support those types. The two proposals (shuffle and nint/nuint) went up at similar times and we had done a blanket approval for the latter (across 3 proposals), so it was just missed.
The ref assembly sources had also been manually updated on a number of occasions, so this regenerates them (which also alphabetized some of the entries).
CopilotAI
review requested due to automatic review settings
May 21, 2026 15:23
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 21, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR refactors several SIMD intrinsic fallback implementations to centralize scalar type classification (via Scalar<T>) and to de-duplicate Shuffle / ShuffleNative fallback logic across the Vector64/128/256/512 and Vector<T> APIs. It also regenerates the System.Numerics.Vectors ref source.
Changes:
  • Introduce Scalar<T>.IsSupported, IsUnsigned, and IsFloatingPoint helpers and update multiple intrinsic fallbacks to use them.
  • Consolidate Shuffle / ShuffleNative fallback implementations via shared generic helpers (per vector width) to reduce duplicated per-type code.
  • Regenerate System.Numerics.Vectors ref sources (mostly formatting/alphabetization).
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.csAdds centralized scalar type classification helpers and simplifies some scalar ops to reuse existing helpers.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.csUses Scalar<T> helpers for classification and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.csUses Scalar<T> helpers and consolidates Shuffle / ShuffleNative logic through shared helpers.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.csUses Scalar<T> helpers and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.csUses Scalar<T> helpers and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/ISimdVector_2.csRemoves an unused CodeAnalysis using.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/SimdVectorExtensions.csRemoves unused usings.
src/libraries/System.Private.CoreLib/src/System/Numerics/Vector.csReplaces repeated typeof(T) classification checks with Scalar<T> helpers in multiple ops.
src/libraries/System.Private.CoreLib/src/System/Numerics/Vector_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Numerics.Vectors/ref/System.Numerics.Vectors.csRegenerated ref source (primarily type name formatting / ordering).
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Outdated

jozkee
jozkee
reviewed
May 21, 2026
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Numerics/Vector.cs
jozkee
jozkee
approved these changes
May 21, 2026
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
@tannergooding
tannergooding
enabled auto-merge (squash)
May 21, 2026 19:18
CopilotAI
review requested due to automatic review settings
May 21, 2026 20:11
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Outdated

CopilotAI
review requested due to automatic review settings
May 21, 2026 21:14
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Outdated

CopilotAI
review requested due to automatic review settings
May 21, 2026 21:23
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 6 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
@tannergooding
Fix indentation
4a756b9
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@tannergooding
tannergooding
commented
May 21, 2026

Copy link


Copy Markdown

MemberAuthor
Sometimes copilot suggestions are a space off and it just tries to correct itself after the fact -.-
Ended up fixing the indentation manually to be correct.
CopilotAI
review requested due to automatic review settings
May 22, 2026 03:29
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.cs
@tannergooding
tannergooding
disabled auto-merge
May 22, 2026 04:44
CopilotAI
review requested due to automatic review settings
May 22, 2026 05:49
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
@tannergooding
tannergooding
enabled auto-merge (squash)
May 22, 2026 06:27
@tannergooding
tannergooding
commented
May 22, 2026

Copy link


Copy Markdown

MemberAuthor
Figured out the mono interpreter failure. Will do a follow up PR to resolve the problem so that IsSupported can still be centralized, have undone that part of the change for getting the bigger simplification in.
@build-analysisbuild-analysisBot
mentioned this pull request
May 22, 2026

Open

3 tasks
@tannergooding
tannergooding
merged commit d2161b7
into
dotnet:mainMay 22, 2026

154 checks passed

@tannergooding
tannergooding
deleted the

vector-shuffle

branch
May 22, 2026 14:48
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 23, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 23, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tarekghtarekghtarekgh approved these changes
@jozkeejozkeejozkee approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-System.Runtime.Intrinsics

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@tannergooding@tarekgh@jozkee

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cleanup some of the intrinsic fallback implementations to make it easier to add support for new types - #128454
Merged
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:vector-shuffle
May 22, 2026
Merged
Cleanup some of the intrinsic fallback implementations to make it easier to add support for new types#128454
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:vector-shuffle
Conversation
@tannergooding
@tannergoodingtannergooding
commented
May 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This adds a couple helpers to the internal Scalar<T> type making it easier to centralize type classification and simplifies various implementations to use those, making it easier to add new types (char and Half) in the future.
It also simplifies the Shuffle/ShuffleNative implementation to go through a single centralized internal method, ensuring we don't have a bunch of complex logic unnecessarily duplicated and that all types are properly supported. This last part means that it adds the missing nint/nuint shuffle overloads which were approved as part of the general expansion to support those types. The two proposals (shuffle and nint/nuint) went up at similar times and we had done a blanket approval for the latter (across 3 proposals), so it was just missed.
The ref assembly sources had also been manually updated on a number of occasions, so this regenerates them (which also alphabetized some of the entries).
CopilotAI
review requested due to automatic review settings
May 21, 2026 15:23
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 21, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR refactors several SIMD intrinsic fallback implementations to centralize scalar type classification (via Scalar<T>) and to de-duplicate Shuffle / ShuffleNative fallback logic across the Vector64/128/256/512 and Vector<T> APIs. It also regenerates the System.Numerics.Vectors ref source.
Changes:
  • Introduce Scalar<T>.IsSupported, IsUnsigned, and IsFloatingPoint helpers and update multiple intrinsic fallbacks to use them.
  • Consolidate Shuffle / ShuffleNative fallback implementations via shared generic helpers (per vector width) to reduce duplicated per-type code.
  • Regenerate System.Numerics.Vectors ref sources (mostly formatting/alphabetization).
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.csAdds centralized scalar type classification helpers and simplifies some scalar ops to reuse existing helpers.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.csUses Scalar<T> helpers for classification and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.csUses Scalar<T> helpers and consolidates Shuffle / ShuffleNative logic through shared helpers.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.csUses Scalar<T> helpers and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.csUses Scalar<T> helpers and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/ISimdVector_2.csRemoves an unused CodeAnalysis using.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/SimdVectorExtensions.csRemoves unused usings.
src/libraries/System.Private.CoreLib/src/System/Numerics/Vector.csReplaces repeated typeof(T) classification checks with Scalar<T> helpers in multiple ops.
src/libraries/System.Private.CoreLib/src/System/Numerics/Vector_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Numerics.Vectors/ref/System.Numerics.Vectors.csRegenerated ref source (primarily type name formatting / ordering).
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Outdated

jozkee
jozkee
reviewed
May 21, 2026
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Numerics/Vector.cs
jozkee
jozkee
approved these changes
May 21, 2026
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
@tannergooding
tannergooding
enabled auto-merge (squash)
May 21, 2026 19:18
CopilotAI
review requested due to automatic review settings
May 21, 2026 20:11
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Outdated

CopilotAI
review requested due to automatic review settings
May 21, 2026 21:14
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Outdated

CopilotAI
review requested due to automatic review settings
May 21, 2026 21:23
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 6 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
@tannergooding
Fix indentation
4a756b9
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@tannergooding
tannergooding
commented
May 21, 2026

Copy link


Copy Markdown

MemberAuthor
Sometimes copilot suggestions are a space off and it just tries to correct itself after the fact -.-
Ended up fixing the indentation manually to be correct.
CopilotAI
review requested due to automatic review settings
May 22, 2026 03:29
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.cs
@tannergooding
tannergooding
disabled auto-merge
May 22, 2026 04:44
CopilotAI
review requested due to automatic review settings
May 22, 2026 05:49
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
@tannergooding
tannergooding
enabled auto-merge (squash)
May 22, 2026 06:27
@tannergooding
tannergooding
commented
May 22, 2026

Copy link


Copy Markdown

MemberAuthor
Figured out the mono interpreter failure. Will do a follow up PR to resolve the problem so that IsSupported can still be centralized, have undone that part of the change for getting the bigger simplification in.
@build-analysisbuild-analysisBot
mentioned this pull request
May 22, 2026

Open

3 tasks
@tannergooding
tannergooding
merged commit d2161b7
into
dotnet:mainMay 22, 2026

154 checks passed

@tannergooding
tannergooding
deleted the

vector-shuffle

branch
May 22, 2026 14:48
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 23, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 23, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tarekghtarekghtarekgh approved these changes
@jozkeejozkeejozkee approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-System.Runtime.Intrinsics

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@tannergooding@tarekgh@jozkee

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cleanup some of the intrinsic fallback implementations to make it easier to add support for new types - #128454
Merged
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:vector-shuffle
May 22, 2026
Merged
Cleanup some of the intrinsic fallback implementations to make it easier to add support for new types#128454
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:vector-shuffle
Conversation
@tannergooding
@tannergoodingtannergooding
commented
May 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This adds a couple helpers to the internal Scalar<T> type making it easier to centralize type classification and simplifies various implementations to use those, making it easier to add new types (char and Half) in the future.
It also simplifies the Shuffle/ShuffleNative implementation to go through a single centralized internal method, ensuring we don't have a bunch of complex logic unnecessarily duplicated and that all types are properly supported. This last part means that it adds the missing nint/nuint shuffle overloads which were approved as part of the general expansion to support those types. The two proposals (shuffle and nint/nuint) went up at similar times and we had done a blanket approval for the latter (across 3 proposals), so it was just missed.
The ref assembly sources had also been manually updated on a number of occasions, so this regenerates them (which also alphabetized some of the entries).
CopilotAI
review requested due to automatic review settings
May 21, 2026 15:23
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 21, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR refactors several SIMD intrinsic fallback implementations to centralize scalar type classification (via Scalar<T>) and to de-duplicate Shuffle / ShuffleNative fallback logic across the Vector64/128/256/512 and Vector<T> APIs. It also regenerates the System.Numerics.Vectors ref source.
Changes:
  • Introduce Scalar<T>.IsSupported, IsUnsigned, and IsFloatingPoint helpers and update multiple intrinsic fallbacks to use them.
  • Consolidate Shuffle / ShuffleNative fallback implementations via shared generic helpers (per vector width) to reduce duplicated per-type code.
  • Regenerate System.Numerics.Vectors ref sources (mostly formatting/alphabetization).
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.csAdds centralized scalar type classification helpers and simplifies some scalar ops to reuse existing helpers.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.csUses Scalar<T> helpers for classification and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.csUses Scalar<T> helpers and consolidates Shuffle / ShuffleNative logic through shared helpers.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.csUses Scalar<T> helpers and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.csUses Scalar<T> helpers and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/ISimdVector_2.csRemoves an unused CodeAnalysis using.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/SimdVectorExtensions.csRemoves unused usings.
src/libraries/System.Private.CoreLib/src/System/Numerics/Vector.csReplaces repeated typeof(T) classification checks with Scalar<T> helpers in multiple ops.
src/libraries/System.Private.CoreLib/src/System/Numerics/Vector_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Numerics.Vectors/ref/System.Numerics.Vectors.csRegenerated ref source (primarily type name formatting / ordering).
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Outdated

jozkee
jozkee
reviewed
May 21, 2026
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Numerics/Vector.cs
jozkee
jozkee
approved these changes
May 21, 2026
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
@tannergooding
tannergooding
enabled auto-merge (squash)
May 21, 2026 19:18
CopilotAI
review requested due to automatic review settings
May 21, 2026 20:11
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Outdated

CopilotAI
review requested due to automatic review settings
May 21, 2026 21:14
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Outdated

CopilotAI
review requested due to automatic review settings
May 21, 2026 21:23
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 6 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
@tannergooding
Fix indentation
4a756b9
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@tannergooding
tannergooding
commented
May 21, 2026

Copy link


Copy Markdown

MemberAuthor
Sometimes copilot suggestions are a space off and it just tries to correct itself after the fact -.-
Ended up fixing the indentation manually to be correct.
CopilotAI
review requested due to automatic review settings
May 22, 2026 03:29
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.cs
@tannergooding
tannergooding
disabled auto-merge
May 22, 2026 04:44
CopilotAI
review requested due to automatic review settings
May 22, 2026 05:49
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
@tannergooding
tannergooding
enabled auto-merge (squash)
May 22, 2026 06:27
@tannergooding
tannergooding
commented
May 22, 2026

Copy link


Copy Markdown

MemberAuthor
Figured out the mono interpreter failure. Will do a follow up PR to resolve the problem so that IsSupported can still be centralized, have undone that part of the change for getting the bigger simplification in.
@build-analysisbuild-analysisBot
mentioned this pull request
May 22, 2026

Open

3 tasks
@tannergooding
tannergooding
merged commit d2161b7
into
dotnet:mainMay 22, 2026

154 checks passed

@tannergooding
tannergooding
deleted the

vector-shuffle

branch
May 22, 2026 14:48
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 23, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 23, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tarekghtarekghtarekgh approved these changes
@jozkeejozkeejozkee approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-System.Runtime.Intrinsics

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@tannergooding@tarekgh@jozkee

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Cleanup some of the intrinsic fallback implementations to make it easier to add support for new types - #128454
Merged
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:vector-shuffle
May 22, 2026
Merged
Cleanup some of the intrinsic fallback implementations to make it easier to add support for new types#128454
tannergooding merged 6 commits into
dotnet:mainfrom 
tannergooding:vector-shuffle
Conversation
@tannergooding
@tannergoodingtannergooding
commented
May 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This adds a couple helpers to the internal Scalar<T> type making it easier to centralize type classification and simplifies various implementations to use those, making it easier to add new types (char and Half) in the future.
It also simplifies the Shuffle/ShuffleNative implementation to go through a single centralized internal method, ensuring we don't have a bunch of complex logic unnecessarily duplicated and that all types are properly supported. This last part means that it adds the missing nint/nuint shuffle overloads which were approved as part of the general expansion to support those types. The two proposals (shuffle and nint/nuint) went up at similar times and we had done a blanket approval for the latter (across 3 proposals), so it was just missed.
The ref assembly sources had also been manually updated on a number of occasions, so this regenerates them (which also alphabetized some of the entries).
CopilotAI
review requested due to automatic review settings
May 21, 2026 15:23
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 21, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR refactors several SIMD intrinsic fallback implementations to centralize scalar type classification (via Scalar<T>) and to de-duplicate Shuffle / ShuffleNative fallback logic across the Vector64/128/256/512 and Vector<T> APIs. It also regenerates the System.Numerics.Vectors ref source.
Changes:
  • Introduce Scalar<T>.IsSupported, IsUnsigned, and IsFloatingPoint helpers and update multiple intrinsic fallbacks to use them.
  • Consolidate Shuffle / ShuffleNative fallback implementations via shared generic helpers (per vector width) to reduce duplicated per-type code.
  • Regenerate System.Numerics.Vectors ref sources (mostly formatting/alphabetization).
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.csAdds centralized scalar type classification helpers and simplifies some scalar ops to reuse existing helpers.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.csUses Scalar<T> helpers for classification and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.csUses Scalar<T> helpers and consolidates Shuffle / ShuffleNative logic through shared helpers.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.csUses Scalar<T> helpers and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.csUses Scalar<T> helpers and centralizes Shuffle / ShuffleNative fallback logic.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/ISimdVector_2.csRemoves an unused CodeAnalysis using.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/SimdVectorExtensions.csRemoves unused usings.
src/libraries/System.Private.CoreLib/src/System/Numerics/Vector.csReplaces repeated typeof(T) classification checks with Scalar<T> helpers in multiple ops.
src/libraries/System.Private.CoreLib/src/System/Numerics/Vector_1.csSwitches IsSupported to Scalar<T>.IsSupported.
src/libraries/System.Numerics.Vectors/ref/System.Numerics.Vectors.csRegenerated ref source (primarily type name formatting / ordering).
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Outdated

jozkee
jozkee
reviewed
May 21, 2026
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Numerics/Vector.cs
jozkee
jozkee
approved these changes
May 21, 2026
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
@tannergooding
tannergooding
enabled auto-merge (squash)
May 21, 2026 19:18
CopilotAI
review requested due to automatic review settings
May 21, 2026 20:11
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Outdated

CopilotAI
review requested due to automatic review settings
May 21, 2026 21:14
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Outdated

CopilotAI
review requested due to automatic review settings
May 21, 2026 21:23
CopilotAI
reviewed
May 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 6 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs
Outdated

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
@tannergooding
Fix indentation
4a756b9
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@tannergooding
tannergooding
commented
May 21, 2026

Copy link


Copy Markdown

MemberAuthor
Sometimes copilot suggestions are a space off and it just tries to correct itself after the fact -.-
Ended up fixing the indentation manually to be correct.
CopilotAI
review requested due to automatic review settings
May 22, 2026 03:29
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Scalar.cs
@tannergooding
tannergooding
disabled auto-merge
May 22, 2026 04:44
CopilotAI
review requested due to automatic review settings
May 22, 2026 05:49
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs
@tannergooding
tannergooding
enabled auto-merge (squash)
May 22, 2026 06:27
@tannergooding
tannergooding
commented
May 22, 2026

Copy link


Copy Markdown

MemberAuthor
Figured out the mono interpreter failure. Will do a follow up PR to resolve the problem so that IsSupported can still be centralized, have undone that part of the change for getting the bigger simplification in.
@build-analysisbuild-analysisBot
mentioned this pull request
May 22, 2026

Open

3 tasks
@tannergooding
tannergooding
merged commit d2161b7
into
dotnet:mainMay 22, 2026

154 checks passed

@tannergooding
tannergooding
deleted the

vector-shuffle

branch
May 22, 2026 14:48
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
May 23, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
May 23, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tarekghtarekghtarekgh approved these changes
@jozkeejozkeejozkee approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-System.Runtime.Intrinsics

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@tannergooding@tarekgh@jozkee