Uh oh!
There was an error while loading. Please reload this page.
[release/8.0-staging] [TestOnly] Fix NumberFormatInfoGroupSize test - #128579
Merged
tarekgh merged 2 commits intoJun 4, 2026
Merged
Conversation
* Fix NumberFormatInfoGroupSize test * Fix coding style
Contributor
There was a problem hiding this comment.
Pull request overview
This backport updates a System.Globalization test to tolerate platform globalization data differences for ur-IN number group sizes, matching the intent of the original main-branch fix.
Changes:
- Adds culture names and optional alternate expected group sizes to
NumberGroupSizes_TestData. - Updates the assertion to accept either primary or alternate expected values and include culture context in failure output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
Tagging subscribers to this area: @dotnet/area-system-globalization |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tarekgh
approved these changes
May 26, 2026
This was referenced May 26, 2026
Open
svick
commented
Jun 4, 2026
MemberAuthor
@jeffhandley Can you approve this test-only fix for servicing? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #120546 to release/8.0-staging
/cc @jeffhandley@tarekgh
Customer Impact
This test failed in CI on 9.0: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1431345&view=ms.vss-test-web.build-test-results-tab&runId=39820274&paneView=debug&resultId=132492.
Since the same test exists on 8.0, I think it should be fixed there as well.
Regression
Testing
Verified in main, and the failing test is occurring in release/9.0-staging as well.
Risk
Low. Test only, handling new data.